[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-10-10 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 30 mins 7 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=false -Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20161011.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20161011/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=true -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commo
 ns-daemon-20161011-native-src.tar.gz -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20161011-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20161011/lib 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 

Re: [VOTE] Release Apache Tomcat 6.0.46

2016-10-10 Thread Rémy Maucherat
2016-10-07 16:11 GMT+02:00 Violeta Georgieva :

> The proposed Apache Tomcat 6.0.46 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1099/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_46/
>
> The proposed 6.0.46 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 6.0.46 Stable
>
> Rémy


Re: [VOTE] Release Apache Tomcat 6.0.46

2016-10-10 Thread Violeta Georgieva
2016-10-07 17:11 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 6.0.46 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1099/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_46/
>
> The proposed 6.0.46 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 6.0.46 Stable

+1

>
> Regards,
> Violeta


[Bug 60196] isMandatory erroneously always set to true for JASPIC SAM

2016-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60196

--- Comment #2 from Arjan Tijms  ---
Thanks a lot for the quick fix!

ps. 

I added a CI target for Tomcat to the Java EE samples project
(https://github.com/javaee-samples/javaee7-samples.git)

After a git clone the JASPIC tests can be started using:

mvn clean install -pl "test-utils,util" -am
cd jaspic
mvn clean test -P tomcat-ci-managed

Tomcat versions from the Apache public and staging repositories can be tested.
It currently defaults to version 8.5.6, but another version can be used via the
-Dtomcat.version option. E.g.

mvn clean test -P tomcat-co-managed -Dtomcat.version=8.5.5

Note that for Tomcat the integration tests with EJB, JSF, JACC, etc are
automatically skipped.

The staged Tomcat 8.5.6 has a perfect test result btw, all tests pass. Very
impressive!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60232] New: HTTP/2 connector stuck when parsing big http header

2016-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60232

Bug ID: 60232
   Summary: HTTP/2 connector stuck when parsing big http header
   Product: Tomcat 8
   Version: 8.5.5
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: barney...@gmail.com

HTTP/2 connector of tomcat 8.5.5 is getting stuck (endless busy loop) when
parsing a big (e.g. 30kb) http header.

Steps to reproduce using apache-tomcat-8.5.5-windows-x86.zip on windows 7 (64)
and jre 1.8.0_102 (32):
1.) configure a https connector including http2 upgrade, e.g.







2.) Point Firefox to https://localhost:8443/, verify HTTP/2 is used using
Network View in Developer Tools
3.) For the verified request, use 'Edit and Resend' to add a big http header,
e.g.
X-Big-Header: 
and send that request
4.) The request never returns, and Windows Task Manager shows that tomcat's
java vm now fully uses one core
5.) Stacktrace of the stuck thread looks like this:

Name: https-openssl-apr-8443-exec-6
State: RUNNABLE
Total blocked: 0  Total waited: 1

Stack trace: 
org.apache.coyote.http2.HPackHuffman.decode(HPackHuffman.java:383)
org.apache.coyote.http2.HpackDecoder.readHuffmanString(HpackDecoder.java:215)
org.apache.coyote.http2.HpackDecoder.readHpackString(HpackDecoder.java:204)
org.apache.coyote.http2.HpackDecoder.readHeaderName(HpackDecoder.java:188)
org.apache.coyote.http2.HpackDecoder.decode(HpackDecoder.java:116)
org.apache.coyote.http2.Http2Parser.readHeaderBlock(Http2Parser.java:404)
org.apache.coyote.http2.Http2Parser.readHeadersFrame(Http2Parser.java:246)
org.apache.coyote.http2.Http2Parser.readFrame(Http2Parser.java:96)
org.apache.coyote.http2.Http2Parser.readFrame(Http2Parser.java:68)
org.apache.coyote.http2.Http2UpgradeHandler.upgradeDispatch(Http2UpgradeHandler.java:314)
org.apache.coyote.http11.upgrade.UpgradeProcessorInternal.dispatch(UpgradeProcessorInternal.java:54)
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:53)
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:802)
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun(AprEndpoint.java:2241)
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
   - locked org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper@cd6eb
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
java.lang.Thread.run(Thread.java:745)


In case you're wondering what the use-case for such big headers is: they
actually occur when using SPNEGO/Kerberos. The 'Negotiate'-Header can easily be
dozens of KB long.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1764106 - /tomcat/trunk/java/org/apache/coyote/http2/

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 14:24:54 2016
New Revision: 1764106

URL: http://svn.apache.org/viewvc?rev=1764106=rev
Log:
Reduce visibility as recommended by UCdetector
Remove unused code

Modified:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java
tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsLocal.java
tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsRemote.java
tomcat/trunk/java/org/apache/coyote/http2/Flags.java
tomcat/trunk/java/org/apache/coyote/http2/FrameType.java
tomcat/trunk/java/org/apache/coyote/http2/HeaderSink.java
tomcat/trunk/java/org/apache/coyote/http2/Hpack.java
tomcat/trunk/java/org/apache/coyote/http2/HpackDecoder.java
tomcat/trunk/java/org/apache/coyote/http2/HpackEncoder.java
tomcat/trunk/java/org/apache/coyote/http2/Http2Error.java
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/Setting.java
tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java
tomcat/trunk/java/org/apache/coyote/http2/StreamStateMachine.java

Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java?rev=1764106=1764105=1764106=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java Mon 
Oct 10 14:24:54 2016
@@ -23,7 +23,7 @@ import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
 import org.apache.tomcat.util.res.StringManager;
 
-public abstract class ConnectionSettingsBase {
+abstract class ConnectionSettingsBase {
 
 private final Log log = LogFactory.getLog(ConnectionSettingsBase.class);
 private final StringManager sm = 
StringManager.getManager(ConnectionSettingsBase.class);
@@ -31,25 +31,25 @@ public abstract class ConnectionSettings
 private final String connectionId;
 
 // Limits
-protected static final int MAX_WINDOW_SIZE = (1 << 31) - 1;
-protected static final int MIN_MAX_FRAME_SIZE = 1 << 14;
-protected static final int MAX_MAX_FRAME_SIZE = (1 << 24) - 1;
-protected static final long UNLIMITED = ((long)1 << 32); // Use the 
maximum possible
-protected static final int MAX_HEADER_TABLE_SIZE = 1 << 16;
+static final int MAX_WINDOW_SIZE = (1 << 31) - 1;
+static final int MIN_MAX_FRAME_SIZE = 1 << 14;
+static final int MAX_MAX_FRAME_SIZE = (1 << 24) - 1;
+static final long UNLIMITED = ((long)1 << 32); // Use the maximum possible
+static final int MAX_HEADER_TABLE_SIZE = 1 << 16;
 
 // Defaults
-protected static final int DEFAULT_HEADER_TABLE_SIZE = 4096;
-protected static final boolean DEFAULT_ENABLE_PUSH = true;
-protected static final long DEFAULT_MAX_CONCURRENT_STREAMS = UNLIMITED;
-protected static final int DEFAULT_INITIAL_WINDOW_SIZE = (1 << 16) - 1;
-protected static final int DEFAULT_MAX_FRAME_SIZE = MIN_MAX_FRAME_SIZE;
-protected static final long DEFAULT_MAX_HEADER_LIST_SIZE = UNLIMITED;
+static final int DEFAULT_HEADER_TABLE_SIZE = 4096;
+static final boolean DEFAULT_ENABLE_PUSH = true;
+static final long DEFAULT_MAX_CONCURRENT_STREAMS = UNLIMITED;
+static final int DEFAULT_INITIAL_WINDOW_SIZE = (1 << 16) - 1;
+static final int DEFAULT_MAX_FRAME_SIZE = MIN_MAX_FRAME_SIZE;
+static final long DEFAULT_MAX_HEADER_LIST_SIZE = UNLIMITED;
 
-protected Map current = new HashMap<>();
-protected Map pending = new HashMap<>();
+Map current = new HashMap<>();
+Map pending = new HashMap<>();
 
 
-public ConnectionSettingsBase(String connectionId) {
+ConnectionSettingsBase(String connectionId) {
 this.connectionId = connectionId;
 // Set up the defaults
 current.put(Setting.HEADER_TABLE_SIZE,  
Long.valueOf(DEFAULT_HEADER_TABLE_SIZE));
@@ -61,7 +61,7 @@ public abstract class ConnectionSettings
 }
 
 
-public void set(Setting setting, long value) throws T {
+final void set(Setting setting, long value) throws T {
 if (log.isDebugEnabled()) {
 log.debug(sm.getString("connectionSettings.debug",
 connectionId, setting, Long.toString(value)));
@@ -102,33 +102,33 @@ public abstract class ConnectionSettings
 }
 
 
-public int getHeaderTableSize() {
+final int getHeaderTableSize() {
 return getMinInt(Setting.HEADER_TABLE_SIZE);
 }
 
 
-public boolean getEnablePush() {
+final boolean getEnablePush() {
 long result = getMin(Setting.ENABLE_PUSH);
 return result != 0;
 }
 
 
-public long getMaxConcurrentStreams() {
+final long getMaxConcurrentStreams() {
 return 

svn commit: r1764096 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:42:30 2016
New Revision: 1764096

URL: http://svn.apache.org/viewvc?rev=1764096=rev
Log:
Add release date

Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1764096=1764095=1764096=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Oct 10 13:42:30 2016
@@ -69,7 +69,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16455 - /dev/tomcat/tomcat-8/v8.0.38/ /release/tomcat/tomcat-8/v8.0.38/

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:41:42 2016
New Revision: 16455

Log:
Release Apache Tomcat 8.0.38

Added:
release/tomcat/tomcat-8/v8.0.38/
  - copied from r16454, dev/tomcat/tomcat-8/v8.0.38/
Removed:
dev/tomcat/tomcat-8/v8.0.38/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1764092 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:39:57 2016
New Revision: 1764092

URL: http://svn.apache.org/viewvc?rev=1764092=rev
Log:
Add release date

Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1764092=1764091=1764092=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Mon Oct 10 13:39:57 2016
@@ -62,7 +62,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16454 - /dev/tomcat/tomcat-8/v8.5.6/ /release/tomcat/tomcat-8/v8.5.6/

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:39:25 2016
New Revision: 16454

Log:
Release Apache Tomcat 8.5.6

Added:
release/tomcat/tomcat-8/v8.5.6/
  - copied from r16407, dev/tomcat/tomcat-8/v8.5.6/
Removed:
dev/tomcat/tomcat-8/v8.5.6/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][RESULT] Release Apache Tomcat 8.5.6

2016-10-10 Thread Mark Thomas
The following votes were cast:

Binding:
Stable: violetagg, remm, mgrigorov, fschumacher, markt

Non-binding:
Stable: huxing

No other votes were cast.

Thanks to everyone who supported the release.

Mark


On 06/10/2016 21:33, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.6 release is now available for voting.
> 
> The major changes compared to the 8.5.5 release are:
> 
> - Refactoring the non-container thread Async complete()/dispatch()
>   handling to remove the possibility of deadlock
> 
> - Update the packaged version of the Tomcat Native Library to
>   1.2.10 to pick up the latest Windows binaries built with
>   OpenSSL 1.0.2j
> 
> - Improved UTF-8 handling for the RewriteValve
> 
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.6/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1097/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_6/
> 
> The proposed 8.5.6 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.6
> [ ] Beta   - go ahead and release as 8.5.6
> [ ] Stable - go ahead and release as 8.5.6
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.6

2016-10-10 Thread Mark Thomas
> The proposed 8.5.6 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.6
> [ ] Beta   - go ahead and release as 8.5.6
> [X] Stable - go ahead and release as 8.5.6

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1764090 - /tomcat/trunk/webapps/docs/changelog.xml

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:32:25 2016
New Revision: 1764090

URL: http://svn.apache.org/viewvc?rev=1764090=rev
Log:
Add release date

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1764090=1764089=1764090=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Oct 10 13:32:25 2016
@@ -78,7 +78,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16453 - /dev/tomcat/tomcat-9/v9.0.0.M11/ /release/tomcat/tomcat-9/v9.0.0.M11/

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:30:39 2016
New Revision: 16453

Log:
Release Apache Tomcat 9.0.0.M11

Added:
release/tomcat/tomcat-9/v9.0.0.M11/
  - copied from r16405, dev/tomcat/tomcat-9/v9.0.0.M11/
Removed:
dev/tomcat/tomcat-9/v9.0.0.M11/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][RESULT] Release Apache Tomcat 9.0.0.M11

2016-10-10 Thread Mark Thomas
The following votes were cast:

Binding:
+1: fschumacher, mgrigorov, markt

Non-binding:
+1: huxing

The vote therefore passes.

Thanks to everyone who helped with the release.

Mark


On 06/10/2016 20:51, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.0.M11 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M10 release are:
> 
> - Refactoring the non-container thread Async complete()/dispatch()
>   handling to remove the possibility of deadlock
> 
> - Update the packaged version of the Tomcat Native Library to
>   1.2.10 to pick up the latest Windows binaries built with
>   OpenSSL 1.0.2j
> 
> - Improved UTF-8 handling for the RewriteValve
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M11/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1096/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M11/
> 
> The proposed 9.0.0.M11 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M11
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1764085 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/Cache.java webapps/docs/changelog.xml

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:08:15 2016
New Revision: 1764085

URL: http://svn.apache.org/viewvc?rev=1764085=rev
Log:
Exclude JAR files in /WEB-INF/lib from the static resource cache.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/webresources/Cache.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Oct 10 13:08:15 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1764084 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/webresources/Cache.java webapps/docs/changelog.xml

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:06:50 2016
New Revision: 1764084

URL: http://svn.apache.org/viewvc?rev=1764084=rev
Log:
Exclude JAR files in /WEB-INF/lib from the static resource cache.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/webresources/Cache.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Oct 10 13:06:50 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-176332
 
0,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763512,1763516,1763518,1763520,1763529,1763574,1763634-1763635,1763718,1763786,1763798-1763799

svn commit: r1764083 - in /tomcat/trunk: java/org/apache/catalina/webresources/Cache.java webapps/docs/changelog.xml

2016-10-10 Thread markt
Author: markt
Date: Mon Oct 10 13:06:12 2016
New Revision: 1764083

URL: http://svn.apache.org/viewvc?rev=1764083=rev
Log:
Exclude JAR files in /WEB-INF/lib from the static resource cache.

Modified:
tomcat/trunk/java/org/apache/catalina/webresources/Cache.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/webresources/Cache.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/Cache.java?rev=1764083=1764082=1764083=diff
==
--- tomcat/trunk/java/org/apache/catalina/webresources/Cache.java (original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/Cache.java Mon Oct 10 
13:06:12 2016
@@ -200,9 +200,11 @@ public class Cache {
 
 private boolean noCache(String path) {
 // Don't cache classes. The class loader handles this.
-if (path.endsWith(".class") &&
-(path.startsWith("/WEB-INF/classes/") ||
-path.startsWith("/WEB-INF/lib/"))) {
+// Don't cache JARs. The ResourceSet handles this.
+if ((path.endsWith(".class") &&
+(path.startsWith("/WEB-INF/classes/") || 
path.startsWith("/WEB-INF/lib/")))
+||
+(path.startsWith("/WEB-INF/lib/") && path.endsWith(".jar"))) {
 return true;
 }
 return false;

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1764083=1764082=1764083=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Oct 10 13:06:12 2016
@@ -64,6 +64,10 @@
 Include the Context name in the log message when an item cannot be
 added to the cache. (markt)
   
+  
+Exclude JAR files in /WEB-INF/lib from the static resource
+cache. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60202] Failed LDAP connection triggers lockout realm

2016-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60202

--- Comment #12 from Remy Maucherat  ---
Created attachment 34352
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34352=edit
isUp idea from comment 9

Using LifecycleState.FAILED is also a possibility but it could have side
effects so I didn't try it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.6

2016-10-10 Thread Mark Thomas
On 07/10/2016 21:38, Martin Grigorov wrote:
> Hi Mark,
> 
> On Fri, Oct 7, 2016 at 6:39 PM, Mark Thomas  wrote:
> 
>> On 07/10/2016 15:51, Mark Thomas wrote:
>>> On 07/10/2016 14:50, Martin Grigorov wrote:
 On Thu, Oct 6, 2016 at 10:33 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.6 release is now available for voting.
>
> The major changes compared to the 8.5.5 release are:
>
> - Refactoring the non-container thread Async complete()/dispatch()
>   handling to remove the possibility of deadlock
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.10 to pick up the latest Windows binaries built with
>   OpenSSL 1.0.2j
>
> - Improved UTF-8 handling for the RewriteValve
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.6/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/
>> orgapachetomcat-1097/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_6/
>
> The proposed 8.5.6 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.6
> [ ] Beta   - go ahead and release as 8.5.6
> [ X ] Stable - go ahead and release as 8.5.6
>

 The only thing that bothers me a bit is that I have a lot of those
>> during
 start:

 07-Oct-2016 15:27:58.342 WARNING [RMI TCP Connection(4)-127.0.0.1]
 org.apache.catalina.webresources.Cache.getResource Unable to add the
 resource at [/WEB-INF/lib/lucene-memory-5.5.2.jar] to the cache because
 there was insufficient free space available after evicting expired cache
 entries - consider increasing the maximum size of the cache
>>>
>>> I suspect that this is the cause:
>>>
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=60146
>>>
>>> We might need to tweak the caching algorithm and/or config.
>>
>> I haven't been able to reproduce this with a simple test. Can you do
>> some debugging and see what code path is triggering the loading of the
>> JAR files this way.
>>
> 
> Here is the stacktrace: http://imgur.com/a/ioRY4
> I use the sources of the voted 8.5.6, not the latest 8.5.x.

Thanks. I think I see what is happening now. The Cache entry size is
calculated based on file size regardless of whether the content of the
entry is cached or not.

What isn't clear is why you saw this with 8.5.6 but not earlier releases.

I think the correct solution here is to make JAR files in WEB-INF/lib
non-cacheable. I'll try that for the next release

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] JK 1.2.42 windows binaries debug symbols

2016-10-10 Thread Konstantin Kolinko
2016-10-06 13:10 GMT+03:00 Mark Thomas :
> These were not part of the original release VOTE so I'm calling a
> separate VOTE for them here.
>
> Tag:
> http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_42/
>
> Source:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/
>
> [ ] -1: Don't release because ...
> [x] +1: Release


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M11

2016-10-10 Thread Mark Thomas
On 06/10/2016 20:51, Mark Thomas wrote:
> The proposed 9.0.0.M11 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M11

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.6

2016-10-10 Thread Mark Thomas
On 08/10/2016 20:39, Christopher Schultz wrote:
> Mark,
> 
> On 10/8/16 3:35 PM, Christopher Schultz wrote:
>> Mark,
>>
>> On 10/6/16 4:33 PM, Mark Thomas wrote:
>>> The proposed Apache Tomcat 8.5.6 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.5 release are:
>>>
>>> - Refactoring the non-container thread Async complete()/dispatch()
>>>   handling to remove the possibility of deadlock
>>>
>>> - Update the packaged version of the Tomcat Native Library to
>>>   1.2.10 to pick up the latest Windows binaries built with
>>>   OpenSSL 1.0.2j
>>>
>>> - Improved UTF-8 handling for the RewriteValve
>>
>> Plus support for the war: UTL protocol, right?

Right. However, that really only affects users running with packed WARs
under a SecurityManager. Each of those use cases is only used by a small
minority of users. The proportion of users that use both is likely to be
very small indeed. Therefore, I didn't think it merited a mention under
major changes.

> Actually, should we try to suggest support for this "protocol" be added
> to the JRE?

Hmm. That could get interesting because a similar argument could be made
for ear files. You could end up with "jar:war:ear:file:...".

Allowing nesting of JARs (i.e. "jar:jar:...") is probably the best
'generic' solution here.

A quick search later...
https://bugs.openjdk.java.net/browse/JDK-4735639

I suggest starting a new thread, cc Rory so he sees it and ask whether
the decision to not fix could be revisited.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] JK 1.2.42 windows binaries debug symbols

2016-10-10 Thread Henri Gomez
[ ] -1: Don't release because ...
[X] +1: Release


[Bug 60202] Failed LDAP connection triggers lockout realm

2016-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60202

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|REOPENED|RESOLVED

--- Comment #11 from Remy Maucherat  ---
I am not the one who closed this report in the first place, hence my -1 is
seconded. You don't need to reopen a bug to have further discussion as well.

Your argument on exceptions doesn't make sense. In realms, the authentication
must look as if it fails to see what the request will do, regardless on what
happens in the realm. Elsewhere, exception are propagated. Async, as in the
other report, is something else, the user component receives the exception and
can do anything with it (so it is an opportunity for processing, logging, etc).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org