Re: [PATCH] Re: Kannel 1.2.1 PANIC when invoking store-status url
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Stipe, all, On Friday 27 December 2002 00:56, Stipe Tolj wrote: Alexander Malysh wrote: this patch shall fix this ... thanks a lot for the patch! I slightly modified it and commited it to cvs. BTW, checking if the Octstr *filename id not NULLed or the FILE *file descriptor is basically the same in this case?! Unfortunally no... If store_cleanup thread call store_dump you set file = NULL and if in the same moment store_save called , then you check file != NULL and return with 0. But in this case we have store file and we want block on the list (sms_store or ack_store) and you have race condition wich follows with warning get ACK of message not found... FILE *file is not the indicator that we doesn't use store file ! Indicator for us is filename , wich will not be set to NULL... Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are - -- Mit besten Grüßen aus Köln Dipl.-Ing. Alexander Malysh ___ Centrium GmbH Ehrenstrasse 2 50672 Köln Fon: +49 (0221) 277 49 150 Fax: +49 (0221) 277 49 109 email: [EMAIL PROTECTED] web: http://www.centrium.de -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+DEu9nX3e5W+uJ0ERAkbnAJ9I3twAf2Wits36pNjETZ2c9YHpJACg53hp mzpuDWpHoP6w68T3ejbUu6Y= =4+Wm -END PGP SIGNATURE-
Re: [PATCH] Re: Kannel 1.2.1 PANIC when invoking store-status url
Unfortunally no... If store_cleanup thread call store_dump you set file = NULL and if in the same moment store_save called , then you check file != NULL and return with 0. But in this case we have store file and we want block on the list (sms_store or ack_store) and you have race condition wich follows with warning get ACK of message not found... FILE *file is not the indicator that we doesn't use store file ! Indicator for us is filename , wich will not be set to NULL... sounds reasonable... Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
[PATCH] Re: Kannel 1.2.1 PANIC when invoking store-status url
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi all,
this patch shall fix this ...
On Thursday 26 December 2002 16:38, Stipe Tolj wrote:
Hi Mauricio,
I'm back again after few months and starting new tests and assessments.
great, welcome back :)
I'm using Kannel 1.2.1 with external dlr (MySQL) and experiencing this
error when invoking the store-status url.
2002-12-26 11:57:04 [3] PANIC: gwlib/list.c:287: list_lock: Assertion
`list != NULL' failed.
Any help?
not directly. Please take some time to crack the problem down on your
own. It seems a list seems to be tried to be locked while it is
NULLed.
Stipe
[EMAIL PROTECTED]
---
Wapme Systems AG
Vogelsanger Weg 80
40470 Düsseldorf
Tel: +49-211-74845-0
Fax: +49-211-74845-299
E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are
- --
Mit besten Grüßen aus Köln
Dipl.-Ing.
Alexander Malysh
___
Centrium GmbH
Ehrenstrasse 2
50672 Köln
Fon: +49 (0221) 277 49 150
Fax: +49 (0221) 277 49 109
email: [EMAIL PROTECTED]
web: http://www.centrium.de
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+C0AGnX3e5W+uJ0ERAvv+AJ9QkouM7wlvtS5/v+She1cskcmgywCeI3h2
4YCsbNoH8Ggx9DYEpcHW9vc=
=6I2C
-END PGP SIGNATURE-
Index: gw/bb_store.c
===
RCS file: /home/cvs/gateway/gw/bb_store.c,v
retrieving revision 1.16
diff -a -u -r1.16 bb_store.c
--- gw/bb_store.c 26 Aug 2002 14:10:10 - 1.16
+++ gw/bb_store.c 26 Dec 2002 17:55:24 -
@@ -207,6 +207,10 @@
ret = octstr_create();
+/* check if we initialized before */
+if (filename == NULL)
+ return ret;
+
/* set the type based header */
if (status_type == BBSTATUS_HTML) {
octstr_append_cstr(ret, table border=1\n
@@ -280,7 +284,8 @@
{
Msg *copy;
-if (file == NULL)
+/* check if we initialized before */
+if (filename == NULL)
return 0;
if (msg_type(msg) == sms) {
Re: [PATCH] Re: Kannel 1.2.1 PANIC when invoking store-status url
Alexander Malysh wrote: this patch shall fix this ... thanks a lot for the patch! I slightly modified it and commited it to cvs. BTW, checking if the Octstr *filename id not NULLed or the FILE *file descriptor is basically the same in this case?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
