Re: SMPP driver default autodetect should be 1

2003-02-14 Thread Andreas Fink

On Freitag, Februar 14, 2003, at 11:18  Uhr, Alex Judd wrote:

Basically detects whether we are sending National, International or Alpha
headers for our messages and adjusts the source TOP and NPI parameters to
the correct settings according to Logica's SMPP 3.4 specifications.

Used to be automaticly there until recently when it got change to be
disabled by default. Not real problem for me as I know it's there however
most users who expect an 'out of the box' working SMPP driver will need to
go into the source and change it.

Got you there. We definitiviely want to have it autodetecting again then.

+1 for the patch...

Andreas Fink
Global Networks Switzerland AG

--
Tel: +41-61-333  Fax: +41-61-334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--
Member of the GSM Association



Re: SMPP driver default autodetect should be 1

2003-02-14 Thread Stipe Tolj
ok, commited to cvs.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




Re: SMPP driver default autodetect should be 1

2003-02-13 Thread Stipe Tolj
Alex Judd wrote:
 
 By default we are disabling the auto switching of TON and NPI in the
 SMPP driver.
 
 I think we should enable this by default and then allow to
 explicitly turn it off.
 
 smsc_smpp.c, line 1272, autodetect_addr = 1;
 
 Make sense to everyone?

any objections from the others? I'm +0 on this.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




Re: SMPP driver default autodetect should be 1

2003-02-13 Thread Andreas Fink

On Freitag, Februar 14, 2003, at 12:06  Uhr, Stipe Tolj wrote:

Alex Judd wrote:
By default we are disabling the auto switching of TON and NPI in the
SMPP driver.

I think we should enable this by default and then allow to
explicitly turn it off.

smsc_smpp.c, line 1272, autodetect_addr = 1;

Make sense to everyone?

any objections from the others? I'm +0 on this.

Can anyone enlighten me on what it is autodetecting here? Then I can come to some opinion...

Andreas Fink
Global Networks Switzerland AG

--
Tel: +41-61-333  Fax: +41-61-334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/  [EMAIL PROTECTED]
--
Member of the GSM Association



Re: SMPP driver default autodetect should be 1

2003-02-13 Thread Stipe Tolj
Andreas Fink schrieb:
  any objections from the others? I'm +0 on this.
 
 Can anyone enlighten me on what it is autodetecting here? Then I can come to some 
opinion...

it's autodetecting the TON, and hence sets the destination TON
accordingly for submit_sm PDUs.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




Re: SMPP driver default autodetect should be 1

2003-02-11 Thread David Holland
On Tue, Feb 11, 2003 at 04:03:13PM -, Alex Judd wrote:
 By default we are disabling the auto switching of TON and NPI in the
 SMPP driver. 
 I think we should enable this by default and then allow to explicitly
 turn it off.

I agree. (it would have saved me half an hour of head-scratching last
week ;-) )

Dave

-- 
:: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 ::
The more complex the system and the more expert the users, the more their
technical conversation sounds like the plot of a soap opera. -- Pinker