[OpenSER-Devel] SF.net SVN: openser: [3748] trunk

2008-02-25 Thread Bogdan-Andrei Iancu
Revision: 3748
  http://openser.svn.sourceforge.net/openser/?rev=3748view=rev
Author:   bogdan_iancu
Date: 2008-02-25 02:51:21 -0800 (Mon, 25 Feb 2008)

Log Message:
---
- added new script core command - ususe_blacklist(list), pair with 
use_blacklist(list)
- functions [un]use_blacklist() may take as parameter the keyword all - the 
acction applies on all blacklists

Modified Paths:
--
trunk/action.c
trunk/blacklists.c
trunk/blacklists.h
trunk/cfg.lex
trunk/cfg.y
trunk/route.c
trunk/route_struct.h


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] [OpenSER-Users] mediaproxy server NEW FEATURE!!!

2008-02-25 Thread Gonzalo J. Sambucaro
Jens,
 yes, if an attacker guess/sniff the SSRC then could take over the rtp
session. A timeout would work fine but right now I don't have the
time to do it, if somebody else wants to do it I can send the source
code.

Regards,
Gonzalo.

 Gonzalo J. Sambucaro [EMAIL PROTECTED] writes:

 [...]
 1) When the first rtp packet of a source arrives, save the SSRC field in
 the MP.
  - Save the SSRC of the caller.
  - Save the SSRC of the called.

 2) If arrives a rtp packet with unknown source IP but with the same SSRC
 field of some of the two streams, updates the binding (with the new IP
 detected) between the caller and the MP or between the called and the MP
 according to the field SSRC previously saved.

 An attacker would have to guess/sniff the SSRC and then could take over
 the rtp session? (maybe could be fixed by only allowing to take over
 after some timeout)
 On the other hand if he can sniff ...

 ___
 Users mailing list
 [EMAIL PROTECTED]
 http://lists.openser.org/cgi-bin/mailman/listinfo/users



-- 
Gonzalo J. Sambucaro
Ingeniería de Software
Tel: +54-341-4230504
MSLC
[EMAIL PROTECTED]
www.mslc.com.ar
Ocampo y Esmeralda - Vivero de Empresas de Base Tecnológica
Ciudad Universitaria Rosario UNR, CCT CONICET
Rosario - Santa Fé - Argentina


___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] SF.net SVN: openser: [3751] trunk/tls/tls_server.c

2008-02-25 Thread Bogdan-Andrei Iancu
Revision: 3751
  http://openser.svn.sourceforge.net/openser/?rev=3751view=rev
Author:   bogdan_iancu
Date: 2008-02-25 04:30:33 -0800 (Mon, 25 Feb 2008)

Log Message:
---
-print more info in case of error

Modified Paths:
--
trunk/tls/tls_server.c


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] irc on domains for rr module

2008-02-25 Thread Bogdan-Andrei Iancu
Hi Juha,

The idea was to have all modules using a core function (like rr does 
now) to check is a domain is local IP or domain, instead of having each 
module to use a core function and a function from other module (domains)..

Regards,
Bogdan


Juha Heinanen wrote:
 Bogdan-Andrei Iancu writes:

   2) technically simple, but solves only the particular case of RR module; 
   and there will be no common way to check from script/other modules if 
   some domain is local or not.

 bogdan,

 i don't understand.  the api that domain module provides for other
 modules IS a common way to check from other modules if some domain is
 local or not.

 -- juha

   


___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] [ openser-Bugs-1901434 ] 6xx reply handling

2008-02-25 Thread SourceForge.net
Bugs item #1901434, was opened at 2008-02-25 17:11
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1901434group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.3.x
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Bogdan-Andrei Iancu (bogdan_iancu)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: 6xx reply handling

Initial Comment:
I found two bugs in 6xx reply handing in TM:



1) according to RFC3261, no branch should be added after a 6xx reply (no more 
serial forking):

Chapter 6 Definitions:

   Sequential Search: In a sequential search, a proxy server attempts each 
contact address in sequence, proceeding to the next one only after the previous 
has generated a final response.  A 2xx or 6xx class final response always 
terminates a sequential search. 

16.7 Response Processing (Point 5)

 If a 6xx response is received, it is not immediately forwarded,but the 
stateful proxy SHOULD cancel all client pending transactions as described in 
Section 10, and it MUST NOT create any new branches in this context.


2) ignoring bug 1), if after a 6xx reply, a new branch is added in failure 
route or callback, the pending branches (from the same set with 6xx reply) are 
not cancelled any more.




--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1901434group_id=139143

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] [ openser-Bugs-1887999 ] memory leak in canceled call with diversion header

2008-02-25 Thread SourceForge.net
Bugs item #1887999, was opened at 2008-02-06 18:12
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1887999group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver 1.2.x
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Will Quan (will_quan)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: memory leak in canceled call with diversionheader

Initial Comment:
[Scripts attached to reproduce the issue.]

I think the issue is with ACC log_extra setting:
modparam(acc, log_extra, div=$di)

The acc callback 'on_missed' is invoked when the call is canceled (487). With 
this 'log_extra' setting, the acc function extra2strar() executes and parses 
the diversion header in the request. It is this memory that is not freed 
(msg-diversion-parsed).




--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-25 17:12

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Closed - keep 1879864 for reporting.

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-11 18:26

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Will,

A fix is available on SVN trunk - please update and test again to see if
the problem was fixed. I need your confirmation before doing a backport
to
1.3 and 1.2

Thanks and regards,
Bogdan

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-07 13:22

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi will,

Fortunately (strange to say this :D) a crash was reported due the same
cause. More or less it confirmed my suppositions on this matter, so things
are clear now.

I will prepare a general solution in TM module.

Regards,
Bogdan 

--

Comment By: Will Quan (will_quan)
Date: 2008-02-06 20:38

Message:
Logged In: YES 
user_id=1850067
Originator: YES

Hi bogdan,

No core dump. 
I may have been running slow enough to where the calls were single-handled
on the same process.

I hacked a fix that frees the memory back in acc extra2strar, after the
ACC log is generated. However, I do not have a general solution :(
--will


--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-06 19:53

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Will,

I went through the debug output you had in the email - very useful.
Take a look at the following output:

Jan 31 16:12:05 www /openser[64400]: DBG: trans=0x4849523c, callback type
128, id 1 entered
Jan 31 16:12:05 www /openser[64400]: qm_malloc(0x8151120, 212) called from
parser/parse_diversion.c: parse_diversion_header(54)
Jan 31 16:12:05 www /openser[64400]: qm_malloc(0x8151120, 212) returns
address 0x81ab378 frag. 0x81ab360 (size=388) on 1 -th hit
Jan 31 16:12:05 www /openser[64400]: qm_malloc(0x8151120, 24) called from
parser/parse_to.c: parse_to_param(278)
Jan 31 16:12:05 www /openser[64400]: qm_malloc(0x8151120, 24) returns
address 0x81a9788 frag. 0x81a9770 (size=32) on 1 -th hit


From TM, the callback type 128 is triggered - note this is
TMCB_RESPONSE_OUT and not TMCB_ON_FAILURE as you thought.
The TMCB_RESPONSE_OUT gets as param both the request (in shm mem) and the
reply.
In acc module (which installs the callback) parse the request (from shm)
looking for some hdrs (due pseudo vars). So, the newly parsed header body
exists in private mem (0x81ab378 and 0x81a9788) and it is attached to the
request which resides in shm memory.
This is why the  0x81ab378 and 0x81a9788 chunks are not freed when the
processing of the reply is done - because they are attached to the request,
in shm memory.
The req from shm is freed when the transaction is completed - don't you
get a core dump when this happens - as the chunks from private memory
(potential from other process) are freed as shm memory ?

Regards,
Bogdan

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1887999group_id=139143

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] more presence errors

2008-02-25 Thread Henning Westerholt
On Saturday 23 February 2008, Juha Heinanen wrote:
 in addition to the crash, i also noticed this:

 Feb 23 08:53:53 rautu /usr/sbin/openser[23344]: LOG: Handling PUBLISH to
 sip:[EMAIL PROTECTED] Feb 23 08:53:53 rautu /usr/sbin/openser[23344]:
 ERROR:db_mysql:db_mysql_submit_query: driver error on query: Commands out
 of sync; you can't run this command now Feb 23 08:53:53 rautu
 /usr/sbin/openser[23344]: ERROR:core:db_do_insert: error while submitting
 query Feb 23 08:53:53 rautu /usr/sbin/openser[23344]:
 ERROR:presence:update_presentity: inserting new record in database Feb 23
 08:53:53 rautu /usr/sbin/openser[23344]: ERROR:presence:handle_publish:
 when updating presentity Feb 23 08:53:53 rautu /usr/sbin/openser[23344]:
 ERROR: PUBLISH to sip:[EMAIL PROTECTED] failed

 all these presence problems appeared when i upgraded trunk to latest
 version.  before that the same presence stuff has worked fine for a long
 time.

Hi Juha,

i've noticed that both traces have a database error in the logs. Perhaps this 
was caused from my recent reworks.. Or perhaps there exists an issue with the 
presence module if a database query fails? I have no test setup for this 
modules ready, so unfortunally i can't test this, but i'll keep an eye on the 
db problems..

Cheers,

Henning

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] [ openser-Bugs-1879864 ] openser crash while handling 487 response

2008-02-25 Thread SourceForge.net
Bugs item #1879864, was opened at 2008-01-25 19:01
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1879864group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.3.x
Status: Open
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: openser crash while handling 487 response

Initial Comment:
If I enable extra acc in openser while doing syslog accounting, openser is 
crashing while handling 487 message.

The following extra acc params is crashing the server:
modparam(acc, log_extra, 
r_uri=$ru;from=$fn;from_uri=$fu;to=$tn;to_uri=$tu;contact=$ct;ua=$hdr(User-Agent);src_ip=$si;src_port=$sp;rpid=$re
 )

Here are the relevant informations:
# openser -V
version: openser 1.3.0-notls (i386/linux)
flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, 
SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
svnrevision: 2:3580M
@(#) $Id: main.c 3565 2008-01-23 17:17:29Z miconda $
main.c compiled on 23:23:01 Jan 24 2008 with gcc 4.1.2

Core was generated by `/usr/sbin/openser -P /var/run/openser.pid -m 512'.
Program terminated with signal 11, Segmentation fault.
#0  0x080efa69 in free_to ()
(gdb) bt
#0  0x080efa69 in free_to ()
#1  0x080daa30 in clean_hdr_field ()
#2  0x0014fd4a in t_should_relay_response (Trans=0x9b965678, new_code=487, 
branch=0, should_store=0xbfdb1cf4, should_relay=0xbfdb1cf8, 
cancel_bitmap=0xbfdb1dd0, reply=0x8195c70) at t_reply.c:545
#3  0x00150a94 in relay_reply (t=0x9b965678, p_msg=0x8195c70, branch=0, 
msg_status=487, cancel_bitmap=0xbfdb1dd0) at t_reply.c:1051
#4  0x00151fcb in reply_received (p_msg=0x8195c70) at t_reply.c:1403
#5  0x08063c50 in forward_reply ()
#6  0x080940e2 in receive_msg ()
#7  0x080d3c87 in udp_rcv_loop ()
#8  0x0806c396 in main ()


Regards,
Ovidiu Sas

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-25 17:13

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Based on some reports from Ovidiu, it looks like there are some side
effects (crashes) that might be related to this fixstill to investigate

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-11 18:25

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

A fix is available on SVN trunk - please update and test again to see if
the problem was fixed. I need your confirmation before doing a backport to
1.3 and 1.2

Thanks and regards,
Bogdan

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-07 13:20

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

Thanks for the core file - it was really helpful. I spent some time
digging into it and I found the bug.
Shortly, it is the same reported by Will (id #1887999). He reported as mem
leak, but as suspected, it can be also a crash (as in your case).

The problem was the $re from extra_acc - RPID header - this pseudo
variable was triggering the parsing (with parse_to() ) of the RPID header
in TMCB_RESPONSE_OUT handler of acc. The parsed hdr was in the private
memory of a process receiving the first reply that required acc. The parsed
hdr remained attached to the transaction (in shm mem) and the
TMCB_ON_FAILURE tried to free it in a different process. The result is
known :).

I will prepare asap a fix for this problem.

Regards,
Bogdan

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-01-29 10:56

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Ovidiu,

could you provide the core file and the binaries? I would like to inspect
a bit the core.

Thanks and regards,
Bogdan

--

Comment By: Ovidiu Sas (osas)
Date: 2008-01-28 23:55

Message:
Logged In: YES 
user_id=1395524
Originator: YES

The server seems to be working fine with the following log_extra params:
modparam(acc, log_extra, from_uri=$fu;r_uri=$ru )

I will try tomorrow to play more with To and report back.

Henning, in my openser config I'm using only cr_tree_rewrite_uri().

--

Comment By: Henning Westerholt (henningw)
Date: 2008-01-28 18:28

Message:
Logged In: YES 
user_id=337916
Originator: NO

Not sure if this is related.. 

Ovidiu, you're seeing this crash with the cr 

[OpenSER-Devel] [ openser-Bugs-1879864 ] openser crash when extra acc params enabled

2008-02-25 Thread SourceForge.net
Bugs item #1879864, was opened at 2008-01-25 12:01
Message generated for change (Settings changed) made by osas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1879864group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.3.x
Status: Open
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: openser crash when extra acc params enabled

Initial Comment:
If I enable extra acc in openser while doing syslog accounting, openser is 
crashing while handling 487 message.

The following extra acc params is crashing the server:
modparam(acc, log_extra, 
r_uri=$ru;from=$fn;from_uri=$fu;to=$tn;to_uri=$tu;contact=$ct;ua=$hdr(User-Agent);src_ip=$si;src_port=$sp;rpid=$re
 )

Here are the relevant informations:
# openser -V
version: openser 1.3.0-notls (i386/linux)
flags: STATS: Off, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MEM, 
SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
svnrevision: 2:3580M
@(#) $Id: main.c 3565 2008-01-23 17:17:29Z miconda $
main.c compiled on 23:23:01 Jan 24 2008 with gcc 4.1.2

Core was generated by `/usr/sbin/openser -P /var/run/openser.pid -m 512'.
Program terminated with signal 11, Segmentation fault.
#0  0x080efa69 in free_to ()
(gdb) bt
#0  0x080efa69 in free_to ()
#1  0x080daa30 in clean_hdr_field ()
#2  0x0014fd4a in t_should_relay_response (Trans=0x9b965678, new_code=487, 
branch=0, should_store=0xbfdb1cf4, should_relay=0xbfdb1cf8, 
cancel_bitmap=0xbfdb1dd0, reply=0x8195c70) at t_reply.c:545
#3  0x00150a94 in relay_reply (t=0x9b965678, p_msg=0x8195c70, branch=0, 
msg_status=487, cancel_bitmap=0xbfdb1dd0) at t_reply.c:1051
#4  0x00151fcb in reply_received (p_msg=0x8195c70) at t_reply.c:1403
#5  0x08063c50 in forward_reply ()
#6  0x080940e2 in receive_msg ()
#7  0x080d3c87 in udp_rcv_loop ()
#8  0x0806c396 in main ()


Regards,
Ovidiu Sas

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-25 10:13

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Based on some reports from Ovidiu, it looks like there are some side
effects (crashes) that might be related to this fixstill to investigate

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-11 11:25

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

A fix is available on SVN trunk - please update and test again to see if
the problem was fixed. I need your confirmation before doing a backport to
1.3 and 1.2

Thanks and regards,
Bogdan

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-07 06:20

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

Thanks for the core file - it was really helpful. I spent some time
digging into it and I found the bug.
Shortly, it is the same reported by Will (id #1887999). He reported as mem
leak, but as suspected, it can be also a crash (as in your case).

The problem was the $re from extra_acc - RPID header - this pseudo
variable was triggering the parsing (with parse_to() ) of the RPID header
in TMCB_RESPONSE_OUT handler of acc. The parsed hdr was in the private
memory of a process receiving the first reply that required acc. The parsed
hdr remained attached to the transaction (in shm mem) and the
TMCB_ON_FAILURE tried to free it in a different process. The result is
known :).

I will prepare asap a fix for this problem.

Regards,
Bogdan

--

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-01-29 03:56

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Ovidiu,

could you provide the core file and the binaries? I would like to inspect
a bit the core.

Thanks and regards,
Bogdan

--

Comment By: Ovidiu Sas (osas)
Date: 2008-01-28 16:55

Message:
Logged In: YES 
user_id=1395524
Originator: YES

The server seems to be working fine with the following log_extra params:
modparam(acc, log_extra, from_uri=$fu;r_uri=$ru )

I will try tomorrow to play more with To and report back.

Henning, in my openser config I'm using only cr_tree_rewrite_uri().

--

Comment By: Henning Westerholt (henningw)
Date: 2008-01-28 11:28

Message:
Logged In: YES 
user_id=337916
Originator: NO

Not sure if this is related.. 

Ovidiu, you're seeing this crash with the cr 

[OpenSER-Devel] SF.net SVN: openser: [3756] trunk/modules/pua_bla/pua_bla.c

2008-02-25 Thread Anca Vamanu
Revision: 3756
  http://openser.svn.sourceforge.net/openser/?rev=3756view=rev
Author:   anca_vamanu
Date: 2008-02-25 09:22:11 -0800 (Mon, 25 Feb 2008)

Log Message:
---
- fixed error message

Modified Paths:
--
trunk/modules/pua_bla/pua_bla.c


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] SF.net SVN: openser: [3757] branches/1.3/modules/pua_bla/pua_bla.c

2008-02-25 Thread Anca Vamanu
Revision: 3757
  http://openser.svn.sourceforge.net/openser/?rev=3757view=rev
Author:   anca_vamanu
Date: 2008-02-25 09:23:39 -0800 (Mon, 25 Feb 2008)

Log Message:
---
- fixed error message

Modified Paths:
--
branches/1.3/modules/pua_bla/pua_bla.c


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] more presence errors

2008-02-25 Thread Dan Pascu
On Monday 25 February 2008, Bogdan-Andrei Iancu wrote:
 Hi,

 if it helps, usually the Commands out of sync error is generated when
 the more than one queries are pushed on the same mysql connection .

To be more precise, if you issue a new query before you finish with and 
free the previous result set.

-- 
Dan

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] return argument

2008-02-25 Thread Daniel-Constantin Mierla
Hello,

On 02/25/08 08:34, Juha Heinanen wrote:
 i remember that someone asked a while ago, if return statement accepts a
 pseudo variable argument.

 looks like it still doesn't because something like this resulted in
 syntax error at return line:

 route[1] {
   route(2);
   return($retcode);
 }

 i solved the problem like this:

 route[1] {
   route(2);
   switch($retcode) {
   case 1:
   return(1);
   case 2:
   return(2);
   default:
   return(-1);
   }
 }

 which is not pretty.  if i didn't make a mistake in above and return
 statement does not accept a pv argument, i would like to put this
 feature on 1.4 wish list.
   
no, it is not implemented yet, but I had it in mind for some time -- I 
remember also some discussion about. Please add to the tracker not to 
forget about it again, until next release.

Cheers,
Daniel

 -- juha

 ___
 Devel mailing list
 Devel@lists.openser.org
 http://lists.openser.org/cgi-bin/mailman/listinfo/devel
   

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] irc on domains for rr module

2008-02-25 Thread Juha Heinanen
Bogdan-Andrei Iancu writes:

  The idea was to have all modules using a core function (like rr does 
  now) to check is a domain is local IP or domain, instead of having each 
  module to use a core function and a function from other module
  (domains)...

in that case, domain module should also push the domains into core
instead of keeping them in its own cache.  it makes no sense to have
them in two places.  after that, there would be only one function in
domain module (is_domain_local(pseudo_variable)) that would call
corresponding core function, which means that perhaps then also
this function should be pushed to core.  then the question is, what to
do with domain_reload function?

on the other hand, it is still don't understand, what the advantage
would be if other modules call a core function instead of calling a
function exported from domain module.  it would just make core bigger
for someone who does not need domains at all.

-- juha

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] more presence errors

2008-02-25 Thread Juha Heinanen
Henning Westerholt writes:

  i've noticed that both traces have a database error in the
  logs. Perhaps this  was caused from my recent reworks.. Or perhaps
  there exists an issue with the 
  presence module if a database query fails?

why would the query start failing like that when it has worked before?

it looks to me that this problem has appeared after changes either in
presence of database modules.  i haven't followed if there has been any
changed in presence modules recently that could have caused this.

-- juha

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] documentation effort

2008-02-25 Thread Daniel-Constantin Mierla
Hello,

Henning, a new mailing list has been setup to conduct and coordinate on 
documentations effort: [EMAIL PROTECTED] .

http://lists.openser.org/cgi-bin/mailman/listinfo/openser-docs

Anyone that want to participate to documentation development process, 
please subscribe to the list.

Cheers,
Daniel

On 02/25/08 15:28, Edson wrote:

 Hi...

 I get contact with Michiel on Friday and he told that he will be back 
 on March, 4th. ‘til there I’ll follow with the ‘clean-up’ that you 
 proposed (dead/unused code on README files)…

 As soon as the list is ready, I’ll post all changes that I made so 
 that the developers can make a revision and commit or discuss it.

 Just as an idea: I’d say that all developers (with SVN access, maybe) 
 should also subscribe to this new list, so that they also be aware on 
 what we do.

 Edson

 

 *From:* Henning Westerholt [mailto:[EMAIL PROTECTED]
 *Sent:* segunda-feira, 25 de fevereiro de 2008 09:57
 *To:* devel@lists.openser.org; Edson
 *Cc:* Michiel ten Hagen
 *Subject:* Re: [OpenSER-Devel] documentation effort

 On Friday 22 February 2008, Michiel ten Hagen wrote:

  During the IRC meetings I proposed to take on some of the work on

  improving the documentation.

 

  For this I recommend the following:

  There already is lots of documentation on openser (and SER) distributed

  on the web and also the openser wiki does contain lots information but

  apparently this is not found by new users. A 'official openser guide'

  would be the appropriate solution for this, this way a single

  consistent source of information for new users is available.

  [..]

 Hi Michiel,

 having an 'openser guide' would be a really great thing. I agree, all 
 existing documentation on openser.org should be consolidated in one place.

  Its preferable to create the guide using DocBook XML and svn with a

  small team. MoinMoin supports wiki - docbook conversions, we could use

  that or create some XSLT ourselves. Using a DocBook - wiki workflow

  allows web users to pinpoint mistakes or make small additions but leave

  the team to create a consistent document.

 Well, we're using dokuwiki at the moment, and not MoinMoin. There 
 exists also a xslt docbook plugin for this wiki, but this is not that 
 maintained and performant i think. If we have a guide then we could 
 just place it on the webserver and link from the wiki. But these are 
 details, no need to discuss this now as long as we don't have a guide 
 at all. ;-)

  Next the guide other improvements such as a faq are usefull but I

  suggest to focus on a guide.

 

  Tasks

  - Create a single point of entry for documentation

  - Create an openser-doc mailing list

  - Create an separate doc tree in svn

  - Create a small documentation team

  - Create an 'official openser guide'

 To the tasks:

 I think we should start with the mailling list. Bogdan or Daniel, 
 perhaps one of you could create the 'openser-docs' list?

 Forming a small team sounds good. Edson already contacted me last 
 week, he probably already want to join this effort. Perhaps sending an 
 announcement to the user list will also help to get some people 
 joining this project. Please let me know if there is something i could 
 do to help you in getting this started.

 You'll will probably need svn access, perhaps we can discuss this 
 after the list has been setup and the first steps in toward the guide 
 has been taken.

  I will be busy the rest of the month but after that I am willing to work

  on the procedures and start with a basic guide.

 Great, i'm looking forward to this.

 Cheers,

 Henning

 

 ___
 Devel mailing list
 Devel@lists.openser.org
 http://lists.openser.org/cgi-bin/mailman/listinfo/devel
   

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] radius issues in IRC minutes

2008-02-25 Thread Daniel-Constantin Mierla
Hello,

I think my proposal was misunderstood in the first place. By compacting 
the RADIUS modules I was not really meaning to remove/merge some of 
them, but to collect duplicate code in a single place, and reuse from 
there. Also, if we get to the conclusion that it is good to be done, 
that does not mean you have to do it :-)

So here are more details and reasons for the proposal.
- in the past, any time when the libradiusclient was updated, all radius 
modules were affected (e.g., see commits on SER repository related to 
migration to libradiusclient-ng or updates/bugs related to this library).
- in the eventuality of adding failover/load balancing support (ability 
to connect to many RADIUS servers depending on different situations and 
usecases), we will have the whole engine in a single place, and once 
added there, all radius modules will benefit of (LDAP module has kind of 
such approach)
- as DIAMETER has same attribute-value architecture, we may find (some 
investigation needed here) that we can reuse the rest of the code in 
*radius modules to add the diameter support just by replacing the 
connector module (e.g., assuming we will have radius and diameter 
modules)
- there are many radius servers out there, although not requested so 
far, in case one wants to add support for other radius server which has 
a different client library, lot of duplicate will be required

These are my main points about this item, any comment is appreciated.

Cheers,
Daniel



On 02/21/08 00:25, Juha Heinanen wrote:
 i read irc meeting minutes (could not participate myself due to 12 hour
 time difference to CET).  here are my comments regarding radius
 modules.

 i don't think that just having a smaller number of modules can justify
 putting a lot of work on writing some new api for radius modules.  i
 would rather put my time in implementing some new functionality.  if
 there is a need to change the module interface in radius modules due to
 some changes in core, i'm willing to do that work.  just let me know
 when a change is coming and what kind.

 nevertheless, there may be a possibility to integrate some radius
 related modules.  i can take a look.  i'm however skeptical regarding
 integrating auth_radius, because it is a sub-module of auth module.

 -- juha

 ___
 Devel mailing list
 Devel@lists.openser.org
 http://lists.openser.org/cgi-bin/mailman/listinfo/devel

   

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


Re: [OpenSER-Devel] new cseq test?

2008-02-25 Thread Daniel-Constantin Mierla
Hello,

On 02/23/08 09:39, Juha Heinanen wrote:
 i haven't noticed this before:

 Feb 23 09:35:50 rautu /usr/sbin/openser[23869]: 
 ERROR:registrar:test_max_contacts: invalid cseq for aor [EMAIL PROTECTED] 

 it is a new test?

 cseq in register was smaller than in location database.

 i have restarted by UA.  should it somehow know that cseq it used
 earlier?
   
did it changed the call id?

More details about matching algorithm:
http://www.openser.org/docs/modules/1.4.x/usrloc.html#CONTACT-MATCHING-ALGS

Cheers,
Daniel

 -- juha

 ___
 Devel mailing list
 Devel@lists.openser.org
 http://lists.openser.org/cgi-bin/mailman/listinfo/devel
   

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] [ openser-Feature Requests-1901736 ] return statement should accept pv argument

2008-02-25 Thread SourceForge.net
Feature Requests item #1901736, was opened at 2008-02-25 14:36
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743023aid=1901736group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: return statement should accept pv argument

Initial Comment:
return statement should accept pv argument.  below is an example of a problem 
that this feature would solve.

-- juha

 it should be possible to write this:

 route[1] {
   route(2);
   return($retcode);
 }

 instead of this:

 route[1] {
   route(2);
   switch($retcode) {
   case 1:
   return(1);
   case 2:
   return(2);
   default:
   return(-1);
   }
 }


--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743023aid=1901736group_id=139143

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] [ openser-Bugs-1901793 ] uri_radius error during start

2008-02-25 Thread SourceForge.net
Bugs item #1901793, was opened at 2008-02-26 01:07
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1901793group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Norm Brandinger (norm_brandinger)
Assigned to: Nobody/Anonymous (nobody)
Summary: uri_radius error during start

Initial Comment:
The following error is thrown at startup:

ERROR:uri_radius:mod_init: uri_radius: can't get code for the SIP-URI-Host 
attribute


The only uri_radius setting in openser.cfg is:

loadmodule uri_radius.so


Note that adding the following had no effect on the above error message:

modparam(uri_radius, use_sip_uri_host, 0)

--

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detailatid=743020aid=1901793group_id=139143

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel


[OpenSER-Devel] [ openser-Bugs-1901793 ] uri_radius error during start

2008-02-25 Thread Juha Heinanen
SourceForge.net writes:

  Initial Comment:
  The following error is thrown at startup:
  
  ERROR:uri_radius:mod_init: uri_radius: can't get code for the
  SIP-URI-Host attribute

norm,

sorry about that.  try now.

-- juha

___
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel