Re: a small twm/Imakefile patch
On 20 Jul 2003, Alexander Pohoyda wrote: With your change, on IRIX, I get: [aurora:/scratch_large/root/X11/alpha/loader/xc/programs] make SUBDIRS=twm Makefiles making Makefiles in programs/twm... mv -f Makefile Makefile.bak cc-1018 cc: ERROR at end of source An unmatched left parentheses ( appears in an expression. Would you please try if it works on IRIX this way: -SpecialCObjectRule(parse,$(_NOOP_),'-DSYSTEM_INIT_FILE='$(TWMDIR)'/system.twmrc') +SpecialCObjectRule(parse,$(_NOOP_),'-DSYSTEM_INIT_FILE=$(TWMDIR)/system.twmrc') Yes, that works. It's not about commiting this senseless patch, of course :-) I did so anyway. Marc. +--+---+ | Marc Aurele La France | work: 1-780-492-9310 | | Computing and Network Services | fax:1-780-492-1729 | | 352 General Services Building | email: [EMAIL PROTECTED] | | University of Alberta +---+ | Edmonton, Alberta | | | T6G 2H1 | Standard disclaimers apply| | CANADA | | +--+---+ XFree86 Core Team member. ATI driver and X server internals. ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
Marc Aurele La France [EMAIL PROTECTED] writes: http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Updated. Can you elaborate on why is it useful to switch from single quote quoting to backslashes? It may be not useful as much, but with an old version we end up calling a command: [...] cc -c [...] -DHAS_MKSTEMP '-DSYSTEM_INIT_FILE='/usr/X11R6/lib/X11/twm'/system.twmrc' parse.c which is not consistent, does not look very nice and requires more processing by the shell. ... but is still required for portability reasons. Oh! Good to know. Thanks. May I also ask on which system/shell/compiler/imake would my patch fail? Just for the record. With your change, on IRIX, I get: [aurora:/scratch_large/root/X11/alpha/loader/xc/programs] make SUBDIRS=twm Makefiles making Makefiles in programs/twm... mv -f Makefile Makefile.bak cc-1018 cc: ERROR at end of source An unmatched left parentheses ( appears in an expression. Would you please try if it works on IRIX this way: -SpecialCObjectRule(parse,$(_NOOP_),'-DSYSTEM_INIT_FILE='$(TWMDIR)'/system.twmrc') +SpecialCObjectRule(parse,$(_NOOP_),'-DSYSTEM_INIT_FILE=$(TWMDIR)/system.twmrc') It's not about commiting this senseless patch, of course :-) Thank you very much! -- Alexander Pohoyda [EMAIL PROTECTED] ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
On 10 Jul 2003, Alexander Pohoyda wrote: http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Can you elaborate on why is it useful to switch from single quote quoting to backslashes? It may be not useful as much, but with an old version we end up calling a command: [...] cc -c [...] -DHAS_MKSTEMP '-DSYSTEM_INIT_FILE='/usr/X11R6/lib/X11/twm'/system.twmrc' parse.c which is not consistent, does not look very nice and requires more processing by the shell. ... but is still required for portability reasons. Oh! Good to know. Thanks. May I also ask on which system/shell/compiler/imake would my patch fail? Just for the record. With your change, on IRIX, I get: [aurora:/scratch_large/root/X11/alpha/loader/xc/programs] make SUBDIRS=twm Makefiles making Makefiles in programs/twm... mv -f Makefile Makefile.bak cc-1018 cc: ERROR at end of source An unmatched left parentheses ( appears in an expression. cc-1247 cc: ERROR File = ./Imakefile, Line = 27 The macro invocation is improperly terminated. SpecialCObjectRule(parse,$(_NOOP_),-DSYSTEM_INIT_FILE=\$(TWMDIR)/system.twmrc\) ^ 2 errors detected in the compilation of Imakefile.c. ../../config/imake/imake: Exit code 2. Stop. *** Error code 1 (bu21) UX:make: ERROR: make: file `Makefile' line 5: Must be a separator (: or ::) for rules (bu39) UX:make: ERROR: make: file `Makefile' line 5: bad character (octal 76) [aurora:/scratch_large/root/X11/alpha/loader/xc/programs] I'm wondering how this can work then: ./xc/programs/xkbcomp/Imakefile:ROOT_DEFINES = -DDFLT_XKB_CONFIG_ROOT=\$(LIBDIR)/xkb\ ./xc/programs/xdm/Imakefile:RANDOM_DEFINES = -DDEV_RANDOM=\/dev/urandom\ Those are not macro expansions (in the cpp sense). Marc. +--+---+ | Marc Aurele La France | work: 1-780-492-9310 | | Computing and Network Services | fax:1-780-492-1729 | | 352 General Services Building | email: [EMAIL PROTECTED] | | University of Alberta +---+ | Edmonton, Alberta | | | T6G 2H1 | Standard disclaimers apply| | CANADA | | +--+---+ XFree86 Core Team member. ATI driver and X server internals. ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
On Mon, 7 Jul 2003, Alexander Pohoyda wrote: Date: Mon, 7 Jul 2003 18:39:38 +0200 (CEST) From: Alexander Pohoyda [EMAIL PROTECTED] To: [EMAIL PROTECTED] Reply-To: [EMAIL PROTECTED] Content-Type: text/plain; charset=utf-8 Subject: a small twm/Imakefile patch Does not really deserves a Bugzilla report (1K): http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Most likely, it doesn't deserve to tracked or applied either then. Bugzilla is for both tracking open bugs, and for submitting patches that fix things or add functionality, etc. things stay open in bugzilla until someone has the time and inclination to investigate and fix/apply. Patches sent to mailing lists get lost if nobody is interested in looking at them immediately. -- Mike A. Harris ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
Alexander Pohoyda wrote (in a message from Monday 7) Does not really deserves a Bugzilla report (1K): http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Can you elaborate on why is it useful to switch from single quote quoting to backslashes? Matthieu ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
Matthieu Herrb [EMAIL PROTECTED] writes: Alexander Pohoyda wrote (in a message from Monday 7) http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Can you elaborate on why is it useful to switch from single quote quoting to backslashes? It may be not useful as much, but with an old version we end up calling a command: [...] cc -c [...] -DHAS_MKSTEMP '-DSYSTEM_INIT_FILE='/usr/X11R6/lib/X11/twm'/system.twmrc' parse.c which is not consistent, does not look very nice and requires more processing by the shell. I have no more arguments, sorry. Please forget the issue if you don't agree with my reasoning. Many thanks for the reply anyway! -- Alexander Pohoyda [EMAIL PROTECTED] ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
On 9 Jul 2003, Alexander Pohoyda wrote: Matthieu Herrb [EMAIL PROTECTED] writes: Alexander Pohoyda wrote (in a message from Monday 7) http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Can you elaborate on why is it useful to switch from single quote quoting to backslashes? It may be not useful as much, but with an old version we end up calling a command: [...] cc -c [...] -DHAS_MKSTEMP '-DSYSTEM_INIT_FILE='/usr/X11R6/lib/X11/twm'/system.twmrc' parse.c which is not consistent, does not look very nice and requires more processing by the shell. ... but is still required for portability reasons. I have no more arguments, sorry. Please forget the issue if you don't agree with my reasoning. Done. Marc. +--+---+ | Marc Aurele La France | work: 1-780-492-9310 | | Computing and Network Services | fax:1-780-492-1729 | | 352 General Services Building | email: [EMAIL PROTECTED] | | University of Alberta +---+ | Edmonton, Alberta | | | T6G 2H1 | Standard disclaimers apply| | CANADA | | +--+---+ XFree86 Core Team member. ATI driver and X server internals. ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
Re: a small twm/Imakefile patch
Marc Aurele La France [EMAIL PROTECTED] writes: On 9 Jul 2003, Alexander Pohoyda wrote: Matthieu Herrb [EMAIL PROTECTED] writes: Alexander Pohoyda wrote (in a message from Monday 7) http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff Can you elaborate on why is it useful to switch from single quote quoting to backslashes? It may be not useful as much, but with an old version we end up calling a command: [...] cc -c [...] -DHAS_MKSTEMP '-DSYSTEM_INIT_FILE='/usr/X11R6/lib/X11/twm'/system.twmrc' parse.c which is not consistent, does not look very nice and requires more processing by the shell. ... but is still required for portability reasons. Oh! Good to know. Thanks. May I also ask on which system/shell/compiler/imake would my patch fail? Just for the record. I'm really sorry if I miss some common knowledge here. I'm wondering how this can work then: ./xc/programs/xkbcomp/Imakefile:ROOT_DEFINES = -DDFLT_XKB_CONFIG_ROOT=\$(LIBDIR)/xkb\ ./xc/programs/xdm/Imakefile:RANDOM_DEFINES = -DDEV_RANDOM=\/dev/urandom\ -- Alexander Pohoyda [EMAIL PROTECTED] ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
a small twm/Imakefile patch
Does not really deserves a Bugzilla report (1K): http://www.alexander-pohoyda.privat.t-online.de/patches/twm.Imakefile.diff -- Alexander Pohoyda [EMAIL PROTECTED] ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
