[Bug 27141] piglit glean/vertProg1 core dumps with RV790

2010-03-18 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=27141





--- Comment #2 from Chris Rankin ranki...@googlemail.com  2010-03-18 07:47:02 
PST ---
The problem happens when destroying the GLContext:

- we call _mesa_free_context_data(), which sets ctx-DrawBuffer = NULL
- _mesa_free_context_data() then calls _mesa_free_texture_data()
- _mesa_free_texture_data() calls r600DeleteTexture()
- r600DeleteTexture() calls radeonFlush() via radeon_firevertices()
- radeonFlush() tries to dereference ctx-DrawBuffer, which has just been set
to NULL
- BANG!

Adding a simple (ctx-DrawBuffer != NULL) check to radeonFlush() makes 43 of
the vertProg1 piglit tests pass, with 2 failures:

  Program: RSQ test 2 (reciprocal square root of negative value)
  Expected color: -1, 0.1, 0.447, 1
  Observed color: 0, 0, 0, 0

  Program: LIT test 2 (degenerate case: 0 ^ 0 - 1)
  Expected color: 1, 0.65, 1, 1
  Observed color: 1, 0.65098, 0, 1


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 27141] piglit glean/vertProg1 core dumps with RV790

2010-03-18 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=27141





--- Comment #3 from Pauli suok...@gmail.com  2010-03-18 12:28:50 PST ---
Patches are welcome :)

You can send the fix to mesa3d-...@lists.sourceforge.net. git commands
format-patch and send-email are very easy tools to send patches to the mailing
list.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 27141] piglit glean/vertProg1 core dumps with RV790

2010-03-18 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=27141





--- Comment #4 from Chris Rankin ranki...@googlemail.com  2010-03-18 12:38:07 
PST ---
(In reply to comment #3)
 Patches are welcome :)

Actually, I would describe this as the cause rather than the fix. I was
hoping that someone who understands what the code *should* be doing would step
in at this point. Maybe Mesa shouldn't be calling radeonFlush() in the first
place here? Or maybe ctx-DrawBuffer shouldn't be unreferenced so early in the
clean-up sequence? I have no intention of papering over this bug with an
off-hand NULL check at this stage.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[Bug 27141] piglit glean/vertProg1 core dumps with RV790

2010-03-17 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=27141





--- Comment #1 from Chris Rankin ranki...@googlemail.com  2010-03-17 15:46:41 
PST ---
This same bug seems to be triggered by bin/vp-bad-program -auto.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel