Re: [Engine-devel] Use java.util.Collection where possible?
BWT I did some checks on the GWT RPC that we use (deRPC) and there shouldn't be any problems using Collection interface (or any interface) in the generic api service. - Original Message - From: Allon Mureinik amure...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Sunday, March 4, 2012 6:57:24 PM Subject: Re: [Engine-devel] Use java.util.Collection where possible? My two cents: There are two meanings of subtyping Collection (or any other interface, for that matter) - additional logic and specific implementation. I think wherever possible, we should use the interface that infers as much logic as possible (e.g., java.util.List for ordering, java.util.Set for uniquness, java.util.SortedSet for natural ordering, etc.), without inferring any specific implementation (e.g., ArrayList, HashSet, etc.). The flipside of this notion is that it's a mistake to use an overly specific class/interface - when your parameter type is ArrayList, you implicitly tell the user the *order* of his objects matter, and that it matters to your internal algorithm to be able to do get(i) as an O(1) operation. Bottom line, now that I'm done with CS 101: +1, but be careful not use interfaces that are too low. Most methods that now receive an ArrayList will still compile if you change the parameter type to Collection, but make sure that you don't implicitly assume some ordering, e.g. -Allon - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, March 1, 2012 5:18:03 PM Subject: [Engine-devel] Use java.util.Collection where possible? Hi, I see that in some places in engine-core we use Java.Util.List, or even Java.Util.ArrayList as types of method arguments, while in the method code we do nothing besides iterating over the collection. I then found all kinds of usages like this: x.foo(new ArrayListMyType(myMap.values())); As you can see need to instantiate a new ArrayList in order to use the values of the map in method foo. Do you see any reason why not change the argument type (at method signature) to Collection in such places, where possible? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] agenda for todays meeting
Hi All, We don't have an agenda for today - open for suggestions. If no other requests will be suggested for today's agenda we'll discuss storage live migration and who ever is interested can join us. Federico/ayal can you make the slot today at 1600? Thanks, Livnat ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Hints for building up a spicec connection in Ovirt
On Wed, Mar 14, 2012 at 12:53 PM, Itamar Heim ih...@redhat.com wrote: On 03/14/2012 06:49 PM, Ewoud Kohl van Wijngaarden wrote: On Wed, Mar 14, 2012 at 05:36:38PM +0200, Itamar Heim wrote: On 03/14/2012 04:51 PM, Andrew Wells wrote: I am trying to build a connection manually with spicec (or what ever I need to build the connection with) in Ovirt/RHEV and I am wondering what do I need to form this connection? And if this is the wrong place to ask, can you point me in the correct direction? rhev-m mostly uses the activex/xpi wrappers. cc-ing spice-devel on command line invocation (or client integrating with the REST API). one thing you will need is to call the engine via the API to set the ticket (password) of the VM, to pass to the client. http://code.google.com/p/rhev-**api-labs/source/browse/python/**spice/http://code.google.com/p/rhev-api-labs/source/browse/python/spice/ is a fairly old example written for RHEV 2.2 based on the powershell RHEV-M API, but I don't think this really changed. actually, i just saw the ovirt cli has a console launch option. michael - does it launch spice as well, or only vnc? __**_ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/**mailman/listinfo/engine-develhttp://lists.ovirt.org/mailman/listinfo/engine-devel So I am assuming that building this connection up in a linux terminal on Ovirt is more or less equal to setting it up using RHEV, but is that not the case? Also what michael posted looks good, but I will need to wait before I can actually dig into that code. In the end I am hoping to just launch X and then launch the spicec session. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] [Jenkins] Auto Generated ovirt-engine rpms for fedora 16
fyi, a new Jenkins job has been added to jenkins.ovirt.org. you can now d/l fresh ovirt-engine rpms after each commit. the rpms are created and latest are stored here: http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_create_rpms/ the job will also notify the author in case his/her commit will break the rpm build. latest rpms for now: ovirt-engine-3.1.0_0001-1.8.fc16.src.rpm ovirt-engine-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-backend-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-config-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-dbscripts-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-debuginfo-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-genericapi-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-image-uploader-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-iso-uploader-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-jboss-deps-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-log-collector-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-notification-service-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-restapi-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-setup-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-tools-common-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-userportal-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-webadmin-portal-3.1.0_0001-1.8.fc16.x86_64.rpm Enjoy, Eyal Edri oVirt Infra Team ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [Jenkins] Auto Generated ovirt-engine rpms for fedora 16
Cool! Any chance to have the same with vdsm rpm's? On 14/03/12 22:45, Eyal Edri wrote: fyi, a new Jenkins job has been added to jenkins.ovirt.org. you can now d/l fresh ovirt-engine rpms after each commit. the rpms are created and latest are stored here: http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_create_rpms/ the job will also notify the author in case his/her commit will break the rpm build. latest rpms for now: ovirt-engine-3.1.0_0001-1.8.fc16.src.rpm ovirt-engine-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-backend-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-config-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-dbscripts-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-debuginfo-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-genericapi-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-image-uploader-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-iso-uploader-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-jboss-deps-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-log-collector-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-notification-service-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-restapi-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-setup-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-tools-common-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-userportal-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-webadmin-portal-3.1.0_0001-1.8.fc16.x86_64.rpm Enjoy, Eyal Edri oVirt Infra Team ___ Infra mailing list in...@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [Jenkins] Auto Generated ovirt-engine rpms for fedora 16
On 2012-3-15 4:45, Eyal Edri wrote: fyi, a new Jenkins job has been added to jenkins.ovirt.org. you can now d/l fresh ovirt-engine rpms after each commit. the rpms are created and latest are stored here: http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_create_rpms/ the job will also notify the author in case his/her commit will break the rpm build. How does it notify the submitter? By echoing messages or email notification? latest rpms for now: ovirt-engine-3.1.0_0001-1.8.fc16.src.rpm ovirt-engine-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-backend-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-config-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-dbscripts-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-debuginfo-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-genericapi-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-image-uploader-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-iso-uploader-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-jboss-deps-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-log-collector-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-notification-service-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-restapi-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-setup-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-tools-common-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-userportal-3.1.0_0001-1.8.fc16.x86_64.rpm ovirt-engine-webadmin-portal-3.1.0_0001-1.8.fc16.x86_64.rpm Enjoy, Eyal Edri oVirt Infra Team ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- Shu Mingshum...@linux.vnet.ibm.com IBM China Systems and Technology Laboratory ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
