[Firebird-devel] code quality and strange comments
Iam fairly new to the codebase but i found allready some strange stuff in some source files. Is some of this allready reviewed and/or allready fixed? firebird/trunk L1165 file: picstr.cpp Text: // Someone may have done something very stupid, like specify a repeat // count of zero. It's too late, as we've already gen'd one instance // of the edit character -- but let's not access violate, shall we? L1609 file: sort.cpp * * Boy, did the assumption below turn out to be pretty stupid! * L48 file: isql.h /* these constants are purely idiotic; there's no point in having a predefined constant with no meaning, but that's Ed Simon the master programmer for you! */ L200 file: exe.h /* CVC: Disabled this horrible hack. // Relations and procedures should be sorted before // columns, hence such a tricky inverted condition if ((v = -strcmp(i1.acc_type, i2.acc_type)) != 0) return v 0; */ K120 file: pat.cpp // CVC: kudos to the programmer that had chosen variables with the same // names that structs in gpre.h and with type char* if not enough. // Renamed ref to lang_ref and val to lang_val. -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
And? Any of these comments are not compiling? Adriano On 15/07/2015 09:17, swobje...@outlook.com wrote: Iam fairly new to the codebase but i found allready some strange stuff in some source files. Is some of this allready reviewed and/or allready fixed? firebird/trunk L1165 file: picstr.cpp Text: // Someone may have done something very stupid, like specify a repeat // count of zero. It's too late, as we've already gen'd one instance // of the edit character -- but let's not access violate, shall we? L1609 file: sort.cpp * * Boy, did the assumption below turn out to be pretty stupid! * L48 file: isql.h /* these constants are purely idiotic; there's no point in having a predefined constant with no meaning, but that's Ed Simon the master programmer for you! */ L200 file: exe.h /* CVC: Disabled this horrible hack. // Relations and procedures should be sorted before // columns, hence such a tricky inverted condition if ((v = -strcmp(i1.acc_type, i2.acc_type)) != 0) return v 0; */ K120 file: pat.cpp // CVC: kudos to the programmer that had chosen variables with the same // names that structs in gpre.h and with type char* if not enough. // Renamed ref to lang_ref and val to lang_val. -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
https://s-media-cache-ak0.pinimg.com/736x/27/69/8a/27698a48b044a7f8d46ccb4e5974d38d.jpg :) 2015-07-15 17:19 GMT+03:00 Jiří Činčura j...@cincura.net: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) -- Mgr. Jiří Činčura Independent IT Specialist -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
QLI i guess it will be removed in the future 4.x and for other parts of the code we accept pull requests :) On Wed, Jul 15, 2015 at 5:19 PM, Jiří Činčura j...@cincura.net wrote: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) -- Mgr. Jiří Činčura Independent IT Specialist -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) -- Mgr. Jiří Činčura Independent IT Specialist -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
-Original Message- From: Adriano dos Santos Fernandes [mailto:adrian...@gmail.com] Sent: Miércoles, 15 de Julio de 2015 9:23 And? Any of these comments are not compiling? Adriano Adriano, I think you shouldn't waste your time with Internet trolls. Just ignore them. Some comments predate FB (before year 2000) while others were put when we were exploring the code (FB1 or FB1.5 I guess). C. -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
Am 15.07.2015 um 16:38 schrieb marius adrian popa: QLI i guess it will be removed in the future 4.x and for other parts of the code we accept pull requests :) Ok. Is the entire devel now completely on git based? I grabbed the source from an svn repo at: svn co svn://svn.code.sf.net/p/firebird/code/ svn co svn://svn.code.sf.net/p/firebird/code/firebird/ but i found Adrianos repo at github as well (https://github.com/asfernandes/firebird) Iam not sure if svn can handle pullrequests - at all? Ok, thx On Wed, Jul 15, 2015 at 5:19 PM, Jiří Činčura j...@cincura.net mailto:j...@cincura.net wrote: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) -- Mgr. Jiří Činčura Independent IT Specialist -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
Am 15.07.2015 um 16:19 schrieb Jiří Činčura: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) exactly ;d -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
Just for the sake of you mood, i changed it ;D Am 15.07.2015 um 16:44 schrieb Adriano dos Santos Fernandes: Historic comments should be removed if they are wrong. I don't have a good mood with people hiding their names in mailing lists, like 'swobjects'. You can call me Dave ;d -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
Re: [Firebird-devel] code quality and strange comments
Historic comments should be removed if they are wrong. I don't have a good mood with people hiding their names in mailing lists, like 'swobjects'. Adriano On 15/07/2015 11:38, marius adrian popa wrote: QLI i guess it will be removed in the future 4.x and for other parts of the code we accept pull requests :) On Wed, Jul 15, 2015 at 5:19 PM, Jiří Činčura j...@cincura.net mailto:j...@cincura.net wrote: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) -- Mgr. Jiří Činčura Independent IT Specialist -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
