Re: [flex-mojos] quick fixes to mavenizer

2013-01-23 Thread Piergiorgio Niero 
ok, I'll post it there,
thank you
ciao
pigiuz

On Tuesday, January 15, 2013 6:55:29 PM UTC+1, Christofer Dutz wrote:

 Thanks for that input. As the mavenizer is an Apache flex tool, I would 
 suggest to post this to the Apache flex mailinglist. In general I created 
 the tool to generate to an empty directory so this was not an issue for me 
 ;-) but I do understand that it would be good for the tool not to die, if 
 you used an existing directory. 

 I'll look into this after coming home from my holiday.

 Chris
 Am 15.01.2013 10:24 schrieb Piergiorgio Niero 
 piergior...@gmail.comjavascript:
 :

 Hi, I'm not a committer so I'm posting here few very quick fixes I used 
 in my working copy.
 one bug was: creating folders if they already existed caused blocking 
 error.
 I don't know if it was a wanted behavior or not, but it was annoying to 
 me so I fixed it.

 *in FlexFrameworkGenerator.java


- line 675, change  
if(targetDirectory.exists()) 
with 
if(!targetDirectory.exists())
- line 610, change
if(!targetThemeVersionDirectory.mkdirs()) {
  throw new RuntimeException(Could not create directory:  
+targetThemeDirectory.getAbsolutePath()); }
with
if(!targetThemeVersionDirectory.exists()){
  if(!targetThemeVersionDirectory.mkdirs()) {
 throw new RuntimeException(Could not create directory:  + 
targetThemeDirectory.getAbsolutePath()); } }




 in FlexCompilerGenerator.java, 

 line 131 change
 if(targetJarDirectory.mkdirs())
 with 
 if(targetJarDirectory.exists() || targetJarDirectory.mkdirs())*
 *
 *
 *
 *
 In my mac I had an exception with the zip library (Zip file must have at 
 least one entry).
 In FlexFrameworkGenerator.java,
 line 178 change
 *writeDummyResourceBundleSwc(dummyRbFile);
 with this:
 if(dummyRbFile.exists())

 writeDummyResourceBundleSwc(dummyRbFile);

 Hope this helps,
 ciao
 pigiuz

 ps: I know this is not the *best* way to submit fixes, is there a 
 mechanism such as pull requests somewhere for this project?
 *

 -- 
 You received this message because you are subscribed to the Google
 Groups Flex Mojos group.
 To post to this group, send email to flex-...@googlegroups.comjavascript:
 To unsubscribe from this group, send email to
 flex-mojos+...@googlegroups.com javascript:
 For more options, visit this group at
 http://groups.google.com/group/flex-mojos
  
 http://flexmojos.sonatype.org/



-- 
You received this message because you are subscribed to the Google
Groups Flex Mojos group.
To post to this group, send email to flex-mojos@googlegroups.com
To unsubscribe from this group, send email to
flex-mojos+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/flex-mojos

http://flexmojos.sonatype.org/

Re: [flex-mojos] quick fixes to mavenizer

2013-01-17 Thread Christofer Dutz 
Thanks for that input. As the mavenizer is an Apache flex tool, I would
suggest to post this to the Apache flex mailinglist. In general I created
the tool to generate to an empty directory so this was not an issue for me
;-) but I do understand that it would be good for the tool not to die, if
you used an existing directory.

I'll look into this after coming home from my holiday.

Chris
Am 15.01.2013 10:24 schrieb Piergiorgio Niero piergiorgio.ni...@gmail.com
:

 Hi, I'm not a committer so I'm posting here few very quick fixes I used in
 my working copy.
 one bug was: creating folders if they already existed caused blocking
 error.
 I don't know if it was a wanted behavior or not, but it was annoying to me
 so I fixed it.

 *in FlexFrameworkGenerator.java


- line 675, change
if(targetDirectory.exists())
with
if(!targetDirectory.exists())
- line 610, change
if(!targetThemeVersionDirectory.mkdirs()) {
  throw new RuntimeException(Could not create directory: 
+targetThemeDirectory.getAbsolutePath()); }
with
if(!targetThemeVersionDirectory.exists()){
  if(!targetThemeVersionDirectory.mkdirs()) {
 throw new RuntimeException(Could not create directory:  +
targetThemeDirectory.getAbsolutePath()); } }




 in FlexCompilerGenerator.java,

 line 131 change
 if(targetJarDirectory.mkdirs())
 with
 if(targetJarDirectory.exists() || targetJarDirectory.mkdirs())*
 *
 *
 *
 *
 In my mac I had an exception with the zip library (Zip file must have at
 least one entry).
 In FlexFrameworkGenerator.java,
 line 178 change
 *writeDummyResourceBundleSwc(dummyRbFile);
 with this:
 if(dummyRbFile.exists())

 writeDummyResourceBundleSwc(dummyRbFile);

 Hope this helps,
 ciao
 pigiuz

 ps: I know this is not the *best* way to submit fixes, is there a
 mechanism such as pull requests somewhere for this project?
 *

 --
 You received this message because you are subscribed to the Google
 Groups Flex Mojos group.
 To post to this group, send email to flex-mojos@googlegroups.com
 To unsubscribe from this group, send email to
 flex-mojos+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/flex-mojos

 http://flexmojos.sonatype.org/


-- 
You received this message because you are subscribed to the Google
Groups Flex Mojos group.
To post to this group, send email to flex-mojos@googlegroups.com
To unsubscribe from this group, send email to
flex-mojos+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/flex-mojos

http://flexmojos.sonatype.org/

[flex-mojos] quick fixes to mavenizer

2013-01-15 Thread Piergiorgio Niero 
Hi, I'm not a committer so I'm posting here few very quick fixes I used in 
my working copy.
one bug was: creating folders if they already existed caused blocking error.
I don't know if it was a wanted behavior or not, but it was annoying to me 
so I fixed it.

*in FlexFrameworkGenerator.java


   - line 675, change  
   if(targetDirectory.exists()) 
   with 
   if(!targetDirectory.exists())
   - line 610, change
   if(!targetThemeVersionDirectory.mkdirs()) {
 throw new RuntimeException(Could not create directory:  
   +targetThemeDirectory.getAbsolutePath()); }
   with
   if(!targetThemeVersionDirectory.exists()){
 if(!targetThemeVersionDirectory.mkdirs()) {
throw new RuntimeException(Could not create directory:  + 
   targetThemeDirectory.getAbsolutePath()); } }




in FlexCompilerGenerator.java, 

line 131 change
if(targetJarDirectory.mkdirs())
with 
if(targetJarDirectory.exists() || targetJarDirectory.mkdirs())*
*
*
*
*
In my mac I had an exception with the zip library (Zip file must have at 
least one entry).
In FlexFrameworkGenerator.java,
line 178 change
*writeDummyResourceBundleSwc(dummyRbFile);
with this:
if(dummyRbFile.exists())

writeDummyResourceBundleSwc(dummyRbFile);

Hope this helps,
ciao
pigiuz

ps: I know this is not the *best* way to submit fixes, is there a mechanism 
such as pull requests somewhere for this project?
*

-- 
You received this message because you are subscribed to the Google
Groups Flex Mojos group.
To post to this group, send email to flex-mojos@googlegroups.com
To unsubscribe from this group, send email to
flex-mojos+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/flex-mojos

http://flexmojos.sonatype.org/