Re: [Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-10-04 Thread Stuart Buchanan
--- On Mon, 22/9/08, Csaba Halász wrote:
 Patch is broken in multiple places (missing line breaks,
 parts of lines)

Sorry you are having problems.

I did a comparison between the results of a straight cvs diff and what is in 
my patch, and they match (apart from date changes, and ignoring some other 
changes I've been making and removed from the .diff file).

I've also checked that I've not got any sticky tags set, so I'm at a loss as to 
what the problem can be. Any help would be appreciated.

For reference, my .cvsrc file looks like this:

cvs -z3 -q
diff -up
update -dP
checkout -P
rdiff -u

-Stuart


  

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-09-30 Thread Stuart Buchanan
(Resend - my previous reply got lost in the ether)

--- On Mon, 22/9/08, Csaba Halász wrote:
 Patch is broken in multiple places (missing line breaks,
 parts of lines)

Sorry you are having problems.

I did a comparison between the results of a straight cvs diff and what is in 
my patch, and they match (apart from date changes, and ignoring some other 
changes I've been making and removed from the .diff file).

I've also checked that I've not got any sticky tags set, so I'm at a loss as to 
what the problem can be. Any help would be appreciated.

For reference, my .cvsrc file looks like this:

cvs -z3 -q
diff -up
update -dP
checkout -P
rdiff -u

-Stuart


  

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-09-30 Thread Csaba Halász
On Tue, Sep 30, 2008 at 9:20 PM, Stuart Buchanan
[EMAIL PROTECTED] wrote:
 (Resend - my previous reply got lost in the ether)

 --- On Mon, 22/9/08, Csaba Halász wrote:
 Patch is broken in multiple places (missing line breaks,
 parts of lines)

 Sorry you are having problems.

 I did a comparison between the results of a straight cvs diff and what is 
 in my patch, and they match (apart from date changes, and ignoring some other 
 changes I've been making and removed from the .diff file).

Well, turns out most of the brokenness is ignored by patch, it just
looked wrong. Such as line 10 of simgear.diff:

@@ -203,8 +203,6 @@ void SGEnviro::startOfFrame( sgVec3 p, s

Apart from 2 problems with the dreaded $Id header in cloud.cxx and
sky.cxx it's ok.

In flightgear.diff, however, the hunk at line 36 concerning
environment_mgr.hxx doesn't have any modifications even though the
line count says a line should have been added:

@@ -58,6 +58,7 @@ public:
   virtual void bind ();
   virtual void unbind ();
   virtual void update (double dt);

   /**
* Get the environment information for the plane's current position.


Removing this hunk makes the patch apply. It does crash at runtime,
like you described, just with different numbers. So I guess that means
it's okay :)

-- 
Thanks,
Csaba/Jester

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-09-30 Thread Stuart Buchanan
--- On Tue, 30/9/08, Csaba Halász wrote:
 In flightgear.diff, however, the hunk at line 36 concerning
 environment_mgr.hxx doesn't have any modifications even
 though the
 line count says a line should have been added:
 
 @@ -58,6 +58,7 @@ public:
virtual void bind ();
virtual void unbind ();
virtual void update (double dt);
 
/**
 * Get the environment information for the plane's
 current position.

That is my fault for not removing some of my other changes properly - sorry for 
 wasting your time.

 Removing this hunk makes the patch apply. It does crash at
 runtime, like you described, just with different numbers. So I guess
 that means it's okay :)

Yes - if you ever want some patches that crash at runtime, just ask. I'm an 
expert ;)

-Stuart


  

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-09-22 Thread Vadym Kukhtin
2008/9/21 Stuart Buchanan [EMAIL PROTECTED]

 Tried apply the patch, but got

patch:  malformed patch at line 50: Index: Environment/fgclouds.cxx

And, can you make some screenshots, please?

-- 
---
WBR, Vadym.
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-09-22 Thread Martin Spott
Vadym Kukhtin wrote:
 2008/9/21 Stuart Buchanan [EMAIL PROTECTED]
 
  Tried apply the patch, but got
 
 patch:  malformed patch at line 50: Index: Environment/fgclouds.cxx

I didn't try it myself, but in general I'd say: If you require external
help to get the patch applied cleanly, then this is definitely not for
you. Did you read Stuart's elaborate comment ?

Martin.
-- 
 Unix _IS_ user friendly - it's just selective about who its friends are !
--

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


[Flightgear-devel] 3D Clouds - Update on (lack of) progress

2008-09-21 Thread Stuart Buchanan
Hi All,

I was hoping that I'd be able to provide a positive update on my work on 3-D 
clouds this weekend. 

Unfortunately, I've hit what appears to be an OSG issue that is beyond my 
knowledge to solve.

The problem I've hit relates to Impostors and Billboards. Impostors are used to 
reduce the impact of creating large billboarded clouds.

The combination of Impostors and Billboards appears to hit a resource limit on 
my graphics card (even though it is a NVidia 7600GS with 512MB of memory) and 
produces large numbers of X11 errors:

  Got an X11ErrorHandling call display=0x9a63a70 event=0xbfea0944
  BadAlloc (insufficient resources for operation)
  Major opcode: 80
  Minor opcode: 1b
  Error code: b
  Request serial: 14c8
  Current serial: 14c9
  ResourceID: 1a3

(Often I get a Major opcode of 128 rather than 80)

I don't think this is (just) my bad coding, as I've repro'd this in the example 
osgimpostor application by replacing line 159 of 
examples/osgimpostor/osgimposter.cpp with the following and rotating the camera 
for a minute or so:

 //osg::Geode * geode = new osg::Geode();
osg::Billboard * geode = new osg::Billboard();
geode-setMode(osg::Billboard::POINT_ROT_EYE);
geode-setNormal(osg::Vec3(0.0f,-1.0f,0.0f));

Due to other commitments I don't expect to have sufficient time in next 6-12 
months to be able to make any more progress on this, so I've uploaded my 
current patch to http://www.nanjika.co.uk/flightgear/clouds.tar.gz. There is a 
README file describing the patch within the tarball.

In addition to the major Impostor issue, there are a number of other bugs that 
I'm aware of (and probably many more I haven't discovered yet!):

1) On start-up 3-D clouds aren't be visible - you need to manually select a 
weather scenario to display them.
2) Currently 3-D clouds are always used if 3D clouds are enabled. The type of 
cloud used should depend on the cloud cover as well as the user's preference.
3) The cloud tiling code is bugged. Specifically, if you travel far enough in 
one direction, the clouds start getting lower. This is fairly minor - you'll 
get a METAR update before you hit this in most cases.
4) The clouds have no effect other than sprite display - visibility doesn't 
drop when you enter them, they don't appear on radar.
5) Billboards should be probably be replaced with a custom transform that stops 
billboarding when the camera gets close to the cloud and instead modifies the 
alpha value so the cloud disappears as the camera intersects it.

If someone with some OSG knowledge and sufficient time on their hands would 
like to pick it up, I'd be very grateful. 

I realize that this will be quite disappointing, especially given the rapid 
progress in OSG random objects and trees. Sadly, 3D clouds have turned out to 
be a lot harder to re-implement than I had expected.

-Stuart



  

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel