Properties - was Sponsorship
Peter B. West wrote: Finn Bock wrote: [Peter B. West] The alt-design property code was, back then, in my eyes, code written by a person who did not intuitively create object oriented design. ... It was, IMO, not a good fundation for further work. Fair enough, apart from the deferred functionality, but irrelevant. We're talking here about ideas and implementation details. I have then later looked at different times, one where I made a incorrect description of how alt-design stored references from fo-object to properties, an other when I wanted to understand why you though alt-designs Property/PropertyValue was any different from head's PropertyMaker/Property. A discussion I am always willing to have, if only to learn more about your approach. I *do* like pretty code. I asked you about it, because I had plans to adopt it. But I was not persuaded that you had the thorny problems solved, so I held off. When it's completed, I'll look again. Finn, I've just had another look at the properties code. It's not a pretty sight, is it? Understandable, because the properties system does not lend itself to simple solutions. I'll pass on adopting it though. The properties code in Folio is already considerably more comprehensible, and will become even more so when the layout work converges. In any case, it was reassuring to see the completely accidental correspondences between your work and mine. Peter -- Peter B. West http://cv.pbw.id.au/ Folio http://defoe.sourceforge.net/folio/ smime.p7s Description: S/MIME Cryptographic Signature
Inline border, padding and alignment commit
I just committed a fairly sizeable patch related to all the work on inline objects done over the last weeks. While I hope it hasn't broken anything, given its size and my inexperience with the overall FOP software base, it is actually likely that there are some unexpected regressions. Please don't hesitate to 'scream' if you see or notice something you feel is wrong or inappropriate or could be coded better or ... Manuel
Re: Inline border, padding and alignment commit
Manuel Mall schrieb: I just committed a fairly sizeable patch related to all the work on inline objects done over the last weeks. Great that you are finally able to commit .. welcome! While I hope it hasn't broken anything, given its size and my inexperience with the overall FOP software base, it is actually likely that there are some unexpected regressions. Testcase inline_border_padding_hyphenate.xml fails ;-) Christian
Re: Inline border, padding and alignment commit
On Fri, 7 Oct 2005 08:00 pm, Christian Geisert wrote: Manuel Mall schrieb: I just committed a fairly sizeable patch related to all the work on inline objects done over the last weeks. Great that you are finally able to commit .. welcome! While I hope it hasn't broken anything, given its size and my inexperience with the overall FOP software base, it is actually likely that there are some unexpected regressions. Testcase inline_border_padding_hyphenate.xml fails ;-) Christian, This is caused by fop-hyph.jar not being in your classpath. This is a new requirement for some of the tests I forgot to include into the build.xml file. Christian Manuel
Re: Inline border, padding and alignment commit
On Fri, 7 Oct 2005 08:51 pm, Jeremias Maerki wrote: Great work That's a lot of new functionality. And lots of new test cases! You're a prime role model. :-) I've got a comment and a question: - I assume the change in StaticPropertyList was a mistake: http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apac he/fop/fo/StaticPropertyList.java?rev=307055r1=307054r2=307055view= diff I put those lines in so I could set a break point for debugging when a particular property was accessed. But then I forgot to remove them. I usually add a comment like //shit when I add something like that and then search for these before committing. However, in this case I didn't follow my own procedure and there you go. - Any particular reason why chose 1mpt and not 0mpt for BPD on space and none leader in LeaderLayoutManager? http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apac he/fop/layoutmgr/inline/LeaderLayoutManager.java?rev=307055r1=307054 r2=307055view=diff Yes, any areas with a 0 BPD are dropped somewhere. For an area to be rendered it needs to have a BPD 0 and 1 was the least disruptive number I could come up with. On 07.10.2005 11:00:56 Manuel Mall wrote: I just committed a fairly sizeable patch related to all the work on inline objects done over the last weeks. While I hope it hasn't broken anything, given its size and my inexperience with the overall FOP software base, it is actually likely that there are some unexpected regressions. Please don't hesitate to 'scream' if you see or notice something you feel is wrong or inappropriate or could be coded better or ... Manuel Jeremias Maerki Manuel
Thanks to Jeremias
Jeremias has sent a most magnanimous email to me. It reflects as well on him as my imputations as to his motives reflect badly on me. My apologies to Jeremias. Peter -- Peter B. West http://cv.pbw.id.au/ Folio http://defoe.sourceforge.net/folio/ smime.p7s Description: S/MIME Cryptographic Signature
Inline border / padding and nested blocks
Luca, I would appreciate if you could please have a look at test case inline_border_padding_block_nested.xml. If you run the test case as is you get a Expect inline sequence as first sequence when last paragraph is not null message. If you comment everything out and uncomment the last block you get a ClassCastException on a Knuth element. For both issues I am a bit out of my depth and hope you could help. Thanks Manuel
Re: Welcome Manuel!
Manuel, Congratulations on your new committership. And a hearty Welcome! Regards, Web Maestro Clay -- [EMAIL PROTECTED] - http://homepage.mac.com/webmaestro/ My religion is simple. My religion is kindness. - HH The 14th Dalai Lama of Tibet
Re: Thanks to Jeremias
Peter, On Oct 7, 2005, at 6:26 AM, Peter B. West wrote: Jeremias has sent a most magnanimous email to me. It reflects as well on him as my imputations as to his motives reflect badly on me. My apologies to Jeremias. Peter Thank you for this. As I believe is true of the nature of the Apache community, I welcome constructive contributions, from wherever they come. When it gets hot is when it gets tough, but just be thankful that we don't all have to spend the holidays in one living room! I don't know if you've seen 'Home for the Holidays'[1] w Robert Downey Jr., Holly Hunter Anne Bancroft among others, but I think you get the idea! I look forward to your future posts, as they are generally constructive, informative, and (IMHO) worthy of being results to archive searches! [1] Home for the Holidays http://www.imdb.com/title/tt0113321/ Regards, Web Maestro Clay -- [EMAIL PROTECTED] - http://homepage.mac.com/webmaestro/ My religion is simple. My religion is kindness. - HH The 14th Dalai Lama of Tibet
Re: Inline border / padding and nested blocks
Manuel Mall I would appreciate if you could please have a look at test case inline_border_padding_block_nested.xml. If you run the test case as is you get a Expect inline sequence as first sequence when last paragraph is not null message. If you comment everything out and uncomment the last block you get a ClassCastException on a Knuth element. For both issues I am a bit out of my depth and hope you could help. First of all, my compliments for your wonderful work! I'll surely have a look at what happens, although I could have no time to do this until monday. Regards Luca
Re: svn commit: r307094 - /xmlgraphics/fop/trunk/src/documentation/content/xdocs/compliance.ihtml
[EMAIL PROTECTED] wrote: Supporting wrap-option=no-wrap on fo:inline will take some additional work in FOP Trunk. It works fine in 0.20.5. That's no surprise given that in the maintenance branch fo:inline doesn't create an area and is basically the same as fo:wrapper. I still wonder: creating no line breaks at all should be significantly easier than creating breaks... J.Pietschmann
Re: script property
Manuel Mall wrote: On Wed, 5 Oct 2005 04:17 pm, Jeremias Maerki wrote: On 05.10.2005 09:46:18 Manuel Mall wrote: While I am at it (this whole alignment stuff I mean) we may as well do it properly. This would include support for the script property. The allowed values for script are defined for example here: http://www.unicode.org/iso15924/iso15924-codes.html. I assume we don't bother to validate if a correct code has been provided as we don't do that for the country and language properties either (should we? If we do we need more external config files or expand fop.xconf to hold those values as they tend to change over time). We don't have to but we could. Since this is not something that changes often I wouldn't put it into the config file, but in resource files instead. OK - makes sense. Validation issues considered in alt-design circa 2002. See CountryLanguageScript.java in the alt-design code for an attempt at this. Generated from xml-lang.xml and xml-lang.xsl. No baselines. Peter -- Peter B. West http://cv.pbw.id.au/ Folio http://defoe.sourceforge.net/folio/ smime.p7s Description: S/MIME Cryptographic Signature
