Re: [fossil-users] push fails with complaint about manifest syntax error
Stephan Beal wrote: FYI: i committed one on top of that. The advantage is that it's centralized, the disadvantage is that it hashes every manifest before parsing (to get the UUID, since parsing modifies it). Might be considered too expensive, considering how rare broken manifests are. Follow-up. The investigation led to the following patch: http://fossil-scm.org/index.html/vinfo/bf3db3d16e15ee98f5c72ebdc4ff2f2ed1609ff5?sbs=0 which, if I understand correctly, only makes corrections to the error reporting, and does not change any of the core program logic. After that change, Fossil now only reports errors out of the Tcl core that I am using to implement one of my Transfer hooks. My current suspicion is that something about the PKI stuff on my server box has changed, which causes Tcl to have trouble connecting to a remote HTTPS server from my TH1 hooks. I.e. Fossil itself is no longer implicated as a contributing cause. I'll keep pulling on that thread in private, since it now seems it is specific to my particular deployment. Many thanks to Richard and Stephen for looking into it and making the improvement to the error reporting. Eric -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Stephan Beal wrote: We'd be interested in hearing back if you discover how an error on your end (if indeed it is) is confusing fossil into trying to read non-manifest files as manifests. Actually, your question sort of confuses me. From my (very tenuous) understanding of the code, it tries to read *every* incoming file during a sync as a manifest. It only takes further action if the file is successfully parsed as a manifest. This sort of thing leads to other kinds of confusion. For example, I took a snapshot of a 3rdparty repository. That 3rdparty repository itself includes a snapshot of the SQLite source tree, which had a manifest file in it. When I committed my snapshot, I suddenly saw an SQLite commit, complete with 'drh' as the committer, show up in own my project timeline! It corresponded to the data that was found in the manifest file. This supports my read of the code, I think. So the parse error is generated regardless -- the only question is whether it gets reported back to the pushing remote 'client'. That I guess is stimulated by my failing TH1 script. So Richard's change caused the true underlying cause of the error to propagate back to the client, not a 'harmless' parse error on a file that is not a manifest. But that is just my vague understanding: obviously Richard can comment more intelligently on that than I can. -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Thu, Oct 23, 2014 at 5:06 PM, Eric Rubin-Smith eas@gmail.com wrote: Stephan Beal wrote: We'd be interested in hearing back if you discover how an error on your end (if indeed it is) is confusing fossil into trying to read non-manifest files as manifests. Actually, your question sort of confuses me. From my (very tenuous) understanding of the code, it tries to read *every* incoming file during a sync as a manifest. It only takes further action if the file is successfully parsed as a manifest. That might be (i'm not yet familiar with how sync works), in which case ignore what i said. i'm curious as to why that was triggering a fatal error (manifest parse) in your case, though. manifest file in it. When I committed my snapshot, I suddenly saw an SQLite commit, complete with 'drh' as the committer, show up in own my project timeline! It corresponded to the data that was found in the manifest file. This supports my read of the code, I think. i remember that coming up a couple weeks back. Similarly, the name drh shows up in the libfossil repo because i accidentally imported a manifest or two from the fossil repo while testing libfossil's manifest parsing/saving. So the parse error is generated regardless -- the only question is whether it gets reported back to the pushing remote 'client'. That I guess is stimulated by my failing TH1 script. So Richard's change caused the true underlying cause of the error to propagate back to the client, not a 'harmless' parse error on a file that is not a manifest. But that is just my vague understanding: obviously Richard can comment more intelligently on that than I can. Your explanation makes sense to me. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] push fails with complaint about manifest syntax error
I haven't changed much recently about my repository topology. One central master repo that I push to from my dev repo. No one else is doing any pushing. The master repo has hooks set up for publishing my commits etc to a remote HTTP REST API. The only change I made recently is to open up my same local repo a second time into a new sandbox. That worked fine for many commits. But today I suddenly see this: $ fossil version This is fossil version 1.29 [3e5ebe2b90] 2014-06-12 17:25:56 UTC $ uname -a Linux miami 3.6.11-4.fc16.x86_64 #1 SMP Tue Jan 8 20:57:42 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux $ fossil commit --branch test -m Test check-in. New_Version: 81ba47a887f005b11fe14aedb9c8c25f0bc23ffe $ fossil push Push to https://eas@snip:10444/ Round-trips: 1 Artifacts sent: 2 received: 0 Error: push script failed: syntax error in manifest Round-trips: 1 Artifacts sent: 2 received: 0 Push finished with 817830 bytes sent, 330 bytes received $ fossil push Push to https://eas@snip:10444/ Round-trips: 1 Artifacts sent: 0 received: 0 Push finished with 817459 bytes sent, 286 bytes received The only interesting thing I did recently was (a) make a commit from my old sandbox on a dev branch; (b) switch to my new sandbox, make two new unrelated commits to trunk; (c) cherrypick the commit I made in (a) to trunk. That's when the issue seems to have started. The data appears to have landed on the server properly. The error now happens consistently every time I try a check-in + push sequence (twice in a row, anyway). My Transfer hooks on the server don't seem to have fired. I tried this, which doesn't give much useful info: $ fossil test-parse-manifest ./manifest $ echo $? 0 $ I assume it's the remove fossil complaining, though -- not the local one. How can I gather more info? ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 6:31 PM, Eric Rubin-Smith eas@gmail.com wrote: I tried this, which doesn't give much useful info: $ fossil test-parse-manifest ./manifest I assume it's the remove fossil complaining, though -- not the local one. That's my assumption, too, but can you paste that one for us? How can I gather more info? i thought fossil had an undocumented option to dump the generated manifest out to a file, but it turns out it's a config option: fossil set manifest on (if it's not already) and then the manifest should be dumped to manifest.uuid. Please post the contents of that file for a checkin which fails this way, and i think that will show us what's wrong. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 6:48 PM, Stephan Beal sgb...@googlemail.com wrote: fossil set manifest on (if it's not already) and then the manifest should be dumped to manifest.uuid. Please post the contents of that file for a checkin which fails this way, and i think that will show us what's wrong. My mistake: that file only holds the UUID. Please post the manifest file. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 7:22 PM, Stephan Beal sgb...@googlemail.com wrote: [stephan@host:~/cvs/fossil/cwal]$ f-mfparse ~/Downloads/manifest.txt Parsing this manifest: /home/stephan/Downloads/manifest.txt f-mfparse: ERROR #128 (FSL_RC_CA_SYNTAX): Malformed UUID in F-card Now i need to expand the error reporting to tell us which F-card it's choking on (you've got 9040 of them!). No need for that - the debugger sufficed. fossil also fails (in the same place) with: f test-parse-manifest ~/Downloads/manifest.txt ERROR: line 3: F-card UUID is the wrong size Line 3 is: F .fossil-settings/allow-symlinks a09a968bf05a50058f3ad50132730b719bc39e76 That UUID is 40 bytes long, i.e. an SHA1 hash, which is syntactically correct So i'm not sure what he's complaining about. Will need to run this through the debugger to find out what the problem is. Both fossil and libfossil fail on that line, but my eyes don't see a reason for it. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Can somebody please forward the bad manifest to me too? On Wed, Oct 15, 2014 at 1:31 PM, Stephan Beal sgb...@googlemail.com wrote: On Wed, Oct 15, 2014 at 7:22 PM, Stephan Beal sgb...@googlemail.com wrote: [stephan@host:~/cvs/fossil/cwal]$ f-mfparse ~/Downloads/manifest.txt Parsing this manifest: /home/stephan/Downloads/manifest.txt f-mfparse: ERROR #128 (FSL_RC_CA_SYNTAX): Malformed UUID in F-card Now i need to expand the error reporting to tell us which F-card it's choking on (you've got 9040 of them!). No need for that - the debugger sufficed. fossil also fails (in the same place) with: f test-parse-manifest ~/Downloads/manifest.txt ERROR: line 3: F-card UUID is the wrong size Line 3 is: F .fossil-settings/allow-symlinks a09a968bf05a50058f3ad50132730b719bc39e76 That UUID is 40 bytes long, i.e. an SHA1 hash, which is syntactically correct So i'm not sure what he's complaining about. Will need to run this through the debugger to find out what the problem is. Both fossil and libfossil fail on that line, but my eyes don't see a reason for it. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 7:31 PM, Stephan Beal sgb...@googlemail.com wrote: F .fossil-settings/allow-symlinks a09a968bf05a50058f3ad50132730b719bc39e76 That UUID is 40 bytes long, i.e. an SHA1 hash, which is syntactically correct So i'm not sure what he's complaining about. Will need to run this through the debugger to find out what the problem is. Both fossil and libfossil fail on that line, but my eyes don't see a reason for it. According my debugger, that uuid is 41 bytes long, including a carriage-return character. How on earth that happend is a mystery to me, as fossil does not use \r characters anywhere unless it's prescribed by a standard (e.g. HTTP headers). The C-card also contains a trailing \r character, as does the D-card. i don't know how you've done it, but your system is writing the manifest with Windows newlines in it. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Stephan Beal wrote: According my debugger, that uuid is 41 bytes long, including a carriage-return character. How on earth that happend is a mystery to me, as fossil does not use \r characters anywhere unless it's prescribed by a standard (e.g. HTTP headers). The C-card also contains a trailing \r character, as does the D-card. i don't know how you've done it, but your system is writing the manifest with Windows newlines in it. How dare you suggest it! :) I don't think that's what's happening. Maybe that was your mail client when you saved my attachment, or mine when I initially sent it (though I doubt it, since I am using a Linux + mutt). Here's what I see in 'hexedit': 43 20 43 68 65 63 6B 2D 69 6E 5C 73 66 6F 72 5C C Check-in\sfor\ 0010 73 6F 66 66 69 63 69 61 6C 5C 73 62 75 69 6C 64 sofficial\sbuild 0020 2E 0A 44 20 32 30 31 34 2D 31 30 2D 31 35 54 31 ..D 2014-10-15T1 0030 36 3A 33 38 3A 35 37 2E 39 34 37 0A 46 20 2E 66 6:38:57.947.F .f 0040 6F 73 73 69 6C 2D 73 65 74 74 69 6E 67 73 2F 61 ossil-settings/a 0050 6C 6C 6F 77 2D 73 79 6D 6C 69 6E 6B 73 20 61 30 llow-symlinks a0 0060 39 61 39 36 38 62 66 30 35 61 35 30 30 35 38 66 9a968bf05a50058f 0070 33 61 64 35 30 31 33 32 37 33 30 62 37 31 39 62 3ad50132730b719b 0080 63 33 39 65 37 36 0A 46 20 33 72 64 70 61 72 74 c39e76.F 3rdpart 0090 79 2F 4D 61 6B 65 66 69 6C 65 20 34 31 61 32 65 y/Makefile 41a2e No 0Ds in there. Let me re-send you the manifest as a 'gz' file. Hopefully no code between me and you will be too clever for its own good this time. -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 7:44 PM, Eric Rubin-Smith eas@gmail.com wrote:
How dare you suggest it! :) I don't think that's what's happening.
Maybe that was your mail client when you saved my attachment, or mine
when I initially sent it (though I doubt it, since I am using a
Linux + mutt).
Here's what I see in 'hexedit':
43 20 43 68 65 63 6B 2D 69 6E 5C 73 66 6F 72 5C C
Check-in\sfor\
0010 73 6F 66 66 69 63 69 61 6C 5C 73 62 75 69 6C 64
sofficial\sbuild
0020 2E 0A 44 20 32 30 31 34 2D 31 30 2D 31 35 54 31 ..D
2014-10-15T1
Indeed. Then my copy is bad. emacs is also saying DOS in the lower left,
but it's not showing them as ^M like it normally does.
Let me re-send you the manifest as a 'gz' file. Hopefully no code
between me and you will be too clever for its own good this time.
Good idea. Please send it to Richard, too.
--
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
Freedom is sloppy. But since tyranny's the only guaranteed byproduct of
those who insist on a perfect world, freedom will have to do. -- Bigby Wolf
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 7:47 PM, Stephan Beal sgb...@googlemail.com wrote: On Wed, Oct 15, 2014 at 7:44 PM, Eric Rubin-Smith eas@gmail.com wrote: Let me re-send you the manifest as a 'gz' file. Hopefully no code between me and you will be too clever for its own good this time. No, that one looks good: [stephan@host:~/cvs/fossil/libfossil/f-apps]$ f test-parse-manifest ~/Downloads/manifest [stephan@host:~/cvs/fossil/libfossil/f-apps]$ ./f-mfparse ~/Downloads/manifest Parsing this manifest: /home/stephan/Downloads/manifest Artifact type=CHECKIN, rid=0, uuid=e3bb18bb3d27b7b91158864dbee53979ed30fa3d Round-trip re-generated artifact (type=CHECKIN) from input file: Rather large - not dumping to console. Dumping mf to file [mf.out] SHA of [mf.out] = [e3bb18bb3d27b7b91158864dbee53979ed30fa3d] SHA match? yes No matching RID found: this is only an error if the artifact came from the current repo. (All that means is that libfossil was able to read and re-generate the manifest with 100% fidelity. i.e. not so much as a timestamp rounding error in the round trip, which occasionally happens.) In addition: [stephan@host:~/Downloads]$ sha1sum manifest e3bb18bb3d27b7b91158864dbee53979ed30fa3d manifest so the hashes match up there, too. i'm at a loss. Perhaps Richard can suggest the next thing to try. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 1:47 PM, Stephan Beal sgb...@googlemail.com wrote: Let me re-send you the manifest as a 'gz' file. Hopefully no code between me and you will be too clever for its own good this time. Good idea. Please send it to Richard, too. fossil test-parse runs without error on the new manifest. Are you sure that is the manifest that is causing the problem? Perhaps we should enhance the error message to include the UUID of the problem manifest as part of the error message? -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 7:56 PM, Richard Hipp d...@sqlite.org wrote: Perhaps we should enhance the error message to include the UUID of the problem manifest as part of the error message? Working on a patch now. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Richard Hipp wrote:
Are you sure that is the manifest that is causing the problem? Perhaps we
should enhance the error message to include the UUID of the problem
manifest as part of the error message?
In case you find it useful for your debugging, I have continued plodding
along with my normal work today, and continue seeing the error:
$ fossil commit
vim ../../../ci-comment-0CB216CD5263.txt
New_Version: efc2f0ca8089b41f9aa144480d530737fa38e755
$ fossil push
Push to https://eas@snip:10444/
Round-trips: 1 Artifacts sent: 4 received: 0
Error: push script failed: syntax error in manifest
Round-trips: 1 Artifacts sent: 4 received: 0
Push finished with 819175 bytes sent, 330 bytes received
My commits continue showing up in the remote repo, despite the error.
Might have something more to do with the Transfer hooks TH1 stuff
('push script failed') than the sync logic itself? Let me know if
you would like to see that TH1 script.
Eric
--
Eric A. Rubin-Smith
Aterlo Networks, Inc.
http://aterlo.com
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 2:15 PM, Eric Rubin-Smith eas@gmail.com wrote:
Richard Hipp wrote:
Are you sure that is the manifest that is causing the problem? Perhaps
we
should enhance the error message to include the UUID of the problem
manifest as part of the error message?
In case you find it useful for your debugging, I have continued plodding
along with my normal work today, and continue seeing the error:
Can you try compiling the tip of the better-error-msgs branch and put
that on your server, then let us know what the new error message is?
$ fossil commit
vim ../../../ci-comment-0CB216CD5263.txt
New_Version: efc2f0ca8089b41f9aa144480d530737fa38e755
$ fossil push
Push to https://eas@snip:10444/
Round-trips: 1 Artifacts sent: 4 received: 0
Error: push script failed: syntax error in manifest
Round-trips: 1 Artifacts sent: 4 received: 0
Push finished with 819175 bytes sent, 330 bytes received
My commits continue showing up in the remote repo, despite the error.
Might have something more to do with the Transfer hooks TH1 stuff
('push script failed') than the sync logic itself? Let me know if
you would like to see that TH1 script.
Eric
--
Eric A. Rubin-Smith
Aterlo Networks, Inc.
http://aterlo.com
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
--
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Stephan Beal wrote: Working on a patch now. Sorry, I'm realizing that the Fossil version I mentioned (1.29) is tainted with my own private changes to the C code (to get my TH1 hooks working). I submitted them to this list, and Joe Mistachkin accepted them -- but with significant changes. It may be that this is my fault, not Fossil's. I would like to eliminate that possibility myself, for fear that I am wasting your time on an issue that does not affect anyone but me. What is a good fossil trunk version for me to re-test with? -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Richard Hipp wrote: Can you try compiling the tip of the better-error-msgs branch and put that on your server, then let us know what the new error message is? Our emails crossed paths. I'll do as you suggest and let you know what happens. -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Richard Hipp wrote: Can you try compiling the tip of the better-error-msgs branch and put that on your server, then let us know what the new error message is? Here we go: $ fossil push Push to https://eas@snip:10444/ Round-trips: 1 Artifacts sent: 2 received: 0 Error: push script failed: syntax error in manifest [449bc674c3fc9c036db0d4dc71281b7cb900fe7d] Round-trips: 1 Artifacts sent: 2 received: 0 Push finished with 818173 bytes sent, 385 bytes received $ -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 8:27 PM, Eric Rubin-Smith eas@gmail.com wrote: Error: push script failed: syntax error in manifest [449bc674c3fc9c036db0d4dc71281b7cb900fe7d] You mention custom changes with regards to push scripts, which make me curious about that error message: i can find push script failed nowhere in fossil. Where is it coming from (if you know)? -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 8:19 PM, Richard Hipp d...@sqlite.org wrote: On Wed, Oct 15, 2014 at 2:15 PM, Eric Rubin-Smith eas@gmail.com wrote: Richard Hipp wrote: Are you sure that is the manifest that is causing the problem? Perhaps we should enhance the error message to include the UUID of the problem manifest as part of the error message? In case you find it useful for your debugging, I have continued plodding along with my normal work today, and continue seeing the error: Can you try compiling the tip of the better-error-msgs branch and put that on your server, then let us know what the new error message is? FYI: i committed one on top of that. The advantage is that it's centralized, the disadvantage is that it hashes every manifest before parsing (to get the UUID, since parsing modifies it). Might be considered too expensive, considering how rare broken manifests are. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Eric Rubin-Smith wrote: $ fossil push Push to https://eas@snip:10444/ Round-trips: 1 Artifacts sent: 2 received: 0 Error: push script failed: syntax error in manifest [449bc674c3fc9c036db0d4dc71281b7cb900fe7d] Round-trips: 1 Artifacts sent: 2 received: 0 Push finished with 818173 bytes sent, 385 bytes received $ Looks like that hex value is the artifact ID for the file I edited for the test check-in. The relevant bytes from the manifest seem fine, to my eye. 'F', space, filename, space, 40 hex digits, newline. The fossil server is sitting behind stunnel. I'll see if I can take a quick capture of the unencrypted traffic -- maybe it'll shed light on something. -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
Stephan Beal wrote: You mention custom changes with regards to push scripts, which make me curious about that error message: i can find push script failed nowhere in fossil. Where is it coming from (if you know)? The strings are escaped :) eric@dev:~/Fossil-5ff4e33617/src$ grep -r 'push\\s' . ./xfer.c:@ error not\sauthorized\sto\spush\sconfiguration ./xfer.c:@ error push\sscript\sfailed:\s%F(g.zErrMsg) I compiled your better-error-messages Fossil, and that's what I'm running now. So the currently-running code is no longer tainted by my private edits, though of course if I managed to screw up my repo with my private changes then we still might be seeing the result of that. Not that I think that is particularly likely, but I'm a fossil-hacking noob so what do I know. -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 2:27 PM, Eric Rubin-Smith eas@gmail.com wrote: Richard Hipp wrote: Can you try compiling the tip of the better-error-msgs branch and put that on your server, then let us know what the new error message is? Here we go: $ fossil push Push to https://eas@snip:10444/ Round-trips: 1 Artifacts sent: 2 received: 0 Error: push script failed: syntax error in manifest [449bc674c3fc9c036db0d4dc71281b7cb900fe7d] Round-trips: 1 Artifacts sent: 2 received: 0 Push finished with 818173 bytes sent, 385 bytes received $ Great. Now please do fossil artifact 449bc674c problem.txt and send me the problem.txt file. -- Eric A. Rubin-Smith Aterlo Networks, Inc. http://aterlo.com ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] push fails with complaint about manifest syntax error
On Wed, Oct 15, 2014 at 2:36 PM, Stephan Beal sgb...@googlemail.com wrote: FYI: i committed one on top of that. The advantage is that it's centralized, the disadvantage is that it hashes every manifest before parsing (to get the UUID, since parsing modifies it). Might be considered too expensive, considering how rare broken manifests are. Isn't the name of the manifest artifact the UUID of the manifest? Or at least the primary key in the artifact table? ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
