Re: [fpc-devel] ANN: Management operators - final patch

[Florian Klämpfl]

Am 21.11.2016 um 02:54 schrieb Paul Ishenin:
> 21.11.2016 8:16, Maciej Izak wrote:
> 
> Overall you've made a great job and a perfect example of how to supply 
> patches for FPC.
> 
> I have a small question regards the following commit:
>> 13. 
>> https://github.com/maciej-izak/freepascal/commit/9baa32a49a204686427981d33c9054f64b2057c4
> 
> Use fpc_Copy for Clone and fpc_Addref for Copy is misleading.

Copy is only equal to addref in case of arc types. If a type is only managed 
like a variant, copy is
not an addref operation. So it should not be called addref. As fpc_addref is 
not exposed to users I
think we can handle this.

> 
> I know Florian insisted on Copy and Clone names but still for my taste it 
> would be the best to have
> conformity between compiler and RTL.

___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Re: [fpc-devel] ANN: Management operators - final patch

[Maciej Izak]

2016-11-21 2:16 GMT+01:00 Maciej Izak :

> I have new dedicated branch located here:
>
> https://github.com/maciej-izak/freepascal/tree/fpc-management-operators
>

note: management operators are also available in version for NewPascal :

https://github.com/maciej-izak/freepascal/tree/management-operators


If someone is interested in tests, "ready to use" compiler with management
operators and latest Lazarus is available at:

http://newpascal.org

-- 
Best regards,
Maciej Izak
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Re: [fpc-devel] ANN: Management operators - final patch

[Maciej Izak]

2016-11-21 2:54 GMT+01:00 Paul Ishenin :

> Use fpc_Copy for Clone and fpc_Addref for Copy is misleading.


First of all I don't like to have Florian in opposition to this feature ;)
it is a teamwork.

Anyway I agree that this is misleading... But as was suggested by Florian
(as far as I understand):

On the language level Clone and Copy is totally new feature. Users don't
have direct access to FPC_COPY nor FPC_ADDREF. FPC_COPY and FPC_ADDREF
naming is outdated and probably renaming to FPC_CLONE and FPC_COPY is good
idea, but old convention is still in usage for backward compatibility with
old code (for "alias"/"public name" feature).

I can't do much in this matter.
-- 
Best regards,
Maciej Izak
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Re: [fpc-devel] ANN: Management operators - final patch

[Sven Barth]

Am 21.11.2016 02:17 schrieb "Maciej Izak" :
>
> Hi,
>
> Patch for management operators is totally reworked. All suggestions from
Florian, Jonas and Sven have been implemented. This is the third attempt.
My base is trunk r34916. Each commit works well with "make clean all". I
have new dedicated branch located here:

Thank you for your rework. That will definitely make things easier to
include :D

Regards,
Sven
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Re: [fpc-devel] ANN: Management operators - final patch

[Paul Ishenin]

21.11.2016 8:16, Maciej Izak wrote:

Overall you've made a great job and a perfect example of how to supply 
patches for FPC.


I have a small question regards the following commit:
13. 
https://github.com/maciej-izak/freepascal/commit/9baa32a49a204686427981d33c9054f64b2057c4


Use fpc_Copy for Clone and fpc_Addref for Copy is misleading.

I know Florian insisted on Copy and Clone names but still for my taste 
it would be the best to have conformity between compiler and RTL.


--
Best regards,
Paul Ishenin
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel