Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed
On 2021-05-14 15:15, Christoph Moench-Tegeder wrote: ## Chris (portmas...@bsdforge.com): The problem I'm addressing in this case; is that the following as *always* worked for licenses which carried a copy in ${WRKSRC}/LICENSE_NAME: The problem you're trying to address is only a consecutive error and not the real problem. As I wrote in my first reply: : Foremost, that Makefile has an .include, and that's where the mess : (for this use case) happens. DO'H! Sorry. I've been fairly overwhelmed w/$DAYJOB so *clearly* glossed over that (important) section. Thank you for taking the time to use your "clue bat" on me. :-) Yes. That's *exactly* why the error(s) are occurring. The only question I have at this juncture; is *why* after some ~5yrs later is it *now* throwing an error? Oh well. In any case, I can easily resolve the problem and set things straight with these ports. Thanks again! :-) --Chris An .include includes the given file at that point (duh), and in this case that's kde-icons-noia/Makefile.icons, which overwrites your LICENSE variables (and brings in LICENSE_TEXT). And, as stated before: that cannot be your intention (and including kde-icons-noia/Makefile.icons only makes sense in a very limited number of ports if at all). And you can (and should, in case of doubt or problems) double-check your variables by running e.g. "make -V LICENSE" in the port's directory (or "make -C -V ", yadda yadda, make(1), etc). > you're not allowed to just put another license on that port. I'm not. It's a verbatim LGPL3 port && license as reported within the port' source. :-) : cmt: x11-themes/kde-icons-nuovext2$ make -V LICENSE : theme That's not LGPL3. Regards, Christoph ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed
## Chris (portmas...@bsdforge.com): > The problem I'm addressing in this case; is that the following as > *always* worked for licenses which carried a copy in > ${WRKSRC}/LICENSE_NAME: The problem you're trying to address is only a consecutive error and not the real problem. As I wrote in my first reply: : Foremost, that Makefile has an .include, and that's where the mess : (for this use case) happens. An .include includes the given file at that point (duh), and in this case that's kde-icons-noia/Makefile.icons, which overwrites your LICENSE variables (and brings in LICENSE_TEXT). And, as stated before: that cannot be your intention (and including kde-icons-noia/Makefile.icons only makes sense in a very limited number of ports if at all). And you can (and should, in case of doubt or problems) double-check your variables by running e.g. "make -V LICENSE" in the port's directory (or "make -C -V ", yadda yadda, make(1), etc). > > you're not allowed to just put another license on that port. > I'm not. It's a verbatim LGPL3 port && license as reported > within the port' source. :-) : cmt: x11-themes/kde-icons-nuovext2$ make -V LICENSE : theme That's not LGPL3. Regards, Christoph -- Spare Space ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed
On 2021-05-14 14:19, Christoph Moench-Tegeder wrote: ## Chris (portmas...@bsdforge.com): > but the way it currently interacts > with your port is not that fine: in the very least, it overwrites > your LICENSE variables, which cannot be your intention. (Try > "make -V LICENSE" in kde-icons-nuovoext2). Sorry. My bad. LGPL3 is now included in the current LICENSE Templates. So LICENSE_FILE is redundant && pkg-fallout (the ports framework) was trying to use a "clue bat" to tell me so. ;-) Absolutely not. Due to the included file, your port has not set the LICENSE to "LGPL3" but to "theme". That is a severe problem, you're not allowed to just put another license on that port. It's also not "look at the Makefile, the intention is clear": the LICENSE field ends up in the package, and there's no weaseling around the problem. Code bugs may be annoying, but "wrong license" is a mistake with potential to awaken the lawyers. Fix it. I'm confused by your reply. The problem I'm addressing in this case; is that the following as *always* worked for licenses which carried a copy in ${WRKSRC}/LICENSE_NAME: LICENSE=LICENSE_TYPE LICENSE_FILE= ${WRKSRC}/LICENSE_NAME however. I've recently been plagued with complaints from pkg-fallout: ===> License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed make: exec(exit) failed (No such file or directory) *** Error code 1 When using that strategy. Sure enough; when performing a make test on the problem port. I get roughly the same ERROR. Curious I thought. Something in the ports framework must have changed. fe; LICENSE=LGPL3 LICENSE_FILE= ${WRKSRC}/COPYING fails. EVEN though the file ${WRKSRC}/COPYING exists. ALSO; LICENSE_FILE *and* LICENSE_TEXT are not BOTH defined, as stated in the ERROR output. Removing LICENSE_FILE returns; no problems with port. So there you have it. The long version. :-) you're not allowed to just put another license on that port. I'm not. It's a verbatim LGPL3 port && license as reported within the port' source. :-) Code bugs may be annoying, but "wrong license" is a mistake with potential to awaken the lawyers. I'm well versed in law, and I've performed nothing contrary to the ports' source' intent. :-) --Chris Regards, Christoph ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed
## Chris (portmas...@bsdforge.com): > > but the way it currently interacts > > with your port is not that fine: in the very least, it overwrites > > your LICENSE variables, which cannot be your intention. (Try > > "make -V LICENSE" in kde-icons-nuovoext2). > Sorry. My bad. LGPL3 is now included in the current LICENSE Templates. > So LICENSE_FILE is redundant && pkg-fallout (the ports framework) was > trying to use a "clue bat" to tell me so. ;-) Absolutely not. Due to the included file, your port has not set the LICENSE to "LGPL3" but to "theme". That is a severe problem, you're not allowed to just put another license on that port. It's also not "look at the Makefile, the intention is clear": the LICENSE field ends up in the package, and there's no weaseling around the problem. Code bugs may be annoying, but "wrong license" is a mistake with potential to awaken the lawyers. Fix it. Regards, Christoph -- Spare Space ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed
On 2021-05-13 09:08, Christoph Moench-Tegeder wrote: ## Chris (portmas...@bsdforge.com): HOWEVER the error returned by pkg-fallout@ makes absolutely no sense at all, given the Makefile for the report contains only: Foremost, that Makefile has an .include, and that's where the mess (for this use case) happens. From a quick glance, I'm not totally sure how that kde-icons-noia/Makefile.icons makes sense in the grand scheme of things (if it's that common functionality, should it live somewhere in Mk? if it's relevant only for a very limited number of ports, should it have some comments about that?), but the way it currently interacts with your port is not that fine: in the very least, it overwrites your LICENSE variables, which cannot be your intention. (Try "make -V LICENSE" in kde-icons-nuovoext2). Sorry. My bad. LGPL3 is now included in the current LICENSE Templates. So LICENSE_FILE is redundant && pkg-fallout (the ports framework) was trying to use a "clue bat" to tell me so. ;-) Sorry for the noise, and thanks for taking the time to reply. --Chris Regards, Christoph ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: pkg-fallout: License not correctly defined: defining both LICENSE_FILE and LICENSE_TEXT is not allowed
## Chris (portmas...@bsdforge.com): > HOWEVER the error returned by pkg-fallout@ makes absolutely no > sense at all, given the Makefile for the report contains only: Foremost, that Makefile has an .include, and that's where the mess (for this use case) happens. >From a quick glance, I'm not totally sure how that kde-icons-noia/Makefile.icons makes sense in the grand scheme of things (if it's that common functionality, should it live somewhere in Mk? if it's relevant only for a very limited number of ports, should it have some comments about that?), but the way it currently interacts with your port is not that fine: in the very least, it overwrites your LICENSE variables, which cannot be your intention. (Try "make -V LICENSE" in kde-icons-nuovoext2). Regards, Christoph -- Spare Space ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"