SOLVED?! ( was Re: BUG?! (was Re: date type attribute not added to accounting request using attr_rewrite)

2003-12-07 Thread Paul Sijben
I found now WHY a change in attr_rewrite when used in pre-Proxy does not
work. It operates on request-packet rather than request-proxy.

Now the question is which ought to be fixed; the call to pre-proxy in
procy.c or the pre-proxy chain that uses standard calls to operate on
the request?

I am now testing the former. I would appreciate feedback if that is correct.

BTW: I would also appreciate input on where to look for the problem not
getting any rewriting out of mod_perl.  

Paul

Alan DeKok wrote:

I am happy to help fix it as I need this to work soon. However I would
appreciate some pointers where to look.
 
 
   src/lib/valuepair.c, function paircreate()
 
   Alan DeKok.
 
 - 
 List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
 


-- 
Paul Sijben  tel: +31205210321
VP Architecture and Business Development  direct: +31205210333
Picopointfax: +31205210320
Amsterdam mobile: +31629582154
the Netherlands   http://www.picopoint.com

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: SOLVED?! ( was Re: BUG?! (was Re: date type attribute not added to accounting request using attr_rewrite)

2003-12-07 Thread Alan DeKok
Paul Sijben [EMAIL PROTECTED] wrote:
 I found now WHY a change in attr_rewrite when used in pre-Proxy does not
 work. It operates on request-packet rather than request-proxy.

  That should be fixed.

 Now the question is which ought to be fixed; the call to pre-proxy in
 procy.c 

  Absolutely not.  I don't know what you would change there, or why.

or the pre-proxy chain that uses standard calls to operate on
 the request?

  I don't know what you mean by that, either.

  You said the module doesn't do what you expect.  Why not change the
module?

  The configuration for the module currently allows it to search in
the packet, config, or reply.  Why not add proxy and prpxy_reply'
to that list?

  Alan DeKok.

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: SOLVED?! ( was Re: BUG?! (was Re: date type attribute not added to accounting request using attr_rewrite)

2003-12-07 Thread Kostas Kalevras
On Sun, 7 Dec 2003, Alan DeKok wrote:

 Paul Sijben [EMAIL PROTECTED] wrote:
  I found now WHY a change in attr_rewrite when used in pre-Proxy does not
  work. It operates on request-packet rather than request-proxy.

   That should be fixed.

  Now the question is which ought to be fixed; the call to pre-proxy in
  procy.c

   Absolutely not.  I don't know what you would change there, or why.

 or the pre-proxy chain that uses standard calls to operate on
  the request?

   I don't know what you mean by that, either.

   You said the module doesn't do what you expect.  Why not change the
 module?

   The configuration for the module currently allows it to search in
 the packet, config, or reply.  Why not add proxy and prpxy_reply'
 to that list?

OK fixed.


   Alan DeKok.

 -
 List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


--
Kostas Kalevras Network Operations Center
[EMAIL PROTECTED]   National Technical University of Athens, Greece
Work Phone: +30 210 7721861
'Go back to the shadow' Gandalf

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: SOLVED?! ( was Re: BUG?! (was Re: date type attribute not added to accounting request using attr_rewrite)

2003-12-07 Thread Paul Sijben
Alan DeKok wrote:

 Paul Sijben [EMAIL PROTECTED] wrote:
 
I found now WHY a change in attr_rewrite when used in pre-Proxy does not
work. It operates on request-packet rather than request-proxy.
 
 
   That should be fixed.
 
 
Now the question is which ought to be fixed; the call to pre-proxy in
procy.c 
 
 
   Absolutely not.  I don't know what you would change there, or why.
 

Working off the 0.9.3 source code I found that the changes attr_rewrite
made to the vps went nowhere since they were attached to the original
packet rather than the one that is sent to the remote server.

So I moved the call to before the copy is made and the thing worked
perfectly.

Paul
 
or the pre-proxy chain that uses standard calls to operate on
the request?
 
 
   I don't know what you mean by that, either.
 
   You said the module doesn't do what you expect.  Why not change the
 module?
 
   The configuration for the module currently allows it to search in
 the packet, config, or reply.  Why not add proxy and prpxy_reply'
 to that list?
 
   Alan DeKok.
 
 - 
 List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
 


-- 
Paul Sijben  tel: +31205210321
VP Architecture and Business Development  direct: +31205210333
Picopointfax: +31205210320
Amsterdam mobile: +31629582154
the Netherlands   http://www.picopoint.com

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: SOLVED?! ( was Re: BUG?! (was Re: date type attribute not added to accounting request using attr_rewrite)

2003-12-07 Thread Paul Sijben
Ah, I see what you mean. Ok that will work as well ;-)

Paul

Kostas Kalevras wrote:

 On Sun, 7 Dec 2003, Alan DeKok wrote:
 
 
Paul Sijben [EMAIL PROTECTED] wrote:

I found now WHY a change in attr_rewrite when used in pre-Proxy does not
work. It operates on request-packet rather than request-proxy.

  That should be fixed.


Now the question is which ought to be fixed; the call to pre-proxy in
procy.c

  Absolutely not.  I don't know what you would change there, or why.


or the pre-proxy chain that uses standard calls to operate on
the request?

  I don't know what you mean by that, either.

  You said the module doesn't do what you expect.  Why not change the
module?

  The configuration for the module currently allows it to search in
the packet, config, or reply.  Why not add proxy and prpxy_reply'
to that list?
 
 
 OK fixed.
 
 
  Alan DeKok.

-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

 
 
 --
 Kostas Kalevras   Network Operations Center
 [EMAIL PROTECTED] National Technical University of Athens, Greece
 Work Phone:   +30 210 7721861
 'Go back to the shadow'   Gandalf
 
 - 
 List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
 


-- 
Paul Sijben  tel: +31205210321
VP Architecture and Business Development  direct: +31205210333
Picopointfax: +31205210320
Amsterdam mobile: +31629582154
the Netherlands   http://www.picopoint.com

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html