Re: FVWM: Can't open new windows?
On Mon, May 24, 2010 at 05:57:38PM -0700, Omar Zakaria wrote: On May 23, 2010, at 11:34 AM, Thomas Adam wrote: On Wed, May 19, 2010 at 10:00:50AM -0700, Omar Zakaria wrote: Thanks again for looking at this. I really appreciate it. Let me know if I can help in any way. Can you please checkout the CVS version of FVWM and apply the patch attached? See if it fixes your problem? Woohoo! Amazing. Looks like it works. So what happens now? I'd like to get this version installed on a few of our machines here, so I'm wondering if you plan on releasing a version of FVWM that includes this patch soon, or if I shouldn't bother waiting and instead just create an RPM with the patch in it myself. Oh, I need to think on this more -- I am not committing that patch as-is, no. If it's working for you and you get no adverse affects from using it, and other XClients other than your SmallTalk ones seem OK about it, then that's good. For now, roll out your own RPMs using that patch, and when I put something in CVS which fixes this properly, I will let you know. -- Thomas Adam
Re: FVWM: Can't open new windows?
On May 23, 2010, at 11:34 AM, Thomas Adam wrote: On Wed, May 19, 2010 at 10:00:50AM -0700, Omar Zakaria wrote: Thanks again for looking at this. I really appreciate it. Let me know if I can help in any way. Can you please checkout the CVS version of FVWM and apply the patch attached? See if it fixes your problem? Woohoo! Amazing. Looks like it works. So what happens now? I'd like to get this version installed on a few of our machines here, so I'm wondering if you plan on releasing a version of FVWM that includes this patch soon, or if I shouldn't bother waiting and instead just create an RPM with the patch in it myself. One way or another, thanks a million! -- Omar Zakaria Agilent Technologies W: 707-577-4214
Re: FVWM: Can't open new windows?
On Wed, May 19, 2010 at 10:00:50AM -0700, Omar Zakaria wrote:
Thanks again for looking at this. I really appreciate it. Let me know if
I can help in any way.
Can you please checkout the CVS version of FVWM and apply the patch
attached? See if it fixes your problem?
-- Thomas Adam
--
It was the cruelest game I've ever played and it's played inside my head.
-- Hush The Warmth, Gorky's Zygotic Mynci.
Index: fvwm/add_window.c
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/add_window.c,v
retrieving revision 1.401
diff -u -p -r1.401 add_window.c
--- fvwm/add_window.c 2 Aug 2009 15:04:08 - 1.401
+++ fvwm/add_window.c 23 May 2010 18:33:50 -
@@ -2378,10 +2378,14 @@ FvwmWindow *AddWindow(
}
else
{
- attributes.event_mask = XEVMASK_CLIENTW;
+ /* TA: Temporarily assign Substructure masks here, and
+ * consider adding them to XEVMASK_CLIENTW if proven to work.
+ */
+ attributes.event_mask = XEVMASK_CLIENTW | \
+ SubstructureRedirectMask | SubstructureNotifyMask;
}
attributes.do_not_propagate_mask = ButtonPressMask | ButtonReleaseMask;
- XChangeWindowAttributes(dpy, FW_W(fw), valuemask, attributes);
+ XChangeWindowAttributes(dpy, FW_W_PARENT(fw), valuemask, attributes);
/** make sure the window is not destroyed when fvwm dies **/
if (!IS_TEAR_OFF_MENU(fw))
{
Re: FVWM: Can't open new windows?
On May 15, 2010, at 2:41 PM, Thomas Adam wrote: [Cc'ing fvwm-workers@ so I don't lose track of this] Sorry it's taken me a few days to get back to you. On Wed, May 12, 2010 at 02:05:33PM -0700, Omar Zakaria wrote: Well, good news, then. I've finished the app. What's a good way to get it to you? I am still unable to run this application via VisualWorks, but it doesn't matter, as just trying to launch VisualWorks itself (which maps windows) seems to exhibit the same problem. Heh. I hope you don't misunderstand me when I say I'm glad to hear it. Tricky little devil of a bug. But beyond that, I can't see why this thing is failing in the way it is. I've done some pretty in-depth analysis of the event-handling code in FVWM -- the events it receives are all handled properly. Out of interest, does the following (albeit drastic -- it's only for testing) help with your problem? Style * Unmanaged Yes, surprisingly, that seems to work. I'm not entirely certain what that means, though. I'm still learning about FVWM. With that line set, we don't see any problems at all launching the VisualWorks app and all windows draw themselves correctly the first time through. I am really hoping it will -- because then FVWM bails even bother trying to reparent the window into its frame. I am going to look into this some more. It's really interesting. Thanks again for looking at this. I really appreciate it. Let me know if I can help in any way. -- Omar Zakaria Agilent Technologies W: 707-577-4214
Re: FVWM: Can't open new windows?
[Cc'ing fvwm-workers@ so I don't lose track of this] On Wed, May 12, 2010 at 02:05:33PM -0700, Omar Zakaria wrote: Well, good news, then. I've finished the app. What's a good way to get it to you? I am still unable to run this application via VisualWorks, but it doesn't matter, as just trying to launch VisualWorks itself (which maps windows) seems to exhibit the same problem. I've spent a little over eight hours straight on this, so am rather tired. It seems through my analysis that the bloody windows this thing maps sends excessive ReparentNotify events -- depsite the fact that there is only ever one such event acted on by FVWM. I've told FVWM to discard_events() for ReparentNotify which didn't help -- it seems this thing *hates* its windows being reparented. But beyond that, I can't see why this thing is failing in the way it is. I've done some pretty in-depth analysis of the event-handling code in FVWM -- the events it receives are all handled properly. Out of interest, does the following (albeit drastic -- it's only for testing) help with your problem? Style * Unmanaged I am really hoping it will -- because then FVWM bails even bother trying to reparent the window into its frame. I am going to look into this some more. It's really interesting. -- Thomas Adam -- It was the cruelest game I've ever played and it's played inside my head. -- Hush The Warmth, Gorky's Zygotic Mynci.
