Re: CVS renato: * Created function module_add_to_fdsets from events.c and module_interface.c
In the tests I'm calling the function GetFdWidth() twice for every
module, which may incur in a bit overhead..
There's a global var called fd_width. I don't know if I should use the
it instead, but supose it should be removed.. I've also considered the
use of a static global var to improve performance.
On the other hand, in this case we don't care for the number of
maximum opened fds - if the number is too big then the open pipe call
will fail. What we want is the max fdset size, so maybe we can just
use FD_SETSIZE.
That's what GetFdWidth() does, but the fd_width variable is there
for exactly this reason. I see the code is a mess now.
Suggestion:
** Remove fd_width in fvwm.c and GetFdWidth() in libs/System.c.
** Add a global variable and a function to fvwmlib.h:
extern const fd_set_size_t fvwmlib_max_fd;
void fvwmlib_init_max_fd(void);
** Define both in libs/System.c:
const fd_set_size_t fvwmlib_max_fd = (fd_set_size_t)-999;
void fvwmlib_init_max_fd(void)
{
/* init fvwmlib_max_fd with code from old
* GetFdWidth() function. */
}
** replace fd_width = GetFdWidth(); in fvwm.c with
fvwmlib_init_mx_fd();.
** Use fvwmlib_max_fd everywhere.
** If you are bored, do the same in all the modules :-P
So what's the best solution?
About the fd_width global, it is used for the select calls. I don't
know if it's better performance-wise to ask for the whole range of
possible pipes (like now) or keep the record of the bigger pipe fd..
Of course it would be faster during the select() calls, but input
is relatively rare. I don't think keeping a sorted list of open
module fds woulb be justified. After all, the fdset is just a
relatively small bit field, not megabytes of memory.
Ciao
Dominik ^_^ ^_^
--
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
CVS renato: Removed the unused test for plain imlib.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/09/04 15:39:35 Modified files: . : ChangeLog acinclude.m4 Log message: Removed the unused test for plain imlib. The test for gdk-imlib is left as-was.
CVS renato: removed the Imlib.h header from gdk_imlib test programs
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/09/04 15:47:31 Modified files: . : ChangeLog acinclude.m4 Log message: removed the Imlib.h header from gdk_imlib test programs
CVS renato: applied Serge's FvwmIconMan cleanup/document patch
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/08/08 13:43:09 Modified files: modules: ChangeLog modules/FvwmIconMan: FvwmIconMan.1.in FvwmIconMan.c FvwmIconMan.h debug.c debug.h debuglevels.h functions.c globals.c readconfig.c winlist.c xmanager.c Log message: applied Serge's FvwmIconMan cleanup/document patch
CVS renato: Added the notice that the ! is prefered in the MenuStyle command.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/25 05:36:23 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: Added the notice that the ! is prefered in the MenuStyle command. Created a centralized list of deprecated negative commands.
CVS renato: Updated the menu styles AnimationOff and ActiveForeOff to the ! negation method
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/25 07:55:49 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: Updated the menu styles AnimationOff and ActiveForeOff to the ! negation method
CVS renato: Created a ! flag explanation in Style similar to the one in MenuStyle
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/25 09:24:00 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: Created a ! flag explanation in Style similar to the one in MenuStyle Moved the deprecated reference of some styles to a centralized place (NoTitle, StippledTitleOff, NoHandles,NoButton, NoIconTitle) Removed the ActiveBack relics from the man page
Re: CVS renato: Created a ! flag explanation in Style similar to the one in MenuStyle
On 7/25/06, FVWM CVS fvwm-workers@fvwm.org wrote: CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/25 09:24:00 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: Created a ! flag explanation in Style similar to the one in MenuStyle Moved the deprecated reference of some styles to a centralized place (NoTitle, StippledTitleOff, NoHandles,NoButton, NoIconTitle) Oops.. Looks like I did a mess with these changes above. I'll revert them for now, and review them as soon as I can. Cheers renato Removed the ActiveBack relics from the man page
CVS renato: Reverted some messed up changes in the man page.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/25 09:57:38 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: Reverted some messed up changes in the man page.
CVS renato: updated the manpage to reflect the prefered !* style negation method.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/17 10:51:34 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: updated the manpage to reflect the prefered !* style negation method. (only Title, StippledTitle and Handles for now).
CVS renato: another update to the man page regarding !* style negation.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/17 13:44:15 Modified files: . : ChangeLog fvwm : fvwm.1.in Log message: another update to the man page regarding !* style negation. (NoButton, NoIconTitle)
CVS renato: Applied Dominik's patch to fix broken KillModule
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/11 04:56:52 Modified files: . : ChangeLog fvwm : module_interface.c Log message: Applied Dominik's patch to fix broken KillModule
CVS renato: Applied Serge's patch correcting --debug-msgs bug.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/11 17:44:05 Modified files: modules: ChangeLog modules/FvwmPager: FvwmPager.c Log message: Applied Serge's patch correcting --debug-msgs bug.
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On Sun, Jul 09, 2006 at 01:00:08AM +0100, seventh guardian wrote: On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. Well, it wasn't even useful to 2.4, and I doubt people would keep configs from pre-2.4.. So I thought it wouldn't matter. My fault. Sometimes it is surprising how long it can take until everybody has switched to a more recent release. Some people stick to 2.2.x for no other reason than that it is smaller. How can I reverse the change? With a bit of CVS magic. First, find out the revision numbers of the changed files before and after the change. For example, for fvwm.c do $ cvs log -N fvwm.c ... revision 1.375 date: 2006/07/07 23:34:31; author: renato; state: Exp; lines: +0 -8 Removed the warning about the obsolete option -blackout. Removed its reference from the manual. revision 1.374 ... (The relevant numbers are 1.374 and 1.375 here). Next, generate a patch for that change: $ cvs diff -u -r 1.374 -r 1.375 fvwm.c blackout.patch (Double check that the patch contains only the changes you want to reverse; edit the patch file if necessary). Finally reverse-apply the patch: $ patch -p0 -R blackout.patch Repeat this for all affected files. Well, although I've now done the change myself locally, I leave it to you as it is a good practive for using cvs :-) -- While you're at it you can change the warning (and todo-3.0 file) to inform the user that -blackout *will* be removed in 3.0. I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) ... Sorry, you're right.. Won't happen again :) There's really no reason to feel disheartened. I appreciate your work very much and other surely do too. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
CVS renato: Reversed the changes regarding -blackout.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/09 07:34:16 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Reversed the changes regarding -blackout. Added some info about its future removal.
CVS renato: Added to the todo-3.0 list:
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/09 07:41:56 Modified files: docs : todo-3.0 Log message: Added to the todo-3.0 list: 43) Remove the -blackout option.
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Sun, Jul 09, 2006 at 01:00:08AM +0100, seventh guardian wrote: On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. Well, it wasn't even useful to 2.4, and I doubt people would keep configs from pre-2.4.. So I thought it wouldn't matter. My fault. Sometimes it is surprising how long it can take until everybody has switched to a more recent release. Some people stick to 2.2.x for no other reason than that it is smaller. How can I reverse the change? With a bit of CVS magic. First, find out the revision numbers of the changed files before and after the change. For example, for fvwm.c do $ cvs log -N fvwm.c ... revision 1.375 date: 2006/07/07 23:34:31; author: renato; state: Exp; lines: +0 -8 Removed the warning about the obsolete option -blackout. Removed its reference from the manual. revision 1.374 ... (The relevant numbers are 1.374 and 1.375 here). Next, generate a patch for that change: $ cvs diff -u -r 1.374 -r 1.375 fvwm.c blackout.patch (Double check that the patch contains only the changes you want to reverse; edit the patch file if necessary). Finally reverse-apply the patch: $ patch -p0 -R blackout.patch Repeat this for all affected files. Well, although I've now done the change myself locally, I leave it to you as it is a good practive for using cvs :-) Ok, done. Thanks for the tip :) -- While you're at it you can change the warning (and todo-3.0 file) to inform the user that -blackout *will* be removed in 3.0. Done. I've also added the the info about its future removal to the manual (hope it's ok). Cheers, Renato I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) ... Sorry, you're right.. Won't happen again :) There's really no reason to feel disheartened. I appreciate your work very much and other surely do too. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEsMFJmeSprTOr4tgRAjAsAKCNDMZXYYvLWDBa5bv0Dd/Cacbx1QCghVlJ MYfu0Uj0Wl3JmlIiK+4Cgik= =NOZ/ -END PGP SIGNATURE-
CVS renato: Removed old debug code from alloca.c
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/08 06:48:09 Modified files: . : ChangeLog fvwm : fvwm.c libs : alloca.c Log message: Removed old debug code from alloca.c Corrected a minor typo in fvwm.c
CVS renato:
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/08 09:57:42 fvwm/compat Update of /home/cvs/fvwm/fvwm/compat In directory util9.math.uh.edu:/tmp/cvs-serv3957/compat Log Message: Directory /home/cvs/fvwm/fvwm/compat added to the repository
Re: CVS renato:
On 7/8/06, FVWM CVS fvwm-workers@fvwm.org wrote: CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/08 09:57:42 fvwm/compat Update of /home/cvs/fvwm/fvwm/compat In directory util9.math.uh.edu:/tmp/cvs-serv3957/compat Log Message: Directory /home/cvs/fvwm/fvwm/compat added to the repository OOPS sorry.. I should have done that only locally... Will never hapen again :) Renato
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEr5hHmeSprTOr4tgRArLlAKCGMrl4JT7tV0SAvv3hKQqd8Qd0HwCbBu3t 5adq7LfT20dzmR9KI9PxpDI= =od5t -END PGP SIGNATURE-
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) From ChangeLog-pre2.4: 1999-07-08 Dominik Vogt dominik(dot)vogt(at)gmx(dot)de (...) * fvwm/fvwm.h: * fvwm/builtins.c (do_recapture): * fvwm/fvwm.c: removed the 'blackout' code completely (...) Cheers Renato Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEr5hHmeSprTOr4tgRArLlAKCGMrl4JT7tV0SAvv3hKQqd8Qd0HwCbBu3t 5adq7LfT20dzmR9KI9PxpDI= =od5t -END PGP SIGNATURE-
CVS renato: Corrected a mistake in a previous entry of ChangeLog
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/08 17:55:21 Modified files: . : ChangeLog Log message: Corrected a mistake in a previous entry of ChangeLog
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On Sat, Jul 08, 2006 at 11:48:43PM +0100, seventh guardian wrote: On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) Well, I certainly don't want to discourage you from doing usefull work, but please don't become too eager committing potentially harmful changes without discussing them. Compatibility is a sensitive issue, and we have spent lots of time thinking about the right way to go. (The fact that most of us don't have time to write patches nowadays does not mean we don't have the time to argue about patches ;-) ) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Sat, Jul 08, 2006 at 11:48:43PM +0100, seventh guardian wrote: On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. Well, it wasn't even useful to 2.4, and I doubt people would keep configs from pre-2.4.. So I thought it wouldn't matter.. My fault. How can I reverse the change? I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) Well, I certainly don't want to discourage you from doing usefull work, but please don't become too eager committing potentially harmful changes without discussing them. Compatibility is a sensitive issue, and we have spent lots of time thinking about the right way to go. (The fact that most of us don't have time to write patches nowadays does not mean we don't have the time to argue about patches ;-) ) Sorry, you're right.. Won't happen again :) Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEsEPbmeSprTOr4tgRAvijAKDUpJbB6gS+oF8zoklKwBVhJsH/rACfV5Bv Ab6/ggXU2ocAevGUMFiCoJk= =KPUA -END PGP SIGNATURE-
CVS renato: Removed unused libs/debug.c and did the required clean up.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/07 13:57:16 Modified files: . : ChangeLog fvwm : focus.h module_interface.c libs : Makefile.am fvwmlib.h Removed files: libs : debug.c Log message: Removed unused libs/debug.c and did the required clean up.
CVS renato: Removed the warning about the obsolete option -blackout.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual.
