Re: Title font color broken
On Tue, Jun 06, 2006 at 03:29:39PM -0400, Dan Espen wrote: Serge (gentoosiast) Koksharov [EMAIL PROTECTED] writes: On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem was that in some cases the GC used to draw the title was not set before drawing, but it seems the old code relied on this not being done. I'd be grateful if someone could look into this problem or at least give me a minimal config to reproduce it. I can confirm Dan's bugreport. And it easily reproducable with minimal config: I compile FVWM like this: aclocal autoheader automake --add-missing autoreconf ./configure --prefix=$HOME/usr --oldincludedir=$HOME/usr/include \ --enable-xft --disable-xinerama --enable-iconv --disable-bidi \ --enable-perllib --enable-nls --enable-gtk --with-x --without-rplay-library \ --without-gnome make make install Then I move entire ~/.fvwm directory somewhere: $ mv ~/.fvwm ~/usr/src Create new empty directory: mkdir ~/.fvwm Create '~/.fvwm/config' file consisting of two lines: Style * ForeColor red Style * HilightFore red Launch FVWM and see that titles of both active and inactive windows are black, but not red. I hope you can reproduce it as well and fix this bug. If not, you can provide me with instructions what to do next and I'll be more than glad to help. Dominik posted a patch containing the commit that caused the problem. He asked for help trying to recreate the original problem he was trying to patch. We could just revert his patch, but the original problem would remain unsolved. I haven't had any time to look into this yet. Fixed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: Title font color broken
On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem was that in some cases the GC used to draw the title was not set before drawing, but it seems the old code relied on this not being done. I'd be grateful if someone could look into this problem or at least give me a minimal config to reproduce it. I can confirm Dan's bugreport. And it easily reproducable with minimal config: I compile FVWM like this: aclocal autoheader automake --add-missing autoreconf ./configure --prefix=$HOME/usr --oldincludedir=$HOME/usr/include \ --enable-xft --disable-xinerama --enable-iconv --disable-bidi \ --enable-perllib --enable-nls --enable-gtk --with-x --without-rplay-library \ --without-gnome make make install Then I move entire ~/.fvwm directory somewhere: $ mv ~/.fvwm ~/usr/src Create new empty directory: mkdir ~/.fvwm Create '~/.fvwm/config' file consisting of two lines: Style * ForeColor red Style * HilightFore red Launch FVWM and see that titles of both active and inactive windows are black, but not red. I hope you can reproduce it as well and fix this bug. If not, you can provide me with instructions what to do next and I'll be more than glad to help. Good luck
Re: Title font color broken
Serge (gentoosiast) Koksharov [EMAIL PROTECTED] writes: On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem was that in some cases the GC used to draw the title was not set before drawing, but it seems the old code relied on this not being done. I'd be grateful if someone could look into this problem or at least give me a minimal config to reproduce it. I can confirm Dan's bugreport. And it easily reproducable with minimal config: I compile FVWM like this: aclocal autoheader automake --add-missing autoreconf ./configure --prefix=$HOME/usr --oldincludedir=$HOME/usr/include \ --enable-xft --disable-xinerama --enable-iconv --disable-bidi \ --enable-perllib --enable-nls --enable-gtk --with-x --without-rplay-library \ --without-gnome make make install Then I move entire ~/.fvwm directory somewhere: $ mv ~/.fvwm ~/usr/src Create new empty directory: mkdir ~/.fvwm Create '~/.fvwm/config' file consisting of two lines: Style * ForeColor red Style * HilightFore red Launch FVWM and see that titles of both active and inactive windows are black, but not red. I hope you can reproduce it as well and fix this bug. If not, you can provide me with instructions what to do next and I'll be more than glad to help. Dominik posted a patch containing the commit that caused the problem. He asked for help trying to recreate the original problem he was trying to patch. We could just revert his patch, but the original problem would remain unsolved. I haven't had any time to look into this yet. -- Dan Espen E-mail: [EMAIL PROTECTED]
Re: Title font color broken
On Sat, Jun 03, 2006 at 07:28:11PM +0100, Thomas Adam wrote:
On Sat, Jun 03, 2006 at 11:57:58AM -0400, Dan Espen wrote:
It's been a while since I've updated to CVS Maybe a month or 2 .
After the last update, the text in my window titles is black. These
commands have no effect:
Style * ForeColor HilightFore
Last I heard those commands were being deprecated in favour of using
colorsets.
They are not desprecated at the moment.
I know about this problem and I'm quite sure which particular
commit caused it:
2006-02-09 Dominik Vogt ...
...
* libs/Flocale.c (FlocaleFontStructDrawString):
(FlocaleDrawString):
set the foreground colour before drawing a string
(diff attached).
Unfortunately I never got any feedback on this from the person who
reported it first. The problem was that in some cases the GC used
to draw the title was not set before drawing, but it seems the old
code relied on this not being done.
I'd be grateful if someone could look into this problem or at
least give me a minimal config to reproduce it.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt, [EMAIL PROTECTED]
Index: Flocale.c
===
RCS file: /home/cvs/fvwm/fvwm/libs/Flocale.c,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -B -b -u -r1.75 -r1.76
--- Flocale.c 26 Nov 2005 21:55:12 - 1.75
+++ Flocale.c 9 Feb 2006 11:49:33 - 1.76
@@ -617,6 +617,9 @@
is_string16, dpy, d, gc, xt, yt,
fws-e_str, fws-str2b, len);
}
+ }
+ if (has_fg_pixels)
+ {
XSetForeground(dpy, gc, fg);
}
xt = gstp_args.orig_x;
@@ -909,7 +912,6 @@
dpy, fws-win, my_gc, xpsh, ypsh, rotated_w,
rotated_h);
}
- XSetForeground(dpy, my_gc, fg);
}
xpsh = gstp_args.orig_x;
ypsh = gstp_args.orig_y;
@@ -1932,8 +1935,8 @@
dpy, fws-win, flf-fontset, fws-gc,
xt, yt, fws-e_str, len);
}
- XSetForeground(dpy, fws-gc, fg);
}
+ XSetForeground(dpy, fws-gc, fg);
xt = gstp_args.orig_x;
yt = gstp_args.orig_y;
XmbDrawString(
@@ -2001,8 +2004,8 @@
buf2,
strlen(buf2));
}
- XSetForeground(dpy, fws-gc, fg);
}
+ XSetForeground(dpy, fws-gc, fg);
xt = gstp_args.orig_x;
yt = gstp_args.orig_y;
XmbDrawString(
signature.asc
Description: Digital signature
Re: Title font color broken
On Sat, Jun 03, 2006 at 11:57:58AM -0400, Dan Espen wrote: It's been a while since I've updated to CVS Maybe a month or 2 . After the last update, the text in my window titles is black. These commands have no effect: Style * ForeColor HilightFore Last I heard those commands were being deprecated in favour of using colorsets. -- Thomas Adam -- If I were a witch's hat, sitting on her head like a paraffin stove, I'd fly away and be a bat. -- Incredible String Band.
Re: Title font color broken
Thomas Adam [EMAIL PROTECTED] writes: On Sat, Jun 03, 2006 at 11:57:58AM -0400, Dan Espen wrote: It's been a while since I've updated to CVS Maybe a month or 2 . After the last update, the text in my window titles is black. These commands have no effect: Style * ForeColor HilightFore Last I heard those commands were being deprecated in favour of using colorsets. Good thing someone is still using them so we don't break things that are only deprecated. Actually, I don't see anything in the man page about colorsets being required. -- Dan Espen E-mail: [EMAIL PROTECTED]
