Re: [HarfBuzz] Disable uniscribe backend

2011-08-24 Thread Behdad Esfahbod
On 08/20/11 14:47, Grigori Goronzy wrote:
 Hi,
 
 the Uniscribe backend doesn't work on Windows XP and unnecessarily

Is that because we use the OpenType version of ScriptShape, etc?  In that case
I think I should switch to a GetProcAddress() method which is common practice
on Windows then.


 bloats HarfBuzz on Windows. According to commit logs it only is for
 testing purposes anyway, so can we have an option to disable it at build
 time?

Yes, we will have for everything.  I just haven't got to building the
configure system properly yet...


 Grigori
 
 PS: what happened to the 0.8 release and the promises of API stability?

I've been on vacation last week and this week, but I'm getting some hacking
done.  I'm integrating Graphite today.  It was necessary to integrate at least
a couple other backends to kick the last quirks out of the API.  So that's for
the API stability.  As for the 0.8 release, well, I just have been lazy :).
___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz


Re: [HarfBuzz] Fwd: Where to report a bug with Tamil text rendering in LibreOffice?

2011-08-24 Thread Behdad Esfahbod
On 08/23/11 11:16, Martin Hosken wrote:
 This means that there were 3 clusters in the sequence, which is what you 
 want. So it seems that hbng is doing what you want. Remember, hbng doesn't do 
 anything with cursors, but it does do clustering.

Note that these clusters are not used, or should not be used, for cursor
movement.  Cursor movement should work according to the UAX#29.

behdad
___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz


[HarfBuzz] harfbuzz-ng: Changes to 'graphite2'

2011-08-24 Thread Behdad Esfahbod
New branch 'graphite2' available with the following commits:
commit a3bd8a0e1862212a2d4141b973039bd000a3054f
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 03:22:49 2011 +0200

[graphite] Rewrite properly

commit 5072934c35bddc23d6bcb07a41010da51eb1b090
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 02:24:27 2011 +0200

Minor

commit 46377396accf6b43792ffba553dcd9847608aa86
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 02:12:05 2011 +0200

[configure] Fix graphite bits

commit 71388b3ee71c7d3b79f842db7588bd683691797c
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 02:09:04 2011 +0200

[uniscribe] Minor

commit cd2b901027bd154e31aa509c0cb2d86633e36398
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 01:47:25 2011 +0200

[graphite] Minor

commit 834af3b48a1aca3e53811d1eb4ca09b582b8e598
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 01:45:47 2011 +0200

[graphite] Remove hb_graphite2_feature_check()

I don't see how this function can be useful.

commit 1f49cf32c96cb45a4d8ba2c210aeb7a8076b4762
Author: Behdad Esfahbod beh...@behdad.org
Date:   Wed Aug 24 01:29:25 2011 +0200

Add graphite2 integration from Martin Hosken

To be modified, a lot.

___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz


Re: [HarfBuzz] Fwd: Where to report a bug with Tamil text rendering in LibreOffice?

2011-08-24 Thread Shriramana Sharma
On Wed, Aug 24, 2011 at 4:40 PM, Behdad Esfahbod beh...@behdad.org wrote:
 Note that these clusters are not used, or should not be used, for cursor
 movement.  '

Then what are they used for?

 Cursor movement should work according to the UAX#29.

OK fine, but still the Tamil issue applies, as the above standard reads:

Indic scripts vary considerably in how they handle the rendering of
such aksaras—in some cases stacking them up into combined forms known
as consonant conjuncts, and in other cases stringing them out
horizontally, with visible renditions of the halant on each consonant
in the sequence. There is even greater variability in how the typical
liquid consonants (or medials), ya, ra, la, and wa, are handled for
display in combinations in aksaras. So tailorings for aksaras may need
to be script-, language-, font-, or context-specific to be useful.

stringing out horizontally with visible renditions of the halant on
each consonant in the sequence applies to Tamil. Hence tailoring is
necessary.

-- 
Shriramana Sharma
___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz


[HarfBuzz] hb-ot-hmtx-table.hh is missing from repository

2011-08-24 Thread Khaled Hosny
Build fails because hb-tt-font.cc includes hb-ot-hmtx-table.hh which
does not exist.

Regards,
 Khaled

-- 
 Khaled Hosny
 Egyptian
 Arab
___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz


Re: [HarfBuzz] hb-ot-hmtx-table.hh is missing from repository

2011-08-24 Thread Behdad Esfahbod
All fixed and pushed :).

On 08/24/11 19:35, Khaled Hosny wrote:
 Build fails because hb-tt-font.cc includes hb-ot-hmtx-table.hh which
 does not exist.
 
 Regards,
  Khaled
 
___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz


Re: [HarfBuzz] harfbuzz-ng: Changes to 'graphite2'

2011-08-24 Thread Martin Hosken
Dear Behdad,

You mentioned that you intend to simplify the whole userdata approach for both 
uniscribe and graphite, which is a great idea. One thing that is worth pointing 
out is that graphite is somewhat unique in needing a difference between undef 
(not yet tried to create a gr_face) and NULL (tried and failed). Most fonts are 
not going to have graphite tables so we don't want to keep trying to create a 
gr_face for them. Instead we just want to try once and note that this isn't a 
graphite font. The fail is then quick.

I haven't refactored the hb-graphite2.cc to put that back since you intend to 
refactor that area anyway. I would suggest the following patch though:

diff --git a/src/hb-graphite2.cc b/src/hb-graphite2.cc
index df97175..dfeab9f 100644
--- a/src/hb-graphite2.cc
+++ b/src/hb-graphite2.cc
@@ -227,6 +227,7 @@ hb_graphite_shape (hb_font_t  *font,
   buffer-guess_properties ();
 
   hb_gr_font_data_t *data = _hb_gr_font_get_data (font);
+  if (!data-grface) return FALSE;
 
   unsigned int charlen;
   hb_glyph_info_t *bufferi = hb_buffer_get_glyph_infos (buffer, charlen);

otherwise you try to do feature stuff on a null font, and so on.

Yours,
Martin
___
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/harfbuzz