[jira] [Commented] (CONFIGURATION-470) Extract classes generated by JavaCC
[ https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148475#comment-13148475 ] Emmanuel Bourg commented on CONFIGURATION-470: -- I adapted my environment to this setup. I'll live with it, sorry for the rant. Extract classes generated by JavaCC --- Key: CONFIGURATION-470 URL: https://issues.apache.org/jira/browse/CONFIGURATION-470 Project: Commons Configuration Issue Type: Improvement Components: Build Affects Versions: 1.7 Reporter: Oliver Heger Assignee: Oliver Heger Priority: Minor Fix For: 1.8 In the plist package classes generated by JavaCC are used to parse specific configuration files. Currently these files are stored in SVN like regular source files. This does not conform to best practices, is confusing, and requires a special treatment in the configuration of tools like checkstyle or findbugs. It would be better to let these files be generated during the build process by the maven JavaCC plug-in. A working configuration can kindly be borrowed from the OGNL component. The additional generation step should not slow down the build significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONFIGURATION-470) Extract classes generated by JavaCC
[ https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146537#comment-13146537 ] Oliver Heger commented on CONFIGURATION-470: I am sorry, but is this really a problem? On my machine (an almost 4 years old laptop) the additional JavaCC step takes about a second; this hardly counts compared to some of the tests which take much longer. Eclipse does not have any problems with finding the generated sources. Benefits are that redundant code has been removed and the danger of editing generated classes has been minimized. Extract classes generated by JavaCC --- Key: CONFIGURATION-470 URL: https://issues.apache.org/jira/browse/CONFIGURATION-470 Project: Commons Configuration Issue Type: Improvement Components: Build Affects Versions: 1.7 Reporter: Oliver Heger Assignee: Oliver Heger Priority: Minor Fix For: 1.8 In the plist package classes generated by JavaCC are used to parse specific configuration files. Currently these files are stored in SVN like regular source files. This does not conform to best practices, is confusing, and requires a special treatment in the configuration of tools like checkstyle or findbugs. It would be better to let these files be generated during the build process by the maven JavaCC plug-in. A working configuration can kindly be borrowed from the OGNL component. The additional generation step should not slow down the build significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONFIGURATION-470) Extract classes generated by JavaCC
[ https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145928#comment-13145928 ] Emmanuel Bourg commented on CONFIGURATION-470: -- I preferred keeping the generated files, they could have been excluded from checkstyle and findbugs if that was an issue. Now the build is slower and my IDE complains about missing classes :( Extract classes generated by JavaCC --- Key: CONFIGURATION-470 URL: https://issues.apache.org/jira/browse/CONFIGURATION-470 Project: Commons Configuration Issue Type: Improvement Components: Build Affects Versions: 1.7 Reporter: Oliver Heger Assignee: Oliver Heger Priority: Minor Fix For: 1.8 In the plist package classes generated by JavaCC are used to parse specific configuration files. Currently these files are stored in SVN like regular source files. This does not conform to best practices, is confusing, and requires a special treatment in the configuration of tools like checkstyle or findbugs. It would be better to let these files be generated during the build process by the maven JavaCC plug-in. A working configuration can kindly be borrowed from the OGNL component. The additional generation step should not slow down the build significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONFIGURATION-470) Extract classes generated by JavaCC
[ https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144333#comment-13144333 ] Oliver Heger commented on CONFIGURATION-470: Updating the Maven build is not an issue, but the Ant build is problematic. There is a task for invoking JavaCC; however, this task requires a pre-existing installation of JavaCC. I have no idea whether there is a way to download JavaCC dynamically. I guess, I will start with documenting this limitation. Extract classes generated by JavaCC --- Key: CONFIGURATION-470 URL: https://issues.apache.org/jira/browse/CONFIGURATION-470 Project: Commons Configuration Issue Type: Improvement Components: Build Affects Versions: 1.7 Reporter: Oliver Heger Assignee: Oliver Heger Priority: Minor In the plist package classes generated by JavaCC are used to parse specific configuration files. Currently these files are stored in SVN like regular source files. This does not conform to best practices, is confusing, and requires a special treatment in the configuration of tools like checkstyle or findbugs. It would be better to let these files be generated during the build process by the maven JavaCC plug-in. A working configuration can kindly be borrowed from the OGNL component. The additional generation step should not slow down the build significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
