Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
ikaronen-relex commented on PR #494: URL: https://github.com/apache/commons-text/pull/494#issuecomment-1973297487 @garydgregory Sorry, I have not had time to follow up on this, nor am I likely to have much spare time to spend on this in the future. We do not actually use this method, so I can't justify spending work time on this. If anyone else wants to take over this PR, feel free to do so and reopen. Otherwise it can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
ikaronen-relex closed pull request #494: Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase URL: https://github.com/apache/commons-text/pull/494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
garydgregory commented on PR #494: URL: https://github.com/apache/commons-text/pull/494#issuecomment-1962085158 @ikaronen-relex ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
garydgregory commented on code in PR #494:
URL: https://github.com/apache/commons-text/pull/494#discussion_r1468914342
##
src/main/java/org/apache/commons/text/CaseUtils.java:
##
@@ -32,6 +32,8 @@
* @since 1.2
*/
public class CaseUtils {
+public static final int SPACE_CODEPOINT = 32;
Review Comment:
Hello @ikaronen-relex and thank you for your reply.
OK, that makes sense, now all you have to do is make sure it compiles Note
that the project requirement in `pom.xml` is Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
garydgregory commented on code in PR #494:
URL: https://github.com/apache/commons-text/pull/494#discussion_r1468914342
##
src/main/java/org/apache/commons/text/CaseUtils.java:
##
@@ -32,6 +32,8 @@
* @since 1.2
*/
public class CaseUtils {
+public static final int SPACE_CODEPOINT = 32;
Review Comment:
Hello @ikaronen-relex and thank you for your reply.
OK, that makes sense, now all you have to do is make sure it compiles ;-)
Note that the project requirement in pom.xml is Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
ikaronen-relex commented on code in PR #494:
URL: https://github.com/apache/commons-text/pull/494#discussion_r1468074534
##
src/main/java/org/apache/commons/text/CaseUtils.java:
##
@@ -32,6 +32,8 @@
* @since 1.2
*/
public class CaseUtils {
+public static final int SPACE_CODEPOINT = 32;
Review Comment:
Thanks! I fixed the visibility.
It might indeed make sense for other whitespace characters to be part of the
default delimiter set, but not knowing how this class may be used, I feel a bit
hesitant changing its behavior so much.
(If I did decide to change it that much, I'd also strongly consider adding
some way to remove the default delimiters rather than just adding extra custom
ones. But again, that would be a pretty major change to the API. The changes in
this PR so far are just internal improvements and tweaks to very rare edge
cases.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
ikaronen-relex commented on code in PR #494:
URL: https://github.com/apache/commons-text/pull/494#discussion_r1468074534
##
src/main/java/org/apache/commons/text/CaseUtils.java:
##
@@ -32,6 +32,8 @@
* @since 1.2
*/
public class CaseUtils {
+public static final int SPACE_CODEPOINT = 32;
Review Comment:
Thanks! I fixed the visibility.
It might indeed make sense for other whitespace characters to be part of the
default delimiter set, but not knowing how this class may be used, I feel a bit
hesitant changing its behavior so much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Clean up, optimize and fix minor bugs in CaseUtils.toCamelCase [commons-text]
garydgregory commented on code in PR #494:
URL: https://github.com/apache/commons-text/pull/494#discussion_r1468036811
##
src/main/java/org/apache/commons/text/CaseUtils.java:
##
@@ -32,6 +32,8 @@
* @since 1.2
*/
public class CaseUtils {
+public static final int SPACE_CODEPOINT = 32;
Review Comment:
Hello @ikaronen-relex
Thank you for your PR.
This constant does not need to be part of the public API.
Shouldn't the set contain chars from `Character.isSpaceChar()` and/or
`Charcter.isWhitespace()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
