[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837831#comment-17837831
]
ASF GitHub Bot commented on MWRAPPER-128:
-
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567798406
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
```suggestion
3.6.3
```
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837828#comment-17837828
]
ASF GitHub Bot commented on MWRAPPER-128:
-
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567790469
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
but we should be consequential and put here 3.6.3 as we do in more of
plugins now
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837829#comment-17837829
]
ASF GitHub Bot commented on MWRAPPER-128:
-
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567790763
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Yeah, but _all plugin builds_ use at least two Maven version: 3.9.6 and ...
usually 3.6.3. So what "issue in runtime" you expect? Okay, if test coverage is
poor... but then we fix and improve coverage, and life goes on...
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837827#comment-17837827
]
ASF GitHub Bot commented on MWRAPPER-128:
-
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567788687
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
I'm still not sure about it ... when we depend on newer version we can have
some issues in runtime which is not cover by ITs.
But from other side we have more information about depractions ...
The perfect way will be for me depends on the same version as in in
prerequisites ... but we block using plugin for older Maven
So we need a compromise on it
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837823#comment-17837823
]
ASF GitHub Bot commented on MWRAPPER-128:
-
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567780642
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Yeah, I did not want to change prerequisite, it was more to kill this
antipattern to "compile against eons old" maven that prevents noticing what is
being deprecated lately in APIs and Core... (and replaced eon old aether w/
maven-resolver)
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837822#comment-17837822
]
ASF GitHub Bot commented on MWRAPPER-128:
-
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567780642
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Yeah, I did not want to change prerequisite, it was more to kill this
antipattern to "compile against eons old" that prevents noticing what is being
deprecated lately in APIs and Core... (and replaced eon old aether w/
maven-resolver)
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837812#comment-17837812
]
ASF GitHub Bot commented on MWRAPPER-128:
-
jorsol commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567426951
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Why not 3.6.3? this PR is about dropping legacy stuff ;)
> Remove legacy
> -
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-128) Remove legacy
[ https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837731#comment-17837731 ] ASF GitHub Bot commented on MWRAPPER-128: - cstamas opened a new pull request, #126: URL: https://github.com/apache/maven-wrapper/pull/126 Also refresh and reshuffle to not duplicate dependencies and versions. Tend to use properties for versions where there is 2+ of them, otherwise is just fluff. --- https://issues.apache.org/jira/browse/MWRAPPER-128 > Remove legacy > - > > Key: MWRAPPER-128 > URL: https://issues.apache.org/jira/browse/MWRAPPER-128 > Project: Maven Wrapper > Issue Type: Task > Components: Maven Wrapper Plugin >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.3.0 > > > This plugin still uses legacy stuff: zap it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
