Re: [kbuild-devel] Another version of cleanfile/cleanpatch
On Thu, Jun 07, 2007 at 04:19:56PM -0700, H. Peter Anvin wrote: Oleg Verych wrote: Because of that, i think, following is redundant: - to check for binary files find . -type f | xargs cleanfile What about patches? Anyway, by agreement (with myself), i've stopped on having per-file-name division (prev. message first patch, and that was last design remaining from cleanfile/cleanpatch). So: for f in $* do clean-whitespace $f 21 /dev/null done But this doesn't look like interactive usage, which i've concluded. Plus copy is saved in $f.clean file, so user can `diff -u` to see any destruction and possibly report a bug. [] - scan whole file for long lines, with useless bunch of messages about ones. Useless, because script doesn't fix that, it can't do that! Still useful to let the human know what is going on, and why. What i've done was `cleanpatch patch-2.6.21-rc4-rc5` That's where usefulness comes from ;) -hpa - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel
[kbuild-devel] Another version of cleanfile/cleanpatch (Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines)
While i'm against whitespace damaged files or patches since my very first patch, and don't like brain damaged programmer's tools called text editors, i also want to encourage UNIX-way of using userspace. Of course, i might be wrong and foolish. Anyway, what i'm trying to do is not to become new generation of Visual Perl#(R) implemented in Java(R) using XML with userspace, that suck. Many things in XXI century still can be done by tools founded 20-30 years ago. Why not try to? Here is script proposal and test case, just for interested parties. -- -o--=O`C info emacs : faq #oo'L O info make : not found ___=E M man gcc: not found clean-whitespace.sh Description: Bourne shell script # last spaces must NOT be striped to two tabs tabspacespaces tab spaces tab # trailing tabs mixed with spaces 2x8 spaces, must be 2xtabs tab spaces tab, bust be 2 tabs # more trailing whitespace bar ## Automatically generated incremental diff ## From: linux-2.6.21-rc4 ## To: linux-2.6.21-rc5 ## Robot: $Id: make-incremental-diff,v 1.12 2004/01/06 07:19:36 hpa Exp $ --- linux-2.6.21-rc4/Documentation/kernel-parameters.txt2007-03-25 23:12:16.654792317 + # dont strip trailing whitespace +++ linux-2.6.21-rc5/Documentation/kernel-parameters.txt2007-03-25 23:12:21.243287617 + @@ -138,6 +138,12 @@ - int gpio_direction_output(unsigned gpio); # tab space tab - tab tab, strip trailing whitespace + int gpio_direction_output(unsigned gpio, int value); The return value is zero for success, else a negative errno. It should be checked, since the get/set calls don't have error returns and since misconfiguration is possible. (These calls could sleep.) # dont touch space + tester, add space for wide line ... vided becomes the initial output value. # end of file, must be one new line efwef - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/___ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] Another version of cleanfile/cleanpatch (Re: [PATCH 08/19] scripts: Make cleanfile/cleanpatch warn about long lines)
On Wed, Jun 06, 2007 at 07:45:56PM +0200, Oleg Verych wrote: While i'm against whitespace damaged files or patches since my very first patch, and don't like brain damaged programmer's tools called text editors, i also want to encourage UNIX-way of using userspace. Of course, i might be wrong and foolish. Anyway, what i'm trying to do is not to become new generation of Visual Perl#(R) implemented in Java(R) using XML with userspace, that suck. Many things in XXI century still can be done by tools founded 20-30 years ago. Why not try to? Because your shell script is unreadable by normal human beings[*] while the perl script for people with a bit of perl fu can read it and fix/modify it. We want tools that can be maintained and enhanced by most people. [*] Normal human beings are people with same level of shell scripting/sed skills that I have just to put that straight. Sam - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] Another version of cleanfile/cleanpatch
On Wed, Jun 06, 2007 at 07:50:26PM +0200, Sam Ravnborg wrote: [] Many things in XXI century still can be done by tools founded 20-30 years ago. Why not try to? Because your shell script is unreadable by normal human beings[*] while the perl script for people with a bit of perl fu can read it and fix/modify it. We want tools that can be maintained and enhanced by most people. [*] Normal human beings are people with same level of shell scripting/sed skills that I have just to put that straight. In many cases i think, it's limiting one's imagination and expanding laziness[0]. In the school algebra (usually) there are many exercises with plain-useless equations and formulas you must solve or simplify. Guess why? Thus my proposition. ;) --- [0] Now, when most UNIX tools done with good quality (courtesy of the GNU project), it's time not to convert programmer's laziness[1] to ordinary one. Why there's one big and slow Bourne again shell, yet to have fast ([d]ash) and tiny one took more time? As result more efforts to remove bashizms... [1] Ironically connected to Perl chapter of UNIX Power Tools http://unix.org.ua/orelly/unix/upt/ch37_02.htm - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel
