Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-10-19 12:48:58, Detlev Casanova wrote: I don't think that GMail will be upgraded to the Jingle standard soon so, you ship it ! :-) Pali Rohár wrote: For support with gmail plugin I must change some code in google libjignle. Trunk version in http://libjingle.googlecode.com/svn/trunk/ is for old gcc and old libraries. This libjingle code works fine only if I applyed patch from http://code.google.com/p/libjingle/issues/list . So If I can commit this patch for google talk voice support (which use external executables), can I import google libjingle from http://libjingle.googlecode.com/svn/trunk/ rev. 7 to kopete/jabber kde repository with patches? With am2cmake I convert autoconf/automake to cmake and now I can compile libjingle executables with kopete. Pali Rohár wrote: Can I commit this patch now? Rafa? Mi?ecki wrote: Detlev Casanova: you mailed me with link to svn://anonsvn.kde.org/home/kde/branches/work/kopete/new_jingle on kopete-devel. AFAIU this is going to be really used Jingle implementation in Kopete soon. Doesn't that mean duplicated code? I mean potential Kopete's Jingle implementation and what this patch adds. Maybe it would be better to get svn://anonsvn.kde.org/home/kde/branches/work/kopete/new_jingle merged mainline and then hack Kopete's implementation to work with Google's modification of Jingle standard? No, and for 2 reasons : First, new_jingle would need lots of work and is not compliant at all with Google Jingle Secondly, Google will update their service to actual Jingle but it will have to wait a little longer and it won't be available before KDE 4.4 is released (or at least, hard freezed). So for KDE 4.4, let's have a Google Jingle implementation and, maybe, an actual Jingle implementation to be compatible with both implementation and for KDE 4.5, it will be OK to remove libjingle. - Detlev --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review2712 --- On 2009-10-25 13:35:31, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-10-25 13:35:31) Review request for Kopete and Detlev Casanova. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp 1040003 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. I try it with windows gmail voice/video plugin and voice call works fine. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-10-25 13:35:31.799830) Review request for Kopete and Detlev Casanova. Changes --- New patch. Added option to enable/disable Google Talk support. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs (updated) - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabbereditaccountwidget.ui 1040003 /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/jabbereditaccountwidget.cpp 1040003 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. I try it with windows gmail voice/video plugin and voice call works fine. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-10-19 12:48:58, Detlev Casanova wrote: I don't think that GMail will be upgraded to the Jingle standard soon so, you ship it ! :-) For support with gmail plugin I must change some code in google libjignle. Trunk version in http://libjingle.googlecode.com/svn/trunk/ is for old gcc and old libraries. This libjingle code works fine only if I applyed patch from http://code.google.com/p/libjingle/issues/list . So If I can commit this patch for google talk voice support (which use external executables), can I import google libjingle from http://libjingle.googlecode.com/svn/trunk/ rev. 7 to kopete/jabber kde repository with patches? With am2cmake I convert autoconf/automake to cmake and now I can compile libjingle executables with kopete. - Pali --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review2712 --- On 2009-10-17 08:39:05, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-10-17 08:39:05) Review request for Kopete and Detlev Casanova. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. I try it with windows gmail voice/video plugin and voice call works fine. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-10-17 02:52:07.243590) Review request for Kopete and Detlev Casanova. Changes --- Detlev, please indicate whether or not this can be committed so it can either go in, or not. Thanks! Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-05-23 04:15:28, Detlev Casanova wrote: It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). Pali Rohár wrote: Will be later libjingle call example application works? Detlev Casanova wrote: Yes, it should, but at that time (I hope before feature freeze for kde 4.4) there will be a compatible implementation in libiris. Currently, the spec changes too often to have an implementation which is compatible for all clients. I don't know if Google folks are going to release a new libjingle version and I don't know if it will be compatible. Can I commit this patch to svn now? Or it is something wrong with this? - Pali --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1182 --- On 2009-07-21 15:08:07, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-07-21 15:08:07) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-05-23 04:15:28, Detlev Casanova wrote: It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). Pali Rohár wrote: Will be later libjingle call example application works? Detlev Casanova wrote: Yes, it should, but at that time (I hope before feature freeze for kde 4.4) there will be a compatible implementation in libiris. Currently, the spec changes too often to have an implementation which is compatible for all clients. I don't know if Google folks are going to release a new libjingle version and I don't know if it will be compatible. Pali Rohár wrote: Can I commit this patch to svn now? Or it is something wrong with this? Support for the new Jingle standard will be ready quite soon. It should be added in Iris around the end of September. Also, Jingle standard is now at draft state. I'll contact Justin Uberti to know if Google will release a new version of libjingle or if it will be a totally different library. In this latter case, it should be best not to commit as it won't be compatible with a lot of other client when KDE 4.4 will be released. - Detlev --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1182 --- On 2009-07-21 15:08:07, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-07-21 15:08:07) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-05-23 04:15:28, Detlev Casanova wrote: It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). Pali Rohár wrote: Will be later libjingle call example application works? Detlev Casanova wrote: Yes, it should, but at that time (I hope before feature freeze for kde 4.4) there will be a compatible implementation in libiris. Currently, the spec changes too often to have an implementation which is compatible for all clients. I don't know if Google folks are going to release a new libjingle version and I don't know if it will be compatible. Pali Rohár wrote: Can I commit this patch to svn now? Or it is something wrong with this? Detlev Casanova wrote: Support for the new Jingle standard will be ready quite soon. It should be added in Iris around the end of September. Also, Jingle standard is now at draft state. I'll contact Justin Uberti to know if Google will release a new version of libjingle or if it will be a totally different library. In this latter case, it should be best not to commit as it won't be compatible with a lot of other client when KDE 4.4 will be released. Ok. - Pali --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1182 --- On 2009-07-21 15:08:07, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-07-21 15:08:07) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-07-21 15:08:07.079168) Review request for Kopete. Changes --- I update patch file. Can I now commit it to svn? Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs (updated) - trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 5/23/09 5:15 AM, Detlev Casanova wrote: It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). Yes, sorry about the delay. At least the XMPP Council will probably advance the specs to Draft next Wednesday -- I have a few more small edits to complete. Peter - -- Peter Saint-Andre https://stpeter.im/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.8 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkodzAgACgkQNL8k5A2w/vxhvQCghngRNHIbJ9LfJj+RdkarHt9T F04AoIKQMklgR1xDssYXL4bNRxkNEqm7 =UrML -END PGP SIGNATURE- ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-05-24 02:13:45.299279) Review request for Kopete. Changes --- I add new patch Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs (updated) - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1182 --- It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). - Detlev On 2009-05-23 02:33:43, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-05-23 02:33:43) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-05-23 04:15:28, Detlev Casanova wrote: It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). Will be later libjingle call example application works? - Pali --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1182 --- On 2009-05-23 02:33:43, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-05-23 02:33:43) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
On 2009-05-23 04:15:28, Detlev Casanova wrote: It's a good idea but will only be temporary. Google plans on updating their implementation as soon as the XFS jingle specifications are accepted by the XMPP council (should be any time soon, since a long time though). Pali Rohár wrote: Will be later libjingle call example application works? Yes, it should, but at that time (I hope before feature freeze for kde 4.4) there will be a compatible implementation in libiris. Currently, the spec changes too often to have an implementation which is compatible for all clients. I don't know if Google folks are going to release a new libjingle version and I don't know if it will be compatible. - Detlev --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1182 --- On 2009-05-23 02:33:43, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-05-23 02:33:43) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: [kopete-devel] Review Request: Add support for google libjingle voice call
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/#review1186 --- General note about addition of new strings: currently we are in both feature and string freeze, so you have to ask to the translators mailing list (kde-i18n-...@kde.org) the permission for adding this new string (that is related to a new feature). /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt http://reviewboard.kde.org/r/753/#comment744 Add a TODO about adding a cmake check (in the perspective of getting rid of the imported code). /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h http://reviewboard.kde.org/r/753/#comment751 Usual const QString needed (like in the whole file). /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h http://reviewboard.kde.org/r/753/#comment752 Like above: usually class members are named like m_foo, foo_ or _foo. Also, some slightly more meaningful name would be nice. /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h http://reviewboard.kde.org/r/753/#comment753 No need for QString in signals, just use const QString /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp http://reviewboard.kde.org/r/753/#comment754 qDebug() is debug output which cannot be disabled from KDE configuration. Either use kDebug() with some kopete/jabber debug area, or #ifdef GOOGLETALK_DEBUG all of them. /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp http://reviewboard.kde.org/r/753/#comment755 Looks like a i18n() string is missing? /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp http://reviewboard.kde.org/r/753/#comment756 Another missing i18n()? /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h http://reviewboard.kde.org/r/753/#comment745 No need to #ifdef a class forward declaration, it can stay even w/o GOOGLETALK_SUPPORT. /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h http://reviewboard.kde.org/r/753/#comment746 Here (and in many other places) there are whitespace-only changes. Could you avoid them, please? /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h http://reviewboard.kde.org/r/753/#comment747 Should take a const QString, and be a const function. /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h http://reviewboard.kde.org/r/753/#comment748 Should take a const QString /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h http://reviewboard.kde.org/r/753/#comment749 'g' is not that meaningful, especially as it is a class member. What about calling it 'm_googleTalk'? /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp http://reviewboard.kde.org/r/753/#comment750 This adds a new i18n string. - Pino On 2009-05-23 02:33:43, Pali Rohár wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/753/ --- (Updated 2009-05-23 02:33:43) Review request for Kopete. Summary --- This patch add support (for jabber protocol) Google Talk libjingle voice call. It use external libjingle call applicaion and stun server from http://code.google.com/p/libjingle/ Diffs - /trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui PRE-CREATION /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 971715 /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 971715 Diff: http://reviewboard.kde.org/r/753/diff Testing --- It works fine with call application from http://code.google.com/p/libjingle/ with patches from http://code.google.com/p/libjingle/issues/list installed in PATH I try it with windows version of Google Talk (on windows) and voice call works. I can make call, accept/reject incoming call, hang up call. Thanks, Pali ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
