Re: [Libreoffice] cppcheck Found duplicate branches for if and else in libs-core
On Fri, Apr 22, 2011 at 02:06:54PM +0200, Julien Nabet wrote: Hello, Hi, many thanks for your hard work! I've runned a cppcheck last git version on libs-core (master branch updated today) and found this oddity : [basic/source/app/mybasic.cxx:265] - [basic/source/app/mybasic.cxx:260]: (style) Found duplicate branches for if and else. It seems it has been like this since forever :) There were two other, commented out, lines in the if branch originally; I suppose they were removed as part of our cleaning up easy hacks. I just moved the return up and removed the--now useless--if statement. [embeddedobj/source/msole/olepersist.cxx:1835] - [embeddedobj/source/msole/olepersist.cxx:1823]: (style) Found This is the same case as above, except that there is a comment suggesting that the m_bIsLink case might need special treatment. I simplified it nevertheless and added a comment to that effect. duplicate branches for if and else. [svx/source/gallery2/galctrl.cxx:701] - [svx/source/gallery2/galctrl.cxx:699]: (style) Found duplicate branches for if and else. Still the same story... The else branch was changed 10 (!) years ago to assign the same value as the if branch... [svx/source/svdraw/svdpagv.cxx:890] - [svx/source/svdraw/svdpagv.cxx:887]: (style) Found duplicate branches for if and else. Should I repeat myself? :) There is a comment saying Hier optimieren ... in the if branch originating in 2000, but the code has not been touched since... [svx/source/unodraw/unoshape.cxx:3091] - [svx/source/unodraw/unoshape.cxx:3084]: (style) Found duplicate branches for if and else. I thought this is a bug at first, but getPropertyState already does the right thing :) Anyway, since this if (mpImpl-mpMaster) ... else ... is pattern the other functions follow, I just changed the impl. so the microoptimization actually might have some effect. Is it a kind of side effect of a merge ? It is not, as you can see from above comments. Every one of these annoyances has been with us for a looong time :) Then I don't know if the if/else must be removed or if one of them must be modified ; I let you judge. If useful, I can run cppcheck on the other modules and filter on this style error, just tell me. Well, this really depends on your willingness to do it :) I suppose they are still listed on your cppcheck webpage, so if anyone feels like incinerating a few useless lines of code he can find them there? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [2nd attempt] Cleaning sal/inc/osl/file.hxx
Am 26.04.2011 20:34, schrieb Thorsten Behrens: Chr. Rossmanith wrote: Maybe it helps to put the question a second time? Sure, makes a lot of sense to me. Go for it! :) And I'll replace the wrapper functions like getSystemPathFromFileURL with the wrapped functions osl_getSystemPathFromFileURL. Vetos? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
But can you tell me that you *really* aren't aware of the OOo-dev builds build process? You developed on OOo: http://wiki.services.openoffice.org/wiki/DomainDeveloper Sure, I am/was a registered domain developer, but I always worked in the ooo-build a.k.a. go-oo build mechanism. Never the upstream OOo one. And is/was that OOo-dev thing ever used by anyone except Hamburg? and in the release notes for Developer Snapshots has been the following (for quite some time): http://development.openoffice.org/releases/3.4beta.html This snapshot build will install as OOo-Dev I have never installed any (what used to be) upstream OOo developer snapshot.. Trust me, this thread is the first time I hear about OOo-Dev. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting
On Wednesday 27 of April 2011, Christian Dywan wrote: Am 27.04.2011 13:01:36 schrieb Christoph Noack: Just a small question ... do I get it right that the disabled menu items get hidden instead of being grayed out? Real interest: could you please explain what the rationale for the change is? As far as I know, there is currently no platform guideline that requires that (or even allows that) - but I might be wrong. Yes, disabled becomes hidden effectively. That is *current* behaviour on all systems as far as I can tell, so I'm not introducing anything new, to make that clear. I explicitly want to change this for GTK+ because it is wrong behaviour. As far as I know, OS X and KDE are the only platforms doing this (I'll ignore Maemo). I don't know the exact guideline, I didn't find clear documentation about it but for example the web page context menu on OS X does it and editor popups I saw in KDE. That said, Lubos or anyone else, please correct me if my observation is wrong, I'll adapt the patch accordingly. I'm not aware of KDE hidding any disabled menu items anywhere, AFAIK they always get just greyed out. I don't have any access to OS X, so I don't know there, but a google query turned up [*], which also seems to just do that instead of hiding. [*] http://macintopics.com/media/2010/06/context-menu-text-substitutions.jpg -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting
On Wednesday 27 of April 2011, Christian Lohmaier wrote: Hi Christian, *, On Thu, Apr 21, 2011 at 3:44 PM, Christian Dywan christ...@lanedo.com wrote: I'm introducing a setting that decides if disabled menu items should be hidden. Currently the code is broken in the sense that items are hidden if disabled on all platforms and UpdateApplicationSettings which theortically does that is a) counter-intuitive and b) not set by platforms. I'm not sure I understand. I absolutely would hate it when the disabled menu-items were hidden instead of just greyed out. Why would you want to have that dependent on the Desktop-environment? Either the user wants to hide them (but I doubt they really do want that), or the user doesn't want it (like me). So why should LO behave differently on KDE vs Gnome vs Windows in this regard? Because platform integration means LO should act like other native applications of that platform (as much as possible and reasonable). If e.g. KDE popups act in a certain way, then KDE user will certainly prefer if LO popups acted the same way, and if Windows 8 decides that all icons should be pink on green, then probably LO on W8 should paint icons that way too. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Crash log attached....
Hi Peter, On Wed, 2011-04-27 at 19:55 -0400, Peter Teeson wrote: As a retired Mac developer I would like to help track down this reproducible bug. Great stuff :-) nasty that it affects the stable release - it would be great to have you digging into that. Whom should I contact? Do I need to subscribe to the developers list? So - the developers list is not a place for reporting bugs, but getting help in debugging and finding a fix. To do that I suggest: You will first need to get your own build on Mac - this is mostly a matter of compile time - and disk space; I guess you first need to install the dependencies: http://wiki.documentfoundation.org/Development/Install_Mac_OS_10.6.4_Dependencies And then checkout the code: git clone git://anongit.freedesktop.org/libreoffice/bootstrap Ultimately, what we most want - is to get a good gdb trace with debuginfo for the libs-gui module and in particular vcl/ so we can see more of where exactly it is failing for you - I hope a bug specific to some font or configuation issue. Its best to hang out on IRC: #libreoffice-dev on irc.freenode.net to ask questions about how to get the build up running. Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Introduce HideDisabledMenuItems style setting
Hi Christian, On Wed, 2011-04-27 at 11:13 +, Christian Dywan wrote: I updated the patch and attached a second one to get rid of UpdateApplicationSettings which for no good reason tries to flip the same switch in a very misleading way. Thanks for the nice patches, which I just pushed. So sorry it took a week to get this, IMHO helpful and sensible cleanup pushed. Personally, I dislike the Application::SetSettings stuff - it looks like a disaster area to me when it comes to merging user / system etc. settings. I'd love to re-factor re-implement the remaining five uses of that outside of vcl/ - then perhaps we could get rid of all those 'SetDoubleClickTime', 'SetStartDragWidth' etc. methods which surely should be internal impl. details of VCL. Anyhow - thanks again, and looking forward to your next cleanup. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] FW: [PATCH] Introduce HideDisabledMenuItems style setting
Hi Allen, I'm picking on you because you SHOUTED ;-) but there are plenty of other problems in this thread, and my mail is fairly generic. Firstly - progress is not well served by hindering, and slowing down people committing patches - yes, some things may break when things are changed, but then - the fixes should be able to get in quickly too. I was disappointed that the first developer response was not to get on IRC, talk it through, and merge it, as I've now done. It is not the end of the world to have a temporary regression in a tinderbox snapshot - we have ~six months to spot and fix it before many end-users get it. It -is- the end of the world to de-motivate, and loose developers contributing code; we need to presume contributor sanity until proven otherwise, and merge unless we know it is certainly wrong. Otherwise we will never get anywhere IMNSHO etc. Shouting about the potential loss (though in fact it is not lost), of a minor feature, available only to expert users and sysadmins, does not seem proportionate to me. Also, by delaying developers with lots of noise, quite apart from de-motivating them, we waste opportunities for using their time for other improvements to the user interface. So - in summary, there is huge danger of de-motivation, dis-couragement and sterilization of the developer community from applying indiscriminate push-back. -Particularly- if it is inexpert push-back. In this case, it seems the distinction between a -context- menu and the main menu, that is present if you read the patch (though somewhat missing from the original mail, and the naming sadly) is quite important. Ergo - I would love to end this thread for now; if a problem or regression is found in a subsequent snapshot of master (for 3.6) - it would be great to know about it at that stage, and of course testing appreciated here. Since I just pushed the changes, hopefully (all else being equal) we'll have those builds in a day or two. Anyhow - I am sure none of us intend to cause problems, delay improvements, de-motivate developers or end up shouting :-) so - hopefully we can get back to some positive work on the product. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Remove List from ZoomList class
Pushed, thanks B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Remove deprecated List container
They all related to the same files, try to apply them in the same order, thanks All pushed, thanks. Good work, esp. replacing home-grown Dictionary struct with std::map, which is much more appropriate in this case. B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Remove List usage in SdPublishingDlg
... pushed also this one ... Thanks! B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
Hi NoOp, On Tue, 2011-04-26 at 18:43 -0700, NoOp wrote: I'm not a developer, but I consider my self to be an above-average user/tester with exeperience in installing, bug reporting et al on OOo and more recently LO. I can/do install test versions on everything from linux to Win (2K, XP, and Wn7) in both standard native partitions Virtual Machines. I think that Cor Nouows will attest to that. Well - testing is most useful; of course, and we value that. However - I just gave you a lot more information on how to help debug this issue in more detail: and - it seems you bailed out on doing the research, and helping to provide enough information to (easily) fix it. The most basic console output tells you, and other devs, exactly what the issues are. If someone building LO Beta releases can't figure out the issue from there then I'm pretty much at a loss. Sure - it is not a matter of ability, simply one of time. It is also an interesting opportunity for you to contribute something more than a simple bug reports: FWIW, we have no shortage of bug reports :-) It is also a way for us to judge your aptitude, and the effectiveness of your contribution. Going back to the OP and the premise of providing LO Beta/RC as Installing beta versions replacing stable versions packages: you already know the answer to this - it's been done on OOo versions for a very long time. Are you telling the users on this thread that you a uaware of the ooo-dev builds and how they are/were accomplished? Sure - they were for the most part built in a proprietary build environment by a very small number of Hamburg release engineers, AFAIR - though, to be honest I have so little interest in that magic process that I have no idea of the state of it these days :-) It may surprise you to learn that, while I have hacked on -lots- of diverse pieces of LibreOffice (and much else), that I simply cannot remember everything: so I have to research, and re-learn each piece I turn to that needs fixing. This takes time; sometimes lots of time. If it requires going near Windows - it is a nightmare; apparently (from the rest of the thread) this 'oodev' build which is supposedly so easy - simply fails to build, even on more manageable platforms. I snip the more colourfully unpleasant language, and baseless accusations from your mail. It seems amazing to you that I ask you to do some more digging into a bug which you view as incredibly important - in order to help fix it. This is a shame - I spent some time writing notes to you on how to do that. By immoderately criticising the product (which developers identify quite strongly with), you will make the developers very unhappy. As such - they will react really badly; this should not be surprising. Furthermore, to noisily point at bugs which you view as mind-blowingly serious, while not being willing to help out by providing enough information to make fixing them trivial is a curious combination. tml quote Yes, Tor is quite floral in his critique :-) On the other hand, hopefully, by reading, and considering his response, it is easy to see how your E-mails can be interpreted as personal attacks, and adapt your style such that they are not seen that way. Substantially this is a matter of style, not substance. The fact that he shows you how he feels when he receives your mail at least shows that he is still reading it - which IMHO is a good sign given the content :-) So - I'd encourage you to re-consider, and get really stuck into the team working on improving things - I'd also like to encourage you to treat those carrying a lot of the burden doing a lot of the work (like Tor) with unusual respect - it makes them happy again :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installation issue
Dan Hopper wrote: I'm running on an iMac G5 w/intel chip. Hi Dan, then you don't need the command line. Just open the .dmg, and drag the LibreOffice icon to where you want to install it. Cheers, -- Thorsten pgpkh6rzmjqEw.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Remove DECLARE_TABLE( SwRTFCharStyleTbl, SwCharFmt* )
Pushed this + the one from the previous mail (removing similar usage of DECLARE_TABLE from rtf filter). Thanks :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Remove DECLARE_TABLE( SwRTFStyleTbl, SwTxtFmtColl* )
( ... see below ... ) :) -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [2nd attempt] Cleaning sal/inc/osl/file.hxx
Hi there,
On Thu, 2011-04-28 at 09:10 +0200, Chr. Rossmanith wrote:
And I'll replace the wrapper functions like getSystemPathFromFileURL
with the wrapped functions osl_getSystemPathFromFileURL.
Um - I wouldn't do that. Particularly because these hide the impl.
details of the string - which are not that pleasant anyway:
static inline RC getSystemPathFromFileURL( const ::rtl::OUString
ustrFileURL, ::rtl::OUString ustrSystemPath )
{
return (RC) osl_getSystemPathFromFileURL( ustrFileURL.pData,
ustrSystemPath.pData );
}
will end up in-lined anyway; and just maps from the C++ to the C style
API.
No problem / inefficiency there. [ assuming you were proposing removing
them ;-].
HTH,
Michael.
--
michael.me...@novell.com , Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Remove deprecated List container
Pushed. Good catch, thanks B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Introduce HideDisabledMenuItems style setting
On Thursday 28 of April 2011, Michael Meeks wrote: Hi Christian, On Wed, 2011-04-27 at 11:13 +, Christian Dywan wrote: I updated the patch and attached a second one to get rid of UpdateApplicationSettings which for no good reason tries to flip the same switch in a very misleading way. Thanks for the nice patches, which I just pushed. So sorry it took a week to get this, IMHO helpful and sensible cleanup pushed. I've reverted the KDE parts of the patch as they do not match KDE behavior. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Embedding LibreOffice in SWT on Linux
Cedric Bosdonnat wrote: Did you test on several platforms / Window managers? I remember having a grey window with GTK several years ago. Have tested on Fedora and Ubuntu 32 and 64 bit both running Gnome. According to the bug entry on ooo the issue does not occur on KDE - but I haven't verified that. I'll test in KDE and post back here. I had time to test on KDE today and confirmed that the problem seems to be limited to Gnome. I plan to test Gnome 3 shortly to see if it exists there. Regards Vik -- View this message in context: http://nabble.documentfoundation.org/Embedding-LibreOffice-in-SWT-on-Linux-tp2720123p2874233.html Sent from the Dev mailing list archive at Nabble.com.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Next section: Save on great pillz up to 300 per month
The best of the anti-ED meddds are here! http://youraffiliatex.com/c0laqo0n.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installation issue
Thank you for responding. I'm using an iMac (Intel Chip) OSX 10.6.7 Dan Hopper On 4/27/11 5:44 PM, Xuacu [via Document Foundation Mail Archive] wrote: El martes, 26-abril-2011 a les 17:24 -0700, Dan Hopper escribió: I have a problem (inexperience) going to the 'command line' to install Libreoffice. Is there an easier way to complete the installation? Hi, Dan! It's hard for us to guess which kind of instalation are you trying to perform. Windows?, Linux?, from source?... Please, provide more details and you'll have more chances to get help. Best regards, -- Saludinos Xuacu Saturio ___ LibreOffice mailing list [hidden email] /user/SendEmail.jtp?type=nodenode=2872229i=0by-user=t http://lists.freedesktop.org/mailman/listinfo/libreoffice If you reply to this email, your message will be added to the discussion below: http://nabble.documentfoundation.org/Installation-issue-tp2868262p2872229.html To unsubscribe from Installation issue, click here http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=unsubscribe_by_codenode=2868262code=ZGFuQGhvcHBlcm5ldC5vcmd8Mjg2ODI2Mnw1MDAxMDU4MDQ=. -- View this message in context: http://nabble.documentfoundation.org/Installation-issue-tp2868262p2874329.html Sent from the Dev mailing list archive at Nabble.com.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Crash log attached....
Michael Meeks wrote: On Wed, 2011-04-27 at 19:55 -0400, Peter Teeson wrote: As a retired Mac developer I would like to help track down this reproducible bug. Great stuff :-) nasty that it affects the stable release - it would be great to have you digging into that. Hi Peter, besides agreeing on what Michael already said about getting a build - tried your scenario here with 3.3.2 and a fresh 3.4 beta3 build, and don't experience the crash - so your help (with getting a dev build on your box and debugging it) here even more appreciated, since something appears to be special for your setup. Cheers, -- Thorsten pgpCyFxw5rDox.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Fix cppcheck warnings in components (easy hack)
The attached patch fixes lots of cppcheck warnings in the components repository. Thanks! All of those are good points. Just small nitpicking (cui/source/dialogs/thesdlg.cxx) -- I did the following change to your patch: -(aLookUpHistory.empty() == 0 || aLookUpText != aLookUpHistory.top())) + (aLookUpHistory.empty() || aLookUpText != aLookUpHistory.top())) ie. it is OK to use just empty(), as aLookUpHistory is std::stack and this call returns bool. No need to additionally compare it to zero. By the way, did anybody review my latest pyuno patch update? Or am I not patient enough :) Nope, or so it seems. As a person in charge of integrating patches this week, I didn't spot it, because I usually look for [PATCH] keyword in e-mail subject. Sorry about that. Someone speaking Python will have look at it in due course. Keep up good work! :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Bug in main function libs-core/desktop/source/app/app.cxx ?
On Friday 22 of April 2011, Julien Nabet wrote: I think this line nAcquireCount = Application::ReleaseSolarMutex() - 1; should be added before the line 1850 : if ( !bTerminateRequested !rCmdLineArgs.IsInvisible() ) In the code before the wrong commit, the SolarMutex stuff surrounds the Application::PostUserEvent() calls, so I think it belongs before them. Not quite sure if it's really needed, as it apparently has worked this way for some time, but I've commited a change to make it the way it was before the commit, thanks. but 1) Before this line, there was also : ::vos::IMutex rMutex = Application::GetSolarMutex(); if ( rMutex.tryToAcquire() ) I don't know if these are still useful 2) in the function doShutdown, there's only on line 1947 : sal_uLong nAcquireCount = Application::ReleaseSolarMutex(); So i don't know too if -1 is necessary or not The solar mutex is a recursive mutex (can be acquire several times by the same thread), the tryToAcquire() call I'd guess is a test if the current thread has it acquired, but it seems to be pointless, as ReleaseSolarMutex() would just return 0 otherwise. The -1 is to compensate for this one additional acquire. Just confused and pointless, as far as I can say. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Display non printable characters on the end of line
Hi. I have created patch which resolve problem with displaing non printable characters at the end of line: https://bugs.freedesktop.org/attachment.cgi?id=45888 Full bug report: https://bugs.freedesktop.org/show_bug.cgi?id=33167 It works only with left align (the rest aligns was unchanged) One of the most big benefits of blank5.patch, is possible to edit non printable character at the end of line (for example inserting new characters). Here is an screenshot without patch: http://bugzilla-attachments-20878.openoffice.org/bugzilla/attachment.cgi?id=76240 and with patch: http://bugzilla-attachments-20878.openoffice.org/bugzilla/attachment.cgi?id=76239 Could you please take a look at this patch and then push it to LibreOffice? Best Regards Bartosz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Set GTK+ native mouse behaviour settings
This patch adds mouse behaviour settings for GTK+. Tested with for example double click time that renders me unable to double click and works even without a restart. Note that unlike the Windows code, I put the SetMouseSettings directly after the block because I find it non-obvious at the bottom (and it took me a re-compile because I didn't notice the need to do that). ciao, ChristianFrom dca0604c80e6c9f06c878321b8717a3b13a2d74a Mon Sep 17 00:00:00 2001 From: Christian Dywan christ...@lanedo.com Date: Thu, 28 Apr 2011 14:32:16 +0200 Subject: [PATCH] Set GTK+ native mouse behaviour settings --- vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx index 1f82b3a..9a81fd7 100644 --- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx @@ -3495,6 +3495,22 @@ void GtkSalGraphics::updateSettings( AllSettings rSettings ) else aStyleSet.SetCursorBlinkTime( STYLE_CURSOR_NOBLINKTIME ); +MouseSettings aMouseSettings = rSettings.GetMouseSettings(); +int iDoubleClickTime, iDoubleClickDistance, iDragThreshold, iMenuPopupDelay; +g_object_get( pSettings, + gtk-double-click-time, iDoubleClickTime, + gtk-double-click-distance, iDoubleClickDistance, + gtk-dnd-drag-threshold, iDragThreshold, + gtk-menu-popup-delay, iMenuPopupDelay, + (char *)NULL ); +aMouseSettings.SetDoubleClickTime( iDoubleClickTime ); +aMouseSettings.SetDoubleClickWidth( iDoubleClickDistance ); +aMouseSettings.SetDoubleClickHeight( iDoubleClickDistance ); +aMouseSettings.SetStartDragWidth( iDragThreshold ); +aMouseSettings.SetStartDragHeight( iDragThreshold ); +aMouseSettings.SetMenuDelay( iMenuPopupDelay ); +rSettings.SetMouseSettings( aMouseSettings ); + gboolean showmenuicons = true; pSettings = gtk_widget_get_settings( gWidgetData[m_nScreen].gImageMenuItem ); g_object_get( pSettings, gtk-menu-images, showmenuicons, (char *)NULL ); -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
Hi Tor, Tor Lillqvist wrote (28-04-11 10:48) But can you tell me that you *really* aren't aware of the OOo-dev builds build process? You developed on OOo: http://wiki.services.openoffice.org/wiki/DomainDeveloper Sure, I am/was a registered domain developer, but I always worked in the ooo-build a.k.a. go-oo build mechanism. Never the upstream OOo one. And is/was that OOo-dev thing ever used by anyone except Hamburg? Oh yes. It was the primary opportunity for anyone to install snap-shots, dev builds, betas or however they were called, to test, without having trouble in special installing actions and/or loosing stable versions. Many many issues were reported from users/testers working with those. Me (and others) always promoted working with those dev-builds, cause it was an easy way to find bugs relatively early, which eases fixing and helps preventing regressions. I have never installed any (what used to be) upstream OOo developer snapshot.. Trust me, this thread is the first time I hear about OOo-Dev. Apparently, in all our enthusiasm and work, we did not yet tell each other enough about our backgrounds and so more. Regards, Cor -- - http://nl.libreoffice.org - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove tools/list.hxx include
Hi Rafael (all) before I integrate this patch (thanks a lot for the remaining ones, btw), can you please clarify something to me? I understand that you want to remove inclusion of tools/list.hxx file, as LIST_APPEND constant is perhaps a single point of dependency on it in the affected files. LIST_APPEND is just an alias to CONTAINER_APPEND, which is defined as ULONG_MAX (which is a platform dependent constant). Are you sure that using Rsc::File member enum set to 0x is an equivalent solution, and if not, that it at least doesn't break anything ? Because I'm not, but maybe I just lack some information/knowledge/context here ... B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
And is/was that OOo-dev thing ever used by anyone except Hamburg? Oh yes. It was the primary opportunity for anyone to install snap-shots, dev builds, betas or however they were called, I meant, were such builds *produced* by anyone except the Hamburg guys? I do believe they were *used* by lots of people in the Sun/Oracle OOo community. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove DECLARE_LIST(DdeServices, DdeService*) [Windows only]
Hey Rafael, Windows only patch, please compile and check that theres no errors, thanks Didn't you actually forget to attach something? :) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
Tor Lillqvist wrote (28-04-11 14:50) And is/was that OOo-dev thing ever used by anyone except Hamburg? Oh yes. It was the primary opportunity for anyone to install snap-shots, dev builds, betas or however they were called, I meant, were such builds *produced* by anyone except the Hamburg guys? I do believe they were *used* by lots of people in the Sun/Oracle OOo community. Oh, sorry, can't answer that question. -- - http://nl.libreoffice.org - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
On Thu, Apr 28, 2011 at 3:19 PM, Cor Nouws oo...@nouenoff.nl wrote: Tor Lillqvist wrote (28-04-11 14:50) And is/was that OOo-dev thing ever used by anyone except Hamburg? Oh yes. It was the primary opportunity for anyone to install snap-shots, dev builds, betas or however they were called, I meant, were such builds *produced* by anyone except the Hamburg guys? I do believe they were *used* by lots of people in the Sun/Oracle OOo community. Oh, sorry, can't answer that question. Maho did provide the Mac builds as dev variant (rcs of course as regular ones), I myself used it (but I wasn't providing builds regularily, just on specific occasion/request), not sure whether Pavel did also provide dev-variants (never used them and I'm too lazy to search in mail-archives/on ftp-server) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] problem with libereoffice
I apologize for what comes from the English automatic translator, so I hope to be clear nell'eposizione the problem. In LibreOffice calcium is not updated link to external pages when they are moved from their original position, which is the case in OpenOffice. For example, except for two files in c: \ file1.ods file2.ods and where there are links in file1 to file2 cells, if I move these two files in d: \ link is not updated and must be redone. This update feature links to files is very useful for complex spreadsheets with various references, so it would be very useful to eliminate this bug Thank you and good job Yours sincerely Federico Benedetti___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
On Thu, 2011-04-28 at 00:21 +0200, Cor Nouws wrote: Do we already have a simple text on the website/wiki, that explains the use of the developer list, and what expectations are? That might be linked to by devs when needed, thus preventing them to get bored or 'funny' or wasting time on this. It might be linked in the footer of this list? If there isn't any (I can't find it) I'll be glad to write a proposal. I think we should do this. At least, I would like to prevent normal usage issues and bug reports from creeping up on this list. There are clearly better facilities for those things. But we do need to state somewhere in bold and italic that what posts are appropriate and what aren't, for the developer list. Otherwise the number of such posts will only increase. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] problem with libereoffice
Hi Frederico, Studio Tecnico Ing. Federico Benedetti wrote (28-04-11 16:39) I apologize for what comes from the English automatic translator, so I hope to be clear nell'eposizione the problem. Thanks for writing. This list is however for developers working together, not for reporting bugs. In LibreOffice calcium is not updated link to external pages when they are moved from their original position, which is the case in OpenOffice. For example, except for two files in c: \ file1.ods file2.ods and where there are links in file1 to file2 cells, if I move these two files in d: \ link is not updated and must be redone. Apart from that, I can write you that that bug had been reported in our bugtracking system It must be either this one https://bugs.freedesktop.org/show_bug.cgi?id=31741 or this one https://bugs.freedesktop.org/show_bug.cgi?id=34637 If you want to read some more information about reporting, tracing bugs etc. pls go to this page: http://wiki.documentfoundation.org/BugReport Kindest regards, Cor -- - http://nl.libreoffice.org - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
Kohei Yoshida wrote (28-04-11 16:53) On Thu, 2011-04-28 at 00:21 +0200, Cor Nouws wrote: Do we already have a simple text on the website/wiki, that explains the use of the developer list, and what expectations are? That might be linked to by devs when needed, thus preventing them to get bored or 'funny' or wasting time on this. It might be linked in the footer of this list? If there isn't any (I can't find it) I'll be glad to write a proposal. I think we should do this. At least, I would like to prevent normal usage issues and bug reports from creeping up on this list. There are clearly better facilities for those things. But we do need to state somewhere in bold and italic that what posts are appropriate and what aren't, for the developer list. Otherwise the number of such posts will only increase. I placed a first draft here: http://wiki.documentfoundation.org/User:Cornouws Looking forward to comments, ideas, .. Cor -- - http://nl.libreoffice.org - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] minutes of tech steering call ...
I omitted to remind people of this one, so poor attendance; but: Present: Kendy, Andras, Bjoern, Petr, Christian, Koehi * AA completed + discuss Debian adding a second apply file support to apply.pl or using patches/hotfixes/ directory (done) + will do that for 3.4 + rough m106 trial merge into integration/dev300_m106 (done) * AA pending: + encourage QA guys to quietly dig at snapshots (Sophie + Thorsten) + research when gio came into widespread being (Caolan) cf. http://www.gtk.org/download-linux.html + update impress 3.4 feature list (Thorsten) + tweak Easy Hacks wiki pages (Bjoern) + the rdb setup stuff is still too cumbersome (Bjoern) + get SmartArt into master as an experimental feature (Thorsten) + UNO / ABI breaking changes into a set of wiki page for 4.0 (Bjoern + Kohei) + add binfilter removal (Norbert) + write list of things that suck for newcomers with taste (Mitch / Christian) * 3.4 status ... + B2 better + Win32 translations, and crash-on exit fixed for B3 + currently up-loading + good progress with most-annoying bugs, 50% fixed + m106 merge to master, and cherry-pick RC1 or not at all ... * KeyId builds + should be with-lang=keyid - but, on windows; didn't work + looking for missing config. files + instead created a fake translation with key ids as translations + potentially better approach for the future + doesn't require a custom build + should add / enable KeyId language for all non product / tinderbox builds in future + translators are happy * bug 36551 - install 3.3 and 3.4 in parallel + Petr working on it, renaming packages prefix * Bjoern's initial impressions thread / summary + ~killed build repo already + unifying git repos into one underway + others - long term things, when doing API changes + subsumed into the wiki page of future goodness + end-thread this topic. * Ubuntu Natty Narwhale done + including LibreOffice 3.3.2 + soliciting useful tasks * Misc working + Christian + fixing settings issues everywhere, that were exclusively implemented for windows etc. + Kendy - m106 merging -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
Hi Cor, On Thu, 2011-04-28 at 17:05 +0200, Cor Nouws wrote: I placed a first draft here: http://wiki.documentfoundation.org/User:Cornouws Looking forward to comments, ideas, .. Its a great start; can you put it in a public place so it can be jointly edited ? One of my bug-bears is people being lazy and not editing context, and thus forcing people to read endless waffle with '+1' at the end, or a single line of added mail. So I would have as #1 * The people reading this list are exceedingly busy. Posters should be polite, by cutting all un-necessary context from their mails. Replying to a large mail, including the context and adding a '+1', or a short comment is simply rude. Hackers have fast, threaded mail readers - please remove all the context. * Again - every extra word sent to the mailing list reduces the programming team's effectiveness: and costs us all, so choose your words carefully. To help you do that: + re-read your mail before sending it. * the Reporting Bugs link - is good; I would add + This mailing list is -not- a suitable forum for reporting bugs, or feature requests *unless* - you are actively soliciting feedback on how best to fix them *yourself* + It is particularly not a good place to report your views on the general quality, completeness etc. of the software - unless connected with actively working to improve the code. Other than that, looks good - I'd number the points so we can refer to them easily :-) Thanks for getting that done Cor ! ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Installing beta versions replacing stable versions
Reading this again I missed a few obvious pieces: * Listen before speaking + get to know the people you're interacting with on the lists before sending mail + in particular, attempting to explain things to people that are experts already has the potential to make both you look very foolish, and provoke a bad reaction. Check the git logs. * Don't tell people what to do + volunteers often react quite badly to being told what to do; instead of telling others - start doing it yourself and encourage others to join you. I guess, just common-sense for beginners - but no harm in writing it down :-) Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] extensions rant
Hi all Are there any plans of launching a LO extensions site to take over? The openoffice one is more and more often offline... http://extensions.services.openoffice.org/ was down yesterday, and today too. I know of http://libreplanet.org/wiki/Group:OpenOfficeExtensions/List but it's actually linking to the openoffice server. I wouldn't mind if I didn't have my extension sitting there... best Arno signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Clean up GtkSettings use in GTK+ platform module
This patch cleans up the GTK+ module a bit, fixing theming bugs in corner cases
by using ONE way to get screen and settings, the different variants were either
wrong or needlessly confusing.
ciao,
ChristianFrom 56349903b4f4b3350499263cb150346ff407471a Mon Sep 17 00:00:00 2001
From: Christian Dywan christ...@twotoasts.de
Date: Thu, 28 Apr 2011 19:30:22 +0200
Subject: [PATCH] Clean up GtkSettings use in GTK+ platform module
---
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 39 -
1 files changed, 11 insertions(+), 28 deletions(-)
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index 9a81fd7..981d1be 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -3246,6 +3246,12 @@ void printStyleColors( GtkStyle* pStyle )
void GtkSalGraphics::updateSettings( AllSettings rSettings )
{
+GdkScreen* pScreen = gtk_widget_get_screen( m_pWindow );
+gtk_widget_ensure_style( m_pWindow );
+GtkStyle* pStyle = gtk_widget_get_style( m_pWindow );
+GtkSettings* pSettings = gtk_widget_get_settings( m_pWindow );
+StyleSettings aStyleSet = rSettings.GetStyleSettings();
+
// get the widgets in place
NWEnsureGTKMenu( m_nScreen );
NWEnsureGTKMenubar( m_nScreen );
@@ -3253,11 +3259,6 @@ void GtkSalGraphics::updateSettings( AllSettings rSettings )
NWEnsureGTKEditBox( m_nScreen );
NWEnsureGTKTooltip( m_nScreen );
-gtk_widget_ensure_style( m_pWindow );
-GtkStyle* pStyle = gtk_widget_get_style( m_pWindow );
-
-StyleSettings aStyleSet = rSettings.GetStyleSettings();
-
#if OSL_DEBUG_LEVEL 2
printStyleColors( pStyle );
#endif
@@ -3479,7 +3480,6 @@ void GtkSalGraphics::updateSettings( AllSettings rSettings )
aStyleSet.SetFloatTitleFont( aFont );
// get cursor blink time
-GtkSettings *pSettings = gtk_widget_get_settings( gWidgetData[m_nScreen].gEditBoxWidget );
gboolean blink = false;
g_object_get( pSettings, gtk-cursor-blink, blink, (char *)NULL );
@@ -3512,7 +3512,6 @@ void GtkSalGraphics::updateSettings( AllSettings rSettings )
rSettings.SetMouseSettings( aMouseSettings );
gboolean showmenuicons = true;
-pSettings = gtk_widget_get_settings( gWidgetData[m_nScreen].gImageMenuItem );
g_object_get( pSettings, gtk-menu-images, showmenuicons, (char *)NULL );
aStyleSet.SetPreferredUseImagesInMenus( showmenuicons );
@@ -3533,45 +3532,29 @@ void GtkSalGraphics::updateSettings( AllSettings rSettings )
// preferred icon style
gchar* pIconThemeName = NULL;
-g_object_get( gtk_settings_get_default(), gtk-icon-theme-name, pIconThemeName, (char *)NULL );
+g_object_get( pSettings, gtk-icon-theme-name, pIconThemeName, (char *)NULL );
aStyleSet.SetPreferredSymbolsStyleName( OUString::createFromAscii( pIconThemeName ) );
g_free( pIconThemeName );
aStyleSet.SetToolbarIconSize( STYLE_TOOLBAR_ICONSIZE_LARGE );
const cairo_font_options_t* pNewOptions = NULL;
-if( GdkScreen* pScreen = gdk_display_get_screen( gdk_display_get_default(), m_nScreen ) )
-{
#if !GTK_CHECK_VERSION(2,9,0)
static cairo_font_options_t* (*gdk_screen_get_font_options)(GdkScreen*) =
(cairo_font_options_t*(*)(GdkScreen*))osl_getAsciiFunctionSymbol( GetSalData()-m_pPlugin, gdk_screen_get_font_options );
if( gdk_screen_get_font_options != NULL )
#endif
pNewOptions = gdk_screen_get_font_options( pScreen );
-}
aStyleSet.SetCairoFontOptions( pNewOptions );
// finally update the collected settings
rSettings.SetStyleSettings( aStyleSet );
+gchar* pThemeName = NULL;
+g_object_get( pSettings, gtk-theme-name, pThemeName, (char *)NULL );
#if OSL_DEBUG_LEVEL 1
-{
-GtkSettings* pGtkSettings = gtk_settings_get_default();
-GValue aValue;
-memset( aValue, 0, sizeof(GValue) );
-g_value_init( aValue, G_TYPE_STRING );
-g_object_get_property( G_OBJECT(pGtkSettings), gtk-theme-name, aValue );
-const gchar* pThemeName = g_value_get_string( aValue );
-std::fprintf( stderr, Theme name is \%s\\n, pThemeName );
-g_value_unset( aValue );
-}
+std::fprintf( stderr, Theme name is \%s\\n, pThemeName );
#endif
-GtkSettings* pGtkSettings = gtk_settings_get_default();
-GValue aValue;
-memset( aValue, 0, sizeof(GValue) );
-g_value_init( aValue, G_TYPE_STRING );
-g_object_get_property( G_OBJECT(pGtkSettings), gtk-theme-name, aValue );
-const gchar* pThemeName = g_value_get_string( aValue );
// default behaviour
bNeedPixmapPaint = bGlobalNeedPixmapPaint;
@@ -3596,7 +3579,7 @@ void GtkSalGraphics::updateSettings( AllSettings rSettings )
}
}
// clean up
-g_value_unset( aValue );
+g_free (pThemeName);
}
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Re: [Libreoffice] [2nd attempt] Cleaning sal/inc/osl/file.hxx
Hi, after removing all redundant #defines from file.hxx I had a look at the enum RC. At a first glance it seems that e.g. E_None is used only in pyuno_module.cxx (and in some comments in file.hxx) and could be replaced by the value osl_File_E_None from file.h. So put into a single question: Can the enum be removed as well? Removing the enum RC from FileBase and using the osl_File_ prefixed names instead means, that there are no ClassDerivedFromFileBase::E_None's (et al) but only osl_File_XXX everywhere. Could that lead to problems? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Bug 36390 title / breaks html filter fixed
Hi, my fix for bug 34666 has been too conservative. Now the test for HTML_UNKNOWNCONTROL_ON is removed and title / is treated correctly (c.f. bug 36390). I'm not sure whether there should be a test if the token is a ONOFF token? And I'm not sure if bug 36080 should be listed in the comment as well, but the strange behaviour is mentioned in the discussion of 36080. Just to emphasize: I didn't push yet because I'd like to have the questions answered first... Thank you, Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Pivot Table perf fix for 3.4
Hi there, As a heads-up, I just checked in a large-ish fix in the 3.4 branch [1], to address performance issues in the DataPilot (or Pivot Table, whatever the official name is now). Unfortunately the change turned out to be larger than I wanted it to be, especially for 3.4 which we are trying to stabilize. But I had to fix it otherwise the performance of DataPilot (or whatever the... you get the picture) would suffer. So, please watch out for any issues in this area. Thanks, Kohei [1] http://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4id=710ca4f56942cf8ad5f4494b2cb30250bf91438a -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Professional printing services
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] extensions rant
Hi Arno, Good question, i'm curious too about the website for LibreOffice extensions. Someone has good news? :-) Regards, Júlio. 2011/4/28 Arno Teigseth arnot...@gmail.com Hi all Are there any plans of launching a LO extensions site to take over? The openoffice one is more and more often offline... http://extensions.services.openoffice.org/ was down yesterday, and today too. I know of http://libreplanet.org/wiki/Group:OpenOfficeExtensions/List but it's actually linking to the openoffice server. I wouldn't mind if I didn't have my extension sitting there... best Arno ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] extensions rant
Hi Cor, I know this list is for developers, extensions website is not a developer stuff? The question is: A website will be created? What is the development plans for it? Sorry anyway, Júlio. 2011/4/28 Cor Nouws oo...@nouenoff.nl Hi Júlio, Arno, Pls mail the question to disc...@documentfoundation.org and continue debating it there. This list is for developers working together. Not for general discussions. Thanks - Cor Júlio Hoffimann wrote (28-04-11 22:38) Hi Arno, Are there any plans of launching a LO extensions site to take over? -- - http://nl.libreoffice.org - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] extensions rant
Júlio Hoffimann wrote: The question is: A website will be created? List for that: webs...@libreoffice.org -- Thorsten pgpaJRzLcZBZt.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] Support export of anonymous db data to OOXML
Hello, this patch allows to export the sheet local anonymous db data to OOXML. The export of named db data is no longer supported with this patch because Excel only supports the concept of one sheet local anonymous db data(named ranges are still supported). Additionally this patch fixes several issues around the export of built-in defined names. I tested the export of autofilter to binary excel format and OOXML and excel could read both files. Regards, Markus 0001-support-export-of-anonymous-db-data-to-OOXML.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML
On Fri, 2011-04-29 at 01:46 +0200, Markus Mohrhard wrote: Hello, this patch allows to export the sheet local anonymous db data to OOXML. The export of named db data is no longer supported with this patch because Excel only supports the concept of one sheet local anonymous db data(named ranges are still supported). Additionally this patch fixes several issues around the export of built-in defined names. I tested the export of autofilter to binary excel format and OOXML and excel could read both files. Looks good. Pushed to master. I saw one minor issue though. When I defined a global range name (Insert - Names - Define) and saved as Excel 2007 xlsx format, Excel 2007 opened the file but said that the content of defined name was unreadable must be repaired. Could you perhaps look into this? The xls binary export worked fine. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
