[Libreoffice-commits] core.git: sd/source
sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c |6 ++ 1 file changed, 6 insertions(+) New commits: commit f5e86ebc097f0f8bc5b282511149cb026710ecde Author: Stephan Bergmann sberg...@redhat.com Date: Fri Nov 14 09:08:27 2014 +0100 Silence winsock deprecation warning Change-Id: Ib0fe869e79ceea77b4dfe00a6ad387ce9c4149cc diff --git a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c index 3e5a181..f8ac116 100644 --- a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c +++ b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c @@ -26,6 +26,12 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include sal/config.h + +#if defined _WIN32 +#define _WINSOCK_DEPRECATED_NO_WARNINGS // warnings about inet_addr +#endif + #include errno.h #include stdlib.h ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Brij Mohan Lal Srivastava license statement
On 11/09/2014 02:53 PM, Brij Mohan Lal Srivastava wrote: All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. put on file at https://wiki.documentfoundation.org/index.php?title=Development/Developersoldid=104369 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Childwindow slot missing
On 11/14/2014 06:42 AM, Richard PALO wrote: Starting up 'swriter', 'scalc' or such I notice the following warnings systematically : | richard@omnis:/home/richard$ swriter | warn:sfx.control:101391:1:sfx2/source/control/dispatch.cxx:1505: | Childwindow slot missing: 10365 | warn:sfx.control:101391:1:sfx2/source/control/dispatch.cxx:1505: | Childwindow slot missing: 10365 | warn:sfx.control:101391:1:sfx2/source/control/dispatch.cxx:1505: | Childwindow slot missing: 10365 Searching bugzilla it seems I'm not alone, although it doesn't seem to be the primary topic. Is this a concern needing a specific issue to be filed? That's SAL_WARN output from a debug build (cf. https://wiki.documentfoundation.org/Development/GeneralProgrammingGuidelines#Assertions_and_Logging). In this particular case, smells like reporting about the consequences of a probably harmless minor programming error someplace else. Filing a bugzilla issue about it is unlikely to be helpful. (But a patch would surely be welcome.) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
On 11/14/2014 07:49 AM, Noel Grandin wrote: On 2014-11-13 06:13 PM, Michael Meeks wrote: * library bloat (Michael S) + not really an issue for release builds - --enable-mergelibs + big library + --enable-symbols - OOM + especially problematic CppuniTests with use_library_objects + perhaps a barrier to entry to new developers + Calc: (with debuginfo) 4.1 - 413Mb, 4.3 - 512Mb, master - 600Mb (stripped)4.3 - 26.8Mb master - 30Mb + linking in parallel gives OOM issues. = avoid making libraries even bigger. + new calc engine uses lots of templates (Markus) + mdds usage is restricted to only a few modules: (Kohei) + 5-6 translation units only. + whole code-base is using lots more templates (Markus) + compilation speed also got more than 2x slower (Kohei) + use of own templates container - STL + recently turned a lot of methods to inline methods left/right (Kohei) Some suggestions: (1) Would it make a difference if I went through the *.hxx files, marking the inline methods with an explicit inline qualifier? Yes, it would needlessly clutter the code. ;) I don't see what benefit you're trying to achieve here? (2) Perhaps we need to be using the extern template feature to limit the number of instantiations of various templates? Template instantiations, via the typical all-inline nature of the template declarations, have hidden visibility and should end up with one copy per dynamic object. I'm not sure whether there would be much compile- or run-time benefit from using another strategy (plus, I'm not sure whether it would work well across the various toolchains to give template instantiations non-hidden visibility). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] website.git: Branch 'update' - check.php
check.php | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
New commits:
commit d542fe540e752138ed2879dc810152ad71d29948
Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Date: Fri Nov 14 11:06:50 2014 +0100
enable update to 4.3.4
diff --git a/check.php b/check.php
index e27d2af..a568b3a 100644
--- a/check.php
+++ b/check.php
@@ -286,6 +286,9 @@ $build_hash_to_version = array(
'5fdddf655fba363e34f755715238d0943a44857e' = '4.2.6.1',
'185f2ce4dcc34af9bd97dec29e6d42c39557298f' = '4.2.6.2', # Final
'3fd416d4c6db7d3204c17ce57a1d70f6e531ee21' = '4.2.6.3', # unscheduled,
4.2.6-secfix
+# 4.2.7
+'ad618ebe74a072c4ad8fae3b902f6ff1be98983d' = '4.2.7.1',
+'933c0aa564ec4f8883ed5732c866db48dca4dac5' = '4.2.7.2', # Final
##
# 4.3.0 versions
@@ -299,6 +302,20 @@ $build_hash_to_version = array(
# 4.3.1
'c4b15cd4d00dec6b266fa830b4ba73e31ae6ce73' = '4.3.1.1',
'958349dc3b25111dbca392fbc281a05559ef6848' = '4.3.1.2', # Final
+# 4.3.2
+'f9b3ad49d92181b0a1fe7e76f785a2c2cd0847d3' = '4.3.2.1',
+'edfb5295ba211bd31ad47d0bad0118690f76407d' = '4.3.2.2', # Final
+# 4.3.3
+'65dc54c61032b7ebe54405cba6b4fb172b9af7d6' = '4.3.3.1', # initial tag, no
builds done
+'7d55112667c8fcddb67bc3803796b46c93aa56b0' = '4.3.3.1', # rc1-buildfix1
+'9bb7eadab57b6755b1265afa86e04bf45fbfc644' = '4.3.3.2', # Final
+# 4.3.4
+'bc356b2f991740509f321d70e4512a6a54c5f243' = '4.3.4.1', # Final
(unscheduled additional release)
+
+##
+# 4.4.0 versions
+'e73cb2cc40530caa75d588833c4b690e4f49f630' = '4.4.0.0.a1', # alpha1 (calc
rendering probs)
+'24f0a5815f581dd9a7f09d30213a379edee6e9ac' = '4.4.0.0.a1', # alpha2
);
# Descriptions of the target versions
@@ -318,11 +335,11 @@ $update_map = array(
'update_src' =
'http://www.libreoffice.org/download/libreoffice-still/?type=typeamp;lang=langamp;version=4.2.6',
'substitute' = true ),
-'latest' = array('gitid' =
'958349dc3b25111dbca392fbc281a05559ef6848',
- 'id' = 'LibreOffice 4.3.1',
- 'version' = '4.3.1',
+'latest' = array('gitid' =
'bc356b2f991740509f321d70e4512a6a54c5f243',
+ 'id' = 'LibreOffice 4.3.4',
+ 'version' = '4.3.4',
'update_type' = 'text/html',
- 'update_src' =
'http://www.libreoffice.org/download/libreoffice-fresh/?type=typeamp;lang=langamp;version=4.3.1',
+ 'update_src' =
'http://www.libreoffice.org/download/libreoffice-fresh/?type=typeamp;lang=langamp;version=4.3.4',
'substitute' = true ),
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] website.git: Branch 'update' - check.php
check.php |4 1 file changed, 4 insertions(+) New commits: commit f24c0780445895ceaa71be8159dd29d7f2a4b12b Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Fri Nov 14 11:09:36 2014 +0100 add missing 4.3.0 hashes diff --git a/check.php b/check.php index a568b3a..70538ee 100644 --- a/check.php +++ b/check.php @@ -299,6 +299,10 @@ $build_hash_to_version = array( 'a06aa316117a6ff0f05c697c82831c227812d810' = '4.3.0.0.b1', # beta1-buildfix1 '67f5430184326974072b65403ef1d9d934fc4481' = '4.3.0.1', # rc1 '9ed0c4329cf13f882dab0ee8b9ecd7b05e4aafbb' = '4.3.0.1', # rc1-buildfix1 +'14ed55896fdfcb93ff437b85c4f3e1923d2b1409' = '4.3.0.2', # rc2 +'fcd3838c4097f7817b5b3984fd88a44e1edd8548' = '4.3.0.3', # rc3 +'08ebe52789a201dd7d38ef653ef7a48925e7f9f7' = '4.3.0.3', # rc3-buildfix1 +'62ad5818884a2fc2e5780dd45466868d41009ec0' = '4.3.0.4', # Final # 4.3.1 'c4b15cd4d00dec6b266fa830b4ba73e31ae6ce73' = '4.3.1.1', '958349dc3b25111dbca392fbc281a05559ef6848' = '4.3.1.2', # Final ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/charatr.hxx | 137 +--
sw/inc/dbfld.hxx|7
sw/inc/docufld.hxx |4
sw/inc/edimp.hxx|9 +
sw/inc/ftninfo.hxx |3
sw/inc/unoframe.hxx |2
sw/source/core/doc/CntntIdxStore.cxx|8
sw/source/core/doc/DocumentContentOperationsManager.cxx | 20 +-
sw/source/core/doc/DocumentDeviceManager.cxx|2
sw/source/core/doc/DocumentDrawModelManager.cxx |4
sw/source/core/doc/DocumentFieldsManager.cxx| 142
sw/source/core/doc/DocumentStateManager.cxx |4
sw/source/core/doc/DocumentStatisticsManager.cxx|2
sw/source/core/doc/DocumentTimerManager.cxx |2
sw/source/core/doc/doccorr.cxx | 43 ++--
sw/source/core/doc/docdesc.cxx | 12 -
sw/source/core/doc/docdraw.cxx | 34 +--
sw/source/core/doc/docedt.cxx | 28 +--
sw/source/core/doc/docfld.cxx | 74
sw/source/core/doc/docfly.cxx | 44 ++--
sw/source/core/doc/docfmt.cxx | 71 +++-
sw/source/core/doc/docftn.cxx | 10 -
sw/source/core/doc/docglbl.cxx | 10 -
sw/source/core/doc/docglos.cxx |2
sw/source/core/doc/doclay.cxx | 34 +--
sw/source/core/doc/docnum.cxx |6
sw/source/core/doc/docredln.cxx | 18 +-
sw/source/core/doc/docruby.cxx |8
sw/source/core/doc/docsort.cxx |2
sw/source/core/doc/doctxm.cxx | 26 +-
30 files changed, 406 insertions(+), 362 deletions(-)
New commits:
commit a05da74d0bdf691f097aa925fa59e21203ade8ed
Author: Noel Grandin n...@peralex.com
Date: Fri Nov 14 08:36:38 2014 +0200
loplugin: cstylecast
Change-Id: I7235a67e85c10ec9fefe7f718cda18f633cda97a
diff --git a/sw/inc/charatr.hxx b/sw/inc/charatr.hxx
index b791a7c..6e24a98 100644
--- a/sw/inc/charatr.hxx
+++ b/sw/inc/charatr.hxx
@@ -21,89 +21,116 @@
#include format.hxx
#include hintids.hxx
+#include editeng/postitem.hxx
+#include editeng/wghtitem.hxx
+#include editeng/shdditem.hxx
+#include editeng/autokernitem.hxx
+#include editeng/wrlmitem.hxx
+#include editeng/contouritem.hxx
+#include editeng/kernitem.hxx
+#include editeng/udlnitem.hxx
+#include editeng/crossedoutitem.hxx
+#include editeng/fhgtitem.hxx
+#include editeng/prszitem.hxx
+#include editeng/fontitem.hxx
+#include editeng/charsetcoloritem.hxx
+#include editeng/escapementitem.hxx
+#include editeng/cmapitem.hxx
+#include editeng/nhypitem.hxx
+#include editeng/blinkitem.hxx
+#include editeng/brushitem.hxx
+#include editeng/emphasismarkitem.hxx
+#include editeng/twolinesitem.hxx
+#include editeng/charscaleitem.hxx
+#include editeng/charrotateitem.hxx
+#include editeng/charreliefitem.hxx
+#include editeng/charhiddenitem.hxx
+#include editeng/boxitem.hxx
+#include editeng/shaditem.hxx
+#include editeng/langitem.hxx
// implementation of the character attribute methods of SwAttrSet
inline const SvxPostureItem SwAttrSet::GetPosture(bool bInP) const
-{ return (const SvxPostureItem)Get( RES_CHRATR_POSTURE,bInP); }
+{ return static_castconst SvxPostureItem(Get(
RES_CHRATR_POSTURE,bInP)); }
inline const SvxPostureItem SwAttrSet::GetCJKPosture(bool bInP) const
-{ return (const SvxPostureItem)Get( RES_CHRATR_CJK_POSTURE,bInP); }
+{ return static_castconst SvxPostureItem(Get(
RES_CHRATR_CJK_POSTURE,bInP)); }
inline const SvxPostureItem SwAttrSet::GetCTLPosture(bool bInP) const
-{ return (const SvxPostureItem)Get( RES_CHRATR_CTL_POSTURE,bInP); }
+{ return static_castconst SvxPostureItem(Get(
RES_CHRATR_CTL_POSTURE,bInP)); }
inline const SvxWeightItem SwAttrSet::GetWeight(bool bInP) const
-{ return (const SvxWeightItem)Get( RES_CHRATR_WEIGHT,bInP); }
+{ return static_castconst SvxWeightItem(Get(
RES_CHRATR_WEIGHT,bInP)); }
inline const SvxWeightItem SwAttrSet::GetCJKWeight(bool bInP) const
-{ return (const SvxWeightItem)Get( RES_CHRATR_CJK_WEIGHT,bInP); }
+{ return static_castconst SvxWeightItem(Get(
RES_CHRATR_CJK_WEIGHT,bInP)); }
inline const SvxWeightItem SwAttrSet::GetCTLWeight(bool bInP) const
-{ return (const SvxWeightItem)Get( RES_CHRATR_CTL_WEIGHT,bInP); }
+{ return static_castconst SvxWeightItem(Get(
RES_CHRATR_CTL_WEIGHT,bInP)); }
inline const SvxShadowedItem SwAttrSet::GetShadowed(bool bInP) const
-{ return (const SvxShadowedItem)Get(
Re: minutes of ESC call ...
On Friday 14 of November 2014, Stephan Bergmann wrote: On 11/14/2014 07:49 AM, Noel Grandin wrote: (2) Perhaps we need to be using the extern template feature to limit the number of instantiations of various templates? Template instantiations, via the typical all-inline nature of the template declarations, have hidden visibility and should end up with one copy per dynamic object. But also with one copy per .o file, which presumably contributes to higher resource demands for building. It's also a question if the linker is as good at discarding duplicate debuginfo about templates. I'm not sure whether there would be much compile- or run-time benefit from using another strategy (plus, I'm not sure whether it would work well across the various toolchains to give template instantiations non-hidden visibility). Given we have SAL_DLLPUBLIC_TEMPLATE, it seems likely that there shouldn't be any big trouble there. -- Lubos Lunak l.lu...@collabora.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
On Friday 14 of November 2014, Noel Grandin wrote: (3) Use gcc's -gsplit-dwarf feature to reduce size of debug information (clang also has some support for this) https://gcc.gnu.org/wiki/DebugFission We could auto-detect this in configure.ac and use it if available. There's rather tool poor support for this feature so far. It e.g. requires relatively recent gdb (and IIRC the support was buggy in some versions, I'm not sure how well it works now. Neither ccache nor icecream support the option (for ccache there's a 3rd party patch that has not been integrated, for icecream I have a patch but compilers do not allow specifying proper path refering to the .dwo file when building in a different path). -- Lubos Lunak l.lu...@collabora.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 21 commits - basic/source connectivity/source cui/source dbaccess/source editeng/source extensions/Library_scn.mk extensions/source filter/source forms/source jvmfwk/pl
basic/source/classes/image.cxx| 11 +
connectivity/source/drivers/dbase/DTable.cxx |4
connectivity/source/drivers/firebird/Blob.cxx | 31 +
cui/source/options/optjava.cxx|6 -
dbaccess/source/core/dataaccess/databasedocument.cxx | 11 +
editeng/source/editeng/editobj.cxx| 13 +-
extensions/Library_scn.mk |1
extensions/source/scanner/sane.cxx|7 -
filter/source/graphicfilter/icgm/class5.cxx | 12 +-
forms/source/component/FormComponent.cxx | 14 ++
jvmfwk/plugins/sunmajor/javaenvsetup/javaldx.cxx | 100 --
lotuswordpro/source/filter/lwpbulletstylemgr.cxx |4
lotuswordpro/source/filter/lwpcelllayout.cxx |7 -
lotuswordpro/source/filter/lwpdrawobj.cxx | 22 +--
lotuswordpro/source/filter/lwpfoundry.cxx |2
lotuswordpro/source/filter/lwpframelayout.cxx |4
lotuswordpro/source/filter/lwpfrib.cxx| 12 +-
lotuswordpro/source/filter/lwpfribbreaks.cxx |4
lotuswordpro/source/filter/lwpfribframe.cxx |2
lotuswordpro/source/filter/lwpfribmark.cxx|6 -
lotuswordpro/source/filter/lwpfribsection.cxx |6 -
lotuswordpro/source/filter/lwpfribtable.cxx |2
lotuswordpro/source/filter/lwpfribtext.cxx|4
lotuswordpro/source/filter/lwpgrfobj.cxx |4
lotuswordpro/source/filter/lwppagelayout.cxx |8 -
lotuswordpro/source/filter/lwppara.cxx| 18 +--
lotuswordpro/source/filter/lwppara1.cxx |8 -
lotuswordpro/source/filter/lwprowlayout.cxx |4
lotuswordpro/source/filter/lwpsilverbullet.cxx|2
lotuswordpro/source/filter/lwptablelayout.cxx | 12 +-
lotuswordpro/source/filter/lwptoc.cxx |2
lotuswordpro/source/filter/xfilter/xfstylecont.cxx| 14 +-
lotuswordpro/source/filter/xfilter/xfstylecont.hxx| 13 ++
lotuswordpro/source/filter/xfilter/xfstylemanager.cxx | 59 +-
lotuswordpro/source/filter/xfilter/xfstylemanager.hxx |2
sc/source/ui/optdlg/calcoptionsdlg.cxx| 28 +
sd/source/ui/view/drviewse.cxx|6 -
sdext/source/pdfimport/test/pdf2xml.cxx |5
svl/source/items/macitem.cxx | 20 +++
sw/source/uibase/docvw/edtwin.cxx |2
tools/source/generic/config.cxx |5
vcl/generic/print/glyphset.cxx| 10 +
vcl/source/gdi/impfont.cxx| 13 +-
vcl/unx/generic/dtrans/bmp.cxx| 18 ++-
44 files changed, 331 insertions(+), 207 deletions(-)
New commits:
commit 8fe8c2e3d4d1ab44cfa53160e309255c109251d3
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 11:41:20 2014 +
coverity#1242630 Untrusted loop bound
Change-Id: I985f47d6e5f5aa86099b86ad4666b194f4b25b83
diff --git a/svl/source/items/macitem.cxx b/svl/source/items/macitem.cxx
index 98e9a98..24c4cc7 100644
--- a/svl/source/items/macitem.cxx
+++ b/svl/source/items/macitem.cxx
@@ -100,10 +100,24 @@ SvStream SvxMacroTableDtor::Read( SvStream rStrm,
sal_uInt16 nVersion )
{
if( SVX_MACROTBL_VERSION40 = nVersion )
rStrm.ReadUInt16( nVersion );
-short nMacro;
-rStrm.ReadInt16( nMacro );
-for( short i = 0; i nMacro; ++i )
+short nMacro(0);
+rStrm.ReadInt16(nMacro);
+
+const size_t nMinStringSize = rStrm.GetStreamCharSet() ==
RTL_TEXTENCODING_UNICODE ? 4 : 2;
+size_t nMinRecordSize = 2 + 2*nMinStringSize;
+if( SVX_MACROTBL_VERSION40 = nVersion )
+nMinRecordSize+=2;
+
+const size_t nMaxRecords = rStrm.remainingSize() / nMinRecordSize;
+if (nMacro 0 static_castsize_t(nMacro) nMaxRecords)
+{
+SAL_WARN(editeng, Parsing error: nMaxRecords
+ max possible entries, but nMacro claimed,
truncating);
+nMacro = nMaxRecords;
+}
+
+for (short i = 0; i nMacro; ++i)
{
sal_uInt16 nCurKey, eType = STARBASIC;
OUString aLibName, aMacName;
commit 8e6c22d74933c7157e083e97d56106b36a166559
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 11:35:00 2014 +
coverity#1209889 Untrusted loop bound
Change-Id: I63039ca0de1dc54b5aa9d048e5110c31bf930bdc
diff --git a/filter/source/graphicfilter/icgm/class5.cxx
b/filter/source/graphicfilter/icgm/class5.cxx
index a1a9bfb..763971a 100644
--- a/filter/source/graphicfilter/icgm/class5.cxx
+++ b/filter/source/graphicfilter/icgm/class5.cxx
@@ -461,10 +461,18 @@ void CGM::ImplDoClass5()
sal_uInt32 i, nColorFrom = 0;
sal_uInt32 nColorTo = 0xff;
-//FIXME, does this loop actually do anything?
+
[Libreoffice-commits] core.git: Changes to 'private/llunak/mailmerge_02'
New branch 'private/llunak/mailmerge_02' available with the following commits: commit 44f40b82d52cfe60de3f18ed5aeae04171c9b197 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Nov 9 22:59:41 2014 +0100 avoid unused argument warning Change-Id: Ib67b804423b521407710f8319cb89977e44494cc commit 390b6e5cf66363275ac693bfc37ead8508412c86 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Nov 9 22:37:11 2014 +0100 speed up SwDoc::IsInHeaderFooter() by using SwFrmFmtAnchorMap Now that it's possible to quickly find anchored objects for a node, it's actually faster to check the node hiearchy rather than layout. Conflicts: sw/source/core/doc/doclay.cxx Change-Id: I5f93d5af32c744f1773535e5ec8537334d1ff58a commit f679e32f892d7ac198d511d53b524d7059ff42fc Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Nov 9 15:30:08 2014 +0100 faster mapping from nodes to SwFrmFmt's anchored at them The SwFrmFmtAnchorMap class provides reverse mapping to SwFrmFmt::GetAnchor().GetCntntAnchor(), so that when code somewhere needs to update SwFrmFmt's anchored at a position, it's not necessary to iterate over all of them (which can be a large number e.g. with mail merge). One special catch with the multimap of SwNodeIndex keys is that the values of those keys change (whenever the node structure of the document changes, indexes of nodes change as a result). This makes it impossible to use any hashing container, as the hashes would change without the container noticing, but multimap should work fine, as it just requires that the keys remain sorted, and that is the case. Nevertheless, the old code in the two converted places is intentionally left there in debug mode to verify the reverse mapping is updated correctly. I intentionally went with SwNodeIndex rather than SwPosition, as SwIndex (the other component of SwPosition) was causing some trouble (see e.g. the SwPosition comparison operator , where two same positions are different if one is registered and the other not) and it doesn't appear to be actually necessary. Conflicts: sw/inc/doc.hxx sw/inc/frmfmt.hxx sw/source/core/attr/swatrset.cxx sw/source/core/doc/docnew.cxx sw/source/core/inc/frmtool.hxx sw/source/core/layout/atrfrm.cxx sw/source/core/txtnode/ndtxt.cxx Change-Id: I7f1768558f60155d4ba83c84aa7f9e34dc65ebf9 commit 0bc4baf73ce11a777195a31c23496960f60f6dfb Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Nov 9 10:33:00 2014 +0100 do not break encapsulation of SwFmtAnchor::GetCntntAnchor() Conflicts: sw/source/core/doc/DocumentContentOperationsManager.cxx sw/source/core/frmedt/fefly1.cxx sw/source/core/frmedt/feshview.cxx sw/source/core/layout/flycnt.cxx sw/source/core/txtnode/atrflyin.cxx Change-Id: I0a320eb990f9a3b6800447a97a84c118239bae96 commit 0e8534395c3ba0d328a14525d145ff3e75b1457d Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sat Nov 8 09:41:02 2014 +0100 do not bother with nice unique names during mailmerge When using a single document for all the generating MM documents, there can be a significant number of sections/etc. , enough to make searching them all in order to find a next nice unique name take a noticeable time. Since it's very unlikely anybody will ever care about nice names after mailmerge, just get some unique name in a fast way. Conflicts: sw/source/core/doc/docbm.cxx sw/source/core/doc/doclay.cxx sw/source/core/doc/docnum.cxx sw/source/core/doc/doctxm.cxx sw/source/core/docnode/ndsect.cxx sw/source/core/inc/MarkManager.hxx Change-Id: Id6b8d39a67529984cb93bb369f2c6eab401f1799 commit 4ca3a96ff8b5c05aa8a4e48000a1ee485a59707a Author: Adam Co rattles2...@gmail.com Date: Tue Nov 26 13:56:46 2013 +0200 Moved 'DateTimeToOString' from 'filter' package to 'tools' package After the move now other classes can convert DateTime to OString also Reviewed on: https://gerrit.libreoffice.org/6816 Conflicts: sw/source/filter/ww8/docxattributeoutput.cxx Change-Id: I0ceb9a5cc26103a6cb36d7765a717770ec3fbe7d commit 0524dee2a9a1b4ff43a19654ab73ff764e7cadef Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sat Nov 8 09:15:49 2014 +0100 actually use return value of GetUniqueSectionName() in SwDoc::UpdateSection() Change-Id: I6d9ae98e900e5e42c5253ee9b2f71bec351b54d1 commit e64428fa982838bd40d068ac65943fcf3c1ed76f Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Fri Nov 7 16:14:21 2014 +0100 do not iterate over all bookmarks in SwTxtNode::Update() 3f9872185e introduced new API for fast finding of marks to a specific text node, so use that (code itself based on cb46aaf2d7).
4.4 refactorings and BHS (was: minutes of ESC call ...)
Hi, On Thu, Nov 13, 2014 at 04:13:33PM +, Michael Meeks wrote: * QA (Robinson) There is a Bug Hunting Session for 4.4 coming up next week. If you did any bigger refactoring or other work that primarily can be assumed to affect a specific area of usecases, please add this to: https://wiki.documentfoundation.org/BugHunting_Session_4.4.0.0#What_to_test so we can get early warning on e.g. regressions by some more focussed testing. Of course, if you did something that is not only a refactoring bug actually brings new features, you are invited to add this to: https://wiki.documentfoundation.org/ReleaseNotes/4.4 so that marketing can use it too and e.g. prepare cute screenshots. @Michael: Can we add that reminder for the next ESC call too? Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: scp2/source
scp2/source/ooo/vc_redist.scp | 11 +++ scp2/source/winexplorerext/file_winexplorerext.scp | 20 2 files changed, 31 insertions(+) New commits: commit ef7e29998c5e86c4174e9dbe16c157705f9dc129 Author: Andras Timar andras.ti...@collabora.com Date: Fri Nov 14 14:11:13 2014 +0100 add redist files for VS 2013 Change-Id: I07c7af3b9b7d3335074d712c35cef9d7828a271b diff --git a/scp2/source/ooo/vc_redist.scp b/scp2/source/ooo/vc_redist.scp index e1c114c..b9ee3f2 100644 --- a/scp2/source/ooo/vc_redist.scp +++ b/scp2/source/ooo/vc_redist.scp @@ -40,3 +40,14 @@ End #endif +#if defined(WITH_VC120_REDIST) + +MergeModule gid_MergeModule_Microsoft_VC120_CRT_x86 +Feature = gm_Root; +Name = Microsoft_VC120_CRT_x86.msm; +RootDir = TARGETDIR; +ComponentCondition = VC_REDIST=1; +End + +#endif + diff --git a/scp2/source/winexplorerext/file_winexplorerext.scp b/scp2/source/winexplorerext/file_winexplorerext.scp index c7fcd69..7567896 100644 --- a/scp2/source/winexplorerext/file_winexplorerext.scp +++ b/scp2/source/winexplorerext/file_winexplorerext.scp @@ -65,4 +65,24 @@ End #endif +#if defined(WITH_VC120_REDIST) + +File gid_File_Lib_Msvcr120 +LIB_FILE_BODY; +Styles = (PACKED); +Dir = gid_Dir_Shlxthdl; +Name = msvcr120.dll; +ComponentCondition = VersionNT64; +End + +File gid_File_Lib_Msvcp120 +LIB_FILE_BODY; +Styles = (PACKED); +Dir = gid_Dir_Shlxthdl; +Name = msvcp120.dll; +ComponentCondition = VersionNT64; +End + +#endif + #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 75757] remove inheritance to std::map and std::vector
https://bugs.freedesktop.org/show_bug.cgi?id=75757 --- Comment #45 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Juan Picca committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ec556b0726e51010aebaa4849195444fda4aa1d fdo#75757: remove inheritance to std::map It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/accmap.cxx | 64 +++
1 file changed, 51 insertions(+), 13 deletions(-)
New commits:
commit 2ec556b0726e51010aebaa4849195444fda4aa1d
Author: Juan Picca jumap...@gmail.com
Date: Thu Nov 13 08:03:21 2014 -0200
fdo#75757: remove inheritance to std::map
Change-Id: I26ec60868c7854517b81ade3aec6b7ab29b0aa89
Reviewed-on: https://gerrit.libreoffice.org/12401
Reviewed-by: Takeshi Abe t...@fixedpoint.jp
Tested-by: Takeshi Abe t...@fixedpoint.jp
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 6a153ff..92e75a4 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -86,11 +86,18 @@ struct SwFrmFunc
}
};
-typedef ::std::map const SwFrm *, uno::WeakReference XAccessible ,
SwFrmFunc _SwAccessibleContextMap_Impl;
-
-class SwAccessibleContextMap_Impl: public _SwAccessibleContextMap_Impl
+class SwAccessibleContextMap_Impl
{
public:
+typedef const SwFrm *
key_type;
+typedef uno::WeakReference XAccessible
mapped_type;
+typedef std::pairconst key_type,mapped_type
value_type;
+typedef SwFrmFunc
key_compare;
+typedef std::mapkey_type,mapped_type,key_compare::iterator
iterator;
+typedef std::mapkey_type,mapped_type,key_compare::const_iterator
const_iterator;
+private:
+std::map key_type,mapped_type,key_compare maMap;
+public:
#if OSL_DEBUG_LEVEL 0
bool mbLocked;
@@ -102,6 +109,13 @@ public:
#endif
{}
+iterator begin() { return maMap.begin(); }
+iterator end() { return maMap.end(); }
+bool empty() const { return maMap.empty(); }
+void clear() { maMap.clear(); }
+iterator find(const key_type key) { return maMap.find(key); }
+std::pairiterator,bool insert(const value_type value ) { return
maMap.insert(value); }
+iterator erase(const_iterator pos) { return maMap.erase(pos); }
};
class SwDrawModellListener_Impl : public SfxListener,
@@ -579,11 +593,23 @@ struct SwAccessibleChildFunc
}
};
-typedef ::std::map SwAccessibleChild, SwAccessibleEventList_Impl::iterator,
- SwAccessibleChildFunc _SwAccessibleEventMap_Impl;
-
-class SwAccessibleEventMap_Impl: public _SwAccessibleEventMap_Impl
+class SwAccessibleEventMap_Impl
{
+public:
+typedef SwAccessibleChild
key_type;
+typedef SwAccessibleEventList_Impl::iterator
mapped_type;
+typedef std::pairconst key_type,mapped_type
value_type;
+typedef SwAccessibleChildFunc
key_compare;
+typedef std::mapkey_type,mapped_type,key_compare::iterator
iterator;
+typedef std::mapkey_type,mapped_type,key_compare::const_iterator
const_iterator;
+private:
+std::map key_type,mapped_type,key_compare maMap;
+public:
+iterator begin() { return maMap.begin(); }
+iterator end() { return maMap.end(); }
+iterator find(const key_type key) { return maMap.find(key); }
+std::pairiterator,bool insert(const value_type value ) { return
maMap.insert(value); }
+iterator erase(const_iterator pos) { return maMap.erase(pos); }
};
struct SwAccessibleParaSelection
@@ -607,12 +633,24 @@ struct SwXAccWeakRefComp
}
};
-typedef ::std::map uno::WeakReference XAccessible ,
-SwAccessibleParaSelection,
-SwXAccWeakRefComp _SwAccessibleSelectedParas_Impl;
-
-class SwAccessibleSelectedParas_Impl: public _SwAccessibleSelectedParas_Impl
-{};
+class SwAccessibleSelectedParas_Impl
+{
+public:
+typedef uno::WeakReference XAccessible
key_type;
+typedef SwAccessibleParaSelection
mapped_type;
+typedef std::pairconst key_type,mapped_type
value_type;
+typedef SwXAccWeakRefComp
key_compare;
+typedef std::mapkey_type,mapped_type,key_compare::iterator
iterator;
+typedef std::mapkey_type,mapped_type,key_compare::const_iterator
const_iterator;
+private:
+std::mapkey_type,mapped_type,key_compare maMap;
+public:
+iterator begin() { return maMap.begin(); }
+iterator end() { return maMap.end(); }
+iterator find(const key_type key) { return maMap.find(key); }
+std::pairiterator,bool insert(const value_type value ) { return
maMap.insert(value); }
+iterator erase(const_iterator pos) { return maMap.erase(pos); }
+};
// helper class that stores preview data
class SwAccPreviewData
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 6 commits - vcl/inc vcl/opengl vcl/source vcl/win vcl/workben
vcl/inc/impimagetree.hxx |7 ++-
vcl/opengl/salbmp.cxx| 12 +-
vcl/source/gdi/impimage.cxx |9 ++--
vcl/source/gdi/impimagetree.cxx | 69 +++--
vcl/win/source/gdi/winlayout.cxx | 72 +++
vcl/workben/vcldemo.cxx | 70 +
6 files changed, 183 insertions(+), 56 deletions(-)
New commits:
commit f1e5ea6801085b9594263cf41d7421b618189973
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 14 11:58:28 2014 +
vcldemo: dump and render all icons from images.zip when zoomed in.
Change-Id: I89f37b8a1ed70334a3485bc3ca06d04cfe6d0827
diff --git a/vcl/inc/impimagetree.hxx b/vcl/inc/impimagetree.hxx
index 712ec80..9e4f579 100644
--- a/vcl/inc/impimagetree.hxx
+++ b/vcl/inc/impimagetree.hxx
@@ -55,6 +55,8 @@ public:
* be too late for the destructors of the bitmaps in m_iconCache)*/
void shutDown();
+css::uno::Reference css::container::XNameAccess getNameAccess();
+
private:
bool doLoadImage(
OUString const name, OUString const style,
@@ -62,8 +64,7 @@ private:
typedef std::pair
OUString,
-com::sun::star::uno::Reference
-com::sun::star::container::XNameAccess Path;
+css::uno::Reference css::container::XNameAccess Path;
typedef boost::unordered_map
OUString, bool, OUStringHash CheckStyleCache;
@@ -78,6 +79,8 @@ private:
bool m_cacheIcons;
IconLinkHash m_linkHash;
+bool checkPathAccess();
+
void setStyle(OUString const style );
void resetPaths();
@@ -89,7 +92,6 @@ private:
void loadImageLinks();
void parseLinkFile(boost::shared_ptr SvStream stream);
OUString const getRealImageName(OUString const name);
-std::vectorOUString getAllPaths();
};
typedef salhelper::SingletonRef ImplImageTree ImplImageTreeSingletonRef;
diff --git a/vcl/source/gdi/impimagetree.cxx b/vcl/source/gdi/impimagetree.cxx
index b5fc822..0778bec 100644
--- a/vcl/source/gdi/impimagetree.cxx
+++ b/vcl/source/gdi/impimagetree.cxx
@@ -248,17 +248,9 @@ bool ImplImageTree::find(
}
}
-if (!m_path.second.is()) {
-try {
-m_path.second =
css::packages::zip::ZipFileAccess::createWithURL(comphelper::getProcessComponentContext(),
m_path.first + .zip);
-} catch (const css::uno::RuntimeException ) {
-throw;
-} catch (const css::uno::Exception e) {
-SAL_INFO(vcl, ImplImageTree::find exception
- e.Message for m_path.first);
-return false;
-}
-}
+if (!checkPathAccess())
+return false;
+
for (std::vector OUString ::const_reverse_iterator j(paths.rbegin());
j != paths.rend(); ++j)
{
@@ -288,21 +280,9 @@ void ImplImageTree::loadImageLinks()
}
}
-if ( !m_path.second.is() )
-{
-try
-{
-m_path.second =
css::packages::zip::ZipFileAccess::createWithURL(comphelper::getProcessComponentContext(),
m_path.first + .zip);
-} catch (const css::uno::RuntimeException ) {
-throw;
-}
-catch (const css::uno::Exception e)
-{
-SAL_INFO(vcl, ImplImageTree::find exception
- e.Message for m_path.first);
-return;
-}
-}
+if (!checkPathAccess())
+return;
+
if ( m_path.second-hasByName(aLinkFilename) )
{
css::uno::Reference css::io::XInputStream s;
@@ -349,21 +329,41 @@ OUString const ImplImageTree::getRealImageName(OUString
const name)
return it-second;
}
-std::vectorOUString ImplImageTree::getAllPaths()
+bool ImplImageTree::checkPathAccess()
{
-std::vectorOUString aNames;
+if (m_path.second.is())
+return true;
+
+try {
+m_path.second =
css::packages::zip::ZipFileAccess::createWithURL(comphelper::getProcessComponentContext(),
m_path.first + .zip);
+} catch (const css::uno::RuntimeException ) {
+throw;
+} catch (const css::uno::Exception e) {
+SAL_INFO(vcl, ImplImageTree::zip file location exception
+ e.Message for m_path.first);
+return false;
+}
+return m_path.second.is();
+}
-return aNames;
+css::uno::Reference css::container::XNameAccess
ImplImageTree::getNameAccess()
+{
+checkPathAccess();
+return m_path.second;
}
// For vcldemo / debugging
-SAL_DLLPUBLIC std::vectorOUString ImageTree_getAllImageNames();
+SAL_DLLPUBLIC css::uno::Sequence OUString ImageTree_getAllImageNames();
/// Recursively dump all names ...
-std::vectorOUString ImageTree_getAllImageNames()
+css::uno::Sequence OUString ImageTree_getAllImageNames()
{
static ImplImageTreeSingletonRef aImageTree;
-return aImageTree.getAllPaths();
+
+css::uno::Reference css::container::XNameAccess xRef(
+
Re: minutes of ESC call ...
On 2014-11-14 01:15 PM, Lubos Lunak wrote: On Friday 14 of November 2014, Noel Grandin wrote: (3) Use gcc's -gsplit-dwarf feature to reduce size of debug information (clang also has some support for this) https://gcc.gnu.org/wiki/DebugFission We could auto-detect this in configure.ac and use it if available. There's rather tool poor support for this feature so far. It e.g. requires relatively recent gdb (and IIRC the support was buggy in some versions, I'm not sure how well it works now. Neither ccache nor icecream support the option (for ccache there's a 3rd party patch that has not been integrated, for icecream I have a patch but compilers do not allow specifying proper path refering to the .dwo file when building in a different path). But that's never stopped us before! We love using features that are just barely stable! Especially since given our size we are guaranteed to head all of the edge cases and O(n^2) algorithms still lurking in the tools.. :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: bin/check-merged.sh
bin/check-merged.sh | 36
1 file changed, 36 insertions(+)
New commits:
commit 710c664083063b4ab5aaa246f204a6f4db9078c0
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 14 15:07:14 2014 +0100
Script that finds commits in a branch that were not pushed to master.
Trivial, but based on the Change-Id's, so hopefully reliable enough :-)
Change-Id: I919a2dc47f088ec4d750b74c68a0b062478d
diff --git a/bin/check-merged.sh b/bin/check-merged.sh
new file mode 100755
index 000..cd39c42
--- /dev/null
+++ b/bin/check-merged.sh
@@ -0,0 +1,36 @@
+#! /bin/bash
+#
+# check that master contains all the patches from a brach
+# and list those that are missing
+#
+
+BRANCH=$1
+[ -z $BRANCH ] {
+cat 12 EOF
+check-merged.sh branchname
+
+Checks that all the patches from branch 'branchname' are in master, and
+reports the commits that are not.
+
+The check is based on the Change-Id's, so if some commits are missing it, they
+won't be detected as missing.
+EOF
+exit 1;
+}
+
+function collect_change_ids {
+git log `git merge-base origin/master origin/feature/opengl-vcl`..$1 | \
+sed 's/^commit /XXXcommitXXX/g' | \
+tr '\n' ';' | \
+sed 's/XXXcommitXXX/\n/g' | \
+sed -e 's/;.*Change-Id://' -e 's/;.*$//' | \
+grep -v '^$' $2
+}
+
+collect_change_ids $BRANCH /tmp/check-merged.branch
+collect_change_ids origin/master /tmp/check-merged.master
+
+cat /tmp/check-merged.branch | \
+while read COMMIT CHID ; do
+[ -n $CHID -a $CHID != ] grep -q $CHID
/tmp/check-merged.master || echo $COMMIT not in origin/master
+done
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Bug 75025 depends on bug 80939, which changed state. Bug 80939 Summary: Mac OS X: LibreOffice windows are pixelated on Retina displays https://bugs.freedesktop.org/show_bug.cgi?id=80939 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: bin/parse-perfcheck.py
bin/parse-perfcheck.py | 253 +
1 file changed, 109 insertions(+), 144 deletions(-)
New commits:
commit e8fbdb374a1f8c5f97dedb53922746d41699c39b
Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Date: Thu Nov 13 11:51:30 2014 +0100
Cleanup parse-perfcheck.py
Use more idiomatic python for file, path, csv handling and options
parsing.
There's still quite a bit of stuff to cleanup, at least it would be
nice to kill the remaining globals.
Fixed indentation on parts i've touched, the rest of the file is
still a bit off.
Change-Id: I4214078c38a1e26cca17d09ebb9c0f53ba429ea9
Reviewed-on: https://gerrit.libreoffice.org/12405
Tested-by: Laurent Godard lgodard.li...@laposte.net
Reviewed-by: Laurent Godard lgodard.li...@laposte.net
diff --git a/bin/parse-perfcheck.py b/bin/parse-perfcheck.py
index ea74c04..71f248c 100755
--- a/bin/parse-perfcheck.py
+++ b/bin/parse-perfcheck.py
@@ -7,63 +7,39 @@
import sys
import os
+import getopt
+import csv
-parseTrigger = desc: Trigger: Client Request:
-parseTotal = totals:
-
-separator = os.path.sep
-
-lastCommitId =
-lastCommitDate =
-needsCsvHeader = True # needs header in csv file ? yes if new
colsResult = {}
allTests = []
-def processDirectory(rootDir):
-
- if needsCsvHeader:
-intermediateResult = lastCommit\tlastCommitDate\ttest filename\tdump
comment\tcount\n
- else:
- intermediateResult =
-
- for dirName, subdirList, fileList in os.walk(rootDir):
+def parseFile(dirname, filename, lastCommit):
-files = [ fi for fi in fileList if fi.startswith(callgrind.out.) ]
-for fname in files:
-found = parseFile(dirName, fname)
-if found != :
- intermediateResult += found
+ curTestComment, total = None, None
- return intermediateResult
+ path = os.path.join(dirname, filename)
-def parseFile(dirname, filename):
+ trigger = desc: Trigger: Client Request:
+ trigger_len = len(trigger)
+ totals = totals:
+ totals_len = len(totals)
- path = dirname + separator + filename
- callgrindFile = open(path,'r')
- lines = callgrindFile.readlines()
+ with open(path,'r') as callgrindFile:
+ lines = callgrindFile.readlines()
- curTestComment =
- total = 0
+ for line in lines:
+ if line.startswith(trigger):
+ curTestComment = line[trigger_len:].replace(\n,)
+ elif line.startswith(totals):
+ total = line[totals_len:].replace(\n,)
- for line in lines:
-if line.startswith(parseTrigger):
- curTestComment = line[len(parseTrigger):].replace(\n,)
-elif line.startswith(parseTotal):
- total = line[len(parseTotal):].replace(\n,)
+ if curTestComment is None or total is None:
+return None
- callgrindFile.close()
-
- if curTestComment == :
-return
-
- if total == 0: # should not occur, btw
-return
-
- dirs = dirname.split(separator)
- currentTest = dirs[-1:]
- testName = currentTest[0].replace(.test.core,)
+ testName = os.path.basename(dirname).replace(.test.core,)
+ lastCommitId, lastCommitDate = lastCommit
if lastCommitId not in colsResult:
colsResult[lastCommitId] = {}
colsResult[lastCommitId]['date'] = lastCommitDate
@@ -71,9 +47,22 @@ def parseFile(dirname, filename):
colsResult[lastCommitId]['values'][curTestComment] = total
- result = lastCommitId + \t + lastCommitDate + \t + testName + \t +
curTestComment + \t + total + \n
+ return [lastCommitId, lastCommitDate, testName, curTestComment, total]
+
+def processDirectory(rootDir, needsCsvHeader, lastCommit):
- return result
+results = []
+
+if needsCsvHeader:
+results.append([lastCommit, lastCommitDate, test filename, dump
comment, count])
+
+for dirName, subdirList, fileList in os.walk(rootDir):
+files = [f for f in fileList if f.startswith(callgrind.out.)]
+for fname in files:
+found = parseFile(dirName, fname, lastCommit)
+if found is not None:
+results.append(found)
+return results
def getLastCommitInfo():
@@ -90,7 +79,7 @@ def displayUsage():
usage =
-Parses the callgrind results of make percheck
+Parses the callgrind results of make perfcheck
Arguments :
@@ -108,91 +97,71 @@ Alerts, if any, are displayed in standard output
print(usage)
+class WrongArguments(Exception):
+pass
+
def analyzeArgs(args):
-isValid = True
+try:
+opts, args = getopt.getopt(args, 'x', [
+'csv-file=', 'source-directory=', 'alert-type=', 'alert-value=',
'help'])
+except getopt.GetoptError:
+raise WrongArguments
targetFileName = perfcheckResult.csv
sourceDirectory = ./workdir/CppunitTest
alertType =
alertValue = 10
-if --help in args:
- isValid = False
-
-if isValid:
-
- for arg in args[1:]:
-
-found = False
-
-if arg.startswith(--csv-file):
-
[Libreoffice-commits] core.git: basic/source
basic/source/comp/symtbl.cxx | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
New commits:
commit 9dacd849b6ba76bab36558ad9e5d5614cd9fa29e
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 14:18:51 2014 +
this is for detecting the type of a variable based on its name
which means legal input is any character which a variable can
start with
Change-Id: I0c2d13a92ba374f8020e86e90e8e5f18ce8a9c90
diff --git a/basic/source/comp/symtbl.cxx b/basic/source/comp/symtbl.cxx
index 594b1d3..99e02e3 100644
--- a/basic/source/comp/symtbl.cxx
+++ b/basic/source/comp/symtbl.cxx
@@ -318,6 +318,8 @@ void SbiSymDef::SetType( SbxDataType t )
{
if( t == SbxVARIANT pIn )
{
+//See if there have been any deftype statements to set the default type
+//of a variable based on its starting letter
sal_Unicode cu = aName[0];
if( cu 256 )
{
@@ -327,14 +329,9 @@ void SbiSymDef::SetType( SbxDataType t )
ch = 'Z';
}
int ch2 = toupper( ch );
-unsigned char c = (unsigned char)ch2;
-if( c 0 c 128 )
-{
-int nIndex = ch2 - 'A';
-assert(nIndex = 0 nIndex N_DEF_TYPES);
-if (nIndex = 0 nIndex N_DEF_TYPES)
-t = pIn-pParser-eDefTypes[nIndex];
-}
+int nIndex = ch2 - 'A';
+if (nIndex = 0 nIndex N_DEF_TYPES)
+t = pIn-pParser-eDefTypes[nIndex];
}
}
eType = t;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
Hi Bjoern, all On Fri, Nov 14, 2014 at 1:55 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Hi, On Thu, Nov 13, 2014 at 04:13:33PM +, Michael Meeks wrote: * QA (Robinson) There is a Bug Hunting Session for 4.4 coming up next week. If you did any bigger refactoring or other work that primarily can be assumed to affect a specific area of usecases, please add this to: https://wiki.documentfoundation.org/BugHunting_Session_4.4.0.0#What_to_test Maybe it would be easier if I add the test cases to MozTrap? there could be also a follow-up through the beta/rc/final. Cheers Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org Tel:+33683901545 Co-founder - Release coordinator The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/opengl vcl/source
vcl/opengl/gdiimpl.cxx |8
vcl/opengl/texture.cxx | 20 +---
vcl/opengl/x11/gdiimpl.cxx |2 ++
vcl/source/opengl/OpenGLContext.cxx |8
vcl/source/opengl/OpenGLHelper.cxx |9 +
5 files changed, 44 insertions(+), 3 deletions(-)
New commits:
commit e7f2088c9a194ccc8f888d393032316948f6981b
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 14 15:43:44 2014 +0100
opengl: Add many more CHECK_GL_ERROR()'s before returning from functions.
Change-Id: I63c147acf9a4013008b0f6d76867186f04ee57d5
diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index 09e80f8..dab78f3 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -120,6 +120,7 @@ void OpenGLSalGraphicsImpl::PostDraw()
glDisable( GL_SCISSOR_TEST );
if( mbUseStencil )
glDisable( GL_STENCIL_TEST );
+
CHECK_GL_ERROR();
}
@@ -144,6 +145,8 @@ void OpenGLSalGraphicsImpl::ImplSetClipBit( const
vcl::Region rClip, GLuint nMa
glColorMask( GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE );
glStencilMask( 0x00 );
glDisable( GL_STENCIL_TEST );
+
+CHECK_GL_ERROR();
}
bool OpenGLSalGraphicsImpl::setClipRegion( const vcl::Region rClip )
@@ -174,6 +177,7 @@ bool OpenGLSalGraphicsImpl::setClipRegion( const
vcl::Region rClip )
ImplSetClipBit( rClip, 0x01 );
}
+CHECK_GL_ERROR();
return true;
}
@@ -301,6 +305,7 @@ bool OpenGLSalGraphicsImpl::CheckOffscreenTexture()
glViewport( 0, 0, GetWidth(), GetHeight() );
DrawTexture( maOffscreenTex, aPosAry );
+CHECK_GL_ERROR();
return true;
}
@@ -679,6 +684,8 @@ void OpenGLSalGraphicsImpl::DrawAlphaTexture(
OpenGLTexture rTexture, const Sal
glBlendFunc( GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA );
DrawTexture( rTexture, rPosAry, bInverted );
glDisable( GL_BLEND );
+
+CHECK_GL_ERROR();
}
void OpenGLSalGraphicsImpl::DrawTextureWithMask( OpenGLTexture rTexture,
OpenGLTexture rMask, const SalTwoRect pPosAry )
@@ -831,6 +838,7 @@ void OpenGLSalGraphicsImpl::DrawAxialGradient( const
Gradient rGradient, const
glDisableVertexAttribArray( GL_ATTRIB_TEX );
glUseProgram( 0 );
+
CHECK_GL_ERROR();
}
diff --git a/vcl/opengl/texture.cxx b/vcl/opengl/texture.cxx
index 005fb66..5c2f3c1 100644
--- a/vcl/opengl/texture.cxx
+++ b/vcl/opengl/texture.cxx
@@ -40,6 +40,8 @@ ImplOpenGLTexture::ImplOpenGLTexture( int nWidth, int
nHeight, bool bAllocate )
if( bAllocate )
glTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, nWidth, nHeight, 0, GL_RGBA,
GL_UNSIGNED_BYTE, NULL );
glBindTexture( GL_TEXTURE_2D, 0 );
+
+CHECK_GL_ERROR();
}
// texture with content retrieved from FBO
@@ -59,6 +61,7 @@ ImplOpenGLTexture::ImplOpenGLTexture( int nX, int nY, int
nWidth, int nHeight )
glCopyTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, nX, nY, nWidth, nHeight, 0 );
CHECK_GL_ERROR();
glBindTexture( GL_TEXTURE_2D, 0 );
+
CHECK_GL_ERROR();
}
@@ -80,6 +83,8 @@ ImplOpenGLTexture::ImplOpenGLTexture( int nWidth, int
nHeight, int nFormat, int
glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST );
glTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, mnWidth, mnHeight, 0, nFormat,
nType, pData );
glBindTexture( GL_TEXTURE_2D, 0 );
+
+CHECK_GL_ERROR();
}
ImplOpenGLTexture::~ImplOpenGLTexture()
@@ -87,6 +92,8 @@ ImplOpenGLTexture::~ImplOpenGLTexture()
SAL_INFO( vcl.opengl, ~OpenGLTexture mnTexture );
if( mnTexture != 0 )
glDeleteTextures( 1, mnTexture );
+
+CHECK_GL_ERROR();
}
OpenGLTexture::OpenGLTexture() :
@@ -198,18 +205,24 @@ void OpenGLTexture::SetFilter( GLenum nFilter )
glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, nFilter );
glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, nFilter );
}
+
+CHECK_GL_ERROR();
}
void OpenGLTexture::Bind()
{
if( mpImpl )
glBindTexture( GL_TEXTURE_2D, mpImpl-mnTexture );
+
+CHECK_GL_ERROR();
}
void OpenGLTexture::Unbind()
{
if( mpImpl )
glBindTexture( GL_TEXTURE_2D, 0 );
+
+CHECK_GL_ERROR();
}
bool OpenGLTexture::Draw()
@@ -243,6 +256,7 @@ bool OpenGLTexture::Draw()
glDisableVertexAttribArray( 1 );
glBindTexture( GL_TEXTURE_2D, 0 );
+CHECK_GL_ERROR();
return true;
}
@@ -269,12 +283,12 @@ void OpenGLTexture::Read( GLenum nFormat, GLenum nType,
sal_uInt8* pData )
GLuint nFramebufferId;
glGenFramebuffers( 1, nFramebufferId );
glBindFramebuffer( GL_FRAMEBUFFER, nFramebufferId );
-CHECK_GL_ERROR();
+CHECK_GL_ERROR();
glFramebufferTexture2D( GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
GL_TEXTURE_2D, Id(), 0 );
-CHECK_GL_ERROR();
+CHECK_GL_ERROR();
glReadPixels( maRect.Left(), mpImpl-mnHeight - maRect.Top(),
GetWidth(), GetHeight(), nFormat, nType, pData );
-CHECK_GL_ERROR();
+CHECK_GL_ERROR();
[ANN] new internal jpeg needs nasm
Hi, I am working on replacing internal jpeg with jpeg-turbo. https://gerrit.libreoffice.org/#/c/12402/ Once it hits master, you will need to get nasm tool to build it. http://www.nasm.us/ Info about how to install it, is in our configure. I've avoided cmake by using our great gcc-wrappers. Thanks for that! It should be ready now, I've just not tested it on OS X. Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/perfwork5' - config_host.mk.in configure.ac download.lst external/jpeg RepositoryExternal.mk vcl/source
RepositoryExternal.mk|6 +- config_host.mk.in|1 configure.ac | 38 ++ download.lst |4 - external/jpeg/ExternalProject_jpeg.mk| 36 + external/jpeg/Module_jpeg.mk |4 - external/jpeg/StaticLibrary_jpeg.mk | 70 --- external/jpeg/UnpackedTarball_jpeg.mk|4 - external/jpeg/configs/jconfig.h | 66 - external/jpeg/jpeg.build.patch.1 | 58 ++ external/jpeg/patches/jpeg-8c-jmorecfg.patch | 18 -- vcl/source/filter/jpeg/transupp.c|3 - 12 files changed, 143 insertions(+), 165 deletions(-) New commits: commit d2735469ff15bea5595085a5e10192bf33e52e4e Author: Matúš Kukan matus.ku...@collabora.com Date: Thu Nov 13 11:16:50 2014 +0100 Replace internal jpeg with jpeg-turbo Unfortunately requires nasm - the netwide assembler - http://www.nasm.us/ Upstream libjpeg-turbo is meant to be built with CMake on Windows but thanks to our gcc-wrappers we are able to avoid that. Change-Id: Id87b7072a8acc2578c3abf7e82cb1499e5094dbf diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 911dab1..6b02fd5 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -451,10 +451,10 @@ $(call gb_LinkTarget_set_include,$(1),\ -I$(call gb_UnpackedTarball_get_dir,jpeg) \ $$(INCLUDE) \ ) - -$(call gb_LinkTarget_use_static_libraries,$(1),\ - jpeg \ +$(call gb_LinkTarget_add_libs,$(1),\ + $(call gb_UnpackedTarball_get_dir,jpeg)/.libs/libjpeg$(gb_StaticLibrary_PLAINEXT) \ ) +$(call gb_LinkTarget_use_external_project,$(1),jpeg) endef diff --git a/config_host.mk.in b/config_host.mk.in index 98dad1d..b2b3104e 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -411,6 +411,7 @@ export MWAW_CFLAGS=$(gb_SPACE)@MWAW_CFLAGS@ export MWAW_LIBS=$(gb_SPACE)@MWAW_LIBS@ export MYTHES_CFLAGS=$(gb_SPACE)@MYTHES_CFLAGS@ export MYTHES_LIBS=$(gb_SPACE)@MYTHES_LIBS@ +export NASM=@NASM@ export NEON_CFLAGS=$(gb_SPACE)@NEON_CFLAGS@ export NEON_LIBS=$(gb_SPACE)@NEON_LIBS@ export NEON_VERSION=@NEON_VERSION@ diff --git a/configure.ac b/configure.ac index 26f7b79..8c4183f 100644 --- a/configure.ac +++ b/configure.ac @@ -7363,7 +7363,45 @@ else AC_MSG_RESULT([internal]) SYSTEM_JPEG= BUILD_TYPE=$BUILD_TYPE JPEG +AC_CHECK_PROGS(NASM, [nasm nasmw yasm]) +if test -z $NASM -a $build_os = cygwin -a -x /opt/lo/bin/nasm; then +NASM=/opt/lo/bin/nasm +fi +if test -z $NASM; then +cat _EOS + +You need nasm (Netwide Assembler) to build internal jpeg library. +To get one please do: + +_EOS +if test $build_os = cygwin; then +cat _EOS +install a pre-compiled binary for Win32 + + mkdir -p /opt/lo/bin + cd /opt/lo/bin + wget http://dev-www.libreoffice.org/bin/cygwin/nasm.exe + chmod +x nasm +_EOS +else +cat _EOS +consult http://svn.code.sf.net/p/libjpeg-turbo/code/trunk/BUILDING.txt +_EOS +fi +cat _EOS + +or get and install one from http://www.nasm.us/ + +Then re-run autogen.sh + +Note: autogen.sh will try to use /opt/lo/bin/nasm if the environment variable NASM is not already defined. +Alternatively, you can install the 'new' nasm where ever you want and make sure that \`which nasm\` finds it. + +_EOS +AC_MSG_ERROR([no nasm (Netwide Assembler) found]) +fi fi +AC_SUBST(NASM) AC_SUBST(SYSTEM_JPEG) diff --git a/download.lst b/download.lst index 13e26e0..b5f9749 100644 --- a/download.lst +++ b/download.lst @@ -77,8 +77,8 @@ export JFREEREPORT_LIBREPOSITORY_TARBALL := 8ce2fcd72becf06c41f7201d15373ed9-lib export JFREEREPORT_LIBSERIALIZER_TARBALL := f94d9870737518e3b597f9265f4e9803-libserializer-1.1.6.zip export JFREEREPORT_LIBXML_TARBALL := ace6ab49184e329db254e454a010f56d-libxml-1.1.7.zip export JFREEREPORT_SAC_TARBALL := 39bb3fcea1514f1369fcfc87542390fd-sacjava-1.3.zip -export JPEG_MD5SUM := 3353992aecaee1805ef4109aadd433e7 -export JPEG_TARBALL := jpegsrc.v9a.tar.gz +export JPEG_MD5SUM := 2c3a68129dac443a72815ff5bb374b05 +export JPEG_TARBALL := libjpeg-turbo-1.3.1.tar.gz export LANGTAGREG_MD5SUM := 49c94710f7858b1969d74ff72e6aac84 export LANGTAGREG_TARBALL := language-subtag-registry-2014-04-10.tar.bz2 export LANGUAGETOOL_TARBALL := b63e6340a02ff1cacfeadb2c42286161-JLanguageTool-1.7.0.tar.bz2 diff --git a/external/jpeg/ExternalProject_jpeg.mk b/external/jpeg/ExternalProject_jpeg.mk new file mode 100644 index 000..e47fb14 --- /dev/null +++ b/external/jpeg/ExternalProject_jpeg.mk @@ -0,0 +1,36 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +#
[Libreoffice-commits] core.git: cppu/source
cppu/source/threadpool/thread.cxx | 20
cppu/source/threadpool/thread.hxx |2 +-
cppu/source/threadpool/threadpool.cxx | 29 ++---
cppu/source/threadpool/threadpool.hxx |6 +++---
4 files changed, 26 insertions(+), 31 deletions(-)
New commits:
commit b021fdfab3a0985ba1f5380f378bf8ab97383aed
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Nov 14 16:05:37 2014 +0100
cid#983623 Don't throw DisposedException past uno_threadpool_putJob
This improves on b68640c44ecdb1df59d704cc6c2bae8bb412d7d0 Prevent creation
of
new ORequestThreads during shutdown, which added throwing the
DisposedException
from ThreadAdmin::add. But ThreadAdmin::m_disposed can only become true via
uno_threadpool_destroy - ThreadPool::joinWorkers - ThreadAdmin::join, and
ThreadAdmin::add observing that can only happen via uno_threadpool_putJob -
ThreadPool::addJob - ThreadPool::createThread - ORequestThread::launch -
ThradAdmin::add, where the bridges should ensure that uno_threadpool_destroy
does not run in parallel with uno_threadpool_putJob. So demote this from a
DisposedException to a SAL_WARN.
Change-Id: I3912ea077b7fa35827c41e82dd0a8f962ba412b6
diff --git a/cppu/source/threadpool/thread.cxx
b/cppu/source/threadpool/thread.cxx
index aed1322..724da75 100644
--- a/cppu/source/threadpool/thread.cxx
+++ b/cppu/source/threadpool/thread.cxx
@@ -21,12 +21,6 @@
#include osl/diagnose.h
#include uno/threadpool.h
-#include com/sun/star/lang/DisposedException.hpp
-#include com/sun/star/uno/Reference.hxx
-#include com/sun/star/uno/XInterface.hpp
-#include rtl/ustring.h
-#include rtl/ustring.hxx
-
#include thread.hxx
#include jobqueue.hxx
#include threadpool.hxx
@@ -49,16 +43,15 @@ namespace cppu_threadpool {
#endif
}
-void ThreadAdmin::add( rtl::Reference ORequestThread const p )
+bool ThreadAdmin::add( rtl::Reference ORequestThread const p )
{
MutexGuard aGuard( m_mutex );
if( m_disposed )
{
-throw css::lang::DisposedException(
-cppu_threadpool::ORequestThread created after
- cppu_threadpool::ThreadAdmin has been disposed);
+return false;
}
m_lst.push_back( p );
+return true;
}
void ThreadAdmin::remove_locked( rtl::Reference ORequestThread const
p )
@@ -120,14 +113,16 @@ namespace cppu_threadpool {
m_bAsynchron = bAsynchron;
}
-void ORequestThread::launch()
+bool ORequestThread::launch()
{
// Assumption is that osl::Thread::create returns normally with a true
// return value iff it causes osl::Thread::run to start executing:
acquire();
ThreadAdmin rThreadAdmin = m_aThreadPool-getThreadAdmin();
osl::ClearableMutexGuard g(rThreadAdmin.m_mutex);
-rThreadAdmin.add( this );
+if (!rThreadAdmin.add( this )) {
+return false;
+}
try {
if (!create()) {
throw std::runtime_error(osl::Thread::create failed);
@@ -138,6 +133,7 @@ namespace cppu_threadpool {
release();
throw;
}
+return true;
}
void ORequestThread::onTerminated()
diff --git a/cppu/source/threadpool/thread.hxx
b/cppu/source/threadpool/thread.hxx
index cc66975..2b7aa96 100644
--- a/cppu/source/threadpool/thread.hxx
+++ b/cppu/source/threadpool/thread.hxx
@@ -45,7 +45,7 @@ namespace cppu_threadpool {
void setTask( JobQueue * , const ::rtl::ByteSequence aThreadId ,
bool bAsynchron );
-void launch();
+bool launch();
static inline void * operator new(std::size_t size)
{ return SimpleReferenceObject::operator new(size); }
diff --git a/cppu/source/threadpool/threadpool.cxx
b/cppu/source/threadpool/threadpool.cxx
index c54b539..f41213b 100644
--- a/cppu/source/threadpool/threadpool.cxx
+++ b/cppu/source/threadpool/threadpool.cxx
@@ -27,6 +27,7 @@
#include osl/mutex.hxx
#include osl/thread.h
#include rtl/instance.hxx
+#include sal/log.hxx
#include uno/threadpool.h
@@ -190,11 +191,10 @@ namespace cppu_threadpool
m_aThreadAdmin.join();
}
-void ThreadPool::createThread( JobQueue *pQueue ,
+bool ThreadPool::createThread( JobQueue *pQueue ,
const ByteSequence aThreadId,
bool bAsynchron )
{
-bool bCreate = true;
{
// Can a thread be reused ?
MutexGuard guard( m_mutexWaitingThreadList );
@@ -210,16 +210,13 @@ namespace cppu_threadpool
// let the thread go
osl_setCondition( pWaitingThread-condition );
-bCreate = false;
+return true;
}
}
-if( bCreate )
-{
-rtl::Reference ORequestThread pThread(
[Libreoffice-commits] core.git: Branch 'feature/priorities' - cui/source extensions/source sw/source
cui/source/dialogs/cuigaldlg.cxx | 12 ++--
cui/source/dialogs/thesdlg.cxx|8
cui/source/inc/cuigaldlg.hxx |2 +-
cui/source/inc/thesdlg.hxx|2 +-
cui/source/tabpages/backgrnd.cxx | 26 +-
cui/source/tabpages/chardlg.cxx |8
extensions/source/bibliography/bibcont.cxx|6 +++---
extensions/source/bibliography/bibcont.hxx|2 +-
extensions/source/bibliography/toolbar.cxx|6 +++---
extensions/source/bibliography/toolbar.hxx|2 +-
extensions/source/update/ui/updatecheckui.cxx | 12 ++--
sw/source/uibase/docvw/edtwin.cxx |8
sw/source/uibase/inc/edtwin.hxx |2 +-
13 files changed, 48 insertions(+), 48 deletions(-)
New commits:
commit 5ee62de1e4fa55a45f49bbb0cfe81dd07111ba51
Author: Tobias Madl tobias.madl@gmail.com
Date: Fri Nov 14 15:31:13 2014 +
changed timers to idles
Change-Id: I223026ce7676a3f8fcda7eb33326cd4ee949c6f0
diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx
index e06c973..ddb379a 100644
--- a/cui/source/dialogs/cuigaldlg.cxx
+++ b/cui/source/dialogs/cuigaldlg.cxx
@@ -435,7 +435,7 @@ void TakeProgress::StartExecuteModal( const Link
rEndDialogHdl )
ActualizeProgress::ActualizeProgress(vcl::Window* pWindow, GalleryTheme* pThm)
: ModalDialog(pWindow, GalleryUpdateProgress,
cui/ui/galleryupdateprogress.ui)
-, pTimer(NULL)
+, pIdle(NULL)
, pTheme(pThm)
{
get(m_pFtActualizeFile, file);
@@ -447,13 +447,13 @@ short ActualizeProgress::Execute()
{
short nRet;
-pTimer = new Timer;
+pIdle = new Idle;
-if ( pTimer )
+if ( pIdle )
{
-pTimer-SetTimeoutHdl( LINK( this, ActualizeProgress, TimeoutHdl ) );
-pTimer-SetTimeout( 500 );
-pTimer-Start();
+pIdle-SetIdleHdl( LINK( this, ActualizeProgress, TimeoutHdl ) );
+pIdle-SetPriority( VCL_IDLE_PRIORITY_LOWEST );
+pIdle-Start();
}
nRet = ModalDialog::Execute();
diff --git a/cui/source/dialogs/thesdlg.cxx b/cui/source/dialogs/thesdlg.cxx
index 03f587b..79c4d9e 100644
--- a/cui/source/dialogs/thesdlg.cxx
+++ b/cui/source/dialogs/thesdlg.cxx
@@ -60,8 +60,8 @@ LookUpComboBox::LookUpComboBox(vcl::Window *pParent)
{
EnableAutoSize(true);
-m_aModifyTimer.SetTimeoutHdl( LINK( this, LookUpComboBox, ModifyTimer_Hdl
) );
-m_aModifyTimer.SetTimeout( 500 );
+m_aModifyIdle.SetIdleHdl( LINK( this, LookUpComboBox, ModifyTimer_Hdl ) );
+m_aModifyIdle.SetPriority( VCL_IDLE_PRIORITY_LOWEST );
EnableAutocomplete( false );
}
@@ -82,13 +82,13 @@ LookUpComboBox::~LookUpComboBox()
void LookUpComboBox::Modify()
{
-m_aModifyTimer.Start();
+m_aModifyIdle.Start();
}
IMPL_LINK( LookUpComboBox, ModifyTimer_Hdl, Timer *, EMPTYARG /*pTimer*/ )
{
m_pDialog-LookUp( GetText() );
-m_aModifyTimer.Stop();
+m_aModifyIdle.Stop();
return 0;
}
diff --git a/cui/source/inc/cuigaldlg.hxx b/cui/source/inc/cuigaldlg.hxx
index 83f234f..ed98621 100644
--- a/cui/source/inc/cuigaldlg.hxx
+++ b/cui/source/inc/cuigaldlg.hxx
@@ -150,7 +150,7 @@ class ActualizeProgress : public ModalDialog
private:
FixedText* m_pFtActualizeFile;
CancelButton* m_pBtnCancel;
-Timer* pTimer;
+Idle* pIdle;
GalleryTheme* pTheme;
GalleryProgress aStatusProgress;
diff --git a/cui/source/inc/thesdlg.hxx b/cui/source/inc/thesdlg.hxx
index 95e712c..729fb8f 100644
--- a/cui/source/inc/thesdlg.hxx
+++ b/cui/source/inc/thesdlg.hxx
@@ -33,7 +33,7 @@ class SvxThesaurusDialog;
class LookUpComboBox : public ComboBox
{
-Timer m_aModifyTimer;
+Idlem_aModifyIdle;
Selection m_aSelection;
SvxThesaurusDialog* m_pDialog;
diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index 8cb9a4a..03fc1a7 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -106,11 +106,11 @@ struct SvxBackgroundPara_Impl
struct SvxBackgroundPage_Impl
{
-Timer* pLoadTimer;
+Idle* pLoadIdle;
boolbIsImportDlgInExecute;
SvxBackgroundPage_Impl()
-: pLoadTimer(NULL)
+: pLoadIdle(NULL)
, bIsImportDlgInExecute(false)
{}
};
@@ -421,7 +421,7 @@ SvxBackgroundTabPage::SvxBackgroundTabPage(vcl::Window*
pParent, const SfxItemSe
SvxBackgroundTabPage::~SvxBackgroundTabPage()
{
-delete pPageImpl-pLoadTimer;
+delete pPageImpl-pLoadIdle;
delete pPageImpl;
delete pImportDlg;
@@ -719,10 +719,10 @@ void SvxBackgroundTabPage::FillUserData()
bool SvxBackgroundTabPage::FillItemSet( SfxItemSet* rCoreSet )
{
-if ( pPageImpl-pLoadTimer pPageImpl-pLoadTimer-IsActive() )
+
Re: [ANN] new internal jpeg needs nasm
On Fri, Nov 14, 2014 at 8:47 AM, Matúš Kukan matus.ku...@collabora.com wrote: Hi, I am working on replacing internal jpeg with jpeg-turbo. https://gerrit.libreoffice.org/#/c/12402/ Once it hits master, you will need to get nasm tool to build it. http://www.nasm.us/ Info about how to install it, is in our configure. I've avoided cmake by using our great gcc-wrappers. Thanks for that! It should be ready now, I've just not tested it on OS X. on mac we need -f macho64 not -f macho I think that is why the buildbot fails on mac other than that nasm seems to be installed by default Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/app/saldisp.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit 37800290245fd0462295a8bbaabd9d761929fa65
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 14 17:04:25 2014 +0100
vcl: Stop-gap solution to start the gen / kde / kde4 plugins again.
Change-Id: Ie538049aa8c4c0812d28b5c1bf91425822c55617
diff --git a/vcl/unx/generic/app/saldisp.cxx b/vcl/unx/generic/app/saldisp.cxx
index d3aca4f..ffd12d7 100644
--- a/vcl/unx/generic/app/saldisp.cxx
+++ b/vcl/unx/generic/app/saldisp.cxx
@@ -73,6 +73,7 @@
#include poll.h
#include boost/scoped_array.hpp
+#include com/sun/star/uno/DeploymentException.hpp
#include officecfg/Office/Common.hxx
using namespace vcl_sal;
@@ -191,9 +192,15 @@ bool SalDisplay::BestVisual( Display *pDisplay,
if( nVID sal_GetVisualInfo( pDisplay, nVID, rVI ) )
return rVI.visualid == nDefVID;
-bool bUseOpenGL = officecfg::Office::Common::VCL::UseOpenGL::get();
-if( bUseOpenGL OpenGLHelper::GetVisualInfo( pDisplay, nScreen, rVI ) )
-return rVI.visualid == nDefVID;
+try {
+bool bUseOpenGL = officecfg::Office::Common::VCL::UseOpenGL::get();
+if( bUseOpenGL OpenGLHelper::GetVisualInfo( pDisplay, nScreen, rVI
) )
+return rVI.visualid == nDefVID;
+}
+catch (const css::uno::DeploymentException)
+{
+// too early to try to access configmgr
+}
XVisualInfo aVI;
aVI.screen = nScreen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [ANN] new internal jpeg needs nasm
On Fri, Nov 14, 2014 at 8:47 AM, Matúš Kukan matus.ku...@collabora.com wrote: Hi, I am working on replacing internal jpeg with jpeg-turbo. https://gerrit.libreoffice.org/#/c/12402/ Once it hits master, you will need to get nasm tool to build it. http://www.nasm.us/ Info about how to install it, is in our configure. I've avoided cmake by using our great gcc-wrappers. Thanks for that! It should be ready now, I've just not tested it on OS X. lode now handle the nasm dependency... so the Windows jenins-buildbot now have it, so the gerrit future gerrit tet build will go further than autogen.sh :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sax/Library_expwrap.mk sax/source sw/qa
sax/Library_expwrap.mk|1 sax/source/fastparser/fastparser.cxx | 315 -- sw/qa/extras/ooxmlexport/ooxmlexport4.cxx |1 3 files changed, 138 insertions(+), 179 deletions(-) New commits: commit 82d08580e368afbc9d73da3613845a36a89b0a8c Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Fri Nov 14 17:13:41 2014 +0100 switch saxparser from expat to libxml2 Using SAX2 interface provides element/attribute names split into prefix/name, and provides namespaces/urls, so FastSaxParserImpl::callbackStartElement() does not have to figure out these on its own (and additionally libxml2 spends a noticeable portion in xmlStrdup() when not in SAX2 mode). The switch saves about 5-10% time. Change-Id: Idd424d7cc9b30c248179a5bad8ec79dbfc62e765 diff --git a/sax/Library_expwrap.mk b/sax/Library_expwrap.mk index ef749a2..0c44d30 100644 --- a/sax/Library_expwrap.mk +++ b/sax/Library_expwrap.mk @@ -24,6 +24,7 @@ $(eval $(call gb_Library_use_sdk_api,expwrap)) $(eval $(call gb_Library_use_externals,expwrap,\ boost_headers \ + libxml2 \ expat \ zlib \ )) diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx index 5c78713..8d5dad2 100644 --- a/sax/source/fastparser/fastparser.cxx +++ b/sax/source/fastparser/fastparser.cxx @@ -44,7 +44,10 @@ #include queue #include cassert #include cstring -#include expat.h +#include libxml/parser.h + +// Inverse of libxml's BAD_CAST. +#define XML_CAST( str ) reinterpret_cast const sal_Char* ( str ) using namespace ::std; using namespace ::osl; @@ -159,7 +162,7 @@ struct Entity : public ParserData // Allow to disable threading for small documents: boolmbEnableThreads; ::com::sun::star::xml::sax::InputSource maStructSource; -XML_Parser mpParser; +xmlParserCtxtPtrmpParser; ::sax_expatwrap::XMLFile2UTFConverter maConverter; // Exceptions cannot be thrown through the C-XmlParser (possible @@ -210,14 +213,17 @@ public: void setLocale( const ::com::sun::star::lang::Locale rLocale ) throw (::com::sun::star::uno::RuntimeException); // called by the C callbacks of the expat parser -void callbackStartElement( const XML_Char* name, const XML_Char** atts ); -void callbackEndElement( const XML_Char* name ); -void callbackCharacters( const XML_Char* s, int nLen ); -bool callbackExternalEntityRef( XML_Parser parser, const XML_Char *openEntityNames, const XML_Char *base, const XML_Char *systemId, const XML_Char *publicId); -void callbackEntityDecl(const XML_Char *entityName, int is_parameter_entity, -const XML_Char *value, int value_length, const XML_Char *base, -const XML_Char *systemId, const XML_Char *publicId, -const XML_Char *notationName); +void callbackStartElement( const xmlChar *localName , const xmlChar* prefix, const xmlChar* URI, +int numNamespaces, const xmlChar** namespaces, int numAttributes, int defaultedAttributes, const xmlChar **attributes ); +void callbackEndElement( const xmlChar* localName, const xmlChar* prefix, const xmlChar* URI ); +void callbackCharacters( const xmlChar* s, int nLen ); +#if 0 +bool callbackExternalEntityRef( XML_Parser parser, const xmlChar *openEntityNames, const xmlChar *base, const xmlChar *systemId, const xmlChar *publicId); +void callbackEntityDecl(const xmlChar *entityName, int is_parameter_entity, +const xmlChar *value, int value_length, const xmlChar *base, +const xmlChar *systemId, const xmlChar *publicId, +const xmlChar *notationName); +#endif void pushEntity( const Entity rEntity ); void popEntity(); @@ -232,19 +238,17 @@ private: bool consume(EventList *); void deleteUsedEvents(); -sal_Int32 GetToken( const sal_Char* pToken, sal_Int32 nTokenLen = 0 ); -sal_Int32 GetTokenWithPrefix( const sal_Char*pPrefix, int nPrefixLen, const sal_Char* pName, int nNameLen ) throw (::com::sun::star::xml::sax::SAXException); +sal_Int32 GetToken( const xmlChar* pName, sal_Int32 nameLen ); +sal_Int32 GetTokenWithPrefix( const xmlChar* pPrefix, int prefixLen, const xmlChar* pName, int nameLen ) throw (::com::sun::star::xml::sax::SAXException); OUString GetNamespaceURL( const OString rPrefix ) throw (::com::sun::star::xml::sax::SAXException); -OUString GetNamespaceURL( const sal_Char*pPrefix, int nPrefixLen ) throw (::com::sun::star::xml::sax::SAXException); sal_Int32 GetNamespaceToken( const OUString rNamespaceURL ); -sal_Int32 GetTokenWithContextNamespace( sal_Int32 nNamespaceToken, const sal_Char* pName, int nNameLen ); -void DefineNamespace( const OString rPrefix, const sal_Char* pNamespaceURL ); - -void splitName( const XML_Char *pwName, const XML_Char *rpPrefix,
[Libreoffice-commits] core.git: 5 commits - comphelper/qa officecfg/registry sc/source sc/uiconfig
comphelper/qa/string/test_string.cxx |4 +
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |2
sc/source/core/tool/calcconfig.cxx |1
sc/source/ui/optdlg/calcoptionsdlg.cxx | 39 ++-
sc/source/ui/optdlg/calcoptionsdlg.hxx |3 -
sc/uiconfig/scalc/ui/formulacalculationoptions.ui| 15 -
6 files changed, 46 insertions(+), 18 deletions(-)
New commits:
commit 5c4a9b1e2adf62a5805c02b20bfbcd62b3533e6d
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 14 18:23:25 2014 +0200
Handle the 'New' and 'Delete' buttons
Change-Id: I1d5d6d70e9ac8d95b1189346fdab29ded39745bf
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index 6492b1a..4aafd8c 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -225,6 +225,9 @@ ScCalcOptionsDialog::ScCalcOptionsDialog(vcl::Window*
pParent, const ScCalcConfi
aLink = LINK(this, ScCalcOptionsDialog, OpenCLWhiteAndBlackListSelHdl);
mpOpenCLWhiteAndBlackListBox-SetSelectHdl(aLink);
+mpListNewButton-SetClickHdl(LINK(this, ScCalcOptionsDialog,
ListNewClickHdl));
+mpListDeleteButton-SetClickHdl(LINK(this, ScCalcOptionsDialog,
ListDeleteClickHdl));
+
aLink = LINK(this, ScCalcOptionsDialog, BtnToggleHdl);
mpBtnTrue-SetToggleHdl(aLink); // Set handler only to the 'True' button.
@@ -913,4 +916,39 @@ IMPL_LINK(ScCalcOptionsDialog,
OpenCLWhiteAndBlackListSelHdl, Control*, )
return 0;
}
+IMPL_LINK( ScCalcOptionsDialog, ListNewClickHdl, PushButton*, )
+{
+ScCalcConfig::OpenCLImplMatcher aEmpty;
+ScCalcConfig::OpenCLImplMatcherSet rSet(CurrentWhiteOrBlackList());
+
+mpOS-SetText();
+mpOSVersion-SetText();
+mpPlatformVendor-SetText();
+mpDevice-SetText();
+mpDriverVersionMin-SetText();
+mpDriverVersionMax-SetText();
+
+rSet.insert(aEmpty);
+#if HAVE_FEATURE_OPENCL
+fillListBox(mpOpenCLWhiteAndBlackListBox, rSet);
+mpOpenCLWhiteAndBlackListBox-SelectEntry(format(aEmpty));
+#endif
+return 0;
+}
+
+IMPL_LINK( ScCalcOptionsDialog, ListDeleteClickHdl, PushButton*, )
+{
+if (mpOpenCLWhiteAndBlackListBox-GetSelectEntryPos() ==
LISTBOX_ENTRY_NOTFOUND)
+return 0;
+
+ScCalcConfig::OpenCLImplMatcherSet rSet(CurrentWhiteOrBlackList());
+const ScCalcConfig::OpenCLImplMatcher
rImpl(CurrentWhiteOrBlackListEntry());
+
+#if HAVE_FEATURE_OPENCL
+rSet.erase(rImpl);
+fillListBox(mpOpenCLWhiteAndBlackListBox, rSet);
+#endif
+return 0;
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.hxx
b/sc/source/ui/optdlg/calcoptionsdlg.hxx
index 25d397d..32e7f42 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.hxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.hxx
@@ -41,6 +41,8 @@ public:
DECL_LINK( NumModifiedHdl, void * );
DECL_LINK( EditModifiedHdl, Control * );
DECL_LINK( OpenCLWhiteAndBlackListSelHdl, Control* );
+DECL_LINK( ListNewClickHdl, PushButton* );
+DECL_LINK( ListDeleteClickHdl, PushButton* );
const ScCalcConfig GetConfig() const { return maConfig;}
commit f9da47eb6a9affb7bb42eafe6637b8059a3b0015
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 14 15:05:49 2014 +0200
Use right mnemonic_widget id
Change-Id: Ia5be89f17d8e63ad67a8d1dc811927dcdebbc0a9
diff --git a/sc/uiconfig/scalc/ui/formulacalculationoptions.ui
b/sc/uiconfig/scalc/ui/formulacalculationoptions.ui
index bb0f02e..0a806b0 100644
--- a/sc/uiconfig/scalc/ui/formulacalculationoptions.ui
+++ b/sc/uiconfig/scalc/ui/formulacalculationoptions.ui
@@ -261,7 +261,7 @@
property name=can_focusFalse/property
property name=xalign0/property
property name=label
translatable=yesOpenCL Platform Vendor/property
-property
name=mnemonic_widgetopenclvendor:border/property
+property
name=mnemonic_widgetplatformvendor:border/property
/object
packing
property name=left_attach0/property
commit f378711cf1da924a92fd48bc11207a89f0d98e04
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 14 14:11:25 2014 +0200
I don't know what I planned the 'Edit' button to do, drop it
Change-Id: I9944023d4cfd897acce8fd71296034ca32d8d136
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index f7a1397..6492b1a 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -151,7 +151,6 @@ ScCalcOptionsDialog::ScCalcOptionsDialog(vcl::Window*
pParent, const ScCalcConfi
get(mpDevice, opencldevice);
get(mpDriverVersionMin, opencldriverversionmin);
Re: [Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
On Fri, Nov 14, 2014 at 03:42:16PM +0100, Sophie Gautier wrote: Maybe it would be easier if I add the test cases to MozTrap? there could be also a follow-up through the beta/rc/final. Thank you, that would be great! I was suggesting to just edit the wiki as telling hackers to enter stuff in MozTrap likely earns us just a few groans mumbling yet another login/account. Speaking of that: If people come forward during the ESC call with stuff done for 4.4 we should just put that in the minutes -- we can copy it over to the Wiki/MozTrap later. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 3 commits - vcl/workben
vcl/workben/vcldemo.cxx | 207 +---
1 file changed, 177 insertions(+), 30 deletions(-)
New commits:
commit 154c863593c7fc81480e59c43c713cbad2e42b51
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 14 14:54:24 2014 +
vcldemo: implement key-bindings and command-line
Change-Id: I98ea70a78f340a2050ef934de3111ba3191ff479
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index 7b4f692..6f6ae4b 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -69,14 +69,21 @@ class DemoWin : public DemoBase
struct RegionRenderer {
public:
virtual ~RegionRenderer() {}
+virtual OUString getName() = 0;
+virtual sal_uInt16 getAccelerator() = 0;
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) = 0;
+#define RENDER_DETAILS(name,key) \
+virtual OUString getName() SAL_OVERRIDE \
+{ return OUString(SAL_STRINGIFY(name)); } \
+virtual sal_uInt16 getAccelerator() SAL_OVERRIDE \
+{ return key; }
};
std::vector RegionRenderer * maRenderers;
sal_Int32 mnSelectedRenderer;
-void InitRenderers();
+void InitRenderers();
public:
DemoWin() : DemoBase()
@@ -108,6 +115,9 @@ public:
InitRenderers();
}
+OUString getRendererList();
+void selectRenderer(const OUString rName);
+
// Bouncing windows on click ...
PushButton *mpButton;
FloatingWindow *mpButtonWin;
@@ -116,6 +126,7 @@ public:
DECL_LINK(BounceTimerCb, void *);
virtual void MouseButtonDown(const MouseEvent rMEvt) SAL_OVERRIDE;
+virtual void KeyInput( const KeyEvent rKEvt ) SAL_OVERRIDE;
virtual void Paint(const Rectangle rRect) SAL_OVERRIDE
{
@@ -175,6 +186,7 @@ public:
struct DrawLines : public RegionRenderer
{
+RENDER_DETAILS(lines,KEY_L)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) SAL_OVERRIDE
{
@@ -261,6 +273,7 @@ public:
struct DrawText : public RegionRenderer
{
+RENDER_DETAILS(text,KEY_T)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext ) SAL_OVERRIDE
{
@@ -273,6 +286,7 @@ public:
struct DrawCheckered : public RegionRenderer
{
+RENDER_DETAILS(checks,KEY_C)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) SAL_OVERRIDE
{
@@ -333,6 +347,7 @@ public:
struct DrawPoly : public RegionRenderer
{
+RENDER_DETAILS(poly,KEY_P)
DrawCheckered maCheckered;
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) SAL_OVERRIDE
@@ -356,6 +371,7 @@ public:
struct DrawEllipse : public RegionRenderer
{
+RENDER_DETAILS(ellipse,KEY_E)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext ) SAL_OVERRIDE
{
@@ -367,6 +383,7 @@ public:
struct DrawGradient : public RegionRenderer
{
+RENDER_DETAILS(gradient,KEY_G)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) SAL_OVERRIDE
{
@@ -437,6 +454,7 @@ public:
struct DrawBitmap : public RegionRenderer
{
+RENDER_DETAILS(bitmap,KEY_B)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) SAL_OVERRIDE
{
@@ -448,6 +466,7 @@ public:
struct DrawBitmapEx : public RegionRenderer
{
+RENDER_DETAILS(bitmapex,KEY_X)
DrawCheckered maCheckered;
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext rCtx) SAL_OVERRIDE
@@ -465,6 +484,7 @@ public:
struct DrawPolyPolygons : public RegionRenderer
{
+RENDER_DETAILS(polypoly,KEY_N)
virtual void RenderRegion(OutputDevice rDev, Rectangle r,
const RenderContext ) SAL_OVERRIDE
{
@@ -515,6 +535,7 @@ public:
struct DrawToVirtualDevice : public RegionRenderer
{
+RENDER_DETAILS(vdev,KEY_V)
enum RenderType {
RENDER_AS_BITMAP,
RENDER_AS_OUTDEV,
@@ -581,6 +602,8 @@ public:
struct DrawIcons : public RegionRenderer
{
+RENDER_DETAILS(icons,KEY_I)
+
std::vectorOUString maIconNames;
std::vectorBitmapEx maIcons;
bool bHasLoadedAll;
@@ -712,6 +735,7 @@ public:
struct FetchDrawBitmap : public RegionRenderer
{
+RENDER_DETAILS(fetchdraw,KEY_F)
virtual void
[Libreoffice-commits] core.git: 2 commits - cppu/source vcl/generic
cppu/source/typelib/static_types.cxx |4 +---
vcl/generic/fontmanager/parseAFM.cxx | 21 +
2 files changed, 10 insertions(+), 15 deletions(-)
New commits:
commit 3d876661857b68cafde16fafd5f280cc78b3e52b
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 16:43:10 2014 +
coverity#704593 silence Dereference after null check
Change-Id: I3ccd6895a1ddbf46a441e60ceaaaceb945f682e4
diff --git a/cppu/source/typelib/static_types.cxx
b/cppu/source/typelib/static_types.cxx
index 13d2e85..fb99775 100644
--- a/cppu/source/typelib/static_types.cxx
+++ b/cppu/source/typelib/static_types.cxx
@@ -277,7 +277,6 @@ CPPU_DLLPUBLIC typelib_TypeDescriptionReference ** SAL_CALL
typelib_static_type_
return s_aTypes[eTypeClass];
}
-
CPPU_DLLPUBLIC void SAL_CALL typelib_static_type_init(
typelib_TypeDescriptionReference ** ppRef,
typelib_TypeClass eTypeClass, const sal_Char * pTypeName )
@@ -291,13 +290,12 @@ CPPU_DLLPUBLIC void SAL_CALL typelib_static_type_init(
OUString aTypeName( OUString::createFromAscii( pTypeName ) );
::typelib_typedescriptionreference_new( ppRef, eTypeClass,
aTypeName.pData );
-// another static ref:
+// coverity[var_deref_op] - another static ref
++((*ppRef)-nStaticRefCount);
}
}
}
-
CPPU_DLLPUBLIC void SAL_CALL typelib_static_sequence_type_init(
typelib_TypeDescriptionReference ** ppRef,
typelib_TypeDescriptionReference * pElementType )
commit 7d9b6119495bf1ca04cfe7b413cf165f347d0ec5
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 15:31:31 2014 +
coverity#706217 Time of check time of use
Change-Id: I762658a01e97f56b2f9362a38a0fefc941698d1b
diff --git a/vcl/generic/fontmanager/parseAFM.cxx
b/vcl/generic/fontmanager/parseAFM.cxx
index 24345d2..13cdca7 100644
--- a/vcl/generic/fontmanager/parseAFM.cxx
+++ b/vcl/generic/fontmanager/parseAFM.cxx
@@ -112,24 +112,21 @@ class FileInputStream
}
};
-FileInputStream::FileInputStream( const char* pFilename ) :
-m_pMemory( NULL ),
-m_nPos( 0 ),
-m_nLen( 0 )
+FileInputStream::FileInputStream(const char* pFilename)
+: m_pMemory(NULL)
+, m_nPos(0)
+, m_nLen(0)
{
-struct stat aStat;
-if( ! stat( pFilename, aStat )
-S_ISREG( aStat.st_mode )
-aStat.st_size 0
- )
+FILE* fp = fopen( pFilename, r );
+if( fp )
{
-FILE* fp = fopen( pFilename, r );
-if( fp )
+struct stat aStat;
+if (!fstat(fileno(fp), aStat) S_ISREG(aStat.st_mode)
aStat.st_size 0)
{
m_pMemory = (char*)rtl_allocateMemory( aStat.st_size );
m_nLen = (unsigned int)fread( m_pMemory, 1, aStat.st_size, fp );
-fclose( fp );
}
+fclose( fp );
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uiview/viewport.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit e170f0858721545d6b0e22d12cc1f5bbc6b2e57d
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 16:59:35 2014 +
coverity#1242518 Arguments in wrong order
doesn't actually matter, they are either the same number or one is 0
in which case it doesn't matter which is zero either
Change-Id: If53d4287dfd57b4ce29e2f7251eb523694730e77
diff --git a/sw/source/uibase/uiview/viewport.cxx
b/sw/source/uibase/uiview/viewport.cxx
index c7509b9..4280ad8 100644
--- a/sw/source/uibase/uiview/viewport.cxx
+++ b/sw/source/uibase/uiview/viewport.cxx
@@ -852,9 +852,9 @@ void ViewResizePixel( const vcl::Window rRef,
const long nVLinSzWidth = bVRuler ?
pVRuler-GetSizePixel().Width() : 0;
-long nScrollBarSize =
rRef.GetSettings().GetStyleSettings().GetScrollBarSize();
-long nHBSzHeight = rHScrollbar.IsVisible(true) ? nScrollBarSize : 0;
-long nVBSzWidth = rVScrollbar.IsVisible(true) ? nScrollBarSize : 0;
+const long nScrollBarSize =
rRef.GetSettings().GetStyleSettings().GetScrollBarSize();
+const long nHBSzHeight = rHScrollbar.IsVisible(true) ? nScrollBarSize : 0;
+const long nVBSzWidth = rVScrollbar.IsVisible(true) ? nScrollBarSize : 0;
if(pVRuler)
{
@@ -927,7 +927,7 @@ void ViewResizePixel( const vcl::Window rRef,
aScrollFillPos.X() = aPos.X();
}
-rScrollBarBox.SetPosSizePixel( aScrollFillPos, Size( nHBSzHeight,
nVBSzWidth) );
+rScrollBarBox.SetPosSizePixel(aScrollFillPos, Size(nVBSzWidth,
nHBSzHeight));
}
void SwView::ShowAtResize()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svtools/source
svtools/source/brwbox/datwin.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5a9b87fc0f4417c8437348b68cd6e4b6fd849e39 Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 14 17:11:26 2014 + coverity#1242527 Arguments in wrong order doesn't seem to matter too much, I guess its only the top left corner that really matters for tooltips. This is the vertical scrollbar as used in e.g. writer-view-datasources Change-Id: I5bd6e563a9f02edae9ca166f073556c55878826c diff --git a/svtools/source/brwbox/datwin.cxx b/svtools/source/brwbox/datwin.cxx index e4412fb..ebf6219 100644 --- a/svtools/source/brwbox/datwin.cxx +++ b/svtools/source/brwbox/datwin.cxx @@ -726,7 +726,7 @@ void BrowserScrollBar::Tracking( const TrackingEvent rTEvt ) else aTip += OUString::number(GetRangeMax()); -Rectangle aRect( GetPointerPosPixel(), Size( GetTextHeight(), GetTextWidth( aTip ) ) ); +Rectangle aRect(GetPointerPosPixel(), Size(GetTextWidth(aTip), GetTextHeight())); if ( _nTip ) Help::UpdateTip( _nTip, this, aRect, aTip ); else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
Hi Bjoern, On Fri, Nov 14, 2014 at 5:37 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Fri, Nov 14, 2014 at 03:42:16PM +0100, Sophie Gautier wrote: Maybe it would be easier if I add the test cases to MozTrap? there could be also a follow-up through the beta/rc/final. Thank you, that would be great! I was suggesting to just edit the wiki as telling hackers to enter stuff in MozTrap likely earns us just a few groans mumbling yet another login/account. yes, no problem, I write the tests and upload them. Speaking of that: If people come forward during the ESC call with stuff done for 4.4 we should just put that in the minutes -- we can copy it over to the Wiki/MozTrap later. Just let the stuff in the minutes, I read them anyway and will ping the developer when I don't understand. Cheers Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org Tel:+33683901545 Co-founder - Release coordinator The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/viewer/mediawindow_impl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 7a71065b8715f09892ef643d6e75550782e116d4
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 17:17:50 2014 +
catch by reference
Change-Id: Ib1f04971dc89df6df09bd12595d3ddb148715e28
diff --git a/avmedia/source/viewer/mediawindow_impl.cxx
b/avmedia/source/viewer/mediawindow_impl.cxx
index 6fb869c..21bd7c5 100644
--- a/avmedia/source/viewer/mediawindow_impl.cxx
+++ b/avmedia/source/viewer/mediawindow_impl.cxx
@@ -541,7 +541,7 @@ void MediaWindowImpl::onURLChanged()
{
xPlayerWindow = mxPlayer-createPlayerWindow( aArgs );
}
-catch( uno::RuntimeException )
+catch( const uno::RuntimeException )
{
// happens eg, on MacOSX where Java frames cannot be created from
X11 window handles
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source svx/source xmloff/source
sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx |6 +++---
svx/source/fmcomp/dbaobjectex.cxx |2 +-
xmloff/source/text/txtfldi.cxx|2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 0b3766645d7d52d5c2022b1e8e4617eff06403c8
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 14 17:21:20 2014 +
more catch by reference
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
diff --git a/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
b/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
index 3cd301c..2621071 100644
--- a/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
+++ b/sd/source/ui/accessibility/AccessibleDrawDocumentView.cxx
@@ -979,12 +979,12 @@ uno::ReferenceXAccessible
AccessibleDrawDocumentView::GetSelAccContextInTable(
}
}
}
-catch ( lang::IndexOutOfBoundsException )
+catch (const lang::IndexOutOfBoundsException)
{
uno::ReferenceXAccessible xEmpty;
return xEmpty;
}
-catch ( uno::RuntimeException )
+catch (const uno::RuntimeException)
{
uno::ReferenceXAccessible xEmpty;
return xEmpty;
@@ -1014,7 +1014,7 @@ void AccessibleDrawDocumentView::UpdateAccessibleName
(void)
sNewName += OUString::number(nPageNumber);
}
}
-catch (beans::UnknownPropertyException)
+catch (const beans::UnknownPropertyException)
{
}
}
diff --git a/svx/source/fmcomp/dbaobjectex.cxx
b/svx/source/fmcomp/dbaobjectex.cxx
index c327c75..d43184e 100644
--- a/svx/source/fmcomp/dbaobjectex.cxx
+++ b/svx/source/fmcomp/dbaobjectex.cxx
@@ -80,7 +80,7 @@ namespace svx
if ( xProp.is() )
xProp-getPropertyValue(IsForm) = bForm;
}
-catch(Exception)
+catch(const Exception)
{}
AddFormat(getDescriptorFormatId(bForm));
}
diff --git a/xmloff/source/text/txtfldi.cxx b/xmloff/source/text/txtfldi.cxx
index b456ae6..93e1d81 100644
--- a/xmloff/source/text/txtfldi.cxx
+++ b/xmloff/source/text/txtfldi.cxx
@@ -3765,7 +3765,7 @@ void XMLAnnotationImportContext::EndElement()
{
GetImportHelper().InsertTextContent( xTextContent );
}
-catch (lang::IllegalArgumentException)
+catch (const lang::IllegalArgumentException)
{
// ignore
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/source
vcl/source/opengl/OpenGLContext.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 07802be53ba1582276c32876e2b5160e7927e225 Author: Jan Holesovsky ke...@collabora.com Date: Fri Nov 14 19:12:11 2014 +0100 windows opengl: Do not be _that_ eager with CHECK_GL_ERROR(). Turns out that when you call glGetError() and OpenGL is not yet set up (or already turned down), it leads to an error; so when we check for errors in a loop, we never recover from that ;-) Change-Id: I849ad1dc30fc93ee1c021b446d9ad379bf9987c0 diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index cbf2bf2..fbadeac 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -78,8 +78,6 @@ OpenGLContext::~OpenGLContext() glXDestroyGLXPixmap(m_aGLWin.dpy, m_aGLWin.glPix); } #endif - -CHECK_GL_ERROR(); } void OpenGLContext::requestLegacyContext() @@ -299,8 +297,7 @@ bool InitMultisample(PIXELFORMATDESCRIPTOR pfd, int rPixelFormat, ReleaseDC(hWnd, glWin.hDC); DestroyWindow(hWnd); -CHECK_GL_ERROR(); -return bArbMultisampleSupported; +return bArbMultisampleSupported; } #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/quartz vcl/source vcl/win
vcl/quartz/salgdicommon.cxx|6 ++
vcl/source/outdev/bitmap.cxx |8
vcl/win/source/gdi/gdiimpl.cxx | 11 ---
3 files changed, 10 insertions(+), 15 deletions(-)
New commits:
commit 0630ed73aa4c29447b10fdc509e693d1475b76a3
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 14 20:35:44 2014 +0100
vcl: The backend should decide whether fast alpha drawing is available.
The unx drawAlphaBitmap() already already checks that the source and
destination have the same size.
Windows and OpenGL should be able to handle that without trouble.
OS X would need some additional code, so added an early return for the case
the source and result sizes do not match.
Change-Id: Ib09654aaa9c9064c232cff5094fcaa1190e931c6
diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index ad15432..6a8d953 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -568,6 +568,12 @@ bool AquaSalGraphics::drawAlphaBitmap( const SalTwoRect
rTR,
{
DBG_DRAW_OPERATION(drawAlphaBitmap, true);
+if (rTR.mnSrcWidth != rTR.mnDestWidth || rTR.mnSrcHeight !=
rTR.mnDestHeight)
+{
+// TODO - would be better to scale it by the native code
+return false;
+}
+
// An image mask can't have a depth 8 bits (should be 1 to 8 bits)
if( rAlphaBmp.GetBitCount() 8 )
{
diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
index 9a2e56d..4b0583b 100644
--- a/vcl/source/outdev/bitmap.cxx
+++ b/vcl/source/outdev/bitmap.cxx
@@ -524,10 +524,10 @@ void OutputDevice::DrawDeviceBitmap( const Point
rDestPt, const Size rDestSize
if (bTryDirectPaint)
{
-// only paint direct when no scaling and no MapMode, else
the
+// only paint direct when no MapMode, else the
// more expensive conversions may be done for short-time
Bitmap/BitmapEx
// used for buffering only
-if (IsMapMode() || aPosAry.mnSrcWidth !=
aPosAry.mnDestWidth || aPosAry.mnSrcHeight != aPosAry.mnDestHeight)
+if (IsMapMode())
{
bTryDirectPaint = false;
}
@@ -663,10 +663,10 @@ void OutputDevice::DrawDeviceAlphaBitmap( const Bitmap
rBmp, const AlphaMask r
if (bTryDirectPaint)
{
-// only paint direct when no scaling and no MapMode, else the
+// only paint direct when no MapMode, else the
// more expensive conversions may be done for short-time
Bitmap/BitmapEx
// used for buffering only
-if (IsMapMode() || rSrcSizePixel.Width() != aOutSz.Width() ||
rSrcSizePixel.Height() != aOutSz.Height())
+if (IsMapMode())
{
bTryDirectPaint = false;
}
diff --git a/vcl/win/source/gdi/gdiimpl.cxx b/vcl/win/source/gdi/gdiimpl.cxx
index 7be39e6..48dd4b1 100644
--- a/vcl/win/source/gdi/gdiimpl.cxx
+++ b/vcl/win/source/gdi/gdiimpl.cxx
@@ -774,17 +774,6 @@ void WinSalGraphicsImpl::drawBitmap( const SalTwoRect
rPosAry,
DBG_ASSERT( !mrParent.isPrinter(), No transparency print possible! );
bool bTryDirectPaint(!mrParent.isPrinter() !mbXORMode);
-if(bTryDirectPaint)
-{
-// only paint direct when no scaling and no MapMode, else the
-// more expensive conversions may be done for short-time
Bitmap/BitmapEx
-// used for buffering only
-if(rPosAry.mnSrcWidth == rPosAry.mnDestWidth rPosAry.mnSrcHeight ==
rPosAry.mnDestHeight)
-{
-bTryDirectPaint = false;
-}
-}
-
// try to draw using GdiPlus directly
if(bTryDirectPaint drawAlphaBitmap(rPosAry, rSSalBitmap,
rSTransparentBitmap))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Bug 75025 depends on bug 79834, which changed state. Bug 79834 Summary: [FILEOPEN] SVG Insert-From File takes 2+ time longer in 4.3 https://bugs.freedesktop.org/show_bug.cgi?id=79834 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Bug 75025 depends on bug 80198, which changed state. Bug 80198 Summary: Insert SVG file breaks the program https://bugs.freedesktop.org/show_bug.cgi?id=80198 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/opengl
vcl/opengl/gdiimpl.cxx |2 -- vcl/opengl/texture.cxx |2 -- 2 files changed, 4 deletions(-) New commits: commit 4dd633a728f0f82de6a6aad9470ffe7ab9bb49e9 Author: Jan Holesovsky ke...@collabora.com Date: Fri Nov 14 21:41:15 2014 +0100 opengl: Another places where it is too eager to check for errors. Change-Id: Ib6ca3d653f3fd1155bce418226146934e765928d diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index dab78f3..e630bf9 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -1505,8 +1505,6 @@ void OpenGLSalGraphicsImpl::endPaint() maContext.makeCurrent(); glFlush(); } - -CHECK_GL_ERROR(); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/opengl/texture.cxx b/vcl/opengl/texture.cxx index 5c2f3c1..938de54 100644 --- a/vcl/opengl/texture.cxx +++ b/vcl/opengl/texture.cxx @@ -92,8 +92,6 @@ ImplOpenGLTexture::~ImplOpenGLTexture() SAL_INFO( vcl.opengl, ~OpenGLTexture mnTexture ); if( mnTexture != 0 ) glDeleteTextures( 1, mnTexture ); - -CHECK_GL_ERROR(); } OpenGLTexture::OpenGLTexture() : ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Release Notes Whiteboard Keyword
Hi All, I had recently been listening to a podcast and they mentioned that a linux or bsd distro would have a keyword in its bug tracking system for bugs that are worth mentioning in the release notes. So i was thinking that a whiteboard keyword of the same could be done so that it is easy to query bugzilla for these when libreoffice releases a major release. -- Regards, Jay Philips ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/perfwork5' - external/jpeg
external/jpeg/ExternalProject_jpeg.mk |1 + external/jpeg/UnpackedTarball_jpeg.mk |1 + external/jpeg/jpeg.win_build.patch.1 | 15 +++ 3 files changed, 17 insertions(+) New commits: commit 7854666e62a216bb927090f25c255439f497696a Author: Matúš Kukan matus.ku...@collabora.com Date: Fri Nov 14 22:00:11 2014 +0100 fix jpeg windows build Change-Id: I1f760cc68ad6d4972edc156504f63c70b8e7479a diff --git a/external/jpeg/ExternalProject_jpeg.mk b/external/jpeg/ExternalProject_jpeg.mk index e47fb14..b741e4f 100644 --- a/external/jpeg/ExternalProject_jpeg.mk +++ b/external/jpeg/ExternalProject_jpeg.mk @@ -25,6 +25,7 @@ $(call gb_ExternalProject_get_state_target,jpeg,build) : $(call gb_ExternalProje $(call gb_ExternalProject_get_state_target,jpeg,configure) : $(call gb_ExternalProject_run,configure,\ MAKE=$(MAKE) ./configure \ + --build=$(if $(filter WNT,$(OS)),i686-pc-cygwin,$(BUILD_PLATFORM)) \ --with-pic \ --enable-static \ --disable-shared \ diff --git a/external/jpeg/UnpackedTarball_jpeg.mk b/external/jpeg/UnpackedTarball_jpeg.mk index fa1999c..ac77b3a 100644 --- a/external/jpeg/UnpackedTarball_jpeg.mk +++ b/external/jpeg/UnpackedTarball_jpeg.mk @@ -13,6 +13,7 @@ $(eval $(call gb_UnpackedTarball_set_tarball,jpeg,$(JPEG_TARBALL))) $(eval $(call gb_UnpackedTarball_add_patches,jpeg,\ external/jpeg/jpeg.build.patch.1 \ + $(if $(filter WNT,$(OS)),external/jpeg/jpeg.win_build.patch.1) \ )) # vim: set noet sw=4 ts=4: diff --git a/external/jpeg/jpeg.win_build.patch.1 b/external/jpeg/jpeg.win_build.patch.1 new file mode 100644 index 000..1dc5b1e --- /dev/null +++ b/external/jpeg/jpeg.win_build.patch.1 @@ -0,0 +1,15 @@ +diff -ur jpeg.org/simd/Makefile.in jpeg/simd/Makefile.in +--- jpeg.org/simd/Makefile.in 2014-11-14 21:55:21.557802955 +0100 jpeg/simd/Makefile.in 2014-11-14 21:57:16.845804312 +0100 +@@ -583,8 +583,9 @@ + .asm.lo: + $(LIBTOOL) --mode=compile --tag NASM $(srcdir)/nasm_lt.sh $(NASM) $(NAFLAGS) -I$(srcdir) -I. $ -o $@ + +-jsimdcfg.inc: $(srcdir)/jsimdcfg.inc.h ../jpeglib.h ../jconfig.h ../jmorecfg.h +- $(CPP) -I$(top_builddir) -I$(top_builddir)/simd $(srcdir)/jsimdcfg.inc.h | $(EGREP) ^[\;%]|^\ % | sed 's%_cpp_protection_%%' | sed 's@% define@%define@g' $@ ++jsimdcfg.inc: $(top_srcdir)/win/jsimdcfg.inc ++ cp $ $@ ++ + # Tell versions [3.59,3.63) of GNU make to not export all variables. + # Otherwise a system limit (for SysV at least) may be exceeded. + .NOEXPORT: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [ANN] new internal jpeg needs nasm
On Fri, 2014-11-14 at 09:36 -0600, Norbert Thiebaud wrote: On Fri, Nov 14, 2014 at 8:47 AM, Matúš Kukan matus.ku...@collabora.com wrote: It should be ready now, I've just not tested it on OS X. on mac we need -f macho64 not -f macho I believe this was fixed by adding --build=$(BUILD_PLATFORM) ..now I see checking for object file format of host system... Mach-O64 checking for object file format specifier (NAFLAGS) ... -fmacho64 -DMACHO -D__x86_64__ checking whether the assembler (nasm -fmacho64 -DMACHO -D__x86_64__) works... no configure: error: installation or configuration problem: assembler cannot create object files. Should I try to remove that configure check and hope it will work or is something really broken there? I don't know how Windows build was working for me before but now it really should be fine. And thanks a lot for the lode thing. other than that nasm seems to be installed by default oh, great Thanks Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/perfwork5' - sc/inc sc/Library_sc.mk sc/source
sc/Library_sc.mk |2
sc/inc/bulkdatahint.hxx | 43
sc/inc/document.hxx |7
sc/inc/formulacell.hxx| 12 +
sc/inc/grouparealistener.hxx | 73 ++
sc/inc/simplehintids.hxx |9
sc/source/core/data/bcaslot.cxx | 116 +-
sc/source/core/data/colorscale.cxx|2
sc/source/core/data/documen2.cxx |4
sc/source/core/data/documen7.cxx | 17 -
sc/source/core/data/formulacell.cxx | 52
sc/source/core/data/table3.cxx|8
sc/source/core/inc/bcaslot.hxx| 57 +++--
sc/source/core/tool/bulkdatahint.cxx | 49
sc/source/core/tool/chartlis.cxx |4
sc/source/core/tool/grouparealistener.cxx | 321 ++
sc/source/core/tool/sharedformula.cxx | 78 +++
sc/source/ui/docshell/macromgr.cxx|2
sc/source/ui/docshell/servobj.cxx |6
sc/source/ui/unoobj/cellsuno.cxx |4
sc/source/ui/unoobj/chart2uno.cxx |4
21 files changed, 787 insertions(+), 83 deletions(-)
New commits:
commit 12899ce686d302352645605f6e262784df77f0b2
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Wed Nov 12 22:18:49 2014 -0500
Dedicated listener type tailored for formula groups.
Right now, it's only used when loading an xlsx file. But eventually
this one should be used everywhere.
Change-Id: I216c3a9a33c4b8040e8284d59299e0637471fb50
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 3648720..4404263 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -197,6 +197,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
sc/source/core/tool/adiasync \
sc/source/core/tool/appoptio \
sc/source/core/tool/autoform \
+sc/source/core/tool/bulkdatahint \
sc/source/core/tool/brdcst \
sc/source/core/tool/calcconfig \
sc/source/core/tool/callform \
@@ -227,6 +228,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
sc/source/core/tool/formulaopt \
sc/source/core/tool/formulaparserpool \
sc/source/core/tool/formularesult \
+sc/source/core/tool/grouparealistener \
sc/source/core/tool/hints \
sc/source/core/tool/inputopt \
sc/source/core/tool/interpr1 \
diff --git a/sc/inc/bulkdatahint.hxx b/sc/inc/bulkdatahint.hxx
new file mode 100644
index 000..31c13fb
--- /dev/null
+++ b/sc/inc/bulkdatahint.hxx
@@ -0,0 +1,43 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_SC_BULKDATAHINT_HXX
+#define INCLUDED_SC_BULKDATAHINT_HXX
+
+#include simplehintids.hxx
+
+class ScDocument;
+
+namespace sc {
+
+class ColumnSpanSet;
+
+class BulkDataHint : public SfxSimpleHint
+{
+struct Impl;
+Impl* mpImpl;
+
+BulkDataHint( const BulkDataHint );
+BulkDataHint operator= ( const BulkDataHint );
+
+public:
+BulkDataHint( ScDocument rDoc, const ColumnSpanSet* pSpans );
+virtual ~BulkDataHint();
+
+void setSpans( const ColumnSpanSet* pSpans );
+const ColumnSpanSet* getSpans() const;
+
+ScDocument getDoc();
+};
+
+}
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 9f6ab2c..72b49a8 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1852,10 +1852,9 @@ private:
static ScRecursionHelper* CreateRecursionHelperInstance();
public:
-voidStartListeningArea( const ScRange rRange,
-SvtListener* pListener );
-voidEndListeningArea( const ScRange rRange,
-SvtListener* pListener );
+void StartListeningArea( const ScRange rRange, bool bGroupListening,
SvtListener* pListener );
+
+void EndListeningArea( const ScRange rRange, bool bGroupListening,
SvtListener* pListener );
/** Broadcast wrapper, calls
rHint.GetCell()-Broadcast() and AreaBroadcast()
and TrackFormulas() and conditional format list
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index b65504e..67381a0 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -23,6 +23,7 @@
#include set
#include boost/noncopyable.hpp
+#include boost/ptr_container/ptr_vector.hpp
#include formula/tokenarray.hxx
#include osl/conditn.hxx
@@ -47,16 +48,18 @@ struct RefUpdateInsertTabContext;
struct RefUpdateDeleteTabContext;
struct RefUpdateMoveTabContext;
class CompileFormulaContext;
+class FormulaGroupAreaListener;
[Bug 67040] resizable autocorrect replacement table dialog
https://bugs.freedesktop.org/show_bug.cgi?id=67040 --- Comment #5 from tommy27 ba...@quipo.it --- oppsss... Coalan, something is gone wrong in 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@42, Branch:master, Time: 2014-11-12_00:19:18 the autocorrect replacement table is not resizable anymore unlike previous alpha1 version. can you please double check and if confirmed set the status to REOPENED? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/opengl
vcl/opengl/salbmp.cxx |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
New commits:
commit 318fc8d6810ed72bd43d811bac32216b6ed9f231
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 14 16:32:06 2014 +
vcl: assert more useful truths on BitmapWriterAccess completion.
Change-Id: I2ccc5eb64bf3b5d5ce94e2ddd4b9b458c3eda217
diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index c2ebb68..2a57e728 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -415,7 +415,8 @@ GLuint OpenGLSalBitmap::CreateTexture()
bool OpenGLSalBitmap::ReadTexture()
{
sal_uInt8* pData = maUserBuffer.get();
-GLenum nFormat, nType;
+GLenum nFormat = GL_RGB;
+GLenum nType = GL_UNSIGNED_BYTE;
SAL_INFO( vcl.opengl, ::ReadTexture mnWidth x mnHeight );
@@ -518,6 +519,12 @@ void OpenGLSalBitmap::ReleaseBuffer( BitmapBuffer*
pBuffer, bool bReadOnly )
// The palette is modified on read during the BitmapWriteAccess,
// but of course, often it is not modified; interesting.
maPalette = pBuffer-maPalette;
+
+// Are there any more ground movements underneath us ?
+assert( pBuffer-mnWidth == mnWidth );
+assert( pBuffer-mnHeight == mnHeight );
+assert( pBuffer-mnBitCount == mnBits );
+
delete pBuffer;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/perfwork5' - sc/inc sc/source
sc/inc/grouparealistener.hxx | 10 ---
sc/source/core/tool/grouparealistener.cxx | 91 --
2 files changed, 1 insertion(+), 100 deletions(-)
New commits:
commit e8184b4bda4f8ce0bfa676d592e1f493ca9e3eeb
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Fri Nov 14 17:47:42 2014 -0500
We don't need 2 variants of this method. One is enough.
Change-Id: I001c388669737e9cf1d92f1fbb1e64fb9f4b05c3
diff --git a/sc/inc/grouparealistener.hxx b/sc/inc/grouparealistener.hxx
index 6301023..28e8f43 100644
--- a/sc/inc/grouparealistener.hxx
+++ b/sc/inc/grouparealistener.hxx
@@ -39,16 +39,6 @@ public:
virtual void Notify( const SfxHint rHint ) SAL_OVERRIDE;
/**
- * Given the position of a changed cell, collect all formula cells that
- * need to be notified of the change.
- *
- * @param rPos position of changed cell.
- * @param rCells all formula cells that need to be notified are put into
- * this container.
- */
-void collectFormulaCells( const ScAddress rPos,
std::vectorScFormulaCell* rCells ) const;
-
-/**
* Given the row span of changed cells within a single column, collect all
* formula cells that need to be notified of the change.
*
diff --git a/sc/source/core/tool/grouparealistener.cxx
b/sc/source/core/tool/grouparealistener.cxx
index e682d61..7a83461 100644
--- a/sc/source/core/tool/grouparealistener.cxx
+++ b/sc/source/core/tool/grouparealistener.cxx
@@ -125,95 +125,6 @@ void FormulaGroupAreaListener::notifyBulkChange( const
BulkDataHint rHint )
std::for_each(aCells.begin(), aCells.end(), Notifier(aHint));
}
-void FormulaGroupAreaListener::collectFormulaCells( const ScAddress rPos,
std::vectorScFormulaCell* rCells ) const
-{
-if (rPos.Tab() maRange.aStart.Tab() || maRange.aEnd.Tab() rPos.Tab())
-// Wrong sheet.
-return;
-
-if (rPos.Col() maRange.aStart.Col() || maRange.aEnd.Col() rPos.Col())
-// Outside the column range.
-return;
-
-ScFormulaCell** pp = mppTopCell;
-ScFormulaCell** ppEnd = pp + mnGroupLen;
-
-if (mbStartFixed)
-{
-if (mbEndFixed)
-{
-// Both top and bottom row positions are absolute. Use the
original range as-is.
-SCROW nRow1 = maRange.aStart.Row();
-SCROW nRow2 = maRange.aEnd.Row();
-if (rPos.Row() nRow1 || nRow2 rPos.Row())
-return;
-
-for (; pp != ppEnd; ++pp)
-rCells.push_back(*pp);
-}
-else
-{
-// Only the end row is relative.
-SCROW nRow1 = maRange.aStart.Row();
-SCROW nRow2 = maRange.aEnd.Row();
-SCROW nMaxRow = nRow2 + mnGroupLen - 1;
-if (rPos.Row() nRow1 || nMaxRow rPos.Row())
-return;
-
-if (nRow2 rPos.Row())
-{
-// Skip ahead to the first hit.
-SCROW nSkip = rPos.Row() - nRow2;
-pp += nSkip;
-nRow2 += nSkip;
-}
-
-// Notify the first hit cell and all subsequent ones.
-for (; pp != ppEnd; ++pp)
-rCells.push_back(*pp);
-}
-}
-else if (mbEndFixed)
-{
-// Only the start row is relative.
-SCROW nRow1 = maRange.aStart.Row();
-SCROW nRow2 = maRange.aEnd.Row();
-
-if (rPos.Row() nRow1 || nRow2 rPos.Row())
-return;
-
-for (; pp != ppEnd nRow1 = nRow2; ++pp, ++nRow1)
-rCells.push_back(*pp);
-}
-else
-{
-// Both top and bottom row positions are relative.
-SCROW nRow1 = maRange.aStart.Row();
-SCROW nRow2 = maRange.aEnd.Row();
-SCROW nMaxRow = nRow2 + mnGroupLen - 1;
-if (nMaxRow rPos.Row())
-return;
-
-if (nRow2 rPos.Row())
-{
-// Skip ahead.
-SCROW nSkip = rPos.Row() - nRow2;
-pp += nSkip;
-nRow1 += nSkip;
-nRow2 += nSkip;
-}
-
-for (; pp != ppEnd; ++pp, ++nRow1, ++nRow2)
-{
-if (rPos.Row() nRow1 || nRow2 rPos.Row())
-// Changed cell is outside the range.
-continue;
-
-rCells.push_back(*pp);
-}
-}
-}
-
void FormulaGroupAreaListener::collectFormulaCells(
SCTAB nTab, SCCOL nCol, SCROW nRow1, SCROW nRow2,
std::vectorScFormulaCell* rCells ) const
{
@@ -312,7 +223,7 @@ void FormulaGroupAreaListener::notifyCellChange( const
SfxHint rHint, const ScA
{
// Determine which formula cells within the group need to be notified of
this change.
std::vectorScFormulaCell* aCells;
-collectFormulaCells(rPos, aCells);
+collectFormulaCells(rPos.Tab(), rPos.Col(), rPos.Row(), rPos.Row(),
aCells);
std::for_each(aCells.begin(), aCells.end(), Notifier(rHint));
}
Re: [Libreoffice-qa] Release Notes Whiteboard Keyword
Hi Jay, Hi All, I had recently been listening to a podcast and they mentioned that a linux or bsd distro would have a keyword in its bug tracking system for bugs that are worth mentioning in the release notes. So i was thinking that a whiteboard keyword of the same could be done so that it is easy to query bugzilla for these when libreoffice releases a major release. I have really mixed feelings about this - sounds like a good way to encourage pet bugs which we don't like. How is this different from just the MAB list? Best, Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Google shuts down the OpenID 2.0 on April 20, 2015
Le Tue, 11 Nov 2014 10:37:45 +0100, Bjoern Michaelsen bjoern.michael...@canonical.com a écrit: On Tue, Nov 11, 2014 at 08:26:19AM +0200, Tor Lillqvist wrote: There is a list: http://openid.net/get-an-openid/ and chances you already have one of those (including lots of smaller providers like wordpress.com, livejournal). Also note that everyone who ever filed a bug against Ubuntu has an OpenID as launchpad offers one. FTR, stackexchange, editor of many websites (stackoverflow, askubuntu,...) is also providing an OpenID 2.0 service [0], if you deigned to create a login on them :) Regards Mat M [0] https://openid.stackexchange.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/chartlis.hxx |6 ++
sc/source/core/tool/chartlis.cxx | 21 +
2 files changed, 27 insertions(+)
New commits:
commit ef2ed50231fd946c1f374ffbce28ebb98eda56c5
Author: Eike Rathke er...@redhat.com
Date: Sat Nov 15 02:00:16 2014 +0100
fdo#73695 prevent use of invalidated iterator due to re-entrance
... through the UNO backdoor..
While charts are updated there can be chart data listeners in BASIC that
in turn modify things such that charts are inserted/removed from the
listener chain, invalidating the iterator. If that happens break and
bail out instead of crashing. Not ideal, but..
Change-Id: Iefb33d3a96d79caed0ee4e19b73e8f811ef3d937
diff --git a/sc/inc/chartlis.hxx b/sc/inc/chartlis.hxx
index f9a3641..9952d4b 100644
--- a/sc/inc/chartlis.hxx
+++ b/sc/inc/chartlis.hxx
@@ -141,6 +141,12 @@ public:
typedef boost::unordered_setOUString, OUStringHash StringSetType;
private:
ListenersType maListeners;
+enum UpdateStatus
+{
+SC_CLCUPDATE_NONE,
+SC_CLCUPDATE_RUNNING,
+SC_CLCUPDATE_MODIFIED
+} meModifiedDuringUpdate;
::std::listRangeListenerItem maHiddenListeners;
StringSetType maNonOleObjectNames;
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index be56325..837dbfe 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -411,6 +411,7 @@
ScChartListenerCollection::RangeListenerItem::RangeListenerItem(const ScRange r
}
ScChartListenerCollection::ScChartListenerCollection( ScDocument* pDocP ) :
+meModifiedDuringUpdate( SC_CLCUPDATE_NONE ),
pDoc( pDocP )
{
aTimer.SetTimeoutHdl( LINK( this, ScChartListenerCollection, TimerHdl ) );
@@ -418,6 +419,7 @@ ScChartListenerCollection::ScChartListenerCollection(
ScDocument* pDocP ) :
ScChartListenerCollection::ScChartListenerCollection(
const ScChartListenerCollection rColl ) :
+meModifiedDuringUpdate( SC_CLCUPDATE_NONE ),
pDoc( rColl.pDoc )
{
aTimer.SetTimeoutHdl( LINK( this, ScChartListenerCollection, TimerHdl ) );
@@ -441,12 +443,16 @@ void ScChartListenerCollection::StartAllListeners()
void ScChartListenerCollection::insert(ScChartListener* pListener)
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
OUString aName = pListener-GetName();
maListeners.insert(aName, pListener);
}
void ScChartListenerCollection::removeByName(const OUString rName)
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
maListeners.erase(rName);
}
@@ -519,6 +525,9 @@ public:
void ScChartListenerCollection::FreeUnused()
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
+
ListenersType aUsed, aUnused;
// First, filter each listener into 'used' and 'unused' categories.
@@ -550,6 +559,9 @@ void ScChartListenerCollection::FreeUnused()
void ScChartListenerCollection::FreeUno( const uno::Reference
chart::XChartDataChangeEventListener rListener,
const uno::Reference
chart::XChartData rSource )
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
+
std::vectorScChartListener* aUsed, aUnused;
// First, filter each listener into 'used' and 'unused' categories.
@@ -594,6 +606,11 @@ IMPL_LINK_NOARG(ScChartListenerCollection, TimerHdl)
void ScChartListenerCollection::UpdateDirtyCharts()
{
+// During ScChartListener::Update() the most nasty things can happen due to
+// UNO listeners, e.g. reentrant calls via BASIC to insert() and FreeUno()
+// and similar that modify maListeners and invalidate iterators.
+meModifiedDuringUpdate = SC_CLCUPDATE_RUNNING;
+
ListenersType::iterator it = maListeners.begin(), itEnd =
maListeners.end();
for (; it != itEnd; ++it)
{
@@ -601,9 +618,13 @@ void ScChartListenerCollection::UpdateDirtyCharts()
if (p-IsDirty())
p-Update();
+if (meModifiedDuringUpdate == SC_CLCUPDATE_MODIFIED)
+break; // iterator is invalid
+
if (aTimer.IsActive() !pDoc-IsImportingXML())
break; // one interfered
}
+meModifiedDuringUpdate = SC_CLCUPDATE_NONE;
}
void ScChartListenerCollection::SetDirty()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Bug 75025 depends on bug 81264, which changed state. Bug 81264 Summary: Calc is not accessible to screen readers if sheet is modified [a11y] https://bugs.freedesktop.org/show_bug.cgi?id=81264 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/perfwork5' - sc/inc sc/source
sc/inc/address.hxx |3 +
sc/source/core/data/bcaslot.cxx | 100 +++
sc/source/core/data/documen7.cxx | 62 +---
sc/source/core/data/document.cxx | 10 +--
sc/source/core/inc/bcaslot.hxx |2
sc/source/core/tool/address.cxx | 15 +
6 files changed, 178 insertions(+), 14 deletions(-)
New commits:
commit eee4f852e112acabbe1117caa88825497c13ec24
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Fri Nov 14 21:51:39 2014 -0500
Send broadcast range to the area broadcast slot machine.
Rather than iterating through cells in the range and broadcasting by
cells individually. This way we can take advantage of the new group
based area listeners and it's much faster this way.
Change-Id: I8a4b49bce69d89b5b4698790befe4390871c755d
diff --git a/sc/inc/address.hxx b/sc/inc/address.hxx
index 7fcdee1..527cba2 100644
--- a/sc/inc/address.hxx
+++ b/sc/inc/address.hxx
@@ -563,6 +563,9 @@ public:
SC_DLLPUBLIC void Justify();
SC_DLLPUBLIC void ExtendTo( const ScRange rRange );
SC_DLLPUBLIC bool Intersects( const ScRange rRange ) const;// do two
ranges intersect?
+
+ScRange Union( const ScRange rOther ) const;
+
void PutInOrder();
inline bool operator==( const ScRange rRange ) const;
inline bool operator!=( const ScRange rRange ) const;
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx
index 9af7c19..ee6f17a 100644
--- a/sc/source/core/data/bcaslot.cxx
+++ b/sc/source/core/data/bcaslot.cxx
@@ -258,6 +258,83 @@ ScBroadcastAreas::const_iterator
ScBroadcastAreaSlot::FindBroadcastArea(
return aBroadcastAreaTbl.find( aTmpSeekBroadcastArea);
}
+namespace {
+
+void broadcastRangeByCell( SvtBroadcaster rBC, const ScRange rRange,
sal_uLong nHint )
+{
+ScHint aHint(nHint, ScAddress());
+ScAddress rPos = aHint.GetAddress();
+for (SCTAB nTab = rRange.aStart.Tab(); nTab = rRange.aEnd.Tab(); ++nTab)
+{
+rPos.SetTab(nTab);
+for (SCCOL nCol = rRange.aStart.Col(); nCol = rRange.aEnd.Col();
++nCol)
+{
+rPos.SetCol(nCol);
+for (SCROW nRow = rRange.aStart.Row(); nRow = rRange.aEnd.Row();
++nRow)
+{
+rPos.SetRow(nRow);
+rBC.Broadcast(aHint);
+}
+}
+}
+}
+
+}
+
+bool ScBroadcastAreaSlot::AreaBroadcast( const ScRange rRange, sal_uLong
nHint )
+{
+if (aBroadcastAreaTbl.empty())
+return false;
+
+bool bInBroadcast = mbInBroadcastIteration;
+mbInBroadcastIteration = true;
+bool bIsBroadcasted = false;
+
+mbHasErasedArea = false;
+
+for (ScBroadcastAreas::const_iterator aIter( aBroadcastAreaTbl.begin()),
+aIterEnd( aBroadcastAreaTbl.end()); aIter != aIterEnd; ++aIter )
+{
+if (mbHasErasedArea isMarkedErased( aIter))
+continue;
+
+ScBroadcastArea* pArea = (*aIter).mpArea;
+const ScRange rAreaRange = pArea-GetRange();
+
+// Take the union of the area range and the broadcast range.
+ScRange aUnion = rAreaRange.Union(rRange);
+if (!aUnion.IsValid())
+continue;
+
+if (pArea-IsGroupListening())
+{
+if (pBASM-IsInBulkBroadcast())
+{
+pBASM-InsertBulkGroupArea(pArea, aUnion);
+}
+else
+{
+broadcastRangeByCell(pArea-GetBroadcaster(), aUnion, nHint);
+bIsBroadcasted = true;
+}
+}
+else if (!pBASM-IsInBulkBroadcast() || pBASM-InsertBulkArea( pArea))
+{
+broadcastRangeByCell(pArea-GetBroadcaster(), aUnion, nHint);
+bIsBroadcasted = true;
+}
+}
+
+mbInBroadcastIteration = bInBroadcast;
+
+// A Notify() during broadcast may call EndListeningArea() and thus dispose
+// an area if it was the last listener, which would invalidate an iterator
+// pointing to it, hence the real erase is done afterwards.
+FinallyEraseAreas();
+
+return bIsBroadcasted;
+}
+
bool ScBroadcastAreaSlot::AreaBroadcast( const ScHint rHint)
{
if (aBroadcastAreaTbl.empty())
@@ -758,6 +835,29 @@ void ScBroadcastAreaSlotMachine::EndListeningArea(
}
}
+bool ScBroadcastAreaSlotMachine::AreaBroadcast( const ScRange rRange,
sal_uLong nHint )
+{
+bool bBroadcasted = false;
+SCTAB nEndTab = rRange.aEnd.Tab();
+for (TableSlotsMap::iterator iTab( aTableSlotsMap.lower_bound(
rRange.aStart.Tab()));
+iTab != aTableSlotsMap.end() (*iTab).first = nEndTab; ++iTab)
+{
+ScBroadcastAreaSlot** ppSlots = (*iTab).second-getSlots();
+SCSIZE nStart, nEnd, nRowBreak;
+ComputeAreaPoints( rRange, nStart, nEnd, nRowBreak );
+SCSIZE nOff = nStart;
+SCSIZE nBreak = nOff + nRowBreak;
+ScBroadcastAreaSlot** pp = ppSlots + nOff;
+while ( nOff = nEnd )
+
[Bug 67040] resizable autocorrect replacement table dialog
https://bugs.freedesktop.org/show_bug.cgi?id=67040 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added CC|libreoffice@lists.freedeskt |f...@libreoffice.org |op.org | --- Comment #6 from Adolfo Jayme f...@libreoffice.org --- I’ve disabled resizing in many dialogs. I would like to know why you need to resize this one in particular. Perhaps what you need is a scrollbar? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Development license statement
All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. -- Regards, Renato Ferreira. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice Gerrit News for core on 2014-11-15
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + fdo#51741 Mark document as modified on bookmark rename / delete in https://gerrit.libreoffice.org/12436 from Renato Ferreira about module sw + fdo#83308 Show thousand separators in document word/character counts in https://gerrit.libreoffice.org/12130 from Matthew Francis about module sw + Improve rtf import filter to handle Chinese suffixes of numbered lists. in https://gerrit.libreoffice.org/12435 from Mark Hung about module sw, writerfilter + fdo82708 fixing statusbar tooltip texts in https://gerrit.libreoffice.org/12433 from Yousuf Philips about module framework, svx, sw + Partial revert of da40cac540e7d735edbe9069b3c8ec6af4530208 in https://gerrit.libreoffice.org/12432 from Andrea Gelmini about module external + Fix typo in bin/check-merged.sh in https://gerrit.libreoffice.org/12431 from Andrea Gelmini about module bin + fdo#86183 set ctrl+shift+e to track changes and reassign edit mode in https://gerrit.libreoffice.org/12415 from Yousuf Philips about module officecfg + fdo#86289 renaming 'Page Preview' to 'Print Preview' in https://gerrit.libreoffice.org/12430 from Yousuf Philips about module officecfg + OXYGEN: Replaced icons with icons from the icon set sources in https://gerrit.libreoffice.org/12429 from Yousuf Philips about module icon-themes + fdo#86190 glmwrappers for bdhommatrix/affinematrix in https://gerrit.libreoffice.org/12379 from Michael Jaumann about module basebmp, basegfx, canvas, cppcanvas, drawinglayer, filter, include, sd, sdext, slideshow, svx + Preparation of the LibreOfficeKit for Windows in https://gerrit.libreoffice.org/12425 from juegen funk about module include, smoketest End of freshness + Replace internal jpeg with jpeg-turbo in https://gerrit.libreoffice.org/12402 from Matúš Kukan about module build, external, vcl + More iwyu suggested headers removal in https://gerrit.libreoffice.org/12427 from Riccardo Magliocchetti about module basic, codemaker, idlc, include, l10ntools, registry, sal, store, tools, vcl + #pragma hdrstop looks quite obsolete in https://gerrit.libreoffice.org/12424 from Michael Stahl about module sc, starmath, svl, svtools + remove unused code in ScRawToken in https://gerrit.libreoffice.org/12423 from Noel Grandin about module build, sc * Merged changes on master for project core changed in the last 25 hours: + Fix common typos. No automatic tools. Handmade… in https://gerrit.libreoffice.org/12164 from Andrea Gelmini + Cleanup parse-perfcheck.py in https://gerrit.libreoffice.org/12405 from Riccardo Magliocchetti + fdo#75757: remove inheritance to std::map in https://gerrit.libreoffice.org/12401 from Juan Picca + fdo#86023 - O[U]String needs a 'clear' method in https://gerrit.libreoffice.org/12391 from Brij Mohan Lal Srivastava + -Werror,-Wunused-const-variable in https://gerrit.libreoffice.org/12422 from Noel Grandin * Abandoned changes on master for project core changed in the last 25 hours: + coverity#983623 Uncaught exception in https://gerrit.libreoffice.org/12426 from Caolán McNamara + fdo#86190 glmwrappers for bdhommatrix/affinematrix in https://gerrit.libreoffice.org/12428 from Michael Jaumann * Open changes needing tweaks, but being untouched for more than a week: + fdo#77569 - Add Choose Theme to Format Menu in https://gerrit.libreoffice.org/12275 from Joel Madero + Perftest for loading autocorrect dictionaries, related fdo#79761 in https://gerrit.libreoffice.org/11296 from Matúš Kukan + android: Show document browser back in the menu in https://gerrit.libreoffice.org/12108 from Jacobo Aragunde Pérez + coverity#1242459 Identical code for different branches in https://gerrit.libreoffice.org/11772 from Caolán McNamara + jvmfwk: Apple Oracle's JRE detection for OS X 10.8+ in https://gerrit.libreoffice.org/12057 from Robert Antoni Buj i Gelonch + HIG-ification of GSoC Color Picker dialog in https://gerrit.libreoffice.org/11494 from Olivier Hallot + WIP: fdo#43090: Add an option to disable autoclose brackets in https://gerrit.libreoffice.org/12024 from Marcos Paulo de Souza + fdo#39625 Make existing CppUnittests work in https://gerrit.libreoffice.org/11605 from Tobias Madl + fdo#58194 - export DOCX Automatic indent as firstLine indent in https://gerrit.libreoffice.org/10425 from Joren De Cuyper + WIP (do not merge): remove custom impl of bidirectional list in https://gerrit.libreoffice.org/11001 from Chris Laplante + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/inc sc/source
sc/inc/chartlis.hxx |6 ++
sc/source/core/tool/chartlis.cxx | 21 +
2 files changed, 27 insertions(+)
New commits:
commit 547d613e0868726e602ccb00fca0e7518a6c4bee
Author: Eike Rathke er...@redhat.com
Date: Sat Nov 15 02:00:16 2014 +0100
fdo#73695 prevent use of invalidated iterator due to re-entrance
... through the UNO backdoor..
While charts are updated there can be chart data listeners in BASIC that
in turn modify things such that charts are inserted/removed from the
listener chain, invalidating the iterator. If that happens break and
bail out instead of crashing. Not ideal, but..
Change-Id: Iefb33d3a96d79caed0ee4e19b73e8f811ef3d937
(cherry picked from commit ef2ed50231fd946c1f374ffbce28ebb98eda56c5)
Reviewed-on: https://gerrit.libreoffice.org/12434
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com
diff --git a/sc/inc/chartlis.hxx b/sc/inc/chartlis.hxx
index 24c1bcd..7feebf3 100644
--- a/sc/inc/chartlis.hxx
+++ b/sc/inc/chartlis.hxx
@@ -141,6 +141,12 @@ public:
typedef boost::unordered_setOUString, OUStringHash StringSetType;
private:
ListenersType maListeners;
+enum UpdateStatus
+{
+SC_CLCUPDATE_NONE,
+SC_CLCUPDATE_RUNNING,
+SC_CLCUPDATE_MODIFIED
+} meModifiedDuringUpdate;
::std::listRangeListenerItem maHiddenListeners;
StringSetType maNonOleObjectNames;
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index 4a96cf6..87cdb6ef 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -421,6 +421,7 @@
ScChartListenerCollection::RangeListenerItem::RangeListenerItem(const ScRange r
}
ScChartListenerCollection::ScChartListenerCollection( ScDocument* pDocP ) :
+meModifiedDuringUpdate( SC_CLCUPDATE_NONE ),
pDoc( pDocP )
{
aTimer.SetTimeoutHdl( LINK( this, ScChartListenerCollection, TimerHdl ) );
@@ -428,6 +429,7 @@ ScChartListenerCollection::ScChartListenerCollection(
ScDocument* pDocP ) :
ScChartListenerCollection::ScChartListenerCollection(
const ScChartListenerCollection rColl ) :
+meModifiedDuringUpdate( SC_CLCUPDATE_NONE ),
pDoc( rColl.pDoc )
{
aTimer.SetTimeoutHdl( LINK( this, ScChartListenerCollection, TimerHdl ) );
@@ -451,12 +453,16 @@ void ScChartListenerCollection::StartAllListeners()
void ScChartListenerCollection::insert(ScChartListener* pListener)
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
OUString aName = pListener-GetName();
maListeners.insert(aName, pListener);
}
void ScChartListenerCollection::removeByName(const OUString rName)
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
maListeners.erase(rName);
}
@@ -544,6 +550,9 @@ public:
void ScChartListenerCollection::FreeUnused()
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
+
ListenersType aUsed, aUnused;
// First, filter each listener into 'used' and 'unused' categories.
@@ -575,6 +584,9 @@ void ScChartListenerCollection::FreeUnused()
void ScChartListenerCollection::FreeUno( const uno::Reference
chart::XChartDataChangeEventListener rListener,
const uno::Reference
chart::XChartData rSource )
{
+if (meModifiedDuringUpdate == SC_CLCUPDATE_RUNNING)
+meModifiedDuringUpdate = SC_CLCUPDATE_MODIFIED;
+
std::vectorScChartListener* aUsed, aUnused;
// First, filter each listener into 'used' and 'unused' categories.
@@ -619,6 +631,11 @@ IMPL_LINK_NOARG(ScChartListenerCollection, TimerHdl)
void ScChartListenerCollection::UpdateDirtyCharts()
{
+// During ScChartListener::Update() the most nasty things can happen due to
+// UNO listeners, e.g. reentrant calls via BASIC to insert() and FreeUno()
+// and similar that modify maListeners and invalidate iterators.
+meModifiedDuringUpdate = SC_CLCUPDATE_RUNNING;
+
ListenersType::iterator it = maListeners.begin(), itEnd =
maListeners.end();
for (; it != itEnd; ++it)
{
@@ -626,9 +643,13 @@ void ScChartListenerCollection::UpdateDirtyCharts()
if (p-IsDirty())
p-Update();
+if (meModifiedDuringUpdate == SC_CLCUPDATE_MODIFIED)
+break; // iterator is invalid
+
if (aTimer.IsActive() !pDoc-IsImportingXML())
break; // one interfered
}
+meModifiedDuringUpdate = SC_CLCUPDATE_NONE;
}
void ScChartListenerCollection::SetDirty()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/unx
vcl/unx/kde/salnativewidgets-kde.cxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit ef76fbe1f53eb7f30c0837cfae8552143831dd50
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Nov 14 15:02:16 2014 +0100
fix building the KDE backend
Change-Id: I03c8629bf27a43d6f4cc08bb8f64ed71b9055fdc
diff --git a/vcl/unx/kde/salnativewidgets-kde.cxx
b/vcl/unx/kde/salnativewidgets-kde.cxx
index aa86e31..a06fe1d 100644
--- a/vcl/unx/kde/salnativewidgets-kde.cxx
+++ b/vcl/unx/kde/salnativewidgets-kde.cxx
@@ -26,6 +26,7 @@
#include unx/saldisp.hxx
#include unx/salgdi.h
#include unx/kde/kdedata.hxx
+#include unx/pixmap.hxx
#include vcl/settings.hxx
#include fontmanager.hxx
@@ -314,7 +315,7 @@ class WidgetPainter
*/
bool drawStyledWidget( QWidget *pWidget,
ControlState nState, const ImplControlValue aValue,
-KDESalGraphics* pGraphics,
+X11SalGraphics* pGraphics,
ControlPart nPart = PART_ENTIRE_CONTROL );
/** 'Get' method for push button.
@@ -506,7 +507,7 @@ WidgetPainter::~WidgetPainter( void )
bool WidgetPainter::drawStyledWidget( QWidget *pWidget,
ControlState nState, const ImplControlValue aValue,
-KDESalGraphics* pGraphics, ControlPart nPart )
+X11SalGraphics* pGraphics, ControlPart nPart )
{
if ( !pWidget )
return false;
@@ -853,7 +854,7 @@ bool WidgetPainter::drawStyledWidget( QWidget *pWidget,
return false;
// Bitblt it to the screen
-pGraphics-RenderPixmapToScreen( xPixmap, qWidgetPos.x(), qWidgetPos.y() );
+pGraphics-RenderPixmapToScreen( xPixmap, qWidgetPos.x(), qWidgetPos.y()
);
// Restore widget's position
pWidget-move( qWidgetPos );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Bugzilla: LO 4.3.3.2 is missing from versions list menu
On Thu, 13 Nov 2014 04:43:39 +0100, Tommy ba...@quipo.it wrote: On Wed, 12 Nov 2014 22:27:35 +0100, Joel Madero jmadero@gmail.com wrote: Fixed thanks. one last fix needed. 4.3.3.2 is still credited as rc instead of release bye, Tommaso and the same regarding 4.3.4.1 rc which has been published as final today --- Questa e-mail è priva di virus e malware perché è attiva la protezione avast! Antivirus. http://www.avast.com ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
Hi, On Thu, Nov 13, 2014 at 04:13:33PM +, Michael Meeks wrote: * QA (Robinson) There is a Bug Hunting Session for 4.4 coming up next week. If you did any bigger refactoring or other work that primarily can be assumed to affect a specific area of usecases, please add this to: https://wiki.documentfoundation.org/BugHunting_Session_4.4.0.0#What_to_test so we can get early warning on e.g. regressions by some more focussed testing. Of course, if you did something that is not only a refactoring bug actually brings new features, you are invited to add this to: https://wiki.documentfoundation.org/ReleaseNotes/4.4 so that marketing can use it too and e.g. prepare cute screenshots. @Michael: Can we add that reminder for the next ESC call too? Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
Hi Bjoern, all On Fri, Nov 14, 2014 at 1:55 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Hi, On Thu, Nov 13, 2014 at 04:13:33PM +, Michael Meeks wrote: * QA (Robinson) There is a Bug Hunting Session for 4.4 coming up next week. If you did any bigger refactoring or other work that primarily can be assumed to affect a specific area of usecases, please add this to: https://wiki.documentfoundation.org/BugHunting_Session_4.4.0.0#What_to_test Maybe it would be easier if I add the test cases to MozTrap? there could be also a follow-up through the beta/rc/final. Cheers Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org Tel:+33683901545 Co-founder - Release coordinator The Document Foundation ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On 2014-11-13 06:13 PM, Michael Meeks wrote: * library bloat (Michael S) + not really an issue for release builds - --enable-mergelibs + big library + --enable-symbols - OOM + especially problematic CppuniTests with use_library_objects + perhaps a barrier to entry to new developers + Calc: (with debuginfo) 4.1 - 413Mb, 4.3 - 512Mb, master - 600Mb (stripped)4.3 - 26.8Mb master - 30Mb + linking in parallel gives OOM issues. = avoid making libraries even bigger. + new calc engine uses lots of templates (Markus) + mdds usage is restricted to only a few modules: (Kohei) + 5-6 translation units only. + whole code-base is using lots more templates (Markus) + compilation speed also got more than 2x slower (Kohei) + use of own templates container - STL + recently turned a lot of methods to inline methods left/right (Kohei) Some suggestions: (1) Would it make a difference if I went through the *.hxx files, marking the inline methods with an explicit inline qualifier? (2) Perhaps we need to be using the extern template feature to limit the number of instantiations of various templates? (3) Use gcc's -gsplit-dwarf feature to reduce size of debug information (clang also has some support for this) https://gcc.gnu.org/wiki/DebugFission We could auto-detect this in configure.ac and use it if available. Disclaimer: http://www.peralex.com/disclaimer.html ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
On Fri, Nov 14, 2014 at 03:42:16PM +0100, Sophie Gautier wrote: Maybe it would be easier if I add the test cases to MozTrap? there could be also a follow-up through the beta/rc/final. Thank you, that would be great! I was suggesting to just edit the wiki as telling hackers to enter stuff in MozTrap likely earns us just a few groans mumbling yet another login/account. Speaking of that: If people come forward during the ESC call with stuff done for 4.4 we should just put that in the minutes -- we can copy it over to the Wiki/MozTrap later. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] retest ping to UNCONFIRMED bugs older than 6 months
On Thu, 13 Nov 2014 07:13:29 +0100, Tommy ba...@quipo.it wrote: sure, QA consensus is necessary, however please wait the official release of 4.3.4 which is planned in Week 47 , Nov 17, 2014 - Nov 23, 2014 so we are sure the user will retest the bugs with the latest up to date version 4.3.4 released today. let's wait next QA meeting then we may proceed if the ping campaign is accepted --- Questa e-mail è priva di virus e malware perché è attiva la protezione avast! Antivirus. http://www.avast.com ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] 4.4 refactorings and BHS (was: minutes of ESC call ...)
Hi Bjoern, On Fri, Nov 14, 2014 at 5:37 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Fri, Nov 14, 2014 at 03:42:16PM +0100, Sophie Gautier wrote: Maybe it would be easier if I add the test cases to MozTrap? there could be also a follow-up through the beta/rc/final. Thank you, that would be great! I was suggesting to just edit the wiki as telling hackers to enter stuff in MozTrap likely earns us just a few groans mumbling yet another login/account. yes, no problem, I write the tests and upload them. Speaking of that: If people come forward during the ESC call with stuff done for 4.4 we should just put that in the minutes -- we can copy it over to the Wiki/MozTrap later. Just let the stuff in the minutes, I read them anyway and will ping the developer when I don't understand. Cheers Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org Tel:+33683901545 Co-founder - Release coordinator The Document Foundation ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Release Notes Whiteboard Keyword
Hi All, I had recently been listening to a podcast and they mentioned that a linux or bsd distro would have a keyword in its bug tracking system for bugs that are worth mentioning in the release notes. So i was thinking that a whiteboard keyword of the same could be done so that it is easy to query bugzilla for these when libreoffice releases a major release. -- Regards, Jay Philips ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Release Notes Whiteboard Keyword
Hi Jay, Hi All, I had recently been listening to a podcast and they mentioned that a linux or bsd distro would have a keyword in its bug tracking system for bugs that are worth mentioning in the release notes. So i was thinking that a whiteboard keyword of the same could be done so that it is easy to query bugzilla for these when libreoffice releases a major release. I have really mixed feelings about this - sounds like a good way to encourage pet bugs which we don't like. How is this different from just the MAB list? Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Release Notes Whiteboard Keyword
Top posting reply to Joel's note... Actually, it makes a lot of sense in that release notes really need a more descriptive narrative for substantive enhancements and bug fixes. As is we often simply list the fixes against prior releases. Envision this whiteboard tagging would support two aspects 1) the editorial tracking that substantive ehnancment/bug fixes have been described in the release notes 2) encourage QA/Dev or OP to describe the user impact of fixing an issue directly in the BZ so it could be picked up in a release note snippet. Stuart From: Libreoffice-qa libreoffice-qa-boun...@lists.freedesktop.org on behalf of Joel Madero jmadero@gmail.com Sent: Friday, November 14, 2014 4:56 PM To: Jay Philips Cc: LibreOffice-QA; libreoffice-dev Subject: Re: [Libreoffice-qa] Release Notes Whiteboard Keyword Hi Jay, Hi All, I had recently been listening to a podcast and they mentioned that a linux or bsd distro would have a keyword in its bug tracking system for bugs that are worth mentioning in the release notes. So i was thinking that a whiteboard keyword of the same could be done so that it is easy to query bugzilla for these when libreoffice releases a major release. I have really mixed feelings about this - sounds like a good way to encourage pet bugs which we don't like. How is this different from just the MAB list? Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 70346] Section condition doesn't hide section with database fields
https://bugs.freedesktop.org/show_bug.cgi?id=70346 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #5 from Beluga todven...@suomi24.fi --- Judging from comment 4 this is fixed, but I don't know how to verify as the original instructions do not have clear steps. What fields to assign to which stuff when creating the data source? I see the conditions can be created in Select address list - Filter, but what should I input and what should I be seeing as an expected result? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60195] Report no more editable on 3.6.5.2
https://bugs.freedesktop.org/show_bug.cgi?id=60195 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #9 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to robert from comment #7) Created attachment 74501 [details] Repaired *.odb-file with new styles.xml in the directory /reports/Obj42/ Robert: Thanks for working some digital duct-tape magic and fixing Projektliste3. Ulf: Does the repaired document work for you? If so, please change the status to RESOLVED WORKSFORME. If not, please leave us a note and change the status back to UNCONFIRMED. Thanks! Status - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76065] TemplateManager: Calc templates are not shown
https://bugs.freedesktop.org/show_bug.cgi?id=76065 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #4 from Beluga todven...@suomi24.fi --- (In reply to a07cd040897db54e103c from comment #3) Tested again with LO 4.2.6.3 on Windows 7 x64 and the problem still exists. To reproduce: 1. put templates of Writer- (*.ott), Calc- (*.ots) and Impress- (*.otp) and Draw (*.otg) documents to a certain folder, lets say c:\temp 2. change the default template path via Extras - Tools - LibreOffice - Paths - Documenttemplates to point to c:\temp 3. open template manager via File - New - Templates... 4. click through each tab and see what templates are shown: you will see all the templates you created *EXCEPT* the template for the spreadsheed With these steps, I can see .ots templates just fine. Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73031] font name and size doesn't update in readonly sections, but stylename does
https://bugs.freedesktop.org/show_bug.cgi?id=73031 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Caolán McNamara from comment #3) Created attachment 106420 [details] sample document that I think reproduces this Assuming I understand the problem correctly, its not specific to master documents. Its that in write protected sections, which master document use, only the style name gets changed when moving around readonly sections. So this can be reproduced in a standalone document Reproduced. Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37315] cropped pictures in .docx file are mangled and in wrong place
https://bugs.freedesktop.org/show_bug.cgi?id=37315 --- Comment #16 from Andrew Ward and...@award.uk --- In LibO 4.3.2.2, when I import a .docx with pictures, each picture is partially obscured by a large white margin at the top of each picture. Nothing I can do with any of the picture properties will fix it. If I copy the contents and paste into a new document, it's absolutely fine. The pictures are correct. If I re-save the original imported document into a new format (eg, .odt), the white margin is still there. So, it's a document property. I hope this is helpful. My first post so if I've done something wrong, please be gentle. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86023] O[U]String needs a 'clear' method ...
https://bugs.freedesktop.org/show_bug.cgi?id=86023 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp TopicCleanup |SkillCpp TopicCleanup ||target:4.4.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86023] O[U]String needs a 'clear' method ...
https://bugs.freedesktop.org/show_bug.cgi?id=86023 --- Comment #6 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Brij Mohan Lal Srivastava committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d32be3ace8c8fd430bbecdf69f88a116b0ee91d1 fdo#86023 - O[U]String needs a 'clear' method It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83982] Saving Draw fluxogram in SVG format lost the math equations
https://bugs.freedesktop.org/show_bug.cgi?id=83982 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- I made a formula x=3 and saved as .svg. Inkscape does not display it. In the .svg, the formula can be seen as: g class=SlideGroup g g id=id1 class=Slide clip-path=url(#presentation_clip_path) g class=Page g class=OLE2 g id=id3desc150/descdesc139/descdesc129/descdesc149/descdesc150/descdesc139/descdesc138/descdesc136/descdesc135/descdesc134/descdesc114/desctspan class=TextPosition y=14748tspan font-family=Liberation Serif, serif font-size=422px font-style=italic font-weight=400 fill=rgb(0,0,0) stroke=nonex/tspandesc140/descdesc139/descdesc138/descdesc136/descdesc135/descdesc134/descdesc114/desctspan font-family=OpenSymbol font-size=422px font-weight=400 fill=rgb(0,0,0) stroke=none=/tspandesc140/descdesc139/descdesc138/descdesc136/descdesc135/descdesc134/descdesc114/desctspan font-family=Liberation Serif, serif font-size=422px font-weight=400 fill=rgb(0,0,0) stroke=none3/tspandesc140/descdesc149/descdesc150/descdesc140/desc/tspan /g /g /g /g /g /g Can you verify that the equations you inserted are in the .svg, but hidden when viewed in a vector editor? Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75167] Tools | Options | LibreOffice Calc | Calculate | Enable Regular Expressions in formulas setting not saved
https://bugs.freedesktop.org/show_bug.cgi?id=75167 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Severity|normal |enhancement --- Comment #6 from Beluga todven...@suomi24.fi --- (In reply to Dave from comment #4) If a user saves a spreadsheet into a XLS format, user must be warned that certain features are contained within the spreadsheet that will be lost as a result of using a different format. There is this warning by default: This document may contain formatting or content that cannot be saved in the currently selected file format “Microsoft Excel 97/2000/XP/2003”. Do you propose to add more information to this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82857] FORMATTING: Formatted text in cell contents not replicated when another cell targets those contents
https://bugs.freedesktop.org/show_bug.cgi?id=82857 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86023] O[U]String needs a 'clear' method ...
https://bugs.freedesktop.org/show_bug.cgi?id=86023 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84042] Adding extension message overlaps other control
https://bugs.freedesktop.org/show_bug.cgi?id=84042 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #2 from Beluga todven...@suomi24.fi --- Does the extension have to be particularly massive to have time to display the message? I tried some 3 meg clipart extensions, but did not see a message. Do you have a sample extension? Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83360] wrong behaviour for svg:viewBox and svg:d in draw:connector
https://bugs.freedesktop.org/show_bug.cgi?id=83360 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- (In reply to t_d_l_c from comment #0) I've attached a file created with calligra flow with a connector that is not connected on one of its ends (calligra_created.odg). In libre office connections like this always end near the top left corner. Reproduced. Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85964] Line numbering size changes when saving as doc/docx
https://bugs.freedesktop.org/show_bug.cgi?id=85964 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- CONFIRMED with LO 4.4.0.0.alpha2 + Ubuntu 14.04 (In reply to A (Andy) from comment #0) The line numbering dot size changes if you save the file as a doc or docx file. Steps to Reproduce: 1. Open WRITER 2. Write any word Walrus (using Liberation Serif 48pt) 3. Select the Bullets On/Off icon in the toolbar at the top to have a line numbering for this word 4. Keep in mind the size of the line numbering dot Yes, it appears very tiny. If I put the cursor by it, the font claims to be OpenSymbol 12pt. 5. Save the file as doc / docx First, I saved it as an ODT and reopened it. 6. Close the file 7. Reopen the saved file Ayup Result: The dot is larger in the doc and docx file. After reopening, the font of the bullet 'dot' still claims to be OpenSymbol 12, but it is now much larger (and proportional to the text on the line). The dot now resizes up/down along with the rest of the text on the line. Same behavior exhibited when saving/reopening in DOC format. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84085] Recent files list opens up slowly if it contains items from a pen drive
https://bugs.freedesktop.org/show_bug.cgi?id=84085 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- What operating system or Linux distro + DE are you using? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66192] Feature: serial letter via PDF export
https://bugs.freedesktop.org/show_bug.cgi?id=66192 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to ben from comment #1) Martin, have you looked into the Mail merge functionality? If you use the wizard (Tools - Mail merge wizard...), in the final step you can save the merged documents and choose PDF as format. Martin: if Mail Merge doesn't provide the functionality you're seeking, please let us know (and change the status back to UNCONFIRMED). Thanks! Status - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80600] PRINTING: Scaling properties not applied when printing xls sheet
https://bugs.freedesktop.org/show_bug.cgi?id=80600 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #3 from Beluga todven...@suomi24.fi --- Works OK, setting to WFM. Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86122] FILEOPEN detects corrupted .ODT file, Repair not working, General Error ..
https://bugs.freedesktop.org/show_bug.cgi?id=86122 --- Comment #34 from joux.al...@wanadoo.fr --- When Opening any .PDF file with LO the file is seen automatically as a drawn type file and is opened without any problem !! So, seems tha the LO OPENING function is failing somewhere for a set of types of file. I have a 16 GB RAM, and a very high speed PC (SSD SAMSUNG 840 PRO 256GB Magician activated system 'drive'), is it a problem ? Any idea ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76592] Password protection in cloud environment
https://bugs.freedesktop.org/show_bug.cgi?id=76592 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added CC||qu...@runcibility.com --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- Created attachment 109451 -- https://bugs.freedesktop.org/attachment.cgi?id=109451action=edit Tiny password-protected ODT file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69998] Other: can't open files with a webdav URL (HTTPS, 502 bad gateway)
https://bugs.freedesktop.org/show_bug.cgi?id=69998 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Whiteboard|BSA |BSA needsWebDAV -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76592] Password protection in cloud environment
https://bugs.freedesktop.org/show_bug.cgi?id=76592 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Herve LECLAIR from comment #0) I have a writer file which is hosted on Google Docs and is password-protected. open it on PC A (password required) open it on PC B; no password required. As I understand it, opening files *from within* Google Docs or Google Drive means that the data is stored, unencrypted, within Google's cloud architecture. ...No more password protection on the file! I tried uploading password-protected ODT attachment 109451 to Google Drive. I couldn't open it from within Drive/Google Docs, and didn't get offered a preview. Herve: How can I reproduce this problem? (Please change status back to UNCONFIRMED after you provide steps to reproduce) Status - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79930] PRINTING: printing preview shows blank page
https://bugs.freedesktop.org/show_bug.cgi?id=79930 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |NOTABUG --- Comment #9 from Beluga todven...@suomi24.fi --- Not a bug, so resolving. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84061] Listeners are not set correctly in SdrTextObj::ImpSetTextStyleSheetListeners
https://bugs.freedesktop.org/show_bug.cgi?id=84061 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |FIXED --- Comment #3 from Beluga todven...@suomi24.fi --- Thanks for the patch, closing this as fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77184] Other: Use of %U option throws an error when launching libreoffice
https://bugs.freedesktop.org/show_bug.cgi?id=77184 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- TESTING with LO 4.2.7-0ubuntu + Ubuntu 14.04 (AMD64) (In reply to jason.wallace from comment #0) Steps to reproduce: 1. Open console 2. Launch any libreoffice application with the %U option What's the %U option? Current behavior: Libreoffice freezes and/or crashes when launched with the %U option FWIW, LibreOffice does seem to freeze/hang if one runs 'libreoffice %U'. Please change the status back to UNCONFIRMED after you explain the intended purpose of the %U switch. Status - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77213] FILESAVE: Frozen converting MHT to DOC
https://bugs.freedesktop.org/show_bug.cgi?id=77213 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Attachment #97100|text/plain |application/x-mimearchive mime type|| CC||qu...@runcibility.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83142] EDITING: Link to inserted Draw object ignored
https://bugs.freedesktop.org/show_bug.cgi?id=83142 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #2 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 64-bit Version: 4.4.0.0.alpha2+ Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85646] LibreOffice Writer crashes 10 times per minute and from debug logs looks like Python initialization problem
https://bugs.freedesktop.org/show_bug.cgi?id=85646 --- Comment #8 from grofaty grof...@hotmail.com --- Now I have analyzed what is different between LibreOffice 4.3.0.0.beta1 and LibreOffice 4.3.0.0.beta2 (last two working versions) and LibreOffice 4.3.0.1 (first crashing version) and I figure it out that beta versions are installing in different directory: LibOfficeDev 4 and non-beta versions are installing in production directories like LIbOffice 4. So I uninstalled LibreOffice beta, delete all programs left overs, delete profile and install LibreOffice 4.3.0.0.beta1 in C:\Programs\LibreOffice4\ directory just like I did install all other 4.3.x or 4.2 versions before. Stunning, if LibreOffice 4.3.0.0.beta1 is installed in C:\Programs\LibreOffice4 directory then it is crashing all over, but if it is installed in C:\Programs\LibreOfficeDev4 then it is not crashing at all. So all of the LibreOffice 4.3.x are now crashing if installed in C:\Programs\LibreOffice4 and also tried back to install LibreOffice 4.2.7.2 in the same directory (uninstalling/cleaning program left oveers/cleaning profile) and it works perfectly well without crashing. Strange, can't explain it rational... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79027] Hyphenation does not work in Calc cells
https://bugs.freedesktop.org/show_bug.cgi?id=79027 Jay Philips philip...@hotmail.com changed: What|Removed |Added CC||c...@nouenoff.nl, ||jmadero@gmail.com, ||lukebe...@hotmail.com Whiteboard||needQAAdvice --- Comment #13 from Jay Philips philip...@hotmail.com --- CCing Cor, Joel and Luke for them to give their opinions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
