[Libreoffice] Building error : Hunk #1 FAILED at 58
Hi, I've just done these steps : git pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download make And here are the error logs : dbaccess-default-varchar-lenght.diff: testing... /home/serval/libreoffice-source/build/patches/dev300/./dbaccess-default-varchar-lenght.diff patch --fuzz=0 -l -p0 -d /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.1 --dry-run patching file dbaccess/source/ui/tabledesign/FieldDescriptions.cxx Hunk #1 FAILED at 58. 1 out of 1 hunk FAILED -- saving rejects to file dbaccess/source/ui/tabledesign/FieldDescriptions.cxx.rej Testing patch dbaccess-default-varchar-lenght.diff failed. at /home/serval/libreoffice-source/build/patches/apply.pl line 98. make: *** [stamp/patch.apply] Erreur 1 Env : Debian testing updated (x86) Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building error : Hunk #1 FAILED at 58
Le 08/10/2010 11:20, Michael Meeks a écrit : Hi Julien, On Thu, 2010-10-07 at 21:41 +0200, julien wrote: I've just done these steps : git pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download You prolly want a: $ bin/g pull -r here - which will update the repositories in clone/ It was just before my eyes and i found this command bin/g quite weird so i had never done it. make Fascinating. If you don't configure --with-distro= it should default to LibreOfficeLinuxDevel - which should apply zero patches. In fact, i read the page http://www.documentfoundation.org/develop/ and never thought about adding with-distro and now i've got this : checking for MINIMUM_REQS... yes not met configure: error: To build LibreOffice on the Mac, you need to have the 10.4u-SDK installed (rerun XCode installer) make: *** [config.status] Erreur 1 whereas i don't have a mac. is there a doc with the different options for with-distro ? (i've got a Debian in testing 32 bits) ... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Building error : Hunk #1 FAILED at 58
Le 08/10/2010 23:10, Christian Lohmaier a écrit : Hi Julien, *, On Fri, Oct 8, 2010 at 10:54 PM, julienserval2...@yahoo.fr wrote: [...] whereas i don't have a mac. is there a doc with the different options for with-distro ? (i've got a Debian in testing 32 bits) No, it was a stupid mistake on my part, pull again I don't know if you made a mistake but now i put all the commands in a 1 line to be sure : git pull -r bin/g pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download make And no more mac error : configure: error: To build LibreOffice on the Mac, you need to have the 10.4u-SDK installed (rerun XCode installer) Thanks to both of you ! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error Building, vcl segmentation fault
Le 10/10/2010 22:31, julien a écrit : Le 10/10/2010 16:33, julien a écrit : Hi, I've just done these steps : make clean git pull -r bni/g pull -r ./autogen.sh --with-git (i removed --disable-kde --disable-kde4 just to test if kde parts are ok, of course i installed kdelibs4-dev ./download make and i've got : Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/util Compiling: vcl/unxlngi6.pro/misc/vcl_dflt_version.c Compiling: vcl/unxlngi6.pro/misc/vclplug_gen_dflt_version.c Compiling: vcl/unxlngi6.pro/misc/vclplug_gtk_dflt_version.c Compiling: vcl/unxlngi6.pro/misc/vclplug_kde_dflt_version.c Compiling: vcl/unxlngi6.pro/misc/desktop_detector_dflt_version.c Making:vcl.lib Making:ipure_x Making:igtk_plug_ Making:ikde_plug_ Making:idet Making:libvclli.so Making:libvclplug_genli.so Making:libvclplug_gtkli.so Making:libvclplug_kdeli.so Segmentation fault dmake: Error code 1, while making '../unxlngi6.pro/lib/libvclplug_kdeli.so' 1 module(s): vcl need(s) to be rebuilt Reason(s): Attention: if you fix the errors in above module(s) you may continue the build issuing the following command: build --all:vcl make: *** [stamp/build] Erreur 1 do i need to add the option with-distro or can i keep on to build like this, without with-distro option in the autogen part ? (I've got a Debian in testing updated) I make again with this : export VERBOSE=TRUE;make and here is what i get : Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/util Making:libvclplug_kdeli.so g++ -L/usr/lib -L/usr/lib -lkdeui -lkdecore -lqt-mt -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-z,defs -Wl,-Bsymbolic-functions -Wl,--dynamic-list-cpp-new -Wl,--dynamic-list-cpp-typeinfo -Wl,--hash-style=both -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib' -shared -L../unxlngi6.pro/lib -L../lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/usr/lib/jvm/java-6-sun/lib -L/usr/lib/jvm/java-6-sun/jre/lib/i386 -L/usr/lib/jvm/java-6-sun/jre/lib/i386/client -L/usr/lib/jvm/java-6-sun/jre/lib/i386/native_threads -L/usr/lib ../unxlngi6.pro/slo/vclplug_kde_dflt_version.o -o ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/slo/kdedata.o ../unxlngi6.pro/slo/salnativewidgets-kde.o -lvclplug_genli -lvclli -ltlli -lvos3gcc3 -luno_sal -Wl,--as-needed -lXext -lX11 -Wl,--no-as-needed -Wl,--as-needed -ldl -lpthread -lm -Wl,--no-as-needed -Wl,-Bdynamic -lstlport_gcc rm -f ../unxlngi6.pro/lib/check_libvclplug_kdeli.so mv ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/lib/check_libvclplug_kdeli.so /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/bin/checkdll.sh -L../unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib ../unxlngi6.pro/lib/check_libvclplug_kdeli.so Checking DLL ../unxlngi6.pro/lib/check_libvclplug_kdeli.so ...Segmentation fault dmake: Error code 1, while making '../unxlngi6.pro/lib/libvclplug_kdeli.so' 1 module(s): vcl need(s) to be rebuilt Reason(s): Attention: if you fix the errors in above module(s) you may continue the build issuing the following command: build --all:vcl I changed the line : $checkdll $@ by gdb $checkdll $@ then : cd home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/ source LinuxX86Env.Set.sh cd vcl build verbose=1 You should get a gdb prompt for checkdll: just enter 'run'. I couldn't do 'thread apply all backtrace' since i had : Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/aqua/source/gdi Nothing to build for GUIBASE unx Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/util Making:libvclplug_kdeli.so g++ -L/usr/lib -L/usr/lib -lkdeui -lkdecore -lqt-mt -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-z,defs -Wl,-Bsymbolic-functions -Wl,--dynamic-list-cpp-new -Wl,--dynamic-list-cpp-typeinfo -Wl,--hash-style=both -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib' -shared -L../unxlngi6.pro/lib -L../lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/usr/lib/jvm/java-6-sun/lib -L/usr/lib/jvm/java-6-sun/jre/lib/i386 -L/usr/lib/jvm/java-6-sun/jre/lib/i386/client -L/usr/lib/jvm/java-6-sun/jre/lib/i386/native_threads -L/usr/lib ../unxlngi6.pro/slo/vclplug_kde_dflt_version.o -o ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/slo/kdedata.o ../unxlngi6.pro/slo/salnativewidgets-kde.o -lvclplug_genli -lvclli -ltlli -lvos3gcc3 -luno_sal -Wl,--as-needed
Re: [Libreoffice] Error Building, vcl segmentation fault
Le 12/10/2010 10:44, Michael Meeks a écrit : On Tue, 2010-10-12 at 08:26 +0200, David Tardon wrote: There is the problem: this line should be gdb --args $checkdll $@ Urk - my problem; you almost got there manually with: On Mon, 2010-10-11 at 23:08 +0200, julien wrote: (gdb) run -s ../unxlngi6.pro/lib/check_libvclplug_kdeli.so Starting program: /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll -s ../unxlngi6.pro/lib/check_libvclplug_kdeli.so [Thread debugging using libthread_db enabled] Program received signal SIGSEGV, Segmentation fault. 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 How tantelising ! :-) this is the crasher - but we really need more symbols :-) - if you had run backtrace at this point we could have got a lot further I think. Having said that - it looks like this may be some horrendous compatibility problem between the internal stlport and the system version - but we'll need to chase that down. Possibly we simply can't use our own stlport if we link KDE, unclear - Lubos: thoughts ? Our internal stlport patches seem to be somewhat insubstantial anyway: mostly portability renames - and a load of SUNPRO stuff that we don't need to care about I think, with a few OS/2 build fixes ;-) Thanks, Michael. Hi, here are the stdout once i replaced $checkdll $@ by gdb --args $checkdll $@ Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/aqua/source/gdi Nothing to build for GUIBASE unx Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/util Making:libvclplug_kdeli.so g++ -L/usr/lib -L/usr/lib -lkdeui -lkdecore -lqt-mt -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-z,defs -Wl,-Bsymbolic-functions -Wl,--dynamic-list-cpp-new -Wl,--dynamic-list-cpp-typeinfo -Wl,--hash-style=both -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib' -shared -L../unxlngi6.pro/lib -L../lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/usr/lib/jvm/java-6-sun/lib -L/usr/lib/jvm/java-6-sun/jre/lib/i386 -L/usr/lib/jvm/java-6-sun/jre/lib/i386/client -L/usr/lib/jvm/java-6-sun/jre/lib/i386/native_threads -L/usr/lib ../unxlngi6.pro/slo/vclplug_kde_dflt_version.o -o ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/slo/kdedata.o ../unxlngi6.pro/slo/salnativewidgets-kde.o -lvclplug_genli -lvclli -ltlli -lvos3gcc3 -luno_sal -Wl,--as-needed -lXext -lX11 -Wl,--no-as-needed -Wl,--as-needed -ldl -lpthread -lm -Wl,--no-as-needed -Wl,-Bdynamic -lstlport_gcc rm -f ../unxlngi6.pro/lib/check_libvclplug_kdeli.so mv ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/lib/check_libvclplug_kdeli.so /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/bin/checkdll.sh -L../unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib ../unxlngi6.pro/lib/check_libvclplug_kdeli.so GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type show copying and show warranty for details. This GDB was configured as i486-linux-gnu. For bug reporting instructions, please see: http://www.gnu.org/software/gdb/bugs/... Reading symbols from /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll...(no debugging symbols found)...done. (gdb) run Starting program: /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll ../unxlngi6.pro/lib/check_libvclplug_kdeli.so [Thread debugging using libthread_db enabled] Checking DLL ../unxlngi6.pro/lib/check_libvclplug_kdeli.so ... Program received signal SIGSEGV, Segmentation fault. 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 (gdb) thread apply all backtrace Thread 1 (Thread 0xb7d276d0 (LWP 7585)): #0 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 #1 0xb67d1414 in _STL::ios_base::ios_base() () from /usr/lib/libstlport_gcc.so.4.6 #2 0xb67e3a41 in _STL::ios_base::_S_initialize() () from /usr/lib/libstlport_gcc.so.4.6 #3 0xb67e3f17 in _STL::ios_base::Init::Init() () from /usr/lib/libstlport_gcc.so.4.6 #4 0xb61e57a1 in global constructors keyed to cascade_mapping.cxx () from /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib/libuno_cppu.so.3 #5 0xb61ecd8d in __do_global_ctors_aux () from /home/serval/libreoffice-source/build/build/libreoffice
Re: [Libreoffice] Error Building, vcl segmentation fault
Le 12/10/2010 22:30, julien a écrit : Le 12/10/2010 10:44, Michael Meeks a écrit : On Tue, 2010-10-12 at 08:26 +0200, David Tardon wrote: There is the problem: this line should be gdb --args $checkdll $@ Urk - my problem; you almost got there manually with: On Mon, 2010-10-11 at 23:08 +0200, julien wrote: (gdb) run -s ../unxlngi6.pro/lib/check_libvclplug_kdeli.so Starting program: /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll -s ../unxlngi6.pro/lib/check_libvclplug_kdeli.so [Thread debugging using libthread_db enabled] Program received signal SIGSEGV, Segmentation fault. 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 How tantelising ! :-) this is the crasher - but we really need more symbols :-) - if you had run backtrace at this point we could have got a lot further I think. Having said that - it looks like this may be some horrendous compatibility problem between the internal stlport and the system version - but we'll need to chase that down. Possibly we simply can't use our own stlport if we link KDE, unclear - Lubos: thoughts ? Our internal stlport patches seem to be somewhat insubstantial anyway: mostly portability renames - and a load of SUNPRO stuff that we don't need to care about I think, with a few OS/2 build fixes ;-) Thanks, Michael. Hi, here are the stdout once i replaced $checkdll $@ by gdb --args $checkdll $@ Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/aqua/source/gdi Nothing to build for GUIBASE unx Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/util Making:libvclplug_kdeli.so g++ -L/usr/lib -L/usr/lib -lkdeui -lkdecore -lqt-mt -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-z,defs -Wl,-Bsymbolic-functions -Wl,--dynamic-list-cpp-new -Wl,--dynamic-list-cpp-typeinfo -Wl,--hash-style=both -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib' -shared -L../unxlngi6.pro/lib -L../lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/usr/lib/jvm/java-6-sun/lib -L/usr/lib/jvm/java-6-sun/jre/lib/i386 -L/usr/lib/jvm/java-6-sun/jre/lib/i386/client -L/usr/lib/jvm/java-6-sun/jre/lib/i386/native_threads -L/usr/lib ../unxlngi6.pro/slo/vclplug_kde_dflt_version.o -o ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/slo/kdedata.o ../unxlngi6.pro/slo/salnativewidgets-kde.o -lvclplug_genli -lvclli -ltlli -lvos3gcc3 -luno_sal -Wl,--as-needed -lXext -lX11 -Wl,--no-as-needed -Wl,--as-needed -ldl -lpthread -lm -Wl,--no-as-needed -Wl,-Bdynamic -lstlport_gcc rm -f ../unxlngi6.pro/lib/check_libvclplug_kdeli.so mv ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/lib/check_libvclplug_kdeli.so /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/bin/checkdll.sh -L../unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib ../unxlngi6.pro/lib/check_libvclplug_kdeli.so GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type show copying and show warranty for details. This GDB was configured as i486-linux-gnu. For bug reporting instructions, please see: http://www.gnu.org/software/gdb/bugs/... Reading symbols from /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll...(no debugging symbols found)...done. (gdb) run Starting program: /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll ../unxlngi6.pro/lib/check_libvclplug_kdeli.so [Thread debugging using libthread_db enabled] Checking DLL ../unxlngi6.pro/lib/check_libvclplug_kdeli.so ... Program received signal SIGSEGV, Segmentation fault. 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 (gdb) thread apply all backtrace Thread 1 (Thread 0xb7d276d0 (LWP 7585)): #0 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 #1 0xb67d1414 in _STL::ios_base::ios_base() () from /usr/lib/libstlport_gcc.so.4.6 #2 0xb67e3a41 in _STL::ios_base::_S_initialize() () from /usr/lib/libstlport_gcc.so.4.6 #3 0xb67e3f17 in _STL::ios_base::Init::Init() () from /usr/lib/libstlport_gcc.so.4.6 #4 0xb61e57a1 in global constructors keyed to cascade_mapping.cxx () from /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib/libuno_cppu.so.3 #5 0xb61ecd8d in __do_global_ctors_aux () from /home/serval/libreoffice-source/build/build/libreoffice
Re: [Libreoffice] Error Building, vcl segmentation fault
Le 12/10/2010 10:44, Michael Meeks a écrit : On Tue, 2010-10-12 at 08:26 +0200, David Tardon wrote: There is the problem: this line should be gdb --args $checkdll $@ Urk - my problem; you almost got there manually with: On Mon, 2010-10-11 at 23:08 +0200, julien wrote: (gdb) run -s ../unxlngi6.pro/lib/check_libvclplug_kdeli.so Starting program: /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll -s ../unxlngi6.pro/lib/check_libvclplug_kdeli.so [Thread debugging using libthread_db enabled] Program received signal SIGSEGV, Segmentation fault. 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 How tantelising ! :-) this is the crasher - but we really need more symbols :-) - if you had run backtrace at this point we could have got a lot further I think. Having said that - it looks like this may be some horrendous compatibility problem between the internal stlport and the system version - but we'll need to chase that down. Possibly we simply can't use our own stlport if we link KDE, unclear - Lubos: thoughts ? Our internal stlport patches seem to be somewhat insubstantial anyway: mostly portability renames - and a load of SUNPRO stuff that we don't need to care about I think, with a few OS/2 build fixes ;-) Thanks, Michael. I did the whole process from scratch to be sure : rm -rf /home/serval/libreoffice/build git clone git://anongit.freedesktop.org/git/libreoffice/build |./autogen.sh --with-git ||./download| |make | then the change of /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/bin/checkdll.sh echo LD_LIBRARY_PATH is $LD_LIBRARY_PATH gdb --args $checkdll $@ when i arrive in gdb : - run then - thread apply all backtrace | and it seems the same : Entering /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/vcl/util Making:libvclplug_kdeli.so g++ -L/usr/lib -L/usr/lib -lkdeui -lkdecore -lqt-mt -Wl,-z,noexecstack -Wl,-z,combreloc -Wl,-z,defs -Wl,-Bsymbolic-functions -Wl,--dynamic-list-cpp-new -Wl,--dynamic-list-cpp-typeinfo -Wl,--hash-style=both -Wl,-rpath,'$ORIGIN:$ORIGIN/../ure-link/lib' -shared -L../unxlngi6.pro/lib -L../lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/unxlngi6/lib -L/usr/lib/jvm/java-6-sun/lib -L/usr/lib/jvm/java-6-sun/jre/lib/i386 -L/usr/lib/jvm/java-6-sun/jre/lib/i386/client -L/usr/lib/jvm/java-6-sun/jre/lib/i386/native_threads -L/usr/lib ../unxlngi6.pro/slo/vclplug_kde_dflt_version.o -o ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/slo/kdedata.o ../unxlngi6.pro/slo/salnativewidgets-kde.o -lvclplug_genli -lvclli -ltlli -lvos3gcc3 -luno_sal -Wl,--as-needed -lXext -lX11 -Wl,--no-as-needed -Wl,--as-needed -ldl -lpthread -lm -Wl,--no-as-needed -Wl,-Bdynamic -lstlport_gcc rm -f ../unxlngi6.pro/lib/check_libvclplug_kdeli.so mv ../unxlngi6.pro/lib/libvclplug_kdeli.so ../unxlngi6.pro/lib/check_libvclplug_kdeli.so /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solenv/bin/checkdll.sh -L../unxlngi6.pro/lib -L/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib ../unxlngi6.pro/lib/check_libvclplug_kdeli.so LD_LIBRARY_PATH is ../unxlngi6.pro/lib:/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or laterhttp://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type show copying and show warranty for details. This GDB was configured as i486-linux-gnu. For bug reporting instructions, please see: http://www.gnu.org/software/gdb/bugs/... Reading symbols from /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll...(no debugging symbols found)...done. (gdb) run Starting program: /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/bin/checkdll ../unxlngi6.pro/lib/check_libvclplug_kdeli.so [Thread debugging using libthread_db enabled] Checking DLL ../unxlngi6.pro/lib/check_libvclplug_kdeli.so ... Program received signal SIGSEGV, Segmentation fault. 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 (gdb) thread apply all backtrace Thread 1 (Thread 0xb7d276d0 (LWP 15195)): #0 0xb68061db in _STL::locale::locale() () from /usr/lib/libstlport_gcc.so.4.6 #1 0xb67d1414 in _STL::ios_base::ios_base() () from /usr/lib/libstlport_gcc.so.4.6 #2 0xb67e3a41 in _STL::ios_base::_S_initialize() () from /usr/lib/libstlport_gcc.so.4.6 #3
[Libreoffice] [FIX] forgot semicolon in svx/source/intro/ooo.src
Hi, Just a quick fix for this file. This contribution is of course under the LGPLv3+. Julien. patch_ooo.src Description: WAIS Source ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Array index at -1
Le 24/10/2010 10:43, Norbert Thiebaud a écrit :
On Sun, Oct 24, 2010 at 3:15 AM, julienserval2...@yahoo.fr wrote:
Hi,
I'm running cppcheck (1.45 from sourceforge since the testing package on
Debian repository is the 1.44 version) the whole project.
And i found these points :
[./build/libreoffice-3.2.99.2/berkeleydb/unxlngi6.pro/misc/build/db-4.7.25.NC/btree/bt_compact.c:1980]:
(error) Array index -1 is out of bounds
=
epg =cp-csp[-1];
[./build/libreoffice-3.2.99.2/berkeleydb/unxlngi6.pro/misc/build/db-4.7.25.NC/btree/bt_delete.c:624]:
(error) Array index -1 is out of bounds
=
for (epg =cp-csp[-1]; epg= cp-sp; epg--) {
Are these bugs false positive or just typos ? I never saw an index to -1 but
i don't know at all C++.
1/ the report is in berkleydb, which is an external library.
So either it is a false positive, or the problem need to be reported
upstream to the berkley db project.
2/ a cursory look at the code lead me to the conculsion that
a/ -1 is hard coded there, and it is used as such in many places in
that source file. It is unlikely a typo or a un-intended pre-compiler
consequences
b/ csp sound like 'current stack pointer' to me... and -1 would make
sens for that kind of object.
So I'd say this is most likely a false positive.
Norbert
Ok, you were right, i didn't know this notation and i found this answer
in a forum (http://bytes.com/topic/c/answers/221640-negative-array-index) :
a[ -1 ] and *(a-1) are identical, the second being what the compiler
converts the first to (already with C89). And yes, you can access
elements of the array also with negative indexes for 'a' as long as
you stay within the limits of the array 'a' is pointing into.
I also read that current version of Berkeley DB was 5.1.9, do we plan to
remove this dependancy or do we stay on the 4.7.25 for the moment as it
could be long to upgrade this library, or something else (like a problem
of license even ethics since it's Oracle) ?
Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Memory leak in ./build/libreoffice-3.2.99.2/libxml2/unxlngi6.pro/misc/build/libxml2-2.7.6/xmlmemory.c
Le 24/10/2010 15:06, Norbert Thiebaud a écrit : On Sun, Oct 24, 2010 at 7:55 AM, julienserval2...@yahoo.fr wrote: Hi, I keep on with cppcheck and i found 3 functions in the this file with a call to malloc without call to free : xmlMallocLoc and xmlMallocAtomicLoc and xmlMemStrdupLoc By the name of it, I would expect these function to do a malloc without a free. I have not looked at the code, but the name imply that these function are meant to allocate memory... there is probalby an xmlFreeLoc function somewhere. Norbert Pff, i was searching only in the code remembering that when there's a malloc, there must be a free somewhere. As it was a malloc on a local variable, i haven't thought about the goal of the functions by looking at their name. You're absolutely right, there's no bug at all. Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build error in desktop::Migration
Hello, Caolan told me via IRC that the hxx has been deleted from repository and he told me about rsync which can't delete that on itself. So just delete the migration.hxx, and the desktop/unxlngi6.pro ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] SAL_N_ELEMENTS for clone/sdk directory
Hello,
Here is a patch for clone/sdk (here again i think there's no more in it).
(LGPLv3+ / MPL)
Julien.
diff --git a/odk/examples/OLE/activex/SOComWindowPeer.cpp
b/odk/examples/OLE/activex/SOComWindowPeer.cpp
index 0b2fabf..1065a1b 100644
--- a/odk/examples/OLE/activex/SOComWindowPeer.cpp
+++ b/odk/examples/OLE/activex/SOComWindowPeer.cpp
@@ -38,6 +38,7 @@
#include stdafx2.h
#include so_activex.h
#include SOComWindowPeer.h
+#include sal/macros.h
/
//
@@ -49,7 +50,7 @@ STDMETHODIMP
SOComWindowPeer::InterfaceSupportsErrorInfo(REFIID riid)
IID_ISOComWindowPeer,
};
-for (int i=0;isizeof(arr)/sizeof(arr[0]);i++)
+for (int i=0;iSAL_N_ELEMENTS(arr);i++)
{
if (InlineIsEqualGUID(*arr[i],riid))
return S_OK;
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] build failure in dbaccess/qa/complex/dbaccess
Hello, I have recompiled the whole project with openjdk 6 and it was ok. However my options to compile are very simple : bin/g pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download make I have openjdk6 and java 6 of sun and with Debian (I've got testing updated), i've configured with update-alternatives javac and java to use openjdk6. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fwd: build failure in dbaccess/qa/complex/dbaccess
Oups, I wanted to respond to the thread opened by Thomas Klausner. Message original Sujet: build failure in dbaccess/qa/complex/dbaccess Date : Thu, 04 Nov 2010 21:13:22 +0100 De :julien serval2...@yahoo.fr Pour : libreoffice@lists.freedesktop.org Hello, I have recompiled the whole project with openjdk 6 and it was ok. However my options to compile are very simple : bin/g pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download make I have openjdk6 and java 6 of sun and with Debian (I've got testing updated), i've configured with update-alternatives javac and java to use openjdk6. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Question about Git
Hello, I've made changes on my repository and now when i type : bin/g pull -r i've got : extensions/source/activex/main/SOActionsApproval.cpp: needs update extensions/source/activex/main/SOComWindowPeer.cpp: needs update extensions/source/activex/main/SODispatchInterceptor.cpp: needs update refusing to pull with rebase: your working tree is not up-to-date I'd like not to commit, to retrieve directly the last versions from the repository. I tried git pull --rebase and i got this : remote: Counting objects: 45, done. remote: Compressing objects: 100% (22/22), done. remote: Total 22 (delta 19), reused 0 (delta 0) Unpacking objects: 100% (22/22), done. From git://anongit.freedesktop.org/git/libreoffice/build d4aebb9..64b35a3 libreoffice-3-3 - origin/libreoffice-3-3 896a77b..1a69901 master - origin/master First, rewinding head to replay your work on top of it... Fast-forwarded master to 1a69901f7e888719f034812838f7841ac86cdfa3. then the same again and i got : Current branch master is up to date. then i try this (found on this url http://wiki.openembedded.net/index.php/GitPhraseBook) : git stash - No local changes to save git pull --rebase - Current branch master is up to date. git stash pop - Nothing to apply It must be quite simple but i don't know git at all. In advance, thanks for your help Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] remove -d from gunzip flags
Hello, It's also possible to replace gunzip by gzip like the other lines of this file : # unpack the Crystal icon set $(MISC)$/crystal.flag : $(CRYSTAL_TARBALL) cd $(MISC) gzip -d -c $(CRYSTAL_TARBALL) | ( tar -xf - ) $(TOUCH) $(@:f) # unpack the Oxygen icon set $(MISC)$/oxygen.flag : $(OXYGEN_TARBALL) cd $(MISC) gzip -d -c $(OXYGEN_TARBALL) | ( tar -xf - ) $(TOUCH) $(@:f) so we'd have : # unpack the classic icon set $(MISC)$/classic.flag : $(CLASSIC_TARBALL) cd $(MISC) gzip -d -c $(CLASSIC_TARBALL) | ( tar -xf - ) $(TOUCH) $(@:f) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for calc\sc\source\filter
Hello, Here is a patch for calc\sc\source\filter Hope i haven't made mistakes, there are 1 or 2 places where i hesitated. (LGPLv3+ / MPL) Julien. RTL_calc_sc_source_filter.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
Le 08/11/2010 14:33, Caolán McNamara a écrit : On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: On Sun, Nov 7, 2010 at 7:00 AM, julienserval2...@yahoo.fr wrote: the if() can only be true if that value is not 0 so here you have a false positive. Julien, could you log a bug against cppcheck itself with this example, including the operator overload information. The cppcheck guys aim for no false positives so that would be helpful for both them and us. C. Hello, It's done now, ticket 2180 on the sourceforge of cpppcheck. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
Le 08/11/2010 21:08, julien a écrit : Le 08/11/2010 14:33, Caolán McNamara a écrit : On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: On Sun, Nov 7, 2010 at 7:00 AM, julienserval2...@yahoo.fr wrote: the if() can only be true if that value is not 0 so here you have a false positive. Julien, could you log a bug against cppcheck itself with this example, including the operator overload information. The cppcheck guys aim for no false positives so that would be helpful for both them and us. C. Hello, It's done now, ticket 2180 on the sourceforge of cpppcheck. Julien. The ticket has been closed since the problem doesn't appear with the last development version. Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx
Hello,
The patch contains only the removing of comments. I haven't removed 1
line of comment because i don't know what Wieder raus mean.
I would have like to remove a warning too since during compilation, I
got this :
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:
In member function 'void sd::DrawViewShell::GetMenuStateSel(SfxItemSet)':
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:301:
warning: declaration of 'rMarkList' shadows a previous local
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:79:
warning: shadowed declaration is here
The lines 79 and 301 contain this :
const SdrMarkList rMarkList = mpDrawView-GetMarkedObjectList();
So i tried on line 301 to remove const SdrMarkList to have this :
rMarkList = mpDrawView-GetMarkedObjectList();
I got this :
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:
In member function 'void sd::DrawViewShell::GetMenuStateSel(SfxItemSet)':
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:301:
error: passing 'const SdrMarkList' as 'this' argument of 'void
SdrMarkList::operator=(const SdrMarkList)' discards qualifiers
Perhaps line 301 is just a bad copy-paste but it would be surprising.
What do you think ?
PS : it seems that there are some comments in german in it which could
be useful to translate.
Julien.
diff --git a/sd/source/ui/view/drviewsj.cxx b/sd/source/ui/view/drviewsj.cxx
index f4fc9d9..1a5fd36 100644
--- a/sd/source/ui/view/drviewsj.cxx
+++ b/sd/source/ui/view/drviewsj.cxx
@@ -98,8 +98,6 @@ void DrawViewShell::GetMenuStateSel( SfxItemSet rSet )
SFX_ITEM_AVAILABLE == rSet.GetItemState( SID_MEASURE_DLG ) ||
SFX_ITEM_AVAILABLE == rSet.GetItemState( SID_CONNECTION_DLG ) ||
SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONNECTION_NEW_ROUTING ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONVERT_TO_3D_LATHE ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONVERT_TO_3D_LATHE_FAST ) ||
SFX_ITEM_AVAILABLE == rSet.GetItemState( SID_OBJECT_SHEAR ) ||
SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONVERT_TO_1BIT_THRESHOLD ) ||
SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONVERT_TO_1BIT_MATRIX ) ||
@@ -160,12 +158,6 @@ void DrawViewShell::GetMenuStateSel( SfxItemSet rSet )
{
rSet.DisableItem(SID_UNGROUP);
}
-/*
-if (!pObj-ISA(SdrObjGroup) !pObj-ISA(SdrGrafObj)
!pObj-ISA(SdrOle2Obj))
-{
-rSet.DisableItem( SID_NAME_GROUP );
-}
-*/
if (!pObj-ISA(SdrGrafObj) ||
((SdrGrafObj*) pObj)-GetGraphicType() != GRAPHIC_BITMAP ||
((SdrGrafObj*) pObj)-IsLinkedGraphic())
@@ -322,8 +314,6 @@ void DrawViewShell::GetMenuStateSel( SfxItemSet rSet )
if(nMarkCount = 2)
rSet.DisableItem(SID_DISTRIBUTE_DLG);
-//rSet.ClearItem( SID_BEZIER_EDIT );
-//rSet.DisableItem( SID_BEZIER_EDIT );
rSet.DisableItem( SID_LINEEND_POLYGON );
rSet.DisableItem( SID_ENTER_GROUP );
// Jetzt (28.10.96) muessen Namen fuer Objekte eindeutig sein
@@ -333,21 +323,6 @@ void DrawViewShell::GetMenuStateSel( SfxItemSet rSet )
rSet.DisableItem( SID_MODIFY_FIELD );
if( 1 )
-// if( SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_ATTR_FILL_STYLE ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState( SID_UNGROUP )
||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_MEASURE_DLG ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONNECTION_DLG ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState( SID_COMBINE )
||
-//SFX_ITEM_AVAILABLE == rSet.GetItemState( SID_OBJECT_SHEAR ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_TEXTATTR_DLG ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONVERT_TO_3D_LATHE ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_CONVERT_TO_3D_LATHE_FAST ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_OBJECT_ALIGN_LEFT ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_OBJECT_ALIGN_CENTER ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_OBJECT_ALIGN_RIGHT ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_OBJECT_ALIGN_UP ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_OBJECT_ALIGN_MIDDLE ) ||
-// SFX_ITEM_AVAILABLE == rSet.GetItemState(
SID_OBJECT_ALIGN_DOWN ) )
{
BOOL bText = FALSE;
BOOL bLine = FALSE;
@@ -509,8 +484,6 @@ void DrawViewShell
[Libreoffice] Suggestion about replacing fgrep instead of grep for the searching of createFromAscii
On the page wiki Easy_Hacks in 2.6, it could be more efficient to indicate to use fgrep instead of grep since it's only a simple string to search. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc_core_data
Hello, Here's a patch for calc/sc/source/core/data I compiled it and it's ok. Hope it's ok ! Julien. (LGPLv3+ / MPL calc_core_data.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] cppcheck : snprintf size is out of bounds
Hello,
I'm currently running the last version of cppcheck (i updated with git
this morning) and i get this error :
snprintf size is out of bounds
ex:
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:542]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:552]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:562]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:590]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:596]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:607]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:653]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:661]: (error)
snprintf size is out of bounds
[./libs-gui/vcl/unx/source/printergfx/common_gfx.cxx:671]: (error)
snprintf size is out of bounds
If i take the first line and i open the file, i see this :
void
PrinterGfx::DrawPolyLineBezier (sal_uInt32 nPoints, const Point* pPath,
const BYTE* pFlgAry)
{
const sal_uInt32 nBezString = 1024;
sal_Char pString[nBezString];
if ( nPoints 1 maLineColor.Is() pPath )
{
PSSetColor (maLineColor);
PSSetColor ();
PSSetLineWidth ();
snprintf(pString, nBezString, %li %li moveto\n, pPath[0].X(),
pPath[0].Y());
I don't understand where's the pb with snprintf, pString has a size of
1024 and snprintf takes a size of 1024.
Is this a false positive to give to the cppcheck guys ?
Julien.
PS : is there a pb with my patch [Libreoffice] [PATCH]
RTL_CONSTASCII_USTRINGPARAM for calc_unoobj ? if it's the case, don't
hesitate to tell me, i'll correct it.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] some cppcheck cleaning in sw + replacement of -exec by xargs
Hello,
Here is a patch for some cppcheck cleaning in sw
Compiling was ok
+ 1 -exec replaced by xargs
Julien
(LGPLv3+ / MPL)
commit 8bce9aee2348d6d34f190b2409390010b9a88e79
Author: Julien Nabet serval2...@yahoo.fr
Date: Sun Jan 9 22:19:39 2011 +0100
Some cppcheck cleaning
diff --git a/sw/source/core/access/accpara.cxx
b/sw/source/core/access/accpara.cxx
index 8a1a24e..f3c2c16 100644
--- a/sw/source/core/access/accpara.cxx
+++ b/sw/source/core/access/accpara.cxx
@@ -2188,7 +2188,7 @@ sal_Bool SwAccessibleParagraph::setAttributes(
{
xPortion-setPropertyValues( aNames, aValues );
}
-catch( UnknownPropertyException e )
+catch( UnknownPropertyException e )
{
// error handling through return code!
bRet = sal_False;
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index d4eaaa2..ed33bc8 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1493,10 +1493,10 @@ void _RestoreCntntIdx(SwDoc* pDoc,
case 0x0800:
case 0x0801:
{
-USHORT nCnt = 0;
SwCrsrShell* pShell = pDoc-GetEditShell();
if( pShell )
{
+USHORT nCnt = 0;
FOREACHSHELL_START( pShell )
SwPaM *_pStkCrsr = PCURSH-GetStkCrsr();
if( _pStkCrsr )
@@ -1653,10 +1653,10 @@ void _RestoreCntntIdx(SvULongs rSaveArr,
case 0x0800:
case 0x0801:
{
-USHORT nCnt = 0;
SwCrsrShell* pShell = pDoc-GetEditShell();
if( pShell )
{
+USHORT nCnt = 0;
FOREACHSHELL_START( pShell )
SwPaM *_pStkCrsr = PCURSH-GetStkCrsr();
if( _pStkCrsr )
diff --git a/sw/source/core/doc/doccomp.cxx b/sw/source/core/doc/doccomp.cxx
index aaf61ab..1100fe6 100644
--- a/sw/source/core/doc/doccomp.cxx
+++ b/sw/source/core/doc/doccomp.cxx
@@ -695,7 +695,6 @@ ULONG Compare::CompareSequence::CheckDiag( ULONG nStt1,
ULONG nEnd1,
for (c = 1;; ++c)
{
long d;/* Active diagonal. */
-long big_snake = 0;
/* Extend the top-down search by an edit step in each diagonal. */
fmin dmin ? pFDiag[--fmin - 1] = -1 : ++fmin;
@@ -713,8 +712,6 @@ ULONG Compare::CompareSequence::CheckDiag( ULONG nStt1,
ULONG nEnd1,
while( ULONG(x) nEnd1 ULONG(y) nEnd2
rMoved1.GetIndex( x ) == rMoved2.GetIndex( y ))
++x, ++y;
-if (x - oldx 20)
-big_snake = 1;
pFDiag[d] = x;
if( odd bmin = d d = bmax pBDiag[d] = pFDiag[d] )
{
@@ -739,8 +736,6 @@ ULONG Compare::CompareSequence::CheckDiag( ULONG nStt1,
ULONG nEnd1,
while( ULONG(x) nStt1 ULONG(y) nStt2
rMoved1.GetIndex( x - 1 ) == rMoved2.GetIndex( y - 1 ))
--x, --y;
-if (oldx - x 20)
-big_snake = 1;
pBDiag[d] = x;
if (!odd fmin = d d = fmax pBDiag[d] = pFDiag[d])
{
diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index 0ebd260..fe203fe 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -2999,11 +2999,11 @@ void SwRedlineExtraData_Format::Reject( SwPaM rPam )
const
int SwRedlineExtraData_Format::operator == ( const SwRedlineExtraData rCmp )
const
{
int nRet = 1;
-USHORT n = 0, nEnd = aWhichIds.Count();
+USHORT nEnd = aWhichIds.Count();
if( nEnd != ((SwRedlineExtraData_Format)rCmp).aWhichIds.Count() )
nRet = 0;
else
-for( ; n nEnd; ++n )
+for(USHORT n=0 ; n nEnd; ++n )
if( ((SwRedlineExtraData_Format)rCmp).aWhichIds[n] !=
aWhichIds[n])
{
nRet = 0;
@@ -3012,8 +3012,6 @@ int SwRedlineExtraData_Format::operator == ( const
SwRedlineExtraData rCmp ) co
return nRet;
}
-/* */
-
SwRedlineData::SwRedlineData( RedlineType_t eT, USHORT nAut )
: pNext( 0 ), pExtraData( 0 ), eType( eT ), nAuthor( nAut ), nSeqNo( 0 )
{
@@ -3066,8 +3064,6 @@ String SwRedlineData::GetDescr() const
return aResult;
}
-/* */
-
SwRedline::SwRedline(RedlineType_t eTyp, const SwPaM rPam )
: SwPaM( *rPam.GetMark(), *rPam.GetPoint() ),
pRedlineData( new SwRedlineData( eTyp, GetDoc()-GetRedlineAuthor() ) ),
diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx
index 7543804..ffd4b9c 100644
--- a/sw/source/core/layout/fly.cxx
+++ b/sw/source/core/layout/fly.cxx
@@ -2712,8 +2712,6 @@ BOOL SwFlyFrm::GetContour( PolyPolygon rContour,
const MapMode aDispMap( MAP_TWIP );
const MapMode aGrfMap( pGrfObj
Re: About coverity 705746 (pormulti.cxx from sw module)
De : Noel Grandin n...@peralex.com
À : julien2412 serval2...@yahoo.fr
Cc : libreoffice@lists.freedesktop.org
Envoyé le : Vendredi 15 mars 2013 10h04
Objet : Re: About coverity 705746 (pormulti.cxx from sw module)
On 2013-03-15 10:30, julien2412 wrote:
Noel Grandin wrote
I would guess that someone meant to move line 742 inside the first if
statement, but only did half the job.
Hello Noël, Perhaps I'm too sleepy this morning but I don't see the interest to
duplicate the new part. Any hint?
I think the code should read:
if( nLeft || nRight )
{
if( !pCurr-GetPortion() )
pCurr-SetPortion( new SwTxtPortion( *pCurr ) );
if( nLeft )
{
SwMarginPortion *pMarg = new SwMarginPortion( 0 );
pMarg-AddPrtWidth( nLeft );
pMarg-SetPortion( pCurr-GetPortion() );
pCurr-SetPortion( pMarg );
}
if( nRight )
{
SwMarginPortion *pMarg = new SwMarginPortion( 0 );
pMarg-AddPrtWidth( nRight );
pCurr-FindLastPortion()-Append( pMarg );
}
}
Disclaimer: http://www.peralex.com/disclaimer.html
Since we have if( nLeft || nRight ), what about:
if( nLeft || nRight )
{
if( !pCurr-GetPortion() )
pCurr-SetPortion( new SwTxtPortion( *pCurr ) );
SwMarginPortion *pMarg = new SwMarginPortion( 0 );
if( nLeft )
{
pMarg-AddPrtWidth( nLeft );
pMarg-SetPortion( pCurr-GetPortion() );
pCurr-SetPortion( pMarg );
}
if( nRight )
{
pMarg-AddPrtWidth( nRight );
pCurr-FindLastPortion()-Append( pMarg );
}
}
If nLeft and nRight are exlusive, it could also just be an if(nLeft)... else...
In both cases, no need to repeat SwMarginPortion *pMarg = new SwMarginPortion(
0 ); since we're sure to be in one of these blocks.
Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] core.git: Revert ...
It allowed me to revert quickly and easily (without rebasing/conflict pb) the
iff commit.
Julien
En date de : Mer 24.6.15, Stephan Bergmann sberg...@redhat.com a écrit :
Objet: Re: [Libreoffice-commits] core.git: Revert ...
À: Julien Nabet serval2...@yahoo.fr
Cc: libreoffice@lists.freedesktop.org
Date: Mercredi 24 juin 2015, 11h49
What was wrong about those two
commits, that required reverting them?
On 06/23/2015 08:43 PM, Julien Nabet wrote:
commit 09b4cbe977c755a447f97034189b85998f358d79
Author: Julien Nabet serval2...@yahoo.fr
Date: Tue Jun 23 20:42:13 2015 +0200
Revert Typo:
repsent-represent
This reverts commit
338161a41d6e01b8e8d8752d9a38cc5c7a63f288.
diff --git
a/bridges/test/java_remote/Bug107753_Test.java
b/bridges/test/java_remote/Bug107753_Test.java
index 8dc4e5f..c83d5f1 100644
--- a/bridges/test/java_remote/Bug107753_Test.java
+++ b/bridges/test/java_remote/Bug107753_Test.java
@@ -32,7 +32,7 @@ import test.lib.TestBed;
*
* pBug #107753# Java UNO: Proxies
should implement intuitive semantics of
* equals and hashCode requests that two
proxies are equal if they represent
- * the same UNO object. This implies that if two
proxies represent the same UNO
+ * the same UNO object. This implies that if two
proxies repsent the same UNO
* object, they must have the same hash
code./p
*/
public final class Bug107753_Test
extends ComplexTestCase {
commit 262dbabe8e07f60d55461ab3fb2c26d37b86a311
Author: Julien Nabet serval2...@yahoo.fr
Date: Tue Jun 23 20:41:33 2015 +0200
Revert Wrong comment with
'sal_True' instead of 'true'
This reverts commit
abd7ad8bff9b1874e3903aa55f33ef887d95096a.
diff --git a/linguistic/source/lngsvcmgr.cxx
b/linguistic/source/lngsvcmgr.cxx
index caa7d09..9b4cc9f 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -1653,7 +1653,7 @@ uno::Sequence lang::Locale
SAL_CALL
static bool IsEqSvcList( const
uno::Sequence OUString rList1,
const
uno::Sequence OUString rList2 )
{
- // returns true if both sequences are
equal
+ // returns sal_True if both sequences
are equal
bool bRes = false;
sal_Int32 nLen =
rList1.getLength();
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Firebird-devel] MacOS build fail "SSE4.2 instruction set not enabled"
I gave a try but had this: lo/lode/dev/core/workdir/UnpackedTarball/firebird/src/common/CRC32C.cpp:41:10: error: always_inline function '_mm_crc32_u8' requires target feature 'sse4.1', but would be inlined into function 'CRC32C' that is compiled without support for 'sse4.1' return _mm_crc32_u8(hash_value, *value); ^ Are you sure msse4 shouldn't be added in CXXFLAGS instead of COMMON_FLAGS? Here's the content of the file prefix.darwin_x86_64 : #DYLD_PRINT_ENV=1 #export DYLD_PRINT_ENV #DYLD_PRINT_LIBRARIES=1 #export DYLD_PRINT_LIBRARIES MACOSX_DEPLOYMENT_TARGET=10.7 export MACOSX_DEPLOYMENT_TARGET PROD_FLAGS=-O1 -DDARWIN -pipe -MMD -fPIC -fno-common DEV_FLAGS=-ggdb -DDARWIN -pipe -MMD -fPIC -fno-omit-frame-pointer -fno-common -Wall -fno-optimize-sibling-calls -Wno-non-virtual-dtor CXXFLAGS:=$(CXXFLAGS) -fvisibility-inlines-hidden -fvisibility=hidden EXE_LINK_OPTIONS:= UNDEF_PLATFORM= LINK_LIBS+=-liconv MATHLIB=-ltommath SO_LINK_LIBS+=-liconv include $(ROOT)/gen/darwin.defaults # This file must be compiled with SSE4.2 support %/CRC32C.o: COMMON_FLAGS += -msse4 Julien En date de : Ven 12.5.17, Alex Peshkoff <peshk...@mail.ru> a écrit : Objet: Re: [Firebird-devel] MacOS build fail "SSE4.2 instruction set not enabled" À: "For discussion among Firebird Developers" <firebird-de...@lists.sourceforge.net>, "Tomaž Vajngerl" <qui...@gmail.com> Cc: "libreoffice-dev" <libreoffice@lists.freedesktop.org>, "julien2412" <serval2...@yahoo.fr> Date: Vendredi 12 mai 2017, 12h08 On 05/12/17 12:05, marius adrian popa wrote: > Known issue in Firebird 3.0.x > > http://firebird.1100200.n4.nabble.com/std-c-11-added-to-CXXFLAGS-in-3-0-on-linux-td4645224.html > > introduced by this commit > > https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d I can't check myself mac issues, but sooner of all attached patch should help. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
About putting back Firebird experimental
Hello, Considering the number of bugs about Firebird migration (see https://bugs.documentfoundation.org/show_bug.cgi?id=116968) and the fact that these bugs may not be trivial to fix (see https://wastack.wordpress.com/2018/07/25/database-migration-in-libreoffice-bug-fixes-and-more/), thought it could be relevant to put Firebird back to experimental or at least stop to propose Firebird migration when opening an odb file with hsqldb embedded. Remark: don't misunderstand me, I'd enjoy to replace HSQLDB to help to remove Java dependency. Also, I know that HSQLDB upgrade has been delayed/cancelled because we had plan to replace it by Firebird but let's face it, I don't think we're ready to propose Firebird widely. Let's not forget there are too few dev experts working on Base part (Lionel + Tamás + Jean-Pierre Ledure for specific Access part). (I'm trying sometimes to work on Base part but most of bugs are too difficult for me and require a good understanding of Base mechanisms). Now perhaps I'm too pessimistic here, so would like your opinion. Any thoughts? Regards, Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: About putting back Firebird experimental
Hi Caolán, Considering all the feedback, I submited https://bugs.documentfoundation.org/show_bug.cgi?id=127180 about putting Migration + propose by default Firebird in experimental. To fullfil this, reverting https://cgit.freedesktop.org/libreoffice/core/commit/?id=8a1a9899e05b0ebbc3ff43f2db242724c8feb18f should respond to the second part. For the first part, I'll take a look at the code pointer you proposed. IMHO it should be in master branch + 6.3 branch. Julien Le jeudi 22 août 2019 à 11:00:01 UTC+2, Caolán McNamara a écrit : On Tue, 2019-08-20 at 14:51 +0200, Alexander Thurgood wrote: > Le 20/08/2019 à 10:28, Julien a écrit : > > Hi Julien, > > +1 from me. > > As a QA triager, I can but agree with Julien given the current stage > of development. The migration code still fails to handle multiple, > basic elements of embedded hsqldb ODB files found in actual use. The last time the firebird issue was brought to the ESC the outcome was this commit[1] to keep the prompt to migrate, but set the default button to "no" and add a link to https://wiki.documentfoundation.org/Documentation/HowTo/MigrateFromHSQLDB The suggestion in the title of the email is about putting firebird as experimental, but is the problem solely (or overwhelmingly) that of the migration process ? Would changing the migration to be experimental, while leaving the default for new databases as firebird, work ? something like restoring a use of SvtMiscOptions::IsExperimentalMode around https://cgit.freedesktop.org/libreoffice/core/tree/dbaccess/source/core/dataaccess/datasource.cxx#n619 [1] https://cgit.freedesktop.org/libreoffice/core/commit/?id=0b2eaf8c9595cc5f91b5d31b770e6f23e3b5b27c ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Impress Remote for IOS (conversion to 64 bits mandatory?)
Hi Jonathan, I don't know if the whole LO is available for ios. In https://www.libreoffice.org/download/download/, I see: Linux (64-bit) (deb), Linux (64-bit) (rpm), MacOs (64-bit), Windows (32-bit), Windows (64-bit) Noticing https://apps.apple.com/fr/app/libreoffice-vanilla/id921923693?mt=12 (sold by Collabora), I suppose LO IOS specific bugs I see in Bugtracker concerns this product from Collabora. However, I was talking about an additional module for LO called "Impress remote" (see https://www.libreoffice.org/download/impress-remote-2/) Regards, Julien Le vendredi 8 novembre 2019 à 14:33:23 UTC+1, Jonathan Aquilina a écrit : Hi Julian, With what I know about ios 13 and mac osx 10.15 they are now fully 64bit. Are 64bit versions of LO for both os's available in 64bit mode or not yet? Regards, Jonathan On 08/11/2019, 11:46, "LibreOffice on behalf of julien2412" wrote: Hello, Following messages about Impress Remote for Android, I wanted to test Impress Remote for IOS on a Ipad and had a message indicating that dev must upgrade. Searching a bit, it seems we must be convert the app to 64 bits. Any thoughts here? Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[RESOLVED] Re: Wrong copy paste in SwFieldFormCheckboxPortion::Format ?
Commented here: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8a82100c8274d3c0e6d8386116fe8c48543fc4c3 Le mardi 19 novembre 2019 à 11:22:49 UTC+1, Julien a écrit : Hi Michael There's no function "GetTextWidth" (or I missed it), so can't do this assertion. See https://opengrok.libreoffice.org/xref/core/sw/source/core/text/portxt.cxx?r=7ade17fd#810 Julien Le mardi 19 novembre 2019 à 11:12:24 UTC+1, Michael Stahl a écrit : On 19.11.19 09:20, Miklos Vajna wrote: > Hi Julien, > > Oh sorry, I didn't realize this pattern is: > > SetWidth(GetHeight()) > SetHeight(GetHeight()) > > I thought it's: > > SetWidth(GetHeight()) > SetHeight(GetWidth()) > > With that in mind, the current code is just OK, the width of the > checkbox portion is the same as its height, since it's a square (and > that size depends on the font size). > > Perhaps add a comment explaining this to make it easier for the next > person to understand. :-) even better: add an assertion that the width and the height are the same, then you'll find out in case your assumption isn't true. assertions are executable documentation :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Wrong copy paste in SwFieldFormCheckboxPortion::Format ?
Hi Michael There's no function "GetTextWidth" (or I missed it), so can't do this assertion. See https://opengrok.libreoffice.org/xref/core/sw/source/core/text/portxt.cxx?r=7ade17fd#810 Julien Le mardi 19 novembre 2019 à 11:12:24 UTC+1, Michael Stahl a écrit : On 19.11.19 09:20, Miklos Vajna wrote: > Hi Julien, > > Oh sorry, I didn't realize this pattern is: > > SetWidth(GetHeight()) > SetHeight(GetHeight()) > > I thought it's: > > SetWidth(GetHeight()) > SetHeight(GetWidth()) > > With that in mind, the current code is just OK, the width of the > checkbox portion is the same as its height, since it's a square (and > that size depends on the font size). > > Perhaps add a comment explaining this to make it easier for the next > person to understand. :-) even better: add an assertion that the width and the height are the same, then you'll find out in case your assumption isn't true. assertions are executable documentation :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
About tdf#129547 and adding COLON
Hello, https://bugs.documentfoundation.org/show_bug.cgi?id=129547 shows that some shortcuts don't work at least with French localization. In French UI some shortcuts need ":" but this character isn't declared in offapi/com/sun/star/awt/Key.idl and at different other locations. Is it possible to add this character? (I can propose a patch about this) Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[RESOLVED] Re: Openssl 1.1.1 support ending in 2023-09-11
With https://cgit.freedesktop.org/libreoffice/core/commit/?id=a539db002bc9ee6692d14cde2aaa166bd213eb51, LO master sources use openssl 3.0.5 Thank you Caolán!
Build failing on Windows when adding "ja" in "with-lang"
Hello, [build CXX] chart2/source/controller/sidebar/ChartSidebarModifyListener.cxx gawk: C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/platform/filter-showIncludes.awk:45: (FILENAME=- FNR=2) warning: Invalid multibyte data detected. There may be a mismatch between your data and your locale Remarque□: inclusion du fichier□: C:\cygwin\home\serva\lode\dev\core\chart2\source\controller\sidebar\ChartSidebarModifyListener.hxx [build CXX] chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx gawk: C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/platform/filter-showIncludes.awk:45: (FILENAME=- FNR=2) warning: Invalid multibyte data detected. There may be a mismatch between your data and your locale Remarque□: inclusion du fichier□: C:\cygwin\home\serva\lode\dev\core\chart2\source\controller\sidebar\ChartSidebarSelectionListener.hxx [build CXX] chart2/source/controller/sidebar/ChartTypePanel.cxx gawk: C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/platform/filter-showIncludes.awk:45: (FILENAME=- FNR=2) warning: Invalid multibyte data detected. There may be a mismatch between your data and your locale Remarque□: inclusion du fichier□: C:\cygwin\home\serva\lode\dev\core\chart2\source\controller\sidebar\ChartTypePanel.hxx ... Trying to reproduce a bug which seems specific to Windows with Japanese UI, I added "ja" in "with-lang" of my autogen.input. But even after a build from scratch, I got: [build CXX] chart2/source/controller/uitest/uiobject.cxx gawk: C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/platform/filter-showIncludes.awk:45: (FILENAME=- FNR=2) warning: Invalid multibyte data detected. There may be a mismatch between your data and your locale Remarque□: inclusion du fichier□: C:\cygwin\home\serva\lode\dev\core\chart2\source\controller\inc\uiobject.hxx Remarque□: inclusion du fichier□: C:\cygwin\home\serva\lode\dev\core\include\vcl/uitest/uiobject.hxx Remarque□: inclusion du fichier□: C:\cygwin\home\serva\lode\dev\core\chart2\source\controller\inc\ObjectHierarchy.hxx [build DEP] LNK:Library/chartcontrollerlo.dll.d [build LNK] Library/chartcontrollerlo.dll gawk: C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/platform/filter-creatingLibrary.awk:31: (FILENAME=- FNR=1) warning: Invalid multibyte data detected. There may be a mismatch between your data and your locale [build CMP] chart2/source/controller/chartcontroller [build BIN] chart2 [build MO ] chartes C:/cygwin/bin/msguniq.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory C:/cygwin/bin/msgfmt.exe: error while loading shared libraries: cygunistring-5.dll: cannot open shared object file: No such file or directory make[1]: *** [C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/AllLangMoTarget.mk:38: C:/cygwin/home/serva/lode/dev/core/workdir/MoTarget/chartes.mo] Error 127 Any idea what to do here? Julien
[Libreoffice] [PATCH] +question RTL_CONSTASCII_USTRINGPARAM for calc_core_tools
Hello, Here's a patch for calc/sc/source/core/tools I compiled it and it's ok. Hope it's ok ! How can we replace createFromAscii in this kind of line : OUString::createFromAscii(aPropNames[i]) Is it possible with another trick than RTL_CONSTASCII_USTRINGPARAM ? Julien. (LGPLv3+ / MPL) calc_core_tools.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc_ui
Hello, Here's a patch for calc/sc/source/ui (except unoobj previously sent). Julien. (LGPLv3+ / MPL) calc_ui.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for calc (datefunc, analysis and solver)
Hello,
Here's a patch for calc
I think it's the last one for calc since i haven't seen other
createFromAscii to remove which concerned litterals.
In datefunc, i tried to use the syntax :
rtl::OUString foo(RTL_CONSTASCII_STRINGPARAM(foo));
-OUString aImpl = OUString::createFromAscii( / );
+OUString aImpl(RTL_CONSTASCII_USTRINGPARAM( / ));
Hope it's ok and there wasn't other i missed.
Julien.
(LGPLv3+ / MPL)
diff --git a/scaddins/source/analysis/analysishelper.cxx
b/scaddins/source/analysis/analysishelper.cxx
index bfebe6d..bf3c0f4 100644
--- a/scaddins/source/analysis/analysishelper.cxx
+++ b/scaddins/source/analysis/analysishelper.cxx
@@ -2850,7 +2850,7 @@ ScaAnyConverter::ScaAnyConverter( const uno::Reference
lang::XMultiServiceFacto
if( xServiceFact.is() )
{
uno::Reference uno::XInterface xInstance =
xServiceFact-createInstance(
-OUString::createFromAscii( com.sun.star.util.NumberFormatter ) );
+OUString(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.util.NumberFormatter )) );
xFormatter = uno::Reference util::XNumberFormatter ( xInstance,
uno::UNO_QUERY );
}
}
diff --git a/scaddins/source/datefunc/datefunc.cxx
b/scaddins/source/datefunc/datefunc.cxx
index 8a4f6a9..e350bc2 100644
--- a/scaddins/source/datefunc/datefunc.cxx
+++ b/scaddins/source/datefunc/datefunc.cxx
@@ -250,9 +250,9 @@ sal_Bool SAL_CALL component_writeInfo(
{
try
{
-OUString aImpl = OUString::createFromAscii( / );
+OUString aImpl(RTL_CONSTASCII_USTRINGPARAM( / ));
aImpl += ScaDateAddIn::getImplementationName_Static();
-aImpl += OUString::createFromAscii( /UNO/SERVICES );
+aImpl += OUString(RTL_CONSTASCII_USTRINGPARAM( /UNO/SERVICES ));
uno::Reference registry::XRegistryKey xNewKey(
reinterpret_cast registry::XRegistryKey* ( pRegistryKey
)-createKey( aImpl ) );
@@ -401,15 +401,15 @@ OUString ScaDateAddIn::GetFuncDescrStr( sal_uInt16
nResId, sal_uInt16 nStrIndex
OUString ScaDateAddIn::getImplementationName_Static()
{
-return OUString::createFromAscii( MY_IMPLNAME );
+return OUString(RTL_CONSTASCII_USTRINGPARAM( MY_IMPLNAME ));
}
uno::Sequence OUString ScaDateAddIn::getSupportedServiceNames_Static()
{
uno::Sequence OUString aRet( 2 );
OUString* pArray = aRet.getArray();
-pArray[0] = OUString::createFromAscii( ADDIN_SERVICE );
-pArray[1] = OUString::createFromAscii( MY_SERVICE );
+pArray[0] = OUString(RTL_CONSTASCII_USTRINGPARAM( ADDIN_SERVICE ));
+pArray[1] = OUString(RTL_CONSTASCII_USTRINGPARAM( MY_SERVICE ));
return aRet;
}
@@ -418,7 +418,7 @@ uno::Sequence OUString
ScaDateAddIn::getSupportedServiceNames_Static()
OUString SAL_CALL ScaDateAddIn::getServiceName() throw( uno::RuntimeException )
{
// name of specific AddIn service
-return OUString::createFromAscii( MY_SERVICE );
+return OUString(RTL_CONSTASCII_USTRINGPARAM( MY_SERVICE ));
}
// XServiceInfo
@@ -711,7 +711,7 @@ sal_Int32 GetNullDate( const uno::Reference
beans::XPropertySet xOptions )
try
{
uno::Any aAny = xOptions-getPropertyValue(
-OUString::createFromAscii( NullDate
) );
+OUString(RTL_CONSTASCII_USTRINGPARAM(
NullDate )) );
util::Date aDate;
if ( aAny = aDate )
return DateToDays( aDate.Day, aDate.Month, aDate.Year );
diff --git a/sccomp/source/solver/solver.cxx b/sccomp/source/solver/solver.cxx
index 380728e..fff803e 100644
--- a/sccomp/source/solver/solver.cxx
+++ b/sccomp/source/solver/solver.cxx
@@ -559,13 +559,13 @@ void SAL_CALL SolverComponent::solve()
throw(uno::RuntimeException)
uno::Sequence OUString SolverComponent_getSupportedServiceNames()
{
uno::Sequence OUString aServiceNames( 1 );
-aServiceNames[ 0 ] = OUString::createFromAscii(
com.sun.star.sheet.Solver );
+aServiceNames[ 0 ] = OUString(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.sheet.Solver ));
return aServiceNames;
}
OUString SolverComponent_getImplementationName()
{
-return OUString::createFromAscii( com.sun.star.comp.Calc.Solver );
+return OUString(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.comp.Calc.Solver ));
}
OUString SAL_CALL SolverComponent::getImplementationName()
throw(uno::RuntimeException)
@@ -614,7 +614,7 @@ extern C
sal_Int32 nPos;
xNewKey = reinterpret_cast registry::XRegistryKey * (
pRegistryKey )-createKey( SolverComponent_getImplementationName() );
-xNewKey = xNewKey-createKey( OUString::createFromAscii(
/UNO/SERVICES ) );
+xNewKey = xNewKey-createKey(
OUString(RTL_CONSTASCII_USTRINGPARAM( /UNO/SERVICES )) );
const uno::Sequence OUString rSNL1 =
SolverComponent_getSupportedServiceNames
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for writer_starmath
Hello,
Here's a small patch as there was only 1 file in the starmath part which
needed modifications.
Julien.
(LGPLv3+ / MPL)
diff --git a/starmath/source/smdetect.cxx b/starmath/source/smdetect.cxx
index a7404eb..8fe1dbd 100644
--- a/starmath/source/smdetect.cxx
+++ b/starmath/source/smdetect.cxx
@@ -468,14 +468,14 @@ UNOSEQUENCE UNOOUSTRING
SmFilterDetect::impl_getStaticSupportedServiceNames()
{
UNOMUTEXGUARD aGuard( UNOMUTEX::getGlobalMutex() );
UNOSEQUENCE UNOOUSTRING seqServiceNames( 1 );
-seqServiceNames.getArray() [0] = UNOOUSTRING::createFromAscii(
com.sun.star.frame.ExtendedTypeDetection );
+seqServiceNames.getArray() [0] = UNOOUSTRING(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.frame.ExtendedTypeDetection ));
return seqServiceNames ;
}
/* Helper for XServiceInfo */
UNOOUSTRING SmFilterDetect::impl_getStaticImplementationName()
{
-return UNOOUSTRING::createFromAscii(
com.sun.star.comp.math.FormatDetector );
+return UNOOUSTRING(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.comp.math.FormatDetector ));
}
/* Helper for registry */
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for impress
Hello, Here's again a small patch for the last changes to do that I've seen in Impress. Julien. (LGPLv3+ / MPL) impress.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] + question RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/source/drivers/adabas/
Hello, Here's a patch (LGPLv3+ / MPL) for libs-core/connectivity/source/drivers/adabas/ Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in the function : ::rtl::OUString OAdabasUser::getPrivilegeString(sal_Int32 nRights) const from the file : connectivity/source/drivers/adabas/Buser.cxx Should'nt there be a block like this for INSERT part (at the beginning of the function) : if(sPrivs.getLength()) sPrivs += ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(,)); ? Julien. connectivity_drivers_adabas.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Error in for libuno_sal.so.3 sal + lots of undefined references
reference to `pthread_mutexattr_setkind_np' mutex.c:(.text+0x1c7): undefined reference to `pthread_mutexattr_destroy' ../unxlngi6.pro/slo/thread.o: In function `osl_setThreadKeyData': thread.c:(.text+0x2f): undefined reference to `pthread_setspecific' ../unxlngi6.pro/slo/thread.o: In function `osl_getThreadTextEncoding': thread.c:(.text+0x61): undefined reference to `pthread_once' thread.c:(.text+0x6d): undefined reference to `pthread_getspecific' ../unxlngi6.pro/slo/thread.o: In function `osl_setThreadTextEncoding': thread.c:(.text+0xad): undefined reference to `pthread_setspecific' ../unxlngi6.pro/slo/thread.o: In function `osl_getThreadKeyData': thread.c:(.text+0xd1): undefined reference to `pthread_getspecific' ../unxlngi6.pro/slo/thread.o: In function `osl_createThreadKey': thread.c:(.text+0xf4): undefined reference to `pthread_key_create' ../unxlngi6.pro/slo/thread.o: In function `osl_thread_init_Impl': thread.c:(.text+0x12a): undefined reference to `pthread_key_create' ../unxlngi6.pro/slo/thread.o: In function `osl_destroyThreadKey': thread.c:(.text+0x184): undefined reference to `pthread_key_delete' ../unxlngi6.pro/slo/thread.o: In function `osl_thread_join_cleanup_Impl': thread.c:(.text+0x49f): undefined reference to `pthread_detach' ../unxlngi6.pro/slo/thread.o: In function `osl_thread_cleanup_Impl': thread.c:(.text+0x628): undefined reference to `pthread_detach' ../unxlngi6.pro/slo/thread.o: In function `osl_thread_create_Impl': thread.c:(.text+0x6d0): undefined reference to `pthread_create' thread.c:(.text+0x724): undefined reference to `__pthread_register_cancel' thread.c:(.text+0x73e): undefined reference to `__pthread_unregister_cancel' ../unxlngi6.pro/slo/thread.o: In function `osl_joinWithThread': thread.c:(.text+0x835): undefined reference to `pthread_detach' thread.c:(.text+0x847): undefined reference to `__pthread_register_cancel' thread.c:(.text+0x853): undefined reference to `pthread_join' thread.c:(.text+0x85a): undefined reference to `__pthread_unregister_cancel' ../unxlngi6.pro/slo/thread.o: In function `osl_scheduleThread': thread.c:(.text+0x8f7): undefined reference to `__pthread_register_cancel' thread.c:(.text+0x90c): undefined reference to `__pthread_unregister_cancel' ../unxlngi6.pro/slo/thread.o: In function `osl_suspendThread': thread.c:(.text+0x9cc): undefined reference to `__pthread_register_cancel' thread.c:(.text+0x9e1): undefined reference to `__pthread_unregister_cancel' ../unxlngi6.pro/slo/thread.o: In function `osl_thread_start_Impl': thread.c:(.text+0xa53): undefined reference to `__pthread_register_cancel' thread.c:(.text+0xaba): undefined reference to `__pthread_register_cancel' thread.c:(.text+0xacf): undefined reference to `__pthread_unregister_cancel' thread.c:(.text+0xb0b): undefined reference to `__pthread_unregister_cancel' ../unxlngi6.pro/slo/signal.o: In function `InitSignal': signal.c:(.text+0x2de): undefined reference to `pthread_sigmask' ../unxlngi6.pro/slo/locale.o: In function `rtl_locale_register': locale.c:(.text+0x49a): undefined reference to `pthread_once' ../unxlngi6.pro/slo/alloc_cache.o: In function `rtl_cache_fini': alloc_cache.c:(.text+0xcde): undefined reference to `pthread_join' ../unxlngi6.pro/slo/alloc_cache.o: In function `rtl_cache_create': alloc_cache.c:(.text+0x10ab): undefined reference to `pthread_once' ../unxlngi6.pro/slo/alloc_cache.o: In function `rtl_cache_once_init': alloc_cache.c:(.text+0x1219): undefined reference to `pthread_create' ../unxlngi6.pro/slo/alloc_arena.o: In function `rtl_arena_create': alloc_arena.c:(.text+0x1255): undefined reference to `pthread_once' collect2: ld returned 1 exit status dmake: Error code 1, while making '../unxlngi6.pro/lib/libuno_sal.so.3' Just before i testwith a long make clean, what do you think ? (here the line i use to update and compile : bin/g pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download make ) Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers/ado
Hello, Here's patch for libs-core/connectivity/drivers/ado Julien. (LGPLv3+ / MPL) libs_core_connectivity_drivers_ado.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error in for libuno_sal.so.3 sal + lots of undefined references
Le 17/11/2010 22:13, Caolán McNamara a écrit : On Wed, 2010-11-17 at 22:03 +0100, Julien Nabet wrote: alloc_arena.c:(.text+0x1255): undefined reference to `pthread_once' Woops, bit of fallout from the Unix GCC .mk merging, try pulling again and see does it work. C. I pulled again then typed rm -rf unxlngi6.pro in the sal directory (i did it though i don't know if it was mandatory) and that's ok now. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers
Hello, Here's patch for the last changes to do that I've seen in libs-core/connectivity/drivers Julien. (LGPLv3+ / MPL) connectivity_source_drivers.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] try to correct some timers in sc + question
Hello,
Here's a try to correct some timers in scmod.cxx.
Here's what I did and why.
1) In IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG )
I just added aSpellTimer.Stop() when there's neither input from keyboard
nor ContinueOnlineSpelling.
+ I changed the function to have 1 return only.
2) In IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG )
I removed all the things with bSpell since it seems that
ContinueOnlineSpelling is managed by SpellTimerHdl
I'd like to add a stop but i'd like first to understand what's the use
of all the SC_IDLE_STEP, SC_IDLE_MAX, nIdleCount...
I repeat, this patch is just a try. If I'm all wrong, sorry for the
noise and please, explain my mistakes.
Julien.
(just in case what I did is ok, license is as usual LGPLv3+ / MPL)
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 1bc98b5..1f164e9 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1912,11 +1912,8 @@ IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG )
BOOL bLinks = pDoc-IdleCheckLinks();
BOOL bWidth = pDoc-IdleCalcTextWidth();
-BOOL bSpell = pDoc-ContinueOnlineSpelling();
-if ( bSpell )
-aSpellTimer.Start(); // da
ist noch was
-bMore = bLinks || bWidth || bSpell;// ueberhaupt
noch was?
+bMore = bLinks || bWidth; // ueberhaupt noch was?
// While calculating a Basic formula, a paint event may have
occured,
// so check the bNeedsRepaint flags for this document's views
@@ -1956,15 +1953,27 @@ IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG )
if ( Application::AnyInput( INPUT_KEYBOARD ) )
{
aSpellTimer.Start();
-return 0; // dann spaeter
wieder...
}
-
-ScDocShell* pDocSh = PTR_CAST( ScDocShell, SfxObjectShell::Current() );
-if ( pDocSh )
+else
{
-ScDocument* pDoc = pDocSh-GetDocument();
-if ( pDoc-ContinueOnlineSpelling() )
-aSpellTimer.Start();
+
+ScDocShell* pDocSh = PTR_CAST( ScDocShell, SfxObjectShell::Current() );
+if ( pDocSh )
+{
+ScDocument* pDoc = pDocSh-GetDocument();
+if ( pDoc-ContinueOnlineSpelling() )
+{
+aSpellTimer.Start();
+}
+else
+{
+aSpellTimer.Stop();
+}
+}
+else
+{
+aSpellTimer.Stop();
+}
}
return 0;
}
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/fpicker
Hello, Here's a patch for libs-core/fpicker Julien. (LGPLv3+ / MPL) libs_core_fpicker.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/framework
Hello, Here's a patch for libs-core/framework Julien. (LGPLv3+ / MPL) diff --git a/framework/source/jobs/jobdata.cxx b/framework/source/jobs/jobdata.cxx index 55cda74..09b2165 100644 --- a/framework/source/jobs/jobdata.cxx +++ b/framework/source/jobs/jobdata.cxx @@ -182,7 +182,7 @@ void JobData::setAlias( const ::rtl::OUString sAlias ) // try to open the configuration set of this job directly and get a property access to it // We open it readonly here ::rtl::OUString sKey; -sKey = ::rtl::OUString::createFromAscii(JOBCFG_ROOT); +sKey = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_ROOT)); sKey += ::utl::wrapConfigurationElementName(m_sAlias); ConfigAccess aConfig(m_xSMGR, sKey); @@ -199,11 +199,11 @@ void JobData::setAlias( const ::rtl::OUString sAlias ) css::uno::Any aValue; // read uno implementation name -aValue = xJobProperties-getPropertyValue(::rtl::OUString::createFromAscii(JOBCFG_PROP_SERVICE)); +aValue = xJobProperties-getPropertyValue(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_PROP_SERVICE))); aValue = m_sService; // read whole argument list -aValue = xJobProperties-getPropertyValue(::rtl::OUString::createFromAscii(JOBCFG_PROP_ARGUMENTS)); +aValue = xJobProperties-getPropertyValue(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_PROP_ARGUMENTS))); css::uno::Reference css::container::XNameAccess xArgumentList; if ( (aValue = xArgumentList) @@ -313,7 +313,7 @@ void JobData::setJobConfig( const css::uno::Sequence css::beans::NamedValue // It doesn nothing here then ... or it change the mode automaticly, if // it was opened using another one before. ::rtl::OUString sKey; -sKey = ::rtl::OUString::createFromAscii(JOBCFG_ROOT); +sKey = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_ROOT)); sKey += ::utl::wrapConfigurationElementName(m_sAlias); ConfigAccess aConfig(m_xSMGR, sKey); @@ -481,11 +481,11 @@ css::uno::Sequence css::beans::NamedValue JobData::getConfig() const lConfig.realloc(2); sal_Int32 i = 0; -lConfig[i].Name = ::rtl::OUString::createFromAscii(PROP_ALIAS); +lConfig[i].Name = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(PROP_ALIAS)); lConfig[i].Value = m_sAlias; ++i; -lConfig[i].Name = ::rtl::OUString::createFromAscii(PROP_SERVICE); +lConfig[i].Name = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(PROP_SERVICE)); lConfig[i].Value = m_sService; ++i; } @@ -556,7 +556,7 @@ void JobData::disableJob() // Convert and write the user timestamp to the configuration. css::uno::Any aValue; aValue = Converter::convert_DateTime2ISO8601(DateTime()); - xPropSet-setPropertyValue(::rtl::OUString::createFromAscii(EVENTCFG_PROP_USERTIME), aValue); + xPropSet-setPropertyValue(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(EVENTCFG_PROP_USERTIME)), aValue); } aConfig.close(); ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/scripting + SAL_N_ELEMENTS (last one ?)
Hello,
Here's a patch for libs-core/scripting + 1 patch for filter_msfilter (I
thought i did it before but i must have deleted it by mistake).
It seems, by reading the result of grep, it's the last SAL_N_ELEMENTS
macro to put in place.
So it would be a task to put in Completed_easy_hacks. Someone to
confirm (or to tell where the last ones are) ?
Julien.
(LGPLv3+ / MPL)
diff --git a/framework/source/jobs/jobdata.cxx
b/framework/source/jobs/jobdata.cxx
index 55cda74..09b2165 100644
--- a/framework/source/jobs/jobdata.cxx
+++ b/framework/source/jobs/jobdata.cxx
@@ -182,7 +182,7 @@ void JobData::setAlias( const ::rtl::OUString sAlias )
// try to open the configuration set of this job directly and get a
property access to it
// We open it readonly here
::rtl::OUString sKey;
-sKey = ::rtl::OUString::createFromAscii(JOBCFG_ROOT);
+sKey = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_ROOT));
sKey += ::utl::wrapConfigurationElementName(m_sAlias);
ConfigAccess aConfig(m_xSMGR, sKey);
@@ -199,11 +199,11 @@ void JobData::setAlias( const ::rtl::OUString sAlias )
css::uno::Any aValue;
// read uno implementation name
-aValue =
xJobProperties-getPropertyValue(::rtl::OUString::createFromAscii(JOBCFG_PROP_SERVICE));
+aValue =
xJobProperties-getPropertyValue(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_PROP_SERVICE)));
aValue = m_sService;
// read whole argument list
-aValue =
xJobProperties-getPropertyValue(::rtl::OUString::createFromAscii(JOBCFG_PROP_ARGUMENTS));
+aValue =
xJobProperties-getPropertyValue(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_PROP_ARGUMENTS)));
css::uno::Reference css::container::XNameAccess xArgumentList;
if (
(aValue = xArgumentList)
@@ -313,7 +313,7 @@ void JobData::setJobConfig( const css::uno::Sequence
css::beans::NamedValue
// It doesn nothing here then ... or it change the mode automaticly, if
// it was opened using another one before.
::rtl::OUString sKey;
-sKey = ::rtl::OUString::createFromAscii(JOBCFG_ROOT);
+sKey = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(JOBCFG_ROOT));
sKey += ::utl::wrapConfigurationElementName(m_sAlias);
ConfigAccess aConfig(m_xSMGR, sKey);
@@ -481,11 +481,11 @@ css::uno::Sequence css::beans::NamedValue
JobData::getConfig() const
lConfig.realloc(2);
sal_Int32 i = 0;
-lConfig[i].Name = ::rtl::OUString::createFromAscii(PROP_ALIAS);
+lConfig[i].Name =
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(PROP_ALIAS));
lConfig[i].Value = m_sAlias;
++i;
-lConfig[i].Name = ::rtl::OUString::createFromAscii(PROP_SERVICE);
+lConfig[i].Name =
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(PROP_SERVICE));
lConfig[i].Value = m_sService;
++i;
}
@@ -556,7 +556,7 @@ void JobData::disableJob()
// Convert and write the user timestamp to the configuration.
css::uno::Any aValue;
aValue = Converter::convert_DateTime2ISO8601(DateTime());
-
xPropSet-setPropertyValue(::rtl::OUString::createFromAscii(EVENTCFG_PROP_USERTIME),
aValue);
+
xPropSet-setPropertyValue(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(EVENTCFG_PROP_USERTIME)),
aValue);
}
aConfig.close();
diff --git a/scripting/source/storage/ScriptSecurityManager.cxx
b/scripting/source/storage/ScriptSecurityManager.cxx
index 6585c96..824ef61 100644
--- a/scripting/source/storage/ScriptSecurityManager.cxx
+++ b/scripting/source/storage/ScriptSecurityManager.cxx
@@ -137,7 +137,7 @@ throw ( RuntimeException )
Reference XInterface xInterface;
Any a = m_xContext-getValueByName(
-OUString::createFromAscii( SCRIPTSTORAGEMANAGER_SERVICE ) );
+OUString(RTL_CONSTASCII_USTRINGPARAM(
SCRIPTSTORAGEMANAGER_SERVICE )) );
if ( sal_False == ( a = xInterface ) )
{
throw RuntimeException(
diff --git a/scripting/source/storage/ScriptStorage.cxx
b/scripting/source/storage/ScriptStorage.cxx
index 0d6109d..ad31efd 100644
--- a/scripting/source/storage/ScriptStorage.cxx
+++ b/scripting/source/storage/ScriptStorage.cxx
@@ -290,8 +290,8 @@ throw ( RuntimeException, Exception )
validateXRef( xSMI, ScriptStorage::create: failed to obtain valid
XExtendedDocumentHandler );
-xStringUri = xStringUri.concat( ::rtl::OUString::createFromAscii(
-SCRIPT_DIR ) );
+xStringUri = xStringUri.concat(
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(
+SCRIPT_DIR )) );
// No Scripts directory - just return
if ( ! m_xSimpleFileAccess-isFolder( xStringUri ) )
@@ -329,7 +329,7 @@ throw ( RuntimeException, Exception )
RTL_TEXTENCODING_ASCII_US ).pData-buffer );
OUString parcelFile = parcelDirs[ j ].concat
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx
Hello, Here's a patch for libs-core/svx Julien. (LGPLv3+ / MPL) libs_core_svx.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper
Hello, Here's a patch for libs-core/vbahelper Julien. (LGPLv3+ / MPL) libs_core_vbahelper.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fwd: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper
Sorry, I just noticed that git diff even on a subdirectory didn't make a diff only on this subdirectory. For example : i made a git diff in clone/libs-core/vbahelper/source but the diff includes the changes i made in clone/libs-core/vbahelper/svx/source and all the others I made today. Sorry again. Julien. Message original Sujet: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper Date : Sun, 21 Nov 2010 21:35:17 +0100 De :Julien Nabet serval2...@yahoo.fr Pour : libreoffice@lists.freedesktop.org Hello, Here's a patch for libs-core/vbahelper Julien. (LGPLv3+ / MPL) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fwd: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper
Sorry, I just noticed that git diff even on a subdirectory didn't make a diff only on this subdirectory. For example : i made a git diff in clone/libs-core/vbahelper/source but the diff includes the changes i made in clone/libs-core/vbahelper/svx/source and all the others I made today. Sorry again. Julien. Message original Sujet: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper Date : Sun, 21 Nov 2010 21:35:17 +0100 De :Julien Nabet serval2...@yahoo.fr Pour : libreoffice@lists.freedesktop.org Hello, Here's a patch for libs-core/vbahelper Julien. (LGPLv3+ / MPL) libs_core_vbahelper.txt.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] RTL_CONSTASCII_USTRINGPARAM for libs-core/svx
Hello, Perhaps a simple table in the wiki to assign oneself a task which is available and its planned deadline could be useful. Julien. Le 22/11/2010 21:59, Joost Eekhoorn a écrit : Hi, I did send my patch to the list and Julien did send his patch just after that. It was pushed this morning by David. It surprises me that it does not happen oftener, because I see no coordination between the people working on RTL_CONSTASCII_USTRINGPARAM. Joost 2010/11/22 Michael Meeks michael.me...@novell.com mailto:michael.me...@novell.com Hi there, On Sun, 2010-11-21 at 17:20 +0100, Julien Nabet wrote: Here's a patch for libs-core/svx It seems someone merged it without replying 'Pushed' ;-) Thanks, Michael. -- michael.me...@novell.com mailto:michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org mailto:LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for components
Hello, Here's a patch for components Julien. (LGPLv3+ / MPL) 0001-RTL-patch.patch.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Git question again
Hello, I'm a little lost with git again now. Yesterday, i made first patches by using : git commit -a git format-patch HEAD~1 Now i do : bin/g pull -r and i got this : = components = usage: git merge-base [-a|--all] commit commit... -a, --all outputs all common ancestors usage: git merge-base [-a|--all] commit commit... -a, --all outputs all common ancestors ... You are not currently on a branch, so I cannot use any 'branch.branchname.merge' in your configuration file. Please specify which remote branch you want to use on the command line and try again (e.g. 'git pull repository refspec'). See git-pull(1) for details. I don't understand why it talks about branch. I don't want to merge anything, i just want to fetch the last version of the main repository. Could anybody help me ? Thanks in advance Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Git question again
Le 24/11/2010 23:03, Miklos Vajna a écrit : On Wed, Nov 24, 2010 at 10:42:58PM +0100, Julien Nabetserval2...@yahoo.fr wrote: Now i do : bin/g pull -r and i got this : = components = usage: git merge-base [-a|--all]commit commit... -a, --all outputs all common ancestors usage: git merge-base [-a|--all]commit commit... -a, --all outputs all common ancestors ... You are not currently on a branch, so I cannot use any It's not obvious for me, either. Maybe you did something else as well what you forgot to mention. :) What is the output of git branch in 'rawbuild/components'? if it's not * master, then use 'git checkout master' to switch to master, then g pull -r should work. Here what i've got : ser...@serval:~/libreoffice-source/build/clone$ git branch * master ser...@serval:~/libreoffice-source/build/clone$ cd components/ ser...@serval:~/libreoffice-source/build/clone/components$ git branch * (no branch) master ser...@serval:~/libreoffice-source/build/clone/components$ cd cui/ ser...@serval:~/libreoffice-source/build/clone/components/cui$ git branch * (no branch) master ser...@serval:~/libreoffice-source/build/clone/components/cui$ cd source/ ser...@serval:~/libreoffice-source/build/clone/components/cui/source$ git branch * (no branch) master ser...@serval:~/libreoffice-source/build/clone/components/cui/source$ cd customize/ ser...@serval:~/libreoffice-source/build/clone/components/cui/source/customize$ git branch * (no branch) master I call git branch on the different subdirectories because i don't know if you can have master at the top level and other branch at another level Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Git question again
Le 24/11/2010 23:14, Miklos Vajna a écrit : On Wed, Nov 24, 2010 at 11:07:51PM +0100, Julien Nabetserval2...@yahoo.fr wrote: Here what i've got : ser...@serval:~/libreoffice-source/build/clone$ git branch * master ser...@serval:~/libreoffice-source/build/clone$ cd components/ ser...@serval:~/libreoffice-source/build/clone/components$ git branch * (no branch) master That's it. Somehow you're not on a branch. I would try: git rebase --abort Under clone/components, and in case it says no rebase is in progress, then just 'git checkout master', and finally re-try bin/g pull -r. NOTE: /clone is part of build.git while /clone/components is components.git. Any directory under components is also part of components.git, so you just get the same output there. Now i have this : ser...@serval:~/libreoffice-source/build/clone/components$ git branch * (no branch) master ser...@serval:~/libreoffice-source/build/clone/components$ git rebase --abort HEAD is now at eb24b6e RTL patch ser...@serval:~/libreoffice-source/build/clone/components$ git checkout master Already on 'master' Your branch and 'origin/master' have diverged, and have 3 and 13 different commit(s) each, respectively. ser...@serval:~/libreoffice-source/build/clone/components$ Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] timers in calc
Message: 3 Date: Wed, 24 Nov 2010 08:39:11 +0100 From: David Tardondtar...@redhat.com Subject: Re: [Libreoffice] timers in calc To: libreoffice@lists.freedesktop.org Message-ID:20101124073910.gh30...@verda-stelo.brq.redhat.com Content-Type: text/plain; charset=iso-8859-1 On Wed, Nov 24, 2010 at 08:14:08AM +0100, Julien Nabet wrote: Le 24/11/2010 08:11, Julien Nabet a ?crit : Date: Tue, 23 Nov 2010 22:20:36 -0500 From: Kohei Yoshidakyosh...@novell.com Subject: Re: [Libreoffice] [PATCH] try to correct some timers in sc + question To:libreoffice@lists.freedesktop.org Message-ID:1290568836.2532.14.ca...@localhost Content-Type: text/plain; charset=UTF-8 Hi Julien, On Sat, 2010-11-20 at 01:19 +0100, Julien Nabet wrote: Hello, Here's a try to correct some timers in scmod.cxx. Here's what I did and why. 1) In IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG ) I just added aSpellTimer.Stop() when there's neither input from keyboard nor ContinueOnlineSpelling. + I changed the function to have 1 return only. 2) In IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG ) I removed all the things with bSpell since it seems that ContinueOnlineSpelling is managed by SpellTimerHdl I'd like to add a stop but i'd like first to understand what's the use of all the SC_IDLE_STEP, SC_IDLE_MAX, nIdleCount... I repeat, this patch is just a try. If I'm all wrong, sorry for the noise and please, explain my mistakes. Well, I applaud your attempt to challenge this rather difficult task, and sorry it took me so long to get back to you. I took a closer look at this issue, and while I don't yet have a complete picture of how this can be fixed, I can at least see that the problem is not with the spell check timer, but the idle timer. The spell check timer itself actually turns itself off rather nicely after it does what it needs. The idle timer, OTOH, keeps on running pretty much forever. I guess my previous comment about the spell check timer may have given you the wrong impression. Sorry about that. So, let's not change the spell check timer since it doesn't look broken, and let's focus on fixing the idle timer itself. Hello, To know how to fix the idle timer I'd like first understand well how it works since it seems to be simpler than idletimer. Could you tell me when and how the spelltimer is stopped ? (I haven't seen where it had a stop). Julien. Hi Julien, a timer is stopped after it expired, unless it's explicitly restarted or unless it's an auto timer (see Timer::ImplTimerCallbackProc in vcl/source/app/timer.cxx). If you look at sc/source/ui/app/scmod.cxx, you see that aSpellTimer is only restared (in SpellTimerHdl) if there is a fresh keyboard input or if spell checking of the whole sheet hasn't been finished yet, but aIdleTimer is restarted (in IdleHandler) unconditionally. HTH, D. Hello David, In fact I misunderstood the timers especially the Stop part because i took example with sd/source/core/drawdoc4.cxx I thought that if Stop wasn't directly called, it couldn't stop, big mistake ! So I read in Timer::ImplTimerCallbackProc of the file vcl/source/app/timer.cxx (pity i know just some words of german since all the comments are in german in it). and i saw a calling of Stop in it. You said that aSpellTimer is only restarted in SpellTimerHdl but i saw line 1915 in the function IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG ) BOOL bSpell = pDoc-ContinueOnlineSpelling(); if ( bSpell ) aSpellTimer.Start();// da ist noch was Is it normal we find a Start calling of aSpellTimer in IMPL_LINK of IdleHandler ? For the rest, i understand that aIdleTimer is always started because of this following line at the end of this same function, there's an unconditionnal : aIdleTimer.Start(); It could help if we had the english translation of german comments (i know there's currently an easy task for this and that it must be quite tedious to translate all the comments) but could someone just translate this ? // ueberhaupt noch was? and above all, this ? // SC_IDLE_COUNT mal mit initialem Timeout, dann hochzaehlen Perhaps just an idea for this timer. If it should be started only if there's something to do, i'd move these lines : aIdleTimer.Start(); return 0; at the end of the block : if ( bMore ) Indeed, the rest just seems a recalculation of the timeout of the handler and perhaps this recalculation must be analysed/rethought/optimized. Of course, it's just a guess and so it has to be checked, tested, etc. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] cppcheck, Memory leak: fallback in shell/source/unix/misc/gnome-open-url.c
Hello, Here's a small patch for shell/source/unix/misc/gnome-open-url.c Julien. (LGPLv3+ / MPL) commit 6b768a031280d0c3ad23624dd3a6470c57395a56 Author: serval ser...@ilapharm.com Date: Thu Nov 25 23:26:39 2010 +0100 correct cppcheck, Memory leak: fallback diff --git a/shell/source/unix/misc/gnome-open-url.c b/shell/source/unix/misc/gnome-open-url.c index 69cd837..9ee106b 100644 --- a/shell/source/unix/misc/gnome-open-url.c +++ b/shell/source/unix/misc/gnome-open-url.c @@ -139,6 +139,7 @@ int main(int argc, char *argv[] ) args[2] = NULL; return execv(fallback, args); } +free(fallback); return -1; } ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] question about cppcheck for libreoffice.boldandbusted.com
Hello, libreoffice.boldandbusted.com is a great idea, but what's the version cppcheck used for libreoffice.boldandbusted.com ? I ask this because cppcheck has sometimes false positives. For example, lately i had opened a tracker (#2235: false Resource leak) and today it's corrected. It could be useful to know the date of the last update at the beginning of the report. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Compilation error
Hello, I use now rawbuild to compile. I updated repositories 2 hours ago and i have this (even after a rm -rf unxlngi6.pro/) I use this to compile : ./autogen.sh --with-num-cpus=1 --without-junit --disable-kde make Must i do a make clean ? ... languages en-US ... ... analyzing files ... ... analyzing files with flag ARCHIVE ... ... analyzing files with flag SUBST_FILENAME ... ... analyzing files with flag SCPZIP_REPLACE ... ... analyzing files with flag PATCH_SO_NAME ... ... analyzing files with flag HIDDEN ... ... creating preregistered services.rdb ... javavm.uno.so javaloader.uno.so stocservices.uno.so ... cleaning the output tree ... ... removing directory /tmp/ooopackaging/i_143241290894341 ... ** ERROR: ERROR: Could not register all components for file services.rdb (gid_Starregistry_Services_Rdb)! in function: create_services_rdb ** ** ERROR: Saved logfile: /home/serval/libreoffice-source/build/clone/bootstrap/instsetoo_native/unxlngi6.pro/LibreOffice/archive/logging/en-US/log_OOO330_en-US.log ** Sat Nov 27 22:46:10 2010 (00:29 min.) dmake: Error code 255, while making 'openoffice_en-US.archive' --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development it seems that the error is inside 'instsetoo_native', please re-run build inside this module to isolate the error and/or test your fix: --- /bin/bash cd /home/serval/libreoffice-source/build/rawbuild source ./LinuxX86Env.Set.sh cd instsetoo_native build when the problem is isolated and fixed exit and re-run 'make' from the top-level sometimes (sadly) it is necessary to rm -Rf unxlngi6.pro in a module. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] question about cppcheck for libreoffice.boldandbusted.com
Hi Jesse I was talking about cppcheck bugtracker. There has been a fix for the tracker #2235, this one has been corrected yesterday. About false positives, i've created 3 trackers on cppcheck for the moment. 2 have been fixed : #2235 i talked about and #2210 which has been corrected by the cppcheck guys the 18/11. It seems like the other one (#2217) has been corrected with other fixes since they didn't reproduce it. Julien. Le 27/11/2010 23:02, some...@boldandbusted.com a écrit : Hi Julien, It is the git version of cppchcek, which I checkout every few days via Portage. If you find false positives, you should let the cppcheck folks know, and they'll remove it or otherwise correct it (or tell you that it isn't a false positive ;) ). Which tracker are you referencing? cppcheck's bugtracker or LO's? I'll bump cppcheck today. Cheers, Jesse Adelman Bold and Busted LLC http://www.boldandbusted.com/ On Sat, 27 Nov 2010 22:44 +0100, Julien Nabetserval2...@yahoo.fr wrote: Hello, libreoffice.boldandbusted.com is a great idea, but what's the version cppcheck used for libreoffice.boldandbusted.com ? I ask this because cppcheck has sometimes false positives. For example, lately i had opened a tracker (#2235: false Resource leak) and today it's corrected. It could be useful to know the date of the last update at the beginning of the report. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report server problem
Hello, I reproduced the segmentation fault with the same file (blibs-gui/vcl/source/helper/canvasbitmap.cxx) by activating enable=all for cppcheck. I made a tracker on cppcheck (#2252 http://sourceforge.net/apps/trac/cppcheck/ticket/2252). Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report server problem
Le 29/11/2010 14:38, Julien Nabet a écrit : Hello, I reproduced the segmentation fault with the same file (blibs-gui/vcl/source/helper/canvasbitmap.cxx) by activating enable=all for cppcheck. I made a tracker on cppcheck (#2252 http://sourceforge.net/apps/trac/cppcheck/ticket/2252). Julien. Hello, Just to say that this tracker is solved now and that another tracker, the #2248: (memory leak : pointer inserted in an object, ex in the file ./libs-gui/svl/source/items/aeitem.cxx). Jesse, could you give another try to it if you have time ? Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Error in autogen.sh of rawbuild : Bad substitution
Hello,
I've runned autogen.sh present in rawbuild and i've got : Bad substitution.
After having added a set -x at the beginning of the script, I found it
was in the function requote, all these lines are ko :
set -- ${@//\'/$q\'$q}# quote inner instances of '
set -- ${@/#/$q} # add ' to start of each param
set -- ${@/%/$q} # add ' to end of each param
After research, I found that it was because these lines correspond to an
extension of the generic shell /bin/sh
So if i use the shebang
#!/bin/bash
instead of
#!/bin/sh
That's ok.
(i haven't tested with the other shells).
I precise I haven't migrated my build system yet so perhaps it's ok now.
Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error in autogen.sh of rawbuild : Bad substitution
Le 02/12/2010 00:19, Jan Holesovsky a écrit :
Hi Julien,
On 2010-12-01 at 23:26 +0100, Julien Nabet wrote:
I've runned autogen.sh present in rawbuild and i've got : Bad substitution.
After having added a set -x at the beginning of the script, I found it
was in the function requote, all these lines are ko :
set -- ${@//\'/$q\'$q}# quote inner instances of '
set -- ${@/#/$q} # add ' to start of each param
set -- ${@/%/$q} # add ' to end of each param
Ah, OK, so I pushed a version that should work even in /bin/sh, can you
please pull try?
Thank you,
Kendy
It works now for me
Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg
Hello,
Here's a small patch for dbaccess/source/ui/dlg
Julien.
(LGPLv3+ / MPL)
commit 611a28b9fbafe37691865c023803a5a0b74b
Author: serval ser...@ilapharm.com
Date: Mon Dec 6 22:36:51 2010 +0100
RTL_CONSTASCII_USTRINGPARAM for ConnectionHelper.cxx
diff --git a/dbaccess/source/ui/dlg/ConnectionHelper.cxx
b/dbaccess/source/ui/dlg/ConnectionHelper.cxx
index a21dff0..c401d28 100644
--- a/dbaccess/source/ui/dlg/ConnectionHelper.cxx
+++ b/dbaccess/source/ui/dlg/ConnectionHelper.cxx
@@ -184,7 +184,7 @@ DBG_NAME(OConnectionHelper)
{
try
{
-::rtl::OUString sFolderPickerService =
::rtl::OUString::createFromAscii(SERVICE_UI_FOLDERPICKER);
+::rtl::OUString sFolderPickerService =
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(SERVICE_UI_FOLDERPICKER));
Reference XFolderPicker
xFolderPicker(m_xORB-createInstance(sFolderPickerService), UNO_QUERY);
if (!xFolderPicker.is())
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Error compilation on sc
Hello, Since today when i compile, i've got this in sc module : Entering /home/serval/libreoffice-source/libo/sc/source/ui/unoobj `../../../unxlngi6.pro/slo/chart2uno.obj' is up to date Entering /home/serval/libreoffice-source/libo/sc/util Making:scalc3c.lib Making:libscli.so : ERROR: /home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/lib/libtkli.so: undefined symbol: _ZN3vcl15ImageRepository9loadImageERKN3rtl8OUStringER8BitmapExb dmake: Error code 1, while making '../unxlngi6.pro/lib/libscli.so' Am i good for a make clean make or is it something else ? (If it could be useful, I can send a file with the result of build with verbose=1) Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] call-catcher / bloat removal
*)dlsym( m_hApp, symName.getStr() );
bridges/source/cpp_uno/gcc3_os2_intel/except.cxx:rtti =
(type_info *)dlsym( hmod, symName.getStr() );
bridges/source/cpp_uno/gcc3_solaris_intel/except.cxx:rtti =
(type_info *)dlsym( m_hApp, symName.getStr() );
bridges/source/cpp_uno/gcc3_solaris_sparc/except.cxx:rtti =
(type_info *)dlsym( m_hApp, symName.getStr() );
pyuno/source/module/pyuno_dlopenwrapper.c:func = (void
(*)())dlsym (h, initpyuno);
sal/osl/unx/module.c:fcnAddr = dlsym(Module, pSymbol);
sal/osl/unx/process_impl.cxx:void * addr = dlsym (RTLD_DEFAULT, main);
= writer =
How to be sure the function isn't called by dlsym ?
For example, must we check if a dlsym on the function AppendContent of
the class chgtrack is called via a function of sal/osl/unx/module.c ?
Julien.
commit 6ac6f2458d5114af29428b94be40034bef636c7b
Author: serval ser...@ilapharm.com
Date: Thu Dec 9 22:44:46 2010 +0100
First try to remove of a call-catcher / bloat removal
diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx
index baef1ae..63a1284 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -2743,24 +2743,6 @@ BOOL ScChangeTrack::IsMatrixFormulaRangeDifferent( const
ScBaseCell* pOldCell,
return nC1 != nC2 || nR1 != nR2;
}
-
-void ScChangeTrack::AppendContent( const ScAddress rPos,
-const String rNewValue, ScBaseCell* pOldCell )
-{
-String aOldValue;
-ScChangeActionContent::GetStringOfCell( aOldValue, pOldCell, pDoc, rPos );
-if ( aOldValue != rNewValue ||
-IsMatrixFormulaRangeDifferent( pOldCell, NULL ) )
-{ // nur wirkliche Aenderung tracken
-ScRange aRange( rPos );
-ScChangeActionContent* pAct = new ScChangeActionContent( aRange );
-pAct-SetOldValue( pOldCell, pDoc, pDoc );
-pAct-SetNewValue( rNewValue, pDoc );
-Append( pAct );
-}
-}
-
-
void ScChangeTrack::AppendContent( const ScAddress rPos,
const ScBaseCell* pOldCell, ULONG nOldFormat, ScDocument* pRefDoc )
{
commit 85f50f62704db5534b6997f596e103b4b1d27068
Author: serval ser...@ilapharm.com
Date: Thu Dec 9 23:26:03 2010 +0100
Remove of the virtual function AppendContent
diff --git a/sc/inc/chgtrack.hxx b/sc/inc/chgtrack.hxx
index e733509..c78b4fc 100644
--- a/sc/inc/chgtrack.hxx
+++ b/sc/inc/chgtrack.hxx
@@ -1248,11 +1248,6 @@ public:
// nicht anders geht (setzen nur String fuer
// NewValue bzw. Formelerzeugung)
-// bevor neuer Wert im Dokument gesetzt wird
-void AppendContent( const ScAddress
rPos,
-const String rNewValue,
-ScBaseCell* pOldCell );
-
SC_DLLPUBLIC voidAppendInsert(
const ScRange );
// pRefDoc may be NULL = no lookup of contents
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Callcatch ScAttrArray::HasLines
Le 10/12/2010 22:13, Julien Nabet a écrit :
Hello,
The function ScAttrArray::HasLines is called in the file
sc/source/core/data/column2.cxx (line 1246).
BOOL ScColumn::IsEmptyBlock(SCROW nStartRow, SCROW nEndRow, bool
bIgnoreNotes) const
{
Rectangle aRect;
if (pAttrArray-HasLines(nStartRow, nEndRow, aRect, TRUE, TRUE))
return FALSE;
...
I missed something or it was just a false positive ?
Julien.
I used this :
http://people.redhat.com/caolanm/callcatcher/DEV300_m87/sc.callcatcher.log,
the link I found on
http://wiki.documentfoundation.org/Development/Easy_Hacks#call-catcher_.2F_bloat_removal
Since, it's DEV300_m87, it's my mistake, at first glance i thought it
was a report from LO git sources like cppcheck.
Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error compilation on sc
Le 09/12/2010 22:42, Julien Nabet a écrit : Hello, Since today when i compile, i've got this in sc module : Entering /home/serval/libreoffice-source/libo/sc/source/ui/unoobj `../../../unxlngi6.pro/slo/chart2uno.obj' is up to date Entering /home/serval/libreoffice-source/libo/sc/util Making:scalc3c.lib Making:libscli.so : ERROR: /home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/lib/libtkli.so: undefined symbol: _ZN3vcl15ImageRepository9loadImageERKN3rtl8OUStringER8BitmapExb dmake: Error code 1, while making '../unxlngi6.pro/lib/libscli.so' Am i good for a make clean make or is it something else ? (If it could be useful, I can send a file with the result of build with verbose=1) Julien. Hello, Thank you ! It's ok now by having done what you said : touch /home/serval/libreoffice-source/libo/toolkit/source/helper/tkresmgr.cxx Now i've got this : Entering /home/serval/libreoffice-source/libo/sc/source/ui/unoobj Making:all_unoobj.dpslo `../../../unxlngi6.pro/slo/chart2uno.obj' is up to date Entering /home/serval/libreoffice-source/libo/sc/util Making:libscli.so : ERROR: /home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/lib/libforuili.so: undefined symbol: _ZN7TabPage16CreateAccessibleEv dmake: Error code 1, while making '../unxlngi6.pro/lib/libscli.so' I didn't find anywhere CreateAccessibleEv How to find the cause of this problem ? Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] call-catcher / bloat removal in sc
Hello, Remove call-catcher / bloat removal with ScBitMaskCompressedArray of sc. Since i've got big problems to compile, this patch must be tested before applying. checking whether the C++ compiler (ccache gcc ) works... no configure: error: installation or configuration problem: C++ compiler cannot create executables. dmake: Error code 1, while making './unxlngi6.pro/misc/build/so_configured_ooo_mozab' --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /home/serval/libreoffice-source/libo/soltools/support ERROR: error 65280 occurred while making /home/serval/libreoffice-source/libo/moz it seems you are using a threaded build, which means that the actual compile error is probably hidden far above, and could be inside any of these other modules: moz please re-run build inside each one to isolate the problem. I tried to compile vcl Julien (LGPLv3+ / MPL) commit cde5d175581ccd7ec388c04aad7454be252da01f Author: serval serval2...@yahoo.fr Date: Sat Dec 11 09:13:41 2010 +0100 Remove callcatcher ScBitMaskCompressedArray diff --git a/sc/inc/compressedarray.hxx b/sc/inc/compressedarray.hxx index c0f8638..e245b23 100644 --- a/sc/inc/compressedarray.hxx +++ b/sc/inc/compressedarray.hxx @@ -466,24 +466,6 @@ public: A nStart, A nEnd, const D rValueToAnd, long nSourceDy = 0 ); -/** Copy values from rArray and bitwise OR them with rValueToOr. */ -voidCopyFromOred( -const ScBitMaskCompressedArray rArray, -A nStart, A nEnd, const D rValueToOr, -long nSourceDy = 0 ); - -/** Return the start row of a region where all entries meet the condition: -((aValue rBitMask) == rMaskedCompare). If not even nEnd meets -this condition, ::std::numeric_limitsA::max() is returned. */ -A GetBitStateStart( A nEnd, const D rBitMask, -const D rMaskedCompare ) const; - -/** Return the end row of a region where all entries meet the condition: -((aValue rBitMask) == rMaskedCompare). If not even nStart meets -this condition, ::std::numeric_limitsA::max() is returned. */ -A GetBitStateEnd( A nStart, const D rBitMask, -const D rMaskedCompare ) const; - /** Return the first row where an entry meets the condition: ((aValue rBitMask) == rMaskedCompare), searching between nStart and nEnd. If no entry meets this condition, ::std::numeric_limitsA::max() @@ -493,39 +475,6 @@ public: const D rMaskedCompare ) const; /** Return the last row where an entry meets the condition: -((aValue rBitMask) == rMaskedCompare), searching between nStart and -nEnd. If no entry meets this condition, ::std::numeric_limitsA::max() -is returned. */ -SC_DLLPUBLIC A GetLastForCondition( A nStart, A nEnd, -const D rBitMask, -const D rMaskedCompare ) const; - -/** Count rows between nStart and nEnd where entries meet the condition: -((aValue rBitMask) == rMaskedCompare) */ -A CountForCondition( A nStart, A nEnd, -const D rBitMask, -const D rMaskedCompare ) const; - -/** Whether there is any entry between nStart and nEnd where the condition -is met: ((aValue rBitMask) == rMaskedCompare) */ -SC_DLLPUBLIC boolHasCondition( A nStart, A nEnd, -const D rBitMask, -const D rMaskedCompare ) const; - -/** Fill an array with row numbers between nStart and nEnd where entries -meet the condition: ((aValue rBitMask) == rMaskedCompare). -@return the count of used elements in array. */ -size_t FillArrayForCondition( A nStart, A nEnd, -const D rBitMask, -const D rMaskedCompare, -A * pArray, size_t nArraySize ) const; - -/** Count rows between nStart and nEnd where entries meet the condition: -((aValue rBitMask) != 0) */ -A CountForAnyBitCondition( A nStart, A nEnd, -const D rBitMask ) const; - -/** Return the last row where an entry meets the condition
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for testtools
Hello,
Here's a patch for testtools
Julien.
(LGPLv3+ / MPL)
commit 454a035958ee250cfc302967d5e936e0c634e746
Author: serval ser...@ilapharm.com
Date: Mon Dec 13 21:36:13 2010 +0100
RTL_CONSTASCII_USTRINGPARAM for testtools
diff --git a/testtools/source/bridgetest/multi.hxx
b/testtools/source/bridgetest/multi.hxx
index f2ac065..5b67a4e 100644
--- a/testtools/source/bridgetest/multi.hxx
+++ b/testtools/source/bridgetest/multi.hxx
@@ -59,7 +59,7 @@ public:
virtual rtl::OUString SAL_CALL fn12(rtl::OUString const arg)
throw (com::sun::star::uno::RuntimeException)
-{ return rtl::OUString::createFromAscii(12) + arg; }
+{ return rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(12)) + arg; }
virtual sal_Int32 SAL_CALL fn21(sal_Int32 arg)
throw (com::sun::star::uno::RuntimeException)
@@ -67,7 +67,7 @@ public:
virtual rtl::OUString SAL_CALL fn22(rtl::OUString const arg)
throw (com::sun::star::uno::RuntimeException)
-{ return rtl::OUString::createFromAscii(22) + arg; }
+{ return rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(22)) + arg; }
virtual double SAL_CALL getatt3()
throw (com::sun::star::uno::RuntimeException)
@@ -83,7 +83,7 @@ public:
virtual rtl::OUString SAL_CALL fn32(rtl::OUString const arg)
throw (com::sun::star::uno::RuntimeException)
-{ return rtl::OUString::createFromAscii(32) + arg; }
+{ return rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(32)) + arg; }
virtual sal_Int32 SAL_CALL fn33()
throw (com::sun::star::uno::RuntimeException)
@@ -99,7 +99,7 @@ public:
virtual rtl::OUString SAL_CALL fn62(rtl::OUString const arg)
throw (com::sun::star::uno::RuntimeException)
-{ return rtl::OUString::createFromAscii(62) + arg; }
+{ return rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(62)) + arg; }
virtual sal_Int32 SAL_CALL fn71(sal_Int32 arg)
throw (com::sun::star::uno::RuntimeException)
@@ -107,7 +107,7 @@ public:
virtual rtl::OUString SAL_CALL fn72(rtl::OUString const arg)
throw (com::sun::star::uno::RuntimeException)
-{ return rtl::OUString::createFromAscii(72) + arg; }
+{ return rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(72)) + arg; }
virtual sal_Int32 SAL_CALL fn73()
throw (com::sun::star::uno::RuntimeException)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Error compilation in vcl module
::parseKey psp::recognize(char*, int)': /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:340: error: expected initializer before '*' token /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:341: error: 'pEntry' was not declared in this scope /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx: At global scope: /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:338: warning: unused parameter 'ident' /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:338: warning: unused parameter 'len' dmake: Error code 1, while making '../../../unxlngi6.pro/slo/parseAFM.obj' Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error compilation in vcl module
Hello Norbert, I had done a ./g pull -r, I did this again 1 hour ago and I still got the same error. (and again, i did a rm -rf unxlng*) In libs-gui, when i make git log, i've got : - last commit : commit 64384c29136df68340bc3cccd2bcf98360b7fb6d Author: Thomas Klausner w...@netbsd.org Date: Thu Dec 16 22:36:46 2010 +0100 Handle NetBSD like the other BSDs in more cases. - the commit you talked about : commit 7758d868da6c4d6f489300bfb517ab3bb7a6dce9 Author: Caolán McNamara caol...@redhat.com Date: Tue Dec 14 09:13:48 2010 + get this to build without errors Perhaps must I do a make clean ? Now my ccache config is ok, it should be quicker to compile ! :-) Julien. Le 16/12/2010 23:39, Norbert Thiebaud a écrit : Julien make sure you have pulled libs-gui:7758d868da6c4d6f489300bfb517ab3bb7a6dce9 Norbert On Thu, Dec 16, 2010 at 3:58 PM, Julien Nabetserval2...@yahoo.fr wrote: Hello, Here the error I get when I compile vcl (i removed unxlng but same result) : Entering /home/serval/libreoffice-source/libo/vcl/unx/gtk/gdi Entering /home/serval/libreoffice-source/libo/vcl/unx/source/fontmanager Compiling: vcl/unx/source/fontmanager/parseAFM.cxx g++ -fmessage-length=0 -c -Os -fno-strict-aliasing -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -I../fontsubset -I/usr/include/freetype2 -I. -I../../../unxlngi6.pro/inc/fontman -I../inc -I../../../inc/pch -I../../../inc -I../../../unx/inc -I../../../unxlngi6.pro/inc -I. -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/external -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc -I/home/serval/libreoffice-source/libo/solenv/unxlngi6/inc -I/home/serval/libreoffice-source/libo/solenv/inc -I/home/serval/libreoffice-source/libo/res -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solenv/inc/Xp31 -I/usr/lib/jvm/java-6-openjdk/include -I/usr/lib/jvm/java-6-openjdk/include/linux -I/usr/lib/jvm/java-6-openjdk/include/native_threads/include -I/usr/include -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/offuh -I. -I../../../res -I. -pipe -mtune=pentiumpro -fvisibility-inlines-hidden -Wall -Wextra -Wendif-labels -Wshadow -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -fpic -DLINUX -DUNX -DVCL -DGCC -DC341 -DINTEL -DGLIBC=2 -D_PTHREADS -D_REENTRANT -DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 -DHAVE_GCC_VISIBILITY_FEATURE -DX86 -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DGXX_INCLUDE_PATH=/usr/include/c++/4.4 -DSUPD=330 -DPRODUCT -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DGSTREAMER -DCUI -DSOLAR_JAVA -DENABLE_FONTCONFIG -DSHAREDLIB -D_DLL_ -fexceptions -fno-enforce-eh-specs -DEXCEPTIONS_ON -o ../../../unxlngi6.pro/slo/parseAFM.o /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx: In function 'psp::parseKey psp::recognize(char*, int)': /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:340: error: expected initializer before '*' token /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:341: error: 'pEntry' was not declared in this scope /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx: At global scope: /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:338: warning: unused parameter 'ident' /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:338: warning: unused parameter 'len' dmake: Error code 1, while making '../../../unxlngi6.pro/slo/parseAFM.obj' Forcing regeneration of dependency info Retrying /home/serval/libreoffice-source/libo/vcl/unx/source/fontmanager Making:all_fontman.dpslo Compiling: vcl/unx/source/fontmanager/parseAFM.cxx g++ -fmessage-length=0 -c -Os -fno-strict-aliasing -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -I../fontsubset -I/usr/include/freetype2 -I. -I../../../unxlngi6.pro/inc/fontman -I../inc -I../../../inc/pch -I../../../inc -I../../../unx/inc -I../../../unxlngi6.pro/inc -I. -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/external -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc -I/home/serval/libreoffice-source/libo/solenv/unxlngi6/inc -I/home/serval/libreoffice-source/libo/solenv/inc -I/home/serval/libreoffice-source/libo/res -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solenv/inc/Xp31 -I/usr/lib/jvm/java-6-openjdk/include -I/usr/lib/jvm/java-6-openjdk/include/linux -I/usr/lib/jvm/java-6-openjdk/include/native_threads/include -I/usr/include -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc
Re: [Libreoffice] Error compilation in vcl module
Hello, After a : ./autogen.sh make clean make it works now ! Thank you ! Next time i'll try to think about ./autogen.sh make before adding make clean Julien Le 17/12/2010 08:14, Julien Nabet a écrit : Hello Norbert, I had done a ./g pull -r, I did this again 1 hour ago and I still got the same error. (and again, i did a rm -rf unxlng*) In libs-gui, when i make git log, i've got : - last commit : commit 64384c29136df68340bc3cccd2bcf98360b7fb6d Author: Thomas Klausner w...@netbsd.org Date: Thu Dec 16 22:36:46 2010 +0100 Handle NetBSD like the other BSDs in more cases. - the commit you talked about : commit 7758d868da6c4d6f489300bfb517ab3bb7a6dce9 Author: Caolán McNamara caol...@redhat.com Date: Tue Dec 14 09:13:48 2010 + get this to build without errors Perhaps must I do a make clean ? Now my ccache config is ok, it should be quicker to compile ! :-) Julien. Le 16/12/2010 23:39, Norbert Thiebaud a écrit : Julien make sure you have pulled libs-gui:7758d868da6c4d6f489300bfb517ab3bb7a6dce9 Norbert On Thu, Dec 16, 2010 at 3:58 PM, Julien Nabetserval2...@yahoo.fr wrote: Hello, Here the error I get when I compile vcl (i removed unxlng but same result) : Entering /home/serval/libreoffice-source/libo/vcl/unx/gtk/gdi Entering /home/serval/libreoffice-source/libo/vcl/unx/source/fontmanager Compiling: vcl/unx/source/fontmanager/parseAFM.cxx g++ -fmessage-length=0 -c -Os -fno-strict-aliasing -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -I../fontsubset -I/usr/include/freetype2 -I. -I../../../unxlngi6.pro/inc/fontman -I../inc -I../../../inc/pch -I../../../inc -I../../../unx/inc -I../../../unxlngi6.pro/inc -I. -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/external -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc -I/home/serval/libreoffice-source/libo/solenv/unxlngi6/inc -I/home/serval/libreoffice-source/libo/solenv/inc -I/home/serval/libreoffice-source/libo/res -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solenv/inc/Xp31 -I/usr/lib/jvm/java-6-openjdk/include -I/usr/lib/jvm/java-6-openjdk/include/linux -I/usr/lib/jvm/java-6-openjdk/include/native_threads/include -I/usr/include -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/offuh -I. -I../../../res -I. -pipe -mtune=pentiumpro -fvisibility-inlines-hidden -Wall -Wextra -Wendif-labels -Wshadow -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -fpic -DLINUX -DUNX -DVCL -DGCC -DC341 -DINTEL -DGLIBC=2 -D_PTHREADS -D_REENTRANT -DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 -DHAVE_GCC_VISIBILITY_FEATURE -DX86 -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DGXX_INCLUDE_PATH=/usr/include/c++/4.4 -DSUPD=330 -DPRODUCT -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DGSTREAMER -DCUI -DSOLAR_JAVA -DENABLE_FONTCONFIG -DSHAREDLIB -D_DLL_ -fexceptions -fno-enforce-eh-specs -DEXCEPTIONS_ON -o ../../../unxlngi6.pro/slo/parseAFM.o /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx: In function 'psp::parseKey psp::recognize(char*, int)': /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:340: error: expected initializer before '*' token /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:341: error: 'pEntry' was not declared in this scope /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx: At global scope: /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:338: warning: unused parameter 'ident' /home/serval/libreoffice-source/libo/clone/libs-gui/vcl/unx/source/fontmanager/parseAFM.cxx:338: warning: unused parameter 'len' dmake: Error code 1, while making '../../../unxlngi6.pro/slo/parseAFM.obj' Forcing regeneration of dependency info Retrying /home/serval/libreoffice-source/libo/vcl/unx/source/fontmanager Making:all_fontman.dpslo Compiling: vcl/unx/source/fontmanager/parseAFM.cxx g++ -fmessage-length=0 -c -Os -fno-strict-aliasing -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -I../fontsubset -I/usr/include/freetype2 -I. -I../../../unxlngi6.pro/inc/fontman -I../inc -I../../../inc/pch -I../../../inc -I../../../unx/inc -I../../../unxlngi6.pro/inc -I. -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/external -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc -I/home/serval/libreoffice-source/libo/solenv/unxlngi6/inc -I/home/serval/libreoffice-source/libo/solenv/inc -I/home/serval/libreoffice-source/libo/res -I/home/serval/libreoffice-source/libo/solver/330/unxlngi6.pro/inc/stl -I/home/serval/libreoffice
[Libreoffice] [Patch] call-catcher / bloat removal in sc module part1
Hello, Remove call-catcher / bloat removal with sc module Compiling sc was ok. Julien (LGPLv3+ / MPL) commit-2680fc0.tar.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM for framework properties
Hello, Here is a patch for properties.h of framework framework compiles ok. Julien. (LGPLv3+ / MPL) commit-d51048d.tar.bz2 Description: application/bzip ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] call-catcher / bloat removal in sc module part1
Le 18/12/2010 19:47, Norbert Thiebaud a écrit : On Sat, Dec 18, 2010 at 2:07 AM, Julien Nabetserval2...@yahoo.fr wrote: Le 18/12/2010 03:28, Norbert Thiebaud a écrit : On Fri, Dec 17, 2010 at 7:34 PM, Julien Nabetserval2...@yahoo.frwrote: Hello, Remove call-catcher / bloat removal with sc module Compiling sc was ok. The .bz2 format means one more obstacle to reviewing it. Norbert Julien (LGPLv3+ / MPL) Hello, I put in this zip the 2 last patches I sent. Just for my information, would the format tar.gz have been an obstacle too ? sorry, I wasn't clear enough: My issue is with the compression, not the type of compression. I can't see compressed attachment 'inline', I need to save them, then uncompress them, then open the content. Norbert No pb, Miklos Vajna had given me these details, so from now i'll sent patches without compressing them. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for writerfilter/source/ooxml/factoryimpl.xsl
Hello,
Here is a patch for writerfilter/source/ooxml/factoryimpl.xsl
(LGPLv3+ / MPL)
Julien.
commit 4f3ac6a823e5592b3596d8edc8b0c0753776b7d3
Author: serval ser...@ilapharm.com
Date: Sun Dec 19 09:48:01 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/writerfilter/source/ooxml/factoryimpl.xsl
b/writerfilter/source/ooxml/factoryimpl.xsl
index 8eecf4a..8945587 100644
--- a/writerfilter/source/ooxml/factoryimpl.xsl
+++ b/writerfilter/source/ooxml/factoryimpl.xsl
@@ -336,8 +336,8 @@ uno::Reference lt; xml::sax::XFastParser gt;
OOXMLStreamImpl::getFastParser()
(mxContext-getServiceManager());
mxFastParser.set(xFactory-createInstanceWithContext
-( ::rtl::OUString::createFromAscii
-( com.sun.star.xml.sax.FastParser ),
+( ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM
+( com.sun.star.xml.sax.FastParser )),
mxContext ), uno::UNO_QUERY_THROW);
/xsl:text
xsl:for-each select=//namespace-alias
@@ -383,4 +383,4 @@ namespace ooxml {
/xsl:text
/xsl:template
-/xsl:stylesheet
\ No newline at end of file
+/xsl:stylesheet
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files
Hello,
Here is a patch for some files
(LGPLv3+ / MPL)
Julien.
commit 492e63b1f62474aaacd6ba08e3a3fac785bc5469
Author: serval serval2...@yahoo.fr
Date: Sun Dec 19 15:45:00 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/toolkit/inc/toolkit/helper/macros.hxx
b/toolkit/inc/toolkit/helper/macros.hxx
index 4e5fa6b..3cde7eb 100644
--- a/toolkit/inc/toolkit/helper/macros.hxx
+++ b/toolkit/inc/toolkit/helper/macros.hxx
@@ -292,7 +292,7 @@ IMPL_LISTENERMULTIPLEXER_LISTENERMETHOD_BODY( ClassName,
InterfaceName, MethodNa
//
-
#define DECLIMPL_SERVICEINFO_DERIVED( ImplName, BaseClass, ServiceName ) \
-::rtl::OUString SAL_CALL getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) { return
::rtl::OUString::createFromAscii( stardiv.Toolkit. #ImplName ); } \
+::rtl::OUString SAL_CALL getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) { return
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( stardiv.Toolkit. #ImplName )); }
\
::com::sun::star::uno::Sequence ::rtl::OUString SAL_CALL
getSupportedServiceNames() throw(::com::sun::star::uno::RuntimeException) \
{ \
::com::sun::star::uno::Sequence
::rtl::OUString aNames = BaseClass::getSupportedServiceNames( ); \
@@ -304,7 +304,7 @@ IMPL_LISTENERMULTIPLEXER_LISTENERMETHOD_BODY( ClassName,
InterfaceName, MethodNa
//
-
#define DECLIMPL_SERVICEINFO( ImplName, ServiceName ) \
-::rtl::OUString SAL_CALL getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) { return
::rtl::OUString::createFromAscii( stardiv.Toolkit. #ImplName ); } \
+::rtl::OUString SAL_CALL getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) { return
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( stardiv.Toolkit. #ImplName )); }
\
::com::sun::star::uno::Sequence ::rtl::OUString SAL_CALL
getSupportedServiceNames() throw(::com::sun::star::uno::RuntimeException) \
{ \
::com::sun::star::uno::Sequence
::rtl::OUString aNames( 1 ); \
diff --git a/toolkit/source/controls/unocontrols.cxx
b/toolkit/source/controls/unocontrols.cxx
index ec3f402..9e82976 100644
--- a/toolkit/source/controls/unocontrols.cxx
+++ b/toolkit/source/controls/unocontrols.cxx
@@ -80,7 +80,7 @@ using ::com::sun::star::uno::Reference;
using namespace ::toolkit;
#define IMPL_SERVICEINFO_DERIVED( ImplName, BaseClass, ServiceName ) \
-::rtl::OUString SAL_CALL ImplName::getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) { return
::rtl::OUString::createFromAscii( stardiv.Toolkit. #ImplName ); } \
+::rtl::OUString SAL_CALL ImplName::getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) { return
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( stardiv.Toolkit. #ImplName )); }
\
::com::sun::star::uno::Sequence ::rtl::OUString SAL_CALL
ImplName::getSupportedServiceNames()
throw(::com::sun::star::uno::RuntimeException)\
{ \
::com::sun::star::uno::Sequence
::rtl::OUString aNames = BaseClass::getSupportedServiceNames( ); \
diff --git a/unotools/source/config/regoptions.cxx
b/unotools/source/config/regoptions.cxx
index f201a84..02cee3c 100644
--- a/unotools/source/config/regoptions.cxx
+++ b/unotools/source/config/regoptions.cxx
@@ -139,7 +139,7 @@ namespace utl
#define DECLARE_STATIC_LAZY_USTRING( name )\
static const ::rtl::OUString lcl_get##name##Name()\
{ \
-static const ::rtl::OUString sName = ::rtl::OUString::createFromAscii(
#name );\
+static const ::rtl::OUString sName =
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( #name ));\
return sName; \
}
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files
Hello,
Here is a patch for some files
(LGPLv3+ / MPL)
Julien
commit 63c58944749de8f44dac979eb4e044e2c08120a8
Author: serval serval2...@yahoo.fr
Date: Tue Dec 21 22:28:50 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/linguistic/source/defs.hxx b/linguistic/source/defs.hxx
index af78449..2ead973 100644
--- a/linguistic/source/defs.hxx
+++ b/linguistic/source/defs.hxx
@@ -41,8 +41,6 @@ class SvStream;
///
-#define A2OU(x)::rtl::OUString::createFromAscii( x )
-
typedef boost::shared_ptr SvStream SvStreamPtr;
namespace css = ::com::sun::star;
diff --git a/linguistic/workben/sprophelp.cxx b/linguistic/workben/sprophelp.cxx
index 4e57cb2..eba4624 100644
--- a/linguistic/workben/sprophelp.cxx
+++ b/linguistic/workben/sprophelp.cxx
@@ -53,7 +53,7 @@ using namespace com::sun::star::linguistic2;
using namespace linguistic;
-#define A2OU(x)::rtl::OUString::createFromAscii( x )
+#define A2OU(x)::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( x ))
///
@@ -70,7 +70,7 @@ PropertyChgHelper::PropertyChgHelper(
OUString *pName = aPropNames.getArray();
for (INT32 i = 0; i nPropCount; ++i)
{
-pName[i] = A2OU( pPropNames[i] );
+pName[i] = ::rtl::OUString::createFromAscii( pPropNames[i] );
}
}
diff --git a/linguistic/workben/sspellimp.hxx b/linguistic/workben/sspellimp.hxx
index 6ad7fe6..ae6655e 100644
--- a/linguistic/workben/sspellimp.hxx
+++ b/linguistic/workben/sspellimp.hxx
@@ -52,9 +52,6 @@ using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::linguistic2;
-
-#define A2OU(x)::rtl::OUString::createFromAscii( x )
-
///
@@ -168,7 +165,7 @@ public:
inline OUString SpellChecker::getImplementationName_Static() throw()
{
-return A2OU( com.sun.star.lingu.examples.SpellChecker );
+return ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.lingu.examples.SpellChecker ));
}
diff --git a/scripting/source/inc/util/util.hxx
b/scripting/source/inc/util/util.hxx
index 442c965..fb3bcb0 100644
--- a/scripting/source/inc/util/util.hxx
+++ b/scripting/source/inc/util/util.hxx
@@ -33,7 +33,7 @@
#include rtl/ustrbuf.hxx
#include osl/diagnose.h
-#define OUSTR(x) ::rtl::OUString( ::rtl::OUString::createFromAscii(x) )
+#define OUSTR(x) ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(x) )
namespace scripting_util
{
@@ -43,7 +43,7 @@ namespace scripting_util
if(!xRef.is())
{
-throw ::com::sun::star::uno::RuntimeException(OUSTR(Msg),
::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface ());
+throw
::com::sun::star::uno::RuntimeException(::rtl::OUString::createFromAscii(Msg),
::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface ());
}
}
}
commit ad010eab30953d6c11c9f6b104e42071dff82978
Author: serval serval2...@yahoo.fr
Date: Tue Dec 21 22:29:27 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/dtrans/source/win32/ftransl/ftransl.cxx
b/dtrans/source/win32/ftransl/ftransl.cxx
index fd7ed18..ec17b05 100644
--- a/dtrans/source/win32/ftransl/ftransl.cxx
+++ b/dtrans/source/win32/ftransl/ftransl.cxx
@@ -58,8 +58,7 @@
#define CPPUTYPE_DEFAULT CPPUTYPE_SEQSALINT8
#define CPPUTYPE_OUSTR getCppuType( (const ::rtl::OUString*)
0 )
#define CPPUTYPE_SALINT32 getCppuType( ( sal_Int32 * ) 0 )
-#define OUSTR( str ) OUString::createFromAscii( #str )
-#define OUSTR_( str ) OUString::createFromAscii( str )
+#define OUSTR( str ) OUString(RTL_CONSTASCII_USTRINGPARAM(
#str ))
#define EMPTY_OUSTR OUString()
const rtl::OUString Windows_FormatName
(RTL_CONSTASCII_USTRINGPARAM(windows_formatname));
diff --git a/i18npool/source/transliteration/transliteration_body.cxx
b/i18npool/source/transliteration/transliteration_body.cxx
index 491932d..03ab018 100644
--- a/i18npool/source/transliteration/transliteration_body.cxx
+++ b/i18npool/source/transliteration/transliteration_body.cxx
@@ -48,8 +48,6 @@ using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::lang;
using namespace ::rtl;
-#define A2OU(x) OUString::createFromAscii(x)
-
namespace com { namespace sun { namespace star { namespace i18n {
diff --git a/svl/source/config/asiancfg.cxx b/svl/source/config/asiancfg.cxx
index 5e169bb..2d3211c 100644
--- a/svl/source/config/asiancfg.cxx
+++ b/svl/source/config/asiancfg.cxx
@@ -45,10 +45,7 @@ using namespace com::sun::star::uno;
using namespace com::sun::star::beans;
using namespace com::sun::star::lang;
-#define C2U(cChar) OUString::createFromAscii(cChar)
-const sal_Char sStartEndCharacters[] = StartEndCharacters
[Libreoffice] Suggestion for Windows building
Hello, I compile LO on Linux but I have a notebook in dualboot with Windows Vista. I'd like to compile on Windows Vista with all the possible modules (Mozilla, NSS, directx, etc.). I read this : http://wiki.documentfoundation.org/Development/Native_Build and of course this : http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies my repository is in : c:\git\libo Here the problems I had (and still have ! :-) ) : 1) Mozilla : after having put the mozilla zips and the contents of the zips in several directories. I read the help in config that talks about an installer on ftp.mozilla.org. I used this after having tried what was in the wiki. Then after having put this : ./autogen.sh --with-mozilla-build=/cygdrive/c/mozilla-build I had this : Building Seamonkey is supported with Mocrisoft Visual Studio 2005 only I've got only Visual Express 2008. I changed the configuration file, but i had other errors, i gave up and used : --disable-mozilla 2) mesa headers not found. I installed all the packages (bin and sources) except demo proposed by cygwin. I searched on Google, nothing. Then I added --without-system-mesa-headers 3) directX DirectX SDK files not found, pleas use --with-direct-home or -disable-directx I installed DirectX and tried by giving the path (/cygdrive/c/program\ files/Microsoft\ DirectX\ SDK\ \(June\ 2010\) or with the short name /cygdrive/c/Progra~1/MI7482~1/ I added with lib at the end, nothing Then I added --disable-directx 4) junit I installed junit4 on Windows, the test install of Junit works. I've got this : cannot find JUnit 4 jar; please install one in the default location (/usr/share/java) So I copied junit.jar of my Windows install in a the new directory I created in Cygwin : /usr/share/java Now it's ok with : NSIS not found, no self contained installer will be build. If anybody who knows the whole process for Windows would have some time to give details in the wiki, it would be great ! If this person has little time, just give some hints please ! :-) Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files part2
Hello,
Here is a patch for some files
(LGPLv3+ / MPL)
Julien
commit 12ed8ec48418ac20a50e8a097e1a5e78f0c99cbb
Author: serval ser...@ilapharm.com
Date: Sun Dec 19 14:46:27 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/forms/source/inc/FormComponent.hxx
b/forms/source/inc/FormComponent.hxx
index 0beb592..8fcb31d 100644
--- a/forms/source/inc/FormComponent.hxx
+++ b/forms/source/inc/FormComponent.hxx
@@ -104,7 +104,7 @@ namespace frm
// old macro for quickly implementing XServiceInfo::getImplementationName
#define IMPLEMENTATION_NAME(ImplName)
\
virtual ::rtl::OUString SAL_CALL getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) \
-{ return
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.comp.forms.) ) +
::rtl::OUString::createFromAscii(#ImplName); }
+{ return
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.comp.forms.) ) +
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#ImplName)); }
class OControlModel;
diff --git a/forms/source/misc/services.cxx b/forms/source/misc/services.cxx
index 844180f..e1beaaf 100644
--- a/forms/source/misc/services.cxx
+++ b/forms/source/misc/services.cxx
@@ -134,7 +134,7 @@ void registerClassInfo(
//...
#define REGISTER_CLASS_CORE(classImplName) \
registerClassInfo( \
-::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.form.) ) +
::rtl::OUString::createFromAscii(#classImplName), \
+::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.form.) ) +
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#classImplName)), \
aServices, \
frm::classImplName##_CreateInstance)
@@ -276,7 +276,7 @@ void ensureClassInfos()
// = XForms core
#define REGISTER_XFORMS_CLASS(name) \
aServices.realloc(1); \
-aServices.getArray()[0] = rtl::OUString::createFromAscii(
com.sun.star.xforms. #name ); \
+aServices.getArray()[0] = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.xforms. #name )); \
REGISTER_CLASS_CORE(name)
REGISTER_XFORMS_CLASS(Model);
commit cf2811221528d3c8000951c8a3ecbd92918b58fe
Author: serval serval2...@yahoo.fr
Date: Sun Dec 19 15:37:23 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/binfilter/bf_forms/source/component/FormComponent.hxx
b/binfilter/bf_forms/source/component/FormComponent.hxx
index c6fa47c..599fb06 100644
--- a/binfilter/bf_forms/source/component/FormComponent.hxx
+++ b/binfilter/bf_forms/source/component/FormComponent.hxx
@@ -69,7 +69,7 @@ const sal_Int16 FRM_DEFAULT_TABINDEX = 0;
// macro for quickly implementing XServiceInfo::getImplementationName
#define IMPLEMENTATION_NAME(ImplName)
\
virtual ::rtl::OUString SAL_CALL getImplementationName( )
throw(::com::sun::star::uno::RuntimeException) \
-{ return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.comp.forms. )) + ::rtl::OUString::createFromAscii(#ImplName); }
+{ return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
com.sun.star.comp.forms. )) +
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#ImplName)); }
// macro for overriding the getInfoServive method of
OAggregationArrayUsageHelper
#define IMPLEMENT_INFO_SERVICE() \
diff --git a/binfilter/bf_forms/source/misc/forms_services.cxx
b/binfilter/bf_forms/source/misc/forms_services.cxx
index 844ee6f..fafc36e 100644
--- a/binfilter/bf_forms/source/misc/forms_services.cxx
+++ b/binfilter/bf_forms/source/misc/forms_services.cxx
@@ -303,7 +303,7 @@ void registerClassInfo(
//...
#define REGISTER_CLASS_CORE(classImplName) \
registerClassInfo( \
-::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( com.sun.star.form. ))
+ ::rtl::OUString::createFromAscii(#classImplName), \
+::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( com.sun.star.form. ))
+ ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(#classImplName)), \
aServices, \
frm::classImplName##_CreateInstance)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] RTL_CONSTASCII_USTRINGPARAM for some files part 3
Hello,
Here is a patch for some files.
(LGPLv3+ / MPL)
Caolán: there's still this :
writer/sw/inc/unomid.h:#define C2U(cChar)
rtl::OUString::createFromAscii( cChar )
There a lot of files that use this macro.
Could you give details about this part of your last message ? (how do
you do this)
after passing a build with the SAL_N_ELEMENTS
as compile-time test
Thank you in advance.
Julien
commit 5576e38145fc8a4f34e3a435986e9b562ac2a49b
Author: serval serval2...@yahoo.fr
Date: Wed Dec 22 22:14:03 2010 +0100
RTL_CONSTASCII_USTRINGPARAM
diff --git a/linguistic/inc/misc.hxx b/linguistic/inc/misc.hxx
index e28a4f1..5853e81 100644
--- a/linguistic/inc/misc.hxx
+++ b/linguistic/inc/misc.hxx
@@ -77,7 +77,7 @@ namespace linguistic
{
// ascii to OUString conversion
-#define A2OU(x) ::rtl::OUString::createFromAscii( x )
+#define A2OU(x) ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( x ))
/// Flags to be used with the multi-path related functions
/// @see GetDictionaryPaths, GetLinguisticPaths
diff --git a/linguistic/source/iprcache.cxx b/linguistic/source/iprcache.cxx
index f831505..185e1e7 100644
--- a/linguistic/source/iprcache.cxx
+++ b/linguistic/source/iprcache.cxx
@@ -100,7 +100,7 @@ static void lcl_AddAsPropertyChangeListener(
for (int i = 0; i NUM_FLUSH_PROPS; ++i)
{
rPropSet-addPropertyChangeListener(
-A2OU(aFlushProperties[i].pPropName), xListener );
+
::rtl::OUString::createFromAscii(aFlushProperties[i].pPropName), xListener );
}
}
}
@@ -115,7 +115,7 @@ static void lcl_RemoveAsPropertyChangeListener(
for (int i = 0; i NUM_FLUSH_PROPS; ++i)
{
rPropSet-removePropertyChangeListener(
-A2OU(aFlushProperties[i].pPropName), xListener );
+
::rtl::OUString::createFromAscii(aFlushProperties[i].pPropName), xListener );
}
}
}
diff --git a/linguistic/source/lngprophelp.cxx
b/linguistic/source/lngprophelp.cxx
index 5ccd55c..5a81077 100644
--- a/linguistic/source/lngprophelp.cxx
+++ b/linguistic/source/lngprophelp.cxx
@@ -82,7 +82,7 @@ PropertyChgHelper::PropertyChgHelper(
OUString *pName = aPropNames.getArray();
for (INT32 i = 0; i nCHCount; ++i)
{
-pName[i] = A2OU( aCH[i] );
+pName[i] = ::rtl::OUString::createFromAscii( aCH[i] );
}
SetDefaultValues();
@@ -119,7 +119,8 @@ void PropertyChgHelper::AddPropNames( const char
*pNewNames[], INT32 nCount )
OUString *pName = GetPropNames().getArray();
for (INT32 i = 0; i nCount; ++i)
{
-pName[ nLen + i ] = A2OU( pNewNames[ i ] );
+pName[ nLen + i ] = ::rtl::OUString::createFromAscii( pNewNames[ i
] );
+
}
}
}
diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index 4b32b4d..a46918c 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -1653,7 +1653,7 @@ BOOL LngSvcMgr::SaveCfgSvcs( const String rServiceName )
{
DBG_ASSERT( 0, node name missing );
}
-OUString aNodeName( A2OU(pNodeName) );
+OUString aNodeName( ::rtl::OUString::createFromAscii(pNodeName) );
for (INT32 i = 0; i nLen; ++i)
{
diff --git a/linguistic/source/misc.cxx b/linguistic/source/misc.cxx
index edfdaac..a107d7f 100644
--- a/linguistic/source/misc.cxx
+++ b/linguistic/source/misc.cxx
@@ -892,7 +892,7 @@ uno::Reference XInterface GetOneInstanceService( const
char *pServiceName )
{
try
{
-xRef = xMgr-createInstance( A2OU( pServiceName ) );
+xRef = xMgr-createInstance( ::rtl::OUString::createFromAscii(
pServiceName ) );
}
catch (uno::Exception )
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] ERROR: error 65280 occurred while making .../mdds
Hello, I don't know what was the pb but I had the same thing. I just updated my repository, then this : ./autogen.sh make clean make I don't know if there's a quicker way since it's quite tedious to make a compilation of the whole thing. Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Trying to identify a webdav bug fixed in LibreOffice but not in Open Office
Hello everyone, last year i experienced the following bug with webdav in Open Office : https://issues.apache.org/ooo/show_bug.cgi?id=113354 When saving an already existing document on a wedav server, the file got truncated. A few month ago i changed to LibreOffice and realized that the bug didn't exist in it (great surprise!). Since the latest Open Office is still affected by this bug i wondered if the LibreOffice team did a special fix for it? If yes could you point me to the commit that did the trick? I would like to report it to Open Office since many of my customer still use it. Thanks anyway for your great work and long life to LibreOffice! -- Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Trying to identify a webdav bug fixed in LibreOffice but not in Open Office
Thanks every one! I guess i'll have to push them to LibreOffice sooner than later :) That's great anyway that we can work properly with webdav! Thanks again for the good work! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix for FDO#42453 - remove unused anchor icons
Very straightforward change attached.
The change is contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From 9dd61fd109964d7db42e1509249c62420611d593 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Wed, 9 Nov 2011 19:50:38 -0800
Subject: [PATCH 1/2] FDO#42453 - EasyHack: remove unused anchor icons ...
Removed the 2 suggested entries as there was no other references to the
---
sw/source/ui/utlui/initui.hrc |3 ---
sw/source/ui/utlui/initui.src |2 --
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/sw/source/ui/utlui/initui.hrc b/sw/source/ui/utlui/initui.hrc
index 367091f..79c9dd5 100644
--- a/sw/source/ui/utlui/initui.hrc
+++ b/sw/source/ui/utlui/initui.hrc
@@ -28,9 +28,6 @@
#ifndef _INITUI_HRC
#define _INITUI_HRC
-#define BMP_FRAME_ANCHOR 1
-#define BMP_FRAME_DRAG_ANCHOR2
-
// lokale Resourcen fuer die Shells:
#define STR_POSTIT_PAGE 1
#define STR_POSTIT_AUTHOR2
diff --git a/sw/source/ui/utlui/initui.src b/sw/source/ui/utlui/initui.src
index ccb3243..6031bd4 100644
--- a/sw/source/ui/utlui/initui.src
+++ b/sw/source/ui/utlui/initui.src
@@ -186,8 +186,6 @@ Resource RID_SW_SHELLRES
{
Text [ en-US ] = Total editing time ;
};
-BITMAP BMP_FRAME_ANCHOR { FILE = anchor.bmp ; };
-BITMAP BMP_FRAME_DRAG_ANCHOR { FILE = danchor.bmp ; };
String STR_PAGEDESC_NAME
{
--
1.7.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove some String - OUString conversion in svl/fsstor
Another simple change attached.
The change is contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From a8d064a78058693d7d2bf5ceaabc779b8290242d Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Thu, 10 Nov 2011 07:23:29 -0800
Subject: [PATCH 2/2] Removed several String - OUString conversion in
fsstor.
---
svl/source/fsstor/fsstorage.cxx |4 ++--
svl/source/fsstor/fsstorage.hxx |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/svl/source/fsstor/fsstorage.cxx b/svl/source/fsstor/fsstorage.cxx
index 2a6e2ca..4c0dcac 100644
--- a/svl/source/fsstor/fsstorage.cxx
+++ b/svl/source/fsstor/fsstorage.cxx
@@ -180,9 +180,9 @@ FSStorage::~FSStorage()
}
//---
-sal_Bool FSStorage::MakeFolderNoUI( const String rFolder, sal_Bool )
+sal_Bool FSStorage::MakeFolderNoUI( const ::rtl::OUString rFolder, sal_Bool )
{
- INetURLObject aURL( rFolder );
+INetURLObject aURL( rFolder );
::rtl::OUString aTitle = aURL.getName( INetURLObject::LAST_SEGMENT, true, INetURLObject::DECODE_WITH_CHARSET );
aURL.removeSegment();
::ucbhelper::Content aParent;
diff --git a/svl/source/fsstor/fsstorage.hxx b/svl/source/fsstor/fsstorage.hxx
index 7d8a144..87430ec 100644
--- a/svl/source/fsstor/fsstorage.hxx
+++ b/svl/source/fsstor/fsstorage.hxx
@@ -75,7 +75,7 @@ public:
void CopyContentToStorage_Impl( ::ucbhelper::Content* pContent,
const ::com::sun::star::uno::Reference ::com::sun::star::embed::XStorage xDest );
-static sal_Bool MakeFolderNoUI( const String rFolder, sal_Bool bNewOnly );
+static sal_Bool MakeFolderNoUI( const ::rtl::OUString rFolder, sal_Bool bNewOnly );
//
// XInterface
--
1.7.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] compile fails: solver/unxlngx6.pro/xml/ure/services.rdb not created
Le 13/11/2011 13:28, Luc Castermans a écrit :
Op 13-11-11 11:33, julien2412 schreef:
Have you tried to apply the advice put here :
http://wiki.documentfoundation.org/Development/How_to_build#The_Build_Failed..._What_can_I_do.C2.A0.3F
?
Yes, result is the 2nd output in the pastebin URL.
http://pastebin.com/4cUAnyXF
when I execute the instruction I move one level deeper and get:
http://pastebin.com/F2z0SjNm
I noticed in line 59 the output
../../unxlngx6.pro/lib/uno_services.rdb \
is created.
I added 2 days ago this part :
$find */${INPATH?}/ -name \*.component-exec rm {} \;
Then rerun the compilation :
$make
+ some explanation
(all this thanks to Stephan)
After, the only way to be sure is :
make clean make
So I read 2 different names: uno_services.rdb and service.rdb;
should they be identical?
I don't know but they're different on my machine (pc Debian x86-32) :
maryline@maryline:~/compile-libreoffice/libo$ ls -lrt
./testtools/unxlngi6/lib/*services.rdb
-rw-r--r-- 1 maryline maryline 8043 nov. 6 11:52
./testtools/unxlngi6/lib/services.rdb
-rw-r--r-- 1 maryline maryline 1347 nov. 11 17:30
./testtools/unxlngi6/lib/uno_services.rdb
-rw-r--r-- 1 maryline maryline 339 nov. 11 17:30
./testtools/unxlngi6/lib/pyuno_services.rdb
maryline@maryline:~/compile-libreoffice/libo$
Regards
Luc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] FDO#39446 - Remove uncallable code in basic/
Hi,
please find attached a patch to remove most of the unused functions in basic/.
The patch is contributed under the LGPLv3+ / MPL.
Thanks,
Julien
From 2e65408accabe86f9b2b47666fea43910e30f845 Mon Sep 17 00:00:00 2001
From: Julien Chaffraix julien.chaffr...@gmail.com
Date: Sun, 13 Nov 2011 22:35:28 -0800
Subject: [PATCH 1/2] FDO#39446 [EasyHack] Bloat Removal. Removing uncallable
code with callcatcher
Removed most unused symbols in basic/. The remaining symbols (SdxDecimal) are
Windows specific and thus should be double-checked on a Windows machine prior
to removal.
---
basic/inc/basic/sbx.hxx |7 ---
basic/inc/basic/sbxobj.hxx|9 ---
basic/inc/basic/sbxvar.hxx| 10
basic/source/sbx/sbxarray.cxx | 30 ---
basic/source/sbx/sbxbase.cxx |7 ---
basic/source/sbx/sbxobj.cxx | 109 -
basic/source/sbx/sbxvalue.cxx | 45 -
basic/source/sbx/sbxvar.cxx | 10
unusedcode.easy | 23 -
9 files changed, 0 insertions(+), 250 deletions(-)
diff --git a/basic/inc/basic/sbx.hxx b/basic/inc/basic/sbx.hxx
index efe4297..7a74e25 100644
--- a/basic/inc/basic/sbx.hxx
+++ b/basic/inc/basic/sbx.hxx
@@ -100,7 +100,6 @@ public:
SbxInfo( const String, sal_uInt32 );
voidAddParam( const String, SbxDataType, sal_uInt16=SBX_READ );
-voidAddParam( const SbxParamInfo );
const SbxParamInfo* GetParam( sal_uInt16 n ) const; // index starts with 1!
const String GetComment() const { return aComment; }
const String GetHelpFile() const { return aHelpFile; }
@@ -139,7 +138,6 @@ class BASIC_DLLPUBLIC SbxAlias : public SbxVariable, public SfxListener
virtual void SFX_NOTIFY( SfxBroadcaster rBC, const TypeId rBCType,
const SfxHint rHint, const TypeId rHintType );
public:
-SbxAlias( const String rName, SbxVariable* pOriginal );
SbxAlias( const SbxAlias );
SbxAlias operator=( const SbxAlias );
};
@@ -227,7 +225,6 @@ class BASIC_DLLPUBLIC SbxDimArray : public SbxArray
protected:
sal_uInt16 Offset( const short* );
sal_uInt32 Offset32( const sal_Int32* );
-sal_uInt16 Offset( SbxArray* );
sal_uInt32 Offset32( SbxArray* );
virtual sal_Bool LoadData( SvStream, sal_uInt16 );
virtual sal_Bool StoreData( SvStream ) const;
@@ -240,14 +237,11 @@ public:
SbxDimArray operator=( const SbxDimArray );
virtual void Clear();
using SbxArray::GetRef;
-SbxVariableRef GetRef( const short* );
using SbxArray::Get;
SbxVariable* Get( const short* );
using SbxArray::Put;
void Put( SbxVariable*, const short* );
-SbxVariableRef GetRef( SbxArray* );
SbxVariable* Get( SbxArray* );
-void Put( SbxVariable*, SbxArray* );
short GetDims() const;
void AddDim( short, short );
@@ -255,7 +249,6 @@ public:
sal_Bool GetDim( short, short, short ) const;
using SbxArray::GetRef32;
-SbxVariableRef GetRef32( const sal_Int32* );
using SbxArray::Get32;
SbxVariable* Get32( const sal_Int32* );
using SbxArray::Put32;
diff --git a/basic/inc/basic/sbxobj.hxx b/basic/inc/basic/sbxobj.hxx
index 0a4e875..653437e 100644
--- a/basic/inc/basic/sbxobj.hxx
+++ b/basic/inc/basic/sbxobj.hxx
@@ -44,8 +44,6 @@ class BASIC_DLLPUBLIC SbxObject : public SbxVariable, public SfxListener
SbxObjectImpl* mpSbxObjectImpl; // Impl data
BASIC_DLLPRIVATE SbxArray* FindVar( SbxVariable*, sal_uInt16 );
-// AB 23.3.1997, special method for VCPtrRemove (see below)
-BASIC_DLLPRIVATE SbxArray* VCPtrFindVar( SbxVariable*, sal_uInt16 );
protected:
SbxArrayRef pMethods; // Methods
SbxArrayRef pProps;// Properties
@@ -91,13 +89,8 @@ public:
// AB 23.4.1997, Optimization, Insertion without check for duplicate Entries and
// without Broadcasts, only used in SO2/auto.cxx
void QuickInsert( SbxVariable* );
-// AB 23.3.1997, Special-Method, allow corresponding controls
-void VCPtrInsert( SbxVariable* );
virtual void Remove( const String, SbxClassType );
virtual void Remove( SbxVariable* );
-// AB 23.3.1997, deletion per pointer for controls (duplicate names!)
-void VCPtrRemove( SbxVariable* );
-void SetPos( SbxVariable*, sal_uInt16 );
// Macro-Recording
virtual String GenerateSource( const String rLinePrefix,
@@ -110,8 +103,6 @@ public:
virtual SvDispatch* GetSvDispatch();
// Debugging
void Dump( SvStream, sal_Bool bDumpAll=sal_False );
-
-static void GarbageCollection( sal_uIntPtr nObjects = 0 /* ::= all */ );
};
#ifndef __SBX_SBXOBJECTREF_HXX
diff --git a/basic/inc/basic/sbxvar.hxx b/basic/inc/basic/sbxvar.hxx
index 350dcf6..485c33e 100644
--- a/basic/inc/basic/sbxvar.hxx
+++ b/basic/inc/basic/sbxvar.hxx
@@ -164,7 +164,6 @@ public:
sal_Bool SetType( SbxDataType
Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons
some physical images removed here are lx03139.png sx03139.png oth_16_8.png oth_32_8.png oth_48_8.png these images are associated with SV_ICON_ID_HTML_DOCUMENT which according to opengrok ( assuming it is correct ) isn't used in code. however there are still entries for these in images.src and ditto svids.hrc ok, I have removed these in an additional commit and hope I did the right thing I think your change was a mistake: SV_ICON_ID_HTML_DOCUMENT is used but never mentioned. I fell into the same pitfall while removing the images. The patch AS-IS was compiling on linux AFAICT. Btw, do you have the error message from the tinderbox by any chance as it would be useful to know what was missed here? Thanks, Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons
I think your change was a mistake: SV_ICON_ID_HTML_DOCUMENT is used but never mentioned. not sure what you mean by used but never mentioned where is it used ? I tried removing SV_ICON_ID_HTML_DOCUMENT because I also did not see it during my grepping. However I would get some errors during make dev-install about the missing icons (I don't have the error with me sorry). opengrok at least doesn't show it being used just beyond the 'Bitmap' definitions in images.src and the define itself. Can you elaborate? I fell into the same pitfall while removing the images. The patch AS-IS was compiling on linux AFAICT. not from clean ( on linux ) Fair enough, I will try with clean builds for the next round. I have restarted my build from clean, assuming the build completes without errors, unless I get some sort of stop the world will end I will commit the patches again. Don't try it too hard. It shouldn't have broken anything. If it does, it means I should have done more research and testing on my side! Thanks, Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] License statement
Hi fellow hackers, All current and past contributions made to the LibreOffice project are done under the GPLv3 / MPL or later version of these licenses. Until further notice, all future contributions to the LibreOffice project are available under the GPLv3 / MPL or later version of these licenses. Thanks, Julien Chaffraix ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] More icons removal
Hi Michael, Regina, (jumping in late, so trying to reply to all your concerns) So - just one quick query; if you check: vcl/unx/generic/app/soicon.cxx you'll see that we calculate the resource id at run-time (this is a bit of a gotcha): [snipped] Did you consider whether it is possible to generate the same number as SV_ICON_ID_PRESENTATION_TEMPLATE in some other way ? I did not as I completely missed this piece of code. Following Regina's line of thoughts, it looks like this was a mistake. I would not have much time to look into whether I have made a major mistake here before a week, you can just revert the changes and I will follow up on those. presumably it is not ( in a sane world ), and you removed it from the header which looks good. There can be -some- cases like this where a compile would succeed, that might fail at runtime - sometimes instead of using ImageLists in a pleasant way, this sort of arithmetic happens ;-) I understand the logic. What would be great is to start unifying the macros and avoid such magical arithmetic so that we can rely on the compiler for the checks (unless I am missing something). I am volunteering to do that if it makes sense! In some ways, I'm surprised to see: Removed SV_ICON_ID_PRESENTATION_COMPRESSED and all associated code. Given that this (apparently) has an 'industrial' version, and we tried to focus on icons that were actually visible for that, but - it also seems correct :-) (in general it's worth being a bit more paranoid about removing them). I have likely err'd on the side of removing used icons due to the mistake above. Out of interest, how many more unused icons have you detected ? and/or do you have a nice script for that ? :-) I have build a list of #define never used in one file as a beginning and I am walking through it one by one, checking for references on the associated icons and the #define values. The list is small (around 10) and I preferred to do it manually and really looking at the code so no script so far .I don't know yet how many icons will end up unused. One I get the hang of it, I may end up with a script to automate that :-) I personally would not mind, if these entries in the list have no icons at all. But it should be tested, that using this menu item does not result in an error. I would love to add more testing but would need some pointer on how to add such test, what type of tests (unit test? more like integration testing in smoke tests?) and where to put such tests. Thanks, Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] License statement
Did you mean LGPLv3/MPL ? Yes, that was a typo. Corrected line below: All current and past contributions made to the LibreOffice project are done under the LGPLv3 / MPL or later version of these licenses. Until further notice, all future contributions to the LibreOffice project are available under the LGPLv3 / MPL or later version of these licenses. Thanks, Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Hi ! We are new on libo! 2/2
Hi, to follow my friend Martius, i'm introducing myself. I'm Julien Levesy, french student in CS. As a school project, I'll will help Martin in reworking file picker, and implementing new features he has presented in his previous mail. All this work is mentored by Cedric Bosdonnat. My nickname in IRC is Jlevesy. All the best ! Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Icons in Specialized class ListBox
Hi I'm working on the file picker dialog. I would like to add a list of places as those we can see on most common file pickers (bookmarks on the left of the dialog). In order to display these places, I use specialization of the SvtListBox component. I would like to add icons for each item in the list. Do you know what the best way to display icons in a listbox is ? Should I re-implement (override) the ListBox::draw() method, or is an other way to do that more easily ? Best regards Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
