Re: [Linux-ha-dev] [Patch:crmsh] Correction of the mistake of the processing to transfer comment.

2014-01-15 Thread Kristoffer Grönlund
On Tue, 14 Jan 2014 12:31:29 +0900 (JST)
renayama19661...@ybb.ne.jp wrote:

> Hi Kristoffer,
> 
> In addition, the error did not happen on the edit test.
> I passed the test of edit even if I did not apply my patch even if I
> applied a patch.
> 
> Did you execute the command of what kind of test?

Sorry, I should have mentioned that I applied the patch to the
development version, not to 1.2.5, when testing.

I suspect that the difference is that in older versions, comments were
stripped completely from the configuration, but in newer versions,
comments are kept. However, it seems that with this patch there are
comments generated in the XML code that the CLI syntax cannot
represent.

I have not had time to completely investigate. I will look into the
problem further and let you know what I find.

Thank you,

> 
>  * on crmsh-7cd5688c164d.tar(tip)
> (snip)
> [root@rh64-2744 test]# ./regression.sh 
> confbasic. checking... PASS
> confbasic-xml. checking... PASS
> edit checking... PASS
> (snip)
> 
>  * on crmsh-ef3f08547688(1.2.5)
> (snip)
> [root@rh64-2744 test]# ./regression.sh 
> confbasic. checking... PASS
> confbasic-xml. checking... FAIL
> edit. checking... PASS
> (snip)
> 
> Best Regards,
> Hideo Yamauchi.
> 



-- 
// Kristoffer Grönlund
// kgronl...@suse.com
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


Re: [Linux-ha-dev] [Patch:crmsh] Correction of the mistake of the processing to transfer comment.

2014-01-15 Thread renayama19661014
Hi Kristoffer,

> Sorry, I should have mentioned that I applied the patch to the
> development version, not to 1.2.5, when testing.
> 
> I suspect that the difference is that in older versions, comments were
> stripped completely from the configuration, but in newer versions,
> comments are kept. However, it seems that with this patch there are
> comments generated in the XML code that the CLI syntax cannot
> represent.
> 
> I have not had time to completely investigate. I will look into the
> problem further and let you know what I find.

It was recognized that the patch which I donated was unnecessary after all.
rpm which we used somehow or other seemed to have a problem.

I withdraw a patch.

Best Regards,
Hideo Yamauchi.

--- On Wed, 2014/1/15, Kristoffer Grönlund  wrote:

> On Tue, 14 Jan 2014 12:31:29 +0900 (JST)
> renayama19661...@ybb.ne.jp wrote:
> 
> > Hi Kristoffer,
> > 
> > In addition, the error did not happen on the edit test.
> > I passed the test of edit even if I did not apply my patch even if I
> > applied a patch.
> > 
> > Did you execute the command of what kind of test?
> 
> Sorry, I should have mentioned that I applied the patch to the
> development version, not to 1.2.5, when testing.
> 
> I suspect that the difference is that in older versions, comments were
> stripped completely from the configuration, but in newer versions,
> comments are kept. However, it seems that with this patch there are
> comments generated in the XML code that the CLI syntax cannot
> represent.
> 
> I have not had time to completely investigate. I will look into the
> problem further and let you know what I find.
> 
> Thank you,
> 
> > 
> >  * on crmsh-7cd5688c164d.tar(tip)
> > (snip)
> > [root@rh64-2744 test]# ./regression.sh 
> > confbasic. checking... PASS
> > confbasic-xml. checking... PASS
> > edit checking... PASS
> > (snip)
> > 
> >  * on crmsh-ef3f08547688(1.2.5)
> > (snip)
> > [root@rh64-2744 test]# ./regression.sh 
> > confbasic. checking... PASS
> > confbasic-xml. checking... FAIL
> > edit. checking... PASS
> > (snip)
> > 
> > Best Regards,
> > Hideo Yamauchi.
> > 
> 
> 
> 
> -- 
> // Kristoffer Grönlund
> // kgronl...@suse.com
> 
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/