Re: [PATCHv2 0/6] hpsa legacy support
On 08/15/2017 05:39 AM, Martin K. Petersen wrote: > > Hannes, > >> here's now the second attempt to add support for legacy boards, ie for >> boards previously supported by cciss only. With this patchset the >> hpsa driver should work with all Smart Array boards if the >> 'hpsa_allow_any' module option is set, rendering the cciss driver >> obsolete. Consequently I've added a patch to remove the cciss driver >> and make 'hpsa' an alias to 'cciss'. > > How does the module alias solve the problem that hpsa_allow_any=1 needs > to be added for users currently running cciss? > > I also fail to see what the point is of having an opt-in parameter when > there is no alternative after cciss has been removed. It's a > don't-be-broken switch. > Hmm ... considering this (and the fact that we now have the ->legacy_board switch) we can indeed remove that option. Will be redoing the patchset. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Re: [PATCHv2 0/6] hpsa legacy support
Hannes, > here's now the second attempt to add support for legacy boards, ie for > boards previously supported by cciss only. With this patchset the > hpsa driver should work with all Smart Array boards if the > 'hpsa_allow_any' module option is set, rendering the cciss driver > obsolete. Consequently I've added a patch to remove the cciss driver > and make 'hpsa' an alias to 'cciss'. How does the module alias solve the problem that hpsa_allow_any=1 needs to be added for users currently running cciss? I also fail to see what the point is of having an opt-in parameter when there is no alternative after cciss has been removed. It's a don't-be-broken switch. -- Martin K. Petersen Oracle Linux Engineering
[PATCHv2 0/6] hpsa legacy support
Hi all, here's now the second attempt to add support for legacy boards, ie for boards previously supported by cciss only. With this patchset the hpsa driver should work with all Smart Array boards if the 'hpsa_allow_any' module option is set, rendering the cciss driver obsolete. Consequently I've added a patch to remove the cciss driver and make 'hpsa' an alias to 'cciss'. Hannes Reinecke (5): hpsa: add support for legacy boards hpsa: disable volume status check for legacy boards hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page hpsa: do not print errors for unsupported report luns format cciss: Drop obsolete driver Jeff Mahoney (1): hpsa: handle unsupported devices more gracefully Documentation/blockdev/cciss.txt | 194 -- MAINTAINERS | 10 - drivers/block/Kconfig| 27 - drivers/block/Makefile |1 - drivers/block/cciss.c| 5415 -- drivers/block/cciss.h| 433 --- drivers/block/cciss_cmd.h| 269 -- drivers/block/cciss_scsi.c | 1653 drivers/block/cciss_scsi.h | 79 - drivers/scsi/hpsa.c | 104 +- drivers/scsi/hpsa.h | 81 +- 11 files changed, 147 insertions(+), 8119 deletions(-) delete mode 100644 Documentation/blockdev/cciss.txt delete mode 100644 drivers/block/cciss.c delete mode 100644 drivers/block/cciss.h delete mode 100644 drivers/block/cciss_cmd.h delete mode 100644 drivers/block/cciss_scsi.c delete mode 100644 drivers/block/cciss_scsi.h -- 1.8.5.6
