Re: default dir when save for first time is not cwd

2017-05-07 Thread Andrew Parsloe 



On 8/05/2017 10:52 a.m., Scott Kostyshak wrote:

On Sat, May 06, 2017 at 11:54:56PM +0200, Stephan Witt wrote:

Am 12.10.2016 um 04:30 schrieb Scott Kostyshak :


On Tue, Oct 11, 2016 at 12:27:51PM -0400, Richard Heck wrote:


Looks fine to me.


It's in at 892593f.


Hi Scott, I’m sorry to say that I missed the consequence of this change.
On Mac the initial value for CWD of a program started from Desktop is
the root directory. So, the document directory of non-configured LyX
has effectively changed from $HOME/Documents to / and one is forced
to configure the ancient default value explicitly in the preferences.
It wouldn’t be a big deal to place it in "development/MacOSX/lyxrc.dist.in“
but the dynamic value retrieval in get_document_dir() was not bad either.


I'm glad that you realized this. I can see how this behavior is a
regression.


What should we do now? What do you think?

Solution 1: Make it platform specific in LyX::init()
Solution 2: Runtime check for writable CWD in LyX::init()


Might not be a bad idea in general (although we should think carefully),
but even if we did this the user probably does not want to have the CWD
set to root. Also, suppose the CWD is not writable, where do we go? I
guess the fallback would be the user directory?


Solution 3: Provide the mentioned lyxrc.dist.in change for Mac


I'm fine with either Solution 1 or 3 so whatever you feel is best is
fine with me. I can't help with Solution 3, but if you want me to take a
look at implementing Solution 1, let me know.

I wonder if the situation is similar on Windows. Does anyone know?

Thanks,

Scott


On windows 7, alpha1-1, the Open dialogue displays the CWD.

Andrew

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: cmake build

2017-05-07 Thread Ian Wilder 

On 2017-05-07 23:39:45 +, Scott Kostyshak said:


I noticed the install layout is not one that could run on macos, but is
instead a layout indicitive of a typical linux install.

ian@ares % find ~/Applications/LyX-master.app -type d -maxdepth 2
[0]
/Users/ian/Applications/LyX-master.app
/Users/ian/Applications/LyX-master.app/bin
/Users/ian/Applications/LyX-master.app/share
/Users/ian/Applications/LyX-master.app/share/LyX
/Users/ian/Applications/LyX-master.app/share/man
~/src/lyx/build

For comparison, this is how the layout appears for 2.2.2

ian@ares % find /Applications/LyX.app -type d -maxdepth 2
[0]
/Applications/LyX.app
/Applications/LyX.app/Contents
/Applications/LyX.app/Contents/Frameworks
/Applications/LyX.app/Contents/Library
/Applications/LyX.app/Contents/MacOS
/Applications/LyX.app/Contents/PlugIns
/Applications/LyX.app/Contents/Resources
/Applications/LyX.app/Contents/translations

It seems either cmake does not have a target for macos install, or I am
using incorrect cmake options or targets.



Ian,

Did you end up figuring out the problem?

Scott




Scott,

Thank you for checking up on me. I have not sorted this out. As 
described in my last post the cmake process does not seem to be aware 
of building a macOS target as the automake build tools do.


I am able to build within Xcode, but I was hoping to build using cmake 
on this platform.

Thank you,
Ian

Re: focus-handling

2017-05-07 Thread Scott Kostyshak 
On Mon, Apr 24, 2017 at 05:19:45PM -0700, Pavel Sanda wrote:
> mn wrote:
> > The blinking cursor should always indicate where keyboard action would
> > have consequences.
> > This seems to be a general issue since similar behavior also impedes
> > working with other panels, like find and spell checking.
> > 
> > Is this now working as designed, i.e. intended?
> 
> Surely not intended. P

Mike, did you file a bug report for this so it doesn't get lost?

Thanks,

Scott


signature.asc
Description: PGP signature

Re: cmake build

2017-05-07 Thread Scott Kostyshak 
On Tue, Apr 04, 2017 at 01:08:52PM -0400, Ian Wilder wrote:
> On 2017-03-13 09:28:22 +, Kornel Benko said:
> 
> > Am Sonntag, 12. März 2017 um 16:35:43, schrieb Ian Wilder
> > 
> > > On 2017-02-13 16:21:52 +, Kornel Benko said:
> > > 
> > > > Am Mittwoch, 1. Februar 2017 um 09:58:40, schrieb Ian Wilder
> > > > 
> > > > > Hey everyone!
> > > > > 
> > 
> > ...
> > 
> > > > 
> > > > 1.) Please do not use source dir as build dir. This messes the source.
> > > 
> > > fixed.
> > > 
> > > > 2.) Do you really want lyx to be installed at
> > > > "/Users/ian/Applications/LyX-master"?
> > > 
> > > I needed to make this LyX-master.app, but other than this, yes. Does
> > > this introduce an issue?
> > > 
> > 
> > No, but it looks s suspect. (As if it were the build dir)
> 
> It is not the build directory. I install lyx to an applications directory
> under my home dir utilizing. The source is /Users/ian/src/lyx and the
> builddir is /Users/ian/src/lyx/build
> 
> > 
> > > > 
> > > > > My platform is
> > > > > 
> > > > > Darwin ares 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21
> > > > > PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
> > > > > 
> > > > > Thanks for any help!
> > > > > 
> > > > > Ian Wilder
> > > > 
> > > > To compile with cmake:
> > > > Get a really clean source tree, say 'xyzzy_src'.
> > > > Create a _new_ build tree, say 'xyzzy_build'.
> > > > 
> > > > cd xyzzy_build
> > > > cmake xyzzy_src -DLYX_USE_QT=QT5 -DLYX_COCOA=ON etc
> > > > make
> > > > 
> > > > 
> > > > Kornel
> > > > 
> > > 
> > > I have now been able to do a build with cmake. Thank you very much!
> > > 
> > > However, the make install target doesn't seem to be runnable. Has
> > > someone been able to run a cmake built version on macos?
> > 
> > In case you did not already used, try to configure with
> > -DLYX_INSTALL=ON
> > With this options you should get the install target. To see all defined
> > target try
> > make help
> > in the build dir.
> > 
> > If that does not work, then you have to follow Stephan's advise.
> 
> Thank you for the tip. However, it still does not build an exeutable that
> runs on macos.
> 
> I noticed the install layout is not one that could run on macos, but is
> instead a layout indicitive of a typical linux install.
> 
> ian@ares % find ~/Applications/LyX-master.app -type d -maxdepth 2
> [0]
> /Users/ian/Applications/LyX-master.app
> /Users/ian/Applications/LyX-master.app/bin
> /Users/ian/Applications/LyX-master.app/share
> /Users/ian/Applications/LyX-master.app/share/LyX
> /Users/ian/Applications/LyX-master.app/share/man
> ~/src/lyx/build
> 
> For comparison, this is how the layout appears for 2.2.2
> 
> ian@ares % find /Applications/LyX.app -type d -maxdepth 2
> [0]
> /Applications/LyX.app
> /Applications/LyX.app/Contents
> /Applications/LyX.app/Contents/Frameworks
> /Applications/LyX.app/Contents/Library
> /Applications/LyX.app/Contents/MacOS
> /Applications/LyX.app/Contents/PlugIns
> /Applications/LyX.app/Contents/Resources
> /Applications/LyX.app/Contents/translations
> 
> It seems either cmake does not have a target for macos install, or I am
> using incorrect cmake options or targets.
> 
> > 
> > > Thanks,
> > > Ian
> > 
> > Kornel
> > 
> > 

Ian,

Did you end up figuring out the problem?

Scott


signature.asc
Description: PGP signature

Re: 2.2.3 Tarballs

2017-05-07 Thread Scott Kostyshak 
On Sun, May 07, 2017 at 01:07:55PM -0400, Richard Heck wrote:
> The taballs for LyX 2.2.3 are available at
> 
> ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.2/2.2.3/
> 
> Please let me know if you have any problems building. Please also
> prepare binaries, if not! We'll aim to release end of the week.

Builds and works well in basic tests, on Ubuntu 16.04.

Scott


signature.asc
Description: PGP signature

Re: default dir when save for first time is not cwd

2017-05-07 Thread Scott Kostyshak 
On Sat, May 06, 2017 at 11:54:56PM +0200, Stephan Witt wrote:
> Am 12.10.2016 um 04:30 schrieb Scott Kostyshak :
> > 
> > On Tue, Oct 11, 2016 at 12:27:51PM -0400, Richard Heck wrote:
> > 
> >> Looks fine to me.
> > 
> > It's in at 892593f.
> 
> Hi Scott, I’m sorry to say that I missed the consequence of this change.
> On Mac the initial value for CWD of a program started from Desktop is
> the root directory. So, the document directory of non-configured LyX
> has effectively changed from $HOME/Documents to / and one is forced
> to configure the ancient default value explicitly in the preferences.
> It wouldn’t be a big deal to place it in "development/MacOSX/lyxrc.dist.in“
> but the dynamic value retrieval in get_document_dir() was not bad either.

I'm glad that you realized this. I can see how this behavior is a
regression.

> What should we do now? What do you think?
> 
> Solution 1: Make it platform specific in LyX::init()
> Solution 2: Runtime check for writable CWD in LyX::init()

Might not be a bad idea in general (although we should think carefully),
but even if we did this the user probably does not want to have the CWD
set to root. Also, suppose the CWD is not writable, where do we go? I
guess the fallback would be the user directory?

> Solution 3: Provide the mentioned lyxrc.dist.in change for Mac

I'm fine with either Solution 1 or 3 so whatever you feel is best is
fine with me. I can't help with Solution 3, but if you want me to take a
look at implementing Solution 1, let me know.

I wonder if the situation is similar on Windows. Does anyone know?

Thanks,

Scott


signature.asc
Description: PGP signature

Re: further add-ons for 2.3.0 ?

2017-05-07 Thread Scott Kostyshak 
On Sat, May 06, 2017 at 09:25:53AM +0200, Tommaso Cucinotta wrote:
> On 06/05/2017 02:02, Scott Kostyshak wrote:
> > Yes please revert. I remember there being some disagreement about the
> > file formats patch. I could be wrong though. Please see my questions
> > here:
> 
> reverted, those 2 patches remain available in my
> 
>   tommaso features/2.3.0alpha
> 
> branch, thanks.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: 2.3.0alpha1-1

2017-05-07 Thread Scott Kostyshak 
On Sun, May 07, 2017 at 04:03:03PM -0500, john kennan wrote:
> Tried 2.3.0 and it can't open any of my LyX files
> These are mostly \lyxformat 508 (but earlier formats don't work either).
> 
> ... is from an older version of LyX and the lyx2lyx script failed to
> convert it.

John, first, thank you for bravely testing alpha!

Please try the following:

/path/to/lyx2lyx -o abc_new.lyx abc.lyx

where "abc.lyx" is the name of a .lyx file with format 508, and where
/path/to/lyx2lyx is the path to the lyx2lyx of LyX-2.3. Let us know if
you have trouble finding this.

Does that command give any output? Does it have a non-zero exit code?

Which versions of Python do you have installed? For example, I have the
following commands available to me:

python
python2
python3

For each of those available commands, was does the option --version
give? I get:

$ python --version
Python 2.7.12
$ python2 --version
Python 2.7.12
$ python3 --version
Python 3.5.2
  
Can you try each of those prefixing the above command? e.g.

  python3 /path/to/lyx2lyx -o abc_new.lyx abc.lyx

Scott


signature.asc
Description: PGP signature

2.3.0alpha1-1

2017-05-07 Thread john kennan 
Tried 2.3.0 and it can't open any of my LyX files
These are mostly \lyxformat 508 (but earlier formats don't work either).

... is from an older version of LyX and the lyx2lyx script failed to
convert it.

macOS 10.12.4 (16E195)

Library directory: /Applications/LyX.app/Contents/Resources/

User directory: ~/Library/Application Support/LyX-2.3/

Qt Version (run-time): 5.6.2

Qt Version (compile-time): 5.6.2


John

Re: 2.2.3 Tarballs

2017-05-07 Thread José Abílio Matos 
On Sunday, 7 May 2017 18.07.55 WEST Richard Heck wrote:
> The taballs for LyX 2.2.3 are available at
> 
> ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.2/2.2.3/
> 
> Please let me know if you have any problems building. Please also
> prepare binaries, if not! We'll aim to release end of the week.
> 
> Richard

Builds fine for Fedora:

https://copr.fedorainfracloud.org/coprs/jamatos/lyx-next/

There are builds for Fedora 24, 25, 26 and rawhide and also to EPEL7.

Regards,
-- 
José Abílio

Re: 2.2.3 Tarballs

2017-05-07 Thread Jean-Pierre Chrétien 

Le 07/05/2017 à 19:07, Richard Heck a écrit :

The taballs for LyX 2.2.3 are available at

ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.2/2.2.3/

Please let me know if you have any problems building. Please also
prepare binaries, if not! We'll aim to release end of the week.


Compiles and runs flawlessly on Debian Jessie, with

Configuration
  Host type:   x86_64-unknown-linux-gnu
  Special build flags:  build=release c++11 std-regex use-hunspell
  C++ Compiler:g++ (4.9.2)
  C++ Compiler flags:   -std=c++11 -O2 -Wno-deprecated-declarations
  C++ Compiler user flags:
  Linker flags:
  Linker user flags:
  Qt Frontend:
  Qt version:  4.8.6
  Packaging:   posix
  LyX binary dir:  /usr/local/bin
  LyX files dir:   /usr/local/share/lyx-2.2.3


--
Jean-Pierre

Make the math package loading automatic

2017-05-07 Thread Jean-Pierre Chrétien 

Dear developers

I finally ended with no errors with the ctest of the 335 files in doc, examples 
and templates directories containing one or more of the ten math options set to 
"Do not load".


Then I ran the following filter on the files

s/use_package amsmath 0/use_package amsmath 1/;
s/use_package amssymb 0/use_package amssymb 1/;
s/use_package cancel 0/use_package cancel 1/;
s/use_package esint 0/use_package esint 1/;
s/use_package mathdots 0/use_package mathdots 1/;
s/use_package mathtools 0/use_package mathtools  1/;
s/use_package mhchem 0/use_package mhchem 1/;
s/use_package stackrel 0/use_package stackrel 1/;
s/use_package stmaryrd 0/use_package stmaryrd 1/;
s/use_package undertilde 0/use_package undertilde 1/;

to make the loading automatic.

Then I reran the ctest command (I run ctest only on xhtml, pdf and pdf2 export 
formats).


I got 5 errors, which in fact are two:
 - export of doc/Math.lyx (and the 3 translations of the doc file in German, 
Spanish and French). This is due to the fact that unlike the code added in the 
preamble to create the boolean \ifundertilde, what is added by the math options 
mechanism is an unconditional \usepackage{undertilde} command.
As undertilde is not installed on my system, compilation stops with a fatal 
error. This is clearly a situation where the math option panel has been 
superseded by code in the preamble, so that "Do not load" should remain enforced.
 - export of file templates/IOP-article.lyx, because as it is said in the 
LyX-note of the file:



* the two options Use AMS math package in the document settings under Math 
Options are not used

* you do not use AMS Math Environments


This case is not clear, because if no ams construct are used in the document,
amssymb and amsmath should not be loaded if the automatic loading option is 
checked. But amsmath is loaded all right, and a lot of conflicts happen between 
the IOP class and amsmath.sty.


I do not get any error with the remaining ctested 330 files.

I reverted the changes in the 4 Math.lyx files and the IOP-article.lyx file, I 
can commit the changes that I made to the other files, but this raises two questions
 - why does automatic loading load a package that the file does not request? 
How does this automatic loading feature exactly work?
 - are there other files than Math.lyx where the preamble supersedes the 
automatic loading mechanism?


What do you think? Should I parse the files to find \usepackage{xxx} command in 
preambles, where xxx is one of the ten math packages managed by math options, or 
is it sufficient to have no ctest failure?


--
Jean-Pierre

2.3.0a1 biblatex via MacPorts issue

2017-05-07 Thread Joel Kulesza 
LyX Developers:

I installed 2.3.0a1 for testing and am having a problem with Biblatex that
appears to be driven by it being a recent, but not latest, version.  This
older version is served by MacPorts with no newer version apparently
available.

See https://www.lyx.org/trac/ticket/10654.

If you are also running MacPorts, I hope you can help me test and confirm
whether an old port is the cause.  If you don't have MacPorts, your help to
identify TeX distributions that provide a more-recent version of biblatex
is appreciated.

If you have an opportunity, can you please try the steps / example file
described at: https://www.lyx.org/trac/ticket/10654?

Thank you,
Joel

Re: [LyX/2.2.x] Prepare for 2.2.3.

2017-05-07 Thread José Abílio Matos 
On Sunday, 7 May 2017 17.38.20 WEST Richard Heck wrote:
> -We are proud to announce the release of LyX 2.2.2. This is the second
> +We are proud to announce the release of LyX 2.2.3. This is the second

We are proud to announce the release of LyX 2.2.3. This is the *third* ...

-- 
José Abílio

Re: keytest.py

2017-05-07 Thread Kornel Benko 
Am Sonntag, 7. Mai 2017 um 19:35:08, schrieb Tommaso Cucinotta 
> On 07/05/2017 14:35, Kornel Benko wrote:
> > Am Sonntag, 7. Mai 2017 um 02:46:31, schrieb Tommaso Cucinotta 
> > 
> >> On 06/05/2017 14:15, Kornel Benko wrote:
> >>> Hi Tommaso,
> >>> could you please test this version?
> >>
> >> sure, as soon as I get back to a successful compile of LyX on Ubuntu 17.04 
> >> :(!
> >> (see separate thread)
> >>
> >>T.
> >>
> >
> > OK.
> > I am committing. I feel confident that nothing is going wrong with alpha 
> > release. And since
> > I am probably the only one (apart from you) testing keytests now, it seems 
> > to not bother anyone.
> 
> Ubuntu 17.04 (perhaps my hw is slower [8 y.o. Latitude E6400], so it gives 
> more troubles :-) ):
> 
> findadv-07-in.txt: FAILED
> findadv-08-in.txt: Ok
> findadv-09-in.txt: Ok
> findadv-10-in.txt: Ok
> findadv-11-in.txt: Ok
> findadv-12-in.txt: Ok
> findadv-13-in.txt: FAILED
> findadv-14-in.txt: Ok
> findadv-15-in.txt: FAILED
> findadv-16-in.txt: FAILED
> findadv-17-in.txt: Ok
> findadv-18-in.txt: Ok
> findadv-19-in.txt: Ok
> findadv-20-in.txt: Ok
> findadv-21-in.txt: FAILED
>  findadv-crash-in.txt: Ok
>   findadv-logo-in.txt: FAILED
>  findadv-re-01-in.txt: FAILED
>  findadv-re-02-in.txt: Ok
>  findadv-re-03-in.txt: FAILED
>  findadv-re-04-in.txt: FAILED
>  findadv-re-05-in.txt: Ok
>  findadv-re-06-in.txt: FAILED
>   tabular-footnote-in.txt: Ok
> 
> There were 10 FAILED tests
> 
>   T.

Latitude E6400 should be fast enough (2.27GHz).
Maybe setting def_delay at line keytest.py:374 to some higher value helps?

Do they fail if retested separately too?
Which QT version?

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: keytest.py

2017-05-07 Thread Tommaso Cucinotta 

On 07/05/2017 14:35, Kornel Benko wrote:

Am Sonntag, 7. Mai 2017 um 02:46:31, schrieb Tommaso Cucinotta 

On 06/05/2017 14:15, Kornel Benko wrote:

Hi Tommaso,
could you please test this version?


sure, as soon as I get back to a successful compile of LyX on Ubuntu 17.04 :(!
(see separate thread)

T.



OK.
I am committing. I feel confident that nothing is going wrong with alpha 
release. And since
I am probably the only one (apart from you) testing keytests now, it seems to 
not bother anyone.


Ubuntu 17.04 (perhaps my hw is slower [8 y.o. Latitude E6400], so it gives more 
troubles :-) ):

   findadv-07-in.txt: FAILED
   findadv-08-in.txt: Ok
   findadv-09-in.txt: Ok
   findadv-10-in.txt: Ok
   findadv-11-in.txt: Ok
   findadv-12-in.txt: Ok
   findadv-13-in.txt: FAILED
   findadv-14-in.txt: Ok
   findadv-15-in.txt: FAILED
   findadv-16-in.txt: FAILED
   findadv-17-in.txt: Ok
   findadv-18-in.txt: Ok
   findadv-19-in.txt: Ok
   findadv-20-in.txt: Ok
   findadv-21-in.txt: FAILED
findadv-crash-in.txt: Ok
 findadv-logo-in.txt: FAILED
findadv-re-01-in.txt: FAILED
findadv-re-02-in.txt: Ok
findadv-re-03-in.txt: FAILED
findadv-re-04-in.txt: FAILED
findadv-re-05-in.txt: Ok
findadv-re-06-in.txt: FAILED
 tabular-footnote-in.txt: Ok

There were 10 FAILED tests

T.

2.2.3 Tarballs

2017-05-07 Thread Richard Heck 
The taballs for LyX 2.2.3 are available at

ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.2/2.2.3/

Please let me know if you have any problems building. Please also
prepare binaries, if not! We'll aim to release end of the week.

Richard

Re: compiling on Ubuntu 17.04

2017-05-07 Thread Tommaso Cucinotta 

On 07/05/2017 14:39, Kornel Benko wrote:

Can it be due to some missing packages?


it was a --no-create --no-recurse that was there in my quite long ./configure 
line (which I recurrently copy from config.log).

Managed to successfully compile and run with qt4, trying now with qt5, thanks.

T.

Re: Fix for vertical table border for added column

2017-05-07 Thread Guillaume MM 

Le 15/02/2017 à 04:24, Scott Kostyshak a écrit :

On Tue, Oct 18, 2016 at 11:03:21PM +0200, racoon wrote:

On 18.10.2016 21:35, racoon wrote:

I think the attached fix leads to more intuitive results for added table
borders.

This solves one strange case:
1. create a new table (with the default borders, in particular the last
row has the borders |c|)


column not row I meant.


2. add a column after the last most right) column

Actual result:
- The last two rows have the borders |c||c


Same here. Need sleep. :)




Hi racoon,

Is this patch still pending? If so, I can take a look at it.



Same question here.

Guillaume

Re: #10455: Preferences shows current zoom instead of preference's default zoom

2017-05-07 Thread Guillaume MM 

Le 29/10/2016 à 22:31, racoon a écrit :

On 29.10.2016 22:17, racoon wrote:

On 29.10.2016 10:33, racoon wrote:

I am working on a patch for

http://www.lyx.org/trac/ticket/10455

Seemed to me like a good suggestion. Attached is a not yet working
patch.

Unfortunately, I have no idea in which header to define the new
currentZoom variable. Any recommendations?

- It will be saved via QSettings (highest hirachy). The alternative to
save it to the preferences does not seem right since preferences are
normally only saved when the settings are manually saved. However, the
currentZoom should be saved whenever LyX is quit.

- Basically this variable is needed everywhere where now there is
lyxrc.zoom except for the preferences itself (and a new LFUN which
resets currentZoom to the default lyxrc.zoom). That is why still putting
it in LyXRC.h is tempting. This is what I did in the patch and what
seems to break it. Probably since the variable is somehow reset when
loading the preferences which happens after the currentZoom is loaded
via QSettings?


Here is an updated version that fixes the bug and makes the default zoom
accessible via binding M+0.

QSettings save and restore does not work properly yet. (Due to the
problem mentioned in my last post.)


Okay, I got it to work:

http://www.lyx.org/trac/ticket/10455#comment:1

Daniel





Hi Daniel,

I have pushed several of your patches including the above one, and
commented on others. Thank you for these contributions. I would love to
see more patches from you in the future, small or big. Also, sorry for
the small delay in reviewing them.

I have the impression that they were written very carefully, most of the
times there was nothing to correct. In the future, the most efficient
way to get your patches committed will be to send them when you find
that they are polished enough directly to the list fordiscussion (you
can also ask for advice beforehand as you have already done). I am sure
that developers will be quick to let you commit your patches by yourself.

I had to rewrite the "author" line every time because of encoding
issues. Can you please check your configuration on that point? Can you
also please document the new features at http://wiki.lyx.org/LyX/NewInLyX23?

Thank you
Guillaume

Re: [coverity again] missing move constructors

2017-05-07 Thread Guillaume MM 

Le 21/04/2017 à 00:11, Guillaume MM a écrit :


I am thinking about something along the lines of the attached patches.
But to be clear, one should not expect any performance gain. Only some
review, clarification, and simplification of the code.

Speaking of review, I found that setMouseHover was never used, making
the variable useless. What do you think?



Any opinion on the patches?

Guillaume

Re: [LyX/master] Add support to cross out characters

2017-05-07 Thread Guillaume MM 

Le 05/04/2017 à 00:01, Uwe Stöhr a écrit :

commit e575e7eebd32d687f3e23be0eeca185adb3b341b
Author: Uwe Stöhr 
Date:   Wed Apr 5 00:01:19 2017 +0200

Add support to cross out characters

- adds support for the command \xout of the LateX package ulem
- fileformat change
...
index 4ad5a78..e5328a5 100644
--- a/src/FuncCode.h
+++ b/src/FuncCode.h
@@ -431,6 +431,7 @@ enum FuncCode
LFUN_SECTION_SELECT,// vfr, 20090503
LFUN_FONT_UNDERLINE,
LFUN_FONT_STRIKEOUT,
+   LFUN_FONT_CROSSOUT, // uwestoehr 20170402
LFUN_FONT_UNDERUNDERLINE,
// 335
LFUN_FONT_UNDERWAVE,


After this addition the comments "// 335" etc. are no longer in sync
with the enum value, I fear.

Re: compiling on Ubuntu 17.04

2017-05-07 Thread Kornel Benko 
Am Sonntag, 7. Mai 2017 um 02:44:59, schrieb Tommaso Cucinotta 
> just made that OS upgrade, and can't compile LyX anymore
> 
> the usual autogen.sh; configure [params] doesn't output a Makefile, so make 
> won't run anything
> 
> Anyone with a clue ? is there a different recipe to restart compilation from 
> scratch ? (did also a make distclean, didn't help)
> 
> Thanks,
> 
>   T.

Can it be due to some missing packages?
Could you post the output of configure?
Have you tried to call configure only (without autogen.sh)?
Configured in the source dir?

Kornel

signature.asc
Description: This is a digitally signed message part.