Re: Biginset branch has landed (sorry for the spam)

2024-04-08 Thread Scott Kostyshak
On Fri, Apr 05, 2024 at 12:52:25PM GMT, Scott Kostyshak wrote:
> On Fri, Apr 05, 2024 at 04:17:10PM GMT, Jean-Marc Lasgouttes wrote:
> > I merged the biginset branch (see #12297 for context) to master. This is the
> > good part.
> > 
> > The bad part is that I decided first to rebase it over master, and that
> > resulted in 100+ messages sent to lyx-devel :( We are investigating how to
> > avoid that.
> > 
> > What now? Well, testing is welcome when you have time : does everything
> > works the same, but faster for big document that were annoying?.
> 
> I came across an issue where the screen seems to stop updating. To reproduce:
> 
> 1. Open the attached document.
> 2. Place the cursor at the end of the buffer.
> 3. Press , which places the cursor inside the math inset.
> 4. Press , which exits math.
> 
> Now, sometimes (not always), weird things happen. I attach a screenshot.
> 
> The easiest way for me to reproduce is if after (4) I switch desktops on
> GNOME. When I switch back, to LyX, it looks very weird and the workarea
> isn't refreshed. If I do , the cursor moves in the math inset but
> still things look weird. If I do  one more time, finally there is
> a screen update and everything looks back to normal.
> 
> I can also reproduce if I switch windows after (4) instead of switching
> desktops. When I switch back to LyX, there is no update.
> 
> Even if I don't leave LyX, sometimes I see strange things after (4), but
> this is harder to reproduce.
> 
> Can anyone reproduce weirdness after (4)?

I can still reproduce on current master. Another way to reproduce, which
doesn't involve math, is the following:

(1) Help > Introduction.
(2) Scroll down a bit with the mouse.
(3) Click somewhere.
(4) Press  + x to open the command buffer.

Sometimes it takes me a few tries. If it doesn't work the first time,
press  to close the command buffer and start at (2) again.

Can anyone reproduce?

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-08 Thread Yu Jin
Am Mo., 8. Apr. 2024 um 22:05 Uhr schrieb Jean-Marc Lasgouttes:

> Le 08/04/2024 à 19:36, Yu Jin a écrit :
> > Can you try to enforce C++11 mode to see whether it works better?
> >
> >
> > That's a problem, I am not able to select C++11:
> > image.png
> > even installed an older Windows SDK and ran CMake reconfigure completely
> > new.
>
> Normally, unary_function and binary_function only disappeared in C++17.
> Does C++14 work?
>
Unfortunately not.
-- 
  Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: SIGSEGV if iconv error from local layout or module

2024-04-08 Thread Richard Kimberly Heck

On 4/8/24 18:57, Scott Kostyshak wrote:

If we have a UTF8 character in the user preamble, LyX gives a very
user-friendly warning if the document encoding is not UTF8.

However, if the same situation happens for the local layout (or in a
module), I get a SIGSEGV when compiling.

To reproduce, open the attached document and compile to PDF.

Note that the error goes away if the encoding is switched to UTF8.

I can reproduce on 2.3.x and current master.

Can anyone else reproduce?


Yes.


Would it make sense to factor out the code that checks the preamble and
use this also for the local layout and included modules?


That sounds like the solution.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


SIGSEGV if iconv error from local layout or module

2024-04-08 Thread Scott Kostyshak
If we have a UTF8 character in the user preamble, LyX gives a very
user-friendly warning if the document encoding is not UTF8.

However, if the same situation happens for the local layout (or in a
module), I get a SIGSEGV when compiling.

To reproduce, open the attached document and compile to PDF.

Note that the error goes away if the encoding is switched to UTF8.

I can reproduce on 2.3.x and current master.

Can anyone else reproduce?

Would it make sense to factor out the code that checks the preamble and
use this also for the local layout and included modules?

Scott


local-layout-not-validated.23.lyx
Description: application/lyx


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-08 Thread Jean-Marc Lasgouttes

Le 08/04/2024 à 19:36, Yu Jin a écrit :

Can you try to enforce C++11 mode to see whether it works better?


That's a problem, I am not able to select C++11:
image.png
even installed an older Windows SDK and ran CMake reconfigure completely 
new.


Normally, unary_function and binary_function only disappeared in C++17. 
Does C++14 work?


JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Comment on ticket 12641 regarding handling of some short cuts on macos with qt6.

2024-04-08 Thread Scott Kostyshak
On Mon, Apr 08, 2024 at 10:41:43AM GMT, Jean-Marc Lasgouttes wrote:
> Le 08/04/2024 à 10:20, pdv a écrit :
> > Tor Arne Vestbø posted a qt-patch solving this issue.
> > See: https://bugreports.qt.io/browse/QTBUG-123848
> 
> Great job Patrick! Now we just have to wait for it to be available.

+1 thanks for taking the time to do that, Patrick!

If this is serious enough we might want to mention this in the
recommendations of Qt versions for macOS users in the release notes.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: File format increases on master make it hard to test

2024-04-08 Thread Scott Kostyshak
On Mon, Apr 08, 2024 at 10:14:07AM GMT, José Matos wrote:
> On Sun, 2024-04-07 at 23:03 -0400, Scott Kostyshak wrote:
> > Thanks, that is a good idea, but I would not want to use that setting
> > for most of my documents. I find that doing repeated lyx2lyx does not
> > create a smooth workflow.
> > 
> > Scott
> 
> I pushed against the guarantee before. :-)
> The rationale was the main priority was to ensure the best upgrade
> (forward).
> 
> On the other hand after hundreds of file updates we have now a better
> understanding of what it involves and so I think that with some small
> effort we can improve, make it for a smoother experience, the round
> trip experience.
> 
> BTW, I know that this is orthogonal to your issue. :-)

Fair enough! You are more optimistic than I about making roundtrip smooth :)

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-08 Thread Yu Jin
Am So., 7. Apr. 2024 um 20:40 Uhr schrieb Jean-Marc Lasgouttes <
lasgout...@lyx.org>:

> Le 05/04/2024 à 22:12, Yu Jin a écrit :
> > Hi,
> >
> > Since 2.3.8 is around the corner I thought to try compiling the 2.3.x
> > branch but failed on Format.cpp, get these errors:
> >
> > Build started at 22:05...
> > 1>-- Build started: Project: LyX (applications\LyX\LyX),
> > Configuration: Debug x64 --
> > 1>Format.cpp
> > 1>C:\lyx\master\src\Format.cpp(61,33): error C2504: 'unary_function':
> > base class undefined
> > 1>C:\lyx\master\src\Format.cpp(61,47): error C2143: syntax error:
> > missing ',' before '<'
> > 1>C:\lyx\master\src\Format.cpp(75,38): error C2504: 'unary_function':
> > base class undefined
> > 1>C:\lyx\master\src\Format.cpp(75,52): error C2143: syntax error:
> > missing ',' before '<'
> > 1>C:\lyx\master\src\Format.cpp(89,32): error C2504: 'unary_function':
> > base class undefined
> > 1>C:\lyx\master\src\Format.cpp(89,46): error C2143: syntax error:
> > missing ',' before '<'
> > 1>C:\lyx\master\src\Format.cpp(608,18): warning C4244: 'return':
> > conversion from '__int64' to 'int', possible loss of data
> > 1>Done building project "LyX.vcxproj" -- FAILED.
> > == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped
> ==
> > == Build completed at 22:05 and took 00,762 seconds ==
> >
> > Any Ideas?
>
> Can you try to enforce C++11 mode to see whether it works better?


That's a problem, I am not able to select C++11:
[image: image.png]
even installed an older Windows SDK and ran CMake reconfigure completely
new.

-- 
  Eugene
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: File format increases on master make it hard to test

2024-04-08 Thread José Matos
On Sun, 2024-04-07 at 23:03 -0400, Scott Kostyshak wrote:
> Thanks, that is a good idea, but I would not want to use that setting
> for most of my documents. I find that doing repeated lyx2lyx does not
> create a smooth workflow.
> 
> Scott

I pushed against the guarantee before. :-)
The rationale was the main priority was to ensure the best upgrade
(forward).

On the other hand after hundreds of file updates we have now a better
understanding of what it involves and so I think that with some small
effort we can improve, make it for a smoother experience, the round
trip experience.

BTW, I know that this is orthogonal to your issue. :-)
-- 
José Abílio
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: c2248 compile error with qcompare and Qt 6.7.0

2024-04-08 Thread Jean-Marc Lasgouttes

Le 07/04/2024 à 21:09, Richard Kimberly Heck a écrit :
Riki, can I backport this trivial fix (c7f53afd), along with the more 
complicated 51562ff3 to 2.4.x? This is needed for compilation with 
MSVC 2019.


OK.


Done, thanks.

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Comment on ticket 12641 regarding handling of some short cuts on macos with qt6.

2024-04-08 Thread Jean-Marc Lasgouttes

Le 08/04/2024 à 10:20, pdv a écrit :

Tor Arne Vestbø posted a qt-patch solving this issue.
See: https://bugreports.qt.io/browse/QTBUG-123848


Great job Patrick! Now we just have to wait for it to be available.

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Comment on ticket 12641 regarding handling of some short cuts on macos with qt6.

2024-04-08 Thread pdv

On 29/03/2024 22:40, pdv wrote:

On 29/03/2024 11:31, Jean-Marc Lasgouttes wrote:

Le 28/03/2024 à 23:04, pdv a écrit :

I submitted the following bug report

https://bugreports.qt.io/browse/QTBUG-123848

pdv


Hi Patrick,

Thanks for doing that!
Frankly I don't use shortcuts very often and I never use asian 
languages, but I cannot resist a challenge. Therefore I gave it a try 
and came to the conclusion that there is no easy way out.


An alternative idea I had was be to install a
global event filter at GuiApplication level that would detect and 
handle shortcut. Does this seem possible to you? And if yes, does this 
seem like a good idea or a kludge?


I have indeed only looked to the key handling at the Widget level.
Is there a possibility to receive all key events at the application 
level? If yes then maybe your proposal might work.

But shouldn't key handling be done preferentially by the widget involved?

With the qt5 behavior lyx could handle all situations correctly and 
AquaSKK should have done something similar.


We'll see what the qt-developers think about it. They may have had other 
reasons for switching the behavior.


pdv



JMarc




Tor Arne Vestbø posted a qt-patch solving this issue.
See: https://bugreports.qt.io/browse/QTBUG-123848

pdv

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel