Re: metainfo and cmake

2023-10-09 Thread Kornel Benko
Am Mon, 9 Oct 2023 10:14:48 +0200
schrieb Pavel Sanda :

> On Sun, Oct 08, 2023 at 12:56:46PM +0200, Kornel Benko wrote:
> > I was not planing to strip that part. The propose was an example.
> > Plan is:
> > If lyx with cmake is configured with
> > -DLYX_PROGRAM_SUFFIX:BOOL=ON
> > the built executables have all a suffix. Only in this case should the 
> > rename happen.
> > org.lyx.LyX.metainfo.xml -> org.lyx.LyX2.4.metainfo.xml
> > 
> > In all other cmake-settings no rename is planed.  
> 
> I see, if the default is not touched then the suffix version is not much of a 
> problem
> IMHO. Pavel

Tested that it works also for the default case. Committed at b05d59ec.

Kornel


pgpLanP0BdJbt.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-09 Thread Pavel Sanda
On Sun, Oct 08, 2023 at 12:56:46PM +0200, Kornel Benko wrote:
> I was not planing to strip that part. The propose was an example.
> Plan is:
> If lyx with cmake is configured with
>   -DLYX_PROGRAM_SUFFIX:BOOL=ON
> the built executables have all a suffix. Only in this case should the rename 
> happen.
>   org.lyx.LyX.metainfo.xml -> org.lyx.LyX2.4.metainfo.xml
> 
> In all other cmake-settings no rename is planed.

I see, if the default is not touched then the suffix version is not much of a 
problem IMHO.
Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-08 Thread Kornel Benko
Am Fri, 6 Oct 2023 14:30:24 +0200
schrieb Pavel Sanda :

> On Fri, Oct 06, 2023 at 01:02:47PM +0200, Kornel Benko wrote:
> > > > I am using lyx2.3 and lyx2.4 in parallel installed. The problem will 
> > > > arise on
> > > > installing lyx2.5 later.
> > > > 
> > > > Installing without using the suffix should be no problem for you (e.g. 
> > > > no change)
> > > > My proposal would rename it to "LyX.metainfo.xml".
> > > > 
> > > 
> > > This conflict is, I believe, also present in autoconf builds. The 
> > > default there is to build without suffix. If I move to cmake for 
> > > openSUSE packages, it's very likely I will continue to build without 
> > > suffix.
> > > 
> > > Cor
> > >   
> > 
> > Sure, good for you. But not for my use case.  
> 
> It's not exactly great idea to ship differently named metainfo files
> when using autoconf vs cmake.
> Did you have at least investigated the implications of stripping org.lyx.
> prefix in the default case?
> 
> Pavel

I was not planing to strip that part. The propose was an example.
Plan is:
If lyx with cmake is configured with
-DLYX_PROGRAM_SUFFIX:BOOL=ON
the built executables have all a suffix. Only in this case should the rename 
happen.
org.lyx.LyX.metainfo.xml -> org.lyx.LyX2.4.metainfo.xml

In all other cmake-settings no rename is planed.

Kornel


pgpSn8cLFZyuH.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Pavel Sanda
On Fri, Oct 06, 2023 at 01:02:47PM +0200, Kornel Benko wrote:
> > > I am using lyx2.3 and lyx2.4 in parallel installed. The problem will 
> > > arise on
> > > installing lyx2.5 later.
> > > 
> > > Installing without using the suffix should be no problem for you (e.g. no 
> > > change)
> > > My proposal would rename it to "LyX.metainfo.xml".
> > >   
> > 
> > This conflict is, I believe, also present in autoconf builds. The 
> > default there is to build without suffix. If I move to cmake for 
> > openSUSE packages, it's very likely I will continue to build without suffix.
> > 
> > Cor
> > 
> 
> Sure, good for you. But not for my use case.

It's not exactly great idea to ship differently named metainfo files
when using autoconf vs cmake.
Did you have at least investigated the implications of stripping org.lyx.
prefix in the default case?

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Fri, 6 Oct 2023 12:30:53 +0200
schrieb Cor Blom :

> Op 06-10-2023 om 12:14 schreef Kornel Benko:
> > Am Fri, 06 Oct 2023 10:53:25 +0100
> > schrieb José Matos :
> >   
> >> On Fri, 2023-10-06 at 11:09 +0200, Kornel Benko wrote:  
> >>> Should we rename this file on install to be able to install multiple
> >>> lyx-versions?
> >>> Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
> >>> if using versioned suffixes?
> >>>
> >>>   Kornel  
> >>
> >> Using my blue hat here (Fedora). :-)
> >>
> >> Although I am not using cmake (yet!) I prefer to have the simple
> >> version. When I need to take care of another version I prefer to do it
> >> myself.
> >>
> >> Looking into the system directory (/usr/share/metainfo/) I do not see
> >> any versioned file.
> >>
> >> My two ¢.  
> > 
> > I am using lyx2.3 and lyx2.4 in parallel installed. The problem will arise 
> > on
> > installing lyx2.5 later.
> > 
> > Installing without using the suffix should be no problem for you (e.g. no 
> > change)
> > My proposal would rename it to "LyX.metainfo.xml".
> >   
> 
> This conflict is, I believe, also present in autoconf builds. The 
> default there is to build without suffix. If I move to cmake for 
> openSUSE packages, it's very likely I will continue to build without suffix.
> 
> Cor
> 

Sure, good for you. But not for my use case.

Kornel


pgpIySxJJXfN1.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Cor Blom

Op 06-10-2023 om 12:14 schreef Kornel Benko:

Am Fri, 06 Oct 2023 10:53:25 +0100
schrieb José Matos :


On Fri, 2023-10-06 at 11:09 +0200, Kornel Benko wrote:

Should we rename this file on install to be able to install multiple
lyx-versions?
Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
if using versioned suffixes?

Kornel


Using my blue hat here (Fedora). :-)

Although I am not using cmake (yet!) I prefer to have the simple
version. When I need to take care of another version I prefer to do it
myself.

Looking into the system directory (/usr/share/metainfo/) I do not see
any versioned file.

My two ¢.


I am using lyx2.3 and lyx2.4 in parallel installed. The problem will arise on 
installing
lyx2.5 later.

Installing without using the suffix should be no problem for you (e.g. no 
change)
My proposal would rename it to "LyX.metainfo.xml".



This conflict is, I believe, also present in autoconf builds. The 
default there is to build without suffix. If I move to cmake for 
openSUSE packages, it's very likely I will continue to build without suffix.


Cor

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Fri, 06 Oct 2023 10:53:25 +0100
schrieb José Matos :

> On Fri, 2023-10-06 at 11:09 +0200, Kornel Benko wrote:
> > Should we rename this file on install to be able to install multiple
> > lyx-versions?
> > Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
> > if using versioned suffixes?
> > 
> > Kornel  
> 
> Using my blue hat here (Fedora). :-)
> 
> Although I am not using cmake (yet!) I prefer to have the simple
> version. When I need to take care of another version I prefer to do it
> myself.
> 
> Looking into the system directory (/usr/share/metainfo/) I do not see
> any versioned file.
> 
> My two ¢.

I am using lyx2.3 and lyx2.4 in parallel installed. The problem will arise on 
installing
lyx2.5 later.

Installing without using the suffix should be no problem for you (e.g. no 
change)
My proposal would rename it to "LyX.metainfo.xml".

Kornel


pgpfJfOZP2p_P.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread José Matos
On Fri, 2023-10-06 at 11:09 +0200, Kornel Benko wrote:
> Should we rename this file on install to be able to install multiple
> lyx-versions?
> Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
> if using versioned suffixes?
> 
>   Kornel

Using my blue hat here (Fedora). :-)

Although I am not using cmake (yet!) I prefer to have the simple
version. When I need to take care of another version I prefer to do it
myself.

Looking into the system directory (/usr/share/metainfo/) I do not see
any versioned file.

My two ¢.
-- 
José Abílio
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Fri, 6 Oct 2023 10:30:14 +0200
schrieb Kornel Benko :

> Am Wed, 4 Oct 2023 10:57:08 +0200
> schrieb Cor Blom :
> 
> > Hi,
> > 
> > autoconf installs org.lyx.LyX.metainfo.xml automatically, but cmake does 
> > not. Intention, mistake, ...?
> > 
> > This is on openSUSE, building rpms using the buildservice.
> > 
> > Thanks,
> > 
> > Cor
> >   
> 
> Mistake. I was not aware of this file.
> 
>   Kornel

Should we rename this file on install to be able to install multiple 
lyx-versions?
Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
if using versioned suffixes?

Kornel


pgpWTsb_b0uvX.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Wed, 4 Oct 2023 10:57:08 +0200
schrieb Cor Blom :

> Hi,
> 
> autoconf installs org.lyx.LyX.metainfo.xml automatically, but cmake does 
> not. Intention, mistake, ...?
> 
> This is on openSUSE, building rpms using the buildservice.
> 
> Thanks,
> 
> Cor
> 

Mistake. I was not aware of this file.

Kornel


pgp0TZUkmapYE.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel