Re: prefs2prefs.py not compatible with python3 [PATCH]

[Scott Kostyshak]

On Sat, Apr 08, 2017 at 08:59:04PM +0200, Stephan Witt wrote:
> Am 06.04.2017 um 03:10 schrieb Scott Kostyshak :
> > 
> > On Sat, Apr 01, 2017 at 09:49:13AM +0100, José Abílio Matos wrote:
> >> On Saturday, 1 April 2017 06.16.55 WEST Scott Kostyshak wrote:
> >>> José, any thoughts?
> >> 
> >> The changes are reasonable and in line with what has been done in other 
> >> places.
> >> So if it works for both python 2 and 3 it should go in. :-)
> > 
> > Thanks, Stephan do you want to commit?
> 
> Yes, thanks for asking. I did it now.

Thanks.

Scott


signature.asc
Description: PGP signature

Re: prefs2prefs.py not compatible with python3 [PATCH]

[Stephan Witt]

Am 06.04.2017 um 03:10 schrieb Scott Kostyshak :
> 
> On Sat, Apr 01, 2017 at 09:49:13AM +0100, José Abílio Matos wrote:
>> On Saturday, 1 April 2017 06.16.55 WEST Scott Kostyshak wrote:
>>> José, any thoughts?
>> 
>> The changes are reasonable and in line with what has been done in other 
>> places.
>> So if it works for both python 2 and 3 it should go in. :-)
> 
> Thanks, Stephan do you want to commit?

Yes, thanks for asking. I did it now.

Stephan

Re: prefs2prefs.py not compatible with python3 [PATCH]

[Scott Kostyshak]

On Sat, Apr 01, 2017 at 09:49:13AM +0100, José Abílio Matos wrote:
> On Saturday, 1 April 2017 06.16.55 WEST Scott Kostyshak wrote:
> > José, any thoughts?
> 
> The changes are reasonable and in line with what has been done in other 
> places.
> So if it works for both python 2 and 3 it should go in. :-)

Thanks, Stephan do you want to commit?

Scott


signature.asc
Description: PGP signature

Re: prefs2prefs.py not compatible with python3 [PATCH]

[José Abílio Matos]

On Saturday, 1 April 2017 06.16.55 WEST Scott Kostyshak wrote:
> José, any thoughts?

The changes are reasonable and in line with what has been done in other 
places.
So if it works for both python 2 and 3 it should go in. :-)

-- 
José Abílio

Re: prefs2prefs.py not compatible with python3 [PATCH]

[Scott Kostyshak]

On Sun, Jan 15, 2017 at 09:22:24PM +0100, pdv wrote:
> On 15/01/17 19:28, Stephan Witt wrote:
> > Am 15.01.2017 um 19:07 schrieb Stephan Witt :
> > > 
> > > Am 15.01.2017 um 17:10 schrieb Stephan Witt :
> > > > 
> > > > Am 15.01.2017 um 13:44 schrieb pdv :
> > > > > 
> > > > > On 15/01/17 00:11, Stephan Witt wrote:
> > > > > > Am 15.01.2017 um 00:05 schrieb Stephan Witt :
> > > > > > > 
> > > > > > > Am 14.01.2017 um 17:42 schrieb pdv :
> > > > > > > > 
> > > > > > > > The current master fails to start-up (on macOS) if the default 
> > > > > > > > Python is Python3.x, because prefs2prefs.py is not compatible 
> > > > > > > > with Python3.
> > > > > > > 
> > > > > > > This looks strange. The python people say python 2.7 is the 
> > > > > > > default on Mac (including the latest OS Sierra).
> > > > > > > 
> > > > > > > http://docs.python-guide.org/en/latest/starting/install3/osx/
> > > > > > > 
> > > > > > > Stephan
> > > > > > > 
> > > > > > > > 
> > > > > > > > In python23() in os.cpp both Python 2 and Python 3 are accepted.
> > > > > > > > 
> > > > > > > > 
> > > > > > > > As a temporarily workaround I've built with 
> > > > > > > > PYTHON="/usr/bin/python" which is the default apple-python, but 
> > > > > > > > that doesn't seem to help.
> > > > > > > > 
> > > > > > > > P. De Visschere
> > > > > > 
> > > > > > Sorry, I misunderstood - you are trying to force the use of the 
> > > > > > default 2.7 python. I think you have to force the use of correct 
> > > > > > python at run-time. It doesn’t matter what your environment is at 
> > > > > > compile time. This is the correct behavior, IMO.
> > > > > > 
> > > > > > Stephan
> > > > > > 
> > > > > 
> > > > > I agree but what then is the use of PYTHON at configure time?
> > > > 
> > > > Python is used to run the tests. Probably the value of PYTHON is used 
> > > > to force a specific python installation if the detected one is not 
> > > > wanted.
> > > > 
> > > > > And yes python2.7 is the default apple python, but if e.g. one has 
> > > > > python installed with macports this one (might) take precedence. 
> > > > > Before running LyX one now has to select a python2 version or none.
> > > > > Since LyX seems to accept also python3 I thought that one was not 
> > > > > aware that prefs2prefs.py is not yet compatible.
> > > > 
> > > > Yes, you’re right. I forgot that LyX should be able to use python3 now. 
> > > > Sorry.
> > > 
> > > I’m not a python expert. Nevertheless I tried to solve this issue. What 
> > > about the attached patch?
> > > 
> > > Stephan
> > > 
> > > 
> > 
> > The follow-up patch I’ve attached now should work with python2 too.
> > 
> > Stephan
> > 
> It does. Thanks.
> 
> Patrick

José, any thoughts?

Scott


signature.asc
Description: PGP signature

Re: prefs2prefs.py not compatible with python3 [PATCH]

[pdv]

On 15/01/17 19:28, Stephan Witt wrote:

Am 15.01.2017 um 19:07 schrieb Stephan Witt :


Am 15.01.2017 um 17:10 schrieb Stephan Witt :


Am 15.01.2017 um 13:44 schrieb pdv :


On 15/01/17 00:11, Stephan Witt wrote:

Am 15.01.2017 um 00:05 schrieb Stephan Witt :


Am 14.01.2017 um 17:42 schrieb pdv :


The current master fails to start-up (on macOS) if the default Python is 
Python3.x, because prefs2prefs.py is not compatible with Python3.


This looks strange. The python people say python 2.7 is the default on Mac 
(including the latest OS Sierra).

http://docs.python-guide.org/en/latest/starting/install3/osx/

Stephan



In python23() in os.cpp both Python 2 and Python 3 are accepted.


As a temporarily workaround I've built with PYTHON="/usr/bin/python" which is 
the default apple-python, but that doesn't seem to help.

P. De Visschere


Sorry, I misunderstood - you are trying to force the use of the default 2.7 
python. I think you have to force the use of correct python at run-time. It 
doesn’t matter what your environment is at compile time. This is the correct 
behavior, IMO.

Stephan



I agree but what then is the use of PYTHON at configure time?


Python is used to run the tests. Probably the value of PYTHON is used to force 
a specific python installation if the detected one is not wanted.


And yes python2.7 is the default apple python, but if e.g. one has python 
installed with macports this one (might) take precedence. Before running LyX 
one now has to select a python2 version or none.
Since LyX seems to accept also python3 I thought that one was not aware that 
prefs2prefs.py is not yet compatible.


Yes, you’re right. I forgot that LyX should be able to use python3 now. Sorry.


I’m not a python expert. Nevertheless I tried to solve this issue. What about 
the attached patch?

Stephan




The follow-up patch I’ve attached now should work with python2 too.

Stephan


It does. Thanks.

Patrick

Re: prefs2prefs.py not compatible with python3 [PATCH]

[Stephan Witt]

Am 15.01.2017 um 19:07 schrieb Stephan Witt :
> 
> Am 15.01.2017 um 17:10 schrieb Stephan Witt :
>> 
>> Am 15.01.2017 um 13:44 schrieb pdv :
>>> 
>>> On 15/01/17 00:11, Stephan Witt wrote:
 Am 15.01.2017 um 00:05 schrieb Stephan Witt :
> 
> Am 14.01.2017 um 17:42 schrieb pdv :
>> 
>> The current master fails to start-up (on macOS) if the default Python is 
>> Python3.x, because prefs2prefs.py is not compatible with Python3.
> 
> This looks strange. The python people say python 2.7 is the default on 
> Mac (including the latest OS Sierra).
> 
> http://docs.python-guide.org/en/latest/starting/install3/osx/
> 
> Stephan
> 
>> 
>> In python23() in os.cpp both Python 2 and Python 3 are accepted.
>> 
>> 
>> As a temporarily workaround I've built with PYTHON="/usr/bin/python" 
>> which is the default apple-python, but that doesn't seem to help.
>> 
>> P. De Visschere
 
 Sorry, I misunderstood - you are trying to force the use of the default 
 2.7 python. I think you have to force the use of correct python at 
 run-time. It doesn’t matter what your environment is at compile time. This 
 is the correct behavior, IMO.
 
 Stephan
 
>>> 
>>> I agree but what then is the use of PYTHON at configure time?
>> 
>> Python is used to run the tests. Probably the value of PYTHON is used to 
>> force a specific python installation if the detected one is not wanted.
>> 
>>> And yes python2.7 is the default apple python, but if e.g. one has python 
>>> installed with macports this one (might) take precedence. Before running 
>>> LyX one now has to select a python2 version or none.
>>> Since LyX seems to accept also python3 I thought that one was not aware 
>>> that prefs2prefs.py is not yet compatible.
>> 
>> Yes, you’re right. I forgot that LyX should be able to use python3 now. 
>> Sorry.
> 
> I’m not a python expert. Nevertheless I tried to solve this issue. What about 
> the attached patch?
> 
> Stephan
> 
> 

The follow-up patch I’ve attached now should work with python2 too.

Stephan



prefs2prefs-b.patch
Description: Binary data

Re: prefs2prefs.py not compatible with python3 [PATCH]

[Stephan Witt]

Am 15.01.2017 um 17:10 schrieb Stephan Witt :
> 
> Am 15.01.2017 um 13:44 schrieb pdv :
>> 
>> On 15/01/17 00:11, Stephan Witt wrote:
>>> Am 15.01.2017 um 00:05 schrieb Stephan Witt :
 
 Am 14.01.2017 um 17:42 schrieb pdv :
> 
> The current master fails to start-up (on macOS) if the default Python is 
> Python3.x, because prefs2prefs.py is not compatible with Python3.
 
 This looks strange. The python people say python 2.7 is the default on Mac 
 (including the latest OS Sierra).
 
 http://docs.python-guide.org/en/latest/starting/install3/osx/
 
 Stephan
 
> 
> In python23() in os.cpp both Python 2 and Python 3 are accepted.
> 
> 
> As a temporarily workaround I've built with PYTHON="/usr/bin/python" 
> which is the default apple-python, but that doesn't seem to help.
> 
> P. De Visschere
>>> 
>>> Sorry, I misunderstood - you are trying to force the use of the default 2.7 
>>> python. I think you have to force the use of correct python at run-time. It 
>>> doesn’t matter what your environment is at compile time. This is the 
>>> correct behavior, IMO.
>>> 
>>> Stephan
>>> 
>> 
>> I agree but what then is the use of PYTHON at configure time?
> 
> Python is used to run the tests. Probably the value of PYTHON is used to 
> force a specific python installation if the detected one is not wanted.
> 
>> And yes python2.7 is the default apple python, but if e.g. one has python 
>> installed with macports this one (might) take precedence. Before running LyX 
>> one now has to select a python2 version or none.
>> Since LyX seems to accept also python3 I thought that one was not aware that 
>> prefs2prefs.py is not yet compatible.
> 
> Yes, you’re right. I forgot that LyX should be able to use python3 now. Sorry.

I’m not a python expert. Nevertheless I tried to solve this issue. What about 
the attached patch?

Stephan



prefs2prefs.patch
Description: Binary data

Re: prefs2prefs.py not compatible with python3

[Stephan Witt]

Am 15.01.2017 um 13:44 schrieb pdv :
> 
> On 15/01/17 00:11, Stephan Witt wrote:
>> Am 15.01.2017 um 00:05 schrieb Stephan Witt :
>>> 
>>> Am 14.01.2017 um 17:42 schrieb pdv :
 
 The current master fails to start-up (on macOS) if the default Python is 
 Python3.x, because prefs2prefs.py is not compatible with Python3.
>>> 
>>> This looks strange. The python people say python 2.7 is the default on Mac 
>>> (including the latest OS Sierra).
>>> 
>>> http://docs.python-guide.org/en/latest/starting/install3/osx/
>>> 
>>> Stephan
>>> 
 
 In python23() in os.cpp both Python 2 and Python 3 are accepted.
 
 
 As a temporarily workaround I've built with PYTHON="/usr/bin/python" which 
 is the default apple-python, but that doesn't seem to help.
 
 P. De Visschere
>> 
>> Sorry, I misunderstood - you are trying to force the use of the default 2.7 
>> python. I think you have to force the use of correct python at run-time. It 
>> doesn’t matter what your environment is at compile time. This is the correct 
>> behavior, IMO.
>> 
>> Stephan
>> 
> 
> I agree but what then is the use of PYTHON at configure time?

Python is used to run the tests. Probably the value of PYTHON is used to force 
a specific python installation if the detected one is not wanted.

> And yes python2.7 is the default apple python, but if e.g. one has python 
> installed with macports this one (might) take precedence. Before running LyX 
> one now has to select a python2 version or none.
> Since LyX seems to accept also python3 I thought that one was not aware that 
> prefs2prefs.py is not yet compatible.

Yes, you’re right. I forgot that LyX should be able to use python3 now. Sorry.

Stephan

> 
> P. De Visschere

Re: prefs2prefs.py not compatible with python3

[pdv]

On 15/01/17 00:11, Stephan Witt wrote:

Am 15.01.2017 um 00:05 schrieb Stephan Witt :


Am 14.01.2017 um 17:42 schrieb pdv :


The current master fails to start-up (on macOS) if the default Python is 
Python3.x, because prefs2prefs.py is not compatible with Python3.


This looks strange. The python people say python 2.7 is the default on Mac 
(including the latest OS Sierra).

http://docs.python-guide.org/en/latest/starting/install3/osx/

Stephan



In python23() in os.cpp both Python 2 and Python 3 are accepted.


As a temporarily workaround I've built with PYTHON="/usr/bin/python" which is 
the default apple-python, but that doesn't seem to help.

P. De Visschere


Sorry, I misunderstood - you are trying to force the use of the default 2.7 
python. I think you have to force the use of correct python at run-time. It 
doesn’t matter what your environment is at compile time. This is the correct 
behavior, IMO.

Stephan



I agree but what then is the use of PYTHON at configure time?

And yes python2.7 is the default apple python, but if e.g. one has 
python installed with macports this one (might) take precedence. Before 
running LyX one now has to select a python2 version or none.
Since LyX seems to accept also python3 I thought that one was not aware 
that prefs2prefs.py is not yet compatible.


P. De Visschere

Re: prefs2prefs.py not compatible with python3

[Stephan Witt]

Am 15.01.2017 um 00:05 schrieb Stephan Witt :
> 
> Am 14.01.2017 um 17:42 schrieb pdv :
>> 
>> The current master fails to start-up (on macOS) if the default Python is 
>> Python3.x, because prefs2prefs.py is not compatible with Python3.
> 
> This looks strange. The python people say python 2.7 is the default on Mac 
> (including the latest OS Sierra).
> 
> http://docs.python-guide.org/en/latest/starting/install3/osx/
> 
> Stephan
> 
>> 
>> In python23() in os.cpp both Python 2 and Python 3 are accepted.
>> 
>> 
>> As a temporarily workaround I've built with PYTHON="/usr/bin/python" which 
>> is the default apple-python, but that doesn't seem to help.
>> 
>> P. De Visschere

Sorry, I misunderstood - you are trying to force the use of the default 2.7 
python. I think you have to force the use of correct python at run-time. It 
doesn’t matter what your environment is at compile time. This is the correct 
behavior, IMO.

Stephan

Re: prefs2prefs.py not compatible with python3

[Stephan Witt]

Am 14.01.2017 um 17:42 schrieb pdv :
> 
> The current master fails to start-up (on macOS) if the default Python is 
> Python3.x, because prefs2prefs.py is not compatible with Python3.

This looks strange. The python people say python 2.7 is the default on Mac 
(including the latest OS Sierra).

http://docs.python-guide.org/en/latest/starting/install3/osx/

Stephan

> 
> In python23() in os.cpp both Python 2 and Python 3 are accepted.
> 
> 
> As a temporarily workaround I've built with PYTHON="/usr/bin/python" which is 
> the default apple-python, but that doesn't seem to help.
> 
> P. De Visschere
> 

prefs2prefs.py not compatible with python3

[pdv]

The current master fails to start-up (on macOS) if the default Python is 
Python3.x, because prefs2prefs.py is not compatible with Python3.


In python23() in os.cpp both Python 2 and Python 3 are accepted.


As a temporarily workaround I've built with PYTHON="/usr/bin/python" 
which is the default apple-python, but that doesn't seem to help.


P. De Visschere