Re: [Mesa-dev] [PATCH 1/6] configure.ac: remove redundant option --enable-gallium-egl
On Thu, Jun 16, 2011 at 7:02 AM, Chia-I Wu olva...@gmail.com wrote: On Thu, Jun 16, 2011 at 10:20 AM, Marek Olšák mar...@gmail.com wrote: Why not to use egl_dri2 for all drivers, the classic and gallium ones? Why not to build a single fully-replaceable binary for a driver, like classic swrast_dri.so can be replaced by swrastg_dri.so from Gallium? Like radeon_drv.so from xf86-video-ati can be replaced by r300_drv.so from Gallium? I thought it had been agreed long ago that Gallium is a private unstable interface inside drivers and shouldn't be exposed publicly in any way. With that, I see no reason for egl_gallium.so to exist. egl_gallium supports OpenVG and some EGL extensions not supported by egl_dri2. SCons's build of egl_gallium does not expose any internal interface. I can(/should have) adjust autoconf-based build not to too. OK, I didn't know about that. Maybe we can have egl_dri2 enabled and egl_gallium disabled when --enable-egl, and has the option to enable egl_gallium? Then maybe have --enable-openvg depend on egl_gallium? Sounds good. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/6] configure.ac: remove redundant option --enable-gallium-egl
On Tue, Jun 14, 2011 at 10:35 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Removing this flag seems right to me, but always building the egl state tracker when gallium and egl is enabled not. So when --with-state-trackers is also removed, we'd need a new --with-egl-drivers=auto|gallium,dri2,glx or so. I decided to add back --enable-gallium-egl as a temporary way to enable/disable egl_gallium. Does the attached patch look okay to you? Is the help string correct? Please review. Marek 0001-configure.ac-add-back-enable-gallium-egl.patch Description: application/pgp-keys ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/6] configure.ac: remove redundant option --enable-gallium-egl
On Sun, Jun 19, 2011 at 4:00 AM, Marek Olšák mar...@gmail.com wrote: On Tue, Jun 14, 2011 at 10:35 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Removing this flag seems right to me, but always building the egl state tracker when gallium and egl is enabled not. So when --with-state-trackers is also removed, we'd need a new --with-egl-drivers=auto|gallium,dri2,glx or so. I decided to add back --enable-gallium-egl as a temporary way to enable/disable egl_gallium. Does the attached patch look okay to you? Is the help string correct? Please review. I did not look at the whole series, but this patch looks good to me. Thanks for working on this. Marek -- o...@lunarg.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/6] configure.ac: remove redundant option --enable-gallium-egl
On Tue, Jun 14, 2011 at 10:35 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Removing this flag seems right to me, but always building the egl state tracker when gallium and egl is enabled not. So when --with-state-trackers is also removed, we'd need a new --with-egl-drivers=auto|gallium,dri2,glx or so. Isn't --with-egl-platforms good enough to select among fbdev, wayland, one-day-maybe dri, ...? I don't see a reason for another option. You can choose between dri and xlib (st/glx) already using --with-driver=dri|xlib. I believe that most people (i.e. non-devs) don't want to enable/disable Gallium, most people don't even know what that actually means. But they certainly want two things: choose drivers for their hardware and choose public APIs for them. Whether a driver is classic or Gallium shouldn't matter. Gallium has absolutely nothing to do with public APIs, it's an internal thing and should stay internal. I assume the word gallium in --with-gallium-drivers is just transitional. So if I choose --with-gallium-drivers=r300 --enable-egl --enable-openvg, I expect OpenGL and OpenVG support in EGL (with default EGL platforms) for r300g, and the OpenGL DRI driver for r300g (because DRI is enabled by default). Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/6] configure.ac: remove redundant option --enable-gallium-egl
On Thu, Jun 16, 2011 at 1:21 AM, Chia-I Wu olva...@gmail.com wrote: On Thu, Jun 16, 2011 at 7:04 AM, Marek Olšák mar...@gmail.com wrote: On Tue, Jun 14, 2011 at 10:35 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Removing this flag seems right to me, but always building the egl state tracker when gallium and egl is enabled not. So when --with-state-trackers is also removed, we'd need a new --with-egl-drivers=auto|gallium,dri2,glx or so. Isn't --with-egl-platforms good enough to select among fbdev, wayland, one-day-maybe dri, ...? I don't see a reason for another option. You can choose between dri and xlib (st/glx) already using --with-driver=dri|xlib. OpenGL can be supported via both egl_dri2 and egl_gallium EGL drivers. The former is generally preferred for various reasons. However, when both drivers exist, there is no automatic way to make EGL chooses the former. Thus it is desirable to be able to disable egl_gallium in the first place. Why not to use egl_dri2 for all drivers, the classic and gallium ones? Why not to build a single fully-replaceable binary for a driver, like classic swrast_dri.so can be replaced by swrastg_dri.so from Gallium? Like radeon_drv.so from xf86-video-ati can be replaced by r300_drv.so from Gallium? I thought it had been agreed long ago that Gallium is a private unstable interface inside drivers and shouldn't be exposed publicly in any way. With that, I see no reason for egl_gallium.so to exist. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/6] configure.ac: remove redundant option --enable-gallium-egl
On Thu, Jun 16, 2011 at 10:20 AM, Marek Olšák mar...@gmail.com wrote: On Thu, Jun 16, 2011 at 1:21 AM, Chia-I Wu olva...@gmail.com wrote: On Thu, Jun 16, 2011 at 7:04 AM, Marek Olšák mar...@gmail.com wrote: On Tue, Jun 14, 2011 at 10:35 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Removing this flag seems right to me, but always building the egl state tracker when gallium and egl is enabled not. So when --with-state-trackers is also removed, we'd need a new --with-egl-drivers=auto|gallium,dri2,glx or so. Isn't --with-egl-platforms good enough to select among fbdev, wayland, one-day-maybe dri, ...? I don't see a reason for another option. You can choose between dri and xlib (st/glx) already using --with-driver=dri|xlib. OpenGL can be supported via both egl_dri2 and egl_gallium EGL drivers. The former is generally preferred for various reasons. However, when both drivers exist, there is no automatic way to make EGL chooses the former. Thus it is desirable to be able to disable egl_gallium in the first place. Why not to use egl_dri2 for all drivers, the classic and gallium ones? Why not to build a single fully-replaceable binary for a driver, like classic swrast_dri.so can be replaced by swrastg_dri.so from Gallium? Like radeon_drv.so from xf86-video-ati can be replaced by r300_drv.so from Gallium? I thought it had been agreed long ago that Gallium is a private unstable interface inside drivers and shouldn't be exposed publicly in any way. With that, I see no reason for egl_gallium.so to exist. egl_gallium supports OpenVG and some EGL extensions not supported by egl_dri2. SCons's build of egl_gallium does not expose any internal interface. I can(/should have) adjust autoconf-based build not to too. Maybe we can have egl_dri2 enabled and egl_gallium disabled when --enable-egl, and has the option to enable egl_gallium? Then maybe have --enable-openvg depend on egl_gallium? Marek -- o...@lunarg.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
