Re: [Mesa-dev] [PATCH v2 06/25] mesa/shaderapi: add a getter for GL_SPIR_V_BINARY_ARB

[Ian Romanick]

This patch is

Reviewed-by: Ian Romanick 

On 11/30/2017 09:28 AM, Eduardo Lima Mitev wrote:
> From: Nicolai Hähnle 
> 
> v2: Use the 'spirv_data' member of gl_shader instead of a
>dedicated flag. (Timothy Arceri)
> ---
>  src/mesa/main/shaderapi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index 24058e5ee2e..3ac1419b7ee 100644
> --- a/src/mesa/main/shaderapi.c
> +++ b/src/mesa/main/shaderapi.c
> @@ -961,6 +961,9 @@ get_shaderiv(struct gl_context *ctx, GLuint name, GLenum 
> pname, GLint *params)
> case GL_SHADER_SOURCE_LENGTH:
>*params = shader->Source ? strlen((char *) shader->Source) + 1 : 0;
>break;
> +   case GL_SPIR_V_BINARY_ARB:
> +  *params = (shader->spirv_data != NULL);
> +  break;
> default:
>_mesa_error(ctx, GL_INVALID_ENUM, "glGetShaderiv(pname)");
>return;
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 06/25] mesa/shaderapi: add a getter for GL_SPIR_V_BINARY_ARB

[Eduardo Lima Mitev]

From: Nicolai Hähnle 

v2: Use the 'spirv_data' member of gl_shader instead of a
   dedicated flag. (Timothy Arceri)
---
 src/mesa/main/shaderapi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index 24058e5ee2e..3ac1419b7ee 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main/shaderapi.c
@@ -961,6 +961,9 @@ get_shaderiv(struct gl_context *ctx, GLuint name, GLenum 
pname, GLint *params)
case GL_SHADER_SOURCE_LENGTH:
   *params = shader->Source ? strlen((char *) shader->Source) + 1 : 0;
   break;
+   case GL_SPIR_V_BINARY_ARB:
+  *params = (shader->spirv_data != NULL);
+  break;
default:
   _mesa_error(ctx, GL_INVALID_ENUM, "glGetShaderiv(pname)");
   return;
-- 
2.15.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev