Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]
On Wed, 18 May 2022 13:39:12 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >> , Mac and linux platforms and updated accordingly. >> >> Verified the build on all the platforms and sanity testing looks fine.No >> regressions observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Space correction works with our new build approach. - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]
On Wed, 18 May 2022 13:39:12 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >> , Mac and linux platforms and updated accordingly. >> >> Verified the build on all the platforms and sanity testing looks fine.No >> regressions observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Space correction Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]
On Wed, 18 May 2022 12:27:46 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update version inof related steps > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt line > 44: > >> 42: 9.2 Copy libxml\src\config.h to libxml\linux\config.h >> 43: >> 44: 10. Update version info in >> 'modules/javafx.web/src/main/legal/libxml.md'.Also, update copyright if any >> new files are added. > > Minor: missing space before `Also`. done > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt > line 37: > >> 35: 9.1 Copy `libxslt/src/config.h` to `libxslt/linux/config.h` and follow >> same guidelines as Windows to retain changes from our repo. >> 36: >> 37: 10. Update version info in >> 'modules/javafx.web/src/main/legal/libxslt.md'.Also, update copyright if any >> new files are added. > > Minor: missing space before `Also`. done - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v4]
> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , > Mac and linux platforms and updated accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Space correction - Changes: - all: https://git.openjdk.java.net/jfx/pull/797/files - new: https://git.openjdk.java.net/jfx/pull/797/files/df0207f3..e3ea6633 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=797=03 - incr: https://webrevs.openjdk.java.net/?repo=jfx=797=02-03 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/797/head:pull/797 PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]
On Wed, 18 May 2022 07:26:56 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >> , Mac and linux platforms and updated accordingly. >> >> Verified the build on all the platforms and sanity testing looks fine.No >> regressions observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Update version inof related steps @johanvos or @tiainen Can one of you be the second reviewer on this? - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
On Tue, 17 May 2022 17:25:16 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/linux/libexslt/exsltconfig.h > line 21: > >> 19: * the version string like "1.2.3" >> 20: */ >> 21: #define LIBEXSLT_DOTTED_VERSION "0.8.20" > > Shouldn't this be `1.1.35`? Actually, now that I see it, it looks correct as is, so you can ignore this question. - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]
On Wed, 18 May 2022 07:26:56 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >> , Mac and linux platforms and updated accordingly. >> >> Verified the build on all the platforms and sanity testing looks fine.No >> regressions observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Update version inof related steps The updated instructions look good with one minor issue (a missing space between a `.` and the start of the next sentence). modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt line 44: > 42: 9.2 Copy libxml\src\config.h to libxml\linux\config.h > 43: > 44: 10. Update version info in > 'modules/javafx.web/src/main/legal/libxml.md'.Also, update copyright if any > new files are added. Minor: missing space before `Also`. modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt line 37: > 35: 9.1 Copy `libxslt/src/config.h` to `libxslt/linux/config.h` and follow > same guidelines as Windows to retain changes from our repo. > 36: > 37: 10. Update version info in > 'modules/javafx.web/src/main/legal/libxslt.md'.Also, update copyright if any > new files are added. Minor: missing space before `Also`. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
On Tue, 17 May 2022 17:24:11 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt > line 15: > >> 13: > cscript configure.js compiler=msvc xslt_debug=no iconv=no >> mem_debug=no modules=no zlib=no profiler=no trio=no >> 14: - Above command generates a header file 'src/config.h' file (on >> all platforms) and libxslt\src\libxslt\xsltconfig.h. >> 15: 4.1 Copy `libxslt\src\config.h` to `libxslt\win32\config.h'. config.h >> file defines several macros to control libxslt features. We do not require >> all of the features to be enabled. > > Minor: trailing whitespace (since this is a text file, jcheck won't complain, > but since you will be editing this file anyway, maybe you can fix this). Done - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v3]
> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , > Mac and linux platforms and updated accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Update version inof related steps - Changes: - all: https://git.openjdk.java.net/jfx/pull/797/files - new: https://git.openjdk.java.net/jfx/pull/797/files/b9091ece..df0207f3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=797=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx=797=01-02 Stats: 12 lines in 2 files changed: 5 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jfx/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/797/head:pull/797 PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
On Tue, 17 May 2022 17:19:00 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/valid.c line > 30: > >> 28: >> 29: static xmlElementPtr xmlGetDtdElementDesc2(xmlDtdPtr dtd, const xmlChar >> *name, >> 30:int create); > > This file has many whitespace-only changes (more than 2,800 lines). There is > only one actual diff for this file. Can you double check the tab conversion? These changes are due to the indentation corrections. Now, the formatting looks fine. Tab conversion looks fine for all the code blocks like if, switch and functions. - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
On Tue, 17 May 2022 17:23:15 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt > line 36: > >> 34: 9.1 Copy `libxslt/src/config.h` to `libxslt/linux/config.h` and follow >> same guidelines as Windows to retain changes from our repo. >> 35: >> 36: 10. Remove tabs and trailing whitespaces from source files(.h and .c). > > Can you add a step to update the version in > `modules/javafx.web/src/main/legal/libxslt.md`. Please also add a similar > step to > `modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt` > (which is otherwise unmodified). Done - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
On Tue, 17 May 2022 17:39:27 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add UPDATING.txt for libxslt update > > modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/attributes.c > line 67: > >> 65: ((c) == 0x0D)) >> 66: >> 67: #define IS_BLANK_NODE(n)\ > > This file has only whitespace changes and no other changes. other than > whitespace changes. Is this intentional? Yes, like in libxml, updated indentation here as well. - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
On Tue, 17 May 2022 17:06:51 GMT, Hima Bindu Meda wrote: >> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured >> for windows , linux and Mac platforms and updated the files accordingly. >> >> Updated libxslt to version 1.1.35. Generated the config.h files for windows >> , Mac and linux platforms and updated accordingly. >> >> Verified the build on all the platforms and sanity testing looks fine.No >> regressions observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Add UPDATING.txt for libxslt update The code changes look good. I tested it on 3 platforms. All good. I left a few inline comments, including a couple questions about whitespace diffs. I notice that there are 27 files that only have whitespace changes and no other diffs, as well as one more where the whitespace diffs are the majority of the changes. Is this intentional? modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/valid.c line 30: > 28: > 29: static xmlElementPtr xmlGetDtdElementDesc2(xmlDtdPtr dtd, const xmlChar > *name, > 30:int create); This file has many whitespace-only changes (more than 2,800 lines). There is only one actual diff for this file. Can you double check the tab conversion? modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt line 15: > 13: > cscript configure.js compiler=msvc xslt_debug=no iconv=no > mem_debug=no modules=no zlib=no profiler=no trio=no > 14: - Above command generates a header file 'src/config.h' file (on > all platforms) and libxslt\src\libxslt\xsltconfig.h. > 15: 4.1 Copy `libxslt\src\config.h` to `libxslt\win32\config.h'. config.h > file defines several macros to control libxslt features. We do not require > all of the features to be enabled. Minor: trailing whitespace (since this is a text file, jcheck won't complain, but since you will be editing this file anyway, maybe you can fix this). modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/UPDATING.txt line 36: > 34: 9.1 Copy `libxslt/src/config.h` to `libxslt/linux/config.h` and follow > same guidelines as Windows to retain changes from our repo. > 35: > 36: 10. Remove tabs and trailing whitespaces from source files(.h and .c). Can you add a step to update the version in `modules/javafx.web/src/main/legal/libxslt.md`. Please also add a similar step to `modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt` (which is otherwise unmodified). modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/linux/libexslt/exsltconfig.h line 21: > 19: * the version string like "1.2.3" > 20: */ > 21: #define LIBEXSLT_DOTTED_VERSION "0.8.20" Shouldn't this be `1.1.35`? modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/libxslt/attributes.c line 67: > 65: ((c) == 0x0D)) > 66: > 67: #define IS_BLANK_NODE(n)\ This file has only whitespace changes and no other changes. other than whitespace changes. Is this intentional? - PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14 [v2]
> Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , > Mac and linux platforms and updated accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Add UPDATING.txt for libxslt update - Changes: - all: https://git.openjdk.java.net/jfx/pull/797/files - new: https://git.openjdk.java.net/jfx/pull/797/files/7af0e74b..b9091ece Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=797=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=797=00-01 Stats: 36 lines in 1 file changed: 36 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/797/head:pull/797 PR: https://git.openjdk.java.net/jfx/pull/797
Re: RFR: JDK-8286256 : Update libxml2 to 2.9.14
On Tue, 17 May 2022 12:32:17 GMT, Hima Bindu Meda wrote: > Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for > windows , linux and Mac platforms and updated the files accordingly. > > Updated libxslt to version 1.1.35. Generated the config.h files for windows , > Mac and linux platforms and updated accordingly. > > Verified the build on all the platforms and sanity testing looks fine.No > regressions observed. Creating UPDATING.txt for libxslt. Will commit it once done. - PR: https://git.openjdk.java.net/jfx/pull/797
RFR: JDK-8286256 : Update libxml2 to 2.9.14
Updated libxml to version 2.9.14.As mentioned in UPDATING.txt, configured for windows , linux and Mac platforms and updated the files accordingly. Updated libxslt to version 1.1.35. Generated the config.h files for windows , Mac and linux platforms and updated accordingly. Verified the build on all the platforms and sanity testing looks fine.No regressions observed. - Commit messages: - Remove tab - Update version info for libxml and libxslt - Remove trailing whitespace - libxslt upgrade to 1.1.35 on linux - libxml update to v2.9.14 on linux - Update xsltconfig.h for libxslt - libxml update to 2.9.14 on windows - libxslt update for mac - Mac specific changes - libxml update to 2.9.14 on mac Changes: https://git.openjdk.java.net/jfx/pull/797/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=797=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286256 Stats: 21619 lines in 79 files changed: 4388 ins; 4294 del; 12937 mod Patch: https://git.openjdk.java.net/jfx/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/797/head:pull/797 PR: https://git.openjdk.java.net/jfx/pull/797
