Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

[Ken Vermette]

> On Dec. 22, 2015, 1:22 a.m., Aleix Pol Gonzalez wrote:
> > I quite like it. +1
> > 
> > What's the sources? (i.e. if someone wanted to modify it, what should he 
> > base on?)

We have it on the VDG share. Here's a link to the wallpaper folder:
https://share.kde.org/index.php/s/Ao0pkmIziY0uCV2

I'll make sure the most up-to-date version is in there. The SVG files are tiny, 
~400kB. :D


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review89878
---


On Dec. 11, 2015, 7:04 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 11, 2015, 7:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
> screenshot.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
> 1280x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png
> 1440x900.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png
> 1600x1200.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png
> 1638x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png
> 1680x1050.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png
> 1920x1080.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png
> 2560x1440.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1440.png
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/1ff471aa-2e26-41d9-8921-2c62544d3415__2560x1600.png
> 3200x1800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/7590da34-e5c5-4f55-9ac9-0a22c13a9c0d__3200x1800.png
> 3200x2000.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/229a429e-9633-4988-ad78-dfb039583fc4__3200x2000.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org

Re: Noto fonts screw my system, please stop forcing fonts upon me!

[Philipp A.]

i did that, but they saw no problem. (i linked to the arch bug report in my
previous mail)

as you can see in the two linked bug report, i think the two correct places
in which is could be fixed is the repo and the packaging. i’ll get back to
the packagers when i have an answer in the repo bug which is some variant
of “lolno”

Sebastian Kügler  schrieb am Di., 22. Dez. 2015 um 15:32 Uhr:

> On Tuesday, December 22, 2015 14:03:19 Philipp A. wrote:
> > all of those individually are perfectly resonable decisions, so without
> it
> > being anyone’s fault, i’m forced to fiddle with my fontconfig to
> blacklist
> > the three metric alias fonts if i don’t want to see it.
>
> That sounds like you want to talk to your packagers?
> --
> sebas
>
> Sebastian Kügler|http://vizZzion.org| http://kde.org
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126468/
---

(Updated Dec. 22, 2015, 2:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 344dbeb93884af36f66e9a5133e7be7bd1b1e70d by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

The timer only added 250ms delay before creating the full representation, 
sometimes resulting in showing empty popup for a moment.


Diffs
-

  src/plasmaquick/appletquickitem.h dffbcf3 
  src/plasmaquick/appletquickitem.cpp 5f6b857 
  src/plasmaquick/private/appletquickitem_p.h 5a7f9db 

Diff: https://git.reviewboard.kde.org/r/126468/diff/


Testing
---

Works fine. Sometimes the very first popup is still a little buggy, but it is 
much better than before and also the bug doesn't come back again during the 
plasmashell lifetime.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126475: Make sure PlasmaCore.WindowThumbnail doesn't redirect windows while disabled or invisible

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126475/#review89947
---

Ship it!


Ship It!

- David Edmundson


On Dec. 22, 2015, 6:18 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126475/
> ---
> 
> (Updated Dec. 22, 2015, 6:18 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Bugs: 356938
> http://bugs.kde.org/show_bug.cgi?id=356938
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> PlasmaCore.WindowThumbnail acts as a mini-compositor and redirects windows to 
> paint a thumbnail of them. Hovering a Task Manager button delegate will down 
> the line instanciate some WindowThumbnails for the tooltip, and these stick 
> around when the tooltip is hidden. This causes windows to keep being 
> redirected, e.g. severely breaking game performance after hovering them in 
> the Task Manager (see associated bug).
> 
> I initially tried just wiping the thumbnail delegates on the Task Manager 
> side when the tooltip goes hidden, but this breaks UX performance when moving 
> across tasks in the applet because the tooltip delegate's visibility prop 
> cycles between true and false from one ToolTipArea to the next. I'll still be 
> tweaking the Task Manager code to at the very least do this when tooltips are 
> disabled to avoid even instanciating, but in the meantime, making 
> WindowThumbnail more idiot-proof strikes me as a good idea regardless.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 5fc5c5e 
> 
> Diff: https://git.reviewboard.kde.org/r/126475/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/
---

(Updated Dec. 22, 2015, 8:34 p.m.)


Review request for Plasma.


Changes
---

Rebased on master; with the toolTipItem changes there's no more
sliding of the tooltip from aside. Also if only one zone is selected
(default) it's not displayed in the tooltip. Also it now shows a date
if the timezone already has a different day (follows date format setting)

See updated screenshot for current look.


Bugs: 348078
https://bugs.kde.org/show_bug.cgi?id=348078


Repository: plasma-workspace


Description
---

In kde4 times, the layout of clock's tooltip was nicely arranged using a table. 
Now it's a bit of a mess so this brings back the table.

Also simplifies the timeForZone function which is used only for the tooltip.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
  applets/digital-clock/package/contents/ui/main.qml e754925 

Diff: https://git.reviewboard.kde.org/r/124047/diff/


Testing
---

See screenshots.


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126477: [breeze-gtk] Relax cmake version requirement to rest of plasma

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126477/
---

Review request for Plasma and David Edmundson.


Repository: breeze-gtk


Description
---

Relax cmake version requirement to rest of plasma, there doesn't seem to be a 
need for >=3.2


Diffs
-

  CMakeLists.txt 240f497fc6408b3eb84b103394a636c0895a6b74 

Diff: https://git.reviewboard.kde.org/r/126477/diff/


Testing
---

No problems building with cmake-2.8.12(.2)


Thanks,

Andreas Sturmlechner

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

[Ashish Bansal]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review89948
---

Ship it!



libs/mediacenter/lastfmimagefetcher.cpp (line 172)


Use QTimer:singleShot(0, your_slot) instead for better response and remove 
runSignal.



libs/mediacenter/lastfmimagefetcher.cpp (line 176)


May be LastFmImageFetcher::setupImageFetcher ?



libs/mediacenter/medialibrary.h (line 59)


mediaUpdated still sounds wrong, although I am not sure what it should be 
named. Anyway replace it with more logically correct name.


- Ashish Bansal


On Dec. 21, 2015, 2:51 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Dec. 21, 2015, 2:51 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList.
> 
> After the image is fetched, gotImage emits the signal mediaUpdated (from 
> mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/medialibrary.h 45744c1 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Builds 100%.
> Works as expected.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review89950
---


It still does not shrink if timezones are removed.

Otherwise looking good.


applets/digital-clock/package/contents/ui/DigitalClock.qml (lines 584 - 590)


You should probably sort them also when I add new ones in the config UI.


- Kai Uwe Broulik


On Dez. 22, 2015, 7:38 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> ---
> 
> (Updated Dez. 22, 2015, 7:38 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
> https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a 
> table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review89951
---


I suppose this is obsolete now.

- Kai Uwe Broulik


On März 14, 2015, 2:53 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> ---
> 
> (Updated März 14, 2015, 2:53 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We have a lot of reusable singletons that are just hidden when unneeded 
> (tooltip, osd). IconItem, however, will always fade from the previous state, 
> even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance 
> when it just became visible. It also removes a visible false call in the 
> tooltip which I didn't know what it was for. (With it in place, the IconItem 
> always becomes visible when moving between tooltip areas, breaking the 
> animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp d653bf3 
>   src/declarativeimports/core/tooltip.cpp 40e0af5 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> ---
> 
> Moving between tray icons - icon fades, moving relly rapidly causes it 
> not to load any icon until you halt (dunno if that happened before but 
> doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not 
> fade, is there right away
> 
> There is an issue with the OSD where it would not fade at all anymore when 
> changing states (eg. change volume, then screen brightness), only on the 
> first invocation, hence the "WIP" badge.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review89958
---



applets/digital-clock/package/contents/ui/Tooltip.qml (line 125)


It's buggy because it would be an undetectable binding loop 

your gridlayout uses it's implicitWidth (size of the children) in it's own 
size hinting. 
layout.fillWidth would set the items to the size of the grid



applets/digital-clock/package/contents/ui/Tooltip.qml (line 131)


this won't do anything.


- David Edmundson


On Dec. 22, 2015, 7:38 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> ---
> 
> (Updated Dec. 22, 2015, 7:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
> https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a 
> table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> ---
> 
> See screenshots.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124047: Improve clock's tooltip layout

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/
---

(Updated Dec. 22, 2015, 8:38 p.m.)


Review request for Plasma.


Changes
---

Forgot the Tooltip.qml


Bugs: 348078
https://bugs.kde.org/show_bug.cgi?id=348078


Repository: plasma-workspace


Description
---

In kde4 times, the layout of clock's tooltip was nicely arranged using a table. 
Now it's a bit of a mess so this brings back the table.

Also simplifies the timeForZone function which is used only for the tooltip.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
  applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
  applets/digital-clock/package/contents/ui/main.qml e754925 

Diff: https://git.reviewboard.kde.org/r/124047/diff/


Testing
---

See screenshots.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible

[David Edmundson]

> On Dec. 22, 2015, 9:58 p.m., Kai Uwe Broulik wrote:
> > I suppose this is obsolete now.

I don't think it is.
The other patch was about removing a silly timer before loading a pixmap, 
however it still always has the fade when changing source.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review89951
---


On March 14, 2015, 2:53 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> ---
> 
> (Updated March 14, 2015, 2:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We have a lot of reusable singletons that are just hidden when unneeded 
> (tooltip, osd). IconItem, however, will always fade from the previous state, 
> even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance 
> when it just became visible. It also removes a visible false call in the 
> tooltip which I didn't know what it was for. (With it in place, the IconItem 
> always becomes visible when moving between tooltip areas, breaking the 
> animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp d653bf3 
>   src/declarativeimports/core/tooltip.cpp 40e0af5 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> ---
> 
> Moving between tray icons - icon fades, moving relly rapidly causes it 
> not to load any icon until you halt (dunno if that happened before but 
> doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not 
> fade, is there right away
> 
> There is an issue with the OSD where it would not fade at all anymore when 
> changing states (eg. change volume, then screen brightness), only on the 
> first invocation, hence the "WIP" badge.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Noto fonts screw my system, please stop forcing fonts upon me!

[Sebastian Kügler]

Avoiding top-posting makes your emails a bit easier to read.  I took the 
liberty to rearrange.

> Sebastian Kügler  schrieb am Di., 22. Dez. 2015 um 15:32 Uhr:
> On Tuesday, December 22, 2015 14:03:19 Philipp A. wrote:
> > all of those individually are perfectly resonable decisions, so without it
> > being anyone’s fault, i’m forced to fiddle with my fontconfig to blacklist
> > the three metric alias fonts if i don’t want to see it.
> 
> That sounds like you want to talk to your packagers?

On Tuesday, December 22, 2015 15:15:26 Philipp A. wrote:
> i did that, but they saw no problem. (i linked to the arch bug report in my
> previous mail)
> 
> as you can see in the two linked bug report, i think the two correct places
> in which is could be fixed is the repo and the packaging. i’ll get back to
> the packagers when i have an answer in the repo bug which is some variant
> of “lolno”

KDE doesn't ship nor install the fonts that bother you, we can't do anything 
about it.
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126468: AppletQuickItem: Drop timer to create full representation

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126468/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

The timer only added 250ms delay before creating the full representation, 
sometimes resulting in showing empty popup for a moment.


Diffs
-

  src/plasmaquick/appletquickitem.h dffbcf3 
  src/plasmaquick/appletquickitem.cpp 5f6b857 
  src/plasmaquick/private/appletquickitem_p.h 5a7f9db 

Diff: https://git.reviewboard.kde.org/r/126468/diff/


Testing
---

Works fine. Sometimes the very first popup is still a little buggy, but it is 
much better than before and also the bug doesn't come back again during the 
plasmashell lifetime.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Dec 2015 10:15:24 +
Build duration: 4 min 16 sec

CHANGE SET
Revision ea96555704842777f067be78dcba5b7d274126fb by Jonathan Riddell: (Update 
version number for 5.5.2 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89900
---



src/declarativeimports/core/iconitem.cpp (line 396)


One of the (albeit extremely flimsy) arguments to a timer is changing both 
the width and height means we do a loadPixmap twice.

Could we move:
  const int iconSize = 
Units::roundToIconSize(qMin(boundingRect().size().width(), 
boundingRect().size().height()));
  
to be a member var outside loadPixmap and only call loadPixmap if that 
acutally changes?


- David Edmundson


On Dec. 22, 2015, 3:17 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 3:17 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.cpp e260487 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review89910
---


Did you test all plasmoids with standard tooltip still work as expected? (and 
quinckly move the mouse back and forth between plsmoid with standard tooltip 
and custom)

- Marco Martin


On Dic. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> ---
> 
> (Updated Dic. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> ---
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Marco Martin]

> On Dic. 20, 2015, 8:24 p.m., andreas kainz wrote:
> > ok so please vote for
> > 1. leave it as it is
> > 2. as it is now but with white text for selected task
> > 3. add blue boarder as all other tasks have (see first line in taskbar3.png)
> > 4. better idea
> 
> Martin Klapetek wrote:
> 3) is good. Keeps the color meaning and improves the visuals, +1 to that.
> 
> If you want to go for blue-bg/white-fg, this would require more things
> involved, Eike could probably elaborate on that more.

between the ones here, I prefer 3.

I would like to try with all tasks with the same border but with colored line 
on an edge as it was in the past.. (but with border to make it more balanced 
than how it was) I'll try to do a version when i'll be home.
in general, 3 for now


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89777
---


On Dic. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dic. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

[Marco Martin]

> On Dic. 21, 2015, 8:38 p.m., David Edmundson wrote:
> > dataengines/notifications/notificationsengine.cpp, line 191
> > 
> >
> > const

shipit, modulo this const


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126460/#review89856
---


On Dic. 21, 2015, 8:24 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126460/
> ---
> 
> (Updated Dic. 21, 2015, 8:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> https://git.reviewboard.kde.org/r/126459/ introduced new
> flag that allows to skip the grouping of notifications.
> 
> This patch adapts the notifications server to that change.
> 
> 
> Diffs
> -
> 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126460/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126468/#review89902
---


you talk about popups, but have you tested applets on the desktop?

Definitely this is a change we want to be making, but it looks like a 
workaround for something else being terribly broken, we need to be sure that's 
fixed.

I'll apply this too and also check.

- David Edmundson


On Dec. 22, 2015, 10:01 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126468/
> ---
> 
> (Updated Dec. 22, 2015, 10:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The timer only added 250ms delay before creating the full representation, 
> sometimes resulting in showing empty popup for a moment.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h dffbcf3 
>   src/plasmaquick/appletquickitem.cpp 5f6b857 
>   src/plasmaquick/private/appletquickitem_p.h 5a7f9db 
> 
> Diff: https://git.reviewboard.kde.org/r/126468/diff/
> 
> 
> Testing
> ---
> 
> Works fine. Sometimes the very first popup is still a little buggy, but it is 
> much better than before and also the bug doesn't come back again during the 
> plasmashell lifetime.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89909
---

Ship it!



src/scriptengines/qml/plasmoid/appletinterface.h (line 109)


QQuickItem *



src/scriptengines/qml/plasmoid/appletinterface.h (line 407)


QPointer  (emit the tooltipItemChanged signal also on object 
destruction)


- Marco Martin


On Dic. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dic. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[David Edmundson]

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, line 406
> > 
> >
> > One of the (albeit extremely flimsy) arguments to a timer is changing 
> > both the width and height means we do a loadPixmap twice.
> > 
> > Could we move:
> >   const int iconSize = 
> > Units::roundToIconSize(qMin(boundingRect().size().width(), 
> > boundingRect().size().height()));
> >   
> > to be a member var outside loadPixmap and only call loadPixmap if that 
> > acutally changes?
> 
> Marco Martin wrote:
> yes, the timer was put there to avoid two loadpixmap in geometry changes.
> the change you propose (David) would indeed avoid many of those duplicate 
> kloadPixmap, especially during scalid up.
> perhaps there would still be some problem while scalig down?
> ie the icon is 40x40
> width gets set to 28 -> 28x28 pixmap loaded
> height gets set to 16 -> 16x16 pixmap gets loaded immediately after

we could move the actual loading into update() ?

By then all QML processing for that frame has finished.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89900
---


On Dec. 22, 2015, 3:17 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 3:17 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.cpp e260487 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review89916
---


+1 from me too
I quite like it. perhaps i'm not too sold as well on that little line that has 
very tiny itams (a bit too much Intel sticker?) but overall is very pretty.

- Marco Martin


On Dic. 11, 2015, 7:04 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dic. 11, 2015, 7:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
> screenshot.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
> 1280x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png
> 1440x900.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png
> 1600x1200.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png
> 1638x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png
> 1680x1050.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png
> 1920x1080.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png
> 2560x1440.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1440.png
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/1ff471aa-2e26-41d9-8921-2c62544d3415__2560x1600.png
> 3200x1800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/7590da34-e5c5-4f55-9ac9-0a22c13a9c0d__3200x1800.png
> 3200x2000.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/229a429e-9633-4988-ad78-dfb039583fc4__3200x2000.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126468/#review89904
---

Ship it!


Ship It!

- David Edmundson


On Dec. 22, 2015, 10:01 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126468/
> ---
> 
> (Updated Dec. 22, 2015, 10:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The timer only added 250ms delay before creating the full representation, 
> sometimes resulting in showing empty popup for a moment.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h dffbcf3 
>   src/plasmaquick/appletquickitem.cpp 5f6b857 
>   src/plasmaquick/private/appletquickitem_p.h 5a7f9db 
> 
> Diff: https://git.reviewboard.kde.org/r/126468/diff/
> 
> 
> Testing
> ---
> 
> Works fine. Sometimes the very first popup is still a little buggy, but it is 
> much better than before and also the bug doesn't come back again during the 
> plasmashell lifetime.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Marco Martin]

> On Dic. 22, 2015, 11:59 a.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, line 406
> > 
> >
> > One of the (albeit extremely flimsy) arguments to a timer is changing 
> > both the width and height means we do a loadPixmap twice.
> > 
> > Could we move:
> >   const int iconSize = 
> > Units::roundToIconSize(qMin(boundingRect().size().width(), 
> > boundingRect().size().height()));
> >   
> > to be a member var outside loadPixmap and only call loadPixmap if that 
> > acutally changes?

yes, the timer was put there to avoid two loadpixmap in geometry changes.
the change you propose (David) would indeed avoid many of those duplicate 
kloadPixmap, especially during scalid up.
perhaps there would still be some problem while scalig down?
ie the icon is 40x40
width gets set to 28 -> 28x28 pixmap loaded
height gets set to 16 -> 16x16 pixmap gets loaded immediately after


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89900
---


On Dic. 22, 2015, 3:17 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dic. 22, 2015, 3:17 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.cpp e260487 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

[Marco Martin]

> On Dic. 21, 2015, 10:39 p.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.h, line 407
> > 
> >
> > what would happen if the tooltipItem object gets deleted by the 
> > plasmoid after having set the object in the applet interface?
> 
> Kai Uwe Broulik wrote:
> "deleted by the plasmoid" means deleted from QML means the QML engine 
> will set the property to null, if I'm not mistaken?

you still have to use a qpointer to store the internal variable tough


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89868
---


On Dic. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dic. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Noto fonts screw my system, please stop forcing fonts upon me!

[Jens Reuterberg]

Hello,
concerning fonts - the choice of fonts is always a tricky call. Aside from an 
exact, and more feature complete version of Oxygen which sadly doesn't exist, 
Noto is the perfect choice for us.

It's a very well made standardized font and the only other contender was the 
Firefox Fira IIRC and that had other issues (as in being to visually tied to 
Firefox and Mozilla where as Noto was not visibly connected to Google).

As for the technical bits I can't reply because that is sadly not my forté, as 
for the visuals I am sorry that you experience these problems and as someone 
who doesn't experience them and can't duplicate them there is a large issue 
here from a visual design bug standard.
But from a design perspective the work done on the Noto Font is top class 
meassured by any metric available and it also provides a good testing ground 
for the font as that font is present in a very very large chunk of places.
You claim that it is unusable on larger screens except smaller form factors 
like mobiles can easily be argued by the very same reasoning why we picked a 
well liked, well made and standard sans font like Noto in the first place. It 
exists on many many machines. 

I realize this isn't the answer but as you are well aware we give every single 
option possible from our POV to the end user via distros to change the font, 
to edit it out. The size is negligent by modern standards, the choice 
available and the choice of Noto as a standard font is a well founded one 
without any clear alternatives that cover as many different symbols and 
alphabetical variants as that. 
We haven't forced anything down anyones throat.

Now many of the more technically adept people have fairly replied, repeating 
the fact that from a technical standpoint no one is forcing you to use 
anything. But that again is their debate with you, not mine.
Since no better alternatives are presented (if you know a font that is seeing 
more active upkeep, with as good a spread or better and with more suitability 
as a standard font - this is your time to speak up), the choice of Noto was a 
necessity and one made carefully with plenty of deliberation, then I consider 
this from a VDG standpoint, a closed subject. 

On Friday, December 18, 2015 12:42:50 AM Mark Gaiser wrote:
> On Fri, Dec 18, 2015 at 12:00 AM, Kai Uwe Broulik 
> 
> wrote:
> > ‎Hi,
> > 
> > > It is a very hard forced dependency on that font.
> > 
> > I'll send you a bigger hard drive for Christmas as you constantly complain
> > about a few megs of dependencies without any runtime overhead. I'm glad
> > that we enforce some rules on fonts in Plasma 5 as in the 4.x times it was
> > usually just embarrassing.
> 
> I consider that to be one of the biggest issues in plasma.
> 
> > > and i'm not going to make bug reports about that.
> > 
> > So don't expect anybody to fix your issues.
> 
> If i report font issues, nobody is looking at them anyway. See [1] for
> oxygen.
> Besides, this is a google font so i would have to report it against their
> bug tracker (github in this case i guess?). But what if the thing i want to
> report is not a bug at all? To mee, it just looks that way because it has
> too much line spacing. But the font just seems to be that way so the font
> itself is probably not the problem here. Just using it as desktop font is
> the problem and _that_ is where plasma comes in.
> 
> > > It is the google font (noto) with the google browser (chromium) that
> > 
> > mainly screws things up completely.
> > 
> > So what?
> 
> If THAT combination isn't tested by google, then perhaps that combination
> is not meant to used at all.
> 
> > > Either case should be sufficient reason to not use it in Plasma 5.
> > 
> > To be honest, I still use Oxygen as I couldn't be bothered to change my
> > settings. Anyway ‎line height looks okay'ish - if you really display that
> > much continuous text anywhere that this matters, except an editor or help,
> > you probably did something wrong.
> 
> Please join the discussion when you know what you're talking about.
> It was visible on every web page. Even on gmail itself.
> 
> I'm not going to send you a screenshot. Just install the font and run
> chromium. At first you will instantly notice the fonts looking weirdly
> different with more space around them. Then you start noticing layout
> breakage. Then you start wondering: "hmm, what screwed my system up this
> time".. two days later you will figure out it's a font installed by plasma.
> 
> > Cheers,
> > Kai Uwe
> > 
> > 
> > 
> > ___
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> [1] https://bugs.kde.org/show_bug.cgi?id=332059

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Noto fonts screw my system, please stop forcing fonts upon me!

[Takahiro HASHIMOTO]

Hi,

I feel like the same as Aleix.
For me, as a part of CJK lang and fonts users, changing font settings is
one of the  highest priority work when I install fresh Plasma emvironment (
and when removing .config/* :P ) even though Noto is set to default.

I think the Plasma dev and design team take a choice which is acceptable
for users widely as default. I think the proposal would be welcomed which
makes fonts handling better than Noto for widely user's benefit, not
personal like/dislikeness.

Takahiro
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

[Alessandro Longo]

Every time that you release a wallpaper I think: "oh, OK, this is the best 
wallpaper ever, even the next won't be better than this!" and every time you 
surprise me with a wallpaper better than the previous.

This time you impress me again, this wallpaper goes exactly in the direction I 
wanted for Plasma! It's professional, has unique style, it's an art 
masterpiece.

I want it for Plasma 5.6. Absolutely.

--
Alex L.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
---

(Updated Dec. 22, 2015, 4:32 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

v2 adopts David's suggestion. In addition to dropping the timer, things now 
call schedulePixmapUpdate() instead of loadPixmap(), which schedules a call to 
loadPixmap() in updatePaintNode(). loadPixmap() no longer calls update(), which 
is a nice cleanliness bonus.


Bugs: 345545
http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
---

This timer seems to exist purely to delay loading the pixmap for the purpose of 
"hey, maybe it will work later ..." when it's not actually needed thanks to 
QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes 
various icon flicker around Plasma, in particular in the Task Manager: When 
swapping out a launcher delegate for a task delegate, or when swapping out 
delegates during virtual desktop switches.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

> On Dec. 22, 2015, 4:35 p.m., Aleix Pol Gonzalez wrote:
> > src/declarativeimports/core/iconitem.cpp, line 254
> > 
> >
> > Are you sure it is a good idea to load the pixmap as we're rendering? 
> > This will have quite some disk IO (icon look-up, read and rendering if an 
> > svg).

No, I don't like this either. Let's call it a stab at this to find out if it's 
what David had in mind.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89937
---


On Dec. 22, 2015, 4:32 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 4:32 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3abef40 
>   src/declarativeimports/core/iconitem.cpp bada940 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
---

(Updated Dec. 22, 2015, 4:58 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Minor cleanup.


Bugs: 345545
http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
---

This timer seems to exist purely to delay loading the pixmap for the purpose of 
"hey, maybe it will work later ..." when it's not actually needed thanks to 
QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes 
various icon flicker around Plasma, in particular in the Task Manager: When 
swapping out a launcher delegate for a task delegate, or when swapping out 
delegates during virtual desktop switches.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, line 406
> > 
> >
> > One of the (albeit extremely flimsy) arguments to a timer is changing 
> > both the width and height means we do a loadPixmap twice.
> > 
> > Could we move:
> >   const int iconSize = 
> > Units::roundToIconSize(qMin(boundingRect().size().width(), 
> > boundingRect().size().height()));
> >   
> > to be a member var outside loadPixmap and only call loadPixmap if that 
> > acutally changes?
> 
> Marco Martin wrote:
> yes, the timer was put there to avoid two loadpixmap in geometry changes.
> the change you propose (David) would indeed avoid many of those duplicate 
> kloadPixmap, especially during scalid up.
> perhaps there would still be some problem while scalig down?
> ie the icon is 40x40
> width gets set to 28 -> 28x28 pixmap loaded
> height gets set to 16 -> 16x16 pixmap gets loaded immediately after
> 
> David Edmundson wrote:
> we could move the actual loading into update() ?
> 
> By then all QML processing for that frame has finished.
> 
> Marco Martin wrote:
> hmm, sounds promising :)

I've done this in v2 but I'm not really sure it's right because of graphics 
thread considerations for updatePaintNode() -- please have a close look ...


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89900
---


On Dec. 22, 2015, 4:32 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 4:32 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3abef40 
>   src/declarativeimports/core/iconitem.cpp bada940 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
---

(Updated Dec. 22, 2015, 4:56 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Move I/O out of the rendering thread again. Do pixmap loading after props are 
done in polish processing, render when needed.


Bugs: 345545
http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
---

This timer seems to exist purely to delay loading the pixmap for the purpose of 
"hey, maybe it will work later ..." when it's not actually needed thanks to 
QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes 
various icon flicker around Plasma, in particular in the Task Manager: When 
swapping out a launcher delegate for a task delegate, or when swapping out 
delegates during virtual desktop switches.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126472: Don't always load the timetracker

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Don't always load the timetracker

It has a timer that wakes up every 2 seconds and drains my battery just
simply because I have debug builds. This make it on demand.

Don't track containments twice.
Containments inherit from Applets which also have the same line


Diffs
-

  src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
  src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
  src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 

Diff: https://git.reviewboard.kde.org/r/126472/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126472: Don't always load the timetracker

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/#review89924
---

Ship it!


Nice.

I agree with Aleix that the env var would be good to have documented. (Is that 
even English?) But then, where?

- Sebastian Kügler


On Dec. 22, 2015, 2:14 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126472/
> ---
> 
> (Updated Dec. 22, 2015, 2:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Don't always load the timetracker
> 
> It has a timer that wakes up every 2 seconds and drains my battery just
> simply because I have debug builds. This make it on demand.
> 
> Don't track containments twice.
> Containments inherit from Applets which also have the same line
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
>   src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
>   src/plasma/private/containment_p.cpp 
> 86d27c43f36b9e1741ab13f8153080fb6b92b321 
> 
> Diff: https://git.reviewboard.kde.org/r/126472/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357045] Remember brigthness level between logins

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357045

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #1 from Kai Uwe Broulik  ---
> Or maybe just don't set any initial brigthness value on systemd
> systems, where the systemd-backlight already does that, it just
> gets overridden by powerdevil on its loading.

Then just uncheck the brightness setting?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126471/#review89920
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 22, 2015, 3:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126471/
> ---
> 
> (Updated Dec. 22, 2015, 3:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> For some applets the status is bound to a complex expression that can be
> re-evaluated a lot. This ends up causing a lot of unnecassary updates; 
> especially for things in systray.
> 
> Found with Aleix's "timertracker" that's in Plasma.
> 
> 
> Diffs
> -
> 
>   src/plasma/applet.cpp 0b7ef5632c1accb3373aa8f2f57a7880e5f3640d 
> 
> Diff: https://git.reviewboard.kde.org/r/126471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126472: Don't always load the timetracker

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/#review89921
---


I'm ok with this, although it wasn't guarded initially because it was asked not 
to. IIRC.

Anyway, +1.

- Aleix Pol Gonzalez


On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126472/
> ---
> 
> (Updated Dec. 22, 2015, 3:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Don't always load the timetracker
> 
> It has a timer that wakes up every 2 seconds and drains my battery just
> simply because I have debug builds. This make it on demand.
> 
> Don't track containments twice.
> Containments inherit from Applets which also have the same line
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
>   src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
>   src/plasma/private/containment_p.cpp 
> 86d27c43f36b9e1741ab13f8153080fb6b92b321 
> 
> Diff: https://git.reviewboard.kde.org/r/126472/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 357045] New: Remember brigthness level between logins

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357045

Bug ID: 357045
   Summary: Remember brigthness level between logins
   Product: Powerdevil
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: mklape...@kde.org

I very often use custom brigthness levels depending on where
I am. So eg. if I'm at some place that has low ambient light and
I'm on AC, I turn the brightness down to ~50%.

But everytime I reboot/relogin, the brightness is brought back
to the preconfigured level, making me blind for couple seconds.

So I'd like to propose to (have an option?) remember the brigthness
levels between sessions. I think it could simply store AC state and
brigthness level and on new session login check for the AC state
being the same and if yes, then restore the brightness level.

Or maybe just don't set any initial brigthness value on systemd
systems, where the systemd-backlight already does that, it just
gets overridden by powerdevil on its loading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Noto fonts screw my system, please stop forcing fonts upon me!

[Philipp A.]

there is one part of this issue that bugs me as well, but it’s rather an
unfortunate coincidence than anything else:

   - KDE requires Noto as a baseline default font. that’s fine as nobody
   forces me to use it.
   - the freetype project ships a metric-aliases config that defines a
   number of aliases for common fonts such as arial and helvetica, among them
   Arimo, Cousine, and Timos as aliases for some microsoft fonts i don’t like.
   that’s fine because i don’t have to install the alias fonts.
   - google have a noto-fonts repo containing Noto fonts and Arimo,
   Cousine, and Timos .
   that’s … weird, but they can of course do what they want in their repo.
   - arch directly packages that repo’s content as noto-fonts without
   excluding the three non-noto fonts
   , which is fine because that’s
   what the repo and font distribution package is called
   - the frameworkintegration package depends on “noto-fonts”, which is
   fine because it’s the only Noto fonts package availabe for arch.

all of those individually are perfectly resonable decisions, so without it
being anyone’s fault, i’m forced to fiddle with my fontconfig to blacklist
the three metric alias fonts if i don’t want to see it.

:(

Takahiro HASHIMOTO  schrieb am Di., 22. Dez. 2015 um
13:53 Uhr:

> Hi,
>
> I feel like the same as Aleix.
> For me, as a part of CJK lang and fonts users, changing font settings is
> one of the  highest priority work when I install fresh Plasma emvironment (
> and when removing .config/* :P ) even though Noto is set to default.
>
> I think the Plasma dev and design team take a choice which is acceptable
> for users widely as default. I think the proposal would be welcomed which
> makes fonts handling better than Noto for widely user's benefit, not
> personal like/dislikeness.
>
> Takahiro
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126471: Don't emit statusChanged if it hasn't changed

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126471/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

For some applets the status is bound to a complex expression that can be
re-evaluated a lot. This ends up causing a lot of unnecassary updates; 
especially for things in systray.

Found with Aleix's "timertracker" that's in Plasma.


Diffs
-

  src/plasma/applet.cpp 0b7ef5632c1accb3373aa8f2f57a7880e5f3640d 

Diff: https://git.reviewboard.kde.org/r/126471/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126472: Don't always load the timetracker

[Aleix Pol Gonzalez]

> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote:
> > I'm ok with this, although it wasn't guarded initially because it was asked 
> > not to. IIRC.
> > 
> > Anyway, +1.

Some small documentation about the environment variable would be neat.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/#review89921
---


On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126472/
> ---
> 
> (Updated Dec. 22, 2015, 3:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Don't always load the timetracker
> 
> It has a timer that wakes up every 2 seconds and drains my battery just
> simply because I have debug builds. This make it on demand.
> 
> Don't track containments twice.
> Containments inherit from Applets which also have the same line
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
>   src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
>   src/plasma/private/containment_p.cpp 
> 86d27c43f36b9e1741ab13f8153080fb6b92b321 
> 
> Diff: https://git.reviewboard.kde.org/r/126472/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Noto fonts screw my system, please stop forcing fonts upon me!

[Sebastian Kügler]

On Tuesday, December 22, 2015 14:03:19 Philipp A. wrote:
> all of those individually are perfectly resonable decisions, so without it
> being anyone’s fault, i’m forced to fiddle with my fontconfig to blacklist
> the three metric alias fonts if i don’t want to see it.

That sounds like you want to talk to your packagers?
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

> On Dec. 22, 2015, 5:13 p.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, line 253
> > 
> >
> > given you have an explicit call to polish() I don't think we need the 
> > guard?

Agreed


> On Dec. 22, 2015, 5:13 p.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, line 332
> > 
> >
> > does this not need an update() too?

No, the update() calls are back unchanged in loadPixmap() now - I don't like 
them, but on the flip side it doesn't depart from (theoretically) tested-code 
someone thought about. Calls to update() don't seem to always call 
updatePolish() if no polish event has been scheduled, though - I tried doing 
polish implicitly from scheduled updates first and it never ran.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89941
---


On Dec. 22, 2015, 4:58 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 4:58 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3abef40 
>   src/declarativeimports/core/iconitem.cpp bada940 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
---

(Updated Dec. 22, 2015, 5:32 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Drop guard. Slot's still needed because polish() is no slot. Cleanup.


Bugs: 345545
http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
---

This timer seems to exist purely to delay loading the pixmap for the purpose of 
"hey, maybe it will work later ..." when it's not actually needed thanks to 
QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes 
various icon flicker around Plasma, in particular in the Task Manager: When 
swapping out a launcher delegate for a task delegate, or when swapping out 
delegates during virtual desktop switches.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89941
---

Ship it!


the diff has ended up a bit broken - revision 4 doesn't show us actually 
dropping the timer.


src/declarativeimports/core/iconitem.cpp (line 253)


given you have an explicit call to polish() I don't think we need the guard?



src/declarativeimports/core/iconitem.cpp (line 332)


does this not need an update() too?


- David Edmundson


On Dec. 22, 2015, 4:58 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 4:58 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3abef40 
>   src/declarativeimports/core/iconitem.cpp bada940 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89942
---


+1

- Aleix Pol Gonzalez


On Dec. 22, 2015, 5:58 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 5:58 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3abef40 
>   src/declarativeimports/core/iconitem.cpp bada940 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126471/
---

(Updated Dec. 22, 2015, 5:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 01cd374c8e6396a8f9135338c34dde7570c79e03 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

For some applets the status is bound to a complex expression that can be
re-evaluated a lot. This ends up causing a lot of unnecassary updates; 
especially for things in systray.

Found with Aleix's "timertracker" that's in Plasma.


Diffs
-

  src/plasma/applet.cpp 0b7ef5632c1accb3373aa8f2f57a7880e5f3640d 

Diff: https://git.reviewboard.kde.org/r/126471/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/#review89946
---

Ship it!


Ship It!

- David Edmundson


On Dec. 22, 2015, 5:32 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126466/
> ---
> 
> (Updated Dec. 22, 2015, 5:32 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 345545
> http://bugs.kde.org/show_bug.cgi?id=345545
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This timer seems to exist purely to delay loading the pixmap for the purpose 
> of "hey, maybe it will work later ..." when it's not actually needed thanks 
> to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and 
> fixes various icon flicker around Plasma, in particular in the Task Manager: 
> When swapping out a launcher delegate for a task delegate, or when swapping 
> out delegates during virtual desktop switches.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3abef40 
>   src/declarativeimports/core/iconitem.cpp bada940 
> 
> Diff: https://git.reviewboard.kde.org/r/126466/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126475: Make sure PlasmaCore.WindowThumbnail doesn't redirect windows while disabled or invisible

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126475/
---

Review request for Plasma, David Edmundson and Martin Gräßlin.


Bugs: 356938
http://bugs.kde.org/show_bug.cgi?id=356938


Repository: plasma-framework


Description
---

PlasmaCore.WindowThumbnail acts as a mini-compositor and redirects windows to 
paint a thumbnail of them. Hovering a Task Manager button delegate will down 
the line instanciate some WindowThumbnails for the tooltip, and these stick 
around when the tooltip is hidden. This causes windows to keep being 
redirected, e.g. severely breaking game performance after hovering them in the 
Task Manager (see associated bug).

I initially tried just wiping the thumbnail delegates on the Task Manager side 
when the tooltip goes hidden, but this breaks UX performance when moving across 
tasks in the applet because the tooltip delegate's visibility prop cycles 
between true and false from one ToolTipArea to the next. I'll still be tweaking 
the Task Manager code to at the very least do this when tooltips are disabled 
to avoid even instanciating, but in the meantime, making WindowThumbnail more 
idiot-proof strikes me as a good idea regardless.


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 5fc5c5e 

Diff: https://git.reviewboard.kde.org/r/126475/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
---

(Updated Dec. 22, 2015, 6:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Bugs: 345545
http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
---

This timer seems to exist purely to delay loading the pixmap for the purpose of 
"hey, maybe it will work later ..." when it's not actually needed thanks to 
QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes 
various icon flicker around Plasma, in particular in the Task Manager: When 
swapping out a launcher delegate for a task delegate, or when swapping out 
delegates during virtual desktop switches.


Diffs
-

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
---


Thanks,

Eike Hein

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel