[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

--- Comment #2 from Martin Gräßlin  ---
Just checked, kwin explicitly ignores key repeat events to trigger global
shortcuts

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

Martin Gräßlin  changed:

   What|Removed |Added

 CC||mgraess...@kde.org

--- Comment #1 from Martin Gräßlin  ---
oh, on X11 the shortcuts are triggered again?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D2399: New new SDDM theme

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 749 lines] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Implements the new SDDM theme.
  There's a lot of hardcoded values, but the mockup asks for it.
  It also doesn't match the mockup exactly because all grid unit sizes are just 
wrong and partly because in many cases I opted for just using the
  Plasma default.
  
  Code is written with the intention to easily port the lock screen
  All SDDM related code is now shifted into Main with Login.qml acting as
  an abstraction layer.

TEST PLAN
  Ran it, against the awesome mock data.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  sddm_stuff

REVISION DETAIL
  https://phabricator.kde.org/D2399

AFFECTED FILES
  sddm-theme/ActionButton.qml
  sddm-theme/Background.qml
  sddm-theme/BatteryIcon.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/README.txt
  sddm-theme/SessionButton.qml
  sddm-theme/UserDelegate.qml
  sddm-theme/UserList.qml
  sddm-theme/dummydata/sddm.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

stylesheed folders

[kainz.a]

Hi,

since a few days you can find in breeze-icons the posibility that folders
follow the color scheme colors.

https://kdeonlinux.wordpress.com/2016/08/08/rainbow-folders/

As visual changes for folders are very importend for the user (visible in
dolphin quite often) I'd like to discuss if we should use the stylesheed
color.

pro
+ unified layout the plasma theme, window decoration follow the color scheme
+ distros can brand default breeze easy without fork it
+ plasma designer get more power
+ no visual changes for the default color schemes (breeze and breeze-dark)

con
- new features mean new bugs (select folder in dolphin)
- visual changes via update. user can't switch to old blue folders

feedback is very welcome. please test the new feature it wasn't released in
kf 5.25 it's only inmaster

thanks
Andreas

Re: Selecting a Plasma logo

[kainz.a]

2016-08-10 23:16 GMT+02:00 Ivan Čukić :

> Hi all,
>
> I've put a few of the ideas on a panel - both on a light theme, and on
> a dark one. Also without any icon background, and on the blue
> rectangle.
>
> It also has the current KDE logo for reference.
>
> https://share.kde.org/index.php/s/b9sMKE3Nl9whJiQ
>
> I'm a bit sad to say that I don't really find any of these fitting as
> a launcher icon.
>
>
I think the current KDE logo (4th line) and the current plasma logo (3rd
line) are quite good in general I like the colored kde logo (8th line)
best.

thanks Ivan

cheers
Andreas

[Differential] [Request, 73 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adjusts the category sidebar to look like the default Breeze widget 
style.
  The width of the sidebar also adjusts (up to a certain maximum width) based 
on the labels within so it doesn't grow as wide anymore.
  
  As Plasma doesn't seem to be supporting Qt high-dpi scaling anytime soon this 
uses units to get the sizing identical to what it looks like in the other 
applications.

TEST PLAN
  You can change Breeze widget style to have a traditional frame but this 
option isn't the default and pretty hidden and I've lost all hope of getting a 
"proper" frame control anyway.
  
  Only tested with DPR of 2 on high-dpi, sizing looks identical to eg. systme 
tray
  
  F254024: Screenshot_20160810_232705.png 
  
  F254025: Screenshot_20160810_232724.png 
  
  F254026: Screenshot_20160810_232739.png 
  
  F254027: Screenshot_20160810_27.png  
While using a black and white icon in this context isn't correct (also urgh the 
triple scrollbars, I resized the window to the possible minimum though) the 
icon colorizes now like we do in other places

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Selecting a Plasma logo

[Ivan Čukić]

Hi all,

I've put a few of the ideas on a panel - both on a light theme, and on
a dark one. Also without any icon background, and on the blue
rectangle.

It also has the current KDE logo for reference.

https://share.kde.org/index.php/s/b9sMKE3Nl9whJiQ

I'm a bit sad to say that I don't really find any of these fitting as
a launcher icon.

Cheers,
Ivan

p.s. If somebody wants to play around, I can post the svg as well.

[Differential] [Closed] D2395: [Milou] Optimize and cleanup sources model

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rMILOU7bfa1a2538fc: [Milou] Optimize and cleanup sources model 
(authored by broulik).

REPOSITORY
  rMILOU Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2395?vs=5810=5815

REVISION DETAIL
  https://phabricator.kde.org/D2395

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, vhanda
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 366608] New: Brightness keyboard action does not repeat while key is pressed under Wayland

[Matthias Fauconneau via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

Bug ID: 366608
   Summary: Brightness keyboard action does not repeat while key
is pressed under Wayland
   Product: Powerdevil
   Version: 5.7.3
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: matthias.fauconn...@gmail.com

When keeping a brightness up/down key pressed under Wayland, brightness level
is changed only by one step.
PowerDevil should smoothly increment/decrement the brightness level while the
key is pressed.


Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D2395: [Milou] Optimize and cleanup sources model

[vhanda (Vishesh Handa)]

vhanda accepted this revision.
vhanda added a comment.
This revision is now accepted and ready to land.


  Looks good.

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D2395

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, vhanda
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Thomas Lübking]

> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote:
> > https://phabricator.kde.org/D2121
> 
> Anthony Fieroni wrote:
> So why not ship it?
> 
> Sebastian Kügler wrote:
> Did you read Martin's comments on the phab request?
> 
> Anthony Fieroni wrote:
> I see it make sense, because it change props on focusIn before click who 
> triggers the bug. This is correct patch to me.
> 
> Thomas Lübking wrote:
> The bug is the sheer existence of this function which is a ridiculous 
> workaround for Qt *silently* ignoring the window type flag.
> 
> Removing it there will just lower the odds that plasmashell succeeds in 
> setting the correct window type ever (along lowering the odds to do the 
> rubbish that causes the normal type)
> 
> The ::ensureWindowType function needs to be erased and the type set 
> *once* explicitly after the native window is created for the window, but 
> before it's mapped (ie. what Qt should actually do)
> 
> Right now, this is just messing around with the symptoms.
> 
> Anthony Fieroni wrote:
> Workaround or not this patch is a *must*.

No, the bug *should* be fixed, because of course the situation is ridiculuous.
But this patch isn't even a workaround but only shifts odds around and does 
nothing to actually fix the problem.

You can remove the call here as initial step, but if you stop there, you'll 
just face other variations of the bug afterwards - maybe even initially cause 
them for other users. That's what Martin objected on David's patch.

I'd however suggest to keep the discussion there. RB is afaiu not even an 
accepted system anymore but in shutdown mode.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
---


On Aug. 10, 2016, 6:28 nachm., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Aug. 10, 2016, 6:28 nachm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/
---

(Updated Авг. 10, 2016, 9:28 след обяд)


Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.


Changes
---

Set window flags only if needed.


Bugs: 350826 and 365014
https://bugs.kde.org/show_bug.cgi?id=350826
https://bugs.kde.org/show_bug.cgi?id=365014


Repository: plasma-workspace


Description
---

^^


Diffs (updated)
-

  shell/desktopview.cpp 83866dc 

Diff: https://git.reviewboard.kde.org/r/128647/diff/


Testing
---

1. open 1 or more non maximized windows
2. make left clicks periodically between window and the desktop
3. desktop is raised over opened windows *sometimes*


Thanks,

Anthony Fieroni

Re: Animate removal from Positioner?

[Marco Martin]

On Wednesday 10 August 2016 21:18:43 Michail Vourlakos wrote:
> Hello,
> 
> I am creating an alternative plasmoid for tasks and I would like your
> wisdom around QML please..
> 
> 
> At some point of my code I am using a Grid(Positioner) and a Repeater
> for the tasksModel but I can not find any way to animate the removal of
> an item from the tasks model. There are add, move, populate transitions
> but not for removals..

that's because when you remove it the thing gets deleted.
the only way would be to execute such removal in an imperative way, having an 
animation instance in the item, then calling item.animateRemoval()

but i guess if the removal happens because the model already removed the item, 
that won't help you, because the instant the item goes away from the model, 
your delegate is deleted, so i don't see (clean) solutions

-- 
Marco Martin

Re: Animate removal from Positioner?

[Kai Uwe Broulik]

Hi,

the thing with positioners like Grid and the like is that they're dumb, ie. the 
item is just gone right away and thus cannot be animated. ListView keeps the 
item around to animate it but is probably overkill for your usecase.

It could surely be done by hand but that would make it overly complex and 
error-prone which is also why we just don't do it in Task Manager.

Cheers, 
Kai Uwe

Animate removal from Positioner?

[Michail Vourlakos]

Hello,

I am creating an alternative plasmoid for tasks and I would like your 
wisdom around QML please..



At some point of my code I am using a Grid(Positioner) and a Repeater 
for the tasksModel but I can not find any way to animate the removal of 
an item from the tasks model. There are add, move, populate transitions 
but not for removals..


The only way I had found is to use the ListView component but my list 
doesnot need contentWidth and contentHeight because it shows all the 
tasks every time... I didnt use Row or Column because the plasmoid when 
changes position is the screen becomes vertical or horizontal accordingly...



So do you know any solution to animate the removal of an item from a 
positioner item in QML?



with regards,

michail

Plasma look and feel switching

[Marco Martin]

Hi all,
as i've came pretty much on a stale mate at the development of a particular 
feature, I'll try to describe it as better as i can, so maybe I can get some 
fresh ideas.
branch, mart/separateLookAndFeelLayout
review https://phabricator.kde.org/D2345

the behavior is:
* look and feel packages bring a layout.js javascript file with them
* right now it's used only if the lnf package is set in kdeglobals before the 
first time plasmashell starts
* with the new branch, the whole plasma shell will get unloaded, and reloaded 
with the new layout.js from the new selected lnf package
* plasmashell has a different config file per lnf package
* when switching from one to another, by default it would use the config file 
saved previously, if present, in order to minimize data loss (otherwise 
switching lnf becomes a very destructive operation)
* but still need an option to reset to the default layout: when switching, the 
kcm could just delete the config file before switching lnf, but to reset the 
current lnf a different way could be needed
* at the moment i have a reloadDefaultLayout() method exposed to dbus: i hate 
it as exposing a dbus method that destroys the current setup doesn't look good 
at all (again to be the least desrtuctive possible)
* a function to dump the current layout in javascript is provided by 
plasmashell, so a separate utility can create a new lnf layout from the 
current setup: makes easier creation by users to publish on kdelook.

did i explain it clearly?

as you can see on https://phabricator.kde.org/D2345 (and the very long 
discussion on it) it's still something that needs work, and there is still not 
really much agreement on it.

I really need it in for 5.8 (as look and feel packages would be a prominent 
content of the new ocs server), but time is getting close, and i'm not sure 
about it at all, in a word.. i need help :(

-- 
Marco Martin

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Anthony Fieroni]

> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote:
> > https://phabricator.kde.org/D2121
> 
> Anthony Fieroni wrote:
> So why not ship it?
> 
> Sebastian Kügler wrote:
> Did you read Martin's comments on the phab request?
> 
> Anthony Fieroni wrote:
> I see it make sense, because it change props on focusIn before click who 
> triggers the bug. This is correct patch to me.
> 
> Thomas Lübking wrote:
> The bug is the sheer existence of this function which is a ridiculous 
> workaround for Qt *silently* ignoring the window type flag.
> 
> Removing it there will just lower the odds that plasmashell succeeds in 
> setting the correct window type ever (along lowering the odds to do the 
> rubbish that causes the normal type)
> 
> The ::ensureWindowType function needs to be erased and the type set 
> *once* explicitly after the native window is created for the window, but 
> before it's mapped (ie. what Qt should actually do)
> 
> Right now, this is just messing around with the symptoms.

Workaround or not this patch is a *must*.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
---


On Авг. 10, 2016, 4:22 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Авг. 10, 2016, 4:22 след обяд)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Commented On] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> shellcorona.cpp:550
> +
> +void ShellCorona::reloadDefaultLayout()
> +{

I hate this method.
tough, i need a way from the kcm to reset the current layout to the default.
it's quite dangerous and exporting a dbus method that effectively destroys the 
current config is evil...
other ideas?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 359 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 5812.
mart added a comment.


  - add a reloadDefaultLayout method to reset layout

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=5760=5812

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2396: [Pager] Hide minimized windows

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2396

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: Zren, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128648: [Calendar DaysModel] Don't call layoutChanged() and emit dataChanged() with roles

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128648/#review98295
---


Ship it!




- David Edmundson


On Aug. 10, 2016, 1:33 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128648/
> ---
> 
> (Updated Aug. 10, 2016, 1:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> LayoutChanged causes QML to destroy all delegates and re-create them. Since 
> the number of days doesn't change but only the numbers, we can just call 
> dataChanged on all roles.
> 
> Furthermore, when agenda-related data changes, only the containsEventItems 
> role might have changed, so only emit a change for it.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.cpp 169711e 
> 
> Diff: https://git.reviewboard.kde.org/r/128648/diff/
> 
> 
> Testing
> ---
> 
> Scrolling through the calendar still properly updates the day numbers, the 
> selected day and "today" marker as well as the "has event items" badge.
> 
> Scrolling quickly through the calendar is now pretty fast and smooth but the 
> initial lag when opening the calendar for the first time is still there.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Request, 2 lines] D2396: [Pager] Hide minimized windows

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It didn't show minimized windows before I broke it in 5.7 and I think it 
shouldn't.

TEST PLAN
  Plasma/5.7

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2396

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 65 lines] D2395: [Milou] Optimize and cleanup sources model

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, vhanda.
broulik set the repository for this revision to rMILOU Milou.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Simplify queryString once, rather than during every iteration
  - Foreach instead of potentially detaching range-for
  - Use reverse iterators (new in Qt 5.6) instead of Java-style iterators
  - Remove traces of begin/endInsert/RemoveRows feature - while it would be 
nice to not reset the model with all this sorting and merging going on it's 
pretty difficult to predict where an item will end up which is probably why it 
never got implemented. It still calculated tons of indices that went unused, so 
remove this and go a different route in the future

TEST PLAN
  Seems to work

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D2395

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, vhanda
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D1514: [Milou] Optimize sources model

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D1514

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Thomas Lübking]

> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote:
> > https://phabricator.kde.org/D2121
> 
> Anthony Fieroni wrote:
> So why not ship it?
> 
> Sebastian Kügler wrote:
> Did you read Martin's comments on the phab request?
> 
> Anthony Fieroni wrote:
> I see it make sense, because it change props on focusIn before click who 
> triggers the bug. This is correct patch to me.

The bug is the sheer existence of this function which is a ridiculous 
workaround for Qt *silently* ignoring the window type flag.

Removing it there will just lower the odds that plasmashell succeeds in setting 
the correct window type ever (along lowering the odds to do the rubbish that 
causes the normal type)

The ::ensureWindowType function needs to be erased and the type set *once* 
explicitly after the native window is created for the window, but before it's 
mapped (ie. what Qt should actually do)

Right now, this is just messing around with the symptoms.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
---


On Aug. 10, 2016, 1:22 nachm., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Aug. 10, 2016, 1:22 nachm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Sebastian Kügler]

> On Aug. 10, 2016, 1:23 p.m., David Rosca wrote:
> > https://phabricator.kde.org/D2121
> 
> Anthony Fieroni wrote:
> So why not ship it?

Did you read Martin's comments on the phab request?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
---


On Aug. 10, 2016, 1:22 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Aug. 10, 2016, 1:22 p.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Review Request 128648: [Calendar DaysModel] Don't call layoutChanged() and emit dataChanged() with roles

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128648/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

LayoutChanged causes QML to destroy all delegates and re-create them. Since the 
number of days doesn't change but only the numbers, we can just call 
dataChanged on all roles.

Furthermore, when agenda-related data changes, only the containsEventItems role 
might have changed, so only emit a change for it.


Diffs
-

  src/declarativeimports/calendar/daysmodel.cpp 169711e 

Diff: https://git.reviewboard.kde.org/r/128648/diff/


Testing
---

Scrolling through the calendar still properly updates the day numbers, the 
selected day and "today" marker as well as the "has event items" badge.

Scrolling quickly through the calendar is now pretty fast and smooth but the 
initial lag when opening the calendar for the first time is still there.


Thanks,

Kai Uwe Broulik

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Anthony Fieroni]

> On Авг. 10, 2016, 4:23 след обяд, David Rosca wrote:
> > https://phabricator.kde.org/D2121

So why not ship it?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
---


On Авг. 10, 2016, 4:22 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Авг. 10, 2016, 4:22 след обяд)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
---



https://phabricator.kde.org/D2121

- David Rosca


On Aug. 10, 2016, 1:22 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Aug. 10, 2016, 1:22 p.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/
---

Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.


Bugs: 350826 and 365014
https://bugs.kde.org/show_bug.cgi?id=350826
https://bugs.kde.org/show_bug.cgi?id=365014


Repository: plasma-workspace


Description
---

^^


Diffs
-

  shell/desktopview.cpp 83866dc 

Diff: https://git.reviewboard.kde.org/r/128647/diff/


Testing
---

1. open 1 or more non maximized windows
2. make left clicks periodically between window and the desktop
3. desktop is raised over opened windows *sometimes*


Thanks,

Anthony Fieroni

[Differential] [Closed] D2356: [shell] Add a dbus call to activate the "main" application launcher

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE267b6a8dfb4a: [shell] Add a dbus call to 
activate the "main" application launcher (authored by graesslin).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2356?vs=5694=5803

REVISION DETAIL
  https://phabricator.kde.org/D2356

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 128598: system-xxx icons are available only monochrome

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128598/#review98284
---


Ship it!




Ship It!

- Marco Martin


On Aug. 5, 2016, 7:07 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128598/
> ---
> 
> (Updated Aug. 5, 2016, 7:07 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> I will remove the system-shutdown, system-restart, system-xxx colored icons 
> from breeze icons cause system-xx isn't a application it's an action icon and 
> action icons are monochrme.
> 
> Also I have some visual problems with the system colored icons
> 1. I need 32px and 16px icons one are colored and one are monochrome and 
> that's not good (don't switch between colored and monochrome)
> 2. the monochrome look better
> 3. the monochrome icons fit's to the grub to shutdown style for 5.8
> 4. the colored ones were used for Hidpi monitors instead of the monochrome 
> ones
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/system.svgz e07725e 
> 
> Diff: https://git.reviewboard.kde.org/r/128598/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> system.svgz
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/05/7db6b7d3-7d86-4684-9009-d9c21758053b__system.svgz
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

Re: Review Request 128598: system-xxx icons are available only monochrome

[Thomas Pfeiffer]

> On Aug. 5, 2016, 8:13 a.m., Marco Martin wrote:
> > don't fully understand what you want to do:
> > 
> > not have the system icons in the breeze theme?
> > having only monochrome versions in the plasma theme?
> > 
> > kickoff system (shutdown, logout etc) icons should be monochrome as well?
> > 
> > as far i understood they should be monochromr in the logout dialog and 
> > colored in kickoff/kicker?
> 
> Andreas Kainz wrote:
> remove the colored ones and have only the monochrome system icons

> kickoff system (shutdown, logout etc) icons should be monochrome as well?

Everything should be monochrome again.
It was once, but then at some point Uri decided that all icons in a certain 
size should be colored, regardless of their function. We'd like to revert that 
decision, and only have application icons in color.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128598/#review98128
---


On Aug. 5, 2016, 7:07 a.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128598/
> ---
> 
> (Updated Aug. 5, 2016, 7:07 a.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> I will remove the system-shutdown, system-restart, system-xxx colored icons 
> from breeze icons cause system-xx isn't a application it's an action icon and 
> action icons are monochrme.
> 
> Also I have some visual problems with the system colored icons
> 1. I need 32px and 16px icons one are colored and one are monochrome and 
> that's not good (don't switch between colored and monochrome)
> 2. the monochrome look better
> 3. the monochrome icons fit's to the grub to shutdown style for 5.8
> 4. the colored ones were used for Hidpi monitors instead of the monochrome 
> ones
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/system.svgz e07725e 
> 
> Diff: https://git.reviewboard.kde.org/r/128598/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> system.svgz
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/05/7db6b7d3-7d86-4684-9009-d9c21758053b__system.svgz
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

[Differential] [Commented On] D2393: Don't check current active session at all

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> powerdevilpolicyagent.cpp:426
>  } else if (!m_sdSessionInterface.isNull()) {
>  bool isActive = 
> m_sdSessionInterface.data()->property("Active").toBool();
>  

You still fetch the property, no?

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2393

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: oliverhenshaw, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

[oliverhenshaw (Oliver Henshaw)]

oliverhenshaw added a comment.


  In https://phabricator.kde.org/D2033#44650, @broulik wrote:
  
  > So, what should we do with this? Since we now have powerdevil as a separate 
binary we could savely do
  >
  >   KIdleTime::instance()->removeAllIdleTimeouts();
  >
  > without jeopardizing other kded modules.
  
  
  Another approach (untested) is sketched out at 
https://phabricator.kde.org/D2393

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2033

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sebas, oliverhenshaw
Cc: sebas, oliverhenshaw, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts

[Differential] [Request, 4 lines] D2393: Don't check current active session at all

[oliverhenshaw (Oliver Henshaw)]

oliverhenshaw created this revision.
oliverhenshaw added reviewers: Plasma, broulik.
oliverhenshaw added a subscriber: plasma-devel.
oliverhenshaw set the repository for this revision to rPOWERDEVIL Powerdevil.
oliverhenshaw added a project: Plasma.

REVISION SUMMARY
  Simply use cached value so that events processed before we process the
  notification that the session is active are treated as if the session is
  inactive - as they were likely sent when the session actually was inactive.

TEST PLAN
  Not yet compiled. Impact on consolekit systems not yet investigated.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2393

AFFECTED FILES
  daemon/powerdevilpolicyagent.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: oliverhenshaw, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Selecting a Plasma logo

[Sebastian Kügler]

On Wednesday, August 10, 2016 10:37:07 AM UTC kainz.a wrote:
> as there is no new mail since 2 days how can we find a new logo?
> 
> 1. poll of the existing logos
> 2. irc/hangout meeting with plasma vdg and the icon designers
> 3. git push

I think consensus is that we're lacking an overview, hardly anybody is able to 
tell which options are being discussed.

What we'd need first is an overview (one page / image) of all logos proposed, 
preferably in different contexts (on black / white / in panel / etc.).

Most of the people I talked to lost track of what exactly was being discussed.

Thomas, I think, agreed on making such an overview.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org

[Differential] [Accepted] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/modefallback

REVISION DETAIL
  https://phabricator.kde.org/D2330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSCREENf53805676dc0: [xrandr backend] fall back to 
preferred mode, fix crash (authored by sebas).

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2330?vs=5798=5799

REVISION DETAIL
  https://phabricator.kde.org/D2330

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Sebastian Kügler]

sebas updated this revision to Diff 5798.
sebas added a comment.


  BUG:366575

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2330?vs=5797=5798

BRANCH
  sebas/modefallback

REVISION DETAIL
  https://phabricator.kde.org/D2330

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Sebastian Kügler]

sebas updated this revision to Diff 5797.
sebas added a comment.


  - Improve conditional

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2330?vs=5796=5797

BRANCH
  sebas/modefallback

REVISION DETAIL
  https://phabricator.kde.org/D2330

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 21 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Sebastian Kügler]

sebas updated this revision to Diff 5796.
sebas added a comment.


  - Merge branch 'master' into sebas/modefallback
  - Improve conditional

REPOSITORY
  rLIBKSCREEN KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2330?vs=5638=5796

BRANCH
  sebas/modefallback

REVISION DETAIL
  https://phabricator.kde.org/D2330

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2325: Don't unconditionally emit buttonPressed on profile load

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  I see. Thanks for your investigation. I must say, though, that I would not 
expect my laptop to do anything because the lid is closed after I closed the 
lid.
  
  Since the bug was originally caused by broken monitor detection, which is 
fixed in 5.7, indeed could be reverted as to not cause regressions in a patch 
release.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2325

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, afiestas, #plasma, davidedmundson
Cc: oliverhenshaw, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> sebas wrote in xrandrconfig.cpp:556-558
> No, this part is a bit different from the above hunk, it uses the xOutput by 
> default, and if that is empty, falls back to kscreen's currentModeId or the 
> preferredModeId.

but then I would reorder it. Why call toInt() and then check afterwards whether 
that one can work at all? I would suggest to make it if-else then

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D2330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Reopened] D2325: Don't unconditionally emit buttonPressed on profile load

[oliverhenshaw (Oliver Henshaw)]

oliverhenshaw reopened this revision.
oliverhenshaw added a comment.
This revision is now accepted and ready to land.


  > I can't find any evidence about the reason this was put in there in the 
first place.
  
  'git blame' [1] shows that this was added for 
https://bugs.kde.org/show_bug.cgi?id=243618 - it should still work as intended 
as long as the screen detection works properly.
  The idea was that switching to a profile and then closing the lid should have 
the same result as closing the lid and then switching to a profile. Any 
exceptions are dealt with as inhibitions and will/should work exactly the same 
in the second case as in the first. I would suggest reverting this and perhaps 
updating the code comment.
  
  Or perhaps there's a better way to handle bug 243618 now?
  
  [1] with https://community.kde.org/Frameworks/GitOldHistory to graft in the 
old history.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2325

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, afiestas, #plasma, davidedmundson
Cc: oliverhenshaw, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 1,365 lines] D2381: Share logic for passing AbstractTasksModelIface methods to source model

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 5795.
davidedmundson added a comment.


  Synced comments

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2381?vs=5768=5795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2381

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/abstracttasksproxymodeliface.cpp
  libtaskmanager/abstracttasksproxymodeliface.h
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/flattentaskgroupsproxymodel.cpp
  libtaskmanager/flattentaskgroupsproxymodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/windowtasksmodel.cpp
  libtaskmanager/windowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128491/#review98278
---


Ship it!




Ship It!

- David Edmundson


On July 21, 2016, 2:25 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128491/
> ---
> 
> (Updated July 21, 2016, 2:25 p.m.)
> 
> 
> Review request for Plasma and John Tapsell.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> ---
> 
> Also fix the fact that cooling devices have a percentage of activity, they're 
> not boolean on or off.
> 
> I'll reverse the tabs->spaces later, if needed.
> 
> 
> Diffs
> -
> 
>   ksysguardd/Linux/acpi.h e50b281 
>   ksysguardd/Linux/acpi.c acf54e1 
> 
> Diff: https://git.reviewboard.kde.org/r/128491/diff/
> 
> 
> Testing
> ---
> 
> It works very well.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

[Differential] [Updated] D2392: [Task Manager] Allow dropping files onto tasks

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 80 lines] D2392: [Task Manager] Allow dropping files onto tasks

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This allows to drop files onto entries in the task manager. Both single and 
multiple files are supported.
  
  When all dropped items are desktop files for app, a launcher is created for 
each item.
  Otherwise the application is launched with those URLs as arguments and 
behavior depends on the application. It might open the file(s) in new tab(s) of 
an existing instance, open a new window with tabs, open new windows for each 
files, etc.
  
  BUG: 365626
  FIXED-IN: 5.8.0

TEST PLAN
  See video: https://www.youtube.com/watch?v=WHx5J_W4fqo
  Depends on https://phabricator.kde.org/D2391

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2392

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 243 lines] D2391: [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Wayland untested but compiled.
  
  (btw, serviceCache.contains and then serviceCache.value performs a double 
lookup, QHash value returns a default-constructed value for not found entries, 
so could probably be simplified to?
  
KService::Ptr service = serviceCache.value(window);
if (service) {
// ...
}

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2391

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/flattentaskgroupsproxymodel.cpp
  libtaskmanager/flattentaskgroupsproxymodel.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/windowtasksmodel.cpp
  libtaskmanager/windowtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE7516a8fb9dac: [Plasma Calendar Integration] 
Filter holiday regions case-insensitively (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2388?vs=5786=5792

REVISION DETAIL
  https://phabricator.kde.org/D2388

AFFECTED FILES
  plasmacalendarintegration/HolidaysConfig.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 69 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 10 Aug 2016 09:52:23 +
Build duration: 2 min 29 sec

CHANGE SET
Revision c8799879688febeefbf6b53d4ad01e0fd4fa2269 by kde: ([Task Manager 
ToolTipDelegate] Silence warning on startup)
  change: edit applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

[Differential] [Closed] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPc8799879688f: [Task Manager ToolTipDelegate] 
Silence warning on startup (authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2390?vs=5789=5791

REVISION DETAIL
  https://phabricator.kde.org/D2390

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2387: [System Tray] Don't reserve space for expander if it's not visible

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEcd19257085e8: [System Tray] Don't reserve 
space for expander if it's not visible (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2387?vs=5785=5790

REVISION DETAIL
  https://phabricator.kde.org/D2387

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/
---

(Updated Aug. 10, 2016, 9:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 920dbcb1e85ba76101ab291aeefe17026e57c6e2 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

commit c8fdd7ed2032b7b0664a6c9d0d56296f674abeb2 pushes a lazy fix for a
crash, but instead just leaves all signals blocked on
ContainmentInterface


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 
55d91aa9d09ee37ec523f9a16f347586db00ecd5 

Diff: https://git.reviewboard.kde.org/r/128642/diff/


Testing
---

Read the code.
Which apparently the previous person didn't do.


Thanks,

David Edmundson

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128641/
---

(Updated Aug. 10, 2016, 9:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Faure.


Changes
---

Submitted with commit 8031d80df57ce912c99561bcf54c9eb73fb498bb by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 ported an argument from
QPoint to QRectF. However, not all local invocations were updated correctly 
with one passing a QRect, which fails.

*NEEDS BACKPORTING TO 5.25*


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 
4efc1e109bbab8ef43b686be25574ed5bd66d9ce 

Diff: https://git.reviewboard.kde.org/r/128641/diff/


Testing
---

Before: Couldn't drag applet from Widget Explorer to Desktop
After: Can

Checked the other invocations are correct.


Thanks,

David Edmundson

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/
---

(Updated Aug. 10, 2016, 9:37 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Faure.


Changes
---

Submitted with commit 1ace6a46dedfb8536890f9c86e7b4fbbc55931ac by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for
adding createApplet, turning the final argument from QPoint to QRect.

If the rectangle size is nothing, it acts like the original code.

Despite this being private API (ish) there is a hacks in plasma-
workspace that call methods on the view via QMetaObject invoke. This
obviously fails. As we need compatibility for Plasma/5.7 and earlier a
compatibility slot needs to stay.


*THIS NEEDS BACKPORTING TO 5.25*


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.h 
c058f8358b4aa123749959a3de5b0667d7a1fecc 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 
4efc1e109bbab8ef43b686be25574ed5bd66d9ce 

Diff: https://git.reviewboard.kde.org/r/128640/diff/


Testing
---

Before: alternatives context menu on the desktop just deleted the applet
Now: works


Thanks,

David Edmundson

[Differential] [Accepted] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

[hein (Eike Hein)]

hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2390

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D2390: [Task Manager ToolTipDelegate] Silence warning on startup

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The MPRIS data sources are queried asynchronously so data in there might not 
yet be available on startup causing a warning.

TEST PLAN
  Media controls still work, I no longer get
  
"Cannot read property DesktopEntry of undefined"
  
  on startup

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2390

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2387: [System Tray] Don't reserve space for expander if it's not visible

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2387

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Selecting a Plasma logo

[kainz.a]

as there is no new mail since 2 days how can we find a new logo?

1. poll of the existing logos
2. irc/hangout meeting with plasma vdg and the icon designers
3. git push

andreas

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/#review98270
---


Ship it!




aww, crap, didn't see that :/
thanks for noticing

- Marco Martin


On Aug. 9, 2016, 11:03 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128640/
> ---
> 
> (Updated Aug. 9, 2016, 11:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for
> adding createApplet, turning the final argument from QPoint to QRect.
> 
> If the rectangle size is nothing, it acts like the original code.
> 
> Despite this being private API (ish) there is a hacks in plasma-
> workspace that call methods on the view via QMetaObject invoke. This
> obviously fails. As we need compatibility for Plasma/5.7 and earlier a
> compatibility slot needs to stay.
> 
> 
> *THIS NEEDS BACKPORTING TO 5.25*
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 
> c058f8358b4aa123749959a3de5b0667d7a1fecc 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 
> 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 
> 
> Diff: https://git.reviewboard.kde.org/r/128640/diff/
> 
> 
> Testing
> ---
> 
> Before: alternatives context menu on the desktop just deleted the applet
> Now: works
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Accepted] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2388

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D2388: [Plasma Calendar Integration] Filter holiday regions case-insensitively

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  PlasmaCore.SortFilterModel for some reason doesn't have a case-sensitivity 
option and filterString always filters case-sensitively whereas filterRegExp 
explicitly sets it to case-insensitive, so we'll use that for now.
  
  BUG: 365621
  FIXED-IN: 5.7.4

TEST PLAN
  Entered "ger", got "Germany", previously I had to enter "Ger"

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2388

AFFECTED FILES
  plasmacalendarintegration/HolidaysConfig.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 8 lines] D2387: [System Tray] Don't reserve space for expander if it's not visible

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If all system tray icons are visible the arrow would hide but the reserved 
space for the system tray would not change leavnig a gap.
  
  BUG: 365636
  FIXED-IN: 5.7.4

TEST PLAN
  Tested both vertical and horizontal panel with and without all items shown 
enabled, worked, margins around system tray stayed evenly distributed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2387

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve marked 28 inline comments as done.
bdhruve added a comment.


  Mark comments as done.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  So, what should we do with this? Since we now have powerdevil as a separate 
binary we could savely do
  
KIdleTime::instance()->removeAllIdleTimeouts();
  
  without jeopardizing other kded modules.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2033

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sebas, oliverhenshaw
Cc: sebas, oliverhenshaw, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts

[Differential] [Updated, 351 lines] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 5781.
bdhruve added a comment.


  Fix keyEvent code for non-X11 platforms.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1989?vs=5755=5781

BRANCH
  kwinqml

REVISION DETAIL
  https://phabricator.kde.org/D1989

AFFECTED FILES
  config-kwin.h.cmake
  main_wayland.cpp
  plugins/CMakeLists.txt
  plugins/qml/CMakeLists.txt
  plugins/qml/kwinqml/CMakeLists.txt
  plugins/qml/kwinqml/kwinplugin.cpp
  plugins/qml/kwinqml/kwinplugin.h
  plugins/qml/kwinqml/kwinqml.cpp
  plugins/qml/kwinqml/kwinqml.h
  plugins/qml/kwinqml/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2325: Don't unconditionally emit buttonPressed on profile load

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVIL48c3dca61d7c: Don't unconditionally emit 
buttonPressed on profile load (authored by broulik).

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2325?vs=5603=5782

REVISION DETAIL
  https://phabricator.kde.org/D2325

AFFECTED FILES
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, afiestas, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/#review98262
---



Can we change this to use QSignalBlocker, returning and having to take care of 
unblocking again isn't future-proof as we have just experienced.

- Kai Uwe Broulik


On Aug. 9, 2016, 11:48 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128642/
> ---
> 
> (Updated Aug. 9, 2016, 11:48 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> commit c8fdd7ed2032b7b0664a6c9d0d56296f674abeb2 pushes a lazy fix for a
> crash, but instead just leaves all signals blocked on
> ContainmentInterface
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 
> 55d91aa9d09ee37ec523f9a16f347586db00ecd5 
> 
> Diff: https://git.reviewboard.kde.org/r/128642/diff/
> 
> 
> Testing
> ---
> 
> Read the code.
> Which apparently the previous person didn't do.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>