[Samba] Joining a win2k3 ads fails

2007-11-25 Thread Lex Brugman
I've just tried the same configuration on a third computer (gentoo on a x86 
platform, just like the
other working box) and it worked, i don't think it is a w2k3 problem
Please note that the problem occurs on an ARM box and is running debian (the 
only difference in
compared to the other 2 boxes where it works).
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re[2]: [Samba] INTERNAL ERROR: Signal 11 in pid xxxx (3.0.26a)

2007-11-25 Thread Marcin Kucharczyk
Hello,

Sunday, November 25, 2007, 12:25:27 AM, you wrote:

DV [EMAIL PROTECTED] wrote:
 I have a problem with samba 3.0.26a (from ports) on FreeBSD (amd64, 
 SMP, 6.2 RELEASE). My log.smbd looks like below:

 [...]

 [2007/11/24 16:55:22, 0] 
 /usr/ports/net/samba3/work/samba-3.0.26a/source/lib/pidfile.c:pidfile_create(112)
  

  ERROR: smbd is already running. File /var/run/smbd.pid exists and 
 process id 1961 is running.

 --- /var/run/smbd.pid exists, becase the error is created after 
 unexpected system shutdown...
DV What os the unexpected system shutdown?  Power failure?  Reset button 
DV after system freeze?

The power failure.

 [2007/11/24 16:59:53, 0] lib/util_tdb.c:tdb_log(662)
  tdb(/var/db/samba/gencache.tdb): tdb_reopen: open failed (No such 
 file or directory)
 [2007/11/24 16:59:53, 0] smbd/server.c:open_sockets_smbd(572)
  tdb_reopen_all failed.
 [2007/11/24 16:59:53, 0] lib/util.c:smb_panic(1632)
  PANIC (pid 2621): tdb_reopen_all failed.
 [2007/11/24 16:59:53, 0] lib/fault.c:fault_report(41)
DV The filesystem didn't flush it's buffers on shutdown.  Unexpectedly, 
DV files are missing and/or corrupted that should be there on startup.

Probably corrupted, becouse I checked: the files exist...

 And after start samba works properly until next unexpected system 
 restart  
DV You need to fix this and ensure you're using a journaled file system 
DV with whatever option is available for the safest, most conservative 
DV journaling mode.

The problem started after 3.0.26a upgrade. I had 3.0.32c run without any 
problems.

 Without deleting /var/db/samba, than the samba will start and 
 procedure described on the start of this message will be repeated  
DV You should be able to delete /var/db/samba (plus maybe the pid file) and
DV restart samba.  Samba will create any tdb files it needs like the 
DV initial startup.

Tried ... reinstall was required

Some mor information:

It looks like the same or similar problem:
  http://lists.samba.org/archive/samba/2007-August/134620.html

My system works with ayhlion 64 x2, but I had similar problem on single 
processor configuration: pentium 4 and duron too. The problem apears not only 
after power failure, but also after samba upgrade from ports - make deinstall 
reinstall. /var/db/samba need to be deleted before reinstall becase samba 
3.0.26a has the problem with start with tdb files form 3.0.23c.

-- 
Best regards,
 Marcin  K.  mailto:[EMAIL PROTECTED]
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[Samba] FW: Please if you advise

2007-11-25 Thread Abdulhak, Najwa TPD

Dears, 

Any feed back please. 

Najwa
  -Original Message-
 From: Abdulhak, Najwa TPD  
 Sent: Thursday, November 22, 2007 1:31 PM
 To:   'samba@lists.samba.org'
 Subject:  Please if you advise
 
 Dears,
  I've got a problem building samba 3.0.27 on Solaria 8 box.,
 Configuration is successful with ,  ./configure --with-pam --with-syslog
 --with-ldapsam --with-automount  But make gives the following output.
 ###
 Using FLAGS  =  -O -D_SAMBA_BUILD_=3
 -I/export/home/samba/samba-3.0.27a/source/iniparser/src -Iinclude
 -I./include  -I. -I. -I./lib/
 replace -I./lib/talloc -I./tdb/include -I./libaddns -I./librpc
 -DHAVE_CONFIG_H  -D_LARGEFILE_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -
 DLDAP_DEPRECATED -DSUNOS5-I/export/home/samba/samba-3.0.27a/source/lib
 -D_SAMBA_BUILD_=3
   PICFLAG= -fPIC
   LIBS   = -lsendfile -lresolv -lnsl -lsocket -ldl
   LDFLAGS= -pie -lthread
   DYNEXP = 
   LDSHFLAGS  = -G -lthread
   SHLIBEXT   = so
   SONAMEFLAG = -Wl,-soname=
 Compiling dynconfig.c
 In file included from include/smb.h:1846,
  from include/includes.h:665,
  from
 /export/home/samba/samba-3.0.27a/source/dynconfig.c:21:
 include/popt_common.h:24:18: popt.h: No such file or directory
 The following command failed:
 gcc  -O -D_SAMBA_BUILD_=3
 -I/export/home/samba/samba-3.0.27a/source/iniparser/src -Iinclude
 -I./include  -I. -I. -I./lib/replace -I./lib
 /talloc -I./tdb/include -I./libaddns -I./librpc -DHAVE_CONFIG_H
 -D_LARGEFILE_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DLDAP_DEPRECATE
 D -DSUNOS5-I/export/home/samba/samba-3.0.27a/source/lib
 -D_SAMBA_BUILD_=3 -DCONFIGFILE=/usr/local/samba/lib/smb.conf
 -DSBINDIR=/u
 sr/local/samba/sbin -DBINDIR=/usr/local/samba/bin
 -DLMHOSTSFILE=/usr/local/samba/lib/lmhosts
 -DSWATDIR=/usr/local/samba/swat  -DLO
 CKDIR=/usr/local/samba/var/locks -DPIDDIR=/usr/local/samba/var/locks
 -DLIBDIR=/usr/local/samba/lib  -DLOGFILEBASE=/usr/local/samba
 /var -DSHLIBEXT=so -DCONFIGDIR=/usr/local/samba/lib
 -DSMB_PASSWD_FILE=/usr/local/samba/private/smbpasswd
 -DPRIVATE_DIR=/usr/local
 /samba/private -fPIC -c
 /export/home/samba/samba-3.0.27a/source/dynconfig.c -o dynconfig.o
 *** Error code 1
 make: Fatal error: Command failed for target `dynconfig.o'
 ##
 Kindly if you advise
 Najwa
  
 
 
 
 
 
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[Samba] Compiling dynconfig.c with make command

2007-11-25 Thread Abdulhak, Najwa TPD




Dears, 

Any feed back please. 

Najwa
  -Original Message-
 From: Abdulhak, Najwa TPD  
 Sent: Thursday, November 22, 2007 1:31 PM
 To:   'samba@lists.samba.org'
 Subject:  Please if you advise
 
 Dears,
  I've got a problem building samba 3.0.27 on Solaria 8 box.,
 Configuration is successful with ,  ./configure --with-pam --with-syslog
 --with-ldapsam --with-automount  But make gives the following output.
 ###
 Using FLAGS  =  -O -D_SAMBA_BUILD_=3
 -I/export/home/samba/samba-3.0.27a/source/iniparser/src -Iinclude
 -I./include  -I. -I. -I./lib/
 replace -I./lib/talloc -I./tdb/include -I./libaddns -I./librpc
 -DHAVE_CONFIG_H  -D_LARGEFILE_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -
 DLDAP_DEPRECATED -DSUNOS5-I/export/home/samba/samba-3.0.27a/source/lib
 -D_SAMBA_BUILD_=3
   PICFLAG= -fPIC
   LIBS   = -lsendfile -lresolv -lnsl -lsocket -ldl
   LDFLAGS= -pie -lthread
   DYNEXP = 
   LDSHFLAGS  = -G -lthread
   SHLIBEXT   = so
   SONAMEFLAG = -Wl,-soname=
 Compiling dynconfig.c
 In file included from include/smb.h:1846,
  from include/includes.h:665,
  from
 /export/home/samba/samba-3.0.27a/source/dynconfig.c:21:
 include/popt_common.h:24:18: popt.h: No such file or directory
 The following command failed:
 gcc  -O -D_SAMBA_BUILD_=3
 -I/export/home/samba/samba-3.0.27a/source/iniparser/src -Iinclude
 -I./include  -I. -I. -I./lib/replace -I./lib
 /talloc -I./tdb/include -I./libaddns -I./librpc -DHAVE_CONFIG_H
 -D_LARGEFILE_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DLDAP_DEPRECATE
 D -DSUNOS5-I/export/home/samba/samba-3.0.27a/source/lib
 -D_SAMBA_BUILD_=3 -DCONFIGFILE=/usr/local/samba/lib/smb.conf
 -DSBINDIR=/u
 sr/local/samba/sbin -DBINDIR=/usr/local/samba/bin
 -DLMHOSTSFILE=/usr/local/samba/lib/lmhosts
 -DSWATDIR=/usr/local/samba/swat  -DLO
 CKDIR=/usr/local/samba/var/locks -DPIDDIR=/usr/local/samba/var/locks
 -DLIBDIR=/usr/local/samba/lib  -DLOGFILEBASE=/usr/local/samba
 /var -DSHLIBEXT=so -DCONFIGDIR=/usr/local/samba/lib
 -DSMB_PASSWD_FILE=/usr/local/samba/private/smbpasswd
 -DPRIVATE_DIR=/usr/local
 /samba/private -fPIC -c
 /export/home/samba/samba-3.0.27a/source/dynconfig.c -o dynconfig.o
 *** Error code 1
 make: Fatal error: Command failed for target `dynconfig.o'
 ##
 Kindly if you advise
 Najwa
  
 
 
 
 
 
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] INTERNAL ERROR: Signal 11 in pid xxxx (3.0.26a)

2007-11-25 Thread Doug VanLeuven

Marcin Kucharczyk wrote:

DV You should be able to delete /var/db/samba (plus maybe the pid file) and
DV restart samba.  Samba will create any tdb files it needs like the 
DV initial startup.


Tried ... reinstall was required

Some mor information:

It looks like the same or similar problem:
  http://lists.samba.org/archive/samba/2007-August/134620.html

My system works with ayhlion 64 x2, but I had similar problem on single 
processor configuration: pentium 4 and duron too. The problem apears not only 
after power failure, but also after samba upgrade from ports - make deinstall 
reinstall. /var/db/samba need to be deleted before reinstall becase samba 
3.0.26a has the problem with start with tdb files form 3.0.23c.
  

Better file a bug report then.
https://bugzilla.samba.org/enter_bug.cgi


Regards, Doug

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] INTERNAL ERROR: Signal 11 in pid xxxx (3.0.26a)

2007-11-25 Thread Volker Lendecke
On Sun, Nov 25, 2007 at 05:29:52AM -0800, Doug VanLeuven wrote:
 Marcin Kucharczyk wrote:
 DV You should be able to delete /var/db/samba (plus maybe the pid file) 
 and
 DV restart samba.  Samba will create any tdb files it needs like the 
 DV initial startup.
 
 Tried ... reinstall was required
 
 Some mor information:
 
 It looks like the same or similar problem:
   http://lists.samba.org/archive/samba/2007-August/134620.html

This particular bug report is highly unlikely to be a Samba
problem. Also, I have a hard time to believe that you have
to really deinstall Samba after a system crash. It *is*
definitely possible to restart Samba from whatever state the
system is in, possibly by removing tdb files. Removing and
recompiling the daemons is definitely unnecessary. You might
want to see what this removing/reinstalling really does.

Volker


pgpUHOVqv12lL.pgp
Description: PGP signature
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] connection to IPC$ denied due to security descriptor

2007-11-25 Thread richid

I don't have any valid users directive set in my global section either.
Your confs look good to me Karol, but what do I know?  Maybe someone else
can shed some light on this...



Karol Makowski wrote:
 
 Marc-Henri PAMISEUX pisze:
 I've just find why ;)
 It's in my smb.conf, there is a problem with directive:
   valid users = @SmbDomAdmins,@SmbDomUsers,@SmbDomGuests,@SmbUsers
 please, comment it !

   
 I don't have any valid directives in my global section.
 There must not be any valid users directive in the Global section. By
 the way, you have to set it in each share definition.

   
 There are not
 I hope that it will be resolv your error ;)
 If my answer did not give you satisfaction, can you post your smb.conf
 file ?
   
 Ok, http://prozac.bsdzine.org/~spaceman/samba
 
 I hope someone will find any errors. As i wrote before I can access 
 shares and I can join domain, but
 I can't log into it.
 
 -- 
 Karol Makowski
 KOELNER SA IT Department
 mailto: [EMAIL PROTECTED]
 [mobile: +48 661 94 00 57] [office: +48 71 32 09 287]
 jid: [EMAIL PROTECTED]
 
 
 
 
 
 -- 
 To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/listinfo/samba
 
 

-- 
View this message in context: 
http://www.nabble.com/connection-to-IPC%24-denied-due-to-security-descriptor-tf4828629.html#a13937265
Sent from the Samba - General mailing list archive at Nabble.com.

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[Samba] NT_STATUS_NO_LOGON_SERVERS errors sporadically occurring

2007-11-25 Thread Jason Haar
Hi there

I have samba-3.0.27a rolled out over a large number of servers, and
every once in a while one of them will start failing to allow people to
connect, with winbind reporting NT_STATUS_NO_LOGON_SERVERS, and
ntlm_auth failing with NT_STATUS_NO_LOGON_SERVERS: No logon servers.
The same problem occurred with earlier versions too.

I think I've tracked down the cause of the problem as being our fault,
but Samba really isn't handling it well. We have a 10.* network, and
servers with dual Ethernet cards, and sometimes/somehow the IP address
of the unused 2nd card (a 192.168.* address) starts getting broadcast
onto our Active Directory as being a domain controller IP. Then if
winbind decides to choose that address, it all starts failing, as that
address space isn't reachable.

If I do a nslookup domain.AD I get a listing of all our valid DC 10.*
addresses back - plus the unwanted 192.168 address - but it appears that
sometimes winbind decides that is the valid address, and won't try any
of the other addresses? And then you get the NT_STATUS_NO_LOGON_SERVERS
- as it isn't reachable.

Here's some excepts from /var/log/samba/log.wb-DOMAIN


ads_find_dc: looking for realm 'domain.AD'
get_sorted_dc_list: attempting lookup for name  domain.AD (sitename
NULL) using [ads]
sitename_fetch: Returning sitename for  domain.AD: correct-sitename
name domain.AD#20 found
get_dc_list: negative entry domain.AD removed from DC list
get_dc_list: returning 1 ip addresses in an ordered list
get_dc_list: 192.168.234.235:389


those last two lines imply why this problem occurs, but this problem
isn't being noticed within AD itself - I think Microsoft actually uses
ICMP pings to test DCs are reachable? Does Samba? Also, I have no idea
why it returns only one, invalid IP - nslookup shows this particular
domain has 13 domain controller IPs listed - including the one 192.168 one.

Obviously to fix it I just have to whine at our AD people until they
clean out this bogus DC IP - but shouldn't Samba work its way around
this? As an added advantage, ping tests could even ensure Samba connects
to the closest DC by measuring the latency...?

Thanks!

-- 
Cheers

Jason Haar
Information Security Manager, Trimble Navigation Ltd.
Phone: +64 3 9635 377 Fax: +64 3 9635 417
PGP Fingerprint: 7A2E 0407 C9A6 CAF6 2B9F 8422 C063 5EBB FE1D 66D1

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] NT_STATUS_NO_LOGON_SERVERS errors sporadically occurring

2007-11-25 Thread Jeremy Allison
On Mon, Nov 26, 2007 at 09:51:18AM +1300, Jason Haar wrote:
 
 If I do a nslookup domain.AD I get a listing of all our valid DC 10.*
 addresses back - plus the unwanted 192.168 address - but it appears that
 sometimes winbind decides that is the valid address, and won't try any
 of the other addresses? And then you get the NT_STATUS_NO_LOGON_SERVERS
 - as it isn't reachable.
 
 Here's some excepts from /var/log/samba/log.wb-DOMAIN
 
 
 ads_find_dc: looking for realm 'domain.AD'
 get_sorted_dc_list: attempting lookup for name  domain.AD (sitename
 NULL) using [ads]
 sitename_fetch: Returning sitename for  domain.AD: correct-sitename
 name domain.AD#20 found
 get_dc_list: negative entry domain.AD removed from DC list
 get_dc_list: returning 1 ip addresses in an ordered list
 get_dc_list: 192.168.234.235:389
 
 
 those last two lines imply why this problem occurs, but this problem
 isn't being noticed within AD itself - I think Microsoft actually uses
 ICMP pings to test DCs are reachable? Does Samba? Also, I have no idea
 why it returns only one, invalid IP - nslookup shows this particular
 domain has 13 domain controller IPs listed - including the one 192.168 one.
 
 Obviously to fix it I just have to whine at our AD people until they
 clean out this bogus DC IP - but shouldn't Samba work its way around
 this? As an added advantage, ping tests could even ensure Samba connects
 to the closest DC by measuring the latency...?

We should notice this address is bad and add it to the negative
connection cache once we fail to connect - we actually use a lot
of techniques to ensure we don't get stuck on a bad DC (server
affinity cache, negative connection cache etc.). Is there a
chance you can get me a debug level 10 when you're running into
this problem so I can see what is going on ?

Jeremy.
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


Re: [Samba] connection to IPC$ denied due to security descriptor

2007-11-25 Thread Edmundo Valle Neto

richid escreveu:

Hey all,

I have a fileserver running Debian Etch and Samba 3.0.24 that I use to serve
media and private home directories.  I have a couple roommates, and
therefore have a couple accounts on the box for those users.  I had
everything working perfectly until last week when my system drive took a
crap.  I've reinstalled everything exactly the same (I think?) but now I am
having problems with some accounts not being able to connect to the shares. 
My username can connect to my home share and the communal media share just

fine.  When I try to connect to another users home share or to the media
share with their username, I keep getting the password dialog box.  I've
ensured that they are in smbpasswd and that their password is correct.  I've
also verified this using smbclient.  


DETAILS:

The log file is reporting this error when I try to connect:
make_connection: connection to IPC$ denied due to security descriptor.

Here is output from smbclient:
[EMAIL PROTECTED]:~$ smbclient //warehouse/media -U bob
Password: 
Domain=[WAREHOUSE] OS=[Unix] Server=[Samba 3.0.24]

smb: \ ls
  .   D0  Thu Oct 18 11:25:22
2007
  ..  D0  Wed Nov  7 21:47:06
2007
  audio   D0  Tue Nov 13 23:40:25
2007
  downloads   D0  Tue Nov 13 23:41:11
2007
  video   D0  Thu Nov 15 23:00:34
2007

44708 blocks of size 33553920. 25310 blocks available
smb: \ 


Here is my smb.conf:

[global]
   netbios name = warehouse
   server string = warehouse
   dns proxy = no
   log file = /var/log/samba/log.%m
   max log size = 1000
   syslog = 0
   panic action = /usr/share/samba/panic-action %d
   security = user
   encrypt passwords = true
   passdb backend = tdbsam
   obey pam restrictions = yes
   invalid users = root
   passwd program = /usr/bin/passwd %u
   passwd chat = *Enter\snew\sUNIX\spassword:* %n\n
*Retype\snew\sUNIX\spassword:* %n\n 
   socket options = TCP_NODELAY

   domain master = auto

force user = %U
force group = users

[homes]
   comment = Home Directories
   browseable = no
   writable = yes
   create mask = 0700
   directory mask = 0700
   force group = %G
   valid users = %S

[media]
   comment = Media
   path = /mnt/storage/media
   browsable = yes
   writeable = yes
   create mask = 0775
   directory mask = 0775
   #guest ok = yes
   hide files = /*.dat/


It's pretty basic, I'm not doing anything special here.  Anyone have any
idea what the problem is?  I've also read a couple other threads, and have
already tried removing the /var/run/samba/share_info.tdb file and restarting
Samba, but that hasn't worked.  I'm really stumped on this one, anyone else?

Thanks in advance,
Rich
  


I have something similar with the computers in my home using Ubuntu 
(that uses almost the same samba package), I can say one thing, it 
doesn't seems to triggered with something inside share_info.tdb, putting 
the line force group = users (that I think I never used before) gives 
me make_connection: connection to IPC$ denied due to security 
descriptor. errors when I log on a Windows XP in the same network, and 
it appears to happen when XP tries to connect to samba with the guest 
account to get the list of shares. But I haven't noted any problem 
because of that. Samba continues to accept connections using already 
created accounts.


So, I don't have sure if your problem has anything to do with that error 
message.


Testparm gives you any error?
Listing the shares with these accounts work? smbclient -L localhost 
-Uanyuser%password ?


Regards.

Edmundo Valle Neto
--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba


[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-368-g41e0768

2007-11-25 Thread Volker Lendecke
The branch, v3-2-test has been updated
   via  41e07682dc1fa535ddaf405efa26fabb33c8bbf9 (commit)
  from  85a84f72ffc440fb71744cb72de2dba07793123c (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -
commit 41e07682dc1fa535ddaf405efa26fabb33c8bbf9
Author: Volker Lendecke [EMAIL PROTECTED]
Date:   Sun Nov 25 12:54:52 2007 +0100

In libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT

Thanks to SATOH Fumiyasu!

This fixes bug 4974

---

Summary of changes:
 source/libsmb/clierror.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/libsmb/clierror.c b/source/libsmb/clierror.c
index 2232ee2..c9c5a6c 100644
--- a/source/libsmb/clierror.c
+++ b/source/libsmb/clierror.c
@@ -239,6 +239,7 @@ static const struct {
 {NT_STATUS_INVALID_HANDLE, EBADF},
 {NT_STATUS_ACCESS_DENIED, EACCES},
 {NT_STATUS_OBJECT_NAME_NOT_FOUND, ENOENT},
+{NT_STATUS_OBJECT_PATH_NOT_FOUND, ENOENT},
 {NT_STATUS_SHARING_VIOLATION, EBUSY},
 {NT_STATUS_OBJECT_PATH_INVALID, ENOTDIR},
 {NT_STATUS_OBJECT_NAME_COLLISION, EEXIST},


-- 
Samba Shared Repository


svn commit: samba r26111 - in branches/SAMBA_4_0/source/torture/rpc: .

2007-11-25 Thread vlendec
Author: vlendec
Date: 2007-11-25 13:38:07 + (Sun, 25 Nov 2007)
New Revision: 26111

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26111

Log:
Fix an uninitialized variable
Modified:
   branches/SAMBA_4_0/source/torture/rpc/dfs.c


Changeset:
Modified: branches/SAMBA_4_0/source/torture/rpc/dfs.c
===
--- branches/SAMBA_4_0/source/torture/rpc/dfs.c 2007-11-25 04:53:54 UTC (rev 
26110)
+++ branches/SAMBA_4_0/source/torture/rpc/dfs.c 2007-11-25 13:38:07 UTC (rev 
26111)
@@ -503,7 +503,7 @@
const char *dir = SMBTORTURE_DFS_DIRNAME;
const char *path = SMBTORTURE_DFS_PATHNAME;
struct smbcli_state *cli;
-   bool ret;
+   bool ret = true;
 
printf(Testing StdRoot\n);
 



svn commit: samba r26112 - in branches/SAMBA_4_0/source/lib/ldb: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 14:26:16 + (Sun, 25 Nov 2007)
New Revision: 26112

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26112

Log:
Do proper error checking in __contains__.
Modified:
   branches/SAMBA_4_0/source/lib/ldb/ldb.i


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/ldb.i
===
--- branches/SAMBA_4_0/source/lib/ldb/ldb.i 2007-11-25 13:38:07 UTC (rev 
26111)
+++ branches/SAMBA_4_0/source/lib/ldb/ldb.i 2007-11-25 14:26:16 UTC (rev 
26112)
@@ -29,8 +29,6 @@
 
 %{
 
-/* Include headers */
-
 #include stdint.h
 #include stdbool.h
 #include talloc.h
@@ -80,10 +78,6 @@
Message can not be None);
 }
 
-/* 
- * Wrap a small bit of talloc
- */
-
 /*
  * Wrap struct ldb_val
  */
@@ -133,7 +127,6 @@
 //talloc_free($1);
 }
 
-
 /*
  * Wrap struct ldb_result
  */
@@ -413,8 +406,8 @@
 %typemap(in,numinputs=1) (void (*debug)(void *context, enum ldb_debug_level 
level, const char *fmt, va_list ap),
 void *context) {
 $1 = py_ldb_debug;
-/* FIXME: Should be decreased somewhere as well. Perhaps register a 
destructor and 
-   tie it to the ldb context ? */
+/* FIXME: Should be decreased somewhere as well. Perhaps register a 
+   destructor and tie it to the ldb context ? */
 Py_INCREF($input);
 $2 = $input;
 }
@@ -518,16 +511,13 @@
 ldb_error transaction_cancel();
 
 #ifdef SWIGPYTHON
-bool __contains__(ldb_dn *dn)
+%typemap(in,numinputs=0) struct ldb_result **result_as_bool (struct 
ldb_result *tmp) { $1 = tmp; }
+%typemap(argout) struct ldb_result **result_as_bool { $result = 
((*$1)-count  0)?Py_True:Py_False; }
+   
 %typemap(freearg) struct ldb_result **result_as_bool { 
talloc_free(*$1); }
+ldb_error __contains__(ldb_dn *dn, struct ldb_result **result_as_bool)
 {
-struct ldb_result *result;
-
-int ret = ldb_search($self, dn, LDB_SCOPE_BASE, NULL, NULL, 
- result);
-
-/* FIXME: Check ret and set exception if necessary */
-
-return result-count  0;
+return ldb_search($self, dn, LDB_SCOPE_BASE, NULL, NULL, 
+ result_as_bool);
 }
 
 PyObject *parse_ldif(const char *s)



svn commit: samba r26113 - in branches/SAMBA_4_0/source: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 15:28:41 + (Sun, 25 Nov 2007)
New Revision: 26113

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26113

Log:
Build tdb python bindings even when not using system tdb.
Modified:
   branches/SAMBA_4_0/source/configure.ac


Changeset:
Modified: branches/SAMBA_4_0/source/configure.ac
===
--- branches/SAMBA_4_0/source/configure.ac  2007-11-25 14:26:16 UTC (rev 
26112)
+++ branches/SAMBA_4_0/source/configure.ac  2007-11-25 15:28:41 UTC (rev 
26113)
@@ -37,7 +37,6 @@
 
 SMB_EXT_LIB_FROM_PKGCONFIG(LIBTDB, tdb = 1.1.0,
[
-   SMB_INCLUDE_MK(lib/tdb/python.mk) 
],
[
m4_include(lib/tdb/libtdb.m4)
@@ -45,6 +44,8 @@
]
 )
 
+SMB_INCLUDE_MK(lib/tdb/python.mk) 
+
 SMB_EXT_LIB_FROM_PKGCONFIG(LIBLDB, ldb = 0.9.1,
[
SMB_INCLUDE_MK(lib/ldb/ldb_ildap/config.mk)



svn commit: samba r26114 - in branches/SAMBA_4_0/source: lib/ldb lib/tdb scripting/python

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 15:34:12 + (Sun, 25 Nov 2007)
New Revision: 26114

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26114

Log:
Allow keyword-arguments.
Modified:
   branches/SAMBA_4_0/source/lib/ldb/setup.py
   branches/SAMBA_4_0/source/lib/tdb/setup.py
   branches/SAMBA_4_0/source/scripting/python/config.mk


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/setup.py
===
--- branches/SAMBA_4_0/source/lib/ldb/setup.py  2007-11-25 15:28:41 UTC (rev 
26113)
+++ branches/SAMBA_4_0/source/lib/ldb/setup.py  2007-11-25 15:34:12 UTC (rev 
26114)
@@ -10,5 +10,6 @@
   license=LGPLv3,
   keywords=[ldap,ldb,db,ldif],
   ext_modules=[Extension('_ldb', ['ldb.i'], include_dirs=['include'],
+ swig_opts=[-keyword],
  library_dirs=[lib], libraries=['ldb','ldap'])],
   )

Modified: branches/SAMBA_4_0/source/lib/tdb/setup.py
===
--- branches/SAMBA_4_0/source/lib/tdb/setup.py  2007-11-25 15:28:41 UTC (rev 
26113)
+++ branches/SAMBA_4_0/source/lib/tdb/setup.py  2007-11-25 15:34:12 UTC (rev 
26114)
@@ -6,5 +6,5 @@
   version='1.0',
   url=http://tdb.samba.org/;,
   ext_modules=[Extension('_tdb', ['tdb.i'], include_dirs=['include'],
-  library_dirs=[.], libraries=['tdb'], swig_opts=[-noproxydel])],
+  library_dirs=[.], libraries=['tdb'], swig_opts=[-keyword])],
 )

Modified: branches/SAMBA_4_0/source/scripting/python/config.mk
===
--- branches/SAMBA_4_0/source/scripting/python/config.mk2007-11-25 
15:28:41 UTC (rev 26113)
+++ branches/SAMBA_4_0/source/scripting/python/config.mk2007-11-25 
15:34:12 UTC (rev 26114)
@@ -20,7 +20,7 @@
 .SUFFIXES: _wrap.c .i
 
 .i_wrap.c:
-   $(SWIG) -Wall -I$(srcdir)/scripting/swig -python $
+   $(SWIG) -Wall -I$(srcdir)/scripting/swig -python -keyword $
 
 clean::
@echo Removing SWIG output files



svn commit: samba r26115 - in branches/4.0-python/source: auth auth/credentials auth/gensec auth/ntlmssp param

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 15:56:39 + (Sun, 25 Nov 2007)
New Revision: 26115

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26115

Log:
Fix includes.
Modified:
   branches/4.0-python/source/auth/auth_anonymous.c
   branches/4.0-python/source/auth/auth_developer.c
   branches/4.0-python/source/auth/auth_simple.c
   branches/4.0-python/source/auth/auth_winbind.c
   branches/4.0-python/source/auth/credentials/credentials.c
   branches/4.0-python/source/auth/credentials/credentials_files.c
   branches/4.0-python/source/auth/gensec/gensec_gssapi.c
   branches/4.0-python/source/auth/gensec/gensec_krb5.c
   branches/4.0-python/source/auth/gensec/schannel.c
   branches/4.0-python/source/auth/gensec/schannel_state.c
   branches/4.0-python/source/auth/ntlmssp/ntlmssp_server.c
   branches/4.0-python/source/auth/sam.c
   branches/4.0-python/source/param/secrets.c


Changeset:
Modified: branches/4.0-python/source/auth/auth_anonymous.c
===
--- branches/4.0-python/source/auth/auth_anonymous.c2007-11-25 15:34:12 UTC 
(rev 26114)
+++ branches/4.0-python/source/auth/auth_anonymous.c2007-11-25 15:56:39 UTC 
(rev 26115)
@@ -21,6 +21,7 @@
 
 #include includes.h
 #include auth/auth.h
+#include auth/auth_util.h
 
 /**
  * Return a anonymous logon for anonymous users (username = )

Modified: branches/4.0-python/source/auth/auth_developer.c
===
--- branches/4.0-python/source/auth/auth_developer.c2007-11-25 15:34:12 UTC 
(rev 26114)
+++ branches/4.0-python/source/auth/auth_developer.c2007-11-25 15:56:39 UTC 
(rev 26115)
@@ -21,6 +21,7 @@
 
 #include includes.h
 #include auth/auth.h
+#include auth/auth_util.h
 #include libcli/security/security.h
 #include librpc/gen_ndr/ndr_samr.h
 

Modified: branches/4.0-python/source/auth/auth_simple.c
===
--- branches/4.0-python/source/auth/auth_simple.c   2007-11-25 15:34:12 UTC 
(rev 26114)
+++ branches/4.0-python/source/auth/auth_simple.c   2007-11-25 15:56:39 UTC 
(rev 26115)
@@ -23,6 +23,7 @@
 
 #include includes.h
 #include auth/auth.h
+#include auth/auth_util.h
 #include lib/events/events.h
 
 /*

Modified: branches/4.0-python/source/auth/auth_winbind.c
===
--- branches/4.0-python/source/auth/auth_winbind.c  2007-11-25 15:34:12 UTC 
(rev 26114)
+++ branches/4.0-python/source/auth/auth_winbind.c  2007-11-25 15:56:39 UTC 
(rev 26115)
@@ -23,6 +23,7 @@
 
 #include includes.h
 #include auth/auth.h
+#include auth/auth_util.h
 #include nsswitch/winbind_client.h
 #include librpc/gen_ndr/ndr_netlogon.h
 #include librpc/gen_ndr/ndr_winbind.h

Modified: branches/4.0-python/source/auth/credentials/credentials.c
===
--- branches/4.0-python/source/auth/credentials/credentials.c   2007-11-25 
15:34:12 UTC (rev 26114)
+++ branches/4.0-python/source/auth/credentials/credentials.c   2007-11-25 
15:56:39 UTC (rev 26115)
@@ -24,7 +24,6 @@
 #include includes.h
 #include librpc/gen_ndr/samr.h /* for struct samrPassword */
 #include auth/credentials/credentials.h
-#include auth/credentials/credentials_krb5.h
 #include libcli/auth/libcli_auth.h
 #include lib/events/events.h
 #include param/param.h

Modified: branches/4.0-python/source/auth/credentials/credentials_files.c
===
--- branches/4.0-python/source/auth/credentials/credentials_files.c 
2007-11-25 15:34:12 UTC (rev 26114)
+++ branches/4.0-python/source/auth/credentials/credentials_files.c 
2007-11-25 15:56:39 UTC (rev 26115)
@@ -28,7 +28,6 @@
 #include system/filesys.h
 #include util/util_ldb.h
 #include auth/credentials/credentials.h
-#include auth/credentials/credentials_krb5.h
 #include param/param.h
 #include ldb_wrap.h
 

Modified: branches/4.0-python/source/auth/gensec/gensec_gssapi.c
===
--- branches/4.0-python/source/auth/gensec/gensec_gssapi.c  2007-11-25 
15:34:12 UTC (rev 26114)
+++ branches/4.0-python/source/auth/gensec/gensec_gssapi.c  2007-11-25 
15:56:39 UTC (rev 26115)
@@ -28,11 +28,11 @@
 #include auth/kerberos/kerberos.h
 #include librpc/gen_ndr/krb5pac.h
 #include auth/auth.h
+#include auth/auth_util.h
 #include lib/ldb/include/ldb.h
 #include auth/auth_sam.h
 #include librpc/rpc/dcerpc.h
 #include auth/credentials/credentials.h
-#include auth/credentials/credentials_krb5.h
 #include auth/gensec/gensec.h
 #include param/param.h
 

Modified: branches/4.0-python/source/auth/gensec/gensec_krb5.c
===
--- branches/4.0-python/source/auth/gensec/gensec_krb5.c2007-11-25 
15:34:12 UTC (rev 26114)
+++ 

svn commit: samba r26116 - in branches/SAMBA_4_0/source/build/smb_build: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 16:12:05 + (Sun, 25 Nov 2007)
New Revision: 26116

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26116

Log:
Mention python in the config.status summary.
Modified:
   branches/SAMBA_4_0/source/build/smb_build/summary.pm


Changeset:
Modified: branches/SAMBA_4_0/source/build/smb_build/summary.pm
===
--- branches/SAMBA_4_0/source/build/smb_build/summary.pm2007-11-25 
15:56:39 UTC (rev 26115)
+++ branches/SAMBA_4_0/source/build/smb_build/summary.pm2007-11-25 
16:12:05 UTC (rev 26116)
@@ -54,6 +54,7 @@
showitem($output, using libblkid, [BLKID]);
showitem($output, using iconv, [ICONV]);
showitem($output, using pam, [PAM]);
+   showitem($output, python bindings, [LIBPYTHON]);
showisexternal($output, popt, LIBPOPT);
showisexternal($output, talloc, LIBTALLOC);
showisexternal($output, tdb, LIBTDB);



svn commit: samba r26117 - in branches/SAMBA_4_0/source/lib/ldb: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 18:49:37 + (Sun, 25 Nov 2007)
New Revision: 26117

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26117

Log:
Fix DESTDIR use for bindir.
Modified:
   branches/SAMBA_4_0/source/lib/ldb/Makefile.in


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/Makefile.in
===
--- branches/SAMBA_4_0/source/lib/ldb/Makefile.in   2007-11-25 16:12:05 UTC 
(rev 26116)
+++ branches/SAMBA_4_0/source/lib/ldb/Makefile.in   2007-11-25 18:49:37 UTC 
(rev 26117)
@@ -209,7 +209,7 @@
 installcheck: install test
 
 install:: all
-   mkdir -p $(DESTDIR)$(includedir) $(DESTDIR)$(libdir)/pkgconfig 
$(DESTDIR)$(libdir) $(bindir)
+   mkdir -p $(DESTDIR)$(includedir) $(DESTDIR)$(libdir) 
$(DESTDIR)$(bindir) $(DESTDIR)$(libdir)/pkgconfig 
cp $(srcdir)/include/ldb.h $(srcdir)/include/ldb_errors.h 
$(DESTDIR)$(includedir)
cp $(STATICLIB) $(SOLIB) $(DESTDIR)$(libdir)
cp $(BINS) $(DESTDIR)$(bindir)



svn commit: samba r26119 - in branches/SAMBA_4_0/source/lib/ldb: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 20:12:08 + (Sun, 25 Nov 2007)
New Revision: 26119

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26119

Log:
Fix warnings.
Modified:
   branches/SAMBA_4_0/source/lib/ldb/ldb.i


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/ldb.i
===
--- branches/SAMBA_4_0/source/lib/ldb/ldb.i 2007-11-25 19:34:04 UTC (rev 
26118)
+++ branches/SAMBA_4_0/source/lib/ldb/ldb.i 2007-11-25 20:12:08 UTC (rev 
26119)
@@ -118,7 +118,7 @@
 if ($1-dn == NULL)
 SWIG_exception(SWIG_TypeError, no dn set);
 } else {
-if (SWIG_ConvertPtr($input, $1, SWIGTYPE_p_ldb_message, 0) != 0)
+if (SWIG_ConvertPtr($input, (void **)$1, SWIGTYPE_p_ldb_message, 0) 
!= 0)
 return NULL;
 }
 }
@@ -225,7 +225,7 @@
 %inline {
 int ldb_dn_from_pyobject(PyObject *object, ldb_dn **dn)
 {
-return SWIG_ConvertPtr(object, dn, SWIGTYPE_p_ldb_dn, 0);
+return SWIG_ConvertPtr(object, (void **)dn, SWIGTYPE_p_ldb_dn, 0);
 }
 
 ldb_msg_element *ldb_msg_element_from_pyobject(PyObject *set_obj, int flags,



svn commit: samba r26120 - in branches/SAMBA_4_0/source/build/smb_build: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 20:55:53 + (Sun, 25 Nov 2007)
New Revision: 26120

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26120

Log:
Don't install python modules as modules.
Modified:
   branches/SAMBA_4_0/source/build/smb_build/makefile.pm


Changeset:
Modified: branches/SAMBA_4_0/source/build/smb_build/makefile.pm
===
--- branches/SAMBA_4_0/source/build/smb_build/makefile.pm   2007-11-25 
20:12:08 UTC (rev 26119)
+++ branches/SAMBA_4_0/source/build/smb_build/makefile.pm   2007-11-25 
20:55:53 UTC (rev 26120)
@@ -314,11 +314,11 @@
if ($ctx-{TYPE} eq PYTHON) {
push (@{$self-{python_dsos}}, 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME});
+   } else {
+   push (@{$self-{shared_modules}}, 
$ctx-{TARGET_SHARED_LIBRARY});
+   push (@{$self-{plugins}}, 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME});
}
 
-   push (@{$self-{shared_modules}}, $ctx-{TARGET_SHARED_LIBRARY});
-   push (@{$self-{plugins}}, 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME});
-
$self-{install_plugins} .= [EMAIL PROTECTED] Installing 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME} as 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
$self-{install_plugins} .= [EMAIL PROTECTED] -p 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/\n;
$self-{install_plugins} .= [EMAIL PROTECTED] 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME} 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;



svn commit: samba r26121 - in branches/SAMBA_4_0/source/build/smb_build: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 21:22:32 + (Sun, 25 Nov 2007)
New Revision: 26121

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26121

Log:
Don't build modules if subsystem isn't build.
Modified:
   branches/SAMBA_4_0/source/build/smb_build/input.pm


Changeset:
Modified: branches/SAMBA_4_0/source/build/smb_build/input.pm
===
--- branches/SAMBA_4_0/source/build/smb_build/input.pm  2007-11-25 20:55:53 UTC 
(rev 26120)
+++ branches/SAMBA_4_0/source/build/smb_build/input.pm  2007-11-25 21:22:32 UTC 
(rev 26121)
@@ -83,6 +83,11 @@
return;
}
 
+   if ($INPUT-{$mod-{SUBSYSTEM}} eq NO) {
+   $mod-{ENABLE} = NO;
+   return;
+   }
+
return if ($mod-{ENABLE} ne YES);
 
if (exists($INPUT-{$mod-{SUBSYSTEM}}{INIT_FUNCTION_TYPE})) {



svn commit: samba r26122 - in branches/SAMBA_4_0/source/build/smb_build: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-25 23:23:30 + (Sun, 25 Nov 2007)
New Revision: 26122

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26122

Log:
Don't install python bindings yet.
Modified:
   branches/SAMBA_4_0/source/build/smb_build/makefile.pm


Changeset:
Modified: branches/SAMBA_4_0/source/build/smb_build/makefile.pm
===
--- branches/SAMBA_4_0/source/build/smb_build/makefile.pm   2007-11-25 
21:22:32 UTC (rev 26121)
+++ branches/SAMBA_4_0/source/build/smb_build/makefile.pm   2007-11-25 
23:23:30 UTC (rev 26122)
@@ -317,18 +317,17 @@
} else {
push (@{$self-{shared_modules}}, 
$ctx-{TARGET_SHARED_LIBRARY});
push (@{$self-{plugins}}, 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME});
-   }
-
-   $self-{install_plugins} .= [EMAIL PROTECTED] Installing 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME} as 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
-   $self-{install_plugins} .= [EMAIL PROTECTED] -p 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/\n;
-   $self-{install_plugins} .= [EMAIL PROTECTED] 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME} 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
-   $self-{uninstall_plugins} .= [EMAIL PROTECTED] Uninstalling 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
-   $self-{uninstall_plugins} .= [EMAIL PROTECTED] 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
-   if (defined($ctx-{ALIASES})) {
-   foreach (@{$ctx-{ALIASES}}) {
-   $self-{install_plugins} .= [EMAIL PROTECTED] -f 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$_.\$(SHLIBEXT)\n;
-   $self-{install_plugins} .= [EMAIL PROTECTED] -fs 
$ctx-{LIBRARY_REALNAME} 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$_.\$(SHLIBEXT)\n;
-   $self-{uninstall_plugins} .= [EMAIL PROTECTED] 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$_.\$(SHLIBEXT)\n;
+   $self-{install_plugins} .= [EMAIL PROTECTED] Installing 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME} as 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
+   $self-{install_plugins} .= [EMAIL PROTECTED] -p 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/\n;
+   $self-{install_plugins} .= [EMAIL PROTECTED] 
$ctx-{SHAREDDIR}/$ctx-{LIBRARY_REALNAME} 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
+   $self-{uninstall_plugins} .= [EMAIL PROTECTED] Uninstalling 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
+   $self-{uninstall_plugins} .= [EMAIL PROTECTED] 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$ctx-{LIBRARY_REALNAME}\n;
+   if (defined($ctx-{ALIASES})) {
+   foreach (@{$ctx-{ALIASES}}) {
+   $self-{install_plugins} .= [EMAIL PROTECTED] 
-f \$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$_.\$(SHLIBEXT)\n;
+   $self-{install_plugins} .= [EMAIL PROTECTED] 
-fs $ctx-{LIBRARY_REALNAME} 
\$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$_.\$(SHLIBEXT)\n;
+   $self-{uninstall_plugins} .= [EMAIL 
PROTECTED] \$(DESTDIR)\$(MODULESDIR)/$sane_subsystem/$_.\$(SHLIBEXT)\n;
+   }
}
}
 



Build status as of Mon Nov 26 00:00:01 2007

2007-11-25 Thread build
URL: http://build.samba.org/

--- /home/build/master/cache/broken_results.txt.old 2007-11-25 
00:01:03.0 +
+++ /home/build/master/cache/broken_results.txt 2007-11-26 00:00:58.0 
+
@@ -1,4 +1,4 @@
-Build status as of Sun Nov 25 00:00:02 2007
+Build status as of Mon Nov 26 00:00:01 2007
 
 Build counts:
 Tree Total  Broken Panic 
@@ -15,8 +15,8 @@
 python   0  0  0 
 rsync28 12 0 
 samba-docs   0  0  0 
-samba-gtk5  5  0 
-samba4   25 23 0 
+samba-gtk4  4  0 
+samba4   25 22 0 
 samba_3_20  0  0 
 samba_3_2_test 28 17 0 
 smb-build27 26 0 


svn commit: samba r26123 - in branches/SAMBA_4_0/source/param: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 00:55:22 + (Mon, 26 Nov 2007)
New Revision: 26123

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26123

Log:
Use utility function for secrets.tdb path.
Modified:
   branches/SAMBA_4_0/source/param/secrets.c


Changeset:
Modified: branches/SAMBA_4_0/source/param/secrets.c
===
--- branches/SAMBA_4_0/source/param/secrets.c   2007-11-25 23:23:30 UTC (rev 
26122)
+++ branches/SAMBA_4_0/source/param/secrets.c   2007-11-26 00:55:22 UTC (rev 
26123)
@@ -66,7 +66,8 @@
if (tdb)
return true;
 
-   asprintf(fname, %s/secrets.tdb, lp_private_dir(global_loadparm));
+   fname = private_path(talloc_autofree_context(), global_loadparm,
+secrets.tdb);
 
tdb = tdb_wrap_open(talloc_autofree_context(), fname, 0, TDB_DEFAULT, 
O_RDWR|O_CREAT, 0600);
 



svn commit: samba r26124 - in branches/SAMBA_4_0/source/lib/ldb: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 01:29:14 + (Mon, 26 Nov 2007)
New Revision: 26124

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26124

Log:
Install ldb_handlers.h, required by ldb_samba.
Modified:
   branches/SAMBA_4_0/source/lib/ldb/Makefile.in


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/Makefile.in
===
--- branches/SAMBA_4_0/source/lib/ldb/Makefile.in   2007-11-26 00:55:22 UTC 
(rev 26123)
+++ branches/SAMBA_4_0/source/lib/ldb/Makefile.in   2007-11-26 01:29:14 UTC 
(rev 26124)
@@ -82,6 +82,8 @@
 
 OBJS = $(MODULES_OBJ) $(COMMON_OBJ) $(LDB_TDB_OBJ) $(TDB_OBJ) $(TALLOC_OBJ) 
$(POPT_OBJ) $(LDB_MAP_OBJ) @LIBREPLACEOBJ@ $(EXTRA_OBJ) 
 
+headers = $(srcdir)/include/ldb.h $(srcdir)/include/ldb_errors.h 
$(srcdir)/include/ldb_handlers.h
+
 BINS = bin/ldbadd bin/ldbsearch bin/ldbdel bin/ldbmodify bin/ldbedit 
bin/ldbrename bin/ldbtest bin/oLschema2ldif
 
 EXAMPLES = examples/ldbreader examples/ldifreader
@@ -210,7 +212,7 @@
 
 install:: all
mkdir -p $(DESTDIR)$(includedir) $(DESTDIR)$(libdir) 
$(DESTDIR)$(bindir) $(DESTDIR)$(libdir)/pkgconfig 
-   cp $(srcdir)/include/ldb.h $(srcdir)/include/ldb_errors.h 
$(DESTDIR)$(includedir)
+   cp $(headers) $(DESTDIR)$(includedir)
cp $(STATICLIB) $(SOLIB) $(DESTDIR)$(libdir)
cp $(BINS) $(DESTDIR)$(bindir)
cp ldb.pc $(DESTDIR)$(libdir)/pkgconfig



svn commit: samba r26125 - in branches/SAMBA_4_0/source/lib/registry: . tests

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 02:19:53 + (Mon, 26 Nov 2007)
New Revision: 26125

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26125

Log:
Update ignores
Modified:
   branches/SAMBA_4_0/source/lib/registry/
   branches/SAMBA_4_0/source/lib/registry/tests/


Changeset:

Property changes on: branches/SAMBA_4_0/source/lib/registry
___
Name: svn:ignore
   - reg_backend_rpc.h
apidocs
registry_proto.h
*.d
*.pc
regf.h
tdr_regf.c
tdr_regf.h

   + registry.py
reg_backend_rpc.h
apidocs
registry_proto.h
*.d
*.pc
regf.h
tdr_regf.c
tdr_regf.h



Property changes on: branches/SAMBA_4_0/source/lib/registry/tests
___
Name: svn:ignore
   + *.pyc
proto.h




svn commit: samba r26126 - in branches/SAMBA_4_0/source: auth/credentials auth/credentials/tests lib/ldb lib/tdb lib/tdb/bin lib/tdb/python/tests librpc/rpc

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 02:22:48 + (Mon, 26 Nov 2007)
New Revision: 26126

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26126

Log:
Update ignores
Modified:
   branches/SAMBA_4_0/source/auth/credentials/
   branches/SAMBA_4_0/source/auth/credentials/tests/
   branches/SAMBA_4_0/source/lib/ldb/
   branches/SAMBA_4_0/source/lib/tdb/
   branches/SAMBA_4_0/source/lib/tdb/bin/
   branches/SAMBA_4_0/source/lib/tdb/python/tests/
   branches/SAMBA_4_0/source/librpc/rpc/


Changeset:

Property changes on: branches/SAMBA_4_0/source/auth/credentials
___
Name: svn:ignore
   - *.d
credentials_proto.h
credentials_krb5_proto.h


   + credentials.py
*.d
credentials_proto.h
credentials_krb5_proto.h




Property changes on: branches/SAMBA_4_0/source/auth/credentials/tests
___
Name: svn:ignore
   + *.pyc



Property changes on: branches/SAMBA_4_0/source/lib/ldb
___
Name: svn:ignore
   - *.d
bin
lib
*.po
*.gc??
Makefile
config.cache
config.status
ldb.pc
configure
config.log
autom4te.cache
apidocs
_trial_temp

   + build
*.pyc
ldb.py
ldb_wrap.c
*.d
bin
lib
*.po
*.gc??
Makefile
config.cache
config.status
ldb.pc
configure
config.log
autom4te.cache
apidocs
_trial_temp



Property changes on: branches/SAMBA_4_0/source/lib/tdb
___
Name: svn:ignore
   - build
*.pyc
_trial_temp
config.log
*.pc
configure

   + Makefile
config.status
libtdb.a
*.so
*.so.*
tdb_wrap.c
tdb.py
build
*.pyc
_trial_temp
config.log
*.pc
configure



Property changes on: branches/SAMBA_4_0/source/lib/tdb/bin
___
Name: svn:ignore
   - .sconsign
tdbtool
tdbtest
tdbtorture
tdbdump

   + .sconsign
tdbbackup
tdbtool
tdbtest
tdbtorture
tdbdump



Property changes on: branches/SAMBA_4_0/source/lib/tdb/python/tests
___
Name: svn:ignore
   + *.pyc



Property changes on: branches/SAMBA_4_0/source/librpc/rpc
___
Name: svn:ignore
   - dcerpc_proto.h
dcerpc_table.h
.sconsign
*.po
*.d

   + dcerpc.py
dcerpc_wrap.c
dcerpc_proto.h
dcerpc_table.h
.sconsign
*.po
*.d




svn commit: samba r26127 - in branches/SAMBA_4_0/source/auth: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 02:25:20 + (Mon, 26 Nov 2007)
New Revision: 26127

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26127

Log:
Move session code out of auth_util.c. No longer making it part of auth but 
making it usable independently will be the next step.
Added:
   branches/SAMBA_4_0/source/auth/session.c
   branches/SAMBA_4_0/source/auth/session.h
   branches/SAMBA_4_0/source/auth/system_session.c
Modified:
   branches/SAMBA_4_0/source/auth/
   branches/SAMBA_4_0/source/auth/auth.h
   branches/SAMBA_4_0/source/auth/auth_util.c
   branches/SAMBA_4_0/source/auth/config.mk


Changeset:
Sorry, the patch is too large (1102 lines) to include; please use WebSVN to see 
it!
WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26127


svn commit: samba r26128 - in branches/SAMBA_4_0/source: . param

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 02:31:53 + (Mon, 26 Nov 2007)
New Revision: 26128

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26128

Log:
Some formatting fixes in secrets.c, fix free of filename, update ignores for 
source/..
Modified:
   branches/SAMBA_4_0/source/
   branches/SAMBA_4_0/source/param/secrets.c


Changeset:

Property changes on: branches/SAMBA_4_0/source
___
Name: svn:ignore
   - .sconsign
st
ID
*.d
Makefile
dox
typescript*
configure
TAGS
tags
*.*
extra_cflags.txt

   + _trial_temp
.sconsign
st
ID
*.d
Makefile
dox
typescript*
configure
TAGS
tags
*.*
extra_cflags.txt


Modified: branches/SAMBA_4_0/source/param/secrets.c
===
--- branches/SAMBA_4_0/source/param/secrets.c   2007-11-26 02:25:20 UTC (rev 
26127)
+++ branches/SAMBA_4_0/source/param/secrets.c   2007-11-26 02:31:53 UTC (rev 
26128)
@@ -46,37 +46,42 @@
 static void get_rand_seed(int *new_seed) 
 {
*new_seed = getpid();
-   if (tdb) {
+   if (tdb != NULL) {
tdb_change_int32_atomic(tdb-tdb, INFO/random_seed, new_seed, 
1);
}
 }
 
-/* close the secrets database */
+/**
+ * close the secrets database
+ */
 void secrets_shutdown(void)
 {
talloc_free(tdb);
 }
 
-/* open up the secrets database */
+/**
+ * open up the secrets database
+ */
 bool secrets_init(void)
 {
char *fname;
uint8_t dummy;
 
-   if (tdb)
+   if (tdb != NULL)
return true;
 
-   fname = private_path(talloc_autofree_context(), global_loadparm,
+   fname = private_path(NULL, global_loadparm,
 secrets.tdb);
 
-   tdb = tdb_wrap_open(talloc_autofree_context(), fname, 0, TDB_DEFAULT, 
O_RDWR|O_CREAT, 0600);
+   tdb = tdb_wrap_open(talloc_autofree_context(), fname, 0, TDB_DEFAULT, 
+   O_RDWR|O_CREAT, 0600);
 
if (!tdb) {
DEBUG(0,(Failed to open %s\n, fname));
-   SAFE_FREE(fname);
+   talloc_free(fname);
return false;
}
-   SAFE_FREE(fname);
+   talloc_free(fname);
 
/**
 * Set a reseed function for the crypto random generator 
@@ -92,8 +97,8 @@
return true;
 }
 
-/*
-  connect to the schannel ldb
+/**
+  connect to the secrets ldb
 */
 struct ldb_context *secrets_db_connect(TALLOC_CTX *mem_ctx)
 {
@@ -133,6 +138,10 @@
return ldb;
 }
 
+/**
+ * Retrieve the domain SID from the secrets database.
+ * @return pointer to a SID object if the SID could be obtained, NULL otherwise
+ */
 struct dom_sid *secrets_get_domain_sid(TALLOC_CTX *mem_ctx,
   const char *domain)
 {



svn commit: samba r26129 - in branches/SAMBA_4_0/source/lib/ldb-samba: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 03:14:28 + (Mon, 26 Nov 2007)
New Revision: 26129

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26129

Log:
Specify path explicitly in case an external ldb installation is used.
Modified:
   branches/SAMBA_4_0/source/lib/ldb-samba/ldif_handlers.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb-samba/ldif_handlers.c
===
--- branches/SAMBA_4_0/source/lib/ldb-samba/ldif_handlers.c 2007-11-26 
02:31:53 UTC (rev 26128)
+++ branches/SAMBA_4_0/source/lib/ldb-samba/ldif_handlers.c 2007-11-26 
03:14:28 UTC (rev 26129)
@@ -22,8 +22,7 @@
 */
 
 #include includes.h
-#include ldb_includes.h
-#include ldb_handlers.h
+#include lib/ldb/include/ldb_includes.h
 
 #include librpc/gen_ndr/ndr_security.h
 #include librpc/gen_ndr/ndr_misc.h



svn commit: samba r26130 - in branches/SAMBA_4_0/source: .

2007-11-25 Thread jelmer
Author: jelmer
Date: 2007-11-26 03:14:57 + (Mon, 26 Nov 2007)
New Revision: 26130

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26130

Log:
Fix header installation
Modified:
   branches/SAMBA_4_0/source/headermap.txt


Changeset:
Modified: branches/SAMBA_4_0/source/headermap.txt
===
--- branches/SAMBA_4_0/source/headermap.txt 2007-11-26 03:14:28 UTC (rev 
26129)
+++ branches/SAMBA_4_0/source/headermap.txt 2007-11-26 03:14:57 UTC (rev 
26130)
@@ -72,6 +72,9 @@
 rpc_server/dcerpc_server_proto.h: dcerpc_server/proto.h
 auth/auth.h: auth.h
 auth/auth_proto.h: auth/proto.h
+auth/system_session_proto.h: auth/system_session.h
+auth/session_proto.h: auth/session_proto.h
+auth/session.h: auth/session.h
 auth/gensec/spnego.h: gensec/spnego.h
 auth/gensec/gensec_proto.h: gensec/proto.h
 libcli/auth/credentials.h: domain_credentials.h



svn commit: samba r26131 - in branches/SAMBA_4_0/source/lib/ldb/ldb_tdb: .

2007-11-25 Thread abartlet
Author: abartlet
Date: 2007-11-26 06:12:01 + (Mon, 26 Nov 2007)
New Revision: 26131

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=26131

Log:
Ensure we show the right errors in the NULL base DN case.  Based on
bug 5090 by Matthias Dieter Walln?\195?\182fer [EMAIL PROTECTED]

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/lib/ldb/ldb_tdb/ldb_search.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/ldb_tdb/ldb_search.c
===
--- branches/SAMBA_4_0/source/lib/ldb/ldb_tdb/ldb_search.c  2007-11-26 
03:14:57 UTC (rev 26130)
+++ branches/SAMBA_4_0/source/lib/ldb/ldb_tdb/ldb_search.c  2007-11-26 
06:12:01 UTC (rev 26131)
@@ -530,10 +530,12 @@
ldb_asprintf_errstring(module-ldb, 
   NULL Base DN invalid for a base 
search);
ret = LDB_ERR_INVALID_DN_SYNTAX;
+   break;
case LDB_SCOPE_ONELEVEL:
ldb_asprintf_errstring(module-ldb, 
   NULL Base DN invalid for a 
one-level search);
ret = LDB_ERR_INVALID_DN_SYNTAX;
+   break;
case LDB_SCOPE_SUBTREE:
default:
/* We accept subtree searches from a NULL base DN, ie 
over the whole DB */



[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-369-g102a247

2007-11-25 Thread Volker Lendecke
The branch, v3-2-test has been updated
   via  102a247df99967f25dbaf40c9be2d48a8e15c64c (commit)
  from  41e07682dc1fa535ddaf405efa26fabb33c8bbf9 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -
commit 102a247df99967f25dbaf40c9be2d48a8e15c64c
Author: Tomoki AONO [EMAIL PROTECTED]
Date:   Sun Nov 25 01:59:40 2007 +0900

1. lib/system.c (xattr code for Solaris) could not be
built against c90 compilers. (declaration after
statement.) Sample patch attached.

---

Summary of changes:
 source/lib/system.c |9 ++---
 1 files changed, 6 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/system.c b/source/lib/system.c
index 7338ea7..5013cc5 100644
--- a/source/lib/system.c
+++ b/source/lib/system.c
@@ -1990,9 +1990,10 @@ int sys_setxattr (const char *path, const char *name, 
const void *value, size_t
 #elif defined(HAVE_ATTROPEN)
int ret = -1;
int myflags = O_RDWR;
+   int attrfd;
if (flags  XATTR_CREATE) myflags |= O_EXCL;
if (!(flags  XATTR_REPLACE)) myflags |= O_CREAT;
-   int attrfd = solaris_attropen(path, name, myflags, (mode_t) 
SOLARIS_ATTRMODE);
+   attrfd = solaris_attropen(path, name, myflags, (mode_t) 
SOLARIS_ATTRMODE);
if (attrfd = 0) {
ret = solaris_write_xattr(attrfd, value, size);
close(attrfd);
@@ -2053,9 +2054,10 @@ int sys_lsetxattr (const char *path, const char *name, 
const void *value, size_t
 #elif defined(HAVE_ATTROPEN)
int ret = -1;
int myflags = O_RDWR | AT_SYMLINK_NOFOLLOW;
+   int attrfd;
if (flags  XATTR_CREATE) myflags |= O_EXCL;
if (!(flags  XATTR_REPLACE)) myflags |= O_CREAT;
-   int attrfd = solaris_attropen(path, name, myflags, (mode_t) 
SOLARIS_ATTRMODE);
+   attrfd = solaris_attropen(path, name, myflags, (mode_t) 
SOLARIS_ATTRMODE);
if (attrfd = 0) {
ret = solaris_write_xattr(attrfd, value, size);
close(attrfd);
@@ -2117,9 +2119,10 @@ int sys_fsetxattr (int filedes, const char *name, const 
void *value, size_t size
 #elif defined(HAVE_ATTROPEN)
int ret = -1;
int myflags = O_RDWR | O_XATTR;
+   int attrfd;
if (flags  XATTR_CREATE) myflags |= O_EXCL;
if (!(flags  XATTR_REPLACE)) myflags |= O_CREAT;
-   int attrfd = solaris_openat(filedes, name, myflags, (mode_t) 
SOLARIS_ATTRMODE);
+   attrfd = solaris_openat(filedes, name, myflags, (mode_t) 
SOLARIS_ATTRMODE);
if (attrfd = 0) {
ret = solaris_write_xattr(attrfd, value, size);
close(attrfd);


-- 
Samba Shared Repository