OK, let's do it / Poll: Remove all author tags
Ok, I understand we want the tags removed. Cool! I will start removing the author tags from the store section. If this works smoothly and fast I will take care more. Anyone volunteering to remove the tags from any part? Oliver Oliver Zeigermann wrote: Folks! As recommended by the ASF projects should remove all author tags. This is because author tags hardly and rarely indicate the person to talk to. Also in projects like ours the whole community is in charge of code, not just the person(s) indicated by author tags. However, if we want author tags or not is to be decided by the community. So, what do you want? I would go for removing author tags. Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30252] - putting two files by two threads resulting in Internal Server Error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=30252.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=30252
putting two files by two threads resulting in Internal Server Error
--- Additional Comments From [EMAIL PROTECTED] 2004-07-28 08:17 ---
Now I use slide2.1M1 and use the followed sample code to test multi-thread put
files.
public class TestCreateFile {
public WebdavResource webdavResource1 = null;
public WebdavResource webdavResource2 = null;
private void init(){
HttpURL httpURL = null;
try {
httpURL = new HttpURL
(http://localhost:8080/slide.toCharArray());
httpURL.setUserinfo(root, root);
webdavResource1 = new WebdavResource(httpURL);
httpURL.setUserinfo(test, test);
webdavResource2 = new WebdavResource(httpURL);
}
catch (Exception ex) {
httpURL = null;
webdavResource1 = null;
webdavResource2 = null;
}
}
public static void main(String[] args) {
TestCreateFile test = new TestCreateFile();
test.init();
new CreateFileThread
(test.webdavResource1,test1.txt).start();
new CreateFileThread
(test.webdavResource2,test2.txt).start();
}
}
class CreateFileThread extends Thread{
private WebdavResource webdavResource = null;
private String filename = null;
public CreateFileThread(WebdavResource webdavResource,String filename)
{
this.webdavResource = webdavResource;
this.filename = filename;
}
public void run() {
try
{
File file = new File(d://test// + filename);
if (file.exists()) {
if (webdavResource.putMethod
(/slide/files/+filename,file)) {
System.out.println(load + filename
+ success.);
}
else {
System.out.println(load + filename
+ failed.);
}
}
}
catch(HttpException e2){
}
catch (IOException e1) {
}
}
}
I get the result one success and one fail mostly.The tomcat show the message:
org.apache.slide.store.impl.rdbms.MySqlRDBMSAdapter - WARNING - 1213: Deadlock
resolved on /files/test1.txt
org.apache.slide.util.event.EventLogger - INFO - Recieved event with
name 'transaction:rollback': org.apache.slide.event.TransactionEvent
[EMAIL PROTECTED]
Thread-4, 28-七月-2004 15:06:24, root, PUT, 409 Conflict, 581 ms, /files/test1
.txt
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Patch for Bug# 30317
I have a fix for Bug# 30317 for RDBMS Content Stores. Could someone review the patch for the same? If yes, please let me know.. I will send the patch file. Regards, Ritu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: OK, let's do it / Poll: Remove all author tags
for file in `find jakarta-slide -name *.java`; do sed '/\\*[:space:[EMAIL PROTECTED]/d' $file TEMP; mv TEMP $file; done This one liner should do. Let me know if I you want me to do that batch conversion. Ingo Ok, I understand we want the tags removed. Cool! I will start removing the author tags from the store section. If this works smoothly and fast I will take care more. Anyone volunteering to remove the tags from any part? Oliver Oliver Zeigermann wrote: Folks! As recommended by the ASF projects should remove all author tags. This is because author tags hardly and rarely indicate the person to talk to. Also in projects like ours the whole community is in charge of code, not just the person(s) indicated by author tags. However, if we want author tags or not is to be decided by the community. So, what do you want? I would go for removing author tags. Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: OK, let's do it / Poll: Remove all author tags
It would be great if you could do the conversion! Oliver Ingo Brunberg wrote: for file in `find jakarta-slide -name *.java`; do sed '/\\*[:space:[EMAIL PROTECTED]/d' $file TEMP; mv TEMP $file; done This one liner should do. Let me know if I you want me to do that batch conversion. Ingo Ok, I understand we want the tags removed. Cool! I will start removing the author tags from the store section. If this works smoothly and fast I will take care more. Anyone volunteering to remove the tags from any part? Oliver Oliver Zeigermann wrote: Folks! As recommended by the ASF projects should remove all author tags. This is because author tags hardly and rarely indicate the person to talk to. Also in projects like ours the whole community is in charge of code, not just the person(s) indicated by author tags. However, if we want author tags or not is to be decided by the community. So, what do you want? I would go for removing author tags. Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30252] - putting two files by two threads resulting in Internal Server Error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30252. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30252 putting two files by two threads resulting in Internal Server Error [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-07-28 09:09 --- This has been somewhat fixed in the CVS head which will become 2.1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Patch for Bug# 30317
Where is that patch? Simply attach it to the bug report. Oliver Ritu Kedia wrote: I have a fix for Bug# 30317 for RDBMS Content Stores. Could someone review the patch for the same? If yes, please let me know.. I will send the patch file. Regards, Ritu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Using NotificationListener to send uncache events
James Mason schrieb: Based on my reading of the NotificationListener source this is the sequence that needs to happen (Client and server are both Slide servers in this case): 1. Client creates a NotificationListener Yes, you can specify the repository host/port and the local udp listener port in the constructor. 2. Client subscribes to server with a Subscriber and receives a subsription id 3a. Client periodically POLLs server for update events for all subscription ids The interval for polling can be specified in constructor. If set to a very large interval, poll is more or disabled. AND 3b. Server sends NOTIFY request with a list of subscription ids to client when a resource is updated 3c. Client POLLs server to get a list of update events for the notified subscription ids 4. Server returns list of update events for the specified subscription ids 5. Client calls notify() on the Subscriber registered for each received update event You should in the end be able to simple register a subscriber and get called when the method you are listening for occurs. You also get the event specific information set by the RemoteInformation interface on server side in a simple map. 6. The subscriber fires a UrisModifiedEvent that is handled elsewhere to uncache the Uris. My suggestion would be to use the event collection on server side and throw the UrisModifiedEvent on server side with all changed uris specified in the RemoteInformation way. So you should lateron be able to register for the UrisModifiedEvent on client side and get notified when any Uris change on server side and get the Uris in the information map at once. First off, does this sequence of event looks like I'm using NotificationListener properly? Second, I'm concerned about the possibility of subscriptions being dropped if a server goes down. In this scenario if the server where to restart and lose the subscription id the client would no longer be able receive events. Is there support for persistent subscriptions on the server or perhaps a way to notify the client that the subscription was lost so it can resubscribe? At the moment the only way is to use the subscription lifetime and renew the subscription periodically. I'll have a look at making subscription persistent as this really seems to be needed if we want reliable event based cluster support... Regarfds, Daniel -James - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP@brutus]: jakarta-slide/jakarta-slide failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project jakarta-slide has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. Project State : 'Failed', Reason 'Build Failed' The following are affected: - jakarta-slide : Content Management System based on WebDAV technology Full details are available at: http://brutus.apache.org/gump/public/jakarta-slide/jakarta-slide/index.html That said, some snippets follow: The following annotations were provided: -WARNING- Unnamed property for [jakarta-slide] in depend on: jakarta-lucene -WARNING- Unnamed property for [jakarta-slide] in depend on: jaxen -DEBUG- Dependency on xml-xerces exists, no need to add for property xmlparser.jar. -DEBUG- Dependency on antlr exists, no need to add for property antlr-tools.jar. -DEBUG- Dependency on dist-ant exists, no need to add for property ant.jar. -DEBUG- Dependency on jmx exists, no need to add for property jmx.jar. -DEBUG- Dependency on jakarta-struts exists, no need to add for property struts.lib. -DEBUG- Dependency on jakarta-taglibs-standard exists, no need to add for property jstl.jar. -DEBUG- Dependency on jakarta-taglibs-standard exists, no need to add for property taglibs-standard.jar. -DEBUG- Dependency on jakarta-tomcat-4.0 exists, no need to add for property catalina.dist. -INFO- Enable verbose output, due to 3 previous error(s). -INFO- Failed with reason build failed -INFO- Enable debug output, due to build failure. The following work was performed: http://brutus.apache.org/gump/public/jakarta-slide/jakarta-slide/gump_work/build_jakarta-slide_jakarta-slide.html Work Name: build_jakarta-slide_jakarta-slide (Type: Build) State: Failed Elapsed: 42 secs Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/xalan-unbundled.jar org.apache.tools.ant.Main -verbose -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Djakarta-lucene=/usr/local/gump/public/workspace/jakarta-lucene/build/lucene-20040728.jar -Djdbc20ext.jar=/usr/local/gump/packages/jdbc2_0/jdbc2_0-stdext.jar -Dantlr-tools.jar=/usr/local/gump/packages/antlr-2.7.3/antlr.jar -Djaxp.jar=/usr/local/gump/packages/java_xml_pack-summer-02_01/jaxp-1.2_01/jaxp-api.jar -Dservlet.jar=/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar -Djstl.jar=/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/jstl.jar -Djunit.jar=/usr/local/gump/public/workspace/dist/junit/junit.jar -Dcommons-httpclient.jar=/usr/local/gump/public/workspace/commons-httpclient-20-branch/dist/commons-httpclient-2.0-20040728.jar -Dxmlparser.jar=/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar -Djmx.jar=/usr/local/gump/packages/jmx-1_2-ri/lib/jmxri.jar -Dstruts.lib=/usr/local/gump/public/workspace/jakarta-struts/dist/lib -Dantlr.jar=/usr/local/gump/packages/antlr-2.7.3/antlr.jar -Dversion=20040728 -Djaxen=/usr/local/gump/public/workspace/jaxen/target/jaxen-20040728.jar -Dxmlapi.jar=/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar -Dtaglibs-standard.jar=/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/standard.jar -Dlog4j.jar=/usr/local/gump/public/workspace/logging-log4j/log4j-20040728.jar -Djdom.jar=/usr/local/gump/public/workspace/jdom/build/jdom.jar -Djndi.jar=/usr/local/gump/packages/jndi1_2_1/lib/jndi.jar -Dcatalina.dist=/usr/local/gump/public/workspace/jakarta-tomcat-4.0/dist -Dcommons-modeler.jar=/usr/local/gump/public/workspace/jakarta-commons/modeler/dist/commons-modeler-20040728.jar -Dant.jar=/usr/local/gump/public/workspace/ant/build/lib/ant.jar -Djta.jar=/usr/local/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar full-dist [Working Directory: /usr/local/gump/public/workspace/jakarta-slide] CLASSPATH : /usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-slide/build/classes:/usr/local/gump/public/workspace/jakarta-slide/build/client/classes:/usr/local/gump/public/workspace/jakarta-slide/webdavclient/build/clientlib/classes:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-20040728.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local
cvs commit: jakarta-slide RELEASE-NOTES-2.1-BETA1
ozeigermann2004/07/28 02:58:39 Modified:.RELEASE-NOTES-2.1-BETA1 Log: Completed beta1 release notes Revision ChangesPath 1.2 +23 -11jakarta-slide/RELEASE-NOTES-2.1-BETA1 Index: RELEASE-NOTES-2.1-BETA1 === RCS file: /home/cvs/jakarta-slide/RELEASE-NOTES-2.1-BETA1,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- RELEASE-NOTES-2.1-BETA1 19 Jul 2004 10:18:44 - 1.1 +++ RELEASE-NOTES-2.1-BETA1 28 Jul 2004 09:58:39 - 1.2 @@ -16,33 +16,46 @@ WebDAV Layer: -- New methods for external transactional control +- External Transaction Support as defined by MS Core: - Transaction control much more adhers to JTA spec allowing for transactions spanning more than one request +- Added transient exclusive locks that limit the risk of deadlocks +- Extractors for MS Office Stores: +- Support for Oracle, DB2 and MySQL 4.1 (additional for 4.0) - Sequence support for MySQL, Oracle and Postgres added (sequence support completed) - - DASL properties expression factory for RDBMS stores dramatically improves DASL performance. +- DASL properties expression factory for RDBMS stores dramatically improves DASL performance. +- JNDI store for users +- New caching modes +- File Store performance improved Client: +- External Transaction Support as defined by MS +- JCA Connector for Slide Misc: +- Projector Framework +- Replaced tx file system, locking, default XAResource implementation, etc. with the versions from commons transaction -BUGFIXES FROM 2.1M1 +BUGFIXES + WebDAV Layer: -- +- Misc. fixes improving WebDAV conformance +- Default mode limits concurrent requests and prevents deadlocks +- http://issues.apache.org/bugzilla/show_bug.cgi?id=28894: Logger no longer buffers body of request and response Core: Stores: - For Postgres properties can contain up to 1G length - Wrong setting of latest version when there were more than 10 versions fixed +- Properties are now long enough to store a significant amount of versions Client: - +- Paths associated with creation of resources now work closer to what one would expect Misc: @@ -50,16 +63,15 @@ WebDAV Layer: -- External Transaction Support not yet finished Core: -- Performance with auto-versioning still not satisfactory -- Improved and scalable search still missing +- Performance on large collections still not satisfactory +- Security checking performance still not satisfactory +- Concurrency not satisfactory Stores: Client: -- JCA Connector for Slide not yet finished Misc: -- Projector Framework not yet ready \ No newline at end of file +- Documentation needs to be improved \ No newline at end of file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-slide RELEASE-NOTES-2.1-BETA1
Please add the stuff I forgot to the release notes. Oliver [EMAIL PROTECTED] wrote: ozeigermann2004/07/28 02:58:39 Modified:.RELEASE-NOTES-2.1-BETA1 Log: Completed beta1 release notes Revision ChangesPath 1.2 +23 -11jakarta-slide/RELEASE-NOTES-2.1-BETA1 Index: RELEASE-NOTES-2.1-BETA1 === RCS file: /home/cvs/jakarta-slide/RELEASE-NOTES-2.1-BETA1,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- RELEASE-NOTES-2.1-BETA1 19 Jul 2004 10:18:44 - 1.1 +++ RELEASE-NOTES-2.1-BETA1 28 Jul 2004 09:58:39 - 1.2 @@ -16,33 +16,46 @@ WebDAV Layer: -- New methods for external transactional control +- External Transaction Support as defined by MS Core: - Transaction control much more adhers to JTA spec allowing for transactions spanning more than one request +- Added transient exclusive locks that limit the risk of deadlocks +- Extractors for MS Office Stores: +- Support for Oracle, DB2 and MySQL 4.1 (additional for 4.0) - Sequence support for MySQL, Oracle and Postgres added (sequence support completed) - - DASL properties expression factory for RDBMS stores dramatically improves DASL performance. +- DASL properties expression factory for RDBMS stores dramatically improves DASL performance. +- JNDI store for users +- New caching modes +- File Store performance improved Client: +- External Transaction Support as defined by MS +- JCA Connector for Slide Misc: +- Projector Framework +- Replaced tx file system, locking, default XAResource implementation, etc. with the versions from commons transaction -BUGFIXES FROM 2.1M1 +BUGFIXES + WebDAV Layer: -- +- Misc. fixes improving WebDAV conformance +- Default mode limits concurrent requests and prevents deadlocks +- http://issues.apache.org/bugzilla/show_bug.cgi?id=28894: Logger no longer buffers body of request and response Core: Stores: - For Postgres properties can contain up to 1G length - Wrong setting of latest version when there were more than 10 versions fixed +- Properties are now long enough to store a significant amount of versions Client: - +- Paths associated with creation of resources now work closer to what one would expect Misc: @@ -50,16 +63,15 @@ WebDAV Layer: -- External Transaction Support not yet finished Core: -- Performance with auto-versioning still not satisfactory -- Improved and scalable search still missing +- Performance on large collections still not satisfactory +- Security checking performance still not satisfactory +- Concurrency not satisfactory Stores: Client: -- JCA Connector for Slide not yet finished Misc: -- Projector Framework not yet ready \ No newline at end of file +- Documentation needs to be improved \ No newline at end of file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Patch for Bug# 30317
Oliver,
For some reason I keep getting Create attachment Bug 30317: No file was
provided, or it was empty. error, when uploading the patch on bugzilla. I
am attaching the patch here. Could you please upload it?
Also I have created the patch on latest from CVS head but tested the fix on
2.1M1 with Oracle Store. Please review it and let me know if you face any
problem with it.
Regards,
Ritu
-Original Message-
From: Oliver Zeigermann [mailto:[EMAIL PROTECTED]
Sent: Wednesday, July 28, 2004 2:38 PM
To: Slide Developers Mailing List
Subject: Re: Patch for Bug# 30317
Where is that patch? Simply attach it to the bug report.
Oliver
Ritu Kedia wrote:
I have a fix for Bug# 30317 for RDBMS Content Stores.
Could someone review the patch for the same? If yes, please let me know..
I
will send the patch file.
Regards,
Ritu
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: DB2RDBMSAdapter.java
===
RCS file:
/home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/DB2RDBMSAdapter.java,v
retrieving revision 1.1
diff -u -r1.1 DB2RDBMSAdapter.java
--- DB2RDBMSAdapter.java15 Jul 2004 06:38:24 - 1.1
+++ DB2RDBMSAdapter.java28 Jul 2004 10:13:20 -
@@ -606,6 +606,7 @@
throw ex;
}
}
+ revisionDescriptor.setContentLength(contentLength);
// Changed (contentlength - 1) to (contentlength) as DB2 was
complaining about
// length mismatch for stream in the below method
// insertStatement.setBinaryStream(2, is, (int)contentLength -1);
Index: OracleRDBMSAdapter.java
===
RCS file:
/home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/OracleRDBMSAdapter.java,v
retrieving revision 1.6
diff -u -r1.6 OracleRDBMSAdapter.java
--- OracleRDBMSAdapter.java 15 Jul 2004 06:38:24 - 1.6
+++ OracleRDBMSAdapter.java 28 Jul 2004 10:13:20 -
@@ -117,12 +117,11 @@
Connection connection,
Uri uri,
NodeRevisionDescriptor revisionDescriptor,
-NodeRevisionContent revisionContent)
+InputStream in)
throws IOException, SQLException
{
getLogger().log(storeContent: + uri, Logger.DEBUG);
-assureVersionInfo(connection, uri, revisionDescriptor);
long versionContentId = getVersionContentId(connection, uri,
revisionDescriptor);
insertEmptyContent(connection, versionContentId);
@@ -134,15 +133,7 @@
try {
res.next();
Blob blob = res.getBlob(1);
-InputStream in = revisionContent.streamContent();
OutputStream out = ((oracle.sql.BLOB) blob).getBinaryOutputStream();
-
-if (bcompress) {
-getLogger().log(Compressing the data, LOG_CHANNEL, 6);
-StoreContentZip ziputil = new StoreContentZip();
-ziputil.Zip(in);
-in = ziputil.getInputStream();
-}
try {
copy(in, out, ((oracle.sql.BLOB) blob).getBufferSize());
Index: StandardRDBMSAdapter.java
===
RCS file:
/home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/StandardRDBMSAdapter.java,v
retrieving revision 1.28
diff -u -r1.28 StandardRDBMSAdapter.java
--- StandardRDBMSAdapter.java 25 Jul 2004 09:48:56 - 1.28
+++ StandardRDBMSAdapter.java 28 Jul 2004 10:13:21 -
@@ -1185,62 +1185,80 @@
}
byte buffer[] = new byte[2048];
File tempFile = null;
-if (contentLength == -1) {
-try {
-tempFile = File.createTempFile(content, null);
-FileOutputStream fos = new FileOutputStream(tempFile);
-do {
-int nChar = is.read(buffer);
-if (nChar == -1)
-break;
-fos.write(buffer, 0, nChar);
-} while (true);
-fos.close();
-is.close();
-is = new FileInputStream(tempFile);
-contentLength = tempFile.length();
-} catch (IOException ex) {
-getLogger().log(
-ex.toString() + during the calculation of the content
length.,
-LOG_CHANNEL,
-
Re: Patch for Bug# 30317
Seems you accidently removed compression support? As the formatting in
your patch is different from the one in CVS it is very hard for me to
see the real changes. Additionally, your patch contains tabs instead of
spaces. Could your change this, please?
Other than that Davide should be the one to review it.
Davide?
Oliver
Ritu Kedia wrote:
Oliver,
For some reason I keep getting Create attachment Bug 30317: No file was
provided, or it was empty. error, when uploading the patch on bugzilla. I
am attaching the patch here. Could you please upload it?
Also I have created the patch on latest from CVS head but tested the fix on
2.1M1 with Oracle Store. Please review it and let me know if you face any
problem with it.
Regards,
Ritu
-Original Message-
From: Oliver Zeigermann [mailto:[EMAIL PROTECTED]
Sent: Wednesday, July 28, 2004 2:38 PM
To: Slide Developers Mailing List
Subject: Re: Patch for Bug# 30317
Where is that patch? Simply attach it to the bug report.
Oliver
Ritu Kedia wrote:
I have a fix for Bug# 30317 for RDBMS Content Stores.
Could someone review the patch for the same? If yes, please let me know..
I
will send the patch file.
Regards,
Ritu
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: DB2RDBMSAdapter.java
===
RCS file: /home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/DB2RDBMSAdapter.java,v
retrieving revision 1.1
diff -u -r1.1 DB2RDBMSAdapter.java
--- DB2RDBMSAdapter.java 15 Jul 2004 06:38:24 - 1.1
+++ DB2RDBMSAdapter.java 28 Jul 2004 10:13:20 -
@@ -606,6 +606,7 @@
throw ex;
}
}
+ revisionDescriptor.setContentLength(contentLength);
// Changed (contentlength - 1) to (contentlength) as DB2 was complaining about
// length mismatch for stream in the below method
// insertStatement.setBinaryStream(2, is, (int)contentLength -1);
Index: OracleRDBMSAdapter.java
===
RCS file: /home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/OracleRDBMSAdapter.java,v
retrieving revision 1.6
diff -u -r1.6 OracleRDBMSAdapter.java
--- OracleRDBMSAdapter.java 15 Jul 2004 06:38:24 - 1.6
+++ OracleRDBMSAdapter.java 28 Jul 2004 10:13:20 -
@@ -117,12 +117,11 @@
Connection connection,
Uri uri,
NodeRevisionDescriptor revisionDescriptor,
-NodeRevisionContent revisionContent)
+InputStream in)
throws IOException, SQLException
{
getLogger().log(storeContent: + uri, Logger.DEBUG);
-assureVersionInfo(connection, uri, revisionDescriptor);
long versionContentId = getVersionContentId(connection, uri, revisionDescriptor);
insertEmptyContent(connection, versionContentId);
@@ -134,15 +133,7 @@
try {
res.next();
Blob blob = res.getBlob(1);
-InputStream in = revisionContent.streamContent();
OutputStream out = ((oracle.sql.BLOB) blob).getBinaryOutputStream();
-
-if (bcompress) {
-getLogger().log(Compressing the data, LOG_CHANNEL, 6);
-StoreContentZip ziputil = new StoreContentZip();
-ziputil.Zip(in);
-in = ziputil.getInputStream();
-}
try {
copy(in, out, ((oracle.sql.BLOB) blob).getBufferSize());
Index: StandardRDBMSAdapter.java
===
RCS file: /home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/StandardRDBMSAdapter.java,v
retrieving revision 1.28
diff -u -r1.28 StandardRDBMSAdapter.java
--- StandardRDBMSAdapter.java 25 Jul 2004 09:48:56 - 1.28
+++ StandardRDBMSAdapter.java 28 Jul 2004 10:13:21 -
@@ -1185,62 +1185,80 @@
}
byte buffer[] = new byte[2048];
File tempFile = null;
-if (contentLength == -1) {
-try {
-tempFile = File.createTempFile(content, null);
-FileOutputStream fos = new FileOutputStream(tempFile);
-do {
-int nChar = is.read(buffer);
-if (nChar == -1)
-break;
-fos.write(buffer, 0, nChar);
-} while (true);
-fos.close();
-is.close();
-is = new FileInputStream(tempFile);
-contentLength = tempFile.length();
-
PollAssert? (was [GUMP@brutus]: jakarta-slide/jakarta-slide failed)
from http://brutus.apache.org/gump/public/jakarta-slide/jakarta-slide/gump_work/build_jakarta-slide_jakarta-slide.txt [javac] /usr/local/gump/public/workspace/jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor/TProcessors.java:1498: cannot resolve symbol [javac] symbol : class PollAssert [javac] location: class org.apache.slide.testsuite.testtools.tprocessor.TProcessors [javac]result = new PollAssert((XMLResponseMethodBase) m, [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -deprecation for details. [javac] 1 error where do I find the PollAssert class? On my machine: $ find /javastuff/gump/jakarta-slide/ -name \*Poll\* /javastuff/gump/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/PollMethod.java /javastuff/gump/jakarta-slide/webdavclient/clientlib/src/java/org/apache/webdav/lib/methods/PollMethod.java /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/classes/org/apache/webdav/lib/NotificationListener$PollMethod$ResponseHandler.class /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/classes/org/apache/webdav/lib/NotificationListener$PollMethod.class /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/classes/org/apache/webdav/lib/methods/PollMethod.class /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/doc/clientjavadoc/org/apache/webdav/lib/methods/PollMethod.html /javastuff/gump/jakarta-slide/webdavclient/dist/doc/clientjavadoc/org/apache/webdav/lib/methods/PollMethod.html /javastuff/gump/jakarta-slide/build/classes/org/apache/slide/webdav/event/WebdavEvent$Poll.class /javastuff/gump/jakarta-slide/build/classes/org/apache/slide/webdav/method/PollMethod.class Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor PollAssert.java
luetzkendorf2004/07/28 04:23:50
Added:
testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor
PollAssert.java
Log:
added
Revision ChangesPath
1.1
jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor/PollAssert.java
Index: PollAssert.java
===
// vi: set ts=3 sw=3:
package org.apache.slide.testsuite.testtools.tprocessor;
import java.util.List;
import org.apache.slide.testsuite.testtools.tutil.XConf;
import org.apache.webdav.lib.methods.XMLResponseMethodBase;
import org.jdom.Element;
/**
* @author Stefan Lützkendorf
*/
public class PollAssert extends PropfindAssert
{
public PollAssert(XMLResponseMethodBase method, Element expectedXmlTree,
XConf xconf, XMLOutput xmlresult, List expectedResponseCodes)
{
super(method, expectedXmlTree, xconf, xmlresult, expectedResponseCodes);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor PollAssert.java
luetzkendorf2004/07/28 04:25:29
Modified:
testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor
PollAssert.java
Log:
removed author tag
Revision ChangesPath
1.2 +0 -3
jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor/PollAssert.java
Index: PollAssert.java
===
RCS file:
/home/cvs/jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor/PollAssert.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- PollAssert.java 28 Jul 2004 11:23:50 - 1.1
+++ PollAssert.java 28 Jul 2004 11:25:29 - 1.2
@@ -8,9 +8,6 @@
import org.jdom.Element;
-/**
- * @author Stefan Lützkendorf
- */
public class PollAssert extends PropfindAssert
{
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: PollAssert? (was [GUMP@brutus]: jakarta-slide/jakarta-slide failed)
in the cvs now. jakarta-slide\testsuite\testsuite\junit\src\org\apache\slide\testsuite\testtools\tprocessor\PollAssert.java Stefan Bodewig wrote: from http://brutus.apache.org/gump/public/jakarta-slide/jakarta-slide/gump_work/build_jakarta-slide_jakarta-slide.txt [javac] /usr/local/gump/public/workspace/jakarta-slide/testsuite/testsuite/junit/src/org/apache/slide/testsuite/testtools/tprocessor/TProcessors.java:1498: cannot resolve symbol [javac] symbol : class PollAssert [javac] location: class org.apache.slide.testsuite.testtools.tprocessor.TProcessors [javac]result = new PollAssert((XMLResponseMethodBase) m, [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -deprecation for details. [javac] 1 error where do I find the PollAssert class? On my machine: $ find /javastuff/gump/jakarta-slide/ -name \*Poll\* /javastuff/gump/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/PollMethod.java /javastuff/gump/jakarta-slide/webdavclient/clientlib/src/java/org/apache/webdav/lib/methods/PollMethod.java /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/classes/org/apache/webdav/lib/NotificationListener$PollMethod$ResponseHandler.class /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/classes/org/apache/webdav/lib/NotificationListener$PollMethod.class /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/classes/org/apache/webdav/lib/methods/PollMethod.class /javastuff/gump/jakarta-slide/webdavclient/build/clientlib/doc/clientjavadoc/org/apache/webdav/lib/methods/PollMethod.html /javastuff/gump/jakarta-slide/webdavclient/dist/doc/clientjavadoc/org/apache/webdav/lib/methods/PollMethod.html /javastuff/gump/jakarta-slide/build/classes/org/apache/slide/webdav/event/WebdavEvent$Poll.class /javastuff/gump/jakarta-slide/build/classes/org/apache/slide/webdav/method/PollMethod.class Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: PollAssert? (was [GUMP@brutus]: jakarta-slide/jakarta-slide failed)
On Wed, 28 Jul 2004, Stefan Lützkendorf [EMAIL PROTECTED] wrote: in the cvs now. Great! I've just managed to have an end-to-end build of Slide in Gump on my machine. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/testsuite/testsuite/junit/xmltestcases/functional/get/conditional - New directory
luetzkendorf2004/07/28 05:00:12 jakarta-slide/testsuite/testsuite/junit/xmltestcases/functional/get/conditional - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/testsuite/testsuite/junit/xmltestcases/functional/get/conditional getConditionalByETag.xml getConditionalByTime.xml
luetzkendorf2004/07/28 05:00:48 Added: testsuite/testsuite/junit/xmltestcases/functional/get/conditional getConditionalByETag.xml getConditionalByTime.xml Log: added testcases to verify conditional GETs Revision ChangesPath 1.1 jakarta-slide/testsuite/testsuite/junit/xmltestcases/functional/get/conditional/getConditionalByETag.xml Index: getConditionalByETag.xml === ?xml version=1.0 encoding=utf-8? !DOCTYPE test SYSTEM ../../../../Tprocessor.dtd test specification abstract Checkes whether If-Match and If-None-Match are handled correctly /abstract description put a file get the file (store the responsed ETag at varETag) get the file with If-Match: %varETag% (should return 200) get the file with If-None-Match: %varETag% (should return 304) put the file again (i.e. modifiy it) get the file with If-Match: %varETag% (should return 412) get the file with If-None-Match: %varETag% (should return 200) /description expectedResult /expectedResult /specification step request command varUsage=globalVariableCollection,globalVariableServerNamePUT /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command body fileReference=../../../contentDirectory/html.html / /request response commandHTTP/1.0 201 Created/command /response /step step request command varUsage=globalVariableCollection,globalVariableServerNameGET /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command /request response commandHTTP/1.0 200 OK/command header varDefinition=varETagETag: */header body fileReference=../../../contentDirectory/html.html / /response /step step request command varUsage=globalVariableCollection,globalVariableServerNameGET /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command header varUsage=varETagIf-Match: %varETag%/header /request response commandHTTP/1.0 200 OK/command body fileReference=../../../contentDirectory/html.html / /response /step step request command varUsage=globalVariableCollection,globalVariableServerNameGET /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command header varUsage=varETagIf-None-Match: %varETag%/header /request response commandHTTP/1.0 304 Not Modified/command /response /step step request command varUsage=globalVariableCollection,globalVariableServerNamePUT /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command body fileReference=../../../contentDirectory/html.html / /request response commandHTTP/1.0 204 No Content/command /response /step step request command varUsage=globalVariableCollection,globalVariableServerNameGET /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command header varUsage=varETagIf-Match: %varETag%/header /request response commandHTTP/1.0 412 Precondition Failed/command /response /step step request command varUsage=globalVariableCollection,globalVariableServerNameGET /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command header varUsage=varETagIf-None-Match: %varETag%/header /request response commandHTTP/1.0 200 OK/command body fileReference=../../../contentDirectory/html.html / /response /step cleanup step request command varUsage=globalVariableCollection,globalVariableServerNameDELETE /%globalVariableServerName%/%globalVariableCollection%/help-doc.html HTTP/1.1/command /request response commandHTTP/1.0 204 No Content/command /response /step /cleanup /test 1.1 jakarta-slide/testsuite/testsuite/junit/xmltestcases/functional/get/conditional/getConditionalByTime.xml Index: getConditionalByTime.xml === ?xml version=1.0 encoding=utf-8? !DOCTYPE test SYSTEM ../../../../Tprocessor.dtd test specification abstract Checkes whether If-Modified-Since and If-Unmodified-Since are handled correctly /abstract description put a file get the file (store the Last-Modified date at varLastMod) get the file with If-Modified-Since: %varLastMod% (should return 304) get the file with If-Unmodified-Since: %varLastMod% (should return 200) waste some time (at least a second, otherwise the next
Re: PollAssert? (was [GUMP@brutus]: jakarta-slide/jakarta-slide failed)
Thanks for all the help :) Oliver Stefan Bodewig wrote: On Wed, 28 Jul 2004, Stefan Lützkendorf [EMAIL PROTECTED] wrote: in the cvs now. Great! I've just managed to have an end-to-end build of Slide in Gump on my machine. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Patch for Bug# 30317
I'll look at it with more attention at home this evening but if I've understood the problem, this bug affects the Oracle store because it doesn't correct contentLength if it's == -1... a possible solution could be: If compression support is on revisionDescriptor.setContentLength(ziputil.getContentLength()); else count the bytes copied to the Oracle Blob in the copy method... -- Davide Savazzi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Patch for Bug# 30317
David, Thanks for looking into this patch. I did try the solution proposed by you i.e. count the bytes copied to Oracle Blob, but that did not return the correct length. I basically executed the select stmt of the storeContent method of the OracleRDBMSStore, after the copy method and then retrieved the blob and queried for blob.length(). The length method did not return the correct length. I don't know the reason for that. So instead of creating a tempFile in the OracleRDBMSStore I used the same code of StandardRDBMSStore for computing contentlength. Regards, Ritu -Original Message- From: Davide Savazzi [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 28, 2004 6:16 PM To: Slide Developers Mailing List Subject: Re: Patch for Bug# 30317 I'll look at it with more attention at home this evening but if I've understood the problem, this bug affects the Oracle store because it doesn't correct contentLength if it's == -1... a possible solution could be: If compression support is on revisionDescriptor.setContentLength(ziputil.getContentLength()); else count the bytes copied to the Oracle Blob in the copy method... -- Davide Savazzi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide RELEASE-NOTES-2.1-BETA1
luetzkendorf2004/07/28 06:33:54 Modified:.RELEASE-NOTES-2.1-BETA1 Log: added some lines Revision ChangesPath 1.3 +5 -1 jakarta-slide/RELEASE-NOTES-2.1-BETA1 Index: RELEASE-NOTES-2.1-BETA1 === RCS file: /home/cvs/jakarta-slide/RELEASE-NOTES-2.1-BETA1,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- RELEASE-NOTES-2.1-BETA1 28 Jul 2004 09:58:39 - 1.2 +++ RELEASE-NOTES-2.1-BETA1 28 Jul 2004 13:33:53 - 1.3 @@ -30,10 +30,12 @@ - JNDI store for users - New caching modes - File Store performance improved +- Transient utility stores Client: - External Transaction Support as defined by MS - JCA Connector for Slide +- new Ant tasks Misc: - Projector Framework @@ -63,6 +65,7 @@ WebDAV Layer: +- SEARCH doesn't work with WebdavServlet mapped to a path other than / Core: - Performance on large collections still not satisfactory @@ -74,4 +77,5 @@ Client: Misc: -- Documentation needs to be improved \ No newline at end of file +- Documentation needs to be improved + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/webdavclient build.xml
luetzkendorf2004/07/28 06:34:41 Modified:webdavclient build.xml Log: name of current commons-transaction.jar updated Revision ChangesPath 1.21 +1 -1 jakarta-slide/webdavclient/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-slide/webdavclient/build.xml,v retrieving revision 1.20 retrieving revision 1.21 diff -u -r1.20 -r1.21 --- build.xml 27 Jul 2004 13:04:13 - 1.20 +++ build.xml 28 Jul 2004 13:34:40 - 1.21 @@ -52,7 +52,7 @@ property name=antlr.jar value=lib/antlr.jar/ property name=commons-logging.jar value=lib/commons-logging.jar/ property name=ant.jar value=lib/ant.jar/ -property name=commons-transaction.jar value=lib/commons-transaction-20040719.jar/ +property name=commons-transaction.jar value=lib/commons-transaction-20040726.jar/ property name=j2ee-spec.jar value=lib/geronimo-spec-j2ee-1.0-M1.jar/ property name=jdom.jar value=lib/jdom-20040226-.jar/ property name=xml-im-exporter.jar value=lib/xml-im-exporter1.1.jar/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/testsuite build.xml
luetzkendorf2004/07/28 06:35:14
Modified:testsuite build.xml
Log:
2.1M2 renamed to 2.1b1
Revision ChangesPath
1.28 +1 -1 jakarta-slide/testsuite/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-slide/testsuite/build.xml,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- build.xml 13 Jul 2004 09:22:22 - 1.27
+++ build.xml 28 Jul 2004 13:35:14 - 1.28
@@ -3,7 +3,7 @@
property name=src value=${basedir}/testsuite/junit/src /
property name=debug value=${basedir}/testsuite/junit/debug /
property name=lib value=${basedir}/lib /
- property name=version value=2.1M2 /
+ property name=version value=2.1b1 /
property name=slideclientlib value=${basedir}/../webdavclient/dist/lib /
property name=slideclientextlib value=${basedir}/../webdavclient/lib /
property name=dist value=${basedir}/dist /
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-slide/testsuite tp.properties.sample
luetzkendorf2004/07/28 06:36:03 Modified:testsuite tp.properties.sample Log: space that produces a NumberFormatException Revision ChangesPath 1.5 +1 -1 jakarta-slide/testsuite/tp.properties.sample Index: tp.properties.sample === RCS file: /home/cvs/jakarta-slide/testsuite/tp.properties.sample,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- tp.properties.sample 13 Jul 2004 08:53:57 - 1.4 +++ tp.properties.sample 28 Jul 2004 13:36:03 - 1.5 @@ -5,7 +5,7 @@ xdav.workhost = localhost xdav.workdb = xdav.users = 1 -xdav.iterations = 1 +xdav.iterations = 1 # TODO: # Rename properties (shorter and more intuitive names :-)) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
author tags in proposals/jcrri
dear colleagues i followed the poll regarding removal of @author tags in the slide source code with great interest. i didn't cast my vote though for 2 reasons: - i didn't want to interfere because i do not work on the slide code base. - as committer of the code in proposals/jcrri i consider myself a guest in the slide community as i am not (yet) actively involved in the development of slide. i agree that removing the @author tags makes sense for code that a lot of people have been working on, that is evolving over a longer period of time, where the author(s) can not be identified properly or where the individual contributions are not apparent. but i wasn't aware though that @author tags would also be removed from the JCR Reference Implementation (proposals/jcrri): 1. the future/role of this proposal within slide is still unclear and has to be decided upon by the community. the JCR RI is currently not an official part of the slide project. 2. i am currently the sole committer working on this proposal. 3. the initial idea/hope was that a community would evolve around this proposal. this was unfortunately not realistic, as the reference implementation is trying to implement an api that is still quite volatile and that (current version) is not publicly disclosed yet. the current code itself is subject to major changes. things will change hopefully when the final proposal draft is available. 4. the jcrri proposal is currently attracting a lot of interest from people from outside of the slide community. i am taking the full responsibility for this code: bugs, bad coding style and/or design, other shortcomings... i am the one to blame as i am the author of this code and i should be identifiable as such. the reasons for removing the @author tags were: quoting_oliver - author tags hardly and rarely indicate the person to talk to. - the whole community is in charge of code, not just the person(s) indicated by author tags /quoting_oliver those clearly do not apply for the jcrri proposal (at least not for the time being). i therefore kindly ask for undoing the @author tag removal in proposals/jcrri for the above stated reasons. should the jcr ri become official part of slide sometime (in whatever form ever) and should a community develop around this code base i would gladly remove all @author tags. cheers stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: author tags in proposals/jcrri
Folks! I understand Stefan's view. Additionally, what about the stuff in the wvcm implementation? Anyway, quoting from the ASF Board Summary for February 18, 2004 - author tags are officially discouraged. these create difficulties in establishing the proper ownership and the protection of our committers. there are other social issues dealing with collaborative development, but the Board is concerned about the legal ramifications around the use of author tags - it is quite acceptable and encouraged to recognize developers' efforts in a CHANGES file, or some other descriptive file which is associated with the overall PMC or release rather than individual files. I noticed the jcrri proposal does not even have an Apache License. I really have no idea how it relates to the ASF if this is so. Just for me, Stefan, could you clarify your role in the Slide community, especially do you see yourself as part of it? If not, what is the role of the jcrri proposal in the Slide CVS? I honestly am just wondering, no intention to push this discussion in any direction. Oliver Stefan Guggisberg wrote: dear colleagues i followed the poll regarding removal of @author tags in the slide source code with great interest. i didn't cast my vote though for 2 reasons: - i didn't want to interfere because i do not work on the slide code base. - as committer of the code in proposals/jcrri i consider myself a guest in the slide community as i am not (yet) actively involved in the development of slide. i agree that removing the @author tags makes sense for code that a lot of people have been working on, that is evolving over a longer period of time, where the author(s) can not be identified properly or where the individual contributions are not apparent. but i wasn't aware though that @author tags would also be removed from the JCR Reference Implementation (proposals/jcrri): 1. the future/role of this proposal within slide is still unclear and has to be decided upon by the community. the JCR RI is currently not an official part of the slide project. 2. i am currently the sole committer working on this proposal. 3. the initial idea/hope was that a community would evolve around this proposal. this was unfortunately not realistic, as the reference implementation is trying to implement an api that is still quite volatile and that (current version) is not publicly disclosed yet. the current code itself is subject to major changes. things will change hopefully when the final proposal draft is available. 4. the jcrri proposal is currently attracting a lot of interest from people from outside of the slide community. i am taking the full responsibility for this code: bugs, bad coding style and/or design, other shortcomings... i am the one to blame as i am the author of this code and i should be identifiable as such. the reasons for removing the @author tags were: quoting_oliver - author tags hardly and rarely indicate the person to talk to. - the whole community is in charge of code, not just the person(s) indicated by author tags /quoting_oliver those clearly do not apply for the jcrri proposal (at least not for the time being). i therefore kindly ask for undoing the @author tag removal in proposals/jcrri for the above stated reasons. should the jcr ri become official part of slide sometime (in whatever form ever) and should a community develop around this code base i would gladly remove all @author tags. cheers stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: author tags in proposals/jcrri
hi oliver, I noticed the jcrri proposal does not even have an Apache License. I really have no idea how it relates to the ASF if this is so. first of all: i am not a lawyer. consider this a disclaimer. ;) the code in jcrri is licensed under a license written by roy fielding based on the Apache 2.0 license which is equivalent to the Apache 2.0 License. the ri, the tck and the spec will all have this licence. Just for me, Stefan, could you clarify your role in the Slide community, especially do you see yourself as part of it? If not, what is the role of the jcrri proposal in the Slide CVS? proposals/jcrri goes back to a proposal submitted by remy maucherat: http://www.mail-archive.com/[EMAIL PROTECTED]/msg05538.html quoting_remy The goals of this proposal would be: - Provide an OSS implementation of JSR 170. - Provide implementation feedback to the JSR 170 expert group, allowing to enhance the specification and fix problems (that's the usual role of a RI). - Provide a more modular architecture for Slide, with the goal of adopting it for Slide 3.x (as with all revolution style proposals, this will of course be subject to a majority vote by all Slide committers, when the proposal is considered to be ready). The WebDAV layer would be able to function on top of another JSR 170 compliant repository, and applications using JSR 170 would be able to use either Slide or WebDAV as their backend. /quoting_remy my role is to work on the code in proposals/jcrri. also, here's the link to the committer vote: http://www.mail-archive.com/[EMAIL PROTECTED]/msg05588.html i personally think that slide and jsr 170 are a natural fit. i very much like the idea of slide being the reference implementation of jsr 170 (like tomcat being the reference implementation of the servlet spec). i also find remy's suggested architecture very intriguing: - WebDAV powered JSR 170 client API - WebDAV server layer, using JSR 170 API - Slide core, providing a JSR 170 API on the other hand, i am obviously biased ;) of course i can't speak for the slide community, this is just my personal view. further answering your question: currently it would be arrogant to claim being part of the slide community as i do not work on the current code base (version 2.x) of slide. i am devoted to open source development and if the slide community would decide to incorporate jsr 170 in the next major release, i would gladly offer to contribute and i'd certainly feel very priviledged to be part of the team that develops slide. does this answer your questions? cheers stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: OutOfMemoryError
Oliver Zeigermann wrote: Actually, this was a bug in TxXMLFileDescriptorsStore as descriptors were never freed. Hopefully, this has been fixed with my latest commit. Could you please check? Yes, the OutOfMemoryError disappeared. Thank you! Guido Thanks and cheers, Oliver Oliver Zeigermann wrote: Hi Guido! The external transactions are nothing you can switch off, as they only get enabled when you start an external transaction. Thus they are switched off by default. Concerning the OutOfMemoryError: Thanks for the stack trace! This is most likely a bug and I will take care of it. Cheers, Oliver Guido Casper wrote: Hi all, when stress testing my application I get OutOfMemoryErrors within Slide (CVS head): java.lang.OutOfMemoryError org.apache.slide.common.ServiceAccessException: Service TxXMLFileDescriptorsStore at store/metadata working on work/metadata access error : java.lang.OutOfMemoryError at org.apache.slide.store.AbstractStore.storeRevisionDescriptor(AbstractStore.java:1235) ... (see complete stacktrace below) What I don't understand is that I DO use TxXMLFileDescriptorsStore: scope match=/ store=tx/ but all traffic is below /files and I have: scope match=/files store=mysql/ Anyway - did anyone experience the same or has an idea what the problem might be? Might it possibly have something to do with the external transaction stuff? Is there an easy way to switch it off (for ruling out)? Thanks Guido http8585-Processor15, 20-Jul-2004 18:56:04, gcasper, PROPFIND, 207 Multi-Status, 1862 ms, /files/repo/staging/documents/article/article.xml java.lang.OutOfMemoryError org.apache.slide.common.ServiceAccessException: Service TxXMLFileDescriptorsStore at store/metadata working on work/metadata access error : java.lang.OutOfMemoryError at org.apache.slide.store.AbstractStore.storeRevisionDescriptor(AbstractStore.java:1235) at org.apache.slide.store.ExtendedStore.storeRevisionDescriptor(ExtendedStore.java:884) at org.apache.slide.content.ContentImpl.store(ContentImpl.java:1039) at org.apache.slide.webdav.util.VersioningHelper.checkout(VersioningHelper.java:813) at org.apache.slide.webdav.method.PutMethod.executeRequest(PutMethod.java:210) at org.apache.slide.webdav.method.AbstractWebdavMethod.run(AbstractWebdavMethod.java:364) at org.apache.slide.webdav.WebdavServlet.service(WebdavServlet.java:166) at javax.servlet.http.HttpServlet.service(HttpServlet.java:856) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:284) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:204) at org.apache.slide.webdav.filter.LogFilter.doFilter(LogFilter.java:141) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:233) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:204) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:256) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:151) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:564) at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:245) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:199) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:151) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:594) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:149) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:564) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:195) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:151) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:164) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:149) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:564) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:156) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:151) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:564) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:972) at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:211) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:805) at
RE: author tags in proposals/jcrri
hi daniel, as far as I understand your code is at the moment completely separated from the Slide project. correct IMO it would be a good idea to integrate the jcrri into the Slide project as this would give you some more feedback on your work. There are lots of people out there using Slide. i totally agree. As we plan to introduce a completely new api in the Slide 3.0 release, it might of interest to see if the jsr-170 api would be a choice. Have a look at this thread: http://www.mail-archive.com/slide-dev%40jakarta.apache.org/msg10230.html So, to see if the 170-api suits our needs it would be great to have an implementation that talks to the Slide server via WebDAV using the webdavclient library. The upcoming Slide 2.1 release has some nice new features as remote long term transactions and notifications, that are also available via the client lib. having the jcr api on top of the webdavclient library would be certainly very appealing. the ri uses abstract filesystems to store its persistence model. currently you can already use the DavFileSystem (which uses the webdavclient lib) for the persistence layer. but as the jsr-170 content model is very granular and the ri's persistence model is very generic (just nodes and properties), on the webdav sevrer you'd only see a bizillion of .node.xml files with cryptic paths. adding a file through the jcr api would e.g. mean adding a node of node type 'nt'mimeResource'. that resource would be represented as 10+ separate files on the server. the core problem is that the jsr content model (which the ri has obviouly to support) is a superset of the dav model: it supports well-structured, semi-structured and unstructrued content where the dav model is resource centric (resources and collections). take a look at http://jsr170tools.day.com/crx to get an impression of the jsr/170 content model (any username will do ;). what do you think of exposing the jcr api as the slide core api (i.e. on the server)? a webdav server on top of the jcr api would imo complete the picture. we have done a quickdirty implementation that you can try. just point your webdav client to http://jsr170tools.day.com/crx/repository. using this architecture: - jcr on the client using webdav as protocol - webdav server on top of jcr - jcr at the core would provide the following benefits: - clients could use either jcr or webdav to access the repository - java clients could access arbitrary webdav servers using jcr - webdav clients could access arbitrary jcr repositories - jcr clients could transparantly access remote and local repositories cheers stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Patch for Bug# 30317
On Wednesday 28 July 2004 14:57, Ritu Kedia wrote:
I did try the solution proposed by you i.e. count the bytes copied to
Oracle Blob, but that did not return the correct length. I basically
executed the select stmt of the storeContent method of the
OracleRDBMSStore, after the copy method and then retrieved the blob and
queried for blob.length().
No I mean count the bytes as they are written to Oracle in the copy(...)
method in CommonRDBMSAdapter, so you don't have to write a tmp file.
I think there's a problem in your patch when you use compression and
contentLength is -1.
ziputil.getContentLength() returns the _compressed_ file size, that is good
for:
statement.setBinaryStream(1, is, (int) contentLength);
but bad for:
revisionDescriptor.setContentLength(contentLength);
I've attached patches for Oracle adapter and StoreContentZip, tell me if they
works to you...
Cheers,
--
Davide Savazzi
/*
* $Header: /home/cvspublic/jakarta-slide/src/stores/org/apache/slide/store/impl/rdbms/CommonRDBMSAdapter.java,v 1.2 2004/07/25 11:33:55 unico Exp $
* $Revision: 1.2 $
* $Date: 2004/07/25 11:33:55 $
*
*
*
* Copyright 2004 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.slide.store.impl.rdbms;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import org.apache.slide.common.Service;
import org.apache.slide.common.ServiceAccessException;
import org.apache.slide.common.Uri;
import org.apache.slide.content.NodeRevisionDescriptor;
import org.apache.slide.content.NodeRevisionNumber;
import org.apache.slide.lock.LockTokenNotFoundException;
import org.apache.slide.lock.NodeLock;
import org.apache.slide.security.NodePermission;
import org.apache.slide.structure.ObjectNode;
import org.apache.slide.structure.ObjectNotFoundException;
import org.apache.slide.util.logger.Logger;
/**
* This adapter has code that has been ported from OracleRDBMSAdapter so that it can be
* resued by both OracleRDBMSAdapter and DB2RDBMSAdapter.
*
*/
public class CommonRDBMSAdapter extends StandardRDBMSAdapter {
// Constructor
public CommonRDBMSAdapter(Service service, Logger logger) {
super(service, logger);
}
public void removeObject(Connection connection, Uri uri, ObjectNode object)
throws ServiceAccessException, ObjectNotFoundException
{
PreparedStatement statement = null;
try {
clearBinding(connection, uri);
// delete links
try {
statement =
connection.prepareStatement(
delete from LINKS l where l.URI_ID in ( +
select u.URI_ID from URI u where u.URI_STRING = ?));
statement.setString(1, uri.toString());
statement.executeUpdate();
} finally {
close(statement);
}
// delete version history
// FIXME: Is this true??? Should the version history be removed if the object is removed???
try {
statement =
connection.prepareStatement(
delete from VERSION_HISTORY vh where vh.URI_ID in ( +
select u.URI_ID from URI u where u.URI_STRING = ?));
statement.setString(1, uri.toString());
statement.executeUpdate();
} finally {
close(statement);
}
// delete version
try {
statement =
connection.prepareStatement(
delete from VERSION v where v.URI_ID in ( +
select u.URI_ID from URI u where u.URI_STRING = ?));
statement.setString(1, uri.toString());
statement.executeUpdate();
} finally {
close(statement);
}
// delete the object itself
try {
statement =
connection.prepareStatement(
delete from OBJECT o where o.URI_ID in ( +
select u.URI_ID from URI u where u.URI_STRING = ?));
statement.setString(1, uri.toString());
