Re: [Spacewalk-devel] pgsql-master merge

2009-07-21 Thread Greg DeKoenigsberg

On Tue, 21 Jul 2009, Jeff Ortel wrote:


All,

Yesterday I merged master-pgsql and today I'm planning on doing some schema 
verification.  Assuming that I can verify the schema (for oracle) is 
equivalent, I will merge the pgsql branch TO master tomorrow 7/22.


The following review items have been addressed:

1) Trailing white space removed from common/tables/*.sql
2) Schema upgrade scripts refactoring reverted.  The upgrade scripts will 
remain as they are today.

3) Chameleon added to build roots.
4) Upgrade script generated to replace named not-null constraints with 
anonymous column modifier.


Any other issues to be resolved before the merge?  Last chance to review 
pgsql before it goes to master.


AWESOME!!!  :)

--g

--
Computer Science professors should be teaching open source.
Help make it happen.   Visit http://teachingopensource.org.

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] pgsql-master merge

2009-07-21 Thread Tom Lane
Jeff Ortel jor...@redhat.com writes:
 Yesterday I merged master-pgsql and today I'm planning on doing some schema 
 verification. 
   Assuming that I can verify the schema (for oracle) is equivalent, I will 
 merge the pgsql 
 branch TO master tomorrow 7/22.

Sweet.  Where are we on having an actually usable pgsql port?  Last I
heard there were still uncompleted tasks as far as installation went.

regards, tom lane

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] pgsql-master merge

2009-07-21 Thread Greg DeKoenigsberg

On Tue, 21 Jul 2009, Tom Lane wrote:


Jeff Ortel jor...@redhat.com writes:

Yesterday I merged master-pgsql and today I'm planning on doing some 
schema verification.


  Assuming that I can verify the schema (for oracle) is equivalent, I 
will merge the pgsql branch TO master tomorrow 7/22.


Sweet.  Where are we on having an actually usable pgsql port?  Last I
heard there were still uncompleted tasks as far as installation went.


We've got to go through every query yet, don't we?

--g

--
Computer Science professors should be teaching open source.
Help make it happen.   Visit http://teachingopensource.org.

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] pgsql-master merge

2009-07-21 Thread Marcus Moeller
Good Evening.

 On Tue, 21 Jul 2009 13:28:28 -0400 (EDT)
 Greg DeKoenigsberg g...@redhat.com wrote:

 On Tue, 21 Jul 2009, Tom Lane wrote:

  Jeff Ortel jor...@redhat.com writes:
 
  Yesterday I merged master-pgsql and today I'm planning on doing
  some schema verification.

    Assuming that I can verify the schema (for oracle) is
  equivalent, I will merge the pgsql branch TO master tomorrow 7/22.
 
  Sweet.  Where are we on having an actually usable pgsql port?  Last
  I heard there were still uncompleted tasks as far as installation
  went.

 We've got to go through every query yet, don't we?

We ran into several performance issues on our Satellite Server with
Standalone Oracle DB (about 3000 clients) due to extremely large
queries (e.g. with about 1500 scheduled actions). I am currently
talking to our database engineer about optimization and we also want
to take a deeper look at hibernate caching features.

So maybe it's a good time to start revisioning some queries. I will
let you know when we got more detailed information.

Best Regards
Marcus

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] pgsql-master merge

2009-07-21 Thread Jeff Ortel



Milan Zazrivec wrote:

On Tuesday 21 July 2009 17:48:35 Jeff Ortel wrote:

All,

Yesterday I merged master-pgsql and today I'm planning on doing some
schema verification. Assuming that I can verify the schema (for oracle) is
equivalent, I will merge the pgsql branch TO master tomorrow 7/22.

The following review items have been addressed:

1) Trailing white space removed from common/tables/*.sql
2) Schema upgrade scripts refactoring reverted.  The upgrade scripts will
remain as they are today.
3) Chameleon added to build roots.
4) Upgrade script generated to replace named not-null constraints with
anonymous column modifier.

Any other issues to be resolved before the merge?  Last chance to review
pgsql before it goes to master.


The oracle schema in pgsql branch does not deploy cleanly. There's
a dependency problem: rhn_channel package body uses procedures
from rhn_user, which in the resulting main.sql is defined (well, declared)
after rhn_channel. Same for rhn_config_channel, rhn_entitlements,
rhn_org, rhn_server pbs.


I've been deploying all day and haven't seen this.  I'll look into it further.



Many columns declared as NUMBER(n) were changed in pgsql branch
to NUMBER (rhn_command_target table for example), which I don't believe
is equivalent.


Yes, I caught this during side-by-side verification and I'm fixing in chameleon 
now.



Also, I'm pretty sure everything rhnfaq* related is not needed in
the schema now.


Yes. I caught this (also) during side-by-side verification and removed them.



-MZ

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel