Re: [systemd-devel] [PATCH 05/11] After emergency service had been started any incoming traffic on syslog.socket

2014-06-20 Thread Lennart Poettering
On Fri, 13.06.14 16:41, Werner Fink (wer...@suse.de) wrote:

 From: arvidj...@gmail.com
 
 will terminate emergency.service due to implicit dependencies on basic.target
 and therefore sysinit.target which in turn conflict with
 emergency.target.

I am not entirely sure how emergecny.service should have been reached
with syslog.socket in place? isolate should not have left it around?

 
 ---
  units/emergency.service.in |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git units/emergency.service.in units/emergency.service.in
 index 94c090f..59f7cda 100644
 --- units/emergency.service.in
 +++ units/emergency.service.in
 @@ -9,7 +9,7 @@
  Description=Emergency Shell
  Documentation=man:sulogin(8)
  DefaultDependencies=no
 -Conflicts=shutdown.target
 +Conflicts=shutdown.target syslog.socket
  Before=shutdown.target
  
  [Service]


Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH 05/11] After emergency service had been started any incoming traffic on syslog.socket

2014-06-20 Thread Lennart Poettering
On Fri, 20.06.14 20:51, Andrey Borzenkov (arvidj...@gmail.com) wrote:

  I am not entirely sure how emergecny.service should have been reached
  with syslog.socket in place? isolate should not have left it around?
  
 
 commit 80cfe9e163b1c92f917e0a5e053b148fca790677
 Author: Dr. Tilmann Bubeck t.bub...@reinform.de
 Date:   Fri May 4 10:32:47 2012 +0200
 
 Do no isolate in case of emergency or severe problems

Ah, indeed!

Hmm, not sure what to do then, both goals are mutally incompatible:
either we don't isolate, and then risk that running some commands will
trigger the substantial amount of code. Or we isolate and then things
are much harder to debug, because the system is gone...

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH 05/11] After emergency service had been started any incoming traffic on syslog.socket

2014-06-19 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jun 17, 2014 at 06:52:04AM +0400, Andrey Borzenkov wrote:
 В Fri, 13 Jun 2014 16:41:04 +0200
 Werner Fink wer...@suse.de пишет:
 
  From: arvidj...@gmail.com
  
  will terminate emergency.service due to implicit dependencies on 
  basic.target
  and therefore sysinit.target which in turn conflict with emergency.target.
  
 
 I always considered it as a stopgap not suitable for upstream. But I
 still do not know what can be done to fix it.
 
 It still looks rather wrong that any arbitrary service can displace
 the whole run-level. May be we need counterpart for RefuseManualStart
 so that some targets can only be displaced manually, not as result of
 implicit dependency.
Agreed. We cannot play whack-a-mole like this, there's simply too many
units which seemingly randomly change the runlevel.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] [PATCH 05/11] After emergency service had been started any incoming traffic on syslog.socket

2014-06-16 Thread Andrey Borzenkov
В Fri, 13 Jun 2014 16:41:04 +0200
Werner Fink wer...@suse.de пишет:

 From: arvidj...@gmail.com
 
 will terminate emergency.service due to implicit dependencies on basic.target
 and therefore sysinit.target which in turn conflict with emergency.target.
 

I always considered it as a stopgap not suitable for upstream. But I
still do not know what can be done to fix it.

It still looks rather wrong that any arbitrary service can displace
the whole run-level. May be we need counterpart for RefuseManualStart
so that some targets can only be displaced manually, not as result of
implicit dependency.

 ---
  units/emergency.service.in |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git units/emergency.service.in units/emergency.service.in
 index 94c090f..59f7cda 100644
 --- units/emergency.service.in
 +++ units/emergency.service.in
 @@ -9,7 +9,7 @@
  Description=Emergency Shell
  Documentation=man:sulogin(8)
  DefaultDependencies=no
 -Conflicts=shutdown.target
 +Conflicts=shutdown.target syslog.socket
  Before=shutdown.target
  
  [Service]

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


[systemd-devel] [PATCH 05/11] After emergency service had been started any incoming traffic on syslog.socket

2014-06-13 Thread Werner Fink
From: arvidj...@gmail.com

will terminate emergency.service due to implicit dependencies on basic.target
and therefore sysinit.target which in turn conflict with emergency.target.

---
 units/emergency.service.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git units/emergency.service.in units/emergency.service.in
index 94c090f..59f7cda 100644
--- units/emergency.service.in
+++ units/emergency.service.in
@@ -9,7 +9,7 @@
 Description=Emergency Shell
 Documentation=man:sulogin(8)
 DefaultDependencies=no
-Conflicts=shutdown.target
+Conflicts=shutdown.target syslog.socket
 Before=shutdown.target
 
 [Service]
-- 
1.7.9.2

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel