Re: Help using Include

2009-06-18 Thread Assaf Arkin
On Wed, Jun 17, 2009 at 4:03 PM, Andrew Moore
andrew.mo...@redprairie.comwrote:

 Well, I have it working, but not as it seems like it should... I'm
 essentially excluding every other kind of file, like this:


 package(:war).path('').include(:from=_('../a/b/c')).exclude('**/*.gif').exclude('**/*.jpg').exclude('**/*.css')

 I've got about a dozen files I'm excluding, so this isn't a great solution.

 I am running version 1.3.3, so maybe there is a bug with that version
 related to this that has been fixed in 1.3.4.
 After looking more closely, it seems like with the other way:

 package(:war).path('').include(:from=_('../a/b/c')).include('**/*.js')


With the exception of merging zips, includes do not compose, so the first
include tells the path to include all the files from a/b/c, and the second
include tells path to include all the .js files in your build.

What's missing is a way to use :from but only for specific patten, something
like:

package(:war).include(**/*.js, :from='a/b/c')

I had to double check that there's no code for that, or an open issue (looks
like such an oversight). So first thing, let's add an issue.

Assaf



 I did seem to only get .js files, but I ended up with duplicate copies...
 one copy of all the .js files at the root of the war and another in the
 directory structure where I expect them to be.

 If I get time, I'll try and revisit this and create a test case example...
 I'm behind schedule right now, so I'll have to plug on with this. Thanks for
 the help, I will try and get back to this to flush it out.

 ~ Andrew




Re: Help using Include

2009-06-18 Thread Ittay Dror



Assaf Arkin wrote:

On Wed, Jun 17, 2009 at 4:03 PM, Andrew Moore
andrew.mo...@redprairie.comwrote:

  

Well, I have it working, but not as it seems like it should... I'm
essentially excluding every other kind of file, like this:


package(:war).path('').include(:from=_('../a/b/c')).exclude('**/*.gif').exclude('**/*.jpg').exclude('**/*.css')

I've got about a dozen files I'm excluding, so this isn't a great solution.

I am running version 1.3.3, so maybe there is a bug with that version
related to this that has been fixed in 1.3.4.
After looking more closely, it seems like with the other way:

package(:war).path('').include(:from=_('../a/b/c')).include('**/*.js')




With the exception of merging zips, includes do not compose, so the first
include tells the path to include all the files from a/b/c, and the second
include tells path to include all the .js files in your build.

What's missing is a way to use :from but only for specific patten, something
like:

package(:war).include(**/*.js, :from='a/b/c')

I had to double check that there's no code for that, or an open issue (looks
like such an oversight). So first thing, let's add an issue.
  

isn't this what https://issues.apache.org/jira/browse/BUILDR-186 suggests?

ittay

Assaf


  

I did seem to only get .js files, but I ended up with duplicate copies...
one copy of all the .js files at the root of the war and another in the
directory structure where I expect them to be.

If I get time, I'll try and revisit this and create a test case example...
I'm behind schedule right now, so I'll have to plug on with this. Thanks for
the help, I will try and get back to this to flush it out.

~ Andrew





  




Re: Help using Include

2009-06-18 Thread Assaf Arkin
On Thu, Jun 18, 2009 at 11:12 AM, Ittay Dror ittay.d...@gmail.com wrote:



 Assaf Arkin wrote:

 On Wed, Jun 17, 2009 at 4:03 PM, Andrew Moore
 andrew.mo...@redprairie.comwrote:



 Well, I have it working, but not as it seems like it should... I'm
 essentially excluding every other kind of file, like this:



 package(:war).path('').include(:from=_('../a/b/c')).exclude('**/*.gif').exclude('**/*.jpg').exclude('**/*.css')

 I've got about a dozen files I'm excluding, so this isn't a great
 solution.

 I am running version 1.3.3, so maybe there is a bug with that version
 related to this that has been fixed in 1.3.4.
 After looking more closely, it seems like with the other way:

 package(:war).path('').include(:from=_('../a/b/c')).include('**/*.js')




 With the exception of merging zips, includes do not compose, so the first
 include tells the path to include all the files from a/b/c, and the second
 include tells path to include all the .js files in your build.

 What's missing is a way to use :from but only for specific patten,
 something
 like:

 package(:war).include(**/*.js, :from='a/b/c')

 I had to double check that there's no code for that, or an open issue
 (looks
 like such an oversight). So first thing, let's add an issue.


 isn't this what https://issues.apache.org/jira/browse/BUILDR-186 suggests?


Quite possibly adding this feature will also solve BUILDR-186.

Assaf




 ittay

  Assaf




 I did seem to only get .js files, but I ended up with duplicate copies...
 one copy of all the .js files at the root of the war and another in the
 directory structure where I expect them to be.

 If I get time, I'll try and revisit this and create a test case
 example...
 I'm behind schedule right now, so I'll have to plug on with this. Thanks
 for
 the help, I will try and get back to this to flush it out.

 ~ Andrew