Re: [webkit-dev] Raw string literals

[Maciej Stachowiak via webkit-dev]

> On Nov 17, 2021, at 2:58 PM, Alex Christensen via webkit-dev 
>  wrote:
> 
> Right now, our style checker disapproves of raw string literals, which were 
> introduced in C++11.  It complains with this message:
> 
> Multi-line string ("...") found.  This lint script doesn't do well with such 
> strings, and may give bogus warnings.  They're ugly and unnecessary, and you 
> should use concatenation instead".
> 
> https://webkit.org/code-style-guidelines/ 
>  says nothing on the subject.  I 
> find them quite useful and nice, especially with strings that contain lots of 
> quotation marks that would otherwise need escaping.  Would anyone oppose to 
> my changing our style checker to allow them if I ever get around to it?

Seems like the style checker complains in part because it doesn’t know how to 
properly parse such strings. With that fixed it seems ok to me to use that type 
of string.

 - Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Raw string literals

[Ryosuke Niwa via webkit-dev]

On Wed, Nov 17, 2021 at 2:59 PM Alex Christensen via webkit-dev <
webkit-dev@lists.webkit.org> wrote:

> Right now, our style checker disapproves of raw string literals, which
> were introduced in C++11.  It complains with this message:
>
> Multi-line string ("...") found.  This lint script doesn't do well with
> such strings, and may give bogus warnings.  They're ugly and unnecessary,
> and you should use concatenation instead".
>
> https://webkit.org/code-style-guidelines/ says nothing on the subject.  I
> find them quite useful and nice, especially with strings that contain lots
> of quotation marks that would otherwise need escaping.  Would anyone oppose
> to my changing our style checker to allow them if I ever get around to it?
>

I'm supportive of this proposed change to the style checker. But perhaps
the simplest solution is to just get rid of that rule since it's not
mentioned anywhere in the style guidelines.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Raw string literals

[Alex Christensen via webkit-dev]

Right now, our style checker disapproves of raw string literals, which were 
introduced in C++11.  It complains with this message:

Multi-line string ("...") found.  This lint script doesn't do well with such 
strings, and may give bogus warnings.  They're ugly and unnecessary, and you 
should use concatenation instead".

https://webkit.org/code-style-guidelines/ 
 says nothing on the subject.  I 
find them quite useful and nice, especially with strings that contain lots of 
quotation marks that would otherwise need escaping.  Would anyone oppose to my 
changing our style checker to allow them if I ever get around to it?

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev