Re: [Wikitech-l] Minor API change, ApiUpload
On Tue, Jul 12, 2011 at 11:25 PM, Ian Baker iba...@wikimedia.org wrote: Temporarily stashed files now have their metadata stored in the database instead of the session. This allows for some future feature expansion with regard to the image review and categorization process, and works around a memcached race condition that was preventing simultaneous uploads from working (see bug 26179https://bugzilla.wikimedia.org/show_bug.cgi?id=26179 ) Great work people! I've really been waiting for this, and I'm glad that it has been finally implemented. A remark about extensibility: in the future we might want to use the upload stash for more advanced features like asynchronous uploads and chunked uploads. I think the database schema should already be prepared for this, even if we're not using it. For this purpose I would at least add us_status. Perhaps Michael has some ideas what such a database schema should further incorporate. Cheers, Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92044]: New comment added
User Bryan posted a comment on MediaWiki.r92044. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92044#c19535 Commit summary: Per wikitech-l, run a bunch of URLs in the API output through wfExpandUrl(), so they become fully-qualified even if they were originally protocol-relative Comment: Callers of $title-getFullUrl() should be guaranteed that an absolute url is returned. Protocol relative urls should be returned by a function called $title-getRelativeUrl(). It is imho wrong to let callers of $title-getFullUrl() do the wfExpandUrl, because you are breaking expectations that have been made in the past. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] [Notice] Scheduled network maintenance in ~4 hours
Hi, The Wikimedia Foundation's Operations team will perform network maintenance today around 3pm CEST / 1pm UTC. For more timezones, please see timeanddates.com's full table: http://ur1.ca/4oyyq Disruption should be limited, but you may be unable to access Wikimedia sites for a few minutes. -- Guillaume Paumier ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r92037. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r92037. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19536 Commit summary: output campaign log details Comment: Duplicate keys in message documentation: source lang=php +'centralnotice-multiple-languages' = '$1 is the number of languages in which the notice is available. It is always greater than 3. This message is in the column languages in the table.', +'centralnotice-multiple-languages' = '$1 is the number of countries in which the notice is available.',/source ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92009]: New comment added
User Bryan posted a comment on MediaWiki.r92009.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92009#c19537
Commit summary:
Refactored UploadStash and related classes to use the database for file
metadata storage instead of the session, see bug 26179
Tweaked the UploadWizard to work properly with the new backend code, updated
tests
Comment:
pre
+ public function __construct( $stash = false, $repo = false ) {
+ if( !$this-repo ) {
+ $this-repo = RepoGroup::singleton()-getLocalRepo();
+ }
/pre
This is not what you meant I think. You want if ( $repo ) { $this-repo = $repo
} else { $this-repo = RepoGroup::singleton()-getLocalRepo(); }
pre
public function getFile( $key ) {
+ global $wgUser;
pre
We should avoid new uses of $wgUser. Pass a user object as parameter to
getFile().
pre
+ $lag = $dbr-getLag();
/pre
$dbr is undefined at this point.
pre
+ 'us_timestamp' = wfTimestamp( TS_MW )
/pre
This breaks postgres, use $dbw-timestamp()
pre
+ $dbw = wfGetDB( DB_MASTER );
+ $dbw-insert(
+ 'uploadstash',
+ $this-fileMetadata[$key],
+ __METHOD__
+ );
/pre
The uploadstash table is repobound, so you should use $repo-getMasterDb().
pre
+ $dbw-delete(
+ 'uploadstash',
+ array( 'us_key' = $key, 'us_user' = $userId ),
+ __METHOD__
+ );
/pre
us_key is a UNIQUE INDEX, so you don't need the condition on us_user.
pre
+ while( $row = $dbr-fetchRow( $res ) ) {
+ array_push( $keys, $row['us_key'] );
+ }
/pre
fetchRow returns objects, not arrays iirc. You should not use while {}, but
iterate over $res with foreach.
pre
+ us_media_type varchar(255),
/pre
This is an enum in image, so for consistency this should also be an enum, but
on the other hand enums suck. Hmmm...
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89892]: New comment added
User Siebrand posted a comment on MediaWiki.r89892. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89892#c19538 Commit summary: (bug 20044) Misaligned text on file pages (RTL wikis only) Comment: Adding todo label so someone might some day notice this... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] improving bugzilla patch review: Splinter?
On Tue, Jul 12, 2011 at 8:10 PM, Brion Vibber br...@pobox.com wrote: It's definitely worth trying out! Being current, maintained, and in use on mozilla's mama bugzilla are all good signs; being a fairly clean BZ plugin that uses the BZ API to fetch its data, it _shouldn't_ be too hard to set up either. *mwahahahah* As of April 2011, Splinter accesses Bugzilla data directly so there is no longer a need for use of the webservices API. https://wiki.mozilla.org/BMO/40Upgrade/Alpha So that's even better. Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91519]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r91519.
Old Status: ok
New Status: fixme
User Krinkle also posted a comment on MediaWiki.r91519.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91519#c19539
Commit summary:
(follow-up r91518; bug 29658 et al.) Improving RTL support for several
extensions:
AbuseFilter: aligning rules edit box as LTR, since they are essentially English
CodeReview: aligning commit messages according to content language direction;
and aligning input boxes on SpecialRepoAdmin as LTR
FlaggedRevs: aligning box shown on articles to content language dir; and adding
direction marks to ReviewedPages UnreviewedPages
LiquidThreads:
* add direction mark
* make headings follow the content language dir
* remove lqt_post_ltr/rtl (added a few commits ago) to use mw-content-ltr/rtl
in core
UploadWizard: make calendar input follow user direction (not content direction,
as since r91518) (see bug 28902)
Comment:
This revision causes a line break in all trimmed commit summeries:
http://i.imgur.com/Jq2Wb.png http://i.imgur.com/m8mLi.png
Please use a {{tag|span|open}} if possible, or set display:inline somewhere.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Highlighting diffs on article pages
Hi, I'm working on a wiki-journalism project where it's useful to support a read-state that allows a user to keep up with developments without having to continually skim the whole article or look at markup diffs. I thought a good way to support this would be to allow a period to be selected (e.g. with a slider) and have all content changed over that period highlighted on the article page itself. Does anyone know of an extension or other project that implements this, or if anyone's currently working on it? I've opened a bug as a point of reference: https://bugzilla.wikimedia.org/show_bug.cgi?id=29860 Thanks. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] SVG image display bug (width-dependent)
Consider the following SVG file: http://commons.wikimedia.org/wiki/File:Badminton_court_legal_bounds.svg When rendering this at any width of 160px or above, the renderer renders it correctly, e.g.: http://goo.gl/Onhww (160px thumbnail, upload.wikimedia.org) However, for sizes below 160px, most of the picture is missing in the rendering: http://goo.gl/U6RPs (159px thumbnail) Can this be fixed? Thanks! Timwi ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91997]: New comment added
User Purodha posted a comment on MediaWiki.r91997. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91997#c19540 Commit summary: Amending minor glitches in a message text, seen by Lloffiwr, see http://translatewiki.net/wiki/Thread:Support/Please_don't_change_Centralauth-merge-welcome! Comment: Fixed in revision 92060 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92059]: New comment added
User SPQRobin posted a comment on MediaWiki.r92059. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92059#c19541 Commit summary: [bug 29737] MediaWiki:Qbsettings-directionality should refer to script, not language. Comment: The sentence feels a bit strange now. Maybe make it depending on the script directionality of your language? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92062]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r92062. Old Status: new New Status: ok User DieBuche also posted a comment on MediaWiki.r92062. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92062#c19543 Commit summary: Follow-up r92054: dir attributes are no longer needed (displays it incorrectly when user direction != content direction) Comment: I wanted to ask you whether it was still needed... : ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92062]: New comment added
User SPQRobin posted a comment on MediaWiki.r92062. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92062#c19544 Commit summary: Follow-up r92054: dir attributes are no longer needed (displays it incorrectly when user direction != content direction) Comment: code:-)/code In any case, it was easily observable with uselang=ar (on an LTR wiki). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92059]: Revision status changed
User Siebrand changed the status of MediaWiki.r92059. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92059#c0 Commit summary: [bug 29737] MediaWiki:Qbsettings-directionality should refer to script, not language. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92060]: Revision status changed
User Siebrand changed the status of MediaWiki.r92060. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92060#c0 Commit summary: Fixing double space introduced in r91997 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91997]: Revision status changed
User Siebrand changed the status of MediaWiki.r91997. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91997#c0 Commit summary: Amending minor glitches in a message text, seen by Lloffiwr, see http://translatewiki.net/wiki/Thread:Support/Please_don't_change_Centralauth-merge-welcome! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85876]: New comment added
User Purodha posted a comment on MediaWiki.r85876. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85876#c19545 Commit summary: (bug 13879) Special:Emailuser now asks for suitable target user if called without. Comment: Fixed by not sending $par any more from the input form in r92065 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92059]: New comment added
User Purodha posted a comment on MediaWiki.r92059. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92059#c19546 Commit summary: [bug 29737] MediaWiki:Qbsettings-directionality should refer to script, not language. Comment: No, there may be no script directionality associated with language. Generally, languages may have several (common) scripts having their own directionality each. Examples are mostly Central Asian ones with Latn, Cyrl, or some other being RTL, and Arab being LTR. Not in our current set but upcoming with growing browser support are also scripts running top-to-bottom lines stacked either RTL or LTR, such as some Chinese, Japanese, Mongolian, Korean, etc. Wording should mention language, because that is what users are aware of selecting (while in fact, they select locales on the code level) and correctly mention script, since directionalities are a direct function of scripts. While for one-script languages users may be not aware, users of languages having multiple scripts of differing directioalities would be bewildered finding MediaWiki associating a directionality with their language. I you have a better wording, which is not too long, please go ahead! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92061]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92061. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92061#c0 Commit summary: Followup r92012: Fix grammar, update meintenance scripts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91929]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91929. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91929#c0 Commit summary: followup r91869: validate id chars for incoming prefs tabs in hash ([\w-]+ is sufficient for our needs here) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91996]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91996. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91996#c0 Commit summary: Make the batch size configurable. Default behavior remains the same ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added, and revision status changed
User SPQRobin changed the status of MediaWiki.r91949.
Old Status: ok
New Status: fixme
User SPQRobin also posted a comment on MediaWiki.r91949.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19547
Commit summary:
Revert r91942, r91943 reimplement. wgActions doesn't contain all possible
actions!
Comment:
Stuff like code$action = $wgRequest-getVal( 'action', $par );/code in
special pages like EditWatchlist/raw return the default action ('view'
probably) instead of the $par, which is 'raw' in the case of EditWatchlist.
Another example is the Interwiki extension: Special:Interwiki/add does not
work, but Special:Interwiki?action=add does.
This is probably due to this commit, so marking as FIXME.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User SPQRobin posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19548 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Indeed, it worked until r91941. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Code review training meeting in San Francisco
Hi everyone, Per our earlier list conversations, Wikimedia Foundation employees are going to be spending more time (20% for most engineers) on things like code review, shell requests, and such. As we've discussed what that actually means, it became clear to everyone that many engineers will need training (or at least refreshers) in order to make the most effective use of that time. Additionally, we would benefit from group discussion about what code review is. Since we have a few remote developers visiting us in San Francisco, we're setting up the first training session for this. This will optimized for local participation in San Francisco, but we're going to at least try to get video for purposes of expanding documentation, and perhaps as educational videos for developers who can't be here but prefer to learn that way. This meeting is scheduled for July 19, at 2:30pm PDT. Here's some of the areas we're planning to have short talks on: * The basics * Stability and performance * UI considerations * Security * Unit testing * General code review philosophy This won't be the last time we'll be presenting these things. I imagine we'll be refining these talks for Hackathons and other events. If you aren't an employee of Wikimedia Foundation, but you'll be in SF and you'd like to come, let me know and I'll see if we can accommodate you. If you have ideas for areas that we should cover that aren't listed above, please let us know. Thanks! Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Code review training meeting in San Francisco
2011/7/13 Rob Lanphier ro...@wikimedia.org: This meeting is scheduled for July 19, at 2:30pm PDT. Here's some of the areas we're planning to have short talks on: * The basics * Stability and performance * UI considerations * Security * Unit testing * General code review philosophy This won't be the last time we'll be presenting these things. I imagine we'll be refining these talks for Hackathons and other events. If there's anyone who wants to present a talk or a workshop about such things or to have a meeting about them at the Haifa hackathon, now is a great time to suggest it, as i am building the schedule for it this week. Write about it at http://wikimania2011.wikimedia.org/wiki/Developer_Days Or just email me personally. Thank you. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com We're living in pieces, I want to live in peace. - T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r80402]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r80402. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80402#c0 Commit summary: Modified EditPage to use Article::doEdit() instead of Article::insertNewArticle() and Article::updateArticle(). The redirect to the page is now done in EditPage::attemptSave() instead of being hidden in EditPage::internalAttemptSave(); this change should not affect anyboby, the only other call to internalAttemptSave() is in ApiEditPage.php where it's not used. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92059]: New comment added
User SPQRobin posted a comment on MediaWiki.r92059. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92059#c19549 Commit summary: [bug 29737] MediaWiki:Qbsettings-directionality should refer to script, not language. Comment: I do know what you explained, and how the mediawiki language/scripts work. A language can have multiple scripts, but it's difficult to formulate that in a simple sentence. This setting does not depend on the language at all (but rather on the script), but language is indeed what users are used to selecting in their preferences. I can't think of a better wording than what I proposed, but depending on the directionality of your script ''AND'' your language is a bit wrong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92068]: New comment added
User Conrad.Irwin posted a comment on MediaWiki.r92068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92068#c19550 Commit summary: (bug 15802) An easy way to look up messages: language qqx which returns the message keys (It doesn't show up in preferences, but you can use ?uselang=qqx) Patch by Conrad Irwin (slightly modified) Comment: When I wrote this initially, I used a pipe character — I changed that to a () because it's valid in page names (things are probably less broken with square brackets than pipes, but I imagine they're more broken with square than round brackets). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92069]: New comment added
User Krinkle posted a comment on MediaWiki.r92069. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92069#c19551 Commit summary: jquery.localize: * Added support for message parameters in jquery.localize since I needed that in order to replace $1 with sitename in MoodBar. See: Bug 29868 - Add support for passing parameters to mw.msg in jquery.localize Comment: Since this module doesn't have any unit test suite at all, I'll commit those separately in a minute. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92068]: New comment added
User SPQRobin posted a comment on MediaWiki.r92068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92068#c19552 Commit summary: (bug 15802) An easy way to look up messages: language qqx which returns the message keys (It doesn't show up in preferences, but you can use ?uselang=qqx) Patch by Conrad Irwin (slightly modified) Comment: That was a quick response :) I had to add svn:eol-style:native anyway (r92070), so I changed it to round brackets as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92068]: New comment added
User Conrad.Irwin posted a comment on MediaWiki.r92068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92068#c19553 Commit summary: (bug 15802) An easy way to look up messages: language qqx which returns the message keys (It doesn't show up in preferences, but you can use ?uselang=qqx) Patch by Conrad Irwin (slightly modified) Comment: Awesomesauce — thanks :). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Code review training meeting in San Francisco
Great news Rob! I'm really glad that the WMF is putting more resources into this! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92070]: Revision status changed
User ^demon changed the status of MediaWiki.r92070. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92070#c0 Commit summary: Follow-up r92068: svn:eol-style:native, and use round bracket ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83723]: Revision status changed
User ^demon changed the status of MediaWiki.r83723. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83723#c0 Commit summary: removed addMediaWizard gadget ( should be supported via dedicated extension 'AddMediaWizard' ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83730]: Revision status changed
User ^demon changed the status of MediaWiki.r83730. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83730#c0 Commit summary: follow up to r83723 ( remove the add-media-wizard gadget ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92037]: New comment added
User Kaldari posted a comment on MediaWiki.r92037. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92037#c19554 Commit summary: output campaign log details Comment: fixed in r92073 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92052]: Revision status changed
User ^demon changed the status of MediaWiki.r92052. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92052#c0 Commit summary: Update Tamil schemes using rules from Tamil Wikipedia. Solves bug 29816. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92064]: Revision status changed
User ^demon changed the status of MediaWiki.r92064. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92064#c0 Commit summary: do not cut the definitions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92073]: Revision status changed
User ^demon changed the status of MediaWiki.r92073. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92073#c0 Commit summary: follow up to r92037, fixing redundant qqq message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91998]: Revision status changed
User ^demon changed the status of MediaWiki.r91998. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91998#c0 Commit summary: Making data key names to camelCase to escape from jQuery bug (http://bugs.jquery.com/ticket/9301) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r91949. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c19555 Commit summary: Revert r91942, r91943 reimplement. wgActions doesn't contain all possible actions! Comment: Looks like r3 tried to fix this problem in EditWatchlist (for another case where running on a particular web server config the action was always set), but it was reverted in r34462, I'm guessing due to r3 mistakenly doing an === compare between null and ). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91467]: Revision status changed
User ^demon changed the status of MediaWiki.r91467. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91467#c0 Commit summary: UserOptionStats: display hidden options in a separate list, otherwise the stats of those options are misleading ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91464]: Revision status changed
User ^demon changed the status of MediaWiki.r91464. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91464#c0 Commit summary: Bugfix: Localization wasn't loaded LQT-enabled (inexisting) User_talk-pages. Caused the entire editor to be filled with foobar. This fixes it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r56094]: Revision status changed
User ^demon changed the status of MediaWiki.r56094. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56094#c0 Commit summary: Moved extension over from Google Code (http://mediawiki-page-object-model.googlecode.com/svn/trunk/). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r65073]: Revision status changed
User ^demon changed the status of MediaWiki.r65073. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/65073#c0 Commit summary: Rename to remove Special prefix from filenames. Update Translate and Configure accordingly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r68682]: Revision status changed
User ^demon changed the status of MediaWiki.r68682. Old Status: fixme New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68682#c0 Commit summary: adding in Modernizr for css-transform capabilities check ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r71454]: Revision status changed
User ^demon changed the status of MediaWiki.r71454. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71454#c0 Commit summary: Changes for 0.6.6 - fixed bug in parsing of popup contents ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92078]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92078. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92078#c0 Commit summary: * (bug 29808) Special:PasswordRest now sorts into the 'users' section on Special:Specialpages One-line patch by Rusty Burchfield - https://bugzilla.wikimedia.org/attachment.cgi?id=8771 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r74541]: Revision status changed
User ^demon changed the status of MediaWiki.r74541. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74541#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79686]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r79686. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79686#c0 Commit summary: Wrote jquery.colorUtil plugin. * Introduces rgbToHsl and hslToRgb functions * Introdoces a simple way to get a brigher or darker color * Moved getRGB() function and colors-array from jquery.color to it so they are publically available. * Applied fixed from JSLint to all of this * Made jquery.color use these instead to avoid duplication and added dependency for it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92078]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r92078. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92078#c19556 Commit summary: * (bug 29808) Special:PasswordRest now sorts into the 'users' section on Special:Specialpages One-line patch by Rusty Burchfield - https://bugzilla.wikimedia.org/attachment.cgi?id=8771 Comment: Trivial fix needs merge to 1.18 branch. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75109]: Revision status changed
User ^demon changed the status of MediaWiki.r75109. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75109#c0 Commit summary: Fix bug introduced by r74414 where keys were changed in the i18n file but changes were not reflected in the main code base. Also remove stub function. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r74390]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r74390. Old Status: fixme New Status: resolved User ^demon also posted a comment on MediaWiki.r74390. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74390#c19557 Commit summary: Initial commit of extension. Comment: Agreed, initial issues with the commit were resolved in followups. Ideas for improvement/expansion can go in BZ. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79518]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r79518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79518#c19558 Commit summary: * Modified Article::loadPageData() to use a slave database connection and pageDataFromTitle() instead of pageDataFromId() in the default case, as in Wiki.php (this also saves a query since the ID will be fetched with other fileds) * Removed the loadPageData() call for the initial article in Wiki.php, will be triggered by the isRedirect() call 7 lines below if needed (this was not needed if $target is set by the InitializeArticleMaybeRedirect hook), but kept the second one (same as above, Article::exists() triggers Title::getArticleId() that would use one query to get id and a second one is needed to get the complete page data) * Modified Article::fetchContent() to use common code (loadPageData()) and to only call it if really needed Comment: I'm pretty sure we've gone back and forth on this sort of thing several times over the years... Reading page data from the slave is dangerous as it may be out of date. Reading page data from the master is potentially slow as it slams the master with more activity. In theory what we're supposed to be doing I think is something like 'grab the most basic page/revision row from master' for reliability, followed by being able to load the page text and do rendering existence checks etc etc on the slave. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92077]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92077. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92077#c0 Commit summary: * (bug 29592) WebChat extension iframe width fix: let the width fit the window rather than hardcoding based on screen width Applied patch submitted by Maymond Martineau, with comments removed: https://bugzilla.wikimedia.org/attachment.cgi?id=8708 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83202]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83202.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83202#c0
Commit summary:
Moving IP-check to mw.util some enhancements to and applying code conventions
to mw.special.block.js
* This commit addresses the @TODOs that were in mediawiki.legacy.block before
it was migrated to /resources in r83183 (@TODO: find some better JS file for
[is IP functions])
* JSHint warning fixed: Using when comparing to '' (safer and faster than
==)
* Instead of checking the initial onload state by faking a onkeyup/onchange
event, seperate the two functions and use those
** -- This fixes issue where it falsely triggers other bindings on-load that
are globally bound to input elements via $('input').live() or
$('[type=text]').delegate() because of the .keyup()/.change() call )
* Caching selectors (var $wpBlockExpiry = $(..) etc.) instead of re-creating a
dozen jQuery objects again and getting the document element by id – on *every*
onkeyup/onchange
** -- Notable speed improvement in Safari 3 and IE6 with the caching, these
had a little bit of a lag when typing fast, mw.legacy.block.js had the lag as
well. Fixed now.
* Adding instantToggle-argument to switch between fade or hiding/showing right
away. When setting the initial state they're called with instant=true so that
there's no fading, the page loads and stuff hides that shouldn't be visible.
Any later interaction will still have the fade.
** Calling a function like foo(true) sucks, adding a local DO_INSTANT = true.
* Making behaviour the same as the legacy.block was (if isEmpty, do bring the
element back to view ( show() / fadeIn) instead of doing nothing)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79518]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r79518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79518#c19559 Commit summary: * Modified Article::loadPageData() to use a slave database connection and pageDataFromTitle() instead of pageDataFromId() in the default case, as in Wiki.php (this also saves a query since the ID will be fetched with other fileds) * Removed the loadPageData() call for the initial article in Wiki.php, will be triggered by the isRedirect() call 7 lines below if needed (this was not needed if $target is set by the InitializeArticleMaybeRedirect hook), but kept the second one (same as above, Article::exists() triggers Title::getArticleId() that would use one query to get id and a second one is needed to get the complete page data) * Modified Article::fetchContent() to use common code (loadPageData()) and to only call it if really needed Comment: With chronology protection and the session key having the db position, it normally should be fine to use a slave. I suppose if the slave lag gets really bad (as it does on occasion) you want to fall back to the master. It might be nice to have some kind cache key or something that's set if the lag gets really bad; when the key isn't set, the lag is checked every other X hits. I can't see why we have to use the master for a simple page view. Also, I'd like it if the functions let you choose master or slave. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92084]: Revision status changed
User ^demon changed the status of MediaWiki.r92084. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92084#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-07-13 19:0:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92009]: New comment added
User Raindrift posted a comment on MediaWiki.r92009. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92009#c19560 Commit summary: Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179 Tweaked the UploadWizard to work properly with the new backend code, updated tests Comment: Thanks for the info. I'm now pulling user info from ApiBase::createContext (though if it's truly deprecated, [[Manual:$wgUser]] should probably be updated). I'm still using $wgUser when called from Filerepo::getUploadStash, since Filerepo doesn't seem to be aware of the current user. I went ahead and changed the type of us_media_type for consistency... I figure if it ever changes to a not-enum, it won't be hard to do it in both places. Timestamp generation is corrected (and I'm glad to see the move to a function that might make datetime columns possible someday). However, [[Manual:WfTimestamp]] should probably mention that this is the right way to do things. I'd make the documentation changes myself, but I'm still a bit unsure about what the correct conventions are at this point. Updates are in r92081 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92086]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r92086. Old Status: deferred New Status: fixme User Raymond also posted a comment on MediaWiki.r92086. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92086#c19561 Commit summary: some work on adding KML support to googlemaps v3 Comment: PHP Warning: filemtime(): stat failed for /www/w/extensions/Maps/includes/services/GoogleMaps3/geoxml3/geoxml3.js in /www/w/includes/resourceloader/ResourceLoaderFileModule.php on line 369 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91519]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r91519. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r91519. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91519#c19562 Commit summary: (follow-up r91518; bug 29658 et al.) Improving RTL support for several extensions: AbuseFilter: aligning rules edit box as LTR, since they are essentially English CodeReview: aligning commit messages according to content language direction; and aligning input boxes on SpecialRepoAdmin as LTR FlaggedRevs: aligning box shown on articles to content language dir; and adding direction marks to ReviewedPages UnreviewedPages LiquidThreads: * add direction mark * make headings follow the content language dir * remove lqt_post_ltr/rtl (added a few commits ago) to use mw-content-ltr/rtl in core UploadWizard: make calendar input follow user direction (not content direction, as since r91518) (see bug 28902) Comment: Cool, setting status back to ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92068]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92068#c19563 Commit summary: (bug 15802) An easy way to look up messages: language qqx which returns the message keys (It doesn't show up in preferences, but you can use ?uselang=qqx) Patch by Conrad Irwin (slightly modified) Comment: Add this into dummy language codes or how was that variable called? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92090]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92090. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92090#c19564 Commit summary: removed a bug introduced by me Comment: is_object()? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92094]: Revision status changed
User ^demon changed the status of MediaWiki.r92094. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92094#c0 Commit summary: * Added some tests for FauxResponse class * Made some fixes to that class and removed one unused variable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92093]: Revision status changed
User ^demon changed the status of MediaWiki.r92093. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92093#c0 Commit summary: is_object() ! (thanks Nikerabbit ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92092]: Revision status changed
User ^demon changed the status of MediaWiki.r92092. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92092#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90340]: New comment added
User Krinkle posted a comment on MediaWiki.r90340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90340#c19565 Commit summary: (bug 29408) Key 'something.' is not in a proper format Fixed this by relaxing the stash key regex. For some files MediaWiki is simply not able to guess an extension. If the wiki has been configured to allow them, we should just let them pass in the stash as well. Comment: See also bug 26367. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92086]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r92086. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92086#c19566 Commit summary: some work on adding KML support to googlemaps v3 Comment: Bug in the RL? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92086]: New comment added
User Catrope posted a comment on MediaWiki.r92086. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92086#c19567 Commit summary: some work on adding KML support to googlemaps v3 Comment: Looks like a missing or unreadable file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92086]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r92086. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92086#c19568 Commit summary: some work on adding KML support to googlemaps v3 Comment: It's from an SVN externals. Works fine for me (code in the file is being used successfully to do stuff, so it's definitely getting read). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91908]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r91908. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r91908. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91908#c19569 Commit summary: Add jsparse.php maintenance script to run given JavaScript files through JSMin+'s JS parser for syntax validity checks. This also confirms JSMin+'s fairly abysmal memory usage on large complex files. :) Pass --memory-limit to set to arbitrary values to see where it dies on your file. ;) Comment: Umm, maybeHelp() is an AWESOME API. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92037]: Revision status changed
User Siebrand changed the status of MediaWiki.r92037. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92037#c0 Commit summary: output campaign log details ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81583]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r81583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81583#c19570 Commit summary: Switch editsection to mw:editsection and start hiding these editsection tags from Tidy so it doesn't break them. Comment: What is the empty replaceEditSectionLinksCallback() there for? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Minor API change, ApiUpload
In terms of a db schema friendly to chunks, we would probably want another table and associated it with a stashed file. Russ was discussing adding support for appending files within the swft object store application logic, so we may not have to be concerned with storing chunk references in the db? Another potential usage for a media stash is transcoding non-free formats. Here we could use the media stash as temporary location to put the media files while we transcode them. Once transcoded we could then move them into the published space. But I would not be too worried about incorporating that into the the DB schema until we get to implementation. --michael On 07/13/2011 12:30 AM, Bryan Tong Minh wrote: Great work people! I've really been waiting for this, and I'm glad that it has been finally implemented. A remark about extensibility: in the future we might want to use the upload stash for more advanced features like asynchronous uploads and chunked uploads. I think the database schema should already be prepared for this, even if we're not using it. For this purpose I would at least add us_status. Perhaps Michael has some ideas what such a database schema should further incorporate. Cheers, Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91774]: Revision status changed
User ^demon changed the status of MediaWiki.r91774. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91774#c0 Commit summary: * (bug 27768) Make it possible to restrict use of RSS tags Added URL whitelist to configuration If there are items in the array, and the used URL isn't in the array, it will not be allowed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91775]: Revision status changed
User ^demon changed the status of MediaWiki.r91775. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91775#c0 Commit summary: MFT r91774 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92102]: Revision status changed
User ^demon changed the status of MediaWiki.r92102. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92102#c0 Commit summary: Made flowing iterative, only doing 3 lines at a time, allowing input to be taken more frequently and rendering to be aborted. Also made rendering re-use existing lines. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92108]: Revision status changed
User ^demon changed the status of MediaWiki.r92108. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92108#c0 Commit summary: Pointless w/s tweaks :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91829]: Revision status changed
User DieBuche changed the status of MediaWiki.r91829. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91829#c0 Commit summary: Followup r91750 : Fix LQT call to module. Bug 29795 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92068]: New comment added
User SPQRobin posted a comment on MediaWiki.r92068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92068#c19571 Commit summary: (bug 15802) An easy way to look up messages: language qqx which returns the message keys (It doesn't show up in preferences, but you can use ?uselang=qqx) Patch by Conrad Irwin (slightly modified) Comment: Ah yes, of course :-) Done in r92122 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19572 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Rewrite? Where is the old code? Why isn't this enabled by default? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92118]: New comment added
User Nikerabbit posted a comment on MediaWiki.r92118. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92118#c19573 Commit summary: Fixed profiling error Comment: Spaces :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] SVG image display bug (width-dependent)
That's interesting. Your SVG file seems to be hand-edited, using xlink and entities so the repetitive elements, like the court, are only defined once. It's clever. Your SVG renders fine (directly) in Chrome, Firefox Inkscape for me. However, maybe these entities are screwing things up somehow when converted. I find that I can't convert the file to any other format either, when using ImageMagick (Mac OS X /usr/bin/convert); I get only parts of your drawing, although not the same ones as what we see on Commons. Even InkScape doesn't convert it right, I get overlapping text or worse. Not sure where the bug is. It might be that your SVG code has a bug which makes it subtly difficult to convert, or perhaps you are just using features or SVG that are poorly supported in renderers. On 7/13/11 5:13 AM, Arne 'Timwi' Heizmann wrote: Consider the following SVG file: http://commons.wikimedia.org/wiki/File:Badminton_court_legal_bounds.svg When rendering this at any width of 160px or above, the renderer renders it correctly, e.g.: http://goo.gl/Onhww (160px thumbnail, upload.wikimedia.org) However, for sizes below 160px, most of the picture is missing in the rendering: http://goo.gl/U6RPs (159px thumbnail) Can this be fixed? Thanks! Timwi ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Neil Kandalgaonkar |) ne...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User DieBuche posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19578 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: I opened some bugs: Bug 29880 Bug 29881 Bug 29882 Bug 29883 Bug 29885 Bug 29886 Bug 29887 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User DieBuche posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c19574 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: The old code slumbered in /branches/js2 for 1 1/2 years. Enabled per default: Not yet, there are a few kinks left. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
