Re: [X2Go-Dev] Patch needed for rpm building (unless someone proves me wrong)
On Tue, Feb 7, 2012 at 3:32 PM, Oliver Burger oliver@googlemail.com wrote: Am 07.02.2012 14:52, schrieb Reinhard Tartler: On Tue, Feb 7, 2012 at 2:09 PM, Oliver Burgerobgr_sen...@mageia.org wrote: I wonder why do you require these changes? Don't you use something like fakeroot for package building? that should the INSTALL_OWNER changes unnecessary. Well, I know, that fakeroot is used in deb packaging but not in rpm packaging, and since you don't build as root, it's quite impossible to use those -g and -o options. Just curious, is fakeroot not available *at all* on fedora/mageia systems. In addition, they are not needed at all, the package building process does fix the permission of these files on its own, at least rpmbuild does. That maybe right, but if we go this route, your patch is also unnecessary, because you can also easily directly override the INSTALL_DIR and INSTALL_FILE macros during the makefile invocation/ The SYSCONFDIR/ETCDIR might make sense if you want to install somewhere else than '$(DESTDIR)/etc/x2go'. However, I'm pretty sure that installing those files somewhere else will break x2go in more or less subtle ways as I think those paths are hardcoded at more other places. Therefore, I wonder again what this patch fixes for you. You are partly right there. While rediffing the patch from 3.0.99.9 I did overlook, the $(DESTDIR) was already added. The patch read - mkdir -p /etc/X11/Xresources - mkdir -p /etc/X11/Xsession.d - touch /etc/X11/Xsession.options + mkdir -p $(DESTDIR)$(SYSCONFDIR)/X11/Xresources + mkdir -p $(DESTDIR)$(SYSCONFDIR)/X11/Xsession.d in the previous version. So you are right, this one isn't really needed anymore. But I have to wonder, why a variable $(ETCDIR) is defined instead of hardcoding it, when it will break x2goserver, if the user should define it during build? Your argument there seems to fire backwards. I never claimed the Makefile to be perfect. If we wanted the to make the location /etc/x2go/... really configurable (which I think would be great) then this is mechanism is a great start. Nevertheless, a lot of additional places needs to be fixed, and I see a lot of other way more important things that need fixing first. Therefore, I'd personally recommend to focus on things that really need fixing first. Your proposed patches in this thread seem rather cosmetic to me, because the functionality that you require can be achieved without any patching as well. I'm not saying they are bad or wrong, I'd rather prefer the makefile to be fixed properly instead of making it more complicated. -- regards, Reinhard ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Re: [X2Go-Dev] Patch needed for rpm building (unless someone proves me wrong)
2012/2/11 Reinhard Tartler siret...@gmail.com: On Tue, Feb 7, 2012 at 3:32 PM, Oliver Burger oliver@googlemail.com wrote: Well, I know, that fakeroot is used in deb packaging but not in rpm packaging, and since you don't build as root, it's quite impossible to use those -g and -o options. Just curious, is fakeroot not available *at all* on fedora/mageia systems. Well, I just looked. Actually fakeroot is available, at least on Mageia. I have no Fedora system here right now. But I'm not aware of it normally being used. And I have to ask others about our - and the Fedora - build servers being able to use it or not. About the other things, my patch proposes. of course it is possible to overwrite INSTALL_DIR, INSTALL_FILE and INSTALL_PROGRAMM, actually that didn't come to my mind, but it does make the make line rather long ;) Oliver ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Re: [X2Go-Dev] Packaging nx-libs (aka x2goagent) for your distro
Hi, is this information available on the wiki? Cheers Morty On 2012-02-10 23:23, Mike Gabriel wrote: Please build x2goagent from nx-libs.git. Tarballs are available here: http://code.x2go.org/releases/source/nx-libs the symlink... -- nx-libs aims at being a replacement for nxagent (as being used with FreeNX, for example) whilst also providing our x2goagent. x2goagent is nothing more than a branded nxagent. Originally, Alex f -- Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter) Lehrstuhl für Informatik 4 (Verteilte Systeme und Betriebssysteme) Friedrich-Alexander-Universität Erlangen-Nürnberg Martensstr. 1 91058 Erlangen Tel : +49 9131 85-25419 Fax : +49 9131 85-28732 eMail : stru...@informatik.uni-erlangen.de WWW : http://www4.informatik.uni-erlangen.de/~morty smime.p7s Description: S/MIME Kryptografische Unterschrift ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Re: [X2Go-Dev] Patch needed for rpm building (unless someone proves me wrong)
On Sat, Feb 11, 2012 at 12:03 AM, Reinhard Tartler siret...@gmail.com wrote: Your proposed patches in this thread seem rather cosmetic to me, because the functionality that you require can be achieved without any patching as well. I'm not saying they are bad or wrong, I'd rather prefer the makefile to be fixed properly instead of making it more complicated. Is anyone working on fixing the makefiles in nx-libs (redistributed)? The fixes I made to the nx-libs build system were certainly more than cosmetic, and they work (I've been using them for a month now), but nx-libs is still being distributed with a horribly broken imake build system. I certainly don't claim the fixes I made are perfect, but they do work, and they do install files in their proper places, and that is better than what is currently being distributed. Hence, my question. Is someone working on fixing the nx-libs build files? ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Re: [X2Go-Dev] Patch needed for rpm building (unless someone proves me wrong)
Hello John, Your proposed patches in this thread seem rather cosmetic to me, because the functionality that you require can be achieved without any patching as well. I'm not saying they are bad or wrong, I'd rather prefer the makefile to be fixed properly instead of making it more complicated. Is anyone working on fixing the makefiles in nx-libs (redistributed)? The fixes I made to the nx-libs build system were certainly more than cosmetic, and they work (I've been using them for a month now), but nx-libs is still being distributed with a horribly broken imake build system. I certainly don't claim the fixes I made are perfect, but they do work, and they do install files in their proper places, and that is better than what is currently being distributed. Hence, my question. Is someone working on fixing the nx-libs build files? we are currently in the process of making this job, yes. We have substantially made a lot of work for RPMS and general build environments to accomodate the standards in distributions other than debian/ubuntu. Please stay tuned just for some days. I will make a larger announcement on this topic to this list as soon as we got the work done. - mike ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Re: [X2Go-Dev] Packaging nx-libs (aka x2goagent) for your distro
V Fri, 10 Feb 2012 23:23:16 +0100 Mike Gabriel mike.gabr...@das-netzwerkteam.de napsáno: Hi Oliver, Milan, Please build x2goagent from nx-libs.git. Tarballs are available here: http://code.x2go.org/releases/source/nx-libs Hello Mike, what is the status with make install for the packages included in nx-libs (i.e. nxcomp, nxcompext, nxcompshad, nxproxy, nxagent, 2goagent)? Unless I am doing something wrong, fakeroot make DESTDIR=/some/path install leads to installation of the libsbinaries to usr/X11R6 and not all components required for x2goagent (incl. x2goagent wrapper itself) are installed anyway. To work around that, I am using install command for all the libs and binaries with the use of the precompiled DEB packages as a template. A second point: in Arch linux, the X2Go packages (incl. nx-libs) are in AUR (user-contributed repository), which does not support so called split packages (i.e. I cannot compile the nx-libs tar ball and create several packages in one go like you do in Debian) [1]. So at the moment, the semi-automatic build process has to download and compile major part of nx-libs repeatedly for each of the dependency (nxcomp: requires nx-x11; nxagent: requires nx-x11, nxcomp, nxcompext, ..., nx-x11; etc...). It works, nonetheless it is slow and inefficient. How difficult would it be to have the Makefiles modified to search for the dependency in the system (/usr/lib/nx/X11...) instead in the source tree? [1] It actually is possible to create split packages with a little hack, but then it is not possible to automatically install the split packages as dependencies of others - AUR (and tools supporting automated compilation installation from AUR like yaourt) cannot search in the list of split packages. Regards, Milan -- http://www.milan-knizek.net/ About linux and photography (Czech only) O linuxu a fotografování signature.asc Description: PGP signature ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
Re: [X2Go-Dev] Packaging nx-libs (aka x2goagent) for your distro
On Sat, Feb 11, 2012 at 11:56 AM, Milan Knížek knizek.co...@gmail.com wrote: what is the status with make install for the packages included in nx-libs (i.e. nxcomp, nxcompext, nxcompshad, nxproxy, nxagent, 2goagent)? Unless I am doing something wrong, fakeroot make DESTDIR=/some/path install leads to installation of the libsbinaries to usr/X11R6 and not all components required for x2goagent (incl. x2goagent wrapper itself) are installed anyway. To work around that, I am using install command for all the libs and binaries with the use of the precompiled DEB packages as a template. A second point: in Arch linux, the X2Go packages (incl. nx-libs) are in AUR (user-contributed repository), which does not support so called split packages (i.e. I cannot compile the nx-libs tar ball and create several packages in one go like you do in Debian) [1]. So at the moment, the semi-automatic build process has to download and compile major part of nx-libs repeatedly for each of the dependency (nxcomp: requires nx-x11; nxagent: requires nx-x11, nxcomp, nxcompext, ..., nx-x11; etc...). It works, nonetheless it is slow and inefficient. Yes, the makefile currently distributed with nx-libs (redistributed) is broken as you say. It sounds like someone is working on it (see post from Michael Kromer). As for the recompilation difficulty, I made an Archlinux package that installs everything from the nx-libs tarball at once, rather than splitting it into a lot of separate packages. ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
[X2Go-Dev] nx-libs and Xinerama, wrong library location
Hi Alex, I have fixed the installation path of libXinerama with latest nx-libs (heuler). Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb pgp0cmY0hdieC.pgp Description: Digitale PGP-Unterschrift ___ X2Go-Dev mailing list X2Go-Dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/x2go-dev
