Re: [RFC] Support firecracker

2019-01-05 Thread Pekka Enberg
On Sat, Jan 5, 2019 at 9:58 AM Pekka Enberg wrote: > > > On Sat, Jan 5, 2019 at 9:43 AM Waldek Kozaczuk > wrote: > >> Indeed I have come across some incompatibility issues. Mostly around >> configuration but nothing very fundamental. You can see in some of my >>

Re: [RFC] Support firecracker

2019-01-04 Thread Pekka Enberg
On Sat, Jan 5, 2019 at 9:43 AM Waldek Kozaczuk wrote: > Indeed I have come across some incompatibility issues. Mostly around > configuration but nothing very fundamental. You can see in some of my > comments. > Right, I missed the comments because the diff is somewhat large. ;-) I would

Re: OSv boots on AWS firecracker in 7ms (seven)

2019-01-04 Thread Pekka Enberg
On Sat, Jan 5, 2019 at 9:04 AM Waldek Kozaczuk wrote: > And one more thing I forgot to mention. I do not know much about ARM > architecture but I think the patch I have just sent may help us provide > virtio implementation for ARM as well, no? > I think ARM64 also supports virtio-pci these

Re: [RFC] Support firecracker

2019-01-04 Thread Pekka Enberg
Hi Waldek, On Sat, Jan 5, 2019 at 8:47 AM Waldek Kozaczuk wrote: > Please bear in mind it is a RFC polluted with hacks and many TODO comments > that raise many questions. > > Feel free to review it especially if you have ideas on how to better > restructure the code (I left some comments about

Re: [PATCH] mm/slub.c: freelist is ensured to be NULL when new_slab() fails

2018-12-29 Thread Pekka Enberg
On 29/12/2018 8.25, Peng Wang wrote: new_slab_objects() will return immediately if freelist is not NULL. if (freelist) return freelist; One more assignment operation could be avoided. Signed-off-by: Peng Wang Reviewed-by: Pekka Enberg --- mm/slub.c | 3

Re: How to test the schedule latency?

2018-10-11 Thread Pekka Enberg
On Thu, Oct 11, 2018 at 12:22 PM Avi Kivity wrote: > > On 11/10/2018 12.14, Nadav Har'El wrote: > > On Thu, Oct 11, 2018 at 12:10 PM Pekka Enberg > wrote: > >> >> >> On Thu, Oct 11, 2018 at 11:50 AM Nadav Har'El wrote: >> >>> >>> test

Re: How to test the schedule latency?

2018-10-11 Thread Pekka Enberg
On Thu, Oct 11, 2018 at 12:14 PM Nadav Har'El wrote: > On Thu, Oct 11, 2018 at 12:10 PM Pekka Enberg > wrote: > >> >> >> On Thu, Oct 11, 2018 at 11:50 AM Nadav Har'El wrote: >> >>> >>> tests/misc-ctxsw.cc >>> >>> To run i

Re: How to test the schedule latency?

2018-10-11 Thread Pekka Enberg
On Thu, Oct 11, 2018 at 11:50 AM Nadav Har'El wrote: > > On Thu, Oct 11, 2018 at 10:45 AM Qixuan Wu wrote: > >> Hi All, >> >> I saw the paper, it said schedule latency is less than linux thread, >> about 328ns. >> >> Guest OS >> >> Colocated >> >> Apart >> >> Linux >> >> 905 ns >> >> 13148 ns

Re: gvisor - google user-space kernel in go

2018-09-20 Thread Pekka Enberg
Hi Nadav, On Thu, Sep 20, 2018 at 11:03 AM, Nadav Har'El wrote: > I think Qixuan may be referring to the fact that OSv today can only run > position-independent executables (shared objects and PIE), and nor > "regular" position-dependent executables, > which causes us in many applications in

Re: gvisor - google user-space kernel in go

2018-09-20 Thread Pekka Enberg
On Thu, Sep 20, 2018 at 9:29 AM, Qixuan Wu wrote: > > > 在 2018年9月19日星期三 UTC+8下午9:25:15,Pekka Enberg写道: >> >> >> >> On Wed, Sep 19, 2018 at 4:18 AM, Qixuan Wu wrote: >> >>> >>>- claim to run unmodified Linux executable like

Re: gvisor - google user-space kernel in go

2018-09-19 Thread Pekka Enberg
On Wed, Sep 19, 2018 at 4:18 AM, Qixuan Wu wrote: > >- claim to run unmodified Linux executable like OSv does > > gVisor can run the C application without recompiling, but application only > can run on OSv with recompiling. > OSv is quite capable of running unmodified Linux executables, as

Re: Running OSv on kvmtool

2018-04-11 Thread Pekka Enberg
Hi, On Wed, Apr 11, 2018 at 6:08 PM, Waldek Kozaczuk wrote: > Do you know if kvmtool supports multiboot? If so which version? > It does not support Multiboot at all. The main problem with booting OSv is indeed the loading part. kvmtool on x86 only supports Linux bzImage.

Re: [PATCH] mm, slab: reschedule cache_reap() on the same CPU

2018-04-11 Thread Pekka Enberg
t;workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs") CC: <sta...@vger.kernel.org> Cc: Joonsoo Kim <iamjoonsoo@lge.com> Cc: David Rientjes <rient...@google.com> Cc: Pekka Enberg <penb...@kernel.org> Cc: Christoph Lameter <c...@linux.com> Cc:

Re: [PATCH] mm, slab: reschedule cache_reap() on the same CPU

2018-04-11 Thread Pekka Enberg
ORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs") CC: Cc: Joonsoo Kim Cc: David Rientjes Cc: Pekka Enberg Cc: Christoph Lameter Cc: Tejun Heo Cc: Lai Jiangshan Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Acked-by: Pekka Enberg --- mm/slab.c | 3 ++- 1 file changed

Re: [Qemu-devel] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Pekka Enberg
Hi, On 02/15/2018 02:39 PM, Peter Maydell wrote: On 8 February 2018 at 05:50, Pekka Enberg <penb...@iki.fi> wrote: This patch adds a "raspi3" machine type, which can now be selected as the machine to run on by users via the "-M" command line option to QEMU. The mach

Re: [Qemu-devel] [PATCH v1 1/3] bcm2836: Make CPU type configurable

2018-02-15 Thread Pekka Enberg
On 02/15/2018 01:48 PM, Peter Maydell wrote: On 8 February 2018 at 05:50, Pekka Enberg <penb...@iki.fi> wrote: This patch adds a "cpu-type" property to BCM2836 SoC in preparation for reusing the code for the Raspberry Pi 3, which has a different processor model. Signed-off-

[Qemu-devel] [PATCH v2 2/3] raspi: Raspberry Pi 3 support

2018-02-15 Thread Pekka Enberg
from scratch by me but the logic is similar to Zoltán Baldaszti's previous work, which I used as a reference (with permission from the author): https://github.com/bztsrc/qemu-raspi3 Signed-off-by: Pekka Enberg <penb...@iki.fi> --- hw/arm/raspi.c | 31 +-- 1 file c

[Qemu-devel] [PATCH v2 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Pekka Enberg
e run something more complicated than what I'm using for testing. Signed-off-by: Pekka Enberg <penb...@iki.fi> --- hw/arm/raspi.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 66fe10e376..ff54f45e3e 100644 --- a/hw/arm/raspi.c +++

[Qemu-devel] [PATCH v2 1/3] bcm2836: Make CPU type configurable

2018-02-15 Thread Pekka Enberg
This patch adds a "cpu-type" property to BCM2836 SoC in preparation for reusing the code for the Raspberry Pi 3, which has a different processor model. Signed-off-by: Pekka Enberg <penb...@iki.fi> --- hw/arm/bcm2836.c | 17 + hw/arm/raspi.c | 3

[Qemu-devel] [PATCH v2 0/3] Raspberry Pi 3 support

2018-02-15 Thread Pekka Enberg
pberry Pi 3 machine definition with TARGET_AARCH64 (Peter Maydell) Pekka Enberg (3): bcm2836: Make CPU type configurable raspi: Raspberry Pi 3 support raspi: Add "raspi3" machine type hw/arm/bcm2836.c | 17 --- hw/arm/raspi.c | 57

[Qemu-devel] [PATCH v1 2/3] raspi: Raspberry Pi 3 support

2018-02-07 Thread Pekka Enberg
from scratch by me but the logic is similar to Zoltán Baldaszti's previous work, which I used as a reference (with permission from the author): https://github.com/bztsrc/qemu-raspi3 Signed-off-by: Pekka Enberg <penb...@iki.fi> --- hw/arm/raspi.c | 31 +-- 1 file c

[Qemu-devel] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-07 Thread Pekka Enberg
e run something more complicated than what I'm using for testing. Signed-off-by: Pekka Enberg <penb...@iki.fi> --- hw/arm/raspi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 66fe10e376..048ff23a51 100644 --- a/hw/arm/raspi.c +++

[Qemu-devel] [PATCH v1 0/3] Raspberry Pi 3 support

2018-02-07 Thread Pekka Enberg
ision is 0xa02082 The patches were written by me but I used Zoltán Baldaszti's previous work as a reference (with permission from the author): https://github.com/bztsrc/qemu-raspi3 Also available from: g...@github.com:penberg/qemu.git raspi3/v1 Pekka Enberg (3): bcm2836: Make

Re: [PATCH 1/2] slab, slub, slob: add slab_flags_t

2017-10-22 Thread Pekka Enberg
On 21/10/2017 13.02, Alexey Dobriyan wrote: Add sparse-checked slab_flags_t for struct kmem_cache::flags (SLAB_POISON, etc). SLAB is bloated temporarily by switching to "unsigned long", but only temporarily. Signed-off-by: Alexey Dobriyan <adobri...@gmail.com> Acked-by: Pe

Re: [PATCH 2/2] slab, slub, slob: convert slab_flags_t to 32-bit

2017-10-22 Thread Pekka Enberg
by: Alexey Dobriyan <adobri...@gmail.com> Acked-by: Pekka Enberg <penb...@kernel.org>

Re: [COMMIT osv master] update apps submodule

2017-07-10 Thread Pekka Enberg
On Fri, Jul 7, 2017 at 1:08 AM, Commit Bot wrote: > From: Nadav Har'El > Committer: Nadav Har'El > Branch: master > > update apps submodule > > Signed-off-by: Nadav Har'El Nadav, it's nice to have "git

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Pekka Enberg
Hi, On 02/02/2017 19.48, Ard Biesheuvel wrote: $ git grep -C5 -ni 0x1DE7EC7EDBADC0DE arch/arm64/kvm/sys_regs.h-105-static inline void reset_unknown(struct kvm_vcpu *vcpu, arch/arm64/kvm/sys_regs.h-106- const struct sys_reg_desc *r) arch/arm64/kvm/sys_regs.h-107-{

[Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Pekka Enberg
Hi, Has anyone been able to successfully run QEMU/KVM under Raspberry Pi 3? I have installed 64-bit Fedora 24 by Gerd Hoffmann on the hardware: https://www.kraxel.org/blog/2016/04/fedora-on-raspberry-pi-updates/ and built a VM image using virt-builder: virt-builder --root-password

Re: [PATCH] loader: do not kill httpserver prematurely

2016-12-27 Thread Pekka Enberg
On Mon, Dec 26, 2016 at 12:04 AM, Nadav Har'El wrote: > Commit e270cf9c (more than two years ago) was well-intentioned, but > introduced a new bug: we no longer wait for the background programs > to finish before stopping httpserver. So for example if the command > line is

Re: [PATCH] virtio-rng: don't hang while waiting for entropy

2016-11-17 Thread Pekka Enberg
rces, and doesn't want to wait for this specific source! > > So virtio-rng's read function shouldn't wait for random bytes, it should > just provide whatever bytes it has right now. > > Fixes #805 > > Signed-off-by: Nadav Har'El <n...@scylladb.com> The virtio-rng part lo

Re: [COMMIT osv master] Update apps/ submodule

2016-09-14 Thread Pekka Enberg
On Wed, Sep 14, 2016 at 9:05 AM, Commit Bot wrote: > From: Nadav Har'El > Committer: Nadav Har'El > Branch: master > > Update apps/ submodule > > Signed-off-by: Nadav Har'El > > --- > diff --git a/apps

Re: [PATCH] drivers/vmxnet3: Fix driver state issues

2016-08-31 Thread Pekka Enberg
On Wed, Aug 31, 2016 at 6:13 PM, Timmons C. Player wrote: > This commit fixes two observed issues with the vmxnet3 driver: > > * Handle both missing SOP and EOP descriptors in the rx loop. ESXi > drops descriptors under load. > * Always leave at least one Tx

Re: [PATCH 0/4] zswap: Optimize compressed pool memory utilization

2016-08-17 Thread Pekka Enberg
On Wed, Aug 17, 2016 at 1:03 PM, Srividya Desireddy wrote: > This series of patches optimize the memory utilized by zswap for storing > the swapped out pages. > > Zswap is a cache which compresses the pages that are being swapped out > and stores them into a dynamically

Re: [PATCH 0/4] zswap: Optimize compressed pool memory utilization

2016-08-17 Thread Pekka Enberg
On Wed, Aug 17, 2016 at 1:03 PM, Srividya Desireddy wrote: > This series of patches optimize the memory utilized by zswap for storing > the swapped out pages. > > Zswap is a cache which compresses the pages that are being swapped out > and stores them into a dynamically allocated RAM-based memory

Re: [PATCH 3/4] zswap: Zero-filled pages handling

2016-08-17 Thread Pekka Enberg
overhead caused due to zero-filled page check is very minimal >> when compared to the time saved by avoiding compression and allocation in >> case of zero-filled pages. The load time of a zero-filled page is reduced >> by 80% when compared to baseline. On Wed, Aug 17, 2016 at 3:25

Re: [PATCH 3/4] zswap: Zero-filled pages handling

2016-08-17 Thread Pekka Enberg
lled page check is very minimal >> when compared to the time saved by avoiding compression and allocation in >> case of zero-filled pages. The load time of a zero-filled page is reduced >> by 80% when compared to baseline. On Wed, Aug 17, 2016 at 3:25 PM, Pekka Enberg wrot

Re: [PATCH 3/4] zswap: Zero-filled pages handling

2016-08-17 Thread Pekka Enberg
On Wed, Aug 17, 2016 at 1:18 PM, Srividya Desireddy wrote: > This patch adds a check in zswap_frontswap_store() to identify zero-filled > page before compression of the page. If the page is a zero-filled page, set > zswap_entry.zeroflag and skip the compression of the

Re: [PATCH 3/4] zswap: Zero-filled pages handling

2016-08-17 Thread Pekka Enberg
On Wed, Aug 17, 2016 at 1:18 PM, Srividya Desireddy wrote: > This patch adds a check in zswap_frontswap_store() to identify zero-filled > page before compression of the page. If the page is a zero-filled page, set > zswap_entry.zeroflag and skip the compression of the page and alloction > of

Re: [PATCH] Remove deprecated "mgmt" submodule

2016-07-11 Thread Pekka Enberg
On Thu, Jun 30, 2016 at 2:29 PM, Nadav Har'El wrote: > Pekka or Avi, can I please have your opinion on this patch? > > Is it ok with you that we drop the old "mgmt" shell, and stop building > images for it? I am certainly fine with that. -- You received this message because

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread Pekka Enberg
On 01/22/2016 01:12 AM, David Rientjes wrote: NACK to your patch as it is just covering up buggy code silently. The problem needs to be addressed in change_memory_common() to return if there is no size to change (numpages == 0). It's a two line fix to that function. So add a WARN_ON there

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

2016-01-21 Thread Pekka Enberg
On 01/22/2016 01:12 AM, David Rientjes wrote: NACK to your patch as it is just covering up buggy code silently. The problem needs to be addressed in change_memory_common() to return if there is no size to change (numpages == 0). It's a two line fix to that function. So add a WARN_ON there

Re: [PATCH 0/3] kvmtool: tiny init fox x86_64

2015-10-22 Thread Pekka Enberg
, but this is minor. I want to write my /virt/init in shell or perl and this change can help. I don't really know who should be cc'ed, I've picked some names from git-log guest/init.c. Will maintains the standalone kvmtool.git tree. The series looks good to me: Acked-by: Pekka Enberg <p

Re: [PATCH] mm: slab: convert slab_is_available to boolean

2015-09-15 Thread Pekka Enberg
On 9/15/15 8:50 PM, Denis Kirjanov wrote: A good one candidate to return a boolean result Signed-off-by: Denis Kirjanov Reviewed-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] mm: slab: convert slab_is_available to boolean

2015-09-15 Thread Pekka Enberg
On 9/15/15 8:50 PM, Denis Kirjanov wrote: A good one candidate to return a boolean result Signed-off-by: Denis Kirjanov <k...@linux-powerpc.org> Reviewed-by: Pekka Enberg <penb...@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH 04/14] cxgb4: Use kvfree() in t4_free_mem()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Hariprasad S Signed-off-by: Pekka Enberg --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4

[PATCH 07/14] drm/nouveau/gem: Use kvfree() in u_free()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: David Airlie Signed-off-by: Pekka Enberg --- drivers/gpu/drm/nouveau/nouveau_gem.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 0e690bf

[PATCH 03/14] cxgb3: Use kvfree() in cxgb_free_mem()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Santosh Raspatur Signed-off-by: Pekka Enberg --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet

[PATCH 09/14] IB/ehca: Use kvfree() in ipz_queue_{cd}tor()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Hoang-Nam Nguyen Cc: Christoph Raisch Signed-off-by: Pekka Enberg --- drivers/infiniband/hw/ehca/ipz_pt_fn.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/ehca/ipz_pt_fn.c b/drivers/infiniband

[PATCH 08/14] drivers/input/evdev.c: Use kvfree() in evdev_release()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Dmitry Torokhov Signed-off-by: Pekka Enberg --- drivers/input/evdev.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index a18f41b..9d35499 100644 --- a/drivers/input/evdev.c

[PATCH 01/14] ipc/util.c: Use kvfree() in ipc_rcu_free()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg --- ipc/util.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ipc/util.c b/ipc/util.c index ff3323e..537a41c 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -467,10 +467,7 @@ void ipc_rcu_free(struct

[PATCH 10/14] target: Use kvfree() in session alloc and free

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: "Nicholas A. Bellinger" Signed-off-by: Pekka Enberg --- drivers/target/target_core_transport.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/target/target_core_transport.c b/driv

[PATCH 12/14] dm: Use kvfree() in dm_kvfree()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Alasdair Kergon Cc: Mike Snitzer Signed-off-by: Pekka Enberg --- drivers/md/dm-stats.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/dm-stats.c b/drivers/md/dm-stats.c index f478a4c..492fe6a 100644 --- a/drivers

[PATCH 11/14] libcxgbi: Use kvfree() in cxgbi_free_big_mem()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: "James E.J. Bottomley" Signed-off-by: Pekka Enberg --- drivers/scsi/cxgbi/libcxgbi.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.h b/drivers/scsi/cxgbi/libcxgbi.h index aba1af7..c2eb

[PATCH 13/14] bcache: Use kvfree() in various places

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Kent Overstreet Signed-off-by: Pekka Enberg --- drivers/md/bcache/super.c | 10 ++ drivers/md/bcache/util.h | 10 ++ 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache

[PATCH 14/14] NTFS: Use kvfree() in ntfs_free()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Anton Altaparmakov Signed-off-by: Pekka Enberg --- fs/ntfs/malloc.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ntfs/malloc.h b/fs/ntfs/malloc.h index a44b14c..ab172e5 100644 --- a/fs/ntfs/malloc.h +++ b/fs/ntfs

[PATCH 06/14] drm: Use kvfree() in drm_free_large()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: David Airlie Signed-off-by: Pekka Enberg --- include/drm/drm_mem_util.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/drm/drm_mem_util.h b/include/drm/drm_mem_util.h index 19a2404..e42495a 100644 --- a/include/drm

[PATCH 02/14] kernel/relay.c: Use kvfree() in relay_free_page_array()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg --- kernel/relay.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/relay.c b/kernel/relay.c index e9dbaeb..0b4570c 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -81,10 +81,7 @@ static struct

[PATCH 05/14] ceph: Use kvfree() in ceph_put_page_vector()

2015-05-15 Thread Pekka Enberg
Use kvfree instead of open-coding it. Cc: "Yan, Zheng" Cc: Sage Weil Signed-off-by: Pekka Enberg --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 096d914..d4f5f22 100644 --- a/net/ceph/pagev

[PATCH 06/14] drm: Use kvfree() in drm_free_large()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: David Airlie airl...@linux.ie Signed-off-by: Pekka Enberg penb...@kernel.org --- include/drm/drm_mem_util.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/drm/drm_mem_util.h b/include/drm/drm_mem_util.h index 19a2404

[PATCH 12/14] dm: Use kvfree() in dm_kvfree()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Alasdair Kergon a...@redhat.com Cc: Mike Snitzer snit...@redhat.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/md/dm-stats.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/dm-stats.c b/drivers/md/dm

[PATCH 03/14] cxgb3: Use kvfree() in cxgb_free_mem()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Santosh Raspatur sant...@chelsio.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3

[PATCH 09/14] IB/ehca: Use kvfree() in ipz_queue_{cd}tor()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Hoang-Nam Nguyen hngu...@de.ibm.com Cc: Christoph Raisch rai...@de.ibm.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/infiniband/hw/ehca/ipz_pt_fn.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 08/14] drivers/input/evdev.c: Use kvfree() in evdev_release()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/input/evdev.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index a18f41b

[PATCH 01/14] ipc/util.c: Use kvfree() in ipc_rcu_free()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg penb...@kernel.org --- ipc/util.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ipc/util.c b/ipc/util.c index ff3323e..537a41c 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -467,10 +467,7 @@ void

[PATCH 02/14] kernel/relay.c: Use kvfree() in relay_free_page_array()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg penb...@kernel.org --- kernel/relay.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/relay.c b/kernel/relay.c index e9dbaeb..0b4570c 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -81,10

[PATCH 05/14] ceph: Use kvfree() in ceph_put_page_vector()

2015-05-15 Thread Pekka Enberg
Use kvfree instead of open-coding it. Cc: Yan, Zheng z...@redhat.com Cc: Sage Weil s...@redhat.com Signed-off-by: Pekka Enberg penb...@kernel.org --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 096d914

[PATCH 11/14] libcxgbi: Use kvfree() in cxgbi_free_big_mem()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: James E.J. Bottomley jbottom...@odin.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/scsi/cxgbi/libcxgbi.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.h b/drivers/scsi/cxgbi

[PATCH 13/14] bcache: Use kvfree() in various places

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Kent Overstreet k...@daterainc.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/md/bcache/super.c | 10 ++ drivers/md/bcache/util.h | 10 ++ 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/md

[PATCH 14/14] NTFS: Use kvfree() in ntfs_free()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Anton Altaparmakov an...@tuxera.com Signed-off-by: Pekka Enberg penb...@kernel.org --- fs/ntfs/malloc.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ntfs/malloc.h b/fs/ntfs/malloc.h index a44b14c..ab172e5 100644 --- a/fs

[PATCH 07/14] drm/nouveau/gem: Use kvfree() in u_free()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: David Airlie airl...@linux.ie Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/gpu/drm/nouveau/nouveau_gem.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm

[PATCH 04/14] cxgb4: Use kvfree() in t4_free_mem()

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Hariprasad S haripra...@chelsio.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4

[PATCH 10/14] target: Use kvfree() in session alloc and free

2015-05-15 Thread Pekka Enberg
Use kvfree() instead of open-coding it. Cc: Nicholas A. Bellinger n...@linux-iscsi.org Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/target/target_core_transport.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/target/target_core_transport.c

Re: [PATCH v2] perf kmem: Show warning when trying to run stat without record

2015-05-05 Thread Pekka Enberg
below to inform user: # perf kmem stat --page --caller Not found page events. Have you run 'perf kmem record --page' before? Acked-by: Pekka Enberg Signed-off-by: Namhyung Kim Thanks, applied. I just found the messages a bit odd souding, perhaps: # perf kmem stat --page --caller

Re: [PATCH v2] perf kmem: Show warning when trying to run stat without record

2015-05-05 Thread Pekka Enberg
below to inform user: # perf kmem stat --page --caller Not found page events. Have you run 'perf kmem record --page' before? Acked-by: Pekka Enberg penb...@kernel.org Signed-off-by: Namhyung Kim namhy...@kernel.org Thanks, applied. I just found the messages a bit odd souding, perhaps

Re: [PATCH 0/13] Parallel struct page initialisation v4

2015-04-28 Thread Pekka Enberg
16] kswapd 2 initialised deferred memory in 1148ms > > Once booted the machine appears to work as normal. Boot times were measured > from the time shutdown was called until ssh was available again. In the > 64G case, the boot time savings are negligible. On the 1TB machine, the &g

Re: [PATCH 0/13] Parallel struct page initialisation v4

2015-04-28 Thread Pekka Enberg
the machine appears to work as normal. Boot times were measured from the time shutdown was called until ssh was available again. In the 64G case, the boot time savings are negligible. On the 1TB machine, the savings were 16 seconds. FWIW, Acked-by: Pekka Enberg penb...@kernel.org for the whole series

Re: [PATCHSET 0/6] perf kmem: Implement page allocation analysis (v7)

2015-04-13 Thread Pekka Enberg
it does slab allocation analysis for backward compatibility. Nice addition! Acked-by: Pekka Enberg for the whole series. - Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCHSET 0/6] perf kmem: Implement page allocation analysis (v7)

2015-04-13 Thread Pekka Enberg
, it does slab allocation analysis for backward compatibility. Nice addition! Acked-by: Pekka Enberg penb...@kernel.org for the whole series. - Pekka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v6 2/4] perf tools: add Java demangling support

2015-03-31 Thread Pekka Enberg
Hi Stephane, On Tue, Mar 31, 2015 at 1:19 AM, Stephane Eranian wrote: > +#define BASE_ENT(c, n) [c-'A']=n > +static const char *base_types['Z'-'A' + 1]={ > + BASE_ENT('B', "byte" ), > + BASE_ENT('C', "char" ), > + BASE_ENT('D', "double" ), > + BASE_ENT('F', "float" ), > +

Re: [PATCH v6 2/4] perf tools: add Java demangling support

2015-03-31 Thread Pekka Enberg
Hi Stephane, On Tue, Mar 31, 2015 at 1:19 AM, Stephane Eranian eran...@google.com wrote: +#define BASE_ENT(c, n) [c-'A']=n +static const char *base_types['Z'-'A' + 1]={ + BASE_ENT('B', byte ), + BASE_ENT('C', char ), + BASE_ENT('D', double ), + BASE_ENT('F', float ),

Re: [PATCH] mm: kill kmemcheck

2015-03-12 Thread Pekka Enberg
Hi Sasha, On 3/11/15 1:43 PM, Sasha Levin wrote: As discussed on LSF/MM, kill kmemcheck. KASan is a replacement that is able to work without the limitation of kmemcheck (single CPU, slow). KASan is already upstream. We are also not aware of any users of kmemcheck (or users who don't consider

Re: stand-alone kvmtool

2015-03-01 Thread Pekka Enberg
On 2/26/15 1:02 PM, Alex Bennée wrote: If you can have it all it would be nice to preserve buildability all through your history for bisecting (and the moon on a stick please ;-) Is the dependency on the kernel sources something that has been stable over the projects history or something that's

Re: stand-alone kvmtool

2015-03-01 Thread Pekka Enberg
On 2/26/15 1:02 PM, Alex Bennée wrote: If you can have it all it would be nice to preserve buildability all through your history for bisecting (and the moon on a stick please ;-) Is the dependency on the kernel sources something that has been stable over the projects history or something that's

Re: stand-alone kvmtool

2015-03-01 Thread Pekka Enberg
On 2/26/15 1:02 PM, Alex Bennée wrote: If you can have it all it would be nice to preserve buildability all through your history for bisecting (and the moon on a stick please ;-) Is the dependency on the kernel sources something that has been stable over the projects history or something that's

Re: stand-alone kvmtool

2015-02-23 Thread Pekka Enberg
Hi, On 2/18/15 5:50 PM, Will Deacon wrote: Thanks for doing this. Since it looks unlikely that kvmtool will ever be merged back into the kernel tree, it makes sense to cut the dependency in my opinion. I am certainly OK with a standalone repository which preserves the history. Will, would

Re: stand-alone kvmtool

2015-02-23 Thread Pekka Enberg
Hi, On 2/18/15 5:50 PM, Will Deacon wrote: Thanks for doing this. Since it looks unlikely that kvmtool will ever be merged back into the kernel tree, it makes sense to cut the dependency in my opinion. I am certainly OK with a standalone repository which preserves the history. Will, would

Re: stand-alone kvmtool

2015-02-23 Thread Pekka Enberg
Hi, On 2/18/15 5:50 PM, Will Deacon wrote: Thanks for doing this. Since it looks unlikely that kvmtool will ever be merged back into the kernel tree, it makes sense to cut the dependency in my opinion. I am certainly OK with a standalone repository which preserves the history. Will, would

Re: [PATCH v3 1/5] slab: Correct size_index table before replacing the bootstrap kmem_cache_node.

2015-02-05 Thread Pekka Enberg
Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org Acked-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/5] slab: Correct size_index table before replacing the bootstrap kmem_cache_node.

2015-02-05 Thread Pekka Enberg
...@imgtec.com Cc: Christoph Lameter c...@linux.com Cc: Pekka Enberg penb...@kernel.org Cc: David Rientjes rient...@google.com Cc: Joonsoo Kim iamjoonsoo@lge.com Cc: Andrew Morton a...@linux-foundation.org Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org Acked-by: Pekka Enberg penb...@kernel.org

Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node.

2015-02-04 Thread Pekka Enberg
On Wed, Feb 4, 2015 at 10:38 PM, Daniel Sanders wrote: > I don't believe the bug to be LLVM specific but GCC doesn't normally > encounter the problem. I haven't been able to identify exactly what GCC is > doing better (probably inlining) but it seems that GCC is managing to > optimize to the

Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node.

2015-02-04 Thread Pekka Enberg
On 2/3/15 3:37 PM, Daniel Sanders wrote: This patch moves the initialization of the size_index table slightly earlier so that the first few kmem_cache_node's can be safely allocated when KMALLOC_MIN_SIZE is large. The patch looks OK to me but how is this related to LLVM? - Pekka -- To

Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node.

2015-02-04 Thread Pekka Enberg
On 2/3/15 3:37 PM, Daniel Sanders wrote: This patch moves the initialization of the size_index table slightly earlier so that the first few kmem_cache_node's can be safely allocated when KMALLOC_MIN_SIZE is large. The patch looks OK to me but how is this related to LLVM? - Pekka -- To

Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node.

2015-02-04 Thread Pekka Enberg
On Wed, Feb 4, 2015 at 10:38 PM, Daniel Sanders daniel.sand...@imgtec.com wrote: I don't believe the bug to be LLVM specific but GCC doesn't normally encounter the problem. I haven't been able to identify exactly what GCC is doing better (probably inlining) but it seems that GCC is managing

Re: [PATCH -mm v2 1/3] slub: never fail to shrink cache

2015-01-28 Thread Pekka Enberg
Acked-by: Christoph Lameter Acked-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH -mm v2 1/3] slub: never fail to shrink cache

2015-01-28 Thread Pekka Enberg
Lameter c...@linux.com Acked-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 3/7] slub: Do not use c->page on free

2014-12-10 Thread Pekka Enberg
t's the (1 << MAX_ORDER) optimization that confused me. Perhaps add a comment there to make it more obvious? I'm fine with the optimization: Reviewed-by: Pekka Enberg - Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 6/7] slub: Drop ->page field from kmem_cache_cpu

2014-12-10 Thread Pekka Enberg
he condition that the current cpu has no > percpu slab attached to it. > > Signed-off-by: Christoph Lameter Reviewed-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 5/7] slub: Use end_token instead of NULL to terminate freelists

2014-12-10 Thread Pekka Enberg
e by setting the lowest bit in the freelist address > and use the start address of a page if no other address is available > for list termination. > > This will allow us to determine the page struct address from a > freelist pointer in the future. > > Signed-off-by: Christoph La

Re: [PATCH 4/7] slub: Avoid using the page struct address in allocation fastpath

2014-12-10 Thread Pekka Enberg
On Wed, Dec 10, 2014 at 6:30 PM, Christoph Lameter wrote: > We can use virt_to_page there and only invoke the costly function if > actually a node is specified and we have to check the NUMA locality. > > Increases the cost of allocating on a specific NUMA node but then that > was never cheap

Re: [PATCH 3/7] slub: Do not use c->page on free

2014-12-10 Thread Pekka Enberg
On Wed, Dec 10, 2014 at 6:30 PM, Christoph Lameter wrote: > Avoid using the page struct address on free by just doing an > address comparison. That is easily doable now that the page address > is available in the page struct and we already have the page struct > address of the object to be freed

<    1   2   3   4   5   6   7   8   9   10   >