[pve-devel] applied: [PATCH v3 storage 1/1] fix #2920: cifs: add options parameter

2023-06-07 Thread Thomas Lamprecht
Am 01/03/2023 um 13:13 schrieb Fiona Ebner: > From: Stefan Hrdlicka > > This makes it possible to add all mount options offered by mount.cifs. > NFS & CIFS now share the options parameter since they use it for the > same purpose. > > Signed-off-by: Stefan Hrdlicka > [FE: rebase + style fixes]

[pve-devel] applied: [PATCH access-control v3 2/2] add realm-sync plugin for jobs and CRUD api for realm-sync-jobs

2023-06-07 Thread Thomas Lamprecht
Am 17/01/2023 um 12:46 schrieb Dominik Csapak: > to be able to define automated jobs that sync ldap/ad > > The jobs plugin contains special handling when no node is given, since > we only want it to run on a single node when that triggers. For that, > we save a statefile in /etc/pve/priv/jobs/

[pve-devel] applied-series: [PATCH-SERIES qemu-server/storage] improve RBD resize

2023-06-06 Thread Thomas Lamprecht
Am 28/04/2023 um 14:32 schrieb Fiona Ebner: > Make the way the block_resize QMP command is used consistent with > what other block device backed storages like ZFS and LVM(thin) do. > > Avoid the --allow-shrink flag that should never be required in our > code and avoid passing floating point

Re: [pve-devel] [PATCH storage 2/2] rbd: volume resize: avoid passing floating point value to rbd

2023-06-06 Thread Thomas Lamprecht
Am 28/04/2023 um 14:32 schrieb Fiona Ebner: > which causes an error "the argument for option '--size' is invalid". > Just round up to the nearest integer to have at least the requested > size. This is similar to what is done for ZFS with d3e3e5d ("When > resizing a ZFS volume, align size to 1M")

[pve-devel] applied-series: [PATCH manager v2 1/2] ui: storage: backup: refactor extraColumns assignment

2023-06-06 Thread Thomas Lamprecht
Am 25/04/2023 um 09:21 schrieb Dominik Csapak: > makes it easier to add columns, and uses less indentation > > Signed-off-by: Dominik Csapak > --- > new in v2 > www/manager6/storage/BackupView.js | 40 +++--- > 1 file changed, 20 insertions(+), 20 deletions(-) > >

[pve-devel] applied: [PATCH manager] fix #4605: drop rsyncable from zstd invocation

2023-06-06 Thread Thomas Lamprecht
Am 17/04/2023 um 09:04 schrieb Fabian Grünbichler: > it causes severe slow downs on fast disks, and we still have other rsyncable > compressors available. > > it was originally added based on wrong documentation that made the performance > impact look a lot smaller than it actually is. > >

[pve-devel] applied: [PATCH-SERIES ha-manager] avoid rebalance-on-start for newly added already running service

2023-06-06 Thread Thomas Lamprecht
Am 14/04/2023 um 14:38 schrieb Fiona Ebner: > As reported in the community forum[0], the current behavior when > adding an already running service to HA is wrong. If rebalance > selected a different node, the service would be stopped, offline > migrated and started again. Since the

[pve-devel] applied: [PATCH qemu-server] net: Skip and warn of interfaces without bridge

2023-06-06 Thread Thomas Lamprecht
Am 12/04/2023 um 10:45 schrieb Christian Ebner: > Handle and warn about network interfaces which are not attached to > any bridge because the user actively removed it from the VM config. > > Signed-off-by: Christian Ebner > --- > PVE/QemuServer.pm | 4 > 1 file changed, 4 insertions(+) >

[pve-devel] applied-series: [PATCH proxmox-apt 1/2] fallback to Release file for Origin retrieval

2023-06-06 Thread Thomas Lamprecht
Am 12/04/2023 um 09:17 schrieb Fabian Grünbichler: > APT will not store the InRelease file in some cases, and some repositories > might not even have one in the first place. > > Signed-off-by: Fabian Grünbichler > --- > src/repositories/repository.rs | 19 --- > 1 file changed,

[pve-devel] applied: [RFC manager] pveceph: add osd details command

2023-06-06 Thread Thomas Lamprecht
Am 19/12/2022 um 15:46 schrieb Aaron Lauterer: > To provide similar output on the CLI as is possible in the GUI/API > regaring OSD details. > > By default (output-format=text) a more concise output is shown. Using > json or yaml as output format will print all the available data. > > The

[pve-devel] applied: [PATCH pve-container] fix #4457: use bridge mtu if no mtu is defined

2023-06-06 Thread Thomas Lamprecht
Am 11/04/2023 um 14:44 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/LXC.pm | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH qemu 2/2] update reentrancy patches to version in upstream git

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 10:58 schrieb Fiona Ebner: > The previous version was picked from the mailing list and still had > an object_dynamic_cast call in a hot path, which is avoided with the > version that landed in git. > > Also adds a few more exceptions for devices that need reentrancy. > >

[pve-devel] applied: [PATCH qemu 1/2] update submodule and patches to QEMU 8.0.2

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 10:58 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > ...le-reentrancy-detection-for-script-R.patch | 4 +- > ...39-fix-large_send_mss-divide-by-zero.patch | 72 > ...en-getting-cursor-without-a-console.patch} | 2 +- >

[pve-devel] applied: [PATCH v2 docs] pvesm: mark ZFS level as both

2023-06-06 Thread Thomas Lamprecht
Am 11/04/2023 um 13:04 schrieb Aaron Lauterer: > ZFS can do both, and we do use both, block and file level functionality. > > Signed-off-by: Aaron Lauterer > --- > changes since v1: rephrased the footnote for ZFS > > pvesm.adoc | 39 +-- > 1 file changed, 21

[pve-devel] applied-series: [PATCH-SERIES storage/docs/guest-common/qemu-server/common] Improve and unify documentation of bwlimit parameter

2023-06-06 Thread Thomas Lamprecht
Am 29/03/2023 um 14:34 schrieb Stefan Hanreich: > While looking through our documentation for the bwlimit parameter > I noticed that the descriptions are inconsistent and sometimes > wrong / unclear about the actual unit used for the parameter. This > patch series fixes some inconsistencies and

[pve-devel] applied: [RFC storage] content-dirs: check that all content dirs are pairwise inequal

2023-06-06 Thread Thomas Lamprecht
Am 21/03/2023 um 18:03 schrieb Friedrich Weber: > This prevents strange interactions in case the same content directory > is used for multiple content types. > > Signed-off-by: Friedrich Weber > --- > I guess technically this is a breaking change, as users may have an > iso+vztmpl storage that

Re: [pve-devel] [PATCH manager] close #4513: ui: backup job: add performance tab

2023-06-06 Thread Thomas Lamprecht
stumbled upon this again when checking out old(er) patches without comments, some higher level comments inline. Am 15/03/2023 um 14:24 schrieb Fiona Ebner: > pigz is not exposed, because it only works after manually installing > the pigz package. > > ionice is not exposed, because it only works

[pve-devel] applied-series: [PATCH widget-toolkit/http-server/apiclient 0/4] Set SameSite=Strict on Auth Cookies

2023-06-06 Thread Thomas Lamprecht
Am 15/03/2023 um 17:26 schrieb Max Carrara: > This series sets the `SameSite` attribute of authentication cookies > to `Strict` as per RFC 6265[1]. This prevents browsers from nagging; > for example, FireFox 102.8.0esr would complain in the following manner: > >> Cookie “PVEAuthCookie” does not

[pve-devel] applied: [PATCH manager] ui: fix duplicate references when using multiple DiskStorageSelectors

2023-06-06 Thread Thomas Lamprecht
Am 21/03/2023 um 14:27 schrieb Dominik Csapak: > by removing the references and change the one place where we used > one of the references. > > Signed-off-by: Dominik Csapak > --- > while i tested all places where we have a disk selector > (wizard, clone, efidisk, add hd) i am not super sure i

[pve-devel] applied: [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI

2023-06-06 Thread Thomas Lamprecht
Am 08/02/2023 um 10:05 schrieb Leo Nunner: > makes it possible to optionally set the 'subdir' parameter when adding a > new CIFS storage. > > Signed-off-by: Leo Nunner > --- > Changes from v1: > - use gettext for the Subdirectory label > > www/manager6/storage/CIFSEdit.js | 11 +++

[pve-devel] applied: [PATCH manager] api: nodes: add 'migrateall' to index

2023-06-06 Thread Thomas Lamprecht
Am 29/03/2023 um 13:36 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > PVE/API2/Nodes.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH v3 manager] gui: expose content-dirs property in storage edit/create

2023-06-06 Thread Thomas Lamprecht
Am 24/03/2023 um 17:12 schrieb Leo Nunner: > Add a separate tab for the storage edit/create panels to set the > recently introduced "content-dirs" property which overrides the > default directory locations. Analogous to the API implementation, > the tab was added for Directory, CIFS and NFS

[pve-devel] applied: [PATCH docs] tree-wide: properly use {pve} instead of PVE

2023-06-06 Thread Thomas Lamprecht
Am 28/03/2023 um 14:03 schrieb Fabian Grünbichler: > where applicable, or expand/replace where it's not a good fit or automatic > expansion doesn't work. > > there are a few more in generated files, those need to be cleaned up > separately. > > Signed-off-by: Fabian Grünbichler > --- > >

[pve-devel] applied: [PATCH docs] network: rephrase corosync and bonds recommendations

2023-06-06 Thread Thomas Lamprecht
Am 24/03/2023 um 14:03 schrieb Aaron Lauterer: > I suspect that the old one seems to be related to multicast traffic and > LACP bonds. > > The link in the comment is dead by now. It seems this is one occasion > where the internet actually forgets as I cannot find the actual message > of that

[pve-devel] applied: [PATCH widget-toolkit 2/3] DateTimeField: Extend and refactor to make field value bindable

2023-06-06 Thread Thomas Lamprecht
Am 23/03/2023 um 15:42 schrieb Christian Ebner: > Extends the date time field so that bindings are updated on value changes. > Also adds a config to disable child components and avoid modification of > current values by cloning the referenced object for min/max value calculation. > >

[pve-devel] applied: [PATCH widget-toolkit 1/3] DateTimeField: fix typo in xtype

2023-06-06 Thread Thomas Lamprecht
Am 23/03/2023 um 15:42 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > src/form/DateTimeField.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, but added the misspelled variant back as alias in a follow-up, that allows us to upgrade the use sites later,

[pve-devel] applied: [PATCH edk2-firmware] add patch to work around older guest kernel bug

2023-06-06 Thread Thomas Lamprecht
nit: a slightly more telling subject could have been something like: backport limiting the phys-bits to 46 for bug in old guest kernel Am 05/06/2023 um 09:43 schrieb Fiona Ebner: > by limiting the phys-bits to 46 instead of 47. On Ubuntu 18.04 with > kernel 4.15, using 47 leads to a strange

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 13:19 schrieb Dominik Csapak: > ---8<--- > use Storable qw(dclone); > > my $normalize; > $normalize = sub {...}; > > my $data = /* create large hash here, with nested data */; > > while(1) { >     my $newdata = dclone($data); >     $newdata = $normalize->($newdata); > } >

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 11:41 schrieb Dominik Csapak: >>>   +my $untaint_recursive; >> >> I got flash backs w.r.t. refcount cycles here keeping all variables, and  >> thus memory >> inside the body alive forever, don't we need a weaken? >> >> E.g., like we had to do in PVE::Status::Graphite's assemble. >

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 10:39 schrieb Dominik Csapak: > a few things were missing for it to work: > * on the cli, we have to get the option as an array if the type is an > array > * the untainting must be done recursively, otherwise, the regex matching > converts an array hash into the string

[pve-devel] applied: [PATCH pve-network 0/6] sdn multiples fixes

2023-06-06 Thread Thomas Lamprecht
Am 20/04/2023 um 23:36 schrieb Alexandre Derumier: > This is a resend of the 4 last patches for pve-network > + 2 new patches > > > Alexandre Derumier (6): > fix #4657 : evpn: fix exit-node with multiple vrf > fix #4425: vxlan|evpn: add vxlan-port option > fix #4662 : frr: fix config

[pve-devel] applied: [PATCH frr 0/4] update to 8.5.1

2023-06-06 Thread Thomas Lamprecht
Am 23/05/2023 um 08:08 schrieb Alexandre Derumier: > Hi, > > This patch serie update frr to 8.5.1. > (mirror need to be update to 8.5.1 tag > https://github.com/FRRouting/frr/tree/frr-8.5.1) > > I have removed old upstreamed patches, and added 2 importants evpn > patches released just after

[pve-devel] applied: [PATCH pve-network 1/1] evpn: update config to frr 8.5.1

2023-06-06 Thread Thomas Lamprecht
Am 23/05/2023 um 08:47 schrieb Alexandre Derumier: > add default values: > "no bgp hard-administrative-reset" > "no bgp graceful-restart notification" > > to avoid frr-reload warning > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Controllers/EvpnPlugin.pm | 7

[pve-devel] applied: [PATCH frr] fix #4040 : patch : ospf6d: fix infinite loop when adding ASBR route

2023-06-06 Thread Thomas Lamprecht
Am 13/04/2023 um 13:48 schrieb Alexandre Derumier: > --- > .../frr/ospf6d-fix-infinite-loop.patch| 76 +++ > debian/patches/series | 1 + > 2 files changed, 77 insertions(+) > create mode 100644 debian/patches/frr/ospf6d-fix-infinite-loop.patch >

[pve-devel] applied: [PATCH] pve7to8: ceph version check: ignore commit hash

2023-06-05 Thread Thomas Lamprecht
Am 02/06/2023 um 18:04 schrieb Aaron Lauterer: > The commit hash of the Ceph version might be different between major > releases. For example: > ceph version 17.2.6 (810db68029296377607028a6c6da1ec06f5a2b27) quincy (stable) > ceph version 17.2.6 (995dec2cdae920da21db2d455e55efbc339bde24) quincy

Re: [pve-devel] [PATCH/RFC widget-toolkit 2/5] apt repositories: just ignore unknown info rather than throwing an error

2023-06-05 Thread Thomas Lamprecht
Am 05/06/2023 um 17:43 schrieb Fiona Ebner: > This will avoid breaking older UI when extending the backend. > > Signed-off-by: Fiona Ebner > --- > src/node/APTRepositories.js | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js >

Re: [pve-devel] [PATCH proxmox-i18n] en: fix spelling mistake, unkown => unknown

2023-06-05 Thread Thomas Lamprecht
Am 15/05/2023 um 05:56 schrieb Marlin Sööse: > This just fixes a spelling mistake. > Thanks for reporting this and appreciating that you sent a patch already, but the POT files are auto-generated and come directly from the source. So, here one would need to fix that, and those are indicated as

[pve-devel] applied: [PATCH cluster v4 1/1] add cfg files for resource mapping

2023-06-05 Thread Thomas Lamprecht
Am 25/05/2023 um 12:17 schrieb Dominik Csapak: > resource/pci.cfg and > resource/usb.cfg > > to PVE/Cluster.pm > and status.c > > Signed-off-by: Dominik Csapak > --- > src/PVE/Cluster.pm | 2 ++ > src/pmxcfs/status.c | 2 ++ > 2 files changed, 4 insertions(+) > > applied, with finalizing

[pve-devel] applied: little PATCH proxmox-i18n for ja.po (for 3.0.0)

2023-06-05 Thread Thomas Lamprecht
Am 03/06/2023 um 05:41 schrieb ribbon: > little Japanese translation update for 3.0.0 > > --- ja.po 2023-06-03 11:10:29.097009127 +0900 > +++ jan.po2023-06-03 11:10:08.708856465 +0900 applied, thanks! Would be great if you could submit those via git directly:

Re: [pve-devel] [PATCH v2 qemu-server 1/1] api2: add check_bridge_access for create/update vm

2023-06-05 Thread Thomas Lamprecht
Am 05/06/2023 um 01:37 schrieb Alexandre Derumier: > test first if user have access to the full zone (any bridge/vlan) > if a tag is defined, test if user have a specific access to the vlan (or > propagate from full bridge acl) > if no tag, test if user have access to full bridge. (if trunks are

[pve-devel] applied: [PATCH cluster] pvecm: fix cluster join over ssh with newer rsync

2023-06-04 Thread Thomas Lamprecht
Am 02/06/2023 um 15:20 schrieb Dominik Csapak: > since rsync 3.2.4, the syntax to give multiple files in one parameter > does not work anymore, so instead add both files explicitly > > this fixes the cluster join over ssh on bookworm > > Signed-off-by: Dominik Csapak > --- >

[pve-devel] applied: [PATCH v2 proxmox 1/5] apt: drop older Ceph standard repositories

2023-06-04 Thread Thomas Lamprecht
Am 02/06/2023 um 10:48 schrieb Fiona Ebner: > On Proxmox VE 8, only Quincy and newer will be supported. > > Signed-off-by: Fiona Ebner > --- > > No changes in v2. > > Changes for the series in v2: > * create temporary test directories inside CARGO_TARGET_TMPDIR > * mention that

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-03 Thread Thomas Lamprecht
Am 02/06/2023 um 11:13 schrieb DERUMIER, Alexandre: > at minimum, it could be interesting to expose the flag in the gui, for > users really needed intel-amd migration. acked also from my side, we can use the flag description for the a note that it might benefit cross vendor migration (with some

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-03 Thread Thomas Lamprecht
Am 01/06/2023 um 11:06 schrieb DERUMIER, Alexandre: >> Maybe the easiest would be to extract the aes flag out of the grid >> into >> the non-advanced part? >> > Couldn't be easier to keep aes enable by default in a single model > (even if it's doesn't match the x86-64 spec). and allow user to

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-03 Thread Thomas Lamprecht
Am 01/06/2023 um 10:34 schrieb Fiona Ebner: > Am 31.05.23 um 16:34 schrieb DERUMIER, Alexandre: >> Le mercredi 31 mai 2023 à 13:36 +0200, Fiona Ebner a écrit : >>> Am 22.05.23 um 12:25 schrieb Alexandre Derumier: In addition to theses model, I have enabled aes too. I think it's really

Re: [pve-devel] [PATCH-SERIES pve-manager/qemu-server] fix#4689 autofind node with proxyto_callback

2023-06-03 Thread Thomas Lamprecht
Hi! Am 01/06/2023 um 00:28 schrieb Alexandre Derumier: > Currently, to manage qemu && lxc vms, we always need to specify nodename in > uri. > > This is a problem with automation tools like terraform, where is node is > registered > in the state of terraform. What do you need here, the whole

Re: [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids

2023-06-01 Thread Thomas Lamprecht
Don't we reuse that on PBS/PMG too, and if is it working there? The commit message isn't excactly telling... ;-) Am 13/04/2023 um 17:10 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > src/node/NetworkEdit.js | 16 > 1 file changed, 16 insertions(+) > > diff

Re: [pve-devel] [PATCH widget-toolkit 2/2] utils: format_size: show negative size as NA

2023-06-01 Thread Thomas Lamprecht
Am 19/04/2023 um 12:34 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > > AFAIK we do not have negative sizes anywhere, and if, it is an > indication that something is wrong. above belongs in the commit message, additionaly some background for why doing this now (i.e., did you

[pve-devel] applied: [PATCH proxmox-widget-toolkit v2 1/1] fix 4551: ui: translate byte unit in `format_size`

2023-06-01 Thread Thomas Lamprecht
Am 06/04/2023 um 13:38 schrieb Noel Ullreich: > Some languages translate byte units like 'GiB' or write them in their > own script. > > By `gettext`ing the units in the `format_size` function, we can > translate the units for (almost) all of the web interface. > > Signed-off-by: Noel Ullreich >

Re: [pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix #4551: ui: use gettext on hardcoded byte units

2023-06-01 Thread Thomas Lamprecht
Used wrong tag, this is for manager, not widget-toolkit... Am 06/04/2023 um 13:38 schrieb Noel Ullreich: > Since some languages translate byte units like 'GiB' or write them in their > own script, this patch wraps units in the `gettext` function. > > While most occurrences of byte strings can

[pve-devel] applied: [PATCH http-server] fix regression in api/html (bootstrap) viewer

2023-05-30 Thread Thomas Lamprecht
Am 30/05/2023 um 13:56 schrieb Dominik Csapak: > recent versions of URI::Escape seem to handle the 'unsafe characters' > parameter differently than before, enforcing what is documented: > > The set is specified as a string that can be used in a regular > expression character class (between [

Re: [pve-devel] Plan for (invasive) shrink of pve-manager git repository

2023-05-28 Thread Thomas Lamprecht
Am 28/05/2023 um 20:38 schrieb Thomas Lamprecht: > For re-aligning your local master branch you can do a hard-reset, BUT check > if you got any local commits yet (move them over to another branch with e.g. > `git checkout -b feature-to-re-apply-on-master` > > git checkout mas

Re: [pve-devel] Plan for (invasive) shrink of pve-manager git repository

2023-05-28 Thread Thomas Lamprecht
Am 26/05/2023 um 11:45 schrieb Thomas Lamprecht: > I'll use the git filter-repo [0] tool, a replacement for filter-branch with > better UX and less potential for getting it wrong, to rewrite the history, > filtering out any problematic artefact or directory. > > For this I'll us

Re: [pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex

2023-05-28 Thread Thomas Lamprecht
Am 17/05/2023 um 15:42 schrieb Stefan Sterz: > sorry just noticed i forgot: adding tests for this was > > Suggested-by: Dominik Csapak I mean, it's really great that we finally get some tests here and if only Dominik statement made you do it, then chapeau to him! But, Suggested-by's should be

[pve-devel] applied: [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close

2023-05-28 Thread Thomas Lamprecht
Am 03/04/2023 um 14:28 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > similar as in > https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b380cb5814ec551588dfcbd6c5ed190f01d54029 added the infor of above into the commit message, such cross references have always some

Re: [pve-devel] [PATCH v4 manager] ui: ceph: improve discoverability of warning details

2023-05-28 Thread Thomas Lamprecht
Am 26/05/2023 um 10:39 schrieb Aaron Lauterer: > ping? Considering that some users are rather hesitant to upgrade to a major > version, it might be a good idea to still get this into Proxmox VE 7 to make > it easier for users to discover more details about any issues they experience. I think

[pve-devel] Plan for (invasive) shrink of pve-manager git repository

2023-05-26 Thread Thomas Lamprecht
Hi all! It follows a head's up for the plan of making it easier to work with our pve-manager git repository by rewriting its history to filter out huge artefacts. This will only affect developers, nothing in the current pve-manager Debian package will change. # Background Our current

Re: [PVE-User] vGPU scheduling

2023-05-25 Thread Thomas Lamprecht
Am 25/05/2023 um 09:43 schrieb Dominik Csapak: >> >> Do you think it'll be merged for proxmox 8 ? > > i don't know, but this also depends on the capacity of my colleagues to  > review  making it easy to digest and adding (good) tests will surely help to accelerate this ;-P But, you're

[pve-devel] applied: [PATCH qemu-server] fix #4737: qmeventd: gracefully handle interrupted epoll_wait call

2023-05-24 Thread Thomas Lamprecht
Am 24/05/2023 um 12:30 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > qmeventd/qmeventd.c | 3 +++ > 1 file changed, 3 insertions(+) > > applied and cherry-picked to stable-7, thanks! ___ pve-devel mailing list

[pve-devel] applied-series: [PATCH-SERIES v2 qemu] update to QEMU 8.0

2023-05-23 Thread Thomas Lamprecht
Am 15/05/2023 um 15:39 schrieb Fiona Ebner: > After weeks and weeks of (sometimes painful) debugging, it's finally > here. And got a load of stable fixes on top already. More testing is > always appreciated, especially backup, PBS live restore and snapshots, > which needed quite a few changes! >

[pve-devel] applied: [PATCH ifupdown2 0/6] bump to 3.2.0

2023-05-20 Thread Thomas Lamprecht
Am 16/05/2023 um 00:47 schrieb Alexandre Derumier: > This patch series bump version to 3.2.0. > > This need update of proxmox ifupdown2 mirror to last master > a0522546b848435115a20eb647f87ade01761a33 commit , as > the 3.2.0 tagged version is missing 1 patch fix. FYI: After checking out the

Re: [pve-devel] [PATCH pve-qemu 1/1] patch: add 0001-add-cpu-models-x86-64-abi.patch

2023-05-19 Thread Thomas Lamprecht
Am 17/05/2023 um 11:08 schrieb Fiona Ebner: >> (BTW, what do you think about bumping the default model ? is it ok for >> you ?) >> > Yes, I do think it should be done, because most currently in-use CPUs > should be fine with x86-64-abi2 and it's not nice to users if the > defaults don't work

[pve-devel] applied: [PATCH docs] pmxcfs: update size limit to 128 MiB

2023-05-18 Thread Thomas Lamprecht
Am 11/04/2023 um 10:16 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > > I also did a reformat of that paragraph. > > pmxcfs.adoc | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied-series: [pbs-devel] [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups - Round 6

2023-05-17 Thread Thomas Lamprecht
Am 14/04/2023 um 15:28 schrieb Stefan Sterz: > this patch series adds a couple more tweaks to the dark theme. first > it improves the contrast ratios on panel header tool icons. then the > chart and gauge colors are brightened to match the primary color. > > for the backup server first the path

[pve-devel] applied-series: [PATCH firewall 1/2] icmp: factor out check for relevant protocols

2023-05-16 Thread Thomas Lamprecht
Am 16/05/2023 um 11:09 schrieb Fabian Grünbichler: > this were not entirely consistent and sometimes the checks were repeated. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/Firewall.pm | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > applied series,

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Thomas Lamprecht
Am 04/05/2023 um 10:57 schrieb Dominik Csapak: > On 5/4/23 10:42, Thomas Lamprecht wrote: >> Am 04/05/2023 um 10:31 schrieb Dominik Csapak: >>> On 5/4/23 10:13, Thomas Lamprecht wrote: >>>> Am 03/05/2023 um 13:26 schrieb Dominik Csapak: >>>>> just a s

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Thomas Lamprecht
Am 04/05/2023 um 10:31 schrieb Dominik Csapak: > On 5/4/23 10:13, Thomas Lamprecht wrote: >> Am 03/05/2023 um 13:26 schrieb Dominik Csapak: >>> just a short comment since this series overlaps a bit with my >>> cluster resource mapping series (i plan on sending a v

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Thomas Lamprecht
Am 03/05/2023 um 13:26 schrieb Dominik Csapak: > just a short comment since this series overlaps a bit with my > cluster resource mapping series (i plan on sending a v4 soon). > > i'd prefer to have the configuration endpoints for mapping bundled in a > subdirectory > so instead of /nodes//dirs/

[pve-devel] applied: [PATCH proxmox-i18n 2/2] Polish translation update

2023-05-02 Thread Thomas Lamprecht
Am 15/04/2023 um 01:12 schrieb Daniel Koć: > Signed-off-by: Daniel Koć > --- > pl.po | 3906 + > 1 file changed, 2295 insertions(+), 1611 deletions(-) > > applied this one, thanks! It seems like the first patch was (mostly?) already

Re: [pve-devel] pct-gentoo-systemd-plugin-fix.patch

2023-05-02 Thread Thomas Lamprecht
Am 29/04/2023 um 21:47 schrieb Jorge Ventura: > Allow install gentoo rootfs based on systemd as container. Tested with > rootfs images from https://jenkins.linuxcontainers.org/. Thanks for your contribution, but applying fails with "error: corrupt patch at line 11" probably due to not using git

[pve-devel] applied: little PATCH proxmox-i18n for ja.po

2023-05-02 Thread Thomas Lamprecht
Am 30/04/2023 um 10:07 schrieb ribbon: > little Japanese translation update > > --- proxmox-i18n/ja.po2023-04-30 16:32:55.922938861 +0900 > +++ jan.po2023-04-30 16:58:03.294743009 +0900 > @@ -8,7 +8,7 @@ applied, thanks! ___ pve-devel

Re: [PVE-User] MIME type of SPICE configuration file

2023-04-29 Thread Thomas Lamprecht
Am 28/04/2023 um 23:24 schrieb Uwe Sauter: > I'm having trouble finding out the MIME type of the configuration file that > is presented as download. As mentioned Firefox has no automatic association > but in order do the configuration I'd need to know which MIME type I need to > associate with 

Re: [pve-devel] [PATCH v2 qemu-server 2/2] remote-migration: add target-cpu param

2023-04-29 Thread Thomas Lamprecht
Am 28/04/2023 um 11:12 schrieb Fabian Grünbichler: >> It's was more about "offline" term, because we don't offline the source >> vm until the disk migration is finished. (to reduce downtime) >> More like "online-restart" instead "offline". >> >> Offline for me , is really, we shut the vm, then do

Re: [pve-devel] is the next pve version 8.0 with debian 12 ? (any planning on patches merge ?)

2023-04-28 Thread Thomas Lamprecht
Am 28/04/2023 um 09:15 schrieb DERUMIER, Alexandre: > I would like to known if the next pve version will be 8.0 on debian12 ? yes. > and if they are any planning for patches merging ? (I would like to > schedule time on my agenda if my patches need to be rework). Debian Bookworkm release is

[pve-devel] applied-series: [PATCH manager 1/2] ui: clone: validate name

2023-04-24 Thread Thomas Lamprecht
On 17/04/2023 09:09, Fiona Ebner wrote: > As reported in the community forum[0], as opposed to VM/LXC creation, > there is no validation for the name in the clone dialog. Use the same > validation as the guest creation wizards do to catch errors early, > before sending the API request. > > [0]:

[pve-devel] applied: [PATCH pve-manager 1/1] adding missing gettext

2023-04-24 Thread Thomas Lamprecht
On 16/04/2023 05:29, Daniel Koć wrote: > --- > www/manager6/ceph/FS.js | 4 ++-- > www/manager6/ceph/OSD.js| 6 +++--- > www/manager6/ceph/OSDDetails.js | 2 +- > www/manager6/form/VLanField.js | 2 +- > www/manager6/ha/Fencing.js | 4 ++-- > www/manager6/ha/GroupEdit.js

Re: [pve-devel] [PATCH proxmox-offline-mirror 1/2] setup wizard: add subscription keys

2023-04-24 Thread Thomas Lamprecht
On 18/04/2023 10:58, Fabian Grünbichler wrote: > to make it a bit easier to configure access to the enterprise repositories. > > Signed-off-by: Fabian Grünbichler > --- > docs/offline-keys.rst | 3 +- > src/bin/proxmox-offline-mirror.rs | 102

[pve-devel] applied: Re: [PATCH proxmox-offline-mirror 2/2] fix #4614: add note about key requirements to mirror docs

2023-04-24 Thread Thomas Lamprecht
On 18/04/2023 10:58, Fabian Grünbichler wrote: > and reference the key part of the documentation. > > Signed-off-by: Fabian Grünbichler > --- > docs/offline-keys.rst | 2 ++ > docs/offline-mirror.rst | 5 + > 2 files changed, 7 insertions(+) > > applied, thanks!

Re: [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default

2023-04-22 Thread Thomas Lamprecht
On 22/04/2023 09:38, Thomas Lamprecht wrote: > , would potentially also split this ignore that part, send to early and patch is actually fine in that regard. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-

[pve-devel] applied: Re: [PATCH v2 manager] ui: utils: monitor_ceph_installed: avoid setting nodename to localhost

2023-04-22 Thread Thomas Lamprecht
On 20/04/2023 14:31, Aaron Lauterer wrote: > If a user is accessing the Ceph panel via Datacenter -> Ceph, then the > install & config wizard might be shown. The nodename that is passed to > the wizard will decide the ID of the initial MON and MGR services. > > Therefore, don't fall back to

Re: [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default

2023-04-22 Thread Thomas Lamprecht
On 20/04/2023 10:06, Dominik Csapak wrote: > instead, add the vmid as extra column, so that the user can still sort > by vmid if they wish to > missing Reported-by tag, would potentially also split this > Signed-off-by: Dominik Csapak > --- > www/manager6/storage/BackupView.js | 12

Re: [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content

2023-04-22 Thread Thomas Lamprecht
On 20/04/2023 10:06, Dominik Csapak wrote: > this enables the user to sort the grid by multiple columns > simultaneously, e.g. by vmid and then by date > > Signed-off-by: Dominik Csapak > --- > sending as rfc because i'm not so sure about this. > > on one hand, this allows to recreate the

Re: [pve-devel] [PATCH manager 2/3] ui: make storage backup content stateful

2023-04-22 Thread Thomas Lamprecht
On 20/04/2023 10:06, Dominik Csapak wrote: > so that e.g. a custom sort/column order is saved > > Signed-off-by: Dominik Csapak > --- > www/manager6/storage/BackupView.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/storage/BackupView.js >

Re: [pve-devel] [PATCH ifupdown2 2/2] patch: add vlan interface ifdown/ifup when changes on reload, like for vxlan

2023-04-22 Thread Thomas Lamprecht
On 20/04/2023 23:37, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > ...-down-up-vxlan-interfaces-when-ifreload_down.patch | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git >

[pve-devel] applied: Re: [PATCH ifupdown2 0/2] fix #4683 : fix reload of vlan interfaces when attribute change

2023-04-22 Thread Thomas Lamprecht
On 20/04/2023 23:37, Alexandre Derumier wrote: > This patch series fix the reload of vlan interface, > when attribute change like vlan-protocol (only use for qinq currently). > > Like vxlan, we need to ifdown/ifup the interface on reload. > > Alexandre Derumier (2): > patch : vlan: fix

Re: [pve-devel] [PATCH pve-docs v5] update the PCI(e) docs

2023-04-17 Thread Thomas Lamprecht
Am 17/04/2023 um 14:45 schrieb Noel Ullreich: > Sorry for the borked v4's. Those can be ignored. This is the (hopefully) > correctly formatted patch please reply to the series/patch mail that should be ignored due to $problems, not the one fixing it. That way, one that has marked the thread with

Re: [pve-devel] [PATCH pve-manager 1/1] adding missing gettext

2023-04-17 Thread Thomas Lamprecht
Am 16/04/2023 um 05:29 schrieb Daniel Koć: Ok, but is missing your Signed-off-by developer certificate of origin, you can either reply here with the S-o-b line, or resend the patch with it amended to the commit message (in that case please also change the commit subject to start with "ui: "),

Re: [pve-devel] [PATCH cluster/manager/ha-manager/proxmox{, -perl-rs} 00/18] fix #4156: introduce new notification module

2023-04-14 Thread Thomas Lamprecht
Am 27/03/2023 um 17:18 schrieb Lukas Wagner: > The purpose of this patch series is to overhaul the existing mail > notification infrastructure in Proxmox VE. nice! Some high level review, but I didn't checked the code basically at all, so sorry if some comments of it are moot, as they're either

Re: [pve-devel] VNC Console using our own portal

2023-04-13 Thread Thomas Lamprecht via pve-devel
--- Begin Message --- Hi, Am 13/04/2023 um 15:06 schrieb Mark Schouten: > Not sure if this thread should exist on this list, if not, let me know and > I’ll repost to pve-users. However, I think there are more people here that > know how to achieve what I’m looking for. :) That's fine here too.

[pve-devel] applied: [PATCH http-server] file upload: don't calculate MD5

2023-04-13 Thread Thomas Lamprecht
Am 12/04/2023 um 16:22 schrieb Matthias Heiserer: > Until now, we calculated the MD5 hash of any uploaded file during the upload, > regardless > of whether the user chose to provide a hash sum and algorithm. > The hash was only logged in the syslog. > > As the user can provide a hash algorithm

Re: [pve-devel] [PATCH v2 common 1/1] fix #1454: meminfo: also return arcsize

2023-04-13 Thread Thomas Lamprecht
Am 28/03/2023 um 14:49 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > Changes from v1: > None > > src/PVE/ProcFSTools.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm > index eb4b0f5..0686c34 100644 > ---

[pve-devel] applied: [PATCH widget-toolkit] form: combo grid: use correct method to initialize the picker

2023-04-12 Thread Thomas Lamprecht
Am 31/03/2023 um 12:04 schrieb Dominik Csapak: > 'createPicker' does create the picker, but not all necessary > initialization for the combobox (namely it does not set the owner field, > but that's only an implementation detail). Instead 'getPicker' should be > used for that, since that does all

[pve-devel] applied: [PATCH manager] fix #4627: ui: backup edit: don't deselect all vms on load

2023-04-12 Thread Thomas Lamprecht
Am 31/03/2023 um 12:03 schrieb Dominik Csapak: > 'selectPoolMembers' will be called when the poolid field changes. > (That can even happen when the mode is not even 'pool') > Due to how the fields are set, there is a race condition that this > will be called after the remaining fields were set up,

[pve-devel] applied: [PATCH manager] api: ceph: mon create: remove superfluous verification call

2023-04-12 Thread Thomas Lamprecht
Am 03/04/2023 um 11:35 schrieb Fiona Ebner: > The pve_verify_cidr{,v4,v6} functions were originally intended for > the /etc/network/interfaces API endpoints and thus are a bit > restrictive. For example, as reported in the community forum[0], > pve_verify_cidr() does not consider '0::/0' and

[pve-devel] applied: [PATCH manager] configs: blacklist: fix typo

2023-04-12 Thread Thomas Lamprecht
Am 31/03/2023 um 14:45 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > configs/pve-blacklist.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH http-server] multipart upload: properly parse file parts without Content-Type

2023-04-11 Thread Thomas Lamprecht
Am 11/04/2023 um 14:19 schrieb Friedrich Weber: > As reported in the forum, multipart requests are parsed incorrectly if > the file part header contains *only* Content-Disposition, but no other > fields (in particular, no Content-Type). As a result, uploaded files > are mangled: In most cases, an

[pve-devel] applied: [PATCH proxmox-offline-mirror 1/2] pool: drop redundant quote for paths..

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 13:21 schrieb Fabian Grünbichler: > a Path(Buf)'s Debug formatting already contains double quotes, no need to > quote > it a second time.. > > Signed-off-by: Fabian Grünbichler > --- > src/pool.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied,

[pve-devel] applied: [PATCH proxmox-offline-mirror 2/2] fix #4261: allow GC for all configured mirrors

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 13:21 schrieb Fabian Grünbichler: > by making the --id parameter optional, and structuring the output accordingly. > since pools are per base-dir, GC only needs to run once per base-dir instead > of > for each mirror entry. > > Signed-off-by: Fabian Grünbichler > --- >

Re: [pve-devel] [PATCH proxmox-offline-mirror 2/2] fix #4632: allow escape hatches for legacy repositories

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 09:48 schrieb Fabian Grünbichler: > there are still repositories out there that are using things like DSA/RSA-1024 > and SHA1, so let's allow POM users to opt into accepting those insecure > cryptographic parameters, but keep the default settings secure. > > Signed-off-by: Fabian

[pve-devel] applied: [PATCH proxmox-offline-mirror 0/2] improve GPG verification

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 09:48 schrieb Fabian Grünbichler: > this patch series improves the error messages when encountering an issue with > GPG verification, and offers an (opt-in) escape hatch for allowing weak > cryptographic algorithms if a repository still needs those. > > Fabian Grünbichler (2): >

<    5   6   7   8   9   10   11   12   13   14   >