[jira] [Commented] (OFBIZ-9791) builds in git fail quickly

2017-09-26 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181271#comment-16181271 ] Adam Heath commented on OFBIZ-9791: --- I have it fixed as I've suggested, but I'm also working on other

[jira] [Commented] (OFBIZ-9791) builds in git fail quickly

2017-09-26 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181257#comment-16181257 ] Adam Heath commented on OFBIZ-9791: --- Basically, let's stop checking in empty folders into SVN. Let's

[jira] [Commented] (OFBIZ-9791) builds in git fail quickly

2017-09-26 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181250#comment-16181250 ] Adam Heath commented on OFBIZ-9791: --- That's not the bug. common.gradle has *custom* code that attempts

[jira] [Updated] (OFBIZ-9795) common.gradle doesn't support infinitely component-load.xml depth

2017-09-26 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-9795: -- Description: ComponentContainer.java can look at component-load.xml in each and every component

[jira] [Commented] (OFBIZ-9795) common.gradle doesn't support infinitely component-load.xml depth

2017-09-26 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181081#comment-16181081 ] Adam Heath commented on OFBIZ-9795: --- The best fix for this, would be to have a start-of-day compile

[jira] [Created] (OFBIZ-9795) common.gradle doesn't support infinitely component-load.xml depth

2017-09-26 Thread Adam Heath (JIRA)
Adam Heath created OFBIZ-9795: - Summary: common.gradle doesn't support infinitely component-load.xml depth Key: OFBIZ-9795 URL: https://issues.apache.org/jira/browse/OFBIZ-9795 Project: OFBiz

[jira] [Created] (OFBIZ-9792) order services.xml references bi entities

2017-09-26 Thread Adam Heath (JIRA)
Adam Heath created OFBIZ-9792: - Summary: order services.xml references bi entities Key: OFBIZ-9792 URL: https://issues.apache.org/jira/browse/OFBIZ-9792 Project: OFBiz Issue Type: Bug

Bug#871420: dpkg(1) manpage path-exclude docs possible license issue

2017-08-07 Thread Adam Heath
package: dpkg version: 1.17.27 In the manpage for dpkg, there is an example for path-exclude/path-include: == --path-exclude=/usr/share/doc/* --path-include=/usr/share/doc/*/copyright == These 2 patterns will end up skipping packages that have /usr/share/doc/$foo as a symlink to another

Bug#871420: dpkg(1) manpage path-exclude docs possible license issue

2017-08-07 Thread Adam Heath
package: dpkg version: 1.17.27 In the manpage for dpkg, there is an example for path-exclude/path-include: == --path-exclude=/usr/share/doc/* --path-include=/usr/share/doc/*/copyright == These 2 patterns will end up skipping packages that have /usr/share/doc/$foo as a symlink to another

[jira] [Created] (CB-12417) Statusbar plugin causing issues with webview size when interacting with Camera

2017-02-02 Thread Adam Heath (JIRA)
Adam Heath created CB-12417: --- Summary: Statusbar plugin causing issues with webview size when interacting with Camera Key: CB-12417 URL: https://issues.apache.org/jira/browse/CB-12417 Project: Apache

Re: Please, provide a fixed Cloud Image URL for Debian

2016-08-10 Thread Adam Heath
On 08/10/2016 05:18 PM, Clint Byrum wrote: I think a fixed URL for downloading images of major versions would in fact be good. But you still need to verify the integrity of that image, for the internet is dark, and full of terrors. Verification of the existing images has to happen regardless;

Re: proposal to remove cobertura and sonar from ofbiz

2016-05-26 Thread Adam Heath
, but an *automated* tool makes it much easier to find. And, the above example is a *very* simple example. Please take a look at the test cases for UtilCache. On 05/26/2016 11:26 AM, Adam Heath wrote: Not to Pierre, but ugly and broken? How so? Please expand with concrete issues. ps: I'm

Re: proposal to remove cobertura and sonar from ofbiz

2016-05-26 Thread Adam Heath
Not to Pierre, but ugly and broken? How so? Please expand with concrete issues. ps: I'm the original integrator of cobertura into ofbiz. pps: I have a local branch that converted ofbiz to maven, and actually produced a runnable output. Should I revive that? On 05/26/2016 07:54 AM, Pierre

Bug#816687: -switch: Please use ifquery in init script

2016-03-03 Thread Adam Heath
Package: openvswitch-switch Version: 2.3.0+git20140819-3 Severity: minor In /etc/init.d/openvswitch-switch, the function network_interfaces does a manual parse of /etc/network/interfaces. This prevents it from finding interfaces defined in /etc/network/interfaces.d. Please switch to use

Bug#816410: "/usr/share/mdadm/mkconf generate" can erase mdadm.conf if it encounters an error

2016-03-01 Thread Adam Heath
Package: mdadm Severity: important Version: 3.3.2-5+deb8u1 If you pass 'generate' to the mkconf script, it attempts to parse some existing values out of the file, then does an "exec >$CONFIG". At this point, the output file has been removed, and is effectively 0 bytes in size. All the

Bug#816409: /usr/share/mdadm/mkconf removes DEVICE settings

2016-03-01 Thread Adam Heath
Package: mdadm Severity: important Version: 3.3.2-5+deb8u1 If I specify a DEVICE line in mdadm.conf, /usr/share/mdadm/mkconf does *not* keep it; instead, the output file contains the DEVICE line prefixed with a comment character('#'). == root@virt-22:~# diff -u <(cat /etc/mdadm/mdadm.conf)

Bug#816406: mdadm mkconf doesn't parse mdadm.conf correctly(whitespace)

2016-03-01 Thread Adam Heath
Package: mdadm Severity: minor Version: 3.3.2-5+deb8u1 /usr/share/mdadm/mkconf attemps to read DEVICE out of /etc/mdadm/mdadm.conf, using sed. It does this, with a simple regex, "s/^DEVICE //p". This is not valid. mdadm.conf(5) says you can have any whitespace after it(space, tab, even

Re: git commit workflow for ofbiz

2015-05-12 Thread Adam Heath
Nice. This is quite thorough. There is an option missing. SVN committers who use git offline. In this case, their changes can be published as primary SVN branches, for collaboration.. See OFBIZ-6271 in JIRA, and as an SVN branch, for an example. I've read through most of what follows, and

Re: Java 8 and functional programming in trunk

2015-05-07 Thread Adam Heath
Not a reply to Jacques, but if an absolutely java-8-only feature is used, be sure to update the regex in ${ofbiz.home}/macros.xml, then the source/target values in common.xml in the same folder. ps: I'm fine with moving towards 1.8. It's not a choice that we can make, actually. On

Re: Addons for OFBiz

2015-05-07 Thread Adam Heath
On 05/07/2015 05:48 AM, Julien NICOLAS wrote: I see a lot of debate about adding new functionality that allow to improve development, compile, manage sources, merge with another framework, but the debate on the division of project extensions seems not to interest. It seems to me extremely

Re: Addons for OFBiz

2015-05-07 Thread Adam Heath
On 05/07/2015 11:02 AM, Jacopo Cappellato wrote: On May 7, 2015, at 5:32 PM, Adam Heath doo...@brainfood.com wrote: ... and Jacopo's own graphs have shown ofbiz in decline(namely, the number of commits to the project). I completely disagree with your analysis. Well, that's a wonderfully

Re: Addons for OFBiz

2015-05-07 Thread Adam Heath
On 05/07/2015 09:42 AM, Julien NICOLAS wrote: Hi Adam, I'm not talking about how to do it but to answer the question : is the community want to do it ? Is the community want to maintain only a framework and not an ERP ? Split the project in several part. Maven could be a solution, but

Re: survey: what version(s) of gradle are available on your systems?

2015-05-06 Thread Adam Heath
supported system? (http://gradle.org/docs/current/userguide/installation.html) Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 05.05.15 um 18:42 schrieb Adam Heath: I'm considering investigating gradle, but have discovered that it's not even available for debian wheezy(nor in backports

Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config: ProductEntityLabels.xml ProductErrorUiLabels.xml

2015-05-06 Thread Adam Heath
quick checked the size of the *UILabels.xml files, they are about 10.2 megs for all modules - not too much for today's servers with gigabytes of RAM. So I think it is not worth the effort... Michael Am 06.05.15 um 21:50 schrieb Adam Heath: Well, hmm. Nothing at all wrong with this change

Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config: ProductEntityLabels.xml ProductErrorUiLabels.xml

2015-05-06 Thread Adam Heath
Well, hmm. Nothing at all wrong with this change, but I'd like to discuss the pattern. So, the way alternative languages are implemented, is that if I am only concerned with *one* language, *all* languages have to be loaded in memory. Wouldn't it make more sense to split all these files

Re: survey: what version(s) of gradle are available on your systems?

2015-05-06 Thread Adam Heath
which combined takes most of the linux users base. Again maybe I missed something in the thread? Taher Alkhateeb - Original Message - From: Adam Heath doo...@brainfood.com To: dev@ofbiz.apache.org Sent: Wednesday, 6 May, 2015 5:57:56 PM Subject: Re: survey: what version(s) of gradle

Re: survey: what version(s) of gradle are available on your systems?

2015-05-06 Thread Adam Heath
On 05/06/2015 10:34 AM, Jacopo Cappellato wrote: On May 6, 2015, at 4:57 PM, Adam Heath doo...@brainfood.com wrote: On 05/06/2015 09:52 AM, Jacopo Cappellato wrote: On May 6, 2015, at 4:45 PM, Adam Heath doo...@brainfood.com wrote: Gradle has to be installed before building ofbiz, so you

Re: survey: what version(s) of gradle are available on your systems?

2015-05-06 Thread Adam Heath
On 05/06/2015 12:10 PM, Jacopo Cappellato wrote: On May 6, 2015, at 6:09 PM, Adam Heath doo...@brainfood.com wrote: That's bad too. By the way, Adam, you're as bitter as an old spinster today! :-) Just express issues we've had interacting with clients. It's all about placing blame

Re: survey: what version(s) of gradle are available on your systems?

2015-05-06 Thread Adam Heath
On 05/06/2015 09:52 AM, Jacopo Cappellato wrote: On May 6, 2015, at 4:45 PM, Adam Heath doo...@brainfood.com wrote: Gradle has to be installed before building ofbiz, so you couldn't use gradle to install gradle. And I'd prefer not to embed it directly. The Groovy project has some scripts

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-05-05 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528535#comment-14528535 ] Adam Heath commented on OFBIZ-6271: --- Um, do you fully understand maven

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-05-05 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528552#comment-14528552 ] Adam Heath commented on OFBIZ-6271: --- Hahaha. That guy is an idiot. Seriously. Don't

Re: Vote: move to git.

2015-05-05 Thread Adam Heath
That's my point as well. These most recent votes have not had concrete actions attached to them. Without a concrete plan, any kind of +# vote is not definitive; a +1 could mean anything in these cases. I chose +0 instead of -0 or -1, as I do believe git is the right approach, but we need

survey: what version(s) of gradle are available on your systems?

2015-05-05 Thread Adam Heath
I'm considering investigating gradle, but have discovered that it's not even available for debian wheezy(nor in backports). So, I currently interested in what other people have available for installation. In jessie, the version of gradle is 1.5.

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-05-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526790#comment-14526790 ] Adam Heath commented on OFBIZ-6271: --- What Jacques is asking about, are all the other non

Re: svn commit: r1677597 - in /ofbiz/trunk: .classpath LICENSE framework/base/lib/commons/commons-cli-1.2.jar macros.xml

2015-05-04 Thread Adam Heath
On 05/04/2015 12:29 PM, Jacopo Cappellato wrote: On May 4, 2015, at 6:36 PM, Adam Heath doo...@brainfood.com wrote: Why are antlr and asm removed, but not mentioned in the log? Antlr and asm jars were not removed, just the classpath entries for the groovy.class.path path id: the classes

Re: svn commit: r1677597 - in /ofbiz/trunk: .classpath LICENSE framework/base/lib/commons/commons-cli-1.2.jar macros.xml

2015-05-04 Thread Adam Heath
On 05/04/2015 08:36 AM, jaco...@apache.org wrote: Author: jacopoc Date: Mon May 4 13:36:09 2015 New Revision: 1677597 URL: http://svn.apache.org/r1677597 Log: Removed commons-cli jar that was not used: barcode4j has an optional dependency on it but only if used from the command line (which

Re: svn commit: r1677386 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/ObjectType.java

2015-05-04 Thread Adam Heath
Inline. On 05/03/2015 06:25 AM, adri...@apache.org wrote: Author: adrianc Date: Sun May 3 11:25:08 2015 New Revision: 1677386 URL: http://svn.apache.org/r1677386 Log: Trivial code cleanup in ObjectType.java - no functional change. Modified:

Re: Vote: move to git.

2015-05-04 Thread Adam Heath
This may be the nail in the coffin, at least for now, but +0, needs more discussion/planning. I've been using git-svn for longer than most with ofbiz, and would really love it if we were already using git, but it's just too soon. Just because git is decentralized, doesn't mean that there is

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-05-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527418#comment-14527418 ] Adam Heath commented on OFBIZ-6271: --- Yes, no, both. I want maven to be have the ability

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-05-04 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527421#comment-14527421 ] Adam Heath commented on OFBIZ-6271: --- I also struggled with moving the list of tasks from

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-05-01 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524204#comment-14524204 ] Adam Heath commented on OFBIZ-6271: --- Ok, quick update. Building a single component

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-30 Thread Adam Heath
On 04/30/2015 12:22 AM, Jacopo Cappellato wrote: On Apr 29, 2015, at 9:17 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: avalon-framework(4.2.0 in ofbiz) is no longer available. avalon.apache.org is closed(!). This was introduce with

Re: move to git.

2015-04-29 Thread Adam Heath
On 04/29/2015 02:26 PM, Jacques Le Roux wrote: Related to this thread but not with previous discussions, see how Github is used at the ASF https://wiki.apache.org/commons/UsingGIT ; notably for Applying Pull Requests (for svn based components) Jacques Yeah, that's actually troubling. The

off-topic: Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-29 Thread Adam Heath
On 04/29/2015 02:17 PM, Jacques Le Roux wrote: [snip] Finally Maven proved to be useful :) [snip] Everything always has at least one use; physical things can be paper weights; virtual things can take up disk space. jk

Re: Milestone redux: Re: svn commit: r1676613 - in /ofbiz/branches/OFBIZ-6271: assembly/LICENSE+NOTICE.xml framework/service/pom.xml pom.xml poms/assembly/ poms/assembly/LICENSE+NOTICE.xml poms/compon

2015-04-29 Thread Adam Heath
On 04/29/2015 01:34 AM, Hans Bakker wrote: ok is working fine on Ubuntu 14.04 and maven 3.0.5 Thanks Hans. It's nice knowning one's code is at least working for one other person. ps: I do remember that initial report of it not working on windows; I still haven't had time to try it there

Re: [jira] [Issue Comment Deleted] (OFBIZ-6271) build management with maven

2015-04-29 Thread Adam Heath
Components: ALL COMPONENTS Reporter: Adam Heath Priority: Minor This is a new build system; the primary goal will be to not require any changes to existing ofbiz layouts(for backwards compatibility, at least initially). These pom.xml files are completely new; the existing

[jira] [Commented] (OFBIZ-6271) build management with maven

2015-04-29 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519855#comment-14519855 ] Adam Heath commented on OFBIZ-6271: --- THANK YOU ADRIAN! So, this seems to work. All

Re: svn commit: r1676674 - in /ofbiz/trunk/framework/base: build.xml src/org/ofbiz/base/util/UtilMisc.java src/org/ofbiz/base/util/test/UtilMiscTests.java testdef/basetests.xml

2015-04-29 Thread Adam Heath
On 04/29/2015 01:10 AM, adri...@apache.org wrote: Author: adrianc Date: Wed Apr 29 06:10:01 2015 New Revision: 1676674 URL: http://svn.apache.org/r1676674 Log: Fixed a bug in UtilMisc.java where the List returned by the availableLocales() method included an empty Locale - causing errors in

Re: [DISCUSSION] Adding more flexibility to how widget elements - and others are referenced

2015-04-29 Thread Adam Heath
What you are looking to define here is relativeness. If a non-absolute path is found in a file, then resolve the full path against the absolute path of the file it was found in. I'm for this, btw. On 04/29/2015 05:02 AM, Pierre Smits wrote: Currently many widgets are referenced in other

Re: svn commit: r1676674 - in /ofbiz/trunk/framework/base: build.xml src/org/ofbiz/base/util/UtilMisc.java src/org/ofbiz/base/util/test/UtilMiscTests.java testdef/basetests.xml

2015-04-29 Thread Adam Heath
http://docs.oracle.com/javase/7/docs/api/java/util/Locale.html#getDisplayName() == depending on which fields are specified in the locale. If the language, sacript, country, and variant fields are all empty, this function returns the empty string. == I'd really like to know what locale

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-29 Thread Adam Heath
On 04/29/2015 01:39 AM, Jacques Le Roux wrote: Le 28/04/2015 16:42, Adam Heath a écrit : On 04/28/2015 03:39 AM, David E. Jones wrote: +1 - with the clarification that to me begin replacing implies a PoC effort in a branch. I just saw this thread and need a little time to think over

Re: Milestone: Re: svn commit: r1676405 - in /ofbiz/branches/OFBIZ-6271: applications/product/pom.xml pom.xml

2015-04-28 Thread Adam Heath
/hans/svn/OFBIZ-6271/ofbiz-component-pom.xml, line 23, column 11 - [Help 2] [ERROR] [Eand more On 28/04/15 09:15, Adam Heath wrote: With this commit, all optionally detected libraries/features during the compilation with ant are now being done with maven. A maven clean

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-28 Thread Adam Heath
On 04/28/2015 03:39 AM, David E. Jones wrote: +1 - with the clarification that to me begin replacing implies a PoC effort in a branch. I just saw this thread and need a little time to think over the best approach, but off the top of my head it would look something like: - add the

Re: Proposal: redefining the components' directory layout for source files

2015-04-28 Thread Adam Heath
On 04/28/2015 02:31 AM, Jacques Le Roux wrote: Le 27/04/2015 16:52, Adam Heath a écrit : On 04/27/2015 09:40 AM, Jacques Le Roux wrote: You can already compile components separately by using the specific build files Yeah, I know, and it's a pain in my side. I actually like being able

Re: Proposal: redefining the components' directory layout for source files

2015-04-28 Thread Adam Heath
On 04/28/2015 03:16 AM, Jacques Le Roux wrote: Le 24/04/2015 17:01, Adam Heath a écrit : On 04/24/2015 09:57 AM, Jacopo Cappellato wrote: On Apr 24, 2015, at 4:36 PM, Adam Heath doo...@brainfood.com wrote: src/main/java/org/ofbiz/product/ src/main/minilang/org/ofbiz/product/ src/main

Re: move to git.

2015-04-28 Thread Adam Heath
On 04/28/2015 03:39 AM, Jacques Le Roux wrote: Le 25/04/2015 01:14, Adam Heath a écrit : On 04/23/2015 06:00 PM, David E. Jones wrote: An FYI for all committers: create an account on GitHub (if you don't already have one) and add your @apache.org email address to it, and within a few hours

Re: Proposal: redefining the components' directory layout for source files

2015-04-28 Thread Adam Heath
On 04/28/2015 03:27 AM, Jacopo Cappellato wrote: On Apr 28, 2015, at 10:16 AM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: So you would like to suppress the concept of event? Most of the events are currently implemented in Java and are already under src folder. Not what I mean.

Re: Proposal: redefining the components' directory layout for source files

2015-04-28 Thread Adam Heath
On 04/28/2015 08:22 AM, Ron Wheeler wrote: On 28/04/2015 3:31 AM, Jacques Le Roux wrote: Le 27/04/2015 16:52, Adam Heath a écrit : On 04/27/2015 09:40 AM, Jacques Le Roux wrote: You can already compile components separately by using the specific build files Yeah, I know, and it's a pain

Re: Milestone: Re: svn commit: r1676405 - in /ofbiz/branches/OFBIZ-6271: applications/product/pom.xml pom.xml

2015-04-28 Thread Adam Heath
On 04/28/2015 10:17 AM, Ron Wheeler wrote: 1) is probably not a problem but it does make it harder to get support if you run into a bug that has already been fixed. I find it hard to imagine a reason to use a piece of software that is known to be defective when there are several newer

Milestone redux: Re: svn commit: r1676613 - in /ofbiz/branches/OFBIZ-6271: assembly/LICENSE+NOTICE.xml framework/service/pom.xml pom.xml poms/assembly/ poms/assembly/LICENSE+NOTICE.xml poms/component-

2015-04-28 Thread Adam Heath
Ok, let's try this again. == * rm -rf ~/.m2 * mvn clean * rm -rf ~/.m2 * mvn clean * mvn package -DskipTests * rm -rf ~/.m2 * mvn package -DskipTests * rm -rf ~/.m2 * mvn install -DskipTests == These are the scenarios I have tested. The final step copies all the artifacts into

Re: Proposal: redefining the components' directory layout for source files

2015-04-27 Thread Adam Heath
On 04/27/2015 09:40 AM, Jacques Le Roux wrote: You can already compile components separately by using the specific build files Yeah, I know, and it's a pain in my side. I actually like being able to *compile* each component separately, by changing to that folder, and running ant. I

Re: jira workflow

2015-04-27 Thread Adam Heath
On 04/27/2015 09:16 AM, Jacques Le Roux wrote: Thanks Adam for the very detailed workflow... answers inline, mostly about vocabulary :) ... Le 23/04/2015 07:56, Jacopo Cappellato a écrit : On Apr 22, 2015, at 10:07 PM, Adam Heath doo...@brainfood.com wrote: So, I've started attempting

Milestone: Re: svn commit: r1676405 - in /ofbiz/branches/OFBIZ-6271: applications/product/pom.xml pom.xml

2015-04-27 Thread Adam Heath
With this commit, all optionally detected libraries/features during the compilation with ant are now being done with maven. A maven clean and maven package -DskipTests is runnable with tools/startofbiz.sh. I have not run system integration tests(aka, any test that requires a running ofbiz

Sad commit: Re: svn commit: r1676303 - /ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java

2015-04-27 Thread Adam Heath
Replying to my own commit; please, double check your changes. The problems I fixed below are just sad. ps: I'm working on maven profiles, that detect optional jars. I went and fetched payflow.jar, and when I made it available, I got compile errors. On 04/27/2015 10:25 AM, doo...@apache.org

[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code

2015-04-27 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514269#comment-14514269 ] Adam Heath commented on OFBIZ-6217: --- And, be very very very careful about anything to do

[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code

2015-04-27 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514317#comment-14514317 ] Adam Heath commented on OFBIZ-6217: --- Don't use UtilGenerics.cast() on an external lib

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-26 Thread Adam Heath
On 04/26/2015 09:44 AM, Adrian Crum wrote: As was discussed last week, there is some interest in replacing some (or all) of OFBiz with Moqui (http://www.moqui.org/framework/index.html). To the scope reasonable, I propose that we begin by converting0 the following parts of the OFBiz framework

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-26 Thread Adam Heath
On 04/26/2015 02:27 PM, Adrian Crum wrote: No one is going to invest their time and effort in a POC unless they have the approval and support of the community. I don't think you're going to see a POC before a vote. I would.

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-26 Thread Adam Heath
On 04/26/2015 06:13 PM, Adam Heath wrote: On 04/26/2015 02:27 PM, Adrian Crum wrote: No one is going to invest their time and effort in a POC unless they have the approval and support of the community. I don't think you're going to see a POC before a vote. I would. I haven't yet looked

Re: VOTE: Begin Replacing OFBiz Framework With Moqui

2015-04-26 Thread Adam Heath
Begin replacing ... is not an actional item. How can we vote on something that is ill-defined? Just saying. On 04/26/2015 08:09 PM, Ron Wheeler wrote: +1 for being too early. -1 for going ahead as a project +1 for a PoC and impact analysis Ron On 26/04/2015 6:46 PM, Pierre Smits wrote:

Re: move to git.

2015-04-24 Thread Adam Heath
On 04/23/2015 06:00 PM, David E. Jones wrote: An FYI for all committers: create an account on GitHub (if you don't already have one) and add your @apache.org email address to it, and within a few hours you'll show up in the contributor graphs. I tried this and am now showing up there:

[jira] [Assigned] (OFBIZ-6300) Compiler-Error with JDK 1.8 and source compatibility 1.8

2015-04-24 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath reassigned OFBIZ-6300: - Assignee: Adam Heath Compiler-Error with JDK 1.8 and source compatibility 1.8

Re: Proposal: redefining the components' directory layout for source files

2015-04-24 Thread Adam Heath
+0.5 (see below, comment inline) Yes, I agree. I even have a way forward, if you've been paying attention to the maven branch(OFBIZ-6271). I have maven working with the *existing* layout in ofbiz. My plan for migration has been this: * Get maven working with existing structure. Ie, maven

java 1.8 features: Re: [jira] [Commented] (OFBIZ-6298) Java collection use optimized

2015-04-24 Thread Adam Heath
Not putting this into the jira issue, as it's not related, but with java 1.8, construction of generic objects is nicer. == MapString, ListMapString, Object myVar = new HashMap(); ==

Re: Maven and Git providing build into at run-time

2015-04-24 Thread Adam Heath
On 04/24/2015 07:45 AM, Ron Wheeler wrote: An interesting article about how git and Maven can be used to automatically make the build revision and other info available at run-time for logging or display in an About display. The top-level build.xml has a rule to update the svn build

Re: Proposal: redefining the components' directory layout for source files

2015-04-24 Thread Adam Heath
On 04/24/2015 10:05 AM, Ron Wheeler wrote: +1 Looks like Adam has the right approach. Thanks. However, I'm thinking of adding a few steps. See below. Ron On 24/04/2015 10:36 AM, Adam Heath wrote: +0.5 (see below, comment inline) Yes, I agree. I even have a way forward, if you've been

[jira] [Commented] (OFBIZ-6300) Compiler-Error with JDK 1.8 and source compatibility 1.8

2015-04-24 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511204#comment-14511204 ] Adam Heath commented on OFBIZ-6300: --- I have been getting additional generics warnings

Re: Proposal: redefining the components' directory layout for source files

2015-04-24 Thread Adam Heath
On 04/24/2015 09:57 AM, Jacopo Cappellato wrote: On Apr 24, 2015, at 4:36 PM, Adam Heath doo...@brainfood.com wrote: src/main/java/org/ofbiz/product/ src/main/minilang/org/ofbiz/product/ src/main/groovy/... src/test/java/org/ofbiz/product/ I haven't yet gotten to integrating a groovy

Re: svn commit: r1672752 [7/18] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/agreement/ applications/accounting/src/org/ofbiz/accounting/finaccount/ applications/accounting/src/

2015-04-24 Thread Adam Heath
This is an example of why having a HUGE commit is wrong. This problem listed below was not discovered, because there were too many changes to review. My maven branch at OFBIZ-6271 is doing things in a much better way. ps: I discovered this because I am attempting to compile each and every

Re: move to git.

2015-04-23 Thread Adam Heath
On 04/23/2015 04:22 AM, Scott Gray wrote: I'm just saying my current project has been using it for 18 months and it's been a long time now since we've lost any changes. This is 15-30 devs that were all new to git. In my experience most issues come from: - Reverting merge commits and picking

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509305#comment-14509305 ] Adam Heath commented on OFBIZ-6291: --- int i = foo... isn't the part that is slower

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509267#comment-14509267 ] Adam Heath commented on OFBIZ-6291: --- * The patch introduces new blank lines; that should

Re: Fwd: Re: Maven

2015-04-23 Thread Adam Heath
As for deploying of artifacts, I've already done a mvn install locally, which copies the built files into $HOME/.m2/; so I know that eventually when everything is done, we could deploy into the global shared repo. On 04/22/2015 09:03 PM, Ron Wheeler wrote: Just to let everyone know that we

Re: move to git.

2015-04-23 Thread Adam Heath
On 04/23/2015 03:28 AM, Scott Gray wrote: I am thoroughly familiar with Git. Git always screws things up. If git always screwed things up, then those other 3 projects wouldn't be using it. ps: I realize this was a quote from Adrian, and not Scott. These two statements are complete

Re: move to git.

2015-04-23 Thread Adam Heath
On 04/23/2015 06:00 PM, David E. Jones wrote: An FYI for all committers: create an account on GitHub (if you don't already have one) and add your @apache.org email address to it, and within a few hours you'll show up in the contributor graphs. I tried this and am now showing up there:

Re: svn commit: r1675762 - in /ofbiz/branches/OFBIZ-6271/framework: base/pom.xml catalina/pom.xml entity/pom.xml geronimo/pom.xml

2015-04-23 Thread Adam Heath
Replying to my own commit; this is a major milestone, as mentioned in the commit log. Internal and external components can still make use of the wildcard includes on the lib folders; there is no current example in this branch that shows this, however. Once all this conversion is done, the

[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507350#comment-14507350 ] Adam Heath commented on OFBIZ-6290: --- [javac17] /srv/ofbiz/apache-git/specialpurpose

[jira] [Created] (OFBIZ-6289) Oagis classes are making use of the deprecated html rendering system

2015-04-22 Thread Adam Heath (JIRA)
Adam Heath created OFBIZ-6289: - Summary: Oagis classes are making use of the deprecated html rendering system Key: OFBIZ-6289 URL: https://issues.apache.org/jira/browse/OFBIZ-6289 Project: OFBiz

[jira] [Commented] (OFBIZ-6289) Oagis classes are making use of the deprecated html rendering system

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507321#comment-14507321 ] Adam Heath commented on OFBIZ-6289: --- [javac17] /srv/ofbiz/apache-git/specialpurpose

[jira] [Created] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated

2015-04-22 Thread Adam Heath (JIRA)
Adam Heath created OFBIZ-6290: - Summary: ButtonEventConfig uses getXmlRootElement which has been deprecated Key: OFBIZ-6290 URL: https://issues.apache.org/jira/browse/OFBIZ-6290 Project: OFBiz

Re: [jira] [Created] (OFBIZ-6275) OFBiz code seems make use of other deprecated OFBiz features

2015-04-22 Thread Adam Heath
Ok, all issues created. Hang back a bit before anyone starts taking ownership of stuff, I've need to make time to commit the ones I've already got fixed. On 04/22/2015 10:11 AM, Adam Heath wrote: I've got some changes already for the sub-tasks I will be filing shortly; as before, a separate

[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507330#comment-14507330 ] Adam Heath commented on OFBIZ-6270: --- Because I plan on also adding test cases(which were

[jira] [Commented] (OFBIZ-6289) Oagis classes are making use of the deprecated html rendering system

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507342#comment-14507342 ] Adam Heath commented on OFBIZ-6289: --- These need to be switched to a macro system

[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507352#comment-14507352 ] Adam Heath commented on OFBIZ-6290: --- Same problem, don't use a cached version

[jira] [Created] (OFBIZ-6276) Fix deprecation issues in framework/entity

2015-04-22 Thread Adam Heath (JIRA)
Adam Heath created OFBIZ-6276: - Summary: Fix deprecation issues in framework/entity Key: OFBIZ-6276 URL: https://issues.apache.org/jira/browse/OFBIZ-6276 Project: OFBiz Issue Type: Sub-task

[jira] [Assigned] (OFBIZ-6278) JNDIConfigUtil makes use of deprecated getXmlRootElement

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath reassigned OFBIZ-6278: - Assignee: Adam Heath JNDIConfigUtil makes use of deprecated getXmlRootElement

[jira] [Created] (OFBIZ-6278) JNDIConfigUtil makes use of deprecated getXmlRootElement

2015-04-22 Thread Adam Heath (JIRA)
Adam Heath created OFBIZ-6278: - Summary: JNDIConfigUtil makes use of deprecated getXmlRootElement Key: OFBIZ-6278 URL: https://issues.apache.org/jira/browse/OFBIZ-6278 Project: OFBiz Issue Type

[jira] [Commented] (OFBIZ-6281) Many classes in framework/widget are still using html-based renderers, instead of macro-based

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507256#comment-14507256 ] Adam Heath commented on OFBIZ-6281: --- [javac17] /srv/ofbiz/apache-git/framework/widget

[jira] [Updated] (OFBIZ-6278) JNDIConfigUtil makes use of deprecated getXmlRootElement

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-6278: -- Priority: Minor (was: Major) JNDIConfigUtil makes use of deprecated getXmlRootElement

[jira] [Updated] (OFBIZ-6279) UtilDateTime has an ImmutableDate inner class that has deprecation warnings

2015-04-22 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Heath updated OFBIZ-6279: -- Component/s: framework UtilDateTime has an ImmutableDate inner class that has deprecation warnings

  1   2   3   4   5   6   7   8   9   10   >