[Bug ld/29823] ld riscv: undefined elf_backend_obj_attrs_handle_unknown causes segfault when merging .riscv.attributes

2024-04-26 Thread paulkirth at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29823 Paul Kirth changed: What|Removed |Added CC||paulkirth at google dot com --- Comment

RE: upload conversion adjustment not throwing partialfailureerrors

2024-04-26 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Conversions and adjustments are all processed offline, so the API call may succeed but that doesn't indicate a successful payload like the way you are trying to test it. You can use the instructions at https://developers.google.com/google-ads/api/docs/conversions/upload-summaries

RE: does the api compliance team even exist? are they dead?

2024-04-26 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi Josh, Thank you for reaching out to the Google Ads API support team. After reviewing your concern, I understand that you have applied for API access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API Compliance team

Re: [PATCH] kernel/trace/trace_probe:Fixed memory leak issues in trace_probe.c.

2024-04-26 Thread Google
goto fail; > } > snprintf(parg->fmt, len, "%s[%d]", parg->type->fmttype, >parg->count); > -- > 2.25.1 > -- Masami Hiramatsu (Google)

Re: [PATCH 0/2] Objpool performance improvements

2024-04-26 Thread Google
> > include/linux/objpool.h | 105 +++-- > lib/objpool.c | 112 +++- > 2 files changed, 107 insertions(+), 110 deletions(-) > > -- > 2.43.0 > -- Masami Hiramatsu (Google)

Re: the standard access request has been in process for an extended period without a response

2024-04-26 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
with below details. Summary: The user has applied for API access with the below details. Google Ads Manager Account (MCC) ID: 983-980-6107 Cases ID: 3-375335326 Access type: Standard access Kindly note that access related issues are handled by the Google Ads API Compliance team

Re: make sure you agree to the customer data processing terms in conversion settings and try again., at conversion_adjustments[0]

2024-04-26 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hello, Not yet. I will continue to monitor our team's progress and let you know when I have any information to share. This message is in relation to case "ref:!00D1U01174p.!5004Q02tOvHd:ref" (ADR-00230310) Thanks, Michael Cloonan Google Ad

Re: Setting or Retrieving Campaign Goal through Adwords API

2024-04-25 Thread 'Vatsal Chandra' via Google Ads API and AdWords API Forum
Hi team. Is setting campaign goal (conversion goals) via API now available ? I am creating campaigns via API, but do not see an option to select the conversion/campaign goal, and it takes account default conversion/campaign goal. On Tuesday, March 30, 2021 at 8:07:49 AM UTC+5:30 Google Ads

RE: requesting convert basic access token to standard access token

2024-04-25 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. After reviewing your concern, I understand that you have applied for basic access and haven’t received any response. Since the access requests are handled by the Google Ads API Compliance team, we are transferring the case

Re: [PATCH v9 00/36] tracing: fprobe: function_graph: Multi-function graph and fprobe on fgraph

2024-04-25 Thread Google
is quite a refactoring :) > > On Mon, Apr 15, 2024 at 2:49 PM Masami Hiramatsu (Google) > wrote: > > > > Hi, > > > > Here is the 9th version of the series to re-implement the fprobe on > > function-graph tracer. The previous version is; > > > >

Re: image extensions not linking through asset link

2024-04-25 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. The error "UNSUPPORTED_FIELD_TYPE", this means the given field type is not supported to be added directly through asset links. Kindly note that image extension as an asset is not supported in the Goog

RE: how to create ad rules using the google api

2024-04-25 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I see that you have already raised this concern on another thread with the subject "Rule problem" and we have already responded there for this issue. To avoid multiple threads on the same issue, please t

RE: how do you create rules using the google ad api

2024-04-25 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I see that you have already raised this concern on another thread with the subject "Rule problem" and we have already responded there for this issue. To avoid multiple threads on the same issue, please t

RE: rule problem

2024-04-25 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. Kindly note that 'Automated rules' are not yet supported in the Google Ads API. I will raise a request to add this feature to be available in the Google Ads API. We cannot provide a scheduled timeline for the availability

RE: didn't get response for apply for basic access - developer token

2024-04-24 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I understand that you have applied for API access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API Compliance team, we are transferring the case

Re: [PATCH v9 01/36] tracing: Add a comment about ftrace_regs definition

2024-04-24 Thread Google
On Wed, 24 Apr 2024 15:19:24 +0200 Florent Revest wrote: > On Wed, Apr 24, 2024 at 2:23 PM Florent Revest wrote: > > > > On Mon, Apr 15, 2024 at 2:49 PM Masami Hiramatsu (Google) > > wrote: > > > > > > From: Masami Hiramatsu (Google) > > > >

Re: google ads api header_error: invalid_login_customer_id

2024-04-24 Thread 'Deb' via Google Ads API and AdWords API Forum
Thank you all. The dashes in the ID was indeed the issue. I am able to push the mutations successfully now. On Tuesday, April 23, 2024 at 10:44:47 AM UTC-4 Google Ads API Forum Advisor wrote: > Hi, > > Thank you for your input on the issue. > > This message is in relation

RE: how to add imges or video to ad group

2024-04-24 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. >From the provided sample code, I could see that you are getting the error >"UNSUPPORTED_FIELD_TYPE". This means that the field type 'MARKETING_IMAGE' is >not supported to be added directly through asset

RE: anyone changed to basic access ?

2024-04-24 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I understand that you have applied for API access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API Compliance team, we are transferring the case

RE: didn't get response for apply for basic access - developer token

2024-04-24 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I understand that you have applied for API access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API Compliance team, we are transferring the case

RE: add images to ad group?

2024-04-24 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I see that you have already raised this concern on another thread with the subject 'How to link a exit asset (imgage or video) to exist ad group', and we have already responded there for this issue. To avoid multiple threads

RE: unable to connect to google ads account

2024-04-23 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for contacting the Google Ads API support team. I can see in the system that you have previously raised this concern on another thread with the subject 'Unable to connect to google ads account using oauth credentials', and it has already been responded to. To avoid multiple

RE: google ads api header_error: invalid_login_customer_id

2024-04-23 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for your input on the issue. This message is in relation to case "ref:!00D1U01174p.!5004Q02tPHgL:ref" (ADR-00232263) Thanks, Google Ads API Team -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find us on our blog: https://googleadsdeveloper.bl

RE: standard api access - no response in nearly a month

2024-04-23 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi Judy, Thank you for reaching out to the Google Ads API support team. After reviewing your concern, I understand that you have applied for Standard API access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API

RE: google ads api token application basic access status

2024-04-23 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. The access requests are handled by the Google Ads API Compliance team, we are transferring the case to the Ads API Compliance team. Can you kindly provide the following information for the compliance team to further assist you

Re: unable to extract paused data from google ads using api call

2024-04-23 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
flag. This message is in relation to case "ref:!00D1U01174p.!5004Q02tPGji:ref" (ADR-00231983) Thanks, Google Ads API Team -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find us on our blog: https://googleadsdeveloper.bl

Re: [PATCH 1/2] tracing/user_events: Fix non-spaced field matching

2024-04-22 Thread Google
r is copied from user > to kernel, so it cannot change (and no other threads access it). I also > checked trace_parse_run_command() which is the same. So at least in this > context the non-atomic part is OK. Oh, sorry if I scared you. I've seen bugs get introduced into loops like this many times (while updating the code), so I try to keep it simple. I'm sure that your code has no bugs. Thank you, -- Masami Hiramatsu (Google)

Re: How do I collect spend data by campaign data by country?

2024-04-22 Thread 'Dmitrii Bevz' via Google Ads API and AdWords API Forum
all performance, seems like a lot of segment.date are > just missing > -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find us on our blog: https://googleadsdeveloper.blogspot.com/ =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ You received this message because you are subscribed to the Google Groups "AdWords A

Re: [PATCH v2] uprobes: reduce contention on uprobes_tree access

2024-04-22 Thread Google
_list(struct inode *inode, > get_uprobe(u); > } > } > - spin_unlock(_treelock); > + read_unlock(_treelock); > } > > /* @vma contains reference counter, not the probed instruction. */ > @@ -1407,9 +1407,9 @@ vma_has_uprobes(struct vm_area_struct *vma, unsigned > long start, unsigned long e > min = vaddr_to_offset(vma, start); > max = min + (end - start) - 1; > > - spin_lock(_treelock); > + read_lock(_treelock); > n = find_node_in_range(inode, min, max); > - spin_unlock(_treelock); > + read_unlock(_treelock); > > return !!n; > } > -- > 2.43.0 > -- Masami Hiramatsu (Google)

Re: [PATCH v2] uprobes: reduce contention on uprobes_tree access

2024-04-22 Thread Google
d - start) - 1; > > > > - spin_lock(_treelock); > > + read_lock(_treelock); > > n = find_node_in_range(inode, min, max); > > if (n) { > > for (t = n; t; t = rb_prev(t)) { > > @@ -1316,7 +1316,7 @@ static void build_probe_list(struct inode *inode, > > get_uprobe(u); > > } > > } > > - spin_unlock(_treelock); > > + read_unlock(_treelock); > > } > > > > /* @vma contains reference counter, not the probed instruction. */ > > @@ -1407,9 +1407,9 @@ vma_has_uprobes(struct vm_area_struct *vma, unsigned > > long start, unsigned long e > > min = vaddr_to_offset(vma, start); > > max = min + (end - start) - 1; > > > > - spin_lock(_treelock); > > + read_lock(_treelock); > > n = find_node_in_range(inode, min, max); > > - spin_unlock(_treelock); > > + read_unlock(_treelock); > > > > return !!n; > > } > > -- > > 2.43.0 > > > -- Masami Hiramatsu (Google)

Re: [PATCHv3 bpf-next 0/7] uprobe: uretprobe speed up

2024-04-22 Thread Google
d! I reviewed the series and just except for the manpage, it looks good to me. Reviewed-by: Masami Hiramatsu (Google) for the series. If Linux API maintainers are OK, I can pick this in probes/for-next. (BTW, who will pick the manpage patch?) Thank you, > > v3 changes: > - adde

Re: [PATCH 7/7] man2: Add uretprobe syscall page

2024-04-22 Thread Google
NOTES > +.BR uretprobe() > +exists only to allow the invocation of return uprobe consumers. > +It should > +.B never > +be called directly. > +Details of the arguments (if any) passed to > +.BR uretprobe () > +and the return value are specific for given architecture. > -- > 2.44.0 > -- Masami Hiramatsu (Google)

Re: [PATCH v5 14/15] kprobes: remove dependency on CONFIG_MODULES

2024-04-22 Thread Google
n non-modular kernels. > > Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside > modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the > dependency of CONFIG_KPROBES on CONFIG_MODULES. Looks good to me. Acked-by: Masami Hiramatsu (Google) Thank y

Re: [PATCH v5 14/15] kprobes: remove dependency on CONFIG_MODULES

2024-04-22 Thread Google
n non-modular kernels. > > Add #ifdef CONFIG_MODULE guards for the code dealing with kprobes inside > modules, make CONFIG_KPROBES select CONFIG_EXECMEM and drop the > dependency of CONFIG_KPROBES on CONFIG_MODULES. Looks good to me. Acked-by: Masami Hiramatsu (Google) Thank y

Re: gaql for account level ip exclusion list

2024-04-22 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
and features.. This message is in relation to case "ref:!00D1U01174p.!5004Q02s0HaN:ref" (ADR-00228946) Thanks, Google Ads API Team -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find us on our blog: https://googleadsdeveloper.bl

RE: is it, campaignconversiongoalservice mutate, available in the api now?

2024-04-22 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. Yes, the CampaignConversionGoalService is available in the Google Ads API. You may refer to the Campaign goals document for more details. Also, you may check the CampaignConversionGoalOperation, where you can perform a single

RE: hi team

2024-04-22 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I understand that the list_accessible_customers function is taking too long to obtain the complete tree. A large inheritance hierarchy can definitely contribute to slow loading times when retrieving the entire account structure

RE: google ads api header_error: invalid_login_customer_id

2024-04-22 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I understand that you have encountered the error "INVALID_CUSTOMER_ID." It means that the provided customer ID is invalid. In order to replicate the issue from our end, provide us with the complete API log

Sign in to your Google Account

2024-04-22 Thread Google
dSR-pYTCjUty7iA8JvilAzPqhxNZNVCJqagdu1yitIQj4cLtaJ3__xUi0=354> it. [image: Google] Sign in to your Google Account pmg...@wanadoo.es You're receiving this message because your Google Account has not been used in at least 8 months. If you want to keep your Google Account, sign in to it before *December 17, 2024*. Take a

Re: Campaign creation options

2024-04-22 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
this guide on Campaign goals for more information. But setting the goal type for campaigns is not supported through the API. This message is in relation to case "ref:!00D1U01174p.!5004Q02ZIqWs:ref" (ADR-00100033) Thanks, Google Ad

Search Api Request Stop

2024-04-21 Thread 'JIHoon Ock' via Google Ads API and AdWords API Forum
Hello. Your request was stopped while using the Google Search API. No error occurred and logging was stopped. If you try again, it's requested normally, but we need Batch every day. I also used the timeout function, but it's not working properly. Was there anything I misused? Code

Re: basic api access - no response in two week

2024-04-21 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for providing the requested information. As informed earlier, since the access requests are handled by the Google Ads API Compliance team, we are transferring the case to the Ads API Compliance team. @Compliance team, please confirm if you are able to assist in the below access

Google Ads API header_error: INVALID_LOGIN_CUSTOMER_ID

2024-04-21 Thread 'Deb' via Google Ads API and AdWords API Forum
etc. Does anyone know what this error means? -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find us on our blog: https://googleadsdeveloper.blogspot.com/ =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ You received this message because you are subscribed to the Google Groups "AdWords API and

Re: [PATCH v4 2/2] rethook: honor CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING in rethook_try_get()

2024-04-20 Thread Google
Thanks for update! This looks good to me. > > Thanks, Masami! Will you take it through your tree, or you'd like to > route it through bpf-next? OK, let me take it through linux-trace tree. Thank you! > > > > > Acked-by: Masami Hiramatsu (Google) > > &

Re: [PATCH 1/2] tracing/user_events: Fix non-spaced field matching

2024-04-20 Thread Google
Ah, nevermind. Synthetic event parses the field by strsep(';') first and argv_split(). So it does not have this issue. Thank you, > > Thanks, > -Beau > > > > + /* We must fixup 'field;field' to 'field; field' */ > > > + char *fixed = fix_semis_no_space(args, count); > > > + char **split; > > > + > > > + if (!fixed) > > > + return NULL; > > > + > > > + /* We do a normal split afterwards */ > > > + split = argv_split(GFP_KERNEL, fixed, argc); > > > + > > > + /* We can free since argv_split makes a copy */ > > > + kfree(fixed); > > > + > > > + return split; > > > + } > > > + > > > + /* No fixup is required */ > > > + return argv_split(GFP_KERNEL, args, argc); > > > +} > > > + > > > /* > > > * Parses the event name, arguments and flags then registers if > > > successful. > > > * The name buffer lifetime is owned by this method for success cases > > > only. > > > @@ -2012,7 +2098,7 @@ static int user_event_parse(struct user_event_group > > > *group, char *name, > > > return -EPERM; > > > > > > if (args) { > > > - argv = argv_split(GFP_KERNEL, args, ); > > > + argv = user_event_argv_split(args, ); > > > > > > if (!argv) > > > return -ENOMEM; > > > -- > > > 2.34.1 > > > > > > > > > -- > > Masami Hiramatsu (Google) -- Masami Hiramatsu (Google)

Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES

2024-04-20 Thread Google
NG) { > ... > } > > so moving out 'enum module_state' won't be enough. Hmm, this part should be inline functions like; #ifdef CONFIG_MODULES static inline bool module_is_coming(struct module *mod) { return mod->state == MODULE_STATE_COMING; } #else #define module_is_coming(mod) (false) #endif Then we don't need the enum. Thank you, > > > > > > >> -- > > >> Masami Hiramatsu > > > > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google)

Re: [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES

2024-04-20 Thread Google
NG) { > ... > } > > so moving out 'enum module_state' won't be enough. Hmm, this part should be inline functions like; #ifdef CONFIG_MODULES static inline bool module_is_coming(struct module *mod) { return mod->state == MODULE_STATE_COMING; } #else #define module_is_coming(mod) (false) #endif Then we don't need the enum. Thank you, > > > > > > >> -- > > >> Masami Hiramatsu > > > > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google)

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-20 Thread Google
module_alloc(). However, if an architecture only supports breakpoint/trap based kprobe, it does not need to consider whether the execmem is allocated. > > We can always share large ROX pages as long as they are within the correct > address space. The permissions for them are ROX and the alignment > differences are due to KASAN and this is handled during allocation of the > large page to refill the cache. __execmem_cache_alloc() only needs to limit > the search for the address space of the range. So I don't think EXECMEM_KPROBE always same as EXECMEM_MODULE_TEXT, it should be configured for each arch. Especially, if it is only used for searching parameter, it looks OK to me. Thank you, > > And regardless, they way we deal with sharing of the cache can be sorted > out later. > > > Thanks, > > Song > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google)

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-20 Thread Google
module_alloc(). However, if an architecture only supports breakpoint/trap based kprobe, it does not need to consider whether the execmem is allocated. > > We can always share large ROX pages as long as they are within the correct > address space. The permissions for them are ROX and the alignment > differences are due to KASAN and this is handled during allocation of the > large page to refill the cache. __execmem_cache_alloc() only needs to limit > the search for the address space of the range. So I don't think EXECMEM_KPROBE always same as EXECMEM_MODULE_TEXT, it should be configured for each arch. Especially, if it is only used for searching parameter, it looks OK to me. Thank you, > > And regardless, they way we deal with sharing of the cache can be sorted > out later. > > > Thanks, > > Song > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google)

Re: [PATCH v9 07/36] function_graph: Allow multiple users to attach to function graph

2024-04-20 Thread Google
On Fri, 19 Apr 2024 23:52:58 -0400 Steven Rostedt wrote: > On Mon, 15 Apr 2024 21:50:20 +0900 > "Masami Hiramatsu (Google)" wrote: > > > @@ -27,23 +28,157 @@ > > > > #define FGRAPH_RET_SIZE sizeof(struct ftrace_ret_stack) > > #define FGRAPH_RET

RE: no response for basic developer access

2024-04-19 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. After reviewing your concern, I understand that you have applied for API basic access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API Compliance team

Re: upload offline conversion using gbraid parameter with upload_offline_conversion.py

2024-04-19 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
to case "ref:!00D1U01174p.!5004Q02tPCLY:ref" (ADR-00231620) Thanks, Google Ads API Team -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find us on our blog: https://googleadsdeveloper.blogspot.com/ =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ You received this messa

Re: issues of enhancement conversion

2024-04-19 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
that we can check the nature of the respective conversion action from our end and assist you accordingly. This message is in relation to case "ref:!00D1U01174p.!5004Q02tP3cf:ref" (ADR-00230909) Thanks, Google Ads API Team -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find

Re: make sure you agree to the customer data processing terms in conversion settings and try again., at conversion_adjustments[0]

2024-04-19 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, I will check with our team regarding your issue and one of my team members will reach out to you once we have an update on this. Meanwhile, your patience is highly appreciated. This message is in relation to case "ref:!00D1U01174p.!5004Q02tOvHd:ref" (ADR-00230310) Thanks, Goog

RE: metrics costperallconversions

2024-04-19 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I understand that you need information regarding the cost metrics from the Google Ads API. The metrics.cost_micros and metrics.average_cost in the campaign report should be able to get cost metrics in the Google Ads API. Note

Re: [PATCH v9 00/36] tracing: fprobe: function_graph: Multi-function graph and fprobe on fgraph

2024-04-18 Thread Google
Hi Steve, Can you review this series? Especially, [07/36] and [12/36] has been changed a lot from your original patch. Thank you, On Mon, 15 Apr 2024 21:48:59 +0900 "Masami Hiramatsu (Google)" wrote: > Hi, > > Here is the 9th version of the series to re-implement the f

Re: [PATCH 1/2] tracing/user_events: Fix non-spaced field matching

2024-04-18 Thread Google
v_split(GFP_KERNEL, args, argc); > +} > + > /* > * Parses the event name, arguments and flags then registers if successful. > * The name buffer lifetime is owned by this method for success cases only. > @@ -2012,7 +2098,7 @@ static int user_event_parse(struct user_event_group > *group, char *name, > return -EPERM; > > if (args) { > - argv = argv_split(GFP_KERNEL, args, ); > + argv = user_event_argv_split(args, ); > > if (!argv) > return -ENOMEM; > -- > 2.34.1 > -- Masami Hiramatsu (Google)

Re: [PATCH v4 2/2] rethook: honor CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING in rethook_try_get()

2024-04-18 Thread Google
which rely on rethook) runtime throughput > by 2.3%, according to BPF benchmarks ([0]). > > [0] > https://lore.kernel.org/bpf/caef4bzauq2wkmjzdc9s0rbwa01bybgwhn6andxqshyia47p...@mail.gmail.com/ > > Signed-off-by: Andrii Nakryiko Thanks for update! This looks good to m

Re: [PATCH] uprobes: reduce contention on uprobes_tree access

2024-04-18 Thread Google
> > > > > > > - spin_lock(_treelock); > > > > > > > > > > > > + write_lock(_treelock); > > > > > > > > > > > > u = __insert_uprobe(uprobe); > > > > > > > > > > > > - spin_unlock(_tr

Re: issues of enhancement conversion

2024-04-18 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, As you mentioned changed to “cross-account conversion management customer," kindly note that the google_ads_conversion_customer field indicates the Google Ads account that creates and manages conversions for this customer. For customers using cross-account conversion tra

RE: upload offline conversion using gbraid parameter with upload_offline_conversion.py

2024-04-18 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. It takes up to 3 hours for imported conversion statistics to appear in your Google Ads account for last-click attribution. For other search attribution models, it can take longer than 3 hours. I would suggest you refer

Re: developer token is missing in the rest interface

2024-04-18 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, It seems you have missed our last update regarding this issue. I would recommend you to add “?Concierge__enable_concierge=false” at the end of the url to get the developer token input field. For instance, https://developers.google.com/google-ads/api/rest/reference/rest/v16

RE: mismatched metrics on smart_campaign_search_term_view and smart campaign campaign query

2024-04-18 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. To double check, is your issue that you are observing a discrepancy between the data from the smart_campaign_search_term_view and the campaign reports? If yes, then note that: The smart_campaign_search_term_view focuses

Re: make sure you agree to the customer data processing terms in conversion settings and try again., at conversion_adjustments[0]

2024-04-18 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Kindly note that the CONVERSION_ACTION_NOT_ELIGIBLE_FOR_ENHANCEMENT error occurs when the conversion_action supplied in the request is not eligible for enhanced conversions for web. In the Google Ads UI, make sure you check the 'Turn on enhanced conversions' box on the conversion action

Re: no response for basic api access

2024-04-18 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, ++@Compliance team, please assist the user with the API - Basic access request. Summary: The user has applied for basic access with the below details. Google Ads Manager Account (MCC) ID: 228-308-0994 Cases ID: requested ( user said Not Received) Do reach out to the Google Ads API

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-17 Thread Google
l be used to identify the calling subsystem and to > allow architectures define parameters for ranges suitable for that > subsystem. > This looks good to me for the kprobe part. Acked-by: Masami Hiramatsu (Google) Thank you, > Signed-off-by: Mike Rapoport (IBM) > --- > arc

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-17 Thread Google
l be used to identify the calling subsystem and to > allow architectures define parameters for ranges suitable for that > subsystem. > This looks good to me for the kprobe part. Acked-by: Masami Hiramatsu (Google) Thank you, > Signed-off-by: Mike Rapoport (IBM) > --- > arc

Re: [PATCH for-next v2] tracing/kprobes: Add symbol counting check when module loads

2024-04-17 Thread Google
Sorry, this is actually v3. (miss-configured...) Thanks, On Thu, 18 Apr 2024 05:46:34 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Currently, kprobe event checks whether the target symbol name is unique > or not, so that i

[PATCH for-next v2] tracing/kprobes: Add symbol counting check when module loads

2024-04-17 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Currently, kprobe event checks whether the target symbol name is unique or not, so that it does not put a probe on an unexpected place. But this skips the check if the target is on a module because the module may not be loaded. To fix this issue, this patch

Re: [PATCH for-next v2] tracing/kprobes: Add symbol counting check when module loads

2024-04-17 Thread Google
On Tue, 16 Apr 2024 00:47:26 -0400 Steven Rostedt wrote: > On Mon, 15 Apr 2024 18:40:23 +0900 > "Masami Hiramatsu (Google)" wrote: > > > Check the number of probe target symbols in the target module when > > the module is loaded. If the probe is not on the unique

Re: no response for basic api access

2024-04-17 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, As the access requests are managed by the Google Ads API Compliance team, I'm looping them back to this thread for further assistance. @Compliance team, Could you please assist the user on this access request. This message is in relation to case "ref:!00D1U01174p.!5004Q02tP5jJ:ref&q

Re: the standard access request has been in process for an extended period without a response

2024-04-17 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, @Compliance team, please confirm if you are able to assist in the below access request. Summary: The user has applied for the standard access with the below details. Google Ads Manager Account (MCC) ID: 983-980-6107 Case ID: 3-375335326 Do reach out to the Google Ads API support

Re: exponential/scientific notation for duoble fields

2024-04-17 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hello, Not yet. I've pinged them yet again and will update here if I hear back. This message is in relation to case "ref:!00D1U01174p.!5004Q02rz8dC:ref" (ADR-00223425) Thanks, Michael Cloonan Google Ads API Team -- -- =~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~ Also find

Re: Get the creation Date of Keyword, Ad, Adgroup, etc with API

2024-04-17 Thread 'Syed Ameen Ali' via Google Ads API and AdWords API Forum
sorry, I meant creation date*. On Wednesday, April 17, 2024 at 2:01:37 PM UTC+5:30 Syed Ameen Ali wrote: > Hello, Is the creation data for AdGroups, AdGroupAd and Campaigns > available in v15 or higher? > > On Thursday, February 13, 2020 at 2:26:33 AM UTC+5:30 Google Ads API Foru

Re: no response for basic api access

2024-04-17 Thread 'VGL Group' via Google Ads API and AdWords API Forum
for clients integrations due to this issue, thanks in advance. Best Regards. On Monday, April 15, 2024 at 3:20:44 PM UTC+5:30 Google Ads API Forum Advisor wrote: > Hi, > > Thank you for reaching out to the Google Ads API support team. > > The access requests are handled by the

RE: basic access level

2024-04-17 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. After reviewing your concern, I understand that you have applied for the basic API access and you haven't received any updates on your application status. Since the access requests are handled by the Google Ads API Compliance

Re: make sure you agree to the customer data processing terms in conversion settings and try again., at conversion_adjustments[0]

2024-04-17 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
sending the upload request. Also, confirm whether you're trying to upload enhanced conversions for web or enhanced conversions for leads via the Google Ads API. This message is in relation to case "ref:!00D1U01174p.!5004Q02tOvHd:ref" (ADR-00230310) Thanks, Google Ad

[visualization-api] Unable to use https://chart.googleapis.com for generating charts

2024-04-16 Thread 'Kasturi Gottivedu Shriniwas' via Google Visualization API
this message because you are subscribed to the Google Groups "Google Visualization API" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-visualization-api+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.go

RE: how to extract segments.product_brand column

2024-04-16 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I would like to inform you that you cannot get the segments.product_brand field with the campaign, ad_group and ad_group_ad resources as they do not support it. It appears that you can get segments.product_brand field only

RE: about app campaigns conversion_cateogy

2024-04-16 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, To track conversions automatically from Google Play without adding tracking code (Android apps), you can use the fields respectively. Downloads -> GOOGLE_PLAY_DOWNLOAD In-app purchase -> GOOGLE_PLAY_IN_APP_PURCHASE Pre-registration -> ANDROID_APP_PRE_REGISTRATION The field for co

RE: update on standard level access

2024-04-16 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I notice that you've already raised this concern in another thread titled 'Update on Google Ads API : Standard Access'. We've already provided a response there regarding this issue. To streamline communication and avoid

RE: update on google ads api : standard access

2024-04-16 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. Since the access requests are handled by the Google Ads API Compliance team, we are transferring the case to the Ads API Compliance team. @Compliance team, please confirm if you are able to assist in the below access request

[PATCH] bootconfig: Fix the kerneldoc of _xbc_exit()

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Fix the kerneldoc of _xbc_exit() which is updated to have an @early argument and the function name is changed. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404150036.kpj3hefa-...@intel.com/ Signed-off-by: Masami Hiramatsu

RE: update campaign name through google ads api

2024-04-15 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. After verifying the provided logs, I could see that you have encountered the 404 error when trying to update the campaign name. and you have provided the wrong updateMask in the request. When I tried to replicate your issue

RE: field to enter developer token is missing in rest interface

2024-04-15 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. I see that your concern has already been raised on another thread with the subject "Developer token is missing in the REST interface" and we already responded there for this issue. To avoid multiple threads on the

RE: developer token is missing in the rest interface

2024-04-15 Thread 'Google Ads API Forum Advisor' via Google Ads API and AdWords API Forum
Hi, Thank you for reaching out to the Google Ads API support team. After checking the provided logs, I could see that you have encountered the " DEVELOPER_TOKEN_PARAMETER_MISSING" error. It means that developer-token parameters are required for all requests. I would sugge

Re: How to get the keyword which triggered the phone call?

2024-04-15 Thread 'Barnabe Cornilleau' via Google Ads API and AdWords API Forum
Hi, Sorry for once again reanimating an old thread. I am looking to get the keyword information linked to each tracked call (from Call Only / Call Extension ads). It is possible to get that report in the Google Ads interface but it doesn't seem doable using a GAQL API request. It seems

[PATCH v9 36/36] fgraph: Skip recording calltime/rettime if it is not nneeded

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Skip recording calltime and rettime if the fgraph_ops does not need it. This is a kind of performance optimization for fprobe. Since the fprobe user does not use these entries, recording timestamp in fgraph is just a overhead (e.g. eBPF, ftrace). So introduce

[PATCH v9 35/36] Documentation: probes: Update fprobe on function-graph tracer

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Update fprobe documentation for the new fprobe on function-graph tracer. This includes some bahvior changes and pt_regs to ftrace_regs interface change. Signed-off-by: Masami Hiramatsu (Google) --- Changes in v2: - Update @fregs parameter explanation

[PATCH v9 34/36] selftests/ftrace: Add a test case for repeating register/unregister fprobe

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) This test case repeats define and undefine the fprobe dynamic event to ensure that the fprobe does not cause any issue with such operations. Signed-off-by: Masami Hiramatsu (Google) --- .../test.d/dynevent/add_remove_fprobe_repeat.tc| 19

[PATCH v9 33/36] selftests: ftrace: Remove obsolate maxactive syntax check

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Since the fprobe event does not support maxactive anymore, stop testing the maxactive syntax error checking. Signed-off-by: Masami Hiramatsu (Google) --- .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc |4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH v9 32/36] tracing/fprobe: Remove nr_maxactive from fprobe

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Remove depercated fprobe::nr_maxactive. This involves fprobe events to rejects the maxactive number. Signed-off-by: Masami Hiramatsu (Google) --- Changes in v2: - Newly added. --- include/linux/fprobe.h |2 -- kernel/trace/trace_fprobe.c | 44

[PATCH v9 31/36] fprobe: Rewrite fprobe on function-graph tracer

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Rewrite fprobe implementation on function-graph tracer. Major API changes are: - 'nr_maxactive' field is deprecated. - This depends on CONFIG_DYNAMIC_FTRACE_WITH_ARGS or !CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and CONFIG_HAVE_FUNCTION_GRAPH_FREGS. So

[PATCH v9 30/36] ftrace: Add CONFIG_HAVE_FTRACE_GRAPH_FUNC

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Add CONFIG_HAVE_FTRACE_GRAPH_FUNC kconfig in addition to ftrace_graph_func macro check. This is for the other feature (e.g. FPROBE) which requires to access ftrace_regs from fgraph_ops::entryfunc() can avoid compiling if the fgraph can not pass the valid

[PATCH v9 29/36] bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Enable kprobe_multi feature if CONFIG_FPROBE is enabled. The pt_regs is converted from ftrace_regs by ftrace_partial_regs(), thus some registers may always returns 0. But it should be enough for function entry (access arguments) and exit (access return value

[PATCH v9 28/36] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Allow fprobe events to be enabled with CONFIG_DYNAMIC_FTRACE_WITH_ARGS. With this change, fprobe events mostly use ftrace_regs instead of pt_regs. Note that if the arch doesn't enable HAVE_PT_REGS_COMPAT_FTRACE_REGS, fprobe events will not be able to be used from

[PATCH v9 27/36] tracing: Add ftrace_fill_perf_regs() for perf event

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Add ftrace_fill_perf_regs() which should be compatible with the perf_fetch_caller_regs(). In other words, the pt_regs returned from the ftrace_fill_perf_regs() must satisfy 'user_mode(regs) == false' and can be used for stack tracing. Signed-off-by: Masami

[PATCH v9 26/36] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Add ftrace_partial_regs() which converts the ftrace_regs to pt_regs. This is for the eBPF which needs this to keep the same pt_regs interface to access registers. Thus when replacing the pt_regs with ftrace_regs in fprobes (which is used by kprobe_multi eBPF event

[PATCH v9 25/36] fprobe: Use ftrace_regs in fprobe exit handler

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) Change the fprobe exit handler to use ftrace_regs structure instead of pt_regs. This also introduce HAVE_PT_REGS_TO_FTRACE_REGS_CAST which means the ftrace_regs's memory layout is equal to the pt_regs so that those are able to cast. Fprobe introduces a new

[PATCH v9 24/36] fprobe: Use ftrace_regs in fprobe entry handler

2024-04-15 Thread Masami Hiramatsu (Google)
From: Masami Hiramatsu (Google) This allows fprobes to be available with CONFIG_DYNAMIC_FTRACE_WITH_ARGS instead of CONFIG_DYNAMIC_FTRACE_WITH_REGS, then we can enable fprobe on arm64. Signed-off-by: Masami Hiramatsu (Google) Acked-by: Florent Revest --- Changes in v6: - Keep using

  1   2   3   4   5   6   7   8   9   10   >